Re: Windows patches for the next release

2013-10-06 Thread Paul Smith
On Sun, 2013-10-06 at 05:52 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Cc: Denis Excoffier , > > bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org > > Date: Sat, 05 Oct 2013 20:05:03 -0400 > > > > > > However, output-sync, recursion, MAKE remain. Included work.tar.xz

Re: Windows patches for the next release

2013-10-05 Thread Eli Zaretskii
> From: Paul Smith > Cc: Denis Excoffier , > bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org > Date: Sat, 05 Oct 2013 20:05:03 -0400 > > > > However, output-sync, recursion, MAKE remain. Included work.tar.xz > > > > All of those failures are because of the exact form of $(M

Re: Windows patches for the next release

2013-10-05 Thread Paul Smith
On Wed, 2013-10-02 at 19:17 +0300, Eli Zaretskii wrote: > > Date: Wed, 02 Oct 2013 09:34:06 +0200 > > From: Denis Excoffier > > Cc: , , , > > > > > > The abspath error is gone. > > Thanks for testing, I will commit the changes soon. > > > However, output-sync, recursion, MAKE remain. Include

Re: Windows patches for the next release

2013-10-03 Thread Eli Zaretskii
> Date: Fri, 4 Oct 2013 01:06:58 -0400 > From: Christopher Faylor > > >> I'm not sure it's correct to consider \a to be an absolute path in the > >> same way that /a is since they mean different things to Cygwin but I > >> guess that's not something that I have to worry about. > > > >I thought ab

Re: Windows patches for the next release

2013-10-03 Thread Christopher Faylor
On Thu, Oct 03, 2013 at 07:05:42PM +0300, Eli Zaretskii wrote: >> Date: Thu, 3 Oct 2013 01:23:15 -0400 >> From: Christopher Faylor >> >> >@@ -2001,13 +2005,17 @@ abspath (const char *name, char *apath) >> > } >> > else >> > { >> >+#ifdef __CYGWIN__ >> >+ if (STOP_SET (name[0], MAP_

Re: Windows patches for the next release

2013-10-03 Thread Eli Zaretskii
> Date: Thu, 3 Oct 2013 01:23:15 -0400 > From: Christopher Faylor > > >@@ -2001,13 +2005,17 @@ abspath (const char *name, char *apath) > > } > > else > > { > >+#ifdef __CYGWIN__ > >+ if (STOP_SET (name[0], MAP_PATHSEP)) > >+root_len = 1; > >+#endif > > I've eyeballed the patch

Re: Windows patches for the next release

2013-10-02 Thread Christopher Faylor
On Tue, Oct 01, 2013 at 07:52:02PM +0300, Eli Zaretskii wrote: >> From: Paul Smith >> Cc: bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org >> Date: Tue, 01 Oct 2013 01:08:32 -0400 >> >> On Mon, 2013-09-30 at 18:15 +0300, Eli Zaretskii wrote: >> > I suggest another RC, I think th

Re: Windows patches for the next release

2013-10-02 Thread Eli Zaretskii
> Date: Wed, 02 Oct 2013 19:17:58 +0300 > From: Eli Zaretskii > Cc: make-w32@gnu.org, bug-...@denis-excoffier.org, pavel_fe...@mail.ru > > > Date: Wed, 02 Oct 2013 09:34:06 +0200 > > From: Denis Excoffier > > Cc: , , , > > > > > > The abspath error is gone. > > Thanks for testing, I will com

Re: Windows patches for the next release

2013-10-02 Thread Eli Zaretskii
> Date: Wed, 02 Oct 2013 09:34:06 +0200 > From: Denis Excoffier > Cc: , , , > > > The abspath error is gone. Thanks for testing, I will commit the changes soon. > However, output-sync, recursion, MAKE remain. Included work.tar.xz All of those failures are because of the exact form of $(MAKE

Re: Windows patches for the next release

2013-10-02 Thread Denis Excoffier
On 2013-10-01 18:52, Eli Zaretskii wrote: Here's the patch for $abspath that should fix the Cygwin build. Would Cygwin people please test it, and in particular see if the related failures in the test suite are gone? I don't have a Cygwin environment to even compile with Cygwin. The abspath

Re: Windows patches for the next release

2013-10-02 Thread Denis Excoffier
On 2013-10-02 09:34, Denis Excoffier wrote: The abspath error is gone. However, output-sync, recursion, MAKE remain. Included work.tar.xz I can also observe that with the following patch (below), make check runs with no error anymore (of course, this patch is not for inclusion in HEAD). % cat

Re: Windows patches for the next release

2013-10-01 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org > Date: Tue, 01 Oct 2013 13:37:36 -0400 > > On Tue, 2013-10-01 at 19:52 +0300, Eli Zaretskii wrote: > > Btw, Paul: I see that the sources don't consistently use STOP_SET > > where characters are tested for

Re: Windows patches for the next release

2013-10-01 Thread Paul Smith
On Tue, 2013-10-01 at 19:52 +0300, Eli Zaretskii wrote: > Btw, Paul: I see that the sources don't consistently use STOP_SET > where characters are tested for being directory separators; sometimes > they actually test for both slashes and backslashes. Should we fix > that throughout the sources? S

Re: Windows patches for the next release

2013-10-01 Thread Eli Zaretskii
> From: Paul Smith > Cc: Denis Excoffier , Pavel Fedin > , Chris Faylor > , make-w32@gnu.org > Date: Mon, 30 Sep 2013 08:47:39 -0400 > > abspath / DOS paths fix I posted a patch for this. Let's hope some Cygwin user will be able to test it soon. > Also, from Savannah: > > https://savannah.

Re: Windows patches for the next release

2013-10-01 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org > Date: Tue, 01 Oct 2013 01:08:32 -0400 > > On Mon, 2013-09-30 at 18:15 +0300, Eli Zaretskii wrote: > > I suggest another RC, I think the changes since the last one are > > non-trivial. > > OK, I created

Re: Windows patches for the next release

2013-09-30 Thread Paul Smith
On Mon, 2013-09-30 at 18:15 +0300, Eli Zaretskii wrote: > I suggest another RC, I think the changes since the last one are > non-trivial. OK, I created a new RC, available now on make-alpha. I don't personally plan to make any more changes, so as soon as you feel you're happy with the Windows sup

Re: Windows patches for the next release

2013-09-30 Thread Eli Zaretskii
> From: Paul Smith > Cc: Denis Excoffier , Pavel Fedin > , Chris Faylor > , make-w32@gnu.org > Date: Mon, 30 Sep 2013 08:47:39 -0400 > > There are some decisions to be made on outstanding Windows patches. > Other than these I believe the next release is ready to go... not > everything is fixed

Windows patches for the next release

2013-09-30 Thread Paul Smith
Hi all; There are some decisions to be made on outstanding Windows patches. Other than these I believe the next release is ready to go... not everything is fixed but at some point you have to pull the trigger. I'm willing to apply the ones that are appropriate, but need some guidance from Eli. A