Re: [matplotlib-devel] MEP22 doc

2014-01-29 Thread Federico Ariza
@tacaswell I have been thinking about what we discussed last time. Again, sorry for the long email Locks: I reduced the number of locks to 2. This is what navigation actually uses,: * keypress: to know if it can process the keypress * message: to know if it can print stuff to the message area. R

Re: [matplotlib-devel] MEP22 doc

2014-01-28 Thread Federico Ariza
The idea to pass the reference of the tool, is just to have a collection of instantiable classes. This allows me to create the toolbar and keymap with their class attributes without instantiating the classes. And leave the __init__ method available for more important things, as window creation and

Re: [matplotlib-devel] MEP22 doc

2014-01-28 Thread Thomas Caswell
On Tue, Jan 28, 2014 at 7:27 PM, Federico Ariza wrote: > activate: I agree with you, renamed to trigger > > [I don't understand. The `__init__` gets called when the tool object > is created (and it gets registered with a particular > `NavigationBase`/`Figure`/`canvas`. The tool object then sits a

Re: [matplotlib-devel] MEP22 doc

2014-01-28 Thread Federico Ariza
@tacaswell regarding your last comments on the wiki Again, please let me know if something is not clear or you have suggestions Again, sorry for the long email, but please don't forget the previous one about the locks. activate: I agree with you, renamed to trigger [I don't understand. The

Re: [matplotlib-devel] MEP22 doc

2014-01-28 Thread Federico Ariza
Hello again I have been playing with the locks to find a solution. What we need is a way to let tools absorb the events (lock its use). The problem that I'm facing is that Navigation itself needs to capture two different events. key_press_event for tool triggering motion_notify_event for setting

Re: [matplotlib-devel] MEP22 doc

2014-01-28 Thread Federico Ariza
@tacaswell I modified the wiki reflecting the changes and trying to answer the questions. Please let me know if I answered your questions/concerns. We can iterate as muchs as needed on this, I have no problem modifying the names or functionnality. Sorry for the long email Here a list of things tha

Re: [matplotlib-devel] MEP22 doc

2014-01-27 Thread Thomas A Caswell
I left some comments on the wiki (in []). Not sure what the best way to leave comments is. On Mon, Jan 27, 2014 at 5:04 PM, Federico Ariza wrote: > Hello everybody > > I just added "click_tool" to simulate a click programatically. > https://github.com/matplotlib/matplotlib/pull/2759 > > Is ther

Re: [matplotlib-devel] MEP22 doc

2014-01-27 Thread Federico Ariza
Hello everybody I just added "click_tool" to simulate a click programatically. https://github.com/matplotlib/matplotlib/pull/2759 Is there anything missing or that you want to change? I'm saturated so I don't see anything anymore. I would like to have some input specially in the `ToolbarBase` c

Re: [matplotlib-devel] MEP22 doc

2014-01-27 Thread Phil Elson
Hi Federico, I just wanted to say that I've been a little busy lately, but your MEP is really shaping up - I really like the concepts that are being proposed and think it will make a huge difference to people who want to implement custom UIs. Keep up the great work, and continue trying to get fee

[matplotlib-devel] MEP22 doc

2014-01-24 Thread Federico Ariza
Hello everybody I just added some documentation for the MEP22 new classes and methods. Please take a look https://github.com/matplotlib/matplotlib/pull/2759 I ran into some problems, when trying to decide if some methods where public or not. If the method was used only for backend implementation