BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/406015 )
Change subject: Hygiene: fix diff tests
..
Hygiene: fix diff tests
mw-redirect classes were added to a few links.
Change-Id: Ife970e33459b6
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405351 )
Change subject: Hygiene: fix jsdoc in extractLeadIntroduction
..
Hygiene: fix jsdoc in extractLeadIntroduction
Change-Id: I1268821bfcf654702
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405350 )
Change subject: Use underscore's implementation of escape
..
Use underscore's implementation of escape
The underscore implementation handles
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405317 )
Change subject: WIP: Get ready for Parsoid change of references wrappers
..
WIP: Get ready for Parsoid change of references wrappers
Parsoid
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405243 )
Change subject: Hygiene: update unit tests: refs changed from span to sup
..
Hygiene: update unit tests: refs changed from span to sup
Updat
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405242 )
Change subject: Hygiene: remove unused addSectionTags for the section case
..
Hygiene: remove unused addSectionTags for the section case
Thi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405241 )
Change subject: Include H1 heading tags to old section parsing
..
Include H1 heading tags to old section parsing
While not encouraged, pages
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405239 )
Change subject: Dev: debug log for MW API requests when debug is true in config
..
Dev: debug log for MW API requests when debug is true in c
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405240 )
Change subject: Dev: debug log for RESTBase requests, too
..
Dev: debug log for RESTBase requests, too
Change-Id: I2cb1d4299a15c87274544f2dc
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405234 )
Change subject: Hygiene: Update diff results for -wrapped references, part
2
..
Hygiene: Update diff results for -wrapped references, part 2
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405210 )
Change subject: Dev: Make sure we tag the correct commit in the src repo
..
Dev: Make sure we tag the correct commit in the src repo
Get the
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404744 )
Change subject: Hygiene: fix api-util-test
..
Hygiene: fix api-util-test
Should not have reused the list between tests.
Bug: T182738
Change
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404742 )
Change subject: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test
run
..
Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for u
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404622 )
Change subject: Skip beta cluster test
..
Skip beta cluster test
Beta cluster API is having some issues:
PHP fatal error: Stack overflow
Ch
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404514 )
Change subject: summary: reorder summarizer transforms
..
summary: reorder summarizer transforms
Doing the regex manipulations first, then t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404515 )
Change subject: summary: skip removing data-mw attributes
..
summary: skip removing data-mw attributes
Skip removing data-mw attributes in t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404510 )
Change subject: summary: fix mainpage handling
..
summary: fix mainpage handling
The issue was that several non-English main pages are not i
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404509 )
Change subject: Hygiene: extract method for when to return 204
..
Hygiene: extract method for when to return 204
Change-Id: I97a3464f5f9f1ec
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404496 )
Change subject: Also keep style attributes when flattening elements
..
Also keep style attributes when flattening elements
See comment https
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404245 )
Change subject: Hygiene: move summary library functions to own lib file
..
Hygiene: move summary library functions to own lib file
There wer
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404248 )
Change subject: summary: inline 204 checks
..
summary: inline 204 checks
The three checks for when to return 204 are simple enough that we c
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404247 )
Change subject: summary: just parse the lead section
..
summary: just parse the lead section
No need to try to parse other sections for the
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404246 )
Change subject: Initial streamlining getting the summary HTML
..
Initial streamlining getting the summary HTML
* Replace pageJsonPromise wit
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404242 )
Change subject: Hygiene: remove extraneous disambig code
..
Hygiene: remove extraneous disambig code
The disambig flag gets determined insid
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404244 )
Change subject: Hygiene: move summary route to own file
..
Hygiene: move summary route to own file
Change-Id: I3f1c11331d4b1ecbc19fa6d5b1a03
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404243 )
Change subject: Hygiene: inline the summary call to _collectRawPageData
..
Hygiene: inline the summary call to _collectRawPageData
This make
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404241 )
Change subject: Hygiene: add more summary tests
..
Hygiene: add more summary tests
Change-Id: I245cb3b3715cb67b7c589f42079f34203c25d32d
---
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403977 )
Change subject: Flatten DOM anchors if no attributes kept
..
Flatten DOM anchors if no attributes kept
The flattenElements method previously
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403882 )
Change subject: Summary: flattened anchors stay anchors
..
Summary: flattened anchors stay anchors
We can remove the flattenElements call fo
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403880 )
Change subject: Summary: update regex for non-ASCII parentheses
..
Summary: update regex for non-ASCII parentheses
The previous version crea
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403881 )
Change subject: Summary: update regex for finding parentheticals
..
Summary: update regex for finding parentheticals
For the latin character
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403770 )
Change subject: Fix another lint issue
..
Fix another lint issue
I ran into these when trying to commit my patches. I run the pre-commit
hoo
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403725 )
Change subject: WIP: Remove parentheses using state machine instead of regex
..
WIP: Remove parentheses using state machine instead of regex
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403578 )
Change subject: Fix lint issues
..
Fix lint issues
Change-Id: I5dbf10b3479856a9e35d2fa32895373f63b577f4
---
M test/lib/mobile-util/mobile-ut
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403568 )
Change subject: Remove unwanted nodes and attributes from summary
..
Remove unwanted nodes and attributes from summary
Bug: T184557
Change-I
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402984 )
Change subject: Update mobileapps to d20915c
..
Update mobileapps to d20915c
List of changes:
94845db Show MW API requests when debug is tru
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402914 )
Change subject: Add revision and tid to references output
..
Add revision and tid to references output
Bug: T184328
Change-Id: I6b055ccc09f3
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402913 )
Change subject: Hygiene: extract references endpoint into new module
..
Hygiene: extract references endpoint into new module
Also fixed/clar
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402891 )
Change subject: Show MW API requests when env var DEBUG_MW_REQUESTS is set
..
Show MW API requests when env var DEBUG_MW_REQUESTS is set
Eve
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402129 )
Change subject: Show MW API requests when debug is true
..
Show MW API requests when debug is true
To make it easier to debug backend reques
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402096 )
Change subject: Update mobileapps to a4ba9fd
..
Update mobileapps to a4ba9fd
List of changes:
29fd37f References: add specific version numbe
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402083 )
Change subject: News: don't include empty stories
..
News: don't include empty stories
Bug: T184198
Change-Id: Ia2e7c4cc61cbb99e2fa0f5af355b
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402077 )
Change subject: Temporarily skip testing of French news.
..
Temporarily skip testing of French news.
Will add a separate patch to fix adding
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402074 )
Change subject: random: fail early when MW API response has no query.pages
..
random: fail early when MW API response has no query.pages
Sta
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398304 )
Change subject: Update mobileapps to ff74bb1
..
Update mobileapps to ff74bb1
List of changes:
96eab05 Revert "Revert "Update section validat
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398300 )
Change subject: Bump onthisday version
..
Bump onthisday version
... since we fixed the section heading id selector strings,
see previous co
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398268 )
Change subject: Fix onthisday entries from day pages
..
Fix onthisday entries from day pages
Since HTML5 section ids were deployed,
onthisda
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398254 )
Change subject: Automatically end announcements after configured endTime
..
Automatically end announcements after configured endTime
No need
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398184 )
Change subject: Add unit test for logging the warning if section validation
fails
..
Add unit test for logging the warning if section valida
Hello jenkins-bot, Mholloway,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/398183
to review the following change.
Change subject: Revert "Revert "Update section validation logic""
..
Reve
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398085 )
Change subject: Skip some tests because of upstream issues
..
Skip some tests because of upstream issues
This is related to T182770.
Change
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398080 )
Change subject: Adjust end time for fundraising announcements
..
Adjust end time for fundraising announcements
New end date it is December 2
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397961 )
Change subject: Bump onthisday version.
..
Bump onthisday version.
Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
---
M lib/mobile-uti
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397928 )
Change subject: Fix onthisday with section tags
..
Fix onthisday with section tags
Onthisday was looking for direct children of body to look
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397867 )
Change subject: References: citation type
..
References: citation type
Instead of an citations array we return a single value in the type
fi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397737 )
Change subject: References: back_link as object
..
References: back_link as object
Instead of a single string a backlink is now an object wi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397640 )
Change subject: References: add specific version number
..
References: add specific version number
This will be part of PCS.
Change-Id: I2f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397633 )
Change subject: Bump mobile-sections and definitions version
..
Bump mobile-sections and definitions version
to hopefully follow shortly aft
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/396428 )
Change subject: WIP: Dev: Replace Sepia with Replayer
..
WIP: Dev: Replace Sepia with Replayer
Unfortunately the Sepia project seems abandon
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/396297 )
Change subject: Bring back Sepia request caching
..
Bring back Sepia request caching
The key is to require sepia. This line got somehow dele
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395849 )
Change subject: Version number for the media endpoint
..
Version number for the media endpoint
Bug: T177430
Change-Id: I426d97e2c36b0071bc3a
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394522 )
Change subject: tag-deploy: push only the created tag
..
tag-deploy: push only the created tag
git push --tags would push any local tags mis
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394479 )
Change subject: Update mobileapps to 4317ea5
..
Update mobileapps to 4317ea5
List of changes:
dad2788 Add figure-inline transformation
ffe7f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394243 )
Change subject: Add figure-inline transformation
..
Add figure-inline transformation
Parsoid is going to change some img wrapper DOM element
BearND has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394227 )
Change subject: Update mobileapps to dcea7d3
..
Update mobileapps to dcea7d3
List of changes:
e5b73f3 Add .nsprc and update dependen
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394227 )
Change subject: Update mobileapps to dcea7d3
..
Update mobileapps to dcea7d3
List of changes:
e5b73f3 Add .nsprc and update dependencies to
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394205 )
Change subject: Tweak Big English fundraiser copy and start time again
..
Tweak Big English fundraiser copy and start time again
Updated sta
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394152 )
Change subject: Tweak Big English fundraiser copy some more
..
Tweak Big English fundraiser copy some more
Removed the extra "Privacy discla
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394107 )
Change subject: Tweak Big English fundraiser copy
..
Tweak Big English fundraiser copy
Now with double the line breaks and updated button la
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394013 )
Change subject: Big English fundraiser announcements
..
Big English fundraiser announcements
For the Big English fundraiser we need to have
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391157 )
Change subject: featured-image: better diagnostics in error case
..
featured-image: better diagnostics in error case
We don't want to have t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390545 )
Change subject: Hygiene: update simple node dependencies
..
Hygiene: update simple node dependencies
This is more to document the node depen
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390544 )
Change subject: Update node-rdkafka dependency to 1.x
..
Update node-rdkafka dependency to 1.x
Bug: T179786
Change-Id: If613179f95fbb2277be4
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390546 )
Change subject: Update node-rdkafka dependency to 2.x
..
Update node-rdkafka dependency to 2.x
Breaking Changes mentioned for 2.0.0 release[
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390096 )
Change subject: Update mobileapps to 8e82983
..
Update mobileapps to 8e82983
List of changes:
ad0b15a Exclude properties only needed for sum
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390068 )
Change subject: Update mobileapps to e86fb6c
..
Update mobileapps to e86fb6c
List of changes:
0492af8 Remove unnecessary API call in unit te
Hello Mobrovac, GWicke, Fjalapeno, Ppchelko, Mhurd, jenkins-bot, Jdlrobson,
Mholloway,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/390047
to review the following change.
Change subject: Revert "Add canonical title to mobile-sections lead"
...
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389643 )
Change subject: Hygiene: preserve response objects throughout special handling
..
Hygiene: preserve response objects throughout special handl
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389644 )
Change subject: Add canonical title to mobile-sections lead
..
Add canonical title to mobile-sections lead
Bug: T179600
Change-Id: I003b491c
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387828 )
Change subject: Hygiene: replace data-section-number with data-mw-section-id
..
Hygiene: replace data-section-number with data-mw-section-id
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387295 )
Change subject: Improve Parsoid section detection
..
Improve Parsoid section detection
Replaces individual implementations with a common fun
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387294 )
Change subject: Hygiene: rename parsoid-sections-test
..
Hygiene: rename parsoid-sections-test
Change-Id: I0bb5a3393f352876addb1f57235c2c863
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386336 )
Change subject: Next gen definitions parsing, using section tags
..
Next gen definitions parsing, using section tags
Prep definitions parsin
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386334 )
Change subject: Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs
..
Hygiene: rename parseDefinitions to parseDefinitionsUsingDiv
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386335 )
Change subject: Hygiene: split up definitions parsing into two implementations
..
Hygiene: split up definitions parsing into two implementati
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386268 )
Change subject: Revert "Add fundraising test via announcement cards in France"
..
Revert "Add fundraising test via announcement cards in Fran
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386045 )
Change subject: Update mobileapps to 3628105
..
Update mobileapps to 3628105
List of changes:
c330b3f Summary 2.0: Introduce namespace white
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385425 )
Change subject: Rewrite sectioning using section tags code
..
Rewrite sectioning using section tags code
For mobile-sections we only care ab
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385424 )
Change subject: Fail incomplete sections early
..
Fail incomplete sections early
To avoid issues with incomplete sections, which let to T175
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385422 )
Change subject: Get section number from Parsoid
..
Get section number from Parsoid
* Get section number from Parsoid's section element data-
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385423 )
Change subject: Hygiene: add tests for new Parsoid section elements
..
Hygiene: add tests for new Parsoid section elements
To prepare for T1
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385420 )
Change subject: Hygiene: create script to compare old and new sectioning code
..
Hygiene: create script to compare old and new sectioning cod
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385419 )
Change subject: Hygiene: add tmp folder to eslintignore
..
Hygiene: add tmp folder to eslintignore
Change-Id: I77f5fb80ffda11c1fcafe5113d6a8
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383648 )
Change subject: Update mobileapps to c045afc
..
Update mobileapps to c045afc
List of changes:
6b7a264 Account for instead of for inline fi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382875 )
Change subject: Hygiene: simplify assert.closeTo and assert.contains
..
Hygiene: simplify assert.closeTo and assert.contains
This is to make
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382877 )
Change subject: Fix Portuguese news selector
..
Fix Portuguese news selector
The old version of the CSS selector for ptwiki news stories res
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382876 )
Change subject: Hygiene: simplify assertions in onthisday test
..
Hygiene: simplify assertions in onthisday test
This is to make failure out
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382878 )
Change subject: Hygiene: Update test fixtures
..
Hygiene: Update test fixtures
This is for news, onthisday, and a general test page.
This ia
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382628 )
Change subject: Hygiene: update diff test results
..
Hygiene: update diff test results
The Frankenstein test page has been protected.
Chang
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382073 )
Change subject: Update mobileapps to 5dc0c02
..
Update mobileapps to 5dc0c02
List of changes:
7139e27 Add featured feed In the news entry fo
1 - 100 of 1043 matches
Mail list logo