Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393851 )
Change subject: Reimplementing MobileOptions in OOUI
..
Reimplementing MobileOptions in OOUI
Special:MobileOptions is completely
written
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393833 )
Change subject: Fix broken QUnit test
..
Fix broken QUnit test
Correct some options names and make minor adjustments to the
constructor
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393651 )
Change subject: Clear spinner after window.print
..
Clear spinner after window.print
Looks like window.print may block so keep the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393649 )
Change subject: Use Html messageBox helpers
..
Use Html messageBox helpers
These helper methods are now upstreamed into core
(see
Hello Pmiazga, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/393644
to review the following change.
Change subject: Revert "Use Html messageBox helpers"
..
Revert "Use Html
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393642 )
Change subject: Run QUnit tests on Minerva skin non-experimental
..
Run QUnit tests on Minerva skin non-experimental
Bug: T181429
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392890 )
Change subject: Hygiene: Refactor Minerva history link generation
..
Hygiene: Refactor Minerva history link generation
* Create several
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392529 )
Change subject: Update the service template to 0.5.3
..
Update the service template to 0.5.3
This updates to the latest version of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391986 )
Change subject: WIP: Fix eslint warnings
..
WIP: Fix eslint warnings
Bug: T151395
Change-Id: I718800cfc99a682986a4fb4faa0a4bbe1368a27a
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391977 )
Change subject: If timestamp is null load revision time
..
If timestamp is null load revision time
Passing null to wfTimestamp will
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391974 )
Change subject: Show last modified bar without relative time for old revisions
..
Show last modified bar without relative time for old
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391944 )
Change subject: Restore the message box styles on old revisions
..
Restore the message box styles on old revisions
While looking at this
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391711 )
Change subject: Load all images during print action
..
Load all images during print action
When the print button is clicked, load all
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391710 )
Change subject: Provide capabilities in Skin to load all images in page
..
Provide capabilities in Skin to load all images in page
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391626 )
Change subject: Add unit tests for Html helper methods and change messageBox
visibility
..
Add unit tests for Html helper methods and
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391615 )
Change subject: Disable EventLogging for popups
..
Disable EventLogging for popups
Bug: T178500
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391143 )
Change subject: POC: Reimplementing MobileOptions in OOUI
..
POC: Reimplementing MobileOptions in OOUI
To tease out the complexity I had
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391142 )
Change subject: Use Html messageBox helpers
..
Use Html messageBox helpers
These helper methods are now upstreamed into core
(see
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391056 )
Change subject: Do not center align h2s in footer
..
Do not center align h2s in footer
In Id9b0e955d6e2a113f91484c7ee6bbc9275e3a2ec the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391055 )
Change subject: Restrict footer styles to skin footer
..
Restrict footer styles to skin footer
The Popups extension uses a footer
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391041 )
Change subject: Enable the download icon on all wikis
..
Enable the download icon on all wikis
Bug: T179914
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391040 )
Change subject: Limit download button to Google Chrome
..
Limit download button to Google Chrome
As discussed on ticket the download
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390344 )
Change subject: Avoid notices due to undefined indexes
..
Avoid notices due to undefined indexes
* Fix issue due to lack of any kind of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389790 )
Change subject: Do not try to add edit links to the HTML in contexts without a
Title
..
Do not try to add edit links to the HTML in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389747 )
Change subject: Limit download button to Google Chrome
..
Limit download button to Google Chrome
As discussed on ticket the download
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388133 )
Change subject: Print styles in Vector are no longer feature flagged
..
Print styles in Vector are no longer feature flagged
Remove
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388132 )
Change subject: Switch to outside list style
..
Switch to outside list style
Bug: T150377
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388127 )
Change subject: [labs] Unconditionally enable popups for anonymous users on
beta cluster
..
[labs] Unconditionally enable popups for
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388083 )
Change subject: Event name has changed
..
Event name has changed
The beta opt in panel since the Minerva/MobileFrontend split and
follow
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388082 )
Change subject: Inform other extensions that the beta opt in panel has been
shown
..
Inform other extensions that the beta opt in panel
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387965 )
Change subject: Hyiene: Move css rule to Minerva
..
Hyiene: Move css rule to Minerva
In preparation for "Adopt new special page template
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387964 )
Change subject: Hygiene: Move css rule to Minerva
..
Hygiene: Move css rule to Minerva
In preparation for "Adopt new special page
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387961 )
Change subject: Hygiene: Make usages of mw.user clearer
..
Hygiene: Make usages of mw.user clearer
Bug: T172454
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387841 )
Change subject: Reveal edit icon and style top level headings on desktop Minerva
..
Reveal edit icon and style top level headings on
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387839 )
Change subject: Hygiene: Remove dead call to addModuleStyles
..
Hygiene: Remove dead call to addModuleStyles
This is adding an empty
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387835 )
Change subject: Style kbd and samp elements as monospace
..
Style kbd and samp elements as monospace
Bug: T175709
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387751 )
Change subject: Update gadget warning to mention global gadgets
..
Update gadget warning to mention global gadgets
Bug: T178566
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387646 )
Change subject: Hygiene: Default placeholderMsg is no longer needed.
..
Hygiene: Default placeholderMsg is no longer needed.
This is
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387639 )
Change subject: Hygiene: Minerva explicitly defines placeholderMsg for
SearchOverlay
..
Hygiene: Minerva explicitly defines
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387635 )
Change subject: Hygiene: Test is in wrong folder and not being run
..
Hygiene: Test is in wrong folder and not being run
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387504 )
Change subject: Do not break edit links on non-mobile formatted pages
..
Do not break edit links on non-mobile formatted pages
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387503 )
Change subject: Add mobile-formatted class to MobileFormatted content
..
Add mobile-formatted class to MobileFormatted content
This will
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387501 )
Change subject: Hide table of contents temporarily on Minerva desktop
..
Hide table of contents temporarily on Minerva desktop
Currently
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387496 )
Change subject: Hash change should reveal hidden content
..
Hash change should reveal hidden content
Bug: T141452
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387361 )
Change subject: Hygiene: Fix svgo version to 0.4.4
..
Hygiene: Fix svgo version to 0.4.4
There was an svgo release an hour ago (1.0.0)
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386917 )
Change subject: Hygiene: PointerOverlay now belongs to Minerva
..
Hygiene: PointerOverlay now belongs to Minerva
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386919 )
Change subject: Hygiene: Merge notification modules
..
Hygiene: Merge notification modules
It makes sense for callers to load both the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386916 )
Change subject: Rename mobile.patrol.ajax
..
Rename mobile.patrol.ajax
mobile.patrol.ajax is a module that initialises a special page.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386920 )
Change subject: Font changing is a "mobile" feature, not "minerva" feature
..
Font changing is a "mobile" feature, not "minerva" feature
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386923 )
Change subject: WIP: Toggling code needs to belong to MobileFrontend
..
WIP: Toggling code needs to belong to MobileFrontend
TODO: This
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386922 )
Change subject: Remove the mobile.betaoptin module
..
Remove the mobile.betaoptin module
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386918 )
Change subject: Hygiene: Merge mobile.abusefilter modules into
mobile.editor.common
..
Hygiene: Merge mobile.abusefilter modules into
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386921 )
Change subject: Betaoptin widget managed by MobileFrontend
..
Betaoptin widget managed by MobileFrontend
The beta opt in widget should
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386913 )
Change subject: Hygiene: Minera owns PointerOverlay
..
Hygiene: Minera owns PointerOverlay
The only usage is inside Minerva so we will
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386915 )
Change subject: BetaOptin now managed by MobileFrontend
..
BetaOptin now managed by MobileFrontend
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386914 )
Change subject: Remove MobileFrontend code from Minerva
..
Remove MobileFrontend code from Minerva
Fontchanger code now runs on all
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386704 )
Change subject: Back to top is now owned by Minerva skin
..
Back to top is now owned by Minerva skin
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386702 )
Change subject: Minerva owns BacktoTopOverlay
..
Minerva owns BacktoTopOverlay
Not used in MobileFrontend so it is moved here from that
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386030 )
Change subject: Remove unnecessary API call in unit test
..
Remove unnecessary API call in unit test
We do not need to hit the API in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385440 )
Change subject: Clear any floats before the print footer
..
Clear any floats before the print footer
Bug: T178656
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385433 )
Change subject: Disable print button on iOS
..
Disable print button on iOS
As documented on the ticket, iOS does not provide pdf
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385095 )
Change subject: Add feature flagged DownloadIcon
..
Add feature flagged DownloadIcon
Shortcut for print. Disabled by default and
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385016 )
Change subject: Notification icon should not show NaN for persian Wikipedia
..
Notification icon should not show NaN for persian
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385007 )
Change subject: Use correct name for gadgets popup on itwiki
..
Use correct name for gadgets popup on itwiki
Bug: T178438
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385005 )
Change subject: Disable special page usage until further notice
..
Disable special page usage until further notice
Provide placeholder
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384903 )
Change subject: Disable special page usage until further notice
..
Disable special page usage until further notice
Provide placeholder
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384621 )
Change subject: Remove indent from the notification overlay header
..
Remove indent from the notification overlay header
This overlay is
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384601 )
Change subject: Disable special page usage until further notice
..
Disable special page usage until further notice
Provide placeholder
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384600 )
Change subject: Remove popups from critical rendering path
..
Remove popups from critical rendering path
Instead load it via
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383941 )
Change subject: Handle and debug case where API returns no pages
..
Handle and debug case where API returns no pages
Bug: T177988
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383940 )
Change subject: Installer should make use of valid skin names
..
Installer should make use of valid skin names
Bug: T178118
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383934 )
Change subject: Drop beta feature step testing in browser tests
..
Drop beta feature step testing in browser tests
Page previews is
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383724 )
Change subject: Tablet modules no longer managed by MobileFrontend
..
Tablet modules no longer managed by MobileFrontend
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383720 )
Change subject: Minerva is responsible for loading tablet modules in tablet mode
..
Minerva is responsible for loading tablet modules in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383718 )
Change subject: Use https for browser test environment
..
Use https for browser test environment
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383715 )
Change subject: Page is optional for Toggler constructor
..
Page is optional for Toggler constructor
According to the function signature
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383706 )
Change subject: Print logo should use an absolute URI
..
Print logo should use an absolute URI
The logo is configured as a relative URL.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383705 )
Change subject: Do not include @nomin instruction in dist build
..
Do not include @nomin instruction in dist build
When bundled by
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383645 )
Change subject: Print logo should use an absolute URI
..
Print logo should use an absolute URI
The logo is configured as a relative URL.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383491 )
Change subject: Enable Vector print logo and print styles on all wikis
..
Enable Vector print logo and print styles on all wikis
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383487 )
Change subject: Expand relative URL - CSSMin needs absolute url
..
Expand relative URL - CSSMin needs absolute url
The logo is
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383481 )
Change subject: Fix table of contents font-size
..
Fix table of contents font-size
Bug: T177892
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383476 )
Change subject: WIP: Add tests for the fixTemplateData method
..
WIP: Add tests for the fixTemplateData method
The previous patch
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383412 )
Change subject: Deal with extreme of an empty book
..
Deal with extreme of an empty book
This edge case currently throws an exception.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383411 )
Change subject: Restore table of content generation tests
..
Restore table of content generation tests
Bug: T175856
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383391 )
Change subject: Don't request render if renderer not configured
..
Don't request render if renderer not configured
If
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383390 )
Change subject: Enable Vector print logo on test wiki
..
Enable Vector print logo on test wiki
Bug: T177800
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383378 )
Change subject: pagePreviews: Restart A/B test on enwiki and dewiki
..
pagePreviews: Restart A/B test on enwiki and dewiki
Bug: T176469
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383287 )
Change subject: Stop testing chapter generation in templates
..
Stop testing chapter generation in templates
The outline was exposed on
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383285 )
Change subject: Update test HTML hierarchy
..
Update test HTML hierarchy
Since I3fce14de04b9e10f7a1953f842e75f065bddd8ef,
the header
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383286 )
Change subject: Update test mock to return license info
..
Update test mock to return license info
Broken by
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383250 )
Change subject: Deal with cases where contributors and images are not defined
..
Deal with cases where contributors and images are not
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383210 )
Change subject: Disable OCG services
..
Disable OCG services
Bug: T177795
Change-Id: I2f820a5c5be5986b14f1c5ce0f52f3fd6140a6a3
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383180 )
Change subject: Enable new print styles on Vector
..
Enable new print styles on Vector
This time with added protection!
Bug: T169732
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383179 )
Change subject: Check config variables are set before applying
..
Check config variables are set before applying
Bug: T169732
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383175 )
Change subject: Testdonotmerge
..
Testdonotmerge
Change-Id: Idf6a2df409faaf8b3039fef63f80724a2e1ac473
---
R
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383170 )
Change subject: Enable new print styles on Vector
..
Enable new print styles on Vector
Bug: T169732
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383157 )
Change subject: Hlist tweaks (size and color)
..
Hlist tweaks (size and color)
* Font size should be relative to context
* Only apply
Hello Pmiazga, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/383153
to review the following change.
Change subject: Revert "Don't run diff test on beta cluster"
..
Revert
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382882 )
Change subject: Avoid clashes with MediaWiki:Common.css for hlist rules
..
Avoid clashes with MediaWiki:Common.css for hlist rules
101 - 200 of 5253 matches
Mail list logo
