[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Update browser test to run on desktop

2017-02-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335860 ) Change subject: Update browser test to run on desktop .. Update browser test to run on desktop This previously passed with a false

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Don't run the test for minerva stable against the beta cluster

2017-02-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335858 ) Change subject: Don't run the test for minerva stable against the beta cluster .. Don't run the test for minerva stable against the beta

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: DONOTMERGE: Another way

2017-02-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335856 ) Change subject: DONOTMERGE: Another way .. DONOTMERGE: Another way A few subtle changes here. 1) Exports are moved to the bottom of the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable RelatedSites on English, French and Italian Wikivoyages

2017-02-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335830 ) Change subject: Disable RelatedSites on English, French and Italian Wikivoyages .. Disable RelatedSites on English, French and Italian

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Redux and redux-thunk now packaged inside ext.popups

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335723 ) Change subject: Redux and redux-thunk now packaged inside ext.popups .. Redux and redux-thunk now packaged inside ext.popups Until this

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Remove unused code in repo

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335713 ) Change subject: Remove unused code in repo .. Remove unused code in repo The existence of these files was causing me much confusion as I

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge footer v2 style module into default style module

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335699 ) Change subject: Hygiene: Merge footer v2 style module into default style module .. Hygiene: Merge footer v2 style module into default

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Avoid PHP warnings in desktop Minerva

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335698 ) Change subject: Avoid PHP warnings in desktop Minerva .. Avoid PHP warnings in desktop Minerva Footer version 2 refers to template data

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update apple touch icon for Wikipedia

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335689 ) Change subject: Update apple touch icon for Wikipedia .. Update apple touch icon for Wikipedia Bug: T152538 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Limit page images on beta cluster to images in the lead section

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335687 ) Change subject: Limit page images on beta cluster to images in the lead section .. Limit page images on beta cluster to images in the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Related pages is shown to 90% of mobile users

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335686 ) Change subject: Related pages is shown to 90% of mobile users .. Related pages is shown to 90% of mobile users Note that

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: RelatedArticles enabled on French Wikipedia (mobile only)

2017-02-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335685 ) Change subject: RelatedArticles enabled on French Wikipedia (mobile only) .. RelatedArticles enabled on French Wikipedia (mobile only)

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Build previews with webpack

2017-02-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335590 ) Change subject: Build previews with webpack .. Build previews with webpack Change-Id: Ieb9e3bf1bee550e4234a5796c0b51405ba458b1f --- A

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Support local testing for development purposes

2017-02-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/33 ) Change subject: Support local testing for development purposes .. Support local testing for development purposes Vagrant uses the domain

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Add close button to settings dialog

2017-02-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335489 ) Change subject: Add close button to settings dialog .. Add close button to settings dialog * Load the close icon (previously was not

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Remove last modified line

2017-02-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335482 ) Change subject: Remove last modified line .. Remove last modified line Note this is a breaking change in the sense that it breaks the

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Changes to copy

2017-02-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335469 ) Change subject: Changes to copy .. Changes to copy Bug: T156368 Change-Id: Ibb570743a9be0028b1f593c465ef95578752b8a5 --- M i18n/en.json

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Trending takes optional period parameter

2017-01-31 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335370 ) Change subject: Trending takes optional period parameter .. Trending takes optional period parameter This allows us to pull out only

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Avoid a 1px glitch in ios

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335181 ) Change subject: Avoid a 1px glitch in ios .. Avoid a 1px glitch in ios The combination of animation and the fact that overlay-ios

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Define header height in pixels

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335176 ) Change subject: Define header height in pixels .. Define header height in pixels When expressed in ems due to how browsers round up

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: SVG logo should not blur

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335165 ) Change subject: SVG logo should not blur .. SVG logo should not blur A known workaround for a webkit bug with SVGS (see

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove MinervaUseFooterV2

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335080 ) Change subject: Hygiene: Remove MinervaUseFooterV2 .. Hygiene: Remove MinervaUseFooterV2 Remove temporary config variable that's causing

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove SkinMinervaOutputPageBeforeExec hook

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335071 ) Change subject: Remove SkinMinervaOutputPageBeforeExec hook .. Remove SkinMinervaOutputPageBeforeExec hook It's been deprecated some

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Surface how long we have been watching edits from

2017-01-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335070 ) Change subject: Surface how long we have been watching edits from .. Surface how long we have been watching edits from This adds a since

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Do not lazy load search to focus search input in overlay in ios

2017-01-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334698 ) Change subject: Do not lazy load search to focus search input in overlay in ios .. Do not lazy load search to focus search input in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Do not downscale the chrome header logo

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334443 ) Change subject: Do not downscale the chrome header logo .. Do not downscale the chrome header logo Use copyright-width and

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Hygiene: Reducers packaged via webpack

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334431 ) Change subject: Hygiene: Reducers packaged via webpack .. Hygiene: Reducers packaged via webpack Bug: T156333 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Hygiene: Generate changeListeners via webpack

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334430 ) Change subject: Hygiene: Generate changeListeners via webpack .. Hygiene: Generate changeListeners via webpack Begin moving over to a JS

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Update notification and search icons

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334427 ) Change subject: Update notification and search icons .. Update notification and search icons Bug: T152458 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Update notification and search icons

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334425 ) Change subject: Update notification and search icons .. Update notification and search icons Bug: T152458 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Deprecate mobile.toast

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334418 ) Change subject: Deprecate mobile.toast .. Deprecate mobile.toast Change-Id: I32704b9adad6ba67a152c00de36216b27cbd484d Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: Remove MobileFrontend toast dependency

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334417 ) Change subject: Remove MobileFrontend toast dependency .. Remove MobileFrontend toast dependency Bug: T155801 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Token is not always set in diff

2017-01-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334416 ) Change subject: Token is not always set in diff .. Token is not always set in diff Replicated this on a local instance while logged in

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Hygiene: Add to mw.popups in only one place

2017-01-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334231 ) Change subject: Hygiene: Add to mw.popups in only one place .. Hygiene: Add to mw.popups in only one place Prepare to shift to a JS

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Add box shadow to headers

2017-01-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334226 ) Change subject: Add box shadow to headers .. Add box shadow to headers The chrome-header is now opt in (not added by default) This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Add box shadow to headers

2017-01-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334227 ) Change subject: Add box shadow to headers .. Add box shadow to headers The chrome-header is now opt in (not added by default) This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: fix up

2017-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334003 ) Change subject: fix up .. fix up Change-Id: Id1412975c4d06f362e69692c44b7842c5c0ce876 --- M minerva.less/minerva.variables.less M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Hygiene: Switch from ems to pixels for layout elements

2017-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334001 ) Change subject: Hygiene: Switch from ems to pixels for layout elements .. Hygiene: Switch from ems to pixels for layout elements This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Rename mobile.ajax module

2017-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333982 ) Change subject: Hygiene: Rename mobile.ajax module .. Hygiene: Rename mobile.ajax module It's a style module, not a script+style module

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Global event emitter passed in as option to Skin

2017-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333981 ) Change subject: Global event emitter passed in as option to Skin .. Global event emitter passed in as option to Skin Bug: T156186

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: UseGalleries is unused

2017-01-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333804 ) Change subject: UseGalleries is unused .. UseGalleries is unused Unless I'm mistaken this config variable has never been used in this

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Document page property names

2017-01-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333805 ) Change subject: Document page property names .. Document page property names This should protect us when we consider renaming these

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Retrieve Drawer from its new home

2017-01-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333707 ) Change subject: Retrieve Drawer from its new home .. Retrieve Drawer from its new home Bug: T156050 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: mobile.pagelist folded into mobile.startup

2017-01-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333293 ) Change subject: Hygiene: mobile.pagelist folded into mobile.startup .. Hygiene: mobile.pagelist folded into mobile.startup Bug: T155799

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove deprecation notices flooding console in Mobi...

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333150 ) Change subject: Hygiene: Remove deprecation notices flooding console in MobileFrontend .. Hygiene: Remove deprecation notices flooding

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Move mobile.toast into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333151 ) Change subject: Hygiene: Move mobile.toast into mobile.startup .. Hygiene: Move mobile.toast into mobile.startup Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: mobile.drawers merged into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333149 ) Change subject: Hygiene: mobile.drawers merged into mobile.startup .. Hygiene: mobile.drawers merged into mobile.startup Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: Hygiene: No need to use ContentOverlay

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333133 ) Change subject: Hygiene: No need to use ContentOverlay .. Hygiene: No need to use ContentOverlay Instead extend Overlay and override the

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: Hygiene: Depend on mobile.startup module

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333126 ) Change subject: Hygiene: Depend on mobile.startup module .. Hygiene: Depend on mobile.startup module Other modules are going to be

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikidata description taglines shown on English Wikipedia

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333124 ) Change subject: Wikidata description taglines shown on English Wikipedia .. Wikidata description taglines shown on English Wikipedia

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.overlays into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333119 ) Change subject: Hygiene: Merge mobile.overlays into mobile.startup .. Hygiene: Merge mobile.overlays into mobile.startup This is an

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.cache into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333118 ) Change subject: Hygiene: Merge mobile.cache into mobile.startup .. Hygiene: Merge mobile.cache into mobile.startup mobile.cache is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.oo into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333075 ) Change subject: Hygiene: Merge mobile.oo into mobile.startup .. Hygiene: Merge mobile.oo into mobile.startup Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.context into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333069 ) Change subject: Hygiene: Merge mobile.context into mobile.startup .. Hygiene: Merge mobile.context into mobile.startup Note that

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: mobile.view folded into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333074 ) Change subject: Hygiene: mobile.view folded into mobile.startup .. Hygiene: mobile.view folded into mobile.startup Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Fold mobile.user into mobile.startup module

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333071 ) Change subject: Hygiene: Fold mobile.user into mobile.startup module .. Hygiene: Fold mobile.user into mobile.startup module Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Move mobile.settings into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333070 ) Change subject: Hygiene: Move mobile.settings into mobile.startup .. Hygiene: Move mobile.settings into mobile.startup Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.modifiedBar into mobile.startup

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333072 ) Change subject: Hygiene: Merge mobile.modifiedBar into mobile.startup .. Hygiene: Merge mobile.modifiedBar into mobile.startup

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Move mobile.browser code into mobile.startup module

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333073 ) Change subject: Hygiene: Move mobile.browser code into mobile.startup module .. Hygiene: Move mobile.browser code into mobile.startup

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Merge mobile.modules and mobile.oo

2017-01-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333068 ) Change subject: Hygiene: Merge mobile.modules and mobile.oo .. Hygiene: Merge mobile.modules and mobile.oo MobileFrontend has more

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[mfui]: Hygiene: Skin moved to mobile.frontend library

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332928 ) Change subject: Hygiene: Skin moved to mobile.frontend library .. Hygiene: Skin moved to mobile.frontend library Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[mfui]: WIP: Building of common code is done by webpack

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332924 ) Change subject: WIP: Building of common code is done by webpack .. WIP: Building of common code is done by webpack Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[mfui]: WIP: View now packaged

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332925 ) Change subject: WIP: View now packaged .. WIP: View now packaged Change-Id: Ic3136b2d6434fecf02aae8ff81a525b82b13ddf1 --- A

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[mfui]: Hygiene: icons moved to build_resources

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332927 ) Change subject: Hygiene: icons moved to build_resources .. Hygiene: icons moved to build_resources Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[mfui]: Icon moved to precompiled mobile.frontend module

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332926 ) Change subject: Icon moved to precompiled mobile.frontend module .. Icon moved to precompiled mobile.frontend module Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove getWikiBaseItemId util

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332923 ) Change subject: Hygiene: Remove getWikiBaseItemId util .. Hygiene: Remove getWikiBaseItemId util Method is not used anywhere. Bug:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP: Limit the width of search in tablet mode

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332892 ) Change subject: WIP: Limit the width of search in tablet mode .. WIP: Limit the width of search in tablet mode Problems: * In tablet

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Update hamburger asset

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332882 ) Change subject: Update hamburger asset .. Update hamburger asset Change-Id: I49ee4fd030228303d395c840e8159a94e684c12c --- M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Change close icon asset and move it to right of search

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332880 ) Change subject: Change close icon asset and move it to right of search .. Change close icon asset and move it to right of search

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Search input is shown on tablet resolutions

2017-01-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332870 ) Change subject: Search input is shown on tablet resolutions .. Search input is shown on tablet resolutions * Re-enable browser tests,

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: 3rd parties should not get Wikipedia specific styles

2017-01-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331693 ) Change subject: 3rd parties should not get Wikipedia specific styles .. 3rd parties should not get Wikipedia specific styles Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Minerva should apply known template hacks in production

2017-01-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331425 ) Change subject: Minerva should apply known template hacks in production .. Minerva should apply known template hacks in production

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Track reverts as best as possible

2017-01-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331250 ) Change subject: Track reverts as best as possible .. Track reverts as best as possible Bug: T152421 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Notifications icon simplified to circle from bell

2017-01-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330382 ) Change subject: Notifications icon simplified to circle from bell .. Notifications icon simplified to circle from bell The notifications

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Search input shown on tablet resolutions

2017-01-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330381 ) Change subject: Search input shown on tablet resolutions .. Search input shown on tablet resolutions Non-Js browser test has been

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Brand beta differently

2017-01-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330378 ) Change subject: Brand beta differently .. Brand beta differently When in beta the logo copyright-beta/copyright or the site heading will

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: Brand beta differently

2017-01-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330359 ) Change subject: Brand beta differently .. Brand beta differently When in beta the logo copyright-beta/copyright or the site heading will

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: New chrome header with branding

2017-01-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330357 ) Change subject: New chrome header with branding .. New chrome header with branding * Replace search input in header with search icon and

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[branding]: New chrome header with branding

2017-01-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330354 ) Change subject: New chrome header with branding .. New chrome header with branding * Replace search input in header with search icon and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DONOTMERGE: Unit test scaffolding

2017-01-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330187 ) Change subject: DONOTMERGE: Unit test scaffolding .. DONOTMERGE: Unit test scaffolding Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Use 0.4.0 of wikipedia-edits-scorer

2016-12-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327385 ) Change subject: Use 0.4.0 of wikipedia-edits-scorer .. Use 0.4.0 of wikipedia-edits-scorer New version calculates scores better for

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix linting issues due to upgrade on eslint-config-wikimedia

2016-12-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327380 ) Change subject: Fix linting issues due to upgrade on eslint-config-wikimedia .. Fix linting issues due to upgrade on

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Test and correct behaviour of getSectionId

2016-12-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327137 ) Change subject: Test and correct behaviour of getSectionId .. Test and correct behaviour of getSectionId Bug: T146394 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: breakup mega-function in MobileView API

2016-12-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327129 ) Change subject: Hygiene: breakup mega-function in MobileView API .. Hygiene: breakup mega-function in MobileView API In order to make

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: WIP: Use mobileview api to get fresher content

2016-12-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327056 ) Change subject: WIP: Use mobileview api to get fresher content .. WIP: Use mobileview api to get fresher content This currently wont

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add revision support to mobile content service

2016-12-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326868 ) Change subject: Add revision support to mobile content service .. Add revision support to mobile content service When editing a page,

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Surface number of editors in trending responses

2016-12-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326499 ) Change subject: Surface number of editors in trending responses .. Surface number of editors in trending responses When deciding if

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add additional information to file and user pages for rendering

2016-12-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326178 ) Change subject: Add additional information to file and user pages for rendering .. Add additional information to file and user pages for

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Remove unnecessary information

2016-12-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/325867 ) Change subject: Remove unnecessary information .. Remove unnecessary information Turns out these fields although interesting are not

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Score and sort pages before exposing

2016-12-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/325847 ) Change subject: Score and sort pages before exposing .. Score and sort pages before exposing Bug: T150039 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Limit content sent in API response

2016-12-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/325848 ) Change subject: Limit content sent in API response .. Limit content sent in API response Note the trendedAt field is purposely omitted

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Provide test case for getPageImageCandidates

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325458 Change subject: Provide test case for getPageImageCandidates .. Provide test case for getPageImageCandidates Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Re-enable banners on Romanian Wikivoyage

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325447 Change subject: Re-enable banners on Romanian Wikivoyage .. Re-enable banners on Romanian Wikivoyage Follow up to

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable Wikipedia beta banner experiment

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325370 Change subject: Disable Wikipedia beta banner experiment .. Disable Wikipedia beta banner experiment Bug: T148634 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable banners on Finnish Wikivoyage

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325369 Change subject: Enable banners on Finnish Wikivoyage .. Enable banners on Finnish Wikivoyage In process convert the whitelist to a

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Roll out wikidata description taglines to French and German ...

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325366 Change subject: Roll out wikidata description taglines to French and German Wikipedias .. Roll out wikidata description taglines to French

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Logged in user tests do not work on beta cluster

2016-12-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/325321 Change subject: Logged in user tests do not work on beta cluster .. Logged in user tests do not work on beta cluster On the beta cluster,

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove dead folder of images

2016-11-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/324613 Change subject: Hygiene: Remove dead folder of images .. Hygiene: Remove dead folder of images This icon is provided by

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove references to Special:TopicTag

2016-11-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/324602 Change subject: Hygiene: Remove references to Special:TopicTag .. Hygiene: Remove references to Special:TopicTag This is a remnant from

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hovering over links in menu should change icons to blue

2016-11-29 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/324370 Change subject: Hovering over links in menu should change icons to blue .. Hovering over links in menu should change icons to blue Use css

<    4   5   6   7   8   9   10   11   12   13   >