[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.20]: mw.loader: Don't assume var 'loading' assigns before Promise...

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348887 ) Change subject: mw.loader: Don't assume var 'loading' assigns before Promise resolves .. mw.loader: Don't assume var 'loading' assigns b

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.21.1

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348882 ) Change subject: Update OOjs UI to v0.21.1 .. Update OOjs UI to v0.21.1 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.21.1

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348881 ) Change subject: Update OOjs UI to v0.21.1 .. Update OOjs UI to v0.21.1 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Drop the csscomb task

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348804 ) Change subject: build: Drop the csscomb task .. build: Drop the csscomb task Finally time to bite the bullet on this one. Not that it r

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Revert "Docs: Fix numbering in Quick start"

2017-04-18 Thread Jforrester (Code Review)
Hello KartikMistry, jenkins-bot, VolkerE, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/348803 to review the following change. Change subject: Revert "Docs: Fix numbering in Quick start" ..

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: postEdit: Show a different success messsage on publish vs. s...

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348749 ) Change subject: postEdit: Show a different success messsage on publish vs. save wikis .. postEdit: Show a different success messsage on

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Vary 'save button' label for appropriate i18n

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348748 ) Change subject: EditPage: Vary 'save button' label for appropriate i18n .. EditPage: Vary 'save button' label for appropriate i18n Chang

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Factor out getSaveButtonLabel method

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348747 ) Change subject: EditPage: Factor out getSaveButtonLabel method .. EditPage: Factor out getSaveButtonLabel method Change-Id: I89a2e3b6b8d

[MediaWiki-commits] [Gerrit] integration/config[master]: [CodeMirror] Express dependency on VisualEditor and WikiEditor

2017-04-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348640 ) Change subject: [CodeMirror] Express dependency on VisualEditor and WikiEditor .. [CodeMirror] Express dependency on VisualEditor and Wik

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (fc46ed86f)

2017-04-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348497 ) Change subject: Update VE core submodule to master (fc46ed86f) .. Update VE core submodule to master (fc46ed86f) New changes: 719f8c667

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OutputPage: Remove deprecated addParserOutputNoText, getHead...

2017-04-13 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348168 ) Change subject: OutputPage: Remove deprecated addParserOutputNoText, getHeadLinks methods .. OutputPage: Remove deprecated addParserOutp

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Removed deprecated ExtractThumbParameters hook

2017-04-13 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348167 ) Change subject: Removed deprecated ExtractThumbParameters hook .. Removed deprecated ExtractThumbParameters hook Change-Id: I97e820d78d8

[MediaWiki-commits] [Gerrit] mediawiki...PagedTiffHandler[master]: Remove ExtractThumbParameters hook, deprecated since MW 1.22

2017-04-13 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348163 ) Change subject: Remove ExtractThumbParameters hook, deprecated since MW 1.22 .. Remove ExtractThumbParameters hook, deprecated since MW 1

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but...

2017-04-13 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348151 ) Change subject: Follow-up 57a06a6e: .getAttribute might be 'guaranteed', but not from null .. Follow-up 57a06a6e: .getAttribute might be

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set wgUsejQueryThree to false everywhere ahead of further te...

2017-04-13 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348094 ) Change subject: Set wgUsejQueryThree to false everywhere ahead of further testing .. Set wgUsejQueryThree to false everywhere ahead of f

[MediaWiki-commits] [Gerrit] oojs/ui[master]: environment: Upgrade jQuery from 1.11.3 to 3.2.1

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348036 ) Change subject: environment: Upgrade jQuery from 1.11.3 to 3.2.1 .. environment: Upgrade jQuery from 1.11.3 to 3.2.1 Change-Id: I74582ce

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[master]: tests: Fiddle with templatedata cache insertion to avoid fai...

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348031 ) Change subject: tests: Fiddle with templatedata cache insertion to avoid failed XHRs .. tests: Fiddle with templatedata cache insertion

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ext.visualEditor.mwcore: Depend on mediawiki.notify for the ...

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348024 ) Change subject: ext.visualEditor.mwcore: Depend on mediawiki.notify for the warning .. ext.visualEditor.mwcore: Depend on mediawiki.noti

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.test.utils: Don't try to write user options in test suites

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348021 ) Change subject: ve.test.utils: Don't try to write user options in test suites .. ve.test.utils: Don't try to write user options in test s

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.init.Target: Be able to not set default mode, for tests

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348019 ) Change subject: ve.init.Target: Be able to not set default mode, for tests .. ve.init.Target: Be able to not set default mode, for tests

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.init.mw.DesktopArticleTarget.init: Don't do this twice, w...

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348020 ) Change subject: ve.init.mw.DesktopArticleTarget.init: Don't do this twice, we do it after the promise anyway .. ve.init.mw.DesktopArticl

[MediaWiki-commits] [Gerrit] oojs/ui[master]: src: Use JSON.parse rather than the deprecated $.parseJSON

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348017 ) Change subject: src: Use JSON.parse rather than the deprecated $.parseJSON .. src: Use JSON.parse rather than the deprecated $.parseJSON

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (e4540d87f)

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348008 ) Change subject: Update VE core submodule to master (e4540d87f) .. Update VE core submodule to master (e4540d87f) New changes: 57c61dcf8

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Upgrade to jQuery v3

2017-04-12 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347872 ) Change subject: Upgrade to jQuery v3 .. Upgrade to jQuery v3 Source code: https://code.jquery.com/jquery-3.2.1.js Documentation: http

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Enforce dm unit test coverage at 20% per file and 80%...

2017-04-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347800 ) Change subject: tests: Enforce dm unit test coverage at 20% per file and 80% globally .. tests: Enforce dm unit test coverage at 20% per

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Switch to use mocha for reporting

2017-04-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347799 ) Change subject: tests: Switch to use mocha for reporting .. tests: Switch to use mocha for reporting Change-Id: Iacb0048f693be098d43598d

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.21.0

2017-04-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347784 ) Change subject: Update OOjs UI to v0.21.0 .. Update OOjs UI to v0.21.0 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up 16231a81: Fix typo in update-oojs-ui.sh

2017-04-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347783 ) Change subject: Follow-up 16231a81: Fix typo in update-oojs-ui.sh .. Follow-up 16231a81: Fix typo in update-oojs-ui.sh Change-Id: Ib3338

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Clean the coverage directory on test

2017-04-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347643 ) Change subject: build: Clean the coverage directory on test .. build: Clean the coverage directory on test Change-Id: I0cf043aaa4c950368

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: stylelint: Drop 'no-unsupported-browser-features' rule, no l...

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347527 ) Change subject: stylelint: Drop 'no-unsupported-browser-features' rule, no longer supported .. stylelint: Drop 'no-unsupported-browser-f

[MediaWiki-commits] [Gerrit] mediawiki...AccountAudit[master]: Clarify that the licence is indeed GPL-2.0+

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347478 ) Change subject: Clarify that the licence is indeed GPL-2.0+ .. Clarify that the licence is indeed GPL-2.0+ Bug: T91522 Change-Id: I10580

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: stylelint: Remove VE-specific config

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347453 ) Change subject: stylelint: Remove VE-specific config .. stylelint: Remove VE-specific config The only two rules in the over-ride were no

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: stylelint: Drop unsupported no-unsupported-browser-features ...

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347440 ) Change subject: stylelint: Drop unsupported no-unsupported-browser-features reference .. stylelint: Drop unsupported no-unsupported-brow

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikitech: Don't try to do cross-wiki uploads to Commons

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347422 ) Change subject: Wikitech: Don't try to do cross-wiki uploads to Commons .. Wikitech: Don't try to do cross-wiki uploads to Commons Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: stylelint: Drop old 'no-unsupported-browser-features' rule

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347408 ) Change subject: stylelint: Drop old 'no-unsupported-browser-features' rule .. stylelint: Drop old 'no-unsupported-browser-features' rule

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: build: Bump devDependencies to latest

2017-04-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347407 ) Change subject: build: Bump devDependencies to latest .. build: Bump devDependencies to latest grunt-banana-checker 0.5.0 → 0.6.0 g

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: FlaggablePageView#changeSaveButton: Address i18n FIXME, use ...

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346934 ) Change subject: FlaggablePageView#changeSaveButton: Address i18n FIXME, use the brackets message .. FlaggablePageView#changeSaveButton:

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: [WIP] Vary the 'submit changes' button on 'Publish' wikis

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346935 ) Change subject: [WIP] Vary the 'submit changes' button on 'Publish' wikis .. [WIP] Vary the 'submit changes' button on 'Publish' wikis C

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: dm.metaitems: Turn grouped metas into variadic ones

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346933 ) Change subject: dm.metaitems: Turn grouped metas into variadic ones .. dm.metaitems: Turn grouped metas into variadic ones We're getting

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: stylelint: Drop no-unsupported-browser-features references

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346920 ) Change subject: stylelint: Drop no-unsupported-browser-features references .. stylelint: Drop no-unsupported-browser-features references

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: stylelint: Drop no-unsupported-browser-features references

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346918 ) Change subject: stylelint: Drop no-unsupported-browser-features references .. stylelint: Drop no-unsupported-browser-features references

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (64daeb4b5)

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346827 ) Change subject: Update VE core submodule to master (64daeb4b5) .. Update VE core submodule to master (64daeb4b5) New changes: dc0cad28c

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up 16231a81: Drop IE9 support from ve.createDocumentF...

2017-04-06 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346826 ) Change subject: Follow-up 16231a81: Drop IE9 support from ve.createDocumentFromHtmlUsingIframe .. Follow-up 16231a81: Drop IE9 support f

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs to v2.0.0

2017-04-05 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346564 ) Change subject: Update OOjs to v2.0.0 .. Update OOjs to v2.0.0 Release notes: https://phabricator.wikimedia.org/diffusion/GOJS/browse/

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs to v2.0.0

2017-04-05 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346562 ) Change subject: Update OOjs to v2.0.0 .. Update OOjs to v2.0.0 Release notes: https://phabricator.wikimedia.org/diffusion/GOJS/browse/

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Bump file copyright notices for 2017

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346487 ) Change subject: build: Bump file copyright notices for 2017 .. build: Bump file copyright notices for 2017 Change-Id: Ia6cb5d07e5a09abd3

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Bump development dependencies to latest

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346486 ) Change subject: build: Bump development dependencies to latest .. build: Bump development dependencies to latest grunt-contrib-uglify

[MediaWiki-commits] [Gerrit] oojs/core[master]: EventEmitter#disconnect: Correct documentation for second pa...

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346485 ) Change subject: EventEmitter#disconnect: Correct documentation for second parameter .. EventEmitter#disconnect: Correct documentation fo

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [BREAKING CHANGE] Drop support for Internet Explorer 9

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346475 ) Change subject: [BREAKING CHANGE] Drop support for Internet Explorer 9 .. [BREAKING CHANGE] Drop support for Internet Explorer 9 Change-

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] dependencies: Drop support for ES3 browser...

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346467 ) Change subject: [BREAKING CHANGE] dependencies: Drop support for ES3 browsers via es5-shim .. [BREAKING CHANGE] dependencies: Drop suppo

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on bgwiki

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346333 ) Change subject: Enable wgCiteResponsiveReferences on bgwiki .. Enable wgCiteResponsiveReferences on bgwiki Bug: T162145 Change-Id: I8c01

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (19a6c389c)

2017-04-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346327 ) Change subject: Update VE core submodule to master (19a6c389c) .. Update VE core submodule to master (19a6c389c) New changes: 5082dcba0

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (a6c25d08e)

2017-03-30 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345794 ) Change subject: Update VE core submodule to master (a6c25d08e) .. Update VE core submodule to master (a6c25d08e) New changes: 803e45655

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Switch from deprecated EditPageBeforeEditChecks to EditPageG...

2017-03-30 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345630 ) Change subject: Switch from deprecated EditPageBeforeEditChecks to EditPageGetCheckboxesDefinition .. Switch from deprecated EditPageBef

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Do not use the deprecated EditPageBeforeEditChecks hook

2017-03-30 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345624 ) Change subject: Do not use the deprecated EditPageBeforeEditChecks hook .. Do not use the deprecated EditPageBeforeEditChecks hook We do

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWSaveDialog: Run links through a render function

2017-03-30 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345607 ) Change subject: MWSaveDialog: Run links through a render function .. MWSaveDialog: Run links through a render function Provide a utility

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: i18n: Update "Save" to "Publish" for page edits

2017-03-29 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345406 ) Change subject: i18n: Update "Save" to "Publish" for page edits .. i18n: Update "Save" to "Publish" for page edits Bug: T142609 Change-I

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Show 'Publish' not 'Save' on Wikipedias except de/en

2017-03-29 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345399 ) Change subject: Show 'Publish' not 'Save' on Wikipedias except de/en .. Show 'Publish' not 'Save' on Wikipedias except de/en Bug: T13113

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.20.1

2017-03-29 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345395 ) Change subject: Update OOjs UI to v0.20.1 .. Update OOjs UI to v0.20.1 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Revert "Update OOjs UI to v0.20.1"

2017-03-29 Thread Jforrester (Code Review)
Hello Legoktm, jenkins-bot, VolkerE, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/345336 to review the following change. Change subject: Revert "Update OOjs UI to v0.20.1" .. Re

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump various devDependencies to latest

2017-03-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345201 ) Change subject: build: Bump various devDependencies to latest .. build: Bump various devDependencies to latest grunt-banana-checker

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump grunt-banana-checker from 0.5.0 to 0.6.0

2017-03-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345199 ) Change subject: build: Bump grunt-banana-checker from 0.5.0 to 0.6.0 .. build: Bump grunt-banana-checker from 0.5.0 to 0.6.0 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (15ee3e37d)

2017-03-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344803 ) Change subject: Update VE core submodule to master (15ee3e37d) .. Update VE core submodule to master (15ee3e37d) New changes: e0651b2df

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set wgOOUIEditPage false everywhere

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344724 ) Change subject: Set wgOOUIEditPage false everywhere .. Set wgOOUIEditPage false everywhere In preparation for I25aa78ac5908. Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on cawiki

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344722 ) Change subject: Enable wgCiteResponsiveReferences on cawiki .. Enable wgCiteResponsiveReferences on cawiki Bug: T161307 Change-Id: I0a2c

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (7b51cb6ab)

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344692 ) Change subject: Update VE core submodule to master (7b51cb6ab) .. Update VE core submodule to master (7b51cb6ab) New changes: f887e6b7a

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: build: Enable eslint rule 'no-multi-spaces' and make pass

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344675 ) Change subject: build: Enable eslint rule 'no-multi-spaces' and make pass .. build: Enable eslint rule 'no-multi-spaces' and make pass C

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: build: Enable eslint rule 'eqeqeq' and make pass

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344674 ) Change subject: build: Enable eslint rule 'eqeqeq' and make pass .. build: Enable eslint rule 'eqeqeq' and make pass Change-Id: I57907da

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: build: Replace jshint and jscs with eslint

2017-03-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344673 ) Change subject: build: Replace jshint and jscs with eslint .. build: Replace jshint and jscs with eslint Bug: T161142 Change-Id: I9c785a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [FAILING TEST CASE] Minimal diff when word starts the paragraph

2017-03-23 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344567 ) Change subject: [FAILING TEST CASE] Minimal diff when word starts the paragraph .. [FAILING TEST CASE] Minimal diff when word starts the

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget.init#activateTarget: Don't trust oldid, ...

2017-03-23 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344505 ) Change subject: DesktopArticleTarget.init#activateTarget: Don't trust oldid, it lies .. DesktopArticleTarget.init#activateTarget: Don't

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.dm.MWImageNode#describeChanges: Ignore borderImage noise ...

2017-03-22 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344281 ) Change subject: ve.dm.MWImageNode#describeChanges: Ignore borderImage noise from the model .. ve.dm.MWImageNode#describeChanges: Ignore

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: i18n: Add a default alignment value

2017-03-22 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344278 ) Change subject: i18n: Add a default alignment value .. i18n: Add a default alignment value Change-Id: Ic3f2a941a55cbd8e23e0291b53080af98

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (ce3618d86)

2017-03-22 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344219 ) Change subject: Update VE core submodule to master (ce3618d86) .. Update VE core submodule to master (ce3618d86) New changes: 9e27aeaed

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Drop the pointless "AllowCiteGroups" config setting

2017-03-22 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344185 ) Change subject: Drop the pointless "AllowCiteGroups" config setting .. Drop the pointless "AllowCiteGroups" config setting Bug: T161144

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: i18n: Don't try to spell out all the options that are allowed

2017-03-22 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344183 ) Change subject: i18n: Don't try to spell out all the options that are allowed .. i18n: Don't try to spell out all the options that are al

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn'...

2017-03-21 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344041 ) Change subject: ve.ui.MWGalleryDialog: Don't die if the dropdown menu doesn't have a value .. ve.ui.MWGalleryDialog: Don't die if the dr

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Revert "Really don't generate 'icons-alerts' for Apex"

2017-03-21 Thread Jforrester (Code Review)
Hello Bartosz Dziewoński, jenkins-bot, VolkerE, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/344038 to review the following change. Change subject: Revert "Really don't generate 'icons-alerts' for Apex" .

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.toolbar: Emit deprecation warnings

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343785 ) Change subject: mediawiki.toolbar: Emit deprecation warnings .. mediawiki.toolbar: Emit deprecation warnings Bug: T30856 Change-Id: I3be

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on itwiki

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343714 ) Change subject: Enable wgCiteResponsiveReferences on itwiki .. Enable wgCiteResponsiveReferences on itwiki Bug: T160932 Change-Id: I67de

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on enwiktionary

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343700 ) Change subject: Enable wgCiteResponsiveReferences on enwiktionary .. Enable wgCiteResponsiveReferences on enwiktionary Bug: T160933 Chan

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on frwiki

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343694 ) Change subject: Enable wgCiteResponsiveReferences on frwiki .. Enable wgCiteResponsiveReferences on frwiki Bug: T160609 Change-Id: Iad20

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on nowiki

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343696 ) Change subject: Enable wgCiteResponsiveReferences on nowiki .. Enable wgCiteResponsiveReferences on nowiki Bug: T160362 Change-Id: Ibdc4

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable wgCiteResponsiveReferences on lawiki

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343695 ) Change subject: Enable wgCiteResponsiveReferences on lawiki .. Enable wgCiteResponsiveReferences on lawiki Bug: T160844 Change-Id: Ieab0

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (f294778e6)

2017-03-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343662 ) Change subject: Update VE core submodule to master (f294778e6) .. Update VE core submodule to master (f294778e6) New changes: 642e86498

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Drop the 'CategorizedRecentChanges' feature

2017-03-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343426 ) Change subject: Drop the 'CategorizedRecentChanges' feature .. Drop the 'CategorizedRecentChanges' feature It is off by default, it's ve

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.16]: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed)

2017-03-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343411 ) Change subject: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed) .. Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: i18n: Add param documentation in qqq for some recent keys

2017-03-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343405 ) Change subject: i18n: Add param documentation in qqq for some recent keys .. i18n: Add param documentation in qqq for some recent keys B

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b2f4785d6)

2017-03-17 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343321 ) Change subject: Update VE core submodule to master (b2f4785d6) .. Update VE core submodule to master (b2f4785d6) New changes: dcff78aa0

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[wmf/1.29.0-wmf.16]: DesktopContext: on destroy, tell our popup to stop positioning

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343228 ) Change subject: DesktopContext: on destroy, tell our popup to stop positioning .. DesktopContext: on destroy, tell our popup to stop posi

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[wmf/1.29.0-wmf.16]: ve.ui.DesktopContext: Prevent hiding of the context popup

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343229 ) Change subject: ve.ui.DesktopContext: Prevent hiding of the context popup .. ve.ui.DesktopContext: Prevent hiding of the context popup *

[MediaWiki-commits] [Gerrit] mediawiki...GlobalCssJs[master]: Register our modules as preload requirements for VisualEdito...

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343226 ) Change subject: Register our modules as preload requirements for VisualEditor if present .. Register our modules as preload requirements

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (ac6d7031c)

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343224 ) Change subject: Update VE core submodule to master (ac6d7031c) .. Update VE core submodule to master (ac6d7031c) New changes: 80b31eddb

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up 335b56728: Reality doesn't run in perma-debug mode...

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343220 ) Change subject: Follow-up 335b56728: Reality doesn't run in perma-debug mode :-) .. Follow-up 335b56728: Reality doesn't run in perma-deb

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destr...

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343206 ) Change subject: Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed .. Follow-up 7a8cc04f0: Re-set qqq messages that i18n bo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Linker: Render selflinks as classed s, not s

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343204 ) Change subject: [WIP] Linker: Render selflinks as classed s, not s .. [WIP] Linker: Render selflinks as classed s, not s Self-links are

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: [WIP] Describe group changes for references and references l...

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343134 ) Change subject: [WIP] Describe group changes for references and references lists .. [WIP] Describe group changes for references and refer

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display ...

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343107 ) Change subject: Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup .. Follow-up eb8ba26a: Make MWNoticesTool#setN

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.16]: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a6323d7)

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343072 ) Change subject: Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a6323d7) .. Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (5c4c9e8ed)

2017-03-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343071 ) Change subject: Update VE core submodule to master (5c4c9e8ed) .. Update VE core submodule to master (5c4c9e8ed) New changes: cc3e61930

<    2   3   4   5   6   7   8   9   10   11   >