[MediaWiki-commits] [Gerrit] Add border-radius and box-shadow functions to mediawiki mixins - change (mediawiki/core)

2014-05-22 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134964 Change subject: Add border-radius and box-shadow functions to mediawiki mixins .. Add border-radius and box-shadow functions to mediawiki

[MediaWiki-commits] [Gerrit] Update test tour to use new API - change (mediawiki...GuidedTour)

2014-05-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134489 Change subject: Update test tour to use new API .. Update test tour to use new API Change-Id: I20ce0338ad693ff85933757424faaf92e7c34daf ---

[MediaWiki-commits] [Gerrit] Change guider button classes to mw-ui-primary - change (mediawiki...GuidedTour)

2014-05-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134513 Change subject: Change guider button classes to mw-ui-primary .. Change guider button classes to mw-ui-primary Change-Id:

[MediaWiki-commits] [Gerrit] jStorage is unreliable, using cookie for CTA flag - change (mediawiki...GettingStarted)

2014-05-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134540 Change subject: jStorage is unreliable, using cookie for CTA flag .. jStorage is unreliable, using cookie for CTA flag Change-Id:

[MediaWiki-commits] [Gerrit] Move post edit messages into the post edit RL module - change (mediawiki...GettingStarted)

2014-05-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134165 Change subject: Move post edit messages into the post edit RL module .. Move post edit messages into the post edit RL module Change-Id:

[MediaWiki-commits] [Gerrit] Apply new guider styles for borders and shadows - change (mediawiki...GuidedTour)

2014-05-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134238 Change subject: Apply new guider styles for borders and shadows .. Apply new guider styles for borders and shadows Change-Id:

[MediaWiki-commits] [Gerrit] Match existing GettingStarted CTA headings to the same style... - change (mediawiki...GettingStarted)

2014-05-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134270 Change subject: Match existing GettingStarted CTA headings to the same styles as guiders .. Match existing GettingStarted CTA headings to

[MediaWiki-commits] [Gerrit] Set the jStorage TTL to match the wikis configured cookie ex... - change (mediawiki...GettingStarted)

2014-05-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/134280 Change subject: Set the jStorage TTL to match the wikis configured cookie expiration .. Set the jStorage TTL to match the wikis configured

[MediaWiki-commits] [Gerrit] Delete the post-edit cookie using the correct domain - change (mediawiki/core)

2014-05-15 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: Delete the post-edit cookie using the correct domain .. Delete the post-edit cookie using the correct domain Use the mediawiki.cookie#set to delete the

[MediaWiki-commits] [Gerrit] Pass archived page id to ArticleUndelete hook. - change (mediawiki/core)

2014-05-15 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/133631 Change subject: Pass archived page id to ArticleUndelete hook. .. Pass archived page id to ArticleUndelete hook. Needed for instrumentation

[MediaWiki-commits] [Gerrit] Instrumentation of PageRestoration schema - change (mediawiki...WikimediaEvents)

2014-05-15 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/133632 Change subject: Instrumentation of PageRestoration schema .. Instrumentation of PageRestoration schema See:

[MediaWiki-commits] [Gerrit] Implement mediawiki.cookie module - change (mediawiki/core)

2014-05-14 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: Implement mediawiki.cookie module .. Implement mediawiki.cookie module Provides functonality similar to WebRequest#getCookie and WebResponse#setcookie.

[MediaWiki-commits] [Gerrit] Show anonymous acquisition experiment once regardless of pag... - change (mediawiki...GettingStarted)

2014-05-12 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/132963 Change subject: Show anonymous acquisition experiment once regardless of page load. .. Show anonymous acquisition experiment once regardless

[MediaWiki-commits] [Gerrit] Instrument the SignupExpCTAButtonClick schema - change (mediawiki...GettingStarted)

2014-05-09 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: Instrument the SignupExpCTAButtonClick schema .. Instrument the SignupExpCTAButtonClick schema Also fix a bug in #handleNoThanksForVisualEditor where a

[MediaWiki-commits] [Gerrit] Instrumentation of signup experiment schemas - change (mediawiki...GettingStarted)

2014-05-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/132486 Change subject: Instrumentation of signup experiment schemas .. Instrumentation of signup experiment schemas Change-Id:

[MediaWiki-commits] [Gerrit] Instrumentation for SignupExpAccountCreationImpression schema - change (mediawiki...GettingStarted)

2014-05-08 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/132225 Change subject: Instrumentation for SignupExpAccountCreationImpression schema .. Instrumentation for SignupExpAccountCreationImpression

[MediaWiki-commits] [Gerrit] Enable anonymous editor acquisition experiment across labs - change (operations/mediawiki-config)

2014-05-08 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/132308 Change subject: Enable anonymous editor acquisition experiment across labs .. Enable anonymous editor acquisition experiment across labs

[MediaWiki-commits] [Gerrit] Only show anonymous editor acquisition once to the user. - change (mediawiki...GettingStarted)

2014-05-07 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/132018 Change subject: Only show anonymous editor acquisition once to the user. .. Only show anonymous editor acquisition once to the user.

[MediaWiki-commits] [Gerrit] Added JSDuck5 custom tag support - change (mediawiki...GuidedTour)

2014-05-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/131615 Change subject: Added JSDuck5 custom tag support .. Added JSDuck5 custom tag support Change-Id: I5c11d40d3ca8d5a13828036e02cba2f756a3b4b4

[MediaWiki-commits] [Gerrit] Fix documentation typo - change (mediawiki/core)

2014-04-04 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/124045 Change subject: Fix documentation typo .. Fix documentation typo Change-Id: I535dd23eeccd6686c64a885f06e030b756e67fec --- M

[MediaWiki-commits] [Gerrit] Add missing messages to RL module - change (mediawiki...UploadWizard)

2014-03-25 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/120968 Change subject: Add missing messages to RL module .. Add missing messages to RL module I assume this has gone unnoticed due to commons

[MediaWiki-commits] [Gerrit] Fix typo in documentation - change (VisualEditor/VisualEditor)

2014-03-24 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/120594 Change subject: Fix typo in documentation .. Fix typo in documentation Change-Id: Ief67028a676865a530200e20f219c3c6ae91b01e --- M

[MediaWiki-commits] [Gerrit] Delint and general mw.UploadWizardUpload cleanup - change (mediawiki...UploadWizard)

2014-03-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/119639 Change subject: Delint and general mw.UploadWizardUpload cleanup .. Delint and general mw.UploadWizardUpload cleanup Change-Id:

[MediaWiki-commits] [Gerrit] Properly teardown TOC widget - change (mediawiki...VisualEditor)

2014-03-19 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/119655 Change subject: Properly teardown TOC widget .. Properly teardown TOC widget Change-Id: Ib115024b4e50ac379e5b8689ae796fce3586d386 --- M

[MediaWiki-commits] [Gerrit] WIP: TOC widget - change (mediawiki...VisualEditor)

2014-01-22 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/108945 Change subject: WIP: TOC widget .. WIP: TOC widget Change-Id: I488cfbbdb060e50d81f51e0f757e67d0114b8936 --- M VisualEditor.php M

[MediaWiki-commits] [Gerrit] Provide content format faux reqeust now that content format ... - change (mediawiki...VisualEditor)

2014-01-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/106619 Change subject: Provide content format faux reqeust now that content format is validated .. Provide content format faux reqeust now that

[MediaWiki-commits] [Gerrit] Provide content format faux reqeust now that content format ... - change (mediawiki...VisualEditor)

2014-01-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/106621 Change subject: Provide content format faux reqeust now that content format is validated .. Provide content format faux reqeust now that

[MediaWiki-commits] [Gerrit] Create mixin for node that responds to node click events - change (VisualEditor/VisualEditor)

2013-12-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/103062 Change subject: Create mixin for node that responds to node click events .. Create mixin for node that responds to node click events

[MediaWiki-commits] [Gerrit] Add clickableNode to MwImageNode - change (mediawiki...VisualEditor)

2013-12-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/103063 Change subject: Add clickableNode to MwImageNode .. Add clickableNode to MwImageNode Change-Id: I6b45018bdb719e36a85a785d4e08d32ee4b9b0a3

[MediaWiki-commits] [Gerrit] Prevent getSaveFields from returning a property named undefined - change (mediawiki...VisualEditor)

2013-12-18 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/102591 Change subject: Prevent getSaveFields from returning a property named undefined .. Prevent getSaveFields from returning a property named

[MediaWiki-commits] [Gerrit] Move additional module loading to viewPage vs general target - change (mediawiki...VisualEditor)

2013-12-17 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/102368 Change subject: Move additional module loading to viewPage vs general target .. Move additional module loading to viewPage vs general target

[MediaWiki-commits] [Gerrit] Configure ext.wikimediaEvents.ve to be compatible with mobile - change (mediawiki...WikimediaEvents)

2013-12-11 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/100835 Change subject: Configure ext.wikimediaEvents.ve to be compatible with mobile .. Configure ext.wikimediaEvents.ve to be compatible with

[MediaWiki-commits] [Gerrit] Move save error tracking into target subclass - change (mediawiki...VisualEditor)

2013-12-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/100520 Change subject: Move save error tracking into target subclass .. Move save error tracking into target subclass Primary reasons for this

[MediaWiki-commits] [Gerrit] Added handling for captcha support on saveError - change (mediawiki...MobileFrontend)

2013-12-06 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/99773 Change subject: Added handling for captcha support on saveError .. Added handling for captcha support on saveError Copied _showCaptcha

[MediaWiki-commits] [Gerrit] Add editing and preview messages to header area - change (mediawiki...MobileFrontend)

2013-12-06 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/99776 Change subject: Add editing and preview messages to header area .. Add editing and preview messages to header area Change-Id:

[MediaWiki-commits] [Gerrit] Prefetch wikitext on summary screen - change (mediawiki...MobileFrontend)

2013-12-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/99591 Change subject: Prefetch wikitext on summary screen .. Prefetch wikitext on summary screen This reflects recent major changes to the save

[MediaWiki-commits] [Gerrit] Add general errorHandling to VisualEditorOverlay - change (mediawiki...MobileFrontend)

2013-12-04 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/99172 Change subject: Add general errorHandling to VisualEditorOverlay .. Add general errorHandling to VisualEditorOverlay Change-Id:

[MediaWiki-commits] [Gerrit] Split apart onSaveError logic for other mw targets - change (mediawiki...VisualEditor)

2013-12-02 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/98713 Change subject: Split apart onSaveError logic for other mw targets .. Split apart onSaveError logic for other mw targets Change-Id:

[MediaWiki-commits] [Gerrit] Toggle veaction-edit class on the body of the view page - change (mediawiki...VisualEditor)

2013-11-26 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/97702 Change subject: Toggle veaction-edit class on the body of the view page .. Toggle veaction-edit class on the body of the view page This

[MediaWiki-commits] [Gerrit] Remove unused badtoken error handling as it is covered in on... - change (mediawiki...VisualEditor)

2013-11-26 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/97735 Change subject: Remove unused badtoken error handling as it is covered in onSaveError .. Remove unused badtoken error handling as it is

[MediaWiki-commits] [Gerrit] Create base mobile init modules and set targets - change (mediawiki...VisualEditor)

2013-11-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/93914 Change subject: Create base mobile init modules and set targets .. Create base mobile init modules and set targets Target mobile for ve

[MediaWiki-commits] [Gerrit] WIP: Target mobile on ve dependencies - change (mediawiki/core)

2013-11-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/93915 Change subject: WIP: Target mobile on ve dependencies .. WIP: Target mobile on ve dependencies Change-Id:

[MediaWiki-commits] [Gerrit] WIP: Prototype ve editing on mobile. - change (mediawiki...MobileFrontend)

2013-11-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/93916 Change subject: WIP: Prototype ve editing on mobile. .. WIP: Prototype ve editing on mobile. Requirements: Visualeditor and Parsoid VE

[MediaWiki-commits] [Gerrit] Modify epoch test to restore original url on teardown - change (mediawiki...MobileFrontend)

2013-10-24 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/91635 Change subject: Modify epoch test to restore original url on teardown .. Modify epoch test to restore original url on teardown Refreshing

[MediaWiki-commits] [Gerrit] Eliminate api fixmes from PageApi - change (mediawiki...MobileFrontend)

2013-10-23 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/91532 Change subject: Eliminate api fixmes from PageApi .. Eliminate api fixmes from PageApi * revise lastmodified property returned by api **

[MediaWiki-commits] [Gerrit] Cleanup on save dialog cruft fix updateWatchLink - change (mediawiki...VisualEditor)

2013-10-16 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/90262 Change subject: Cleanup on save dialog cruft fix updateWatchLink .. Cleanup on save dialog cruft fix updateWatchLink Change-Id:

[MediaWiki-commits] [Gerrit] Use existing reference to wgVisualEditorConfig - change (mediawiki...VisualEditor)

2013-10-15 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/89868 Change subject: Use existing reference to wgVisualEditorConfig .. Use existing reference to wgVisualEditorConfig Change-Id:

[MediaWiki-commits] [Gerrit] Use existing ve config for pluginModules - change (mediawiki...VisualEditor)

2013-10-15 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/89875 Change subject: Use existing ve config for pluginModules .. Use existing ve config for pluginModules Change-Id:

[MediaWiki-commits] [Gerrit] The amazing mystery of scrollTop and onscroll - change (mediawiki...VisualEditor)

2013-10-08 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: The amazing mystery of scrollTop and onscroll .. The amazing mystery of scrollTop and onscroll What I learned today: * Window doesn't have a scrollTop

[MediaWiki-commits] [Gerrit] The amazing mystery of scrollTop and onscroll - change (mediawiki...VisualEditor)

2013-10-08 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: The amazing mystery of scrollTop and onscroll .. The amazing mystery of scrollTop and onscroll What I learned today: * Window doesn't have a scrollTop

[MediaWiki-commits] [Gerrit] Update VisualEditor to wmf19 branch for cherry-picks - change (mediawiki/core)

2013-10-08 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/88675 Change subject: Update VisualEditor to wmf19 branch for cherry-picks .. Update VisualEditor to wmf19 branch for cherry-picks Change-Id:

[MediaWiki-commits] [Gerrit] WIP Create ve.ce.ClickableNode mixin. - change (mediawiki...VisualEditor)

2013-09-16 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/84461 Change subject: WIP Create ve.ce.ClickableNode mixin. .. WIP Create ve.ce.ClickableNode mixin. Objective: To sanely bind a click ( or double

[MediaWiki-commits] [Gerrit] Cleanup whitespace issues and remove some overqualified and ... - change (mediawiki...Flow)

2013-09-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/83431 Change subject: Cleanup whitespace issues and remove some overqualified and unused selectors .. Cleanup whitespace issues and remove some

[MediaWiki-commits] [Gerrit] Add abstract method for getMediaSources. - change (mediawiki...VisualEditor)

2013-09-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/83041 Change subject: Add abstract method for getMediaSources. .. Add abstract method for getMediaSources. Change-Id:

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-08-28 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/81594 Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: I2d855af98d0cde7110165127793ce3cf1b48947b --- M

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-08-28 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: I2d855af98d0cde7110165127793ce3cf1b48947b --- M extensions/VisualEditor 1 file

[MediaWiki-commits] [Gerrit] Create ve MWModal interstitial - change (mediawiki...VisualEditor)

2013-08-01 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/77248 Change subject: Create ve MWModal interstitial .. Create ve MWModal interstitial For configured wikis, show MWModal on the first load of

[MediaWiki-commits] [Gerrit] update visualeditor to master - change (mediawiki/core)

2013-07-31 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/77068 Change subject: update visualeditor to master .. update visualeditor to master Change-Id: I5fd8a31a3ce6c48b5f10e169aa8e6b09b81aee40 --- M

[MediaWiki-commits] [Gerrit] update visualeditor to master - change (mediawiki/core)

2013-07-31 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: update visualeditor to master .. update visualeditor to master Change-Id: I5fd8a31a3ce6c48b5f10e169aa8e6b09b81aee40 --- M extensions/VisualEditor 1 file

[MediaWiki-commits] [Gerrit] WIP: media location editing - change (mediawiki...VisualEditor)

2013-07-22 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/75147 Change subject: WIP: media location editing .. WIP: media location editing Needs location icons Dependant on media-settings base Change-Id:

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-07-17 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/74180 Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: Ie78054f43de3cefa60fa771214e3566b70d8a976 --- M

[MediaWiki-commits] [Gerrit] WIP: Add size widget to media edit dialog - change (mediawiki...VisualEditor)

2013-07-16 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/74082 Change subject: WIP: Add size widget to media edit dialog .. WIP: Add size widget to media edit dialog TODO: Documentation! Change-Id:

[MediaWiki-commits] [Gerrit] Normalize image titles in cache to prevent duplicates. - change (mediawiki...VisualEditor)

2013-07-11 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73190 Change subject: Normalize image titles in cache to prevent duplicates. .. Normalize image titles in cache to prevent duplicates. Bug: 50158

[MediaWiki-commits] [Gerrit] Adjust toolbar group margins for equal vertical alignment - change (mediawiki...VisualEditor)

2013-07-11 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73198 Change subject: Adjust toolbar group margins for equal vertical alignment .. Adjust toolbar group margins for equal vertical alignment

[MediaWiki-commits] [Gerrit] Focus link inspector input prior to lookup. - change (mediawiki...VisualEditor)

2013-07-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/72985 Change subject: Focus link inspector input prior to lookup. .. Focus link inspector input prior to lookup. Since the menu only shows while

[MediaWiki-commits] [Gerrit] Bind listener to keyup to capture arrows better math for s... - change (mediawiki...VisualEditor)

2013-07-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73015 Change subject: Bind listener to keyup to capture arrows better math for scrolling. .. Bind listener to keyup to capture arrows better

[MediaWiki-commits] [Gerrit] Add protected semiprotected notices to api. - change (mediawiki...VisualEditor)

2013-07-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73022 Change subject: Add protected semiprotected notices to api. .. Add protected semiprotected notices to api. Bug: 50415 Change-Id:

[MediaWiki-commits] [Gerrit] Add notices for pages protected from creation - change (mediawiki...VisualEditor)

2013-07-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73043 Change subject: Add notices for pages protected from creation .. Add notices for pages protected from creation Change-Id:

[MediaWiki-commits] [Gerrit] When normalizing category titles with mw.Title, use getMain ... - change (mediawiki...VisualEditor)

2013-07-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/73116 Change subject: When normalizing category titles with mw.Title, use getMain method .. When normalizing category titles with mw.Title, use

[MediaWiki-commits] [Gerrit] Affordances for MenuWidget to be optionally focusable. - change (mediawiki...VisualEditor)

2013-07-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/72768 Change subject: Affordances for MenuWidget to be optionally focusable. .. Affordances for MenuWidget to be optionally focusable. *

[MediaWiki-commits] [Gerrit] Be sure lookupMenu input is focused before showing inputMenu. - change (mediawiki...VisualEditor)

2013-07-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/72849 Change subject: Be sure lookupMenu input is focused before showing inputMenu. .. Be sure lookupMenu input is focused before showing

[MediaWiki-commits] [Gerrit] Decrease the time it takes to focus the input element. - change (mediawiki...VisualEditor)

2013-07-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/72852 Change subject: Decrease the time it takes to focus the input element. .. Decrease the time it takes to focus the input element. Having such

[MediaWiki-commits] [Gerrit] Listen to keypress in ve.ce.surface.$ rather than window. - change (mediawiki...VisualEditor)

2013-07-03 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/71844 Change subject: Listen to keypress in ve.ce.surface.$ rather than window. .. Listen to keypress in ve.ce.surface.$ rather than window. Bug:

[MediaWiki-commits] [Gerrit] Restore focus to documentNode on convert - change (mediawiki...VisualEditor)

2013-07-01 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/71388 Change subject: Restore focus to documentNode on convert .. Restore focus to documentNode on convert Since format dropdown tool is the only

[MediaWiki-commits] [Gerrit] Don't draw highlights over hidden elements. - change (mediawiki...VisualEditor)

2013-06-28 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/71118 Change subject: Don't draw highlights over hidden elements. .. Don't draw highlights over hidden elements. Rational is that you wouldn't

[MediaWiki-commits] [Gerrit] Make local overlays local to surface and remove insane z-ind... - change (mediawiki...VisualEditor)

2013-06-27 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70851 Change subject: Make local overlays local to surface and remove insane z-indexes .. Make local overlays local to surface and remove insane

[MediaWiki-commits] [Gerrit] Don't advance cursor when adding new line at start of node - change (mediawiki...VisualEditor)

2013-06-27 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70864 Change subject: Don't advance cursor when adding new line at start of node .. Don't advance cursor when adding new line at start of node

[MediaWiki-commits] [Gerrit] If cursor is obscured by toolbar, on keypress scroll to cursor. - change (mediawiki...VisualEditor)

2013-06-27 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70918 Change subject: If cursor is obscured by toolbar, on keypress scroll to cursor. .. If cursor is obscured by toolbar, on keypress scroll to

[MediaWiki-commits] [Gerrit] Init surface after toolbar is setup vs. before. - change (mediawiki...VisualEditor)

2013-06-27 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70936 Change subject: Init surface after toolbar is setup vs. before. .. Init surface after toolbar is setup vs. before. This fixes all tools

[MediaWiki-commits] [Gerrit] Prevent visual effect on disabled toolbar buttons - change (mediawiki...VisualEditor)

2013-06-24 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70231 Change subject: Prevent visual effect on disabled toolbar buttons .. Prevent visual effect on disabled toolbar buttons Bug: 33113 Change-Id:

[MediaWiki-commits] [Gerrit] Don't put slugs after internal nodes. - change (mediawiki...VisualEditor)

2013-06-24 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/70333 Change subject: Don't put slugs after internal nodes. .. Don't put slugs after internal nodes. Bug: 50132 Change-Id:

[MediaWiki-commits] [Gerrit] Fix check for existing category in article. - change (mediawiki...VisualEditor)

2013-05-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/63241 Change subject: Fix check for existing category in article. .. Fix check for existing category in article. Now looking inside

[MediaWiki-commits] [Gerrit] Modify context to overlay $focusable element in focusableNode - change (mediawiki...VisualEditor)

2013-05-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/63243 Change subject: Modify context to overlay $focusable element in focusableNode .. Modify context to overlay $focusable element in

[MediaWiki-commits] [Gerrit] Do not merge. WIP for image suggestions - change (mediawiki...VisualEditor)

2013-05-07 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/62730 Change subject: Do not merge. WIP for image suggestions .. Do not merge. WIP for image suggestions TODO: 1) Lazily place images vs

[MediaWiki-commits] [Gerrit] Fixes to DM metaList stuff under Roan's guidance. - change (mediawiki...VisualEditor)

2013-04-11 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/58833 Change subject: Fixes to DM metaList stuff under Roan's guidance. .. Fixes to DM metaList stuff under Roan's guidance. Splitting this out of

[MediaWiki-commits] [Gerrit] Fix 404 on iframe styles by standardizing get and set module... - change (mediawiki...VisualEditor)

2013-04-10 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/58542 Change subject: Fix 404 on iframe styles by standardizing get and set modules methods. .. Fix 404 on iframe styles by standardizing get and

[MediaWiki-commits] [Gerrit] Hook in MetaList and MWCategoryMetaItems into category ui wi... - change (mediawiki...VisualEditor)

2013-04-09 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/58274 Change subject: Hook in MetaList and MWCategoryMetaItems into category ui widget .. Hook in MetaList and MWCategoryMetaItems into category ui

[MediaWiki-commits] [Gerrit] Enhance popupWidget with automatic closing when not focused. - change (mediawiki...VisualEditor)

2013-04-04 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/57684 Change subject: Enhance popupWidget with automatic closing when not focused. .. Enhance popupWidget with automatic closing when not focused.

[MediaWiki-commits] [Gerrit] Fix borked resource module for LabeledElement, and GroupElem... - change (mediawiki...VisualEditor)

2013-04-02 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/57179 Change subject: Fix borked resource module for LabeledElement, and GroupElement. .. Fix borked resource module for LabeledElement, and

[MediaWiki-commits] [Gerrit] Base commit for meta dialog category suggestion widget - change (mediawiki...VisualEditor)

2013-03-26 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/55853 Change subject: Base commit for meta dialog category suggestion widget .. Base commit for meta dialog category suggestion widget

[MediaWiki-commits] [Gerrit] Fix for (Bug 46025) Current annotation was being nullified. - change (mediawiki...VisualEditor)

2013-03-12 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/53488 Change subject: Fix for (Bug 46025) Current annotation was being nullified. .. Fix for (Bug 46025) Current annotation was being nullified.

[MediaWiki-commits] [Gerrit] In MW integration, dialog was overlapping toolbar shadow. - change (mediawiki...VisualEditor)

2013-03-08 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/52884 Change subject: In MW integration, dialog was overlapping toolbar shadow. .. In MW integration, dialog was overlapping toolbar shadow.

[MediaWiki-commits] [Gerrit] Emit apply and close dialog when apply changes is clicked. - change (mediawiki...VisualEditor)

2013-03-08 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/52921 Change subject: Emit apply and close dialog when apply changes is clicked. .. Emit apply and close dialog when apply changes is clicked. *

[MediaWiki-commits] [Gerrit] Tweak i18n for meta and content dialog title - change (mediawiki...VisualEditor)

2013-03-07 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/52725 Change subject: Tweak i18n for meta and content dialog title .. Tweak i18n for meta and content dialog title Change-Id:

[MediaWiki-commits] [Gerrit] More work on dialog classes and their mw specific handling. - change (mediawiki...VisualEditor)

2013-03-06 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/52538 Change subject: More work on dialog classes and their mw specific handling. .. More work on dialog classes and their mw specific handling.

[MediaWiki-commits] [Gerrit] Introduce configurable target views. - change (mediawiki...VisualEditor)

2013-02-20 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/50045 Change subject: Introduce configurable target views. .. Introduce configurable target views. Major changes: ve.init.Target.js * Create

[MediaWiki-commits] [Gerrit] (bug 36858) Improve message for negative numbers. - change (mediawiki...MoodBar)

2013-02-20 Thread Robmoen (Code Review)
Robmoen has submitted this change and it was merged. Change subject: (bug 36858) Improve message for negative numbers. .. (bug 36858) Improve message for negative numbers. Change-Id: Ide359174316131b1e8aa14415e168e091c4946cd

[MediaWiki-commits] [Gerrit] Abort activation when changing to view mode. - change (mediawiki...VisualEditor)

2013-02-11 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. Change subject: Abort activation when changing to view mode. .. Abort activation when changing to view mode. Resolves (Bug 44838) Changes: * onLoad: Setup only if activating.

[MediaWiki-commits] [Gerrit] Annotate newly inserted target text as a link. - change (mediawiki...VisualEditor)

2013-02-06 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. Change subject: Annotate newly inserted target text as a link. .. Annotate newly inserted target text as a link. Fixes (Bug 44086) Changes: ve.ui.LinkInspector.js - Annotate

[MediaWiki-commits] [Gerrit] Check for instance of generic LinkAnnotation when querying t... - change (mediawiki...VisualEditor[master])

2013-02-05 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review. Change subject: Check for instance of generic LinkAnnotation when querying target. .. Check for instance of generic LinkAnnotation when querying target. Resolves (Bug 44686)

<    1   2   3   4   5   >