[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove

2018-01-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405809 ) Change subject: Remove

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove

2018-01-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405809 ) Change subject: Remove

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove JSCS comments

2018-01-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405626 ) Change subject: Remove JSCS comments .. Remove JSCS comments Change-Id: I5ed4ae64800f2ba508302256ee85274ba7a0f5dd --- M src/ce/

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove JSCS comments

2018-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405626 ) Change subject: Remove JSCS comments .. Remove JSCS comments Change-Id: I5ed4ae64800f2ba508302256ee85274ba7a0f5dd --- M src/ce/ve.ce.TextS

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove server-only scripts from visualEditor.rebase

2017-09-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377768 ) Change subject: Remove server-only scripts from visualEditor.rebase .. Remove server-only scripts from visualEditor.rebase visu

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove server-only scripts from visualEditor.rebase

2017-09-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377768 ) Change subject: Remove server-only scripts from visualEditor.rebase .. Remove server-only scripts from visualEditor.rebase visualEditor.re

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove 'return' mapping as it is aliased to 'enter' below

2017-09-12 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377506 ) Change subject: Remove 'return' mapping as it is aliased to 'enter' below .. Remove 'return' mapping as it is aliased to 'enter'

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove 'return' mapping as it is aliased to 'enter' below

2017-09-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377506 ) Change subject: Remove 'return' mapping as it is aliased to 'enter' below .. Remove 'return' mapping as it is aliased to 'enter' below Cha

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove execute mode from non-executable

2017-08-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373590 ) Change subject: Remove execute mode from non-executable .. Remove execute mode from non-executable Change-Id: I15a2197f7395f1d4

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove execute mode from non-executable

2017-08-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373590 ) Change subject: Remove execute mode from non-executable .. Remove execute mode from non-executable Change-Id: I15a2197f7395f1d402bfecb3a998d

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unnecessary mixin from standalone image caption node

2017-07-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367883 ) Change subject: Remove unnecessary mixin from standalone image caption node .. Remove unnecessary mixin from standalone image ca

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unnecessary mixin from standalone image caption node

2017-07-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367883 ) Change subject: Remove unnecessary mixin from standalone image caption node .. Remove unnecessary mixin from standalone image caption node

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove custom icon sizing from block slugs

2017-06-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361861 ) Change subject: Remove custom icon sizing from block slugs .. Remove custom icon sizing from block slugs This causes alignment

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove custom icon sizing from block slugs

2017-06-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361861 ) Change subject: Remove custom icon sizing from block slugs .. Remove custom icon sizing from block slugs This causes alignment issues sinc

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove ⌘+M shortcut for removing styling on mavs

2017-06-16 Thread Deskana (Code Review)
Deskana has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359455 ) Change subject: Remove ⌘+M shortcut for removing styling on mavs .. Remove ⌘+M shortcut for removing styling on mavs Per T167898, this over

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused filibuster CSS

2017-06-07 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357579 ) Change subject: Remove unused filibuster CSS .. Remove unused filibuster CSS Filibuster doesn't generate any table cells. Chan

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused MWImage-specific CSS

2017-06-07 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357578 ) Change subject: Remove unused MWImage-specific CSS .. Remove unused MWImage-specific CSS This was moved into MW 3 years ago. C

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused table editor CSS

2017-06-07 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357577 ) Change subject: Remove unused table editor CSS .. Remove unused table editor CSS This is left over from before we implemented T

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused MWImage-specific CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357578 ) Change subject: Remove unused MWImage-specific CSS .. Remove unused MWImage-specific CSS This was moved into MW 3 years ago. Change-Id: I

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused filibuster CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357579 ) Change subject: Remove unused filibuster CSS .. Remove unused filibuster CSS Filibuster doesn't generate any table cells. Change-Id: I35f

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused table editor CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357577 ) Change subject: Remove unused table editor CSS .. Remove unused table editor CSS This is left over from before we implemented TableLineCon

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove 'cellable' attribute

2017-05-15 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/353712 ) Change subject: Remove 'cellable' attribute .. Remove 'cellable' attribute Now we have a separate class for AlienTableCell we c

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove eslint:fix

2017-04-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350872 ) Change subject: Remove eslint:fix .. Remove eslint:fix Not very useful now rules are stable. Change-Id: I62a84b89f1cbb5d66cd9a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove eslint:fix

2017-04-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350872 ) Change subject: Remove eslint:fix .. Remove eslint:fix Not very useful now rules are stable. Change-Id: I62a84b89f1cbb5d66cd9a5f62bc941eb

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove builtin padding from .ve-ce-documentNode

2017-04-12 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347977 ) Change subject: Remove builtin padding from .ve-ce-documentNode .. Remove builtin padding from .ve-ce-documentNode I think it's

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove more IE9 hacks

2017-04-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346815 ) Change subject: Remove more IE9 hacks .. Remove more IE9 hacks Change-Id: I0811ebd250ec8c87713440cbe4d8fbfab20a5aa8 --- M src/ce/styles/no

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove DiffElement DOM element when destroying

2017-04-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/346201 ) Change subject: Remove DiffElement DOM element when destroying .. Remove DiffElement DOM element when destroying Bug: T161877 C

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove DiffElement DOM element when destroying

2017-04-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346201 ) Change subject: Remove DiffElement DOM element when destroying .. Remove DiffElement DOM element when destroying Bug: T161877 Change-Id: I

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344800 ) Change subject: Remove superfluous setting of canContainContent when inheriting from CBN .. Remove superfluous setting of canCo

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

2017-03-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344800 ) Change subject: Remove superfluous setting of canContainContent when inheriting from CBN .. Remove superfluous setting of canContainConten

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove redundant setDisabled calls from tools extending ve.u...

2017-03-16 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343034 ) Change subject: Remove redundant setDisabled calls from tools extending ve.ui.Tool .. Remove redundant setDisabled calls from t

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove redundant setDisabled calls from tools extending ve.u...

2017-03-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343034 ) Change subject: Remove redundant setDisabled calls from tools extending ve.ui.Tool .. Remove redundant setDisabled calls from tools extend

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove $returnFocusTo hack now null is supported upstream

2017-03-10 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342227 ) Change subject: Remove $returnFocusTo hack now null is supported upstream .. Remove $returnFocusTo hack now null is supported up

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove $returnFocusTo hack now null is supported upstream

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342227 ) Change subject: Remove $returnFocusTo hack now null is supported upstream .. Remove $returnFocusTo hack now null is supported upstream Cha

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove used 'header' params from toolbar config

2017-02-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338637 ) Change subject: Remove used 'header' params from toolbar config .. Remove used 'header' params from toolbar config Change-Id: I

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove styles for non-existent toolbar-shadow

2017-02-20 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338742 ) Change subject: Remove styles for non-existent toolbar-shadow .. Remove styles for non-existent toolbar-shadow Change-Id: I49b4

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove styles for non-existent toolbar-shadow

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338742 ) Change subject: Remove styles for non-existent toolbar-shadow .. Remove styles for non-existent toolbar-shadow Change-Id: I49b4387314b893f

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove used 'header' params from toolbar config

2017-02-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338637 ) Change subject: Remove used 'header' params from toolbar config .. Remove used 'header' params from toolbar config Change-Id: I0611bd5d466

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove explicit toolbar indicator definitions

2017-02-06 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/335990 ) Change subject: Remove explicit toolbar indicator definitions .. Remove explicit toolbar indicator definitions These are now co

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove explicit toolbar indicator definitions

2017-02-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335990 ) Change subject: Remove explicit toolbar indicator definitions .. Remove explicit toolbar indicator definitions These are now computed upst

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove presynchronize, use precommit instead

2017-02-03 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/335640 ) Change subject: Remove presynchronize, use precommit instead .. Remove presynchronize, use precommit instead The presynchronize

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove presynchronize, use precommit instead

2017-02-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335640 ) Change subject: Remove presynchronize, use precommit instead .. Remove presynchronize, use precommit instead The presynchronize event didn'

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove mobile window logic upstreamed to OOUI

2017-01-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328518 ) Change subject: Remove mobile window logic upstreamed to OOUI .. Remove mobile window logic upstreamed to OOUI Depends on Idc49

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both u...

2017-01-03 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327148 ) Change subject: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both unused) .. Remove ve.getHtmlAttributes and ve.getOpe

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unit test hack, no longer needed.

2017-01-01 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329690 ) Change subject: Remove unit test hack, no longer needed. .. Remove unit test hack, no longer needed. Change-Id: Iff757ba0eac1ef

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove serialization test cheat; make tests actually pass

2017-01-01 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329657 ) Change subject: Remove serialization test cheat; make tests actually pass .. Remove serialization test cheat; make tests actuall

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unit test hack, no longer needed.

2016-12-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329690 ) Change subject: Remove unit test hack, no longer needed. .. Remove unit test hack, no longer needed. Change-Id: Iff757ba0eac1efb76ce343f33

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove serialization test cheat; make tests actually pass

2016-12-29 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329657 ) Change subject: Remove serialization test cheat; make tests actually pass .. Remove serialization test cheat; make tests actually pass The au

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove mobile window logic upstreamed to OOUI

2016-12-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328518 ) Change subject: Remove mobile window logic upstreamed to OOUI .. Remove mobile window logic upstreamed to OOUI Depends on Idc49819cd (like

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both u...

2016-12-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327148 ) Change subject: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both unused) .. Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (b

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unnecessary double-negation cast in if()

2016-11-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unnecessary double-negation cast in if() .. Remove unnecessary double-negation cast in if() if() expressions are automatically cast to booleans. T

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unnecessary double-negation cast in if()

2016-11-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/320399 Change subject: Remove unnecessary double-negation cast in if() .. Remove unnecessary double-negation cast in if() if() expressions are auto

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused eslint exceptions and old jshint comments

2016-11-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unused eslint exceptions and old jshint comments .. Remove unused eslint exceptions and old jshint comments Change-Id: I5140c7b1f949b9660b469d8add0

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused eslint exceptions and old jshint comments

2016-11-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/319312 Change subject: Remove unused eslint exceptions and old jshint comments .. Remove unused eslint exceptions and old jshint comments Change-Id

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove #rebuildTree calls and ensure #getDocumentNode is used

2016-10-31 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove #rebuildTree calls and ensure #getDocumentNode is used .. Remove #rebuildTree calls and ensure #getDocumentNode is used Change-Id: I2e95ea905f15196

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove #rebuildTree calls and ensure #getDocumentNode is used

2016-10-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318788 Change subject: Remove #rebuildTree calls and ensure #getDocumentNode is used .. Remove #rebuildTree calls and ensure #getDocumentNode is use

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove rules which have been moved upstream

2016-10-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove rules which have been moved upstream .. Remove rules which have been moved upstream Change-Id: I1be848230c90eb9d2cc71078add26a0ea7003bd4 --- M .esl

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove rules which have been moved upstream

2016-10-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318578 Change subject: Remove rules which have been moved upstream .. Remove rules which have been moved upstream Change-Id: I1be848230c90eb9d2cc71

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs binary space rule

2016-10-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove comment about jscs binary space rule .. Remove comment about jscs binary space rule This is correctly enforced in eslint. Change-Id: Ic2e77173fb2c

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs empty blocks rule

2016-10-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove comment about jscs empty blocks rule .. Remove comment about jscs empty blocks rule We do have an eslint rule, it just allows blocks with comments.

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove jshint comment, no rule required

2016-10-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove jshint comment, no rule required .. Remove jshint comment, no rule required Change-Id: Id785b33d7fb2cbd4983fe1efec8cd2fffd73f53d --- M src/ce/ve.ce

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs binary space rule

2016-10-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318482 Change subject: Remove comment about jscs binary space rule .. Remove comment about jscs binary space rule This is correctly enforced in esl

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs empty blocks rule

2016-10-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318481 Change subject: Remove comment about jscs empty blocks rule .. Remove comment about jscs empty blocks rule We do have an eslint rule, it jus

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove jshint comment, no rule required

2016-10-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318480 Change subject: Remove jshint comment, no rule required .. Remove jshint comment, no rule required Change-Id: Id785b33d7fb2cbd4983fe1efec8cd

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove items from DTH factory indexes when unregistering

2016-08-31 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove items from DTH factory indexes when unregistering .. Remove items from DTH factory indexes when unregistering Bug: T143954 Change-Id: I4a5a5de4dbd2

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove items from DTH factory caches when unregistering

2016-08-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/306967 Change subject: Remove items from DTH factory caches when unregistering .. Remove items from DTH factory caches when unregistering Bug: T143

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove duplicate properties defined in mixin ve.Node

2016-08-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove duplicate properties defined in mixin ve.Node .. Remove duplicate properties defined in mixin ve.Node Change-Id: I6bb3017b6b27e7f5ee4bf1423c3780b76

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove duplicate properties defined in mixin ve.Node

2016-08-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/304969 Change subject: Remove duplicate properties defined in mixin ve.Node .. Remove duplicate properties defined in mixin ve.Node Change-Id: I6bb