[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Only apply artificial delay to submitChange events

2018-01-23 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405927 ) Change subject: rebaser: Only apply artificial delay to submitChange events .. rebaser: Only apply artificial delay to submitChange events

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.dm.Change: Truncate stores as well as transactions on con...

2018-01-23 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405926 ) Change subject: ve.dm.Change: Truncate stores as well as transactions on conflict .. ve.dm.Change: Truncate stores as well as transactions

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Disable undo/usurp within SurfaceSynchronizer

2018-01-22 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405838 ) Change subject: Disable undo/usurp within SurfaceSynchronizer .. Disable undo/usurp within SurfaceSynchronizer Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Create ve.EventEmitter with emitCatch, and use it throughout...

2018-01-22 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405827 ) Change subject: Create ve.EventEmitter with emitCatch, and use it throughout ve.dm .. Create ve.EventEmitter with emitCatch, and use it

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use ve.dm.MetaList without explicitly requiring metadata off...

2018-01-21 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405664 ) Change subject: Use ve.dm.MetaList without explicitly requiring metadata offset/index .. Use ve.dm.MetaList without explicitly requiring

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Don't execute commands twice

2017-12-06 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395919 ) Change subject: Don't execute commands twice .. Don't execute commands twice Bug: T182270 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Destroy CE nodes on removal by onSplice

2017-11-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393436 ) Change subject: Destroy CE nodes on removal by onSplice .. Destroy CE nodes on removal by onSplice Bug: T179574 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: [BREAKING CHANGE] Refactor ve.dm.MetaList

2017-10-30 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387511 ) Change subject: WIP: [BREAKING CHANGE] Refactor ve.dm.MetaList .. WIP: [BREAKING CHANGE] Refactor ve.dm.MetaList Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix highly misleading comment

2017-10-27 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386974 ) Change subject: Fix highly misleading comment .. Fix highly misleading comment Change-Id: Ibb7a0a46a266253cdb096c1f5202fe16b11338f4 --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Get a ve.ce.BranchNode position's corresponding DOM pos...

2017-10-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383404 ) Change subject: WIP: Get a ve.ce.BranchNode position's corresponding DOM position .. WIP: Get a ve.ce.BranchNode position's corresponding

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Don't assume events have an originalEvent object

2017-10-07 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382971 ) Change subject: Don't assume events have an originalEvent object .. Don't assume events have an originalEvent object Because jQuery

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Do not setup inline slugs when rendering is locked

2017-09-26 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380900 ) Change subject: Do not setup inline slugs when rendering is locked .. Do not setup inline slugs when rendering is locked Bug: T176762

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make IME tests more consistent across test environments

2017-09-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380451 ) Change subject: Make IME tests more consistent across test environments .. Make IME tests more consistent across test environments Bug:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP dontmerge: dummy patchset to check whether CI fails

2017-09-21 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379695 ) Change subject: WIP dontmerge: dummy patchset to check whether CI fails .. WIP dontmerge: dummy patchset to check whether CI fails

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Setup slugs in TreeModifier

2017-09-16 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378378 ) Change subject: Setup slugs in TreeModifier .. Setup slugs in TreeModifier Bug: T175852 Change-Id: I9cea81cfe71d97a38e3fdf30015d8389eedde756

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ce.BranchNode#splice: disconnect nodes fully

2017-09-12 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377510 ) Change subject: ve.ce.BranchNode#splice: disconnect nodes fully .. ve.ce.BranchNode#splice: disconnect nodes fully Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Notification for DM node attached/detached

2017-09-11 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377237 ) Change subject: WIP: Notification for DM node attached/detached .. WIP: Notification for DM node attached/detached Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix crashes when placeholder replacement contains references

2017-09-05 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376077 ) Change subject: Fix crashes when placeholder replacement contains references .. Fix crashes when placeholder replacement contains references

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Fix failing test

2017-08-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373864 ) Change subject: Fix failing test .. Fix failing test Change-Id: If62aa152af63fc17526cc6d836bf551cdb12e57f --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Don't use eslint-config-wikimedia 0.4.0

2017-08-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371758 ) Change subject: Don't use eslint-config-wikimedia 0.4.0 .. Don't use eslint-config-wikimedia 0.4.0 It fails to let you mark code as ES6

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Fix expected remove data to match actual remove data exactly

2017-08-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371718 ) Change subject: Fix expected remove data to match actual remove data exactly .. Fix expected remove data to match actual remove data exactly

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWLinkAction: Don't annotate close tags

2017-08-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371717 ) Change subject: MWLinkAction: Don't annotate close tags .. MWLinkAction: Don't annotate close tags Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: QUnit 2 compatibility fixes

2017-08-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371062 ) Change subject: QUnit 2 compatibility fixes .. QUnit 2 compatibility fixes Change-Id: I737fabe4412a20627ca7a8a60da741583c79eeba --- M

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: WIP: Avoid segmenting within certain types of tag

2017-08-09 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370869 ) Change subject: WIP: Avoid segmenting within certain types of tag .. WIP: Avoid segmenting within certain types of tag To avoid adding spans

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Expose ve.ui.MWInternalLinkContextItem generateBody logic

2017-08-09 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370823 ) Change subject: Expose ve.ui.MWInternalLinkContextItem generateBody logic .. Expose ve.ui.MWInternalLinkContextItem generateBody logic

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: WIP: Miscellaneous support for ContentTranslation

2017-07-05 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363521 ) Change subject: WIP: Miscellaneous support for ContentTranslation .. WIP: Miscellaneous support for ContentTranslation Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: TransactionProcessor: modify DM tree branches instead of reb...

2017-06-04 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357171 ) Change subject: TransactionProcessor: modify DM tree branches instead of rebuilding them .. TransactionProcessor: modify DM tree branches

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Fixes to TreeModifier

2017-05-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355605 ) Change subject: WIP: Fixes to TreeModifier .. WIP: Fixes to TreeModifier TODO: * Decide what to do about the metadata failures * Un-revert

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Tree modifications: don't presume the tree is in sync with t...

2017-05-20 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354888 ) Change subject: Tree modifications: don't presume the tree is in sync with the linear model .. Tree modifications: don't presume the tree is

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaseUncommittedChange: remove weird duplicated selection u...

2017-05-20 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354692 ) Change subject: rebaseUncommittedChange: remove weird duplicated selection update code .. rebaseUncommittedChange: remove weird duplicated

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.dm.SurfaceFragment#delete: Don't pre-build a sequence of ...

2017-05-16 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353994 ) Change subject: ve.dm.SurfaceFragment#delete: Don't pre-build a sequence of transactions .. ve.dm.SurfaceFragment#delete: Don't pre-build a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Process transaction before selecting nodes for annotation ev...

2017-05-14 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353830 ) Change subject: Process transaction before selecting nodes for annotation events .. Process transaction before selecting nodes for annotation

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Restructure DM tree instead of rebuilding it afresh

2017-04-17 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348450 ) Change subject: WIP: Restructure DM tree instead of rebuilding it afresh .. WIP: Restructure DM tree instead of rebuilding it afresh TODO:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: When setting ce=true/false on a ve.ce.DocumentNode, change d...

2017-04-01 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345955 ) Change subject: When setting ce=true/false on a ve.ce.DocumentNode, change descendants too .. When setting ce=true/false on a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Serialize/deserialize for Transaction and IndexValueStore

2017-03-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344812 ) Change subject: Serialize/deserialize for Transaction and IndexValueStore .. Serialize/deserialize for Transaction and IndexValueStore

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: When indexing originalDomElements for ve.dm.Annotations, dis...

2017-03-18 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343458 ) Change subject: When indexing originalDomElements for ve.dm.Annotations, disregard child nodes .. When indexing originalDomElements for

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Update bin/apertium-xhtml to work with config.yaml

2017-02-09 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336957 ) Change subject: Update bin/apertium-xhtml to work with config.yaml .. Update bin/apertium-xhtml to work with config.yaml Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Destroy unicorns properly when cursoring to another branch node

2017-02-03 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335962 ) Change subject: Destroy unicorns properly when cursoring to another branch node .. Destroy unicorns properly when cursoring to another branch

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Check correctly whether the cursor crossed a preunicorn

2017-02-02 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335641 ) Change subject: Check correctly whether the cursor crossed a preunicorn .. Check correctly whether the cursor crossed a preunicorn Without

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIPissimo: RebaseServer persistent storage

2017-01-30 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334995 ) Change subject: WIPissimo: RebaseServer persistent storage .. WIPissimo: RebaseServer persistent storage Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Include oojs-ui-core.js in debugging pages

2017-01-22 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333561 ) Change subject: Include oojs-ui-core.js in debugging pages .. Include oojs-ui-core.js in debugging pages Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Minor changes to RebaseServer

2017-01-11 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331822 ) Change subject: Minor changes to RebaseServer .. Minor changes to RebaseServer Change-Id: I59d1995fa6330c6ee6ffa9fc06079a2d39ebe67d --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Make RebaseServer asynchronous

2017-01-09 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331423 ) Change subject: WIP: Make RebaseServer asynchronous .. WIP: Make RebaseServer asynchronous Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove serialization test cheat; make tests actually pass

2016-12-29 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329657 ) Change subject: Remove serialization test cheat; make tests actually pass .. Remove serialization test cheat; make tests actually pass The

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make BlockquoteNode fully non-ContentBranchNode

2016-12-28 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329448 ) Change subject: Make BlockquoteNode fully non-ContentBranchNode .. Make BlockquoteNode fully non-ContentBranchNode Before, BlockquoteNode

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Refactor ve.dm.TransactionBuilder#newFromWrap

2016-12-21 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328583 ) Change subject: Refactor ve.dm.TransactionBuilder#newFromWrap .. Refactor ve.dm.TransactionBuilder#newFromWrap Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both u...

2016-12-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327148 ) Change subject: Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag (both unused) .. Remove ve.getHtmlAttributes and ve.getOpeningHtmlTag

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use try-finally instead of try-catch-rethrow

2016-12-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327143 ) Change subject: Use try-finally instead of try-catch-rethrow .. Use try-finally instead of try-catch-rethrow This works better with

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix socket.io-client path

2016-12-06 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/325575 Change subject: Fix socket.io-client path .. Fix socket.io-client path Change-Id: If83a2ab094b7497b3c71e6915dd35912ebcbdaf9 --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Refactor ve.dm.Transaction

2016-11-30 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/324415 Change subject: Refactor ve.dm.Transaction .. Refactor ve.dm.Transaction * Create ve.dm.TransactionBuilder; put ve.dm.Transaction-building

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Focusable cursor tests: place cursor in cursorHolders

2016-11-28 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/324029 Change subject: Focusable cursor tests: place cursor in cursorHolders .. Focusable cursor tests: place cursor in cursorHolders Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Hijack EventSequencer timeouts in unit testing

2016-11-28 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/324028 Change subject: Hijack EventSequencer timeouts in unit testing .. Hijack EventSequencer timeouts in unit testing Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: OOjs: remove internal lib/ version and use npm instead

2016-11-23 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/323353 Change subject: OOjs: remove internal lib/ version and use npm instead .. OOjs: remove internal lib/ version and use npm instead Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Rebase logic

2016-11-21 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/322714 Change subject: Rebase logic .. Rebase logic Change-Id: I2876abff50eb37a80b8c2407db64a6e39393aed1 --- M build/modules.json A

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Partial change rebasing in the case of conflicts

2016-11-03 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/319522 Change subject: WIP: Partial change rebasing in the case of conflicts .. WIP: Partial change rebasing in the case of conflicts Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.dm.Transaction: add 'author' field

2016-10-22 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/317373 Change subject: ve.dm.Transaction: add 'author' field .. ve.dm.Transaction: add 'author' field Also remove toJSON method, as it is no longer

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix translateRange bug that expands selections

2016-10-22 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/317330 Change subject: Fix translateRange bug that expands selections .. Fix translateRange bug that expands selections Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Human-readable transaction summary

2016-10-20 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/317094 Change subject: Human-readable transaction summary .. Human-readable transaction summary Change-Id: I6920514df81c304a02a672a2eabffb91a8f1e5e7

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Allow shallow clone of whole document

2016-10-20 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/317088 Change subject: Allow shallow clone of whole document .. Allow shallow clone of whole document Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.sparseSplice: Splice one array into another, replicating ...

2016-10-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/315657 Change subject: ve.sparseSplice: Splice one array into another, replicating any holes .. ve.sparseSplice: Splice one array into another,

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.Range: Don't fixup invalid arguments

2016-10-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/315199 Change subject: ve.Range: Don't fixup invalid arguments .. ve.Range: Don't fixup invalid arguments Hitherto, calls such as "new ve.Range( NaN,

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Apply inserted annotations above background annotation stack

2016-10-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/315198 Change subject: Apply inserted annotations above background annotation stack .. Apply inserted annotations above background annotation stack

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Optimize batchPush on small lists

2016-10-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/315196 Change subject: Optimize batchPush on small lists .. Optimize batchPush on small lists Doubles the speed of ve.batchPush( [], [ 1, 2, 3, 4, 5

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Check for null keyDownSelectionState in handlers

2016-10-04 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/313997 Change subject: Check for null keyDownSelectionState in handlers .. Check for null keyDownSelectionState in handlers Bug: T147304 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: On CBN detach, mark contentBranchNodeChanged in the CE Surface

2016-09-18 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/311371 Change subject: On CBN detach, mark contentBranchNodeChanged in the CE Surface .. On CBN detach, mark contentBranchNodeChanged in the CE

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Test selections without relying on a ve.dm.Surface select ev...

2016-09-17 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/311238 Change subject: Test selections without relying on a ve.dm.Surface select event listener .. Test selections without relying on a ve.dm.Surface

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests

2016-09-14 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/310544 Change subject: Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests .. Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make ve.dm.Transaction plain data by removing the .doc property

2016-09-06 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/308925 Change subject: Make ve.dm.Transaction plain data by removing the .doc property .. Make ve.dm.Transaction plain data by removing the .doc

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo

2016-09-06 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/308919 Change subject: Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo .. Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo Seems

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make ve.dm.IndexValueStore ordered, append-only and slicable

2016-08-24 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/306480 Change subject: Make ve.dm.IndexValueStore ordered, append-only and slicable .. Make ve.dm.IndexValueStore ordered, append-only and slicable

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: collab-service

2016-08-18 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/305564 Change subject: WIP: collab-service .. WIP: collab-service Change-Id: I068447d8155b0732c08d642357dab07cfca5aa2a --- A collab/Collab.js A

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: ve.dm.Change class with rebase operations

2016-08-18 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/305563 Change subject: WIP: ve.dm.Change class with rebase operations .. WIP: ve.dm.Change class with rebase operations Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP: Function to rebase a transaction onto another

2016-08-17 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/305438 Change subject: WIP: Function to rebase a transaction onto another .. WIP: Function to rebase a transaction onto another Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Forcibly reapply selection on insertion annotation change, t...

2016-08-11 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/304325 Change subject: Forcibly reapply selection on insertion annotation change, to move between unicorns .. Forcibly reapply selection on insertion

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix TextState#getChangeTransaction bug

2016-08-10 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/304135 Change subject: Fix TextState#getChangeTransaction bug .. Fix TextState#getChangeTransaction bug Also document the algorithm more clearly

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Always call back if SurfaceObserver sees a branch node change

2016-08-05 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/303335 Change subject: Always call back if SurfaceObserver sees a branch node change .. Always call back if SurfaceObserver sees a branch node change

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: WIP: Hide text without confusing Chromium's cursoring

2016-08-04 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/303008 Change subject: WIP: Hide text without confusing Chromium's cursoring .. WIP: Hide text without confusing Chromium's cursoring Change-Id:

[MediaWiki-commits] [Gerrit] TransactionProcessor: Apply annotations to ranges at the hig... - change (VisualEditor/VisualEditor)

2016-07-18 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/299570 Change subject: TransactionProcessor: Apply annotations to ranges at the highest uniform offset .. TransactionProcessor: Apply annotations to

[MediaWiki-commits] [Gerrit] New decodeURIComponentIntoArticleTitle method - change (mediawiki...VisualEditor)

2016-06-14 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/294393 Change subject: New decodeURIComponentIntoArticleTitle method .. New decodeURIComponentIntoArticleTitle method This replaces

[MediaWiki-commits] [Gerrit] Rename keyDownState.selection to keyDownState.selectionState - change (VisualEditor/VisualEditor)

2016-06-07 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/293093 Change subject: Rename keyDownState.selection to keyDownState.selectionState .. Rename keyDownState.selection to keyDownState.selectionState

[MediaWiki-commits] [Gerrit] Clarify EventSequencer listener slice/splice behaviour - change (VisualEditor/VisualEditor)

2016-06-07 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/293088 Change subject: Clarify EventSequencer listener slice/splice behaviour .. Clarify EventSequencer listener slice/splice behaviour Change-Id:

[MediaWiki-commits] [Gerrit] Document the purpose of setTimeout calls in ve.ce.Surface - change (VisualEditor/VisualEditor)

2016-06-06 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/292895 Change subject: Document the purpose of setTimeout calls in ve.ce.Surface .. Document the purpose of setTimeout calls in ve.ce.Surface

[MediaWiki-commits] [Gerrit] WIP: Preserve prior valid DOM selections in showModelSelection - change (VisualEditor/VisualEditor)

2016-06-05 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/292835 Change subject: WIP: Preserve prior valid DOM selections in showModelSelection .. WIP: Preserve prior valid DOM selections in

[MediaWiki-commits] [Gerrit] WIP: Calculate model ranges on demand, not RangeState creation - change (VisualEditor/VisualEditor)

2016-05-24 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/290425 Change subject: WIP: Calculate model ranges on demand, not RangeState creation .. WIP: Calculate model ranges on demand, not RangeState

[MediaWiki-commits] [Gerrit] Handle about groups correctly in getNodeAndOffset - change (VisualEditor/VisualEditor)

2016-05-04 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/287048 Change subject: Handle about groups correctly in getNodeAndOffset .. Handle about groups correctly in getNodeAndOffset Bug: T133608 Change-Id:

[MediaWiki-commits] [Gerrit] Reinstate Firefox img hack for versions >= 38 - change (VisualEditor/VisualEditor)

2016-04-26 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/285579 Change subject: Reinstate Firefox img hack for versions >= 38 .. Reinstate Firefox img hack for versions >= 38 Partially reverts

[MediaWiki-commits] [Gerrit] Update cursor holders in showModelSelection - change (VisualEditor/VisualEditor)

2016-04-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/285335 Change subject: Update cursor holders in showModelSelection .. Update cursor holders in showModelSelection Bug: T131674 Change-Id:

[MediaWiki-commits] [Gerrit] Fix ve.ce.KeyDownHandlerFactory.name - change (VisualEditor/VisualEditor)

2016-04-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/285331 Change subject: Fix ve.ce.KeyDownHandlerFactory.name .. Fix ve.ce.KeyDownHandlerFactory.name Change-Id:

[MediaWiki-commits] [Gerrit] WIP DONTMERGE: IME UI integration - change (mediawiki...UniversalLanguageSelector)

2016-04-13 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/283197 Change subject: WIP DONTMERGE: IME UI integration .. WIP DONTMERGE: IME UI integration Change-Id: I796fa6b5425e108f9b6b17f1b0f1579616619b6e

[MediaWiki-commits] [Gerrit] WIP DONTMERGE: integrate jquery.ime UI - change (mediawiki...VisualEditor)

2016-03-27 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/279747 Change subject: WIP DONTMERGE: integrate jquery.ime UI .. WIP DONTMERGE: integrate jquery.ime UI TODO: - Fix the UI - Improve jquery.ime

[MediaWiki-commits] [Gerrit] WIP DONTMERGE: integrate jquery.ime UI - change (mediawiki...VisualEditor)

2016-03-27 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/279748 Change subject: WIP DONTMERGE: integrate jquery.ime UI .. WIP DONTMERGE: integrate jquery.ime UI TODO: - Fix the UI - Improve jquery.ime

[MediaWiki-commits] [Gerrit] Emulated setTimeout for unit testing - change (oojs/ui)

2016-03-15 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/277594 Change subject: Emulated setTimeout for unit testing .. Emulated setTimeout for unit testing Bug: T130064 Change-Id:

[MediaWiki-commits] [Gerrit] WIP DONTMERGE: integrate jquery.ime UI - change (VisualEditor/VisualEditor)

2016-03-09 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/276145 Change subject: WIP DONTMERGE: integrate jquery.ime UI .. WIP DONTMERGE: integrate jquery.ime UI Needs tidying up Change-Id:

[MediaWiki-commits] [Gerrit] Use offset paths in selection state tests - change (VisualEditor/VisualEditor)

2016-02-28 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/273762 Change subject: Use offset paths in selection state tests .. Use offset paths in selection state tests This will facilitate expected positions

[MediaWiki-commits] [Gerrit] Make getSelectionState preserve collapsedness - change (VisualEditor/VisualEditor)

2016-02-26 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/273435 Change subject: Make getSelectionState preserve collapsedness .. Make getSelectionState preserve collapsedness Bug: T128176 Change-Id:

[MediaWiki-commits] [Gerrit] Clarify documentation of directionality methods - change (VisualEditor/VisualEditor)

2016-02-16 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/271064 Change subject: Clarify documentation of directionality methods .. Clarify documentation of directionality methods Change-Id:

[MediaWiki-commits] [Gerrit] WIP: Refactor getNodeAndOffset - change (VisualEditor/VisualEditor)

2016-02-12 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/270315 Change subject: WIP: Refactor getNodeAndOffset .. WIP: Refactor getNodeAndOffset Change-Id: I8b833feee813b10004fc9f1cf862a6fdbf7e1634 --- M

[MediaWiki-commits] [Gerrit] Document annotation content container usage - change (VisualEditor/VisualEditor)

2016-02-11 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/269988 Change subject: Document annotation content container usage .. Document annotation content container usage Explicitly state the usage

[MediaWiki-commits] [Gerrit] Handle Enter keyPress without matching keyDown - change (VisualEditor/VisualEditor)

2016-02-08 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/269362 Change subject: Handle Enter keyPress without matching keyDown .. Handle Enter keyPress without matching keyDown This can happen with OS X

[MediaWiki-commits] [Gerrit] Utility function for "index of node in its parentNode's chil... - change (VisualEditor/VisualEditor)

2016-02-03 Thread Divec (Code Review)
Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/268061 Change subject: Utility function for "index of node in its parentNode's childNode list" .. Utility function for "index of node in its

  1   2   3   >