[Differential] [Updated, 124 lines] D76: contrib: add a codemod script to rewrite nested with

quark updated this revision to Diff 127. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D76?vs=124=127 REVISION DETAIL https://phab.mercurial-scm.org/D76 AFFECTED FILES contrib/codemod/codemod_nestedwith.py tests/hghave.py

[PATCH 2 of 2] test-amend: fix HGEDITOR shell script to run on Windows

# HG changeset patch # User Matt Harbison # Date 151031 14400 # Thu Jul 13 22:57:11 2017 -0400 # Node ID 067229dccb405319bc510f029663221624f21a79 # Parent a7a929d086cfb37b63e8d6d00edc4cff7a9042b7 test-amend: fix HGEDITOR shell script to run on Windows Windows

[Differential] [Planned Changes] D76: contrib: add a codemod script to rewrite nested with

quark planned changes to this revision. quark added a comment. Could take wrong action if the outer `with` has blocks other than a single inner `with`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D76 EMAIL PREFERENCES

[Differential] [Abandoned] D69: tests: put temporary files in $TESTTMP

simpkins abandoned this revision. simpkins added a comment. https://phab.mercurial-scm.org/D67 has landed in hgcommitted, so this isn't really necessary any more. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D69 EMAIL PREFERENCES

[Differential] [Updated, 66 lines] D76: contrib: add a codemod script to rewrite nested with

quark updated this revision to Diff 124. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D76?vs=123=124 REVISION DETAIL https://phab.mercurial-scm.org/D76 AFFECTED FILES contrib/codemod/codemod_nestedwith.py CHANGE DETAILS Index:

[Differential] [Updated, 66 lines] D76: contrib: add a codemod script to rewrite nested with

quark updated this revision to Diff 123. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D76?vs=120=123 REVISION DETAIL https://phab.mercurial-scm.org/D76 AFFECTED FILES contrib/codemod/codemod_nestedwith.py CHANGE DETAILS Index:

[Differential] [Commented On] D77: codemod: simplify nested withs

quark added a comment. Suggestion: use "Whitespace Changes: Ignore All" to view the diff: https://phab.mercurial-scm.org/D77?vs=on=121=ignore-all#toc REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D77 EMAIL PREFERENCES

[Differential] [Request, 352 lines] D77: codemod: simplify nested withs

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the result of running: python contrib/codemod/codemod_nestedwith.py **/*.py REPOSITORY rHG Mercurial REVISION DETAIL

[Differential] [Request, 82 lines] D76: contrib: add a codemod script to rewrite nested with

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The codemod script rewrites nested with with a single with if the code could be put in one line (80 chars). REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

On Thu, 13 Jul 2017 20:57:24 -0400, Pulkit Goyal <7895pul...@gmail.com> wrote: On Fri, Jul 14, 2017 at 6:22 AM, Matt Harbison wrote: On Thu, 13 Jul 2017 16:44:35 -0400, Sean Farley wrote: Pulkit Goyal <7895pul...@gmail.com> writes: # HG

Re: [PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

On Fri, Jul 14, 2017 at 6:22 AM, Matt Harbison wrote: > On Thu, 13 Jul 2017 16:44:35 -0400, Sean Farley wrote: > >> >> Pulkit Goyal <7895pul...@gmail.com> writes: >> >>> # HG changeset patch >>> # User Pulkit Goyal <7895pul...@gmail.com> >>> # Date

Re: [PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

On Thu, 13 Jul 2017 16:44:35 -0400, Sean Farley wrote: Pulkit Goyal <7895pul...@gmail.com> writes: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1499856010 -19800 # Wed Jul 12 16:10:10 2017 +0530 # Node ID

Re: [Bug 4119] New: don't list the content of untracked directories in status command

On Fri, Jul 14, 2017 at 4:14 AM, Josef 'Jeff' Sipek wrote: > It's been a while since this bug got closed as WONTFIX. I'm wondering if > the developers' thoughts about this changed since then. > > (I wouldn't mind if this functionality was behind an argument or a config >

[PATCH 2 of 4] win32: add a method to trigger the Crypto API to complete a certificate chain

# HG changeset patch # User Matt Harbison # Date 1490845523 14400 # Wed Mar 29 23:45:23 2017 -0400 # Node ID 0d8d8dffab1d315bbadee6569f28224d6b1f59df # Parent 34ade5bfcf96b840ee3643d2429f44865b977749 win32: add a method to trigger the Crypto API to complete a

[PATCH 1 of 4] win32: work around a WinError problem handling HRESULT types

# HG changeset patch # User Matt Harbison # Date 1490848380 14400 # Thu Mar 30 00:33:00 2017 -0400 # Node ID 34ade5bfcf96b840ee3643d2429f44865b977749 # Parent 26e4ba058215e536d3827befbea99ff6203d35f8 win32: work around a WinError problem handling HRESULT types I

[PATCH 4 of 4] sslutil: inform the user about how to fix an incomplete certificate chain

# HG changeset patch # User Matt Harbison # Date 1499899033 14400 # Wed Jul 12 18:37:13 2017 -0400 # Node ID 2000c901f306bc051b3d4fe5f89176f164933f6d # Parent f931e230e7265b024e823c32b50a3167dd9e43a4 sslutil: inform the user about how to fix an incomplete

[Bug 5622] New: hg id option to not check for modified files

https://bz.mercurial-scm.org/show_bug.cgi?id=5622 Bug ID: 5622 Summary: hg id option to not check for modified files Product: Mercurial Version: 4.1.2 Hardware: PC OS: Other Status: UNCONFIRMED Severity:

[Differential] [Updated] D62: rebase: add config to move rebase into a single transaction

martinvonz added inline comments. INLINE COMMENTS > durham wrote in rebase.py:721 > The context manage will only call tr.release(),since it's an exception exit > path. Ah, right. Anyway, once https://phab.mercurial-scm.org/D66 is in, you should be able to simplify this to: tr = None if

[Bug 5620] New: 4.1.3 not listed as a possible version

https://bz.mercurial-scm.org/show_bug.cgi?id=5620 Bug ID: 5620 Summary: 4.1.3 not listed as a possible version Product: Mercurial Version: unspecified Hardware: PC OS: Other Status: UNCONFIRMED Severity:

[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

durham added a comment. In https://phab.mercurial-scm.org/D62#790, @phillco wrote: > Though, it's interesting, it looks like I have the ability to accept as `hg`. I presume I'll need to keep unchecking that so I don't accidentally pretend to be a core reviewer. Anyone can accept

[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

durham added inline comments. INLINE COMMENTS > martinvonz wrote in rebase.py:721 > Won't this and tr's context manager together double-close the transaction? The context manage will only call tr.release(),since it's an exception exit path. REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

Pulkit Goyal <7895pul...@gmail.com> writes: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1499856010 -19800 > # Wed Jul 12 16:10:10 2017 +0530 > # Node ID e8200f6a0783798ad61cd84f73c1721264966f02 > # Parent 3d742534fa70a38a2b540cfb0bf68610ecc63d0e > #

Re: [PATCH 1 of 3 V3] vfs: allow to pass more argument to audit

On Fri, 2017-07-14 at 00:28 +0900, Yuya Nishihara wrote: > On Tue, 11 Jul 2017 17:55:27 +0200, Boris Feld wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1499768878 -7200 > > #  Tue Jul 11 12:27:58 2017 +0200 > > # Node ID

[Differential] [Commented On] D65: histedit: create transaction outside of try

martinvonz added inline comments. INLINE COMMENTS > durham wrote in histedit.py:1120 > It might be more technically correct to do this after state.write() happens. > state.write() is intended to be called before the transaction, and it only > technically works right here because it's ignoring

[Differential] [Updated, 25 lines] D65: histedit: create transaction outside of try

martinvonz updated this revision to Diff 115. martinvonz marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D65?vs=99=115 REVISION DETAIL https://phab.mercurial-scm.org/D65 AFFECTED FILES hgext/histedit.py CHANGE DETAILS

[Differential] [Accepted] D38: phabricator: allow specifying reviewers on phabsend

phillco accepted this revision. phillco added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D38 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: quark,

[Differential] [Accepted] D67: test-check-pyflakes: do not leave test.py in the repo

martinvonz accepted this revision. martinvonz added a comment. This revision is now accepted and ready to land. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D67 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/

[Differential] [Accepted] D65: histedit: create transaction outside of try

durham accepted this revision. durham added inline comments. INLINE COMMENTS > histedit.py:1120 > +# external process it may choose to commit the transaction first. > +tr = repo.transaction('histedit') > It might be more technically correct to do this after state.write()

[Differential] [Commented On] D66: histedit: extract InterventionRequired transaction handling to utils

durham added inline comments. INLINE COMMENTS > util.py:594 > +@contextlib.contextmanager > +def acceptintervention(tr=None): > +"""A context manager that closes the transaction on InterventionRequired Technically this will apply to dsguard as well, so 'tr' isn't quite precise. But I

Re: [PATCH 5 of 5] template: add successors template

Yuya Nishihara writes: > On Fri, 07 Jul 2017 09:35:48 -0700, Sean Farley wrote: >> Yuya Nishihara writes: >> > On Thu, 06 Jul 2017 11:05:22 -0700, Sean Farley wrote: >> >> Augie Fackler writes: >> >> > On Wed, Jul 05, 2017 at 10:53:58PM +0200,

[PATCH V4] status: add a flag to terse the output (issue4119)

# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1497710422 -19800 # Sat Jun 17 20:10:22 2017 +0530 # Node ID d2f046b37522465606f3824d663ece2608f0a23d # Parent 50243c975fc2ee605ebac493f4ab18d37117e46a # EXP-Topic tersestatus status: add a flag to terse the output

Re: [PATCH 3 of 3] revset: add experimental ancestors/descendants relation subscript

Yuya Nishihara writes: > # HG changeset patch > # User Yuya Nishihara > # Date 1499487317 -32400 > # Sat Jul 08 13:15:17 2017 +0900 > # Node ID 660613df4ea547c78b4ae06e20e4af46399dc02f > # Parent eed6cd6aa792698d0535f276e150f88500943866 > revset: add

[Differential] [Accepted] D57: match: write forceincludematcher using unionmatcher

dsp accepted this revision. dsp added a comment. This revision is now accepted and ready to land. accepting this for visibility to hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D57 EMAIL PREFERENCES

Re: [PATCH 4 of 4] bundle2: no longer use 'retractboundary' in updatephases

Martin von Zweigbergk writes: > On Thu, Jul 13, 2017 at 12:22 AM, Martin von Zweigbergk > wrote: >> On Wed, Jul 12, 2017 at 8:29 PM, Sean Farley wrote: >>> >>> Boris Feld writes: >>> # HG changeset

[Differential] [Request, 139 lines] D73: util: remove unused ctxmanager

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was meant as a substitute for Python's "with" with multiple context managers before we moved to Python 2.7. We're now on 2.7, so we should have no

Re: [PATCH 4 of 4] bundle2: no longer use 'retractboundary' in updatephases

On Thu, Jul 13, 2017 at 12:22 AM, Martin von Zweigbergk wrote: > On Wed, Jul 12, 2017 at 8:29 PM, Sean Farley wrote: >> >> Boris Feld writes: >> >>> # HG changeset patch >>> # User Boris Feld >>> # Date

[PATCH] templatekw: export ui.paths as {peerpaths}

# HG changeset patch # User Yuya Nishihara # Date 1499873754 -32400 # Thu Jul 13 00:35:54 2017 +0900 # Node ID 0601429fa6973ef5eeb97032772ecbdc1c54c37d # Parent 660613df4ea547c78b4ae06e20e4af46399dc02f templatekw: export ui.paths as {peerpaths} It's sometimes useful to show

[PATCH 1 of 3] revset: do not compute weight for integer literal argument

# HG changeset patch # User Yuya Nishihara # Date 1499485786 -32400 # Sat Jul 08 12:49:46 2017 +0900 # Node ID f98c5d417af06e54df22a58fa2e6305ff7b5a7ba # Parent 0d5afd360e9ec118081c2e2ed5146af80086c49a revset: do not compute weight for integer literal argument In x^n and

[PATCH 2 of 3] revset: add experimental relation and subscript operators

# HG changeset patch # User Yuya Nishihara # Date 1499486879 -32400 # Sat Jul 08 13:07:59 2017 +0900 # Node ID eed6cd6aa792698d0535f276e150f88500943866 # Parent f98c5d417af06e54df22a58fa2e6305ff7b5a7ba revset: add experimental relation and subscript operators The proposed

[PATCH 3 of 3] revset: add experimental ancestors/descendants relation subscript

# HG changeset patch # User Yuya Nishihara # Date 1499487317 -32400 # Sat Jul 08 13:15:17 2017 +0900 # Node ID 660613df4ea547c78b4ae06e20e4af46399dc02f # Parent eed6cd6aa792698d0535f276e150f88500943866 revset: add experimental ancestors/descendants relation subscript The

Re: [PATCH 9 of 9] template: use template-engine for obsfate

Excerpts from Jun Wu's message of 2017-07-13 08:42:11 -0700: > Excerpts from Boris Feld's message of 2017-07-13 12:32:39 +0200: > > I think there was a misunderstanding about obsfate that I will try to > > clarify, this email is a bit long, sorry. > > > > TL;DR: > > - hg log is a

Re: [PATCH V2] match: inverse _anypats(), making it _prefix()

On Thu, Jul 13, 2017 at 9:04 AM, Yuya Nishihara wrote: > On Tue, 11 Jul 2017 09:44:28 -0700, Martin von Zweigbergk via Mercurial-devel > wrote: >> # HG changeset patch >> # User Martin von Zweigbergk >> # Date 1499791352 25200 >> # Tue Jul 11 09:42:32

[Differential] [Commented On] D66: histedit: extract InterventionRequired transaction handling to utils

martinvonz added inline comments. INLINE COMMENTS > lothiraldan wrote in util.py:599 > The initial check was slighty more precise (if tr is not None), any specific > reason for the change? We generally prefer "not X" over "is not None" when they're functionally equivalent (and I do think they

Re: [PATCH V2] match: inverse _anypats(), making it _prefix()

On Tue, 11 Jul 2017 09:44:28 -0700, Martin von Zweigbergk via Mercurial-devel wrote: > # HG changeset patch > # User Martin von Zweigbergk > # Date 1499791352 25200 > # Tue Jul 11 09:42:32 2017 -0700 > # Node ID 2800fa259f4e1c23dc9c9605ed02f4d734dd1761 > # Parent

Re: [PATCH V2] amend: new extension providing the amend command

Excerpts from Gregory Szorc's message of 2017-07-13 08:03:42 -0700: > I'm late to the review party. > > When I saw this patch, I thought an extension was a bit heavyweight. I was > wondering if we could achieve something similar by defining a [commands] > option or 2 for changing behavior of

Re: [PATCH 1 of 3 V3] vfs: allow to pass more argument to audit

On Tue, 11 Jul 2017 17:55:27 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1499768878 -7200 > # Tue Jul 11 12:27:58 2017 +0200 > # Node ID 9addf65400ec8e6052a399c1586320988d73a321 > # Parent 4672db164c986da4442bd864cd044512d975c3f2 > #

Re: [PATCH 12 of 14] vfs: add the possibility to have a "ward" to check vfs usage

On Tue, 11 Jul 2017 16:32:46 +0200, Boris Feld wrote: > On Sat, 2017-07-08 at 16:36 +0900, Yuya Nishihara wrote: > > On Fri, 07 Jul 2017 18:48:44 +0200, Boris Feld wrote: > > > On Fri, 2017-07-07 at 21:48 +0900, Yuya Nishihara wrote: > > > > On Thu, 06 Jul 2017 20:53:50 +0200, Boris Feld wrote: >

Re: [POLL] Mass renaming options for consistency + guidelines

Le 13 juil. 2017 5:37 PM, "Augie Fackler" a écrit : > On Jul 13, 2017, at 05:15, David Demelier wrote: > > Hello, > > I'm one of the creator of the ConfigConsolidationPlan [0]. > > In Mercurial there was a big issue regarding the options continuously

Re: [PATCH 9 of 9] template: use template-engine for obsfate

Excerpts from Boris Feld's message of 2017-07-13 12:32:39 +0200: > I think there was a misunderstanding about obsfate that I will try to > clarify, this email is a bit long, sorry. > > TL;DR: > - hg log is a changeset-centric command > - obsfate template summarize the obs-history between a

Re: [POLL] Mass renaming options for consistency + guidelines

> On Jul 13, 2017, at 05:15, David Demelier wrote: > > Hello, > > I'm one of the creator of the ConfigConsolidationPlan [0]. > > In Mercurial there was a big issue regarding the options continuously added > without any guideline into the hgrc file. This leads to

[PATCH 1 of 4] configitems: handle case were the default value is not static

# HG changeset patch # User Boris Feld # Date 1499895370 -7200 # Wed Jul 12 23:36:10 2017 +0200 # Node ID afad2f9ae04d35cef5165b07a2987b0e5604924b # Parent 68e9762a357b19ec7751683e2fb80266c0d260ce # EXP-Topic config.register.special-case configitems: handle case were

[PATCH 2 of 4] configitems: register the 'color.pagermode' config

# HG changeset patch # User Boris Feld # Date 1499895388 -7200 # Wed Jul 12 23:36:28 2017 +0200 # Node ID ad57894ea839e08f6b4f2dd3eb5c779c4746202e # Parent afad2f9ae04d35cef5165b07a2987b0e5604924b # EXP-Topic config.register.special-case configitems: register the

[PATCH 4 of 4] configitems: register the 'worker.backgroundclose' config

# HG changeset patch # User Boris Feld # Date 1498787157 -7200 # Fri Jun 30 03:45:57 2017 +0200 # Node ID f62a1b71aa6959c3be5a88afe574b056b9ebec5a # Parent 5f2e71c738b41b8a864ae8c7b38eff41985ebd99 # EXP-Topic config.register.special-case configitems: register the

[PATCH 3 of 4] configitems: register the 'progress.width' config

# HG changeset patch # User Boris Feld # Date 1498787045 -7200 # Fri Jun 30 03:44:05 2017 +0200 # Node ID 5f2e71c738b41b8a864ae8c7b38eff41985ebd99 # Parent ad57894ea839e08f6b4f2dd3eb5c779c4746202e # EXP-Topic config.register.special-case configitems: register the

Re: [PATCH V2] amend: new extension providing the amend command

>> On Jul 12, 2017, at 10:11, Martin von Zweigbergk via Mercurial-devel >> wrote: >> >> On Wed, Jul 12, 2017 at 12:47 AM, Jun Wu wrote: >> # HG changeset patch >> # User Jun Wu >> # Date 1499831635 25200 >> # Tue Jul 11

Re: [PATCH 9 of 9] template: use template-engine for obsfate

I think there was a misunderstanding about obsfate that I will try to clarify, this email is a bit long, sorry. TL;DR: - hg log is a changeset-centric command - obsfate template summarize the obs-history between a changeset and its successors, history that can span several obs-markers - hg obslog

[POLL] Mass renaming options for consistency + guidelines

Hello, I'm one of the creator of the ConfigConsolidationPlan [0]. In Mercurial there was a big issue regarding the options continuously added without any guideline into the hgrc file. This leads to massive inconsistency like : allowpull allow_push assume-tty In the process of

[Differential] [Commented On] D66: histedit: extract InterventionRequired transaction handling to utils

lothiraldan added a comment. LGTM apart from the condition change INLINE COMMENTS > util.py:599 > +""" > +if not tr: > +yield The initial check was slighty more precise (if tr is not None), any specific reason for the change? REPOSITORY rHG Mercurial REVISION DETAIL

[Differential] [Commented On] D72: httpclient: honor the timeout when setting up the connection

lothiraldan added a comment. LGTM, but I'm not sure how to test it locally. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D72 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: simpkins, #hg-reviewers Cc: lothiraldan,

Re: Community video chats?

On Tue, 2017-07-11 at 16:08 -0400, Augie Fackler wrote: > > On Jul 11, 2017, at 15:47, Phillip Cohen > > wrote: > > > > Great, glad there's interest. > > > > How would Thursday at 10am PST / 1pm EST  / 6pm UTC work? This is > > early enough for London to join, but not too

Re: [PATCH 4 of 4] bundle2: no longer use 'retractboundary' in updatephases

On Wed, Jul 12, 2017 at 8:29 PM, Sean Farley wrote: > > Boris Feld writes: > >> # HG changeset patch >> # User Boris Feld >> # Date 1499742361 -7200 >> # Tue Jul 11 05:06:01 2017 +0200 >> # Node ID