D6776: bookmarks: validate changes on push (issue6193) (BC)

idlsoft added a comment. > If you mean "reject bad pushes as long as people don't push -f", both versions implement this (the client-side check is not racy thanks to these check:bookmark bundle parts). That was the idea. This implementation is a bit more flexible I think. Since it’s se

D6776: bookmarks: validate changes on push (issue6193) (BC)

valentin.gatienbaron added a comment. In D6776#100506 , @durin42 wrote: > In D6776#100487 , @valentin.gatienbaron wrote: > >> I showed in D6847 the same cha

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow.t:457 > > No, I meant what if you don't get rid of the .i files. > > This is not changing which .i files we get rid of; the behavior should be the > same as if you had typed `hg tracked --removeinclude path:d0 -

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16536. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16532&id=16536 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED FI

D6849: tests: move a config write to top of file since it applies to all tests

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to add another test that depends on this config. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial

D6776: bookmarks: validate changes on push (issue6193) (BC)

idlsoft updated this revision to Diff 16534. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6776?vs=16533&id=16534 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6776 AFFECTED FILES mercurial/bundle2.py me

D6776: bookmarks: validate changes on push (issue6193) (BC)

idlsoft updated this revision to Diff 16533. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6776?vs=16531&id=16533 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6776 AFFECTED FILES mercurial/bundle2.py me

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16532. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16528&id=16532 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED FI

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > rdamazio wrote in test-narrow.t:457 > > That's just about the working directory, right? This file is unchanged in > > the working directory at the time of hg tracked --auto-remove-includes... > > No, I meant what if you don't get rid of the .i

D6848: narrow: add option for automatically removing unused includes

rdamazio added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow.t:457 > > This obsolete commit is completely lost afterwards, which kind of violates > > the principle of "all changes are kept forever" - should it dump this > > somewhere for safekeeping? > > Yes, it does dump

D6776: bookmarks: validate changes on push (issue6193) (BC)

idlsoft updated this revision to Diff 16531. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6776?vs=16524&id=16531 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6776 AFFECTED FILES mercurial/bundle2.py me

D6846: packaging: script the building of a MacOS installer using a custom python

mharbison72 added a comment. In D6846#100478 , @mharbison72 wrote: > This seems to work (though the shebang line hack is painful)- until the original python build directory is deleted. Then a lot of things complain about unsupported hash typ

D6776: bookmarks: validate changes on push (issue6193) (BC)

idlsoft added a comment. > Isn't that a client-side change only though, so we still need functionality on the server to reject bad pushes? (I could be missing something.) I'm actually not sure how to make this work for http, it doesn't seem to propagate `--force` to `unbundle`. Which i

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > rdamazio wrote in test-narrow.t:457 > This obsolete commit is completely lost afterwards, which kind of violates > the principle of "all changes are kept forever" - should it dump this > somewhere for safekeeping? > Also, what if you just don'

D6848: narrow: add option for automatically removing unused includes

rdamazio added inline comments. INLINE COMMENTS > test-narrow.t:457 > + $ echo a >> d0/f > + $ hg ci -m 'local change to d0' > + $ hg co '.^' This obsolete commit is completely lost afterwards, which kind of violates the principle of "all changes are kept forever" - should it dump this somew

Re: [PATCH evolve-ext] docs: add example for the `prune` command

Done as a merge request on https://dev.heptapod.net/mercurial/evolve, thanks for reminding me On 9/13/19 3:56 PM, Anton Shestakov wrote: This patch seems to have fallen entirely through the cracks. Try CCing marmoute in V2. On Fri, 19 Jul 2019 16:29:42 +0200 Raphaël Gomès wrote: # HG change

Re: [PATCH evolve-ext] docs: add example for the `prune` command

This patch seems to have fallen entirely through the cracks. Try CCing marmoute in V2. On Fri, 19 Jul 2019 16:29:42 +0200 Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1563546408 -7200 > # Fri Jul 19 16:26:48 2019 +0200 > # Branch stable > # Node ID 7fc102507d

D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 added a comment. In D6776#100487 , @valentin.gatienbaron wrote: > I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass. > I think it'd make for a simpler fi

D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > hg_path.rs:175 > +pub fn push(&mut self, byte: u8) { > +self.inner.push(byte); > +} debug_assert check after the mutation. > hg_path.rs:242 > +fn extend>(&mut self, iter: T) { > +self.

D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf

Alphare added inline comments. INLINE COMMENTS > kevincox wrote in files.rs:75 > Is this used? Can you either use, delete or add tests. I think the rebase fixed the diff. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6774/new/ REVISION DETAIL https:/

D6774: rust-hgpath: replace all paths and filenames with HgPath/HgPathBuf

Alphare updated this revision to Diff 16530. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6774?vs=16367&id=16530 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6774/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6774 AFFECTED FILES

D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths

Alphare updated this revision to Diff 16529. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6773?vs=16371&id=16529 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6773/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6773 AFFECTED FILES

D6836: interfaces: introduce an interface for dirstate implementations

Alphare added inline comments. INLINE COMMENTS > dirstate.py:37 > + > +_map = interfaceutil.Attribute( > +"""Return the dirstate contents (see documentation for dirstatemap). Shouldn't this be removed? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-sc