mercurial@43274: 41 new changesets

2019-10-16 Thread Mercurial Commits
41 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c09e8ac3f61f changeset: 43234:c09e8ac3f61f user:Gregory Szorc date:Mon Oct 14 21:21:58 2019 -0700 summary: automation: schedule an EC2Launch run on next boot

D6925: ci: track spot instance state, randomly assign availability zone

2019-10-16 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg reclaimed this revision. Oops. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6925/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6925 To: indygreg, #hg-reviewers Cc: mercurial-devel

D6906: ci: implement a new CI system for Mercurial

2019-10-16 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg planned changes to this revision. Since nobody seems to have plans to review this, I'll hold off on requesting review at this time. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL

D7105: dirs: reject consecutive slashes in paths

2019-10-16 Thread indygreg (Gregory Szorc)
indygreg added a comment. I dropped this from committed because of discussion on this review and because Windows was not happy with the change: mercurial/cext/dirs.c(75) : error C2275: 'PyObject' : illegal use of this type as an expression

D7062: convert: convert os.devnull to bytes before trying to join it with other bytes

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHG6ef48274e803: convert: convert os.devnull to bytes before trying to join it with other bytes (authored by Kwan). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7124: copies: move from a copy on branchpoint to a copy on write approach

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this changes, any branch points results in a copy of the dictionary containing the copy information. This can be very costly for branchy history with few

D7076: copies: compute the exact set of revision to walk

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17279. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7076?vs=17278=17279 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7076/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7076 AFFECTED FILES

D7116: rust-performance: introduce FastHashMap type alias for HashMap

2019-10-16 Thread kevincox (Kevin Cox)
kevincox added a comment. kevincox accepted this revision. I've seen very good results with https://github.com/servo/rust-fnv in the past so it is probably worth including that in the comparison and possibly using it. It is especially good for small keys which seems like a common case in

D7116: rust-performance: introduce FastHashMap type alias for HashMap

2019-10-16 Thread kevincox (Kevin Cox)
kevincox added a comment. In D7116#104617 , @durin42 wrote: > OOC, have you compared this with the hashbrown crate for perf? std::collections::HashMap now uses hashbrown https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html REPOSITORY

D7076: copies: compute the exact set of revision to walk

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute edited the summary of this revision. marmoute updated this revision to Diff 17278. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7076?vs=17116=17278 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7076/new/ REVISION DETAIL

D7075: copies: add an explicit test using multiple roots

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17277. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7075?vs=17115=17277 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7075/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7075 AFFECTED FILES

D7074: sidedatacopies: fast path data fetching if revision has no sidedata

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute edited the summary of this revision. marmoute updated this revision to Diff 17276. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7074?vs=17114=17276 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7074/new/ REVISION DETAIL

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7121#104675 , @marmoute wrote: > In D7121#104674 , @martinvonz wrote: > >> In D7121#104673 , @marmoute wrote: >>

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7121#104674 , @martinvonz wrote: > In D7121#104673 , @marmoute wrote: > >> In D7121#104672 , @martinvonz wrote: >>

D7121: copies: get copies information directly from _copies

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7121#104673 , @marmoute wrote: > In D7121#104672 , @martinvonz wrote: > >> In D7121#104671 , @marmoute wrote: >>

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7121#104672 , @martinvonz wrote: > In D7121#104671 , @marmoute wrote: > >> In D7121#104546 , @martinvonz wrote: >>

D7121: copies: get copies information directly from _copies

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7121#104671 , @marmoute wrote: > In D7121#104546 , @martinvonz wrote: > >> In D7121#104543 , @martinvonz wrote:

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7121#104546 , @martinvonz wrote: > In D7121#104543 , @martinvonz wrote: > >>> Performance measurement does not show any significant performance movement. This

mercurial@43233: 4 new changesets

2019-10-16 Thread Mercurial Commits
4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e51f5d06a99c changeset: 43230:e51f5d06a99c user:Pierre-Yves David date:Wed Oct 02 14:16:30 2019 -0400 summary: sidedatacopies: only read from copies when in this mode

D7072: sidedatacopies: directly fetch copies information from sidedata

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17275. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7072?vs=17251=17275 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7072/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7072 AFFECTED FILES

D7123: copies: use an unfiltered repository for the changeset centric algorithm

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17274. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7123?vs=17250=17274 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7123/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7123 AFFECTED FILES

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17273. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7070?vs=17249=17273 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7070/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7070 AFFECTED FILES

D7122: copies: avoid instancing more changectx to access parent revisions

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17272. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7122?vs=17248=17272 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7122/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7122 AFFECTED FILES

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17271. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7121?vs=17247=17271 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7121/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7121 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

2019-10-16 Thread Raphaël Gomès
Closed by commit rHG38ac72317ba4: rust-dirstate-status: add first Rust implementation of `dirstate.status` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7059: rust-dirstate-status: rust-cpython bindings for `dirstate.status`

2019-10-16 Thread Raphaël Gomès
Closed by commit rHGfb3bdcf4895c: rust-dirstate-status: rust-cpython bindings for `dirstate.status` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7060: rust-dirstate-status: add call to rust-fast path for `dirstate.status`

2019-10-16 Thread Raphaël Gomès
Closed by commit rHGa85a71cb383f: rust-dirstate-status: add call to rust-fast path for `dirstate.status` (authored by Alphare). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7060?vs=17253=17270#toc REPOSITORY

D7110: rust-refsharing: add missing lifetime parameter in ref_sharing

2019-10-16 Thread Raphaël Gomès
Closed by commit rHGb902066d9b86: rust-refsharing: add missing lifetime parameter in ref_sharing (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7060: rust-dirstate-status: add call to rust-fast path for `dirstate.status`

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added inline comments. martinvonz accepted this revision. INLINE COMMENTS > dirstate.py:1120-1127 > +lookup, modified, added, removed, deleted, unknown, clean = > rustmod.status( > +dmap._rustmap, > +

D7120: rust-cpython: removed now useless py_set() conversion

2019-10-16 Thread gracinet (Georges Racinet)
Closed by commit rHG4fc02c926e88: rust-cpython: removed now useless py_set() conversion (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7001: share: unmark --relative as EXPERIMENTAL

2019-10-16 Thread pulkit (Pulkit Goyal)
Closed by commit rHG7b0b902b8c19: share: unmark --relative as EXPERIMENTAL (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7003: grep: put --diff in the first line of usage

2019-10-16 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHG0b8b7905f239: grep: put --diff in the first line of usage (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7112: tests: stabilize test-eol-update on Windows

2019-10-16 Thread mharbison72 (Matt Harbison)
Closed by commit rHG44db020fe4ba: tests: stabilize test-eol-update on Windows (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6843: ui: option to preserve the progress bar

2019-10-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
Closed by commit rHGcf25e525b7ae: ui: option to preserve the progress bar (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7111: tests: opt into python3 when testing virtualenv installation

2019-10-16 Thread mharbison72 (Matt Harbison)
Closed by commit rHG97988ce08f0c: tests: opt into python3 when testing virtualenv installation (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7116: rust-performance: introduce FastHashMap type alias for HashMap

2019-10-16 Thread durin42 (Augie Fackler)
durin42 added a comment. OOC, have you compared this with the hashbrown crate for perf? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7116/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7116 To: Alphare, #hg-reviewers Cc: durin42, kevincox,

D7055: phabricator: update hgmatcher to cope with the new data format

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHGa124b79a3a7e: phabricator: update hgmatcher to cope with the new data format (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7054: phabricator: treat non-utf-8 text files as binary as phabricator requires

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHGa852a1ef8c8a: phabricator: treat non-utf-8 text files as binary as phabricator requires (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7053: phabricator: switch to the creatediff endpoint

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHGd5fabfe54ec6: phabricator: switch to the creatediff endpoint (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7052: phabricator: change conduit data format to match arcanist

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHGfaf084d63c72: phabricator: change conduit data format to match arcanist (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7066: phabricator: convert phabhunk and phabchange keys to bytes when finalising

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHG7dca674a456b: phabricator: convert phabhunk and phabchange keys to bytes when finalising (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7050: phabricator: add addadded function

2019-10-16 Thread Kwan (Ian Moody)
Closed by commit rHG1bc599b69354: phabricator: add addadded function (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7056: phabricator: include bookmark in diff metadata

2019-10-16 Thread durin42 (Augie Fackler)
durin42 added a comment. (or a config knob) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7056/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7056 To: Kwan, #hg-reviewers Cc: durin42, mercurial-devel

D7056: phabricator: include bookmark in diff metadata

2019-10-16 Thread durin42 (Augie Fackler)
durin42 added a comment. Yeah, the bookmark-name disclosure seems like something that should be optional? Maybe put this behind a flag? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7056/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7056

D7061: convert: don't pass bytes to, or expect bytes from, emailparser

2019-10-16 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > Kwan wrote in gnuarch.py:301 > Hmm, I wasn't aware of that drawback of `unifromlocal()` if it's true. Is > there a canonical "Give me unicode from these mercurial bytes" function? > Regardless, `BytesParser` does sound handy, and is even in

D7055: phabricator: update hgmatcher to cope with the new data format

2019-10-16 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > Kwan wrote in phabricator.py:155-156 > These will need converting to unicode first for py3.5 (I keep forgetting > about loads only accepting bytes from 3.6 onwards). That might be a nudge towards dropping 3.5 support. We've already got problems

Mercurial 5.4 sprint (Spring 2020)

2019-10-16 Thread Kyle Lippincott
I know the 5.2 sprint just finished, but let's get a jump start on planning the 5.4 sprint (Spring 2020). This one will be in Europe. We have had a few offers for hosting and I don't know all of the details, so please update the wiki page: https://www.mercurial-scm.org/wiki/5.4Sprint. Please put

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

2019-10-16 Thread Raphaël Gomès
Alphare updated this revision to Diff 17252. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17196=17252 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7060: rust-dirstate-status: add call to rust-fast path for `dirstate.status`

2019-10-16 Thread Raphaël Gomès
Alphare updated this revision to Diff 17253. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7060?vs=17067=17253 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7060/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7060 AFFECTED FILES

mercurial@43229: new changeset

2019-10-16 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9fa941faef94 changeset: 43229:9fa941faef94 bookmark:@ tag: tip user:Yuya Nishihara date:Sun Oct 13 20:06:09 2019 +0900 summary: dirs: remove mutable string optimization at all -- Repository

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > status.rs:103-110 > +Err(ref e) > +if e.kind() == std::io::ErrorKind::NotFound > +|| e.raw_os_error() == Some(20) => > +{ > +//

D7072: sidedatacopies: directly fetch copies information from sidedata

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHGbd62a9569f21: sidedatacopies: directly fetch copies information from sidedata (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7123: copies: use an unfiltered repository for the changeset centric algorithm

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHG3d0b9f7563ea: copies: use an unfiltered repository for the changeset centric algorithm (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHG8cdebdb3133e: copies: extract data extraction into a `revinfo` function (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7122: copies: avoid instancing more changectx to access parent revisions

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHG6b43c7be2d15: copies: avoid instancing more changectx to access parent revisions (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHG32943e8c8d68: copies: get copies information directly from _copies (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7121?vs=17240=17247

D7073: revlog: introduce a `_uncheckedflags` shortcut

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Should no longer be necessary with D7123 , right? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7073/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7073 To: marmoute,

D7123: copies: use an unfiltered repository for the changeset centric algorithm

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In my copies-in-changesets version of mozilla-unified, this makes a very significant difference: before: ! wall 3.715800 comb 3.72 user 3.69 sys 0.03 (best of 10) after: ! wall 2.950721 comb 2.96 user 2.88 sys 0.08 (best

D7122: copies: avoid instancing more changectx to access parent revisions

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. In my copies-in-changesets version of mozilla-unified, this makes a very significant difference: before: ! wall 4.485065 comb 4.49 user 4.44 sys 0.05 (best of

D7121: copies: get copies information directly from _copies

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7121#104543 , @martinvonz wrote: >> Performance measurement does not show any significant performance movement. This >> is not surprising since p1copies() code is self._copies[0]. > > My testing agrees

D7121: copies: get copies information directly from _copies

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. > Performance measurement does not show any significant performance movement. This > is not surprising since p1copies() code is self._copies[0]. My testing agrees with that.

D7072: sidedatacopies: directly fetch copies information from sidedata

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17246. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7072?vs=17112=17246 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7072/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7072 AFFECTED FILES

D7123: copies: use an unfiltered repository for the changeset centric algorithm

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17245. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7123?vs=17243=17245 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7123/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7123 AFFECTED FILES

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17244. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7070?vs=17242=17244 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7070/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7070 AFFECTED FILES

D7123: copies: use an unfiltered repository for the changeset centric algorithm

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since the algorithm work form heads to ancestors, we don't need to check filtering for anything but the two entries. Using an unfiltered version is

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17242. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7070?vs=17110=17242 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7070/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7070 AFFECTED FILES

D7122: copies: avoid instancing more changectx to access parent revisions

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We just need to know the revision numbers of the parents, creating full context is needlessly expensive. This provide a small, but noticeable performance

D7121: copies: get copies information directly from _copies

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Performance measurement does not show any significant performance movement. This is not surprising since p1copies() code is `self._copies[0]`. REPOSITORY rHG

D7113: automation: schedule an EC2Launch run on next boot

2019-10-16 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in aws.py:1128 > black wants this line to be wrapped. I'll fix that in flight. I should install black, I was waiting for Augie's fix to land to prevent doing some extra work. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. To clarify, you don't see any slowdown if you apply the following patch? diff --git a/mercurial/copies.py b/mercurial/copies.py - a/mercurial/copies.py +++ b/mercurial/copies.py @@ -192,7 +192,7 @@ def _revinfogetter(repo): def revinfo(rev):

D7070: copies: extract data extraction into a `revinfo` function

2019-10-16 Thread marmoute (Pierre-Yves David)
marmoute added a comment. I splitted the usage of changelog.parent out of the extraction of revinfo to measure things further. That step give a small perf boost. Adding a function call comes with a tiny performance cost: revision: large amount; added files: large amount; rename small

Re: Python 3 Transition Plan / Calendar Versioning

2019-10-16 Thread Gregory Szorc
On Wed, Oct 16, 2019 at 1:09 AM David Demelier wrote: > Le 09/10/2019 à 03:26, Gregory Szorc a écrit : > > Our new versioning scheme will be .[M]M.N. e.g. 2020.5.0 or > > 2020.10.1. This scheme consists of the 4 digit year, a 1-2 digit month, > > and a monotonically increasing point release,

D7069: copies: simplify the handling of merges

2019-10-16 Thread marmoute (Pierre-Yves David)
Closed by commit rHG0aef9177a653: copies: simplify the handling of merges (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7069?vs=17195=17239 CHANGES SINCE

D7113: automation: schedule an EC2Launch run on next boot

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > aws.py:1128 > +r'''"extendBootVolumeSize": true, "handleUserData": true, ''' > +r'''"adminPasswordType": "Specify", "adminPassword": "%s"}' ''' > % c.automation.default_password(), > + >

mercurial@43228: new changeset

2019-10-16 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0d609ed185ea changeset: 43228:0d609ed185ea bookmark:@ tag: tip user:Denis Laxalde date:Tue Oct 15 12:14:44 2019 +0200 summary: py3: prevent comparison with None in curses histedit (issue6196)

D7120: rust-cpython: removed now useless py_set() conversion

2019-10-16 Thread gracinet (Georges Racinet)
gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In rust-cpython 0.3.0, HashSets implement the appropriate ToPythonObject, we can therefore get rid of this hacky conversion. There still

D7099: widening: pass in matchers instead of patterns

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7099#104414 , @pulkit wrote: >> The oldmatch is not used yet, but it should be used eventually when widening no longer resends manifests and files the client already has. > > You mean for ellipses case? If

D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes

2019-10-16 Thread durin42 (Augie Fackler)
Closed by commit rHG707a4d56f05a: cleanup: hgdemandimport.tracing accepts strings, not bytes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7107: rust-cross-platform: remove `unimplemented!` to get compile-time errors instead

2019-10-16 Thread Raphaël Gomès
Closed by commit rHG3f21d1c1bba5: rust-cross-platform: remove `unimplemented!` to get compile-time errors (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7057: rust-utils: introduce a debug util to print the python stack trace

2019-10-16 Thread Raphaël Gomès
Closed by commit rHG886f0822a38e: rust-utils: introduce a debug util to print the python stack trace (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7099: widening: pass in matchers instead of patterns

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGc62229c8ddf6: widening: pass in matchers instead of patterns (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7099?vs=17153=17218

D7097: widening: remove "depth" argument since it's always None

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG1634188b1e67: widening: remove depth argument since its always None (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7097?vs=17151=17215

D7098: widening: trust user to give full "known" set

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGd0cd26a7c7a7: widening: trust user to give full known set (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7098?vs=17152=17216 CHANGES

D7096: widening: remove unused "heads" argument

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGa221b566038c: widening: remove unused heads argument (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7096?vs=17150=17214 CHANGES SINCE

D7095: widening: remove pointless code for second changegroup

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG093dc11d8f8c: widening: remove pointless code for second changegroup (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7095?vs=17149=17213

D7094: widening: remove always-true condition in widening code

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGc0b5a3f9046b: widening: remove always-true condition in widening code (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7093: narrow: drop server support for widening using the getbundle command (BC)

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG5300fcac910c: narrow: drop server support for widening using the getbundle command (BC) (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7092: widening: duplicate generateellipsesbundle2() for widening

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG81b315f781da: widening: duplicate generateellipsesbundle2() for widening (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6550: tracing: add a couple of trace points on obsolete and repoview

2019-10-16 Thread durin42 (Augie Fackler)
Closed by commit rHG149d6ba20d9a: tracing: add a couple of trace points on obsolete and repoview (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7091: tests: show graph log before and after widening in more cases

2019-10-16 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG018cd154d61c: tests: show graph log before and after widening in more cases (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7109: dirstate: add some traces on listdir calls

2019-10-16 Thread durin42 (Augie Fackler)
Closed by commit rHGbc5c4919a1a0: dirstate: add some traces on listdir calls (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7109?vs=17179=17207 CHANGES SINCE

D7102: tests: fix formatting test after move of black config

2019-10-16 Thread durin42 (Augie Fackler)
Closed by commit rHG1a7d1f1aa0ac: tests: fix formatting test after move of black config (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7102?vs=17170=17205

D7115: rust-dependencies: pin the dependencies of hg-core to prevent breakage

2019-10-16 Thread Raphaël Gomès
Closed by commit rHG8607818012e7: rust-dependencies: pin the dependencies of hg-core to prevent breakage (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7114: automation: install Python 3.8.0

2019-10-16 Thread indygreg (Gregory Szorc)
Closed by commit rHG5b05df9c5c70: automation: install Python 3.8.0 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7114?vs=17194=17203 CHANGES SINCE LAST

D7113: automation: schedule an EC2Launch run on next boot

2019-10-16 Thread indygreg (Gregory Szorc)
Closed by commit rHGae3491aad62a: automation: schedule an EC2Launch run on next boot (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7113?vs=17193=17202

D7107: rust-cross-platform: remove `unimplemented!` to get compile-time errors instead

2019-10-16 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Edited the commit message and removed `instead` from end because `test-check-commit.t` was saying hi. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7107/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7107 To:

Re: Python 3 Transition Plan / Calendar Versioning

2019-10-16 Thread Augie Fackler
> On Oct 16, 2019, at 04:02, David Demelier wrote: > > I also don't understand why we keep creating releases at specific dates while > not just release “once it's ready”. We used to do that, long long ago (like...9 or 10 years ago). In practice it meant we had trouble ever getting releases

Re: Python 3 Transition Plan / Calendar Versioning

2019-10-16 Thread Augie Fackler
> On Oct 16, 2019, at 06:19, Anton Shestakov wrote: > >> Succinctly, we decided to adopt calendar versioning because Mercurial's >> version numbers don't have much semantic meaning and may confuse users who >> think the major version number changes imply breaking changes. Furthermore, >>

Re: Python 3 Transition Plan / Calendar Versioning

2019-10-16 Thread Augie Fackler
> On Oct 15, 2019, at 14:47, André Sintzoff wrote: > > Le mer. 9 oct. 2019 à 03:30, Gregory Szorc a écrit : >> >> Our new versioning scheme will be .[M]M.N. e.g. 2020.5.0 or 2020.10.1. >> This scheme consists of the 4 digit year, a 1-2 digit month, and a >> monotonically increasing

D7099: widening: pass in matchers instead of patterns

2019-10-16 Thread pulkit (Pulkit Goyal)
This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > The oldmatch is not used yet, but it should be used eventually when widening no longer resends manifests and files the client already has. You mean for ellipses case? If yes,

  1   2   >