[PATCH] tests: check availability of pyflakes by trying to import pyflakes module

2020-03-10 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1583901662 -3600 # Wed Mar 11 05:41:02 2020 +0100 # Node ID 14cffca0d2f0b0818ac98eefc432ba22b3d6e364 # Parent a08bbdf839ae08ff69c6f99a289ee85b3a012f03 tests: check availability of pyflakes by trying to import pyflakes module Since e397c6d74652

D7631: absorb: allowing committed changes to be absorbed into their ancestors

2020-03-10 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7631#123318 , @mjacob wrote: > I like the name `--from` for the option. It would also make sense in combination with a possible future `--into` option. The unfortunate thing about `--from` is that it implie

D7631: absorb: allowing committed changes to be absorbed into their ancestors

2020-03-10 Thread mjacob (Manuel Jacob)
mjacob added a comment. I like the name `--from` for the option. It would also make sense in combination with a possible future `--into` option. INLINE COMMENTS > martinvonz wrote in absorb.py:993 > I think we should at least have a TODO about adding them. > > By the way, without the next p

D8272: archive: fix crash when archiving to gzip file with Python 3.8.2+

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D8272#123252 , @ludovicchabant wrote: > The `_write_gzip_header` function is now getting passed the compression level in the latest Python release. > It does seem brittle to me to override some Python internal me

D8192: nodemap: display percentage of unused in `hg debugnodemap`

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20687. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8192?vs=20584&id=20687 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8184: nodemap: track the tip_node for validation

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20681. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8184?vs=20581&id=20681 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8193: nodemap: automatically "vacuum" the persistent nodemap when too sparse

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20688. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8193?vs=20585&id=20688 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8187: nodemap: make sure hooks have access to an up-to-date version

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20684. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8187?vs=20582&id=20684 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8191: nodemap: make sure on disk change get rolled back with the transaction

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20686. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8191?vs=20583&id=20686 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8188: nodemap: make sure the nodemap docket is updated after the changelog

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20685. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8188?vs=20391&id=20685 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8187: nodemap: make sure hooks have access to an up-to-date version

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D8187#123258 , @durin42 wrote: > No longer applies on top of @. I don't understand this feedback. There are about 15 other changesets before it in this stack, so this is not meant to be directly applied on the

D8164: rust-nodemap: automatically use the rust index for persistent nodemap

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20679. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8164?vs=20662&id=20679 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8186: nodemap: deal with the "debugupdatecache" case using a "fake" transaction

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20683. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8186?vs=20676&id=20683 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8185: changelog: change the implementation of `_divertopenener`

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20682. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8185?vs=20675&id=20682 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8183: nodemap: test that an outdated nodemap can catch up

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20680. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8183?vs=20674&id=20680 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8152: revlog: using two new functions in C capsule from Rust code

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20678. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8152?vs=20651&id=20678 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8174: nodemap: refresh the persistent data on nodemap creation

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute updated this revision to Diff 20677. rebase above latest default up to landed-D8182 REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8174?vs=20576&id=20677 BRANCH default CHANGES SINCE LAST ACTION https://phab.merc

D8183: nodemap: test that an outdated nodemap can catch up

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. This got cherry picked before the other patches that implement more of the nodemap in rust. As a result `test-persistent-nodemap.t` breaks. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8183/new/ REVISION DETAIL https://ph

D8270: run-tests: restrict Rust thread pool to 3 threads during tests

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > pulkit wrote in run-tests.py:2998 > Should we also take value of `-j` into account too? If `-j 1` is used, then > we should not do multi-threading here. I don't think we should take -j in account. Even if we run test one at a time, it is import

D7932: debugbackupbundle: introduce command to interact with strip backups

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > mharbison72 wrote in debugcommands.py:3432 > I thought we were trying to avoid `os.path`, so maybe just > `repo.vfs.join("strip-backup", ".hg")`? > > (And don't these need to be `b''` prefixed for py3?) +1 on using `vfs` here, this is the abstr

D8189: testlib: add a small scrip to help process to synchronise using file

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. By using explicit wait on signal (through the fs) that each process reached the appropriate file. We avoid flackyness. There are already multiple use of this approach in the test suite, that does not suffer from flackyness (unlike the wheelbarrow of flaky test relyi

D8186: nodemap: deal with the "debugupdatecache" case using a "fake" transaction

2020-03-10 Thread marmoute (Pierre-Yves David)
Closed by commit rHG3265c92f7d13: nodemap: deal with the "debugupdatecache" case using a "fake" transaction (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSIT

D8183: nodemap: test that an outdated nodemap can catch up

2020-03-10 Thread marmoute (Pierre-Yves David)
Closed by commit rHG1376cb1c8e34: nodemap: test that an outdated nodemap can catch up (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CH

D8185: changelog: change the implementation of `_divertopenener`

2020-03-10 Thread marmoute (Pierre-Yves David)
Closed by commit rHG897f0ce4b484: changelog: change the implementation of `_divertopener` (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8182: nodemap: document the docket attributes

2020-03-10 Thread marmoute (Pierre-Yves David)
Closed by commit rHG283fd803afa5: nodemap: document the docket attributes (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D8189: testlib: add a small scrip to help process to synchronise using file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 added a comment. This script feels extremely like a flaky test waiting to happen. Is there no alternative for this? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8189/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8189 To: marmoute,

D8187: nodemap: make sure hooks have access to an up-to-date version

2020-03-10 Thread durin42 (Augie Fackler)
This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. No longer applies on top of @. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8187/new/ REVISION DETAIL https://phab.mercurial-scm.org

D8270: run-tests: restrict Rust thread pool to 3 threads during tests

2020-03-10 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 accepted this revision as: durin42. INLINE COMMENTS > pulkit wrote in run-tests.py:2998 > Should we also take value of `-j` into account too? If `-j 1` is used, then > we should not do multi-threading here. I don't think so, since part of the goal is to un

D8272: archive: fix crash when archiving to gzip file with Python 3.8.2+

2020-03-10 Thread ludovicchabant (Ludovic Chabant)
ludovicchabant added a comment. It does seem brittle to me to override some Python internal method anyway? Can we get rid of this altogether? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8272/new/ REVISION DETAIL https://phab.mercurial-scm.org/D82

D8272: archive: fix crash when archiving to gzip file with Python 3.8.2+

2020-03-10 Thread ludovicchabant (Ludovic Chabant)
ludovicchabant created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8272 AFFECTED FILES mercurial/archival.py CHANGE DETAILS diff --git a/mercur

D7932: debugbackupbundle: introduce command to interact with strip backups

2020-03-10 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > martinvonz wrote in debugcommands.py:3432 > I think Windows doesn't care much about `/` vs `\`, but should we ideally use > `os.path.join(..., ".hg")` here? I thought we were trying to avoid `os.path`, so maybe just `repo.vfs.join("strip-bac

Re: [PATCH 2 of 2 STABLE] heptapod-ci: run the test from outside the test directory

2020-03-10 Thread Augie Fackler
queued for stable, thanks > On Mar 10, 2020, at 13:17, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1583855378 -3600 > # Tue Mar 10 16:49:38 2020 +0100 > # Branch stable > # Node ID 247cdc8417916c5fc223d839e0b702012fa2436d > # Parent 7621c3b5191

Re: [PATCH 3 of 3 STABLE] gzip: use the stdlib version with python 3 (issue6284)

2020-03-10 Thread Pierre-Yves David
Here is the associated CI run https://foss.heptapod.net/octobus/mercurial-devel/pipelines/3957 (the CI is python 2.7 and 3.7. I did local test with 3.8) tests/test-subrepo-deep-nested-change.t was broken before this patch and worked afterward. On 3/10/20 7:23 PM, Pierre-Yves David wrote: #

[PATCH 2 of 3 STABLE] gzip: indent the custom Gzip code

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583862799 -3600 # Tue Mar 10 18:53:19 2020 +0100 # Branch stable # Node ID d50ce19a49dac6ac8710291d903a93188dd97f1d # Parent f0f5e4dbc875fb4a7201987deba6c1eb2cbdbdee # EXP-Topic fix-3.8 # Available At https://dev.heptapod.net/octobus/merc

[PATCH 1 of 3 STABLE] gzip: rename the argument to `mtime` to match upstream python

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583863069 -3600 # Tue Mar 10 18:57:49 2020 +0100 # Branch stable # Node ID f0f5e4dbc875fb4a7201987deba6c1eb2cbdbdee # Parent 9803b374389a408dabdd4e3810ed7217ac0186a1 # EXP-Topic fix-3.8 # Available At https://dev.heptapod.net/octobus/merc

[PATCH 3 of 3 STABLE] gzip: use the stdlib version with python 3 (issue6284)

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583862884 -3600 # Tue Mar 10 18:54:44 2020 +0100 # Branch stable # Node ID 48b865a401be25e653870f652776b6836b6fed60 # Parent d50ce19a49dac6ac8710291d903a93188dd97f1d # EXP-Topic fix-3.8 # Available At https://dev.heptapod.net/octobus/merc

[PATCH 2 of 2 STABLE] heptapod-ci: run the test from outside the test directory

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583855378 -3600 # Tue Mar 10 16:49:38 2020 +0100 # Branch stable # Node ID 247cdc8417916c5fc223d839e0b702012fa2436d # Parent 7621c3b5191c951e974c31147b559101c0e9bf48 # EXP-Topic fix-hghave # Available At https://dev.heptapod.net/octobus/m

[PATCH 1 of 2 STABLE] run-tests: fix conditional when tests are run outside of `tests`

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583855222 -3600 # Tue Mar 10 16:47:02 2020 +0100 # Branch stable # Node ID 7621c3b5191c951e974c31147b559101c0e9bf48 # Parent 9803b374389a408dabdd4e3810ed7217ac0186a1 # EXP-Topic fix-hghave # Available At https://dev.heptapod.net/octobus/m

mercurial@44470: 19 new changesets

2020-03-10 Thread Mercurial Commits
19 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9d2b2df2c2ba changeset: 44452:9d2b2df2c2ba parent: 9:ff72bd52d56a user:Augie Fackler date:Fri Mar 06 13:27:41 2020 -0500 summary: cleanup: run pyupgrade on our source tree to clean up varying

D8265: git: key off `git` in .hg/requires rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
Closed by commit rHG02c47b74366c: git: key off `git` in .hg/requires rather than separate file (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercu

D8271: git: correctly handle p1() on dirstate when underlying git repo is empty

2020-03-10 Thread durin42 (Augie Fackler)
Closed by commit rHGeb061d272af4: git: correctly handle p1() on dirstate when underlying git repo is empty (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8265: git: key off `git` in .hg/requires rather than separate file

2020-03-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > durin42 wrote in test-git-interop.t:5-11 > My understanding is that the > will cause the lines to all happen in the same > shell invocation, whereas $ will do separate evaluations of each line, so > it's (more or less) intentional. I believe i

D8265: git: key off `git` in .hg/requires rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 retitled this revision from "git: key off `git` in .hg/requirements rather than separate file" to "git: key off `git` in .hg/requires rather than separate file". durin42 marked an inline comment as done. durin42 updated this revision to Diff 20669. REPOSITORY rHG Mercurial CHANGES SIN

D8271: git: correctly handle p1() on dirstate when underlying git repo is empty

2020-03-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This shows up in my next change, which ends up making an empty git repo and then running hg. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 marked 4 inline comments as done. INLINE COMMENTS > martinvonz wrote in test-git-interop.t:5-11 > `$` prefix on these too since you're cleaning up anyway? My understanding is that the > will cause the lines to all happen in the same shell invocation, where

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > __init__.py:89-94 > +reqsf = os.path.join(storebasepath, b'requires') > +reqs = set() > +if os.path.exists(reqsf): > +with open(reqsf, 'rb') as f: > +reqs = {l.strip() for l in f} > +if b'git' in reqs: is thi

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in __init__.py:89 > Why not use `.hg/requires`? Because I have the dumb. Will fix shortly. > pulkit wrote in dirstate.py:79 > looks like unrelated change which should be in separate patch? Sigh, you're right, and I'm being lazy.

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > dirstate.py:79 > def p1(self): > -return self.git.head.peel().id.raw > +try: > +return self.git.head.peel().id.raw looks like unrelated change which should be in separate patch? REPOSITORY rHG Mercurial CHANGES

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 20667. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20666&id=20667 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D82

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 marked an inline comment as done. durin42 updated this revision to Diff 20666. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20665&id=20666 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION D

D8246: hg-core: add a compilation error if trying to compile outside of Linux

2020-03-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Forgot to mention, I tried to apply this patch on default and it failed. Now I see it's targeted for stable. Since most of the rust code is experimental/not much used, it should be fine to have this on default branch. Any reason why this is targeted for stable? REPOS

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > __init__.py:89 > def _makestore(orig, requirements, storebasepath, vfstype): > -# Check for presence of pygit2 only here. The assumption is that we'll > -# run this code iff we'll later need pygit2. > -if gitutil.get_pygit2() is Non

D7922: rust-matchers: add function to generate a regex matcher function

2020-03-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7922#123207 , @pulkit wrote: > In D7922#123193 , @martinvonz wrote: > >> In D7922#123057 , @pulkit wrote: >> >>>

D7922: rust-matchers: add function to generate a regex matcher function

2020-03-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In D7922#123193 , @martinvonz wrote: > In D7922#123057 , @pulkit wrote: > >> @martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead a

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > mharbison72 wrote in __init__.py:104 > Shouldn't it be an error if `git` is in requirements, but `.git` doesn't > exist? Or is there something in the original function that will raise an > error in this

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 20665. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20664&id=20665 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D82

D8270: run-tests: restrict Rust thread pool to 3 threads during tests

2020-03-10 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > run-tests.py:2998 > +# multi-threading bugs while keeping the thrashing reasonable. > +os.environ.setdefault("RAYON_NUM_THREADS", "3") > + Should we also take value of `-j` into account too? If `-j 1` is used, then we should not do

D8265: git: key off `git` in .hg/requirements rather than separate file

2020-03-10 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 20664. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20614&id=20664 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D82

[Bug 6286] New: `hg push -r BOOKMARK` no longer causes the mark to update

2020-03-10 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6286 Bug ID: 6286 Summary: `hg push -r BOOKMARK` no longer causes the mark to update Product: Mercurial Version: default branch Hardware: PC OS: Mac OS

D8270: run-tests: restrict Rust thread pool to 3 threads during tests

2020-03-10 Thread Raphaël Gomès
Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8270 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.p

D7922: rust-matchers: add function to generate a regex matcher function

2020-03-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7922#123057 , @pulkit wrote: > @martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it? You can push it. I wanted to

Re: [PATCH] rust: clean remains of direct-ffi code

2020-03-10 Thread Yuya Nishihara
On Tue, 10 Mar 2020 14:49:16 +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1583846648 -3600 > # Tue Mar 10 14:24:08 2020 +0100 > # Node ID 3e9fa97f5932c6262c7323edc68c0737fe34af76 > # Parent b3991b72d9f15a092befdb499d0ec4891e432466 > # EXP-Topic d

[PATCH] rust: clean remains of direct-ffi code

2020-03-10 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1583846648 -3600 # Tue Mar 10 14:24:08 2020 +0100 # Node ID 3e9fa97f5932c6262c7323edc68c0737fe34af76 # Parent b3991b72d9f15a092befdb499d0ec4891e432466 # EXP-Topic direct-ffi-cleanup # Available At https://dev.heptapod.net/octobus/mercurial

Re: [PATCH 1 of 6 v3] setup: use printf instead of print

2020-03-10 Thread Yuya Nishihara
On Mon, 09 Mar 2020 18:34:52 +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1583770604 -3600 > # Mon Mar 09 17:16:44 2020 +0100 > # Node ID 27e1e79c1a5ad9dfa699954aa68a4c0361d39f1b > # Parent b4fe3395b975d72c56f392fa671f86c3ccd1a892 > # EXP-Topic r

Re: [PATCH 2 of 6 v3] cext: drop the WITH_RUST block

2020-03-10 Thread Yuya Nishihara
On Mon, 09 Mar 2020 18:34:53 +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1583771190 -3600 > # Mon Mar 09 17:26:30 2020 +0100 > # Node ID bbfdc8c2f3a2ac0f3c4921351614f4e134b0d46d > # Parent 27e1e79c1a5ad9dfa699954aa68a4c0361d39f1b > # EXP-Topic r

D8164: rust-nodemap: automatically use the rust index for persistent nodemap

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20662. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8164?vs=20579&id=20662 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8164/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8163: nodemap: use data from the index in debugnodemap --dump-new

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20661. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8163?vs=20578&id=20661 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8163/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8161: rust-nodemap: also clear Rust data in `clearcaches`

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20660. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8161?vs=20380&id=20660 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8161/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8160: rust-nodemap: add binding to `nodemap_update_data`

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20659. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8160?vs=20379&id=20659 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8160/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8159: rust-nodemap: add binding for `nodemap_data_incremental`

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20658. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8159?vs=20378&id=20658 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8159/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8158: rust-nodemap: add binding for `nodemap_data_all`

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20657. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8158?vs=20377&id=20657 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8158/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8157: rust-nodemap: use proper Index API instead of using the C API

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20656. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8157?vs=20376&id=20656 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8157/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8156: rust-nodemap: add utils for propagating errors

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20655. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8156?vs=20331&id=20655 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8156/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8155: rust-nodemap: add utils to create `Node`s from Python objects

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20654. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8155?vs=20330&id=20654 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8155/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8152: revlog: using two new functions in C capsule from Rust code

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20651. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8152?vs=20327&id=20651 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8152/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8154: rust-index: add `append` method to cindex/Index

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20653. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8154?vs=20329&id=20653 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8154/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8153: rust-index: moved constructor in separate impl block

2020-03-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 20652. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8153?vs=20328&id=20652 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8153/new/ REVISION DETAIL https://phab.mercurial-scm.org/D81

D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269)

2020-03-10 Thread marmoute (Pierre-Yves David)
marmoute added a comment. This is released as part of 5.3.1 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8134/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8134 To: pulkit, #hg-reviewers, marmoute Cc: sluongng, durin42, marmoute, mercurial-

D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269)

2020-03-10 Thread sluongng (Son Luong Ngoc)
sluongng added a comment. Is there a chance to get this fix in an upcoming minor release? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8134/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8134 To: pulkit, #hg-reviewers, marmoute Cc: sluongng,