pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowbundle2.py:54
> > I said that because there is a 'narrow:changespec' part being send from the
> > server.
>
> I assumed that was the reason :) But I don't think we'll need that part
> because we don't need to strip nodes
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad9ca365738b: narrow: factor out logic to create cg while
widening into separate fn (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm
martinvonz accepted this revision.
martinvonz added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> pulkit wrote in narrowbundle2.py:54
> > since ellipses case will require sending a bundle not a changegroup
>
> I said that because there is a 'narrow:changespe
pulkit added a comment.
I have not changed this patch much, just added a XXX, saying we should return
a bundle from here. I changed https://phab.mercurial-scm.org/D4813 to return a
bundle2 instead of just sending the changegroup and added a patch on top of it
for returning a bundle2 from the
pulkit updated this revision to Diff 11559.
pulkit edited the summary of this revision.
Herald added a reviewer: martinvonz.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4786?vs=11469&id=11559
REVISION DETAIL
https://phab.mercurial-scm.org/D4786
AFFEC
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in narrowbundle2.py:54
> I do plan to support ellipses with the wireprotocol command. Since ellipses
> case will require sending a bundle not a changegroup, I plan to make that as
> a seperate function and call the required functi
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowbundle2.py:54
> Do you plan to add support for ellipses to this too? I don't know if you need
> that feature, but I think the coming wire protocol command should eventually
> gain support for ellipsis nodes. Do you think
martinvonz added inline comments.
INLINE COMMENTS
> narrowbundle2.py:54
>
> +def widen_changegroup(repo, diffmatcher, common, cgversion, source):
> +"""generates changegroup for widening a narrow clone
Do you plan to add support for ellipses to this too? I don't know if you need
that feat
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch takes out the logic which generates a changegroup for widening a
narrow clone when ellipses are disabled. This is done
