Re: [Mesa-dev] [PATCH 2/3] translate: implement translation of (pure) integer formats

2012-01-04 Thread Dave Airlie
On Mon, Jan 2, 2012 at 1:07 PM, Marek Olšák mar...@gmail.com wrote: The conversion is limited to only a few cases, because converting to any other type shouldn't happen in any driver. Reviewed-by: Dave Airlie airl...@redhat.com Dave. ___ mesa-dev

Re: [Mesa-dev] [PATCH 3/3] translate: implement translation of 10_10_10_2 types

2012-01-04 Thread Dave Airlie
On Mon, Jan 2, 2012 at 1:07 PM, Marek Olšák mar...@gmail.com wrote: This is for GL_ARB_vertex_type_2_10_10_10_rev. I just took the code from u_format_table.c. It's based on pack_rgba_float. I had no other choice. The u_format hooks are not exactly compatible with translate. The cleanup of it

[Mesa-dev] [Bug 44438] New: Configure fails on missing tests/Makefile.in

2012-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44438 Bug #: 44438 Summary: Configure fails on missing tests/Makefile.in Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All)

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix glGetTransformFeedbackVarying().

2012-01-04 Thread Eric Anholt
On Tue, 03 Jan 2012 19:19:16 -0800, Ian Romanick i...@freedesktop.org wrote: On 01/03/2012 06:52 PM, Eric Anholt wrote: The current implementation was totally broken -- it was looking in an unpopulated structure for varyings, and trying to do so using the current list of varying names, not

Re: [Mesa-dev] [RFC PATCH] mesa/gl3: introduce a new option to the gl3 version enable.

2012-01-04 Thread Eric Anholt
On Mon, 2 Jan 2012 16:34:23 +, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com EXT_texture_integer isn't strictly equivalent to GL3, the L/I/A integer formats are not required in GL3, and some drivers may not require them. I've no idea if we have any hw that

Re: [Mesa-dev] [PATCH] intel: Re-enable GL_OES_standard_derivatives on GEN4+

2012-01-04 Thread Eric Anholt
On Tue, 3 Jan 2012 19:26:57 -0800, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com This extension only needs to be enabled on GEN3. disabled. Other than that, Reviewed-by: Eric Anholt e...@anholt.net pgp9ZUAH5fyxL.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH] glx/dri2: print FPS when env var MESA_SHOW_FPS is 1

2012-01-04 Thread Michel Dänzer
On Mit, 2012-01-04 at 06:05 +0100, Marek Olšák wrote: This is useful for apps which don't print FPS. Only enabled in SwapBuffers. --- src/glx/dri2_glx.c | 36 +++- 1 files changed, 35 insertions(+), 1 deletions(-) diff --git a/src/glx/dri2_glx.c

Re: [Mesa-dev] [PATCH] intel: Re-enable GL_OES_standard_derivatives on GEN4+

2012-01-04 Thread Kenneth Graunke
On 01/04/2012 12:37 AM, Eric Anholt wrote: On Tue, 3 Jan 2012 19:26:57 -0800, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com This extension only needs to be enabled on GEN3. disabled. Other than that, Reviewed-by: Eric Anholt e...@anholt.net

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin varyings.

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 06:42 PM, Paul Berry wrote: [snip] Ok, sounds good. I'm going to consider this an acked-by if that's all right with you. I haven't heard many comments on this patch series, but given that it fixes the tests and there hasn't been any negative feedback, I think I'm going to

Re: [Mesa-dev] [PATCH 3/3] vl: replace decode_buffers with auxiliary data field

2012-01-04 Thread Christian König
On 03.01.2012 17:03, Maarten Lankhorst wrote: Hi Christian, 2012/1/2 Christian Königdeathsim...@vodafone.de: Hi Maarten, first of all: Happy new Year and sorry for the late reply, have been on vacation for the last week. On 29.12.2011 16:41, Maarten Lankhorst wrote: Hey Christian, Op

Re: [Mesa-dev] [PATCH] mesa: Avoid segfault when getting an unbound transform feedback buffer name.

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 02:11 PM, Paul Berry wrote: Previously we were using gl_transform_feedback_object::Buffers[i]-Name to service an indexed get request for GL_TRANSFORM_FEEDBACK_BUFFER_BINDING. However, if no buffer has been bound, gl_transform_feedback_object::Buffers[i] is NULL, so this was

Re: [Mesa-dev] [PATCH] mesa: Fix transform feedback of unsubscripted arrays.

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 10:35 PM, Paul Berry wrote: It is not explicitly stated in the GL 3.0 spec that transform feedback can be performed on a whole varying array (without supplying a subscript). However, it seems clear from context that this was the intent. Section 2.15 (TransformFeedback) says

Re: [Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 12:32 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Detect whether a new enough version of XCB is installed at configure time. If it is not, don't enable the extension and don't build the unit tests. Signed-off-by: Ian Romanick ian.d.roman...@intel.com

Re: [Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 01:03 PM, Paul Berry wrote: With the addition of unit tests in commit 3ef3ba4d2eee36f64062a21ce030c3f4d8c4cac4, several additional build artifacts are created: bin/depcomp bin/missing tests/Makefile tests/Makefile.in tests/glx/Makefile tests/glx/Makefile.in

[Mesa-dev] [PATCH] i965: Add missing _NEW_TEXTURE dirty bit to brw_vs_prog state atom.

2012-01-04 Thread Kenneth Graunke
Commit d45814c925dd6c479cfd383b9b59458fc4359cf7 totally added a data dependency on _NEW_TEXTURE, even including the comment, but didn't actually add the dirty bit. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_vs.c |1 + 1 files changed, 1

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 09:43 PM, Marek Olšák wrote: On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick i...@freedesktop.org wrote: diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index db2f200..50a724b 100644 --- a/src/mesa/main/uniform_query.cpp +++

[Mesa-dev] [PATCH] i965/vs: Use the proper dimensionality for the sampler result register.

2012-01-04 Thread Kenneth Graunke
textureSize() returns an int, ivec2, or ivec3, but never an ivec4. Creating the destination register as an ivec4 triggered later failures, even though the register did hold the proper values. For example, piglit test vs-textureSize-compare calls textureSize on a 2D texture and compares the result

[Mesa-dev] [PATCH 2/3] st/mesa: add support for clip vertex.

2012-01-04 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com We need to pass the pre-projection matrix clip planes into the driver, instead of the post for the case we have a vertex shader that writes clip vertex. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_atom_clip.c | 20

[Mesa-dev] [PATCH 1/3] gallium: add new semantic for clip vertex.

2012-01-04 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This is to match the gl_ClipVertex output from GLSL 1.20. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_dump.c |3 ++- src/gallium/include/pipe/p_shader_tokens.h |3 ++- 2 files changed, 4 insertions(+), 2

[Mesa-dev] gallium clip vertex support + softpipe

2012-01-04 Thread Dave Airlie
Hi, This is a GLSL 1.20 feature we don't have support for in softpipe, and we fail the tests, this is just my first attempt to add support, it could probably be done another way, this just seemed the simplest first cut. It passes the tests in piglit now, just waiting a full run to see if it does

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Marek Olšák
On Wed, Jan 4, 2012 at 12:28 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 01/03/2012 09:43 PM, Marek Olšák wrote: On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick i...@freedesktop.org wrote: diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index

Re: [Mesa-dev] [PATCH] glx/dri2: print FPS when env var MESA_SHOW_FPS is 1

2012-01-04 Thread Marek Olšák
2012/1/4 Michel Dänzer mic...@daenzer.net: On Mit, 2012-01-04 at 06:05 +0100, Marek Olšák wrote: This is useful for apps which don't print FPS. Only enabled in SwapBuffers. ---  src/glx/dri2_glx.c |   36 +++-  1 files changed, 35 insertions(+), 1 deletions(-)

Re: [Mesa-dev] [PATCH] glx/dri2: print FPS when env var MESA_SHOW_FPS is 1

2012-01-04 Thread Michel Dänzer
On Mit, 2012-01-04 at 15:04 +0100, Marek Olšák wrote: 2012/1/4 Michel Dänzer mic...@daenzer.net: On Mit, 2012-01-04 at 06:05 +0100, Marek Olšák wrote: This is useful for apps which don't print FPS. Only enabled in SwapBuffers. --- src/glx/dri2_glx.c | 36

[Mesa-dev] [PATCH 1/2] gallium: add STATIC_ASSERT macro

2012-01-04 Thread Brian Paul
--- src/gallium/include/pipe/p_compiler.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/gallium/include/pipe/p_compiler.h b/src/gallium/include/pipe/p_compiler.h index 6ac3644..1daa5ab 100644 --- a/src/gallium/include/pipe/p_compiler.h +++

[Mesa-dev] [PATCH 2/2] tgsi: consolidate TGSI string arrays in new tgsi_strings.h

2012-01-04 Thread Brian Paul
There was some duplication between the tgsi_dump.c and tgsi_text.c files. Also use some static assertions to help catch errors when adding new TGSI values. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c |1 + src/gallium/auxiliary/tgsi/tgsi_dump.c | 139 +

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-04 Thread Adam Jackson
On Tue, 2012-01-03 at 19:14 -0800, Ian Romanick wrote: Okay. If some of that gets captured in the commit message, the change is Reviewed-by: Ian Romanick ian.d.roman...@intel.com Pushed with better commit message, thanks. - ajax signature.asc Description: This is a digitally signed

Re: [Mesa-dev] gallium clip vertex support + softpipe

2012-01-04 Thread Brian Paul
On 01/04/2012 05:12 AM, Dave Airlie wrote: Hi, This is a GLSL 1.20 feature we don't have support for in softpipe, and we fail the tests, this is just my first attempt to add support, it could probably be done another way, this just seemed the simplest first cut. It passes the tests in piglit

Re: [Mesa-dev] [PATCH 1/3] gallium: add new semantic for clip vertex.

2012-01-04 Thread Brian Paul
On 01/04/2012 05:12 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com This is to match the gl_ClipVertex output from GLSL 1.20. Signed-off-by: Dave Airlieairl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_dump.c |3 ++- src/gallium/include/pipe/p_shader_tokens.h |3

Re: [Mesa-dev] [PATCH 3/3] draw/softpipe: add clip vertex support.

2012-01-04 Thread Brian Paul
On 01/04/2012 05:13 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com softpipe always clipped using the position vector, however for unclipped vertices it stored the position in window coordinates, however when position and clipping are separated, we need to store the clip-space

Re: [Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

2012-01-04 Thread Robert Hooker
dri builds are fine with this, but ./configure --prefix=/usr --mandir=\${prefix}/share/man \             --infodir=\${prefix}/share/info --sysconfdir=/etc \             --libdir=\${prefix}/lib/x86_64-linux-gnu \             --localstatedir=/var

Re: [Mesa-dev] [PATCH] mesa/main: fix incorrect use of _mesa_ffsll. _mesa_ffsll may or may not be defined on GNUC

2012-01-04 Thread Alexander von Gluck
On 03.01.2012 16:54, Brian Paul wrote: On Tue, Jan 3, 2012 at 1:49 PM, Alexander von Gluck kallis...@unixzen.com wrote: ---  src/mesa/main/arrayobj.c |    2 +-  src/mesa/main/imports.h  |    2 +-  2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/arrayobj.c

[Mesa-dev] [PATCH] mesa: fix situations where ffs or ffsl may not be defined

2012-01-04 Thread Alexander von Gluck
--- src/mesa/main/imports.h | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index b7e8743..522ffeb 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -568,13 +568,19 @@

Re: [Mesa-dev] [PATCH] Bug 44205 - read from pointer after free

2012-01-04 Thread Anuj Phogat
On Tue 03 Jan 2012 07:14:09 PM PST, Ian Romanick wrote: On 01/03/2012 06:36 PM, Anuj Phogat wrote: Coverity reported a read from pointer after free defect in src/mesa/drivers/dri/intel/intel_mipmap_tree.c In intel_miptree_all_slices_resolve() function, i = i-next was executing after freeing

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-04 Thread Roland Scheidegger
Am 04.01.2012 04:20, schrieb Yuanhan Liu: On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: Ah index scanning... I don't like that this will map/unmap the ib once for each prim, Me either :) though I don't really see a nice way to avoid that (I think if you have to

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-04 Thread Roland Scheidegger
Am 04.01.2012 04:59, schrieb Yuanhan Liu: On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: Ah index scanning... I don't like that this will map/unmap the ib once for each prim, Me either :) though I don't

[Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

2012-01-04 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Detect whether a new enough version of XCB is installed at configure time. If it is not, don't enable the extension and don't build the unit tests. v2: Move the AM_CONDIATION outside the case-statement so that it is invoked even for non-GLX builds.

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Ian Romanick
On 01/04/2012 12:54 AM, Mike Lothian wrote: On 4 January 2012 03:50, Ian Romanicki...@freedesktop.org wrote: On 01/03/2012 06:06 PM, Mike Lothian wrote: On 3 January 2012 20:27, Ian Romanicki...@freedesktop.orgwrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 18:45, Ian Romanick i...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem:  * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub  * econf: updating Mesa-/bin/config.guess with

Re: [Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-04 Thread Ian Romanick
On 01/03/2012 01:03 PM, Paul Berry wrote: With the addition of unit tests in commit 3ef3ba4d2eee36f64062a21ce030c3f4d8c4cac4, several additional build artifacts are created: bin/depcomp bin/missing tests/Makefile tests/Makefile.in tests/glx/Makefile tests/glx/Makefile.in

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Ian Romanick
On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanicki...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem: * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub * econf: updating

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Michel Dänzer
On Mit, 2012-01-04 at 10:56 -0800, Ian Romanick wrote: On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanicki...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem: * econf: updating

Re: [Mesa-dev] [PATCH] i965/vs: Use the proper dimensionality for the sampler result register.

2012-01-04 Thread Ian Romanick
On 01/04/2012 04:07 AM, Kenneth Graunke wrote: textureSize() returns an int, ivec2, or ivec3, but never an ivec4. Creating the destination register as an ivec4 triggered later failures, even though the register did hold the proper values. For example, piglit test vs-textureSize-compare calls

Re: [Mesa-dev] [PATCH] i965: Add missing _NEW_TEXTURE dirty bit to brw_vs_prog state atom.

2012-01-04 Thread Eric Anholt
On Wed, 4 Jan 2012 03:15:56 -0800, Kenneth Graunke kenn...@whitecape.org wrote: Commit d45814c925dd6c479cfd383b9b59458fc4359cf7 totally added a data dependency on _NEW_TEXTURE, even including the comment, but didn't actually add the dirty bit. Reviewed-by: Eric Anholt e...@anholt.net

Re: [Mesa-dev] [PATCH] i965/vs: Use the proper dimensionality for the sampler result register.

2012-01-04 Thread Eric Anholt
On Wed, 4 Jan 2012 04:07:24 -0800, Kenneth Graunke kenn...@whitecape.org wrote: textureSize() returns an int, ivec2, or ivec3, but never an ivec4. Creating the destination register as an ivec4 triggered later failures, even though the register did hold the proper values. For example,

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Ian Romanick
On 01/04/2012 11:05 AM, Michel Dänzer wrote: On Mit, 2012-01-04 at 10:56 -0800, Ian Romanick wrote: On 01/04/2012 10:55 AM, Daniel Stone wrote: Hi, On 4 January 2012 18:45, Ian Romanicki...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem:

Re: [Mesa-dev] [PATCH] mesa: Fix transform feedback of unsubscripted arrays.

2012-01-04 Thread Ian Romanick
On 01/03/2012 10:35 PM, Paul Berry wrote: It is not explicitly stated in the GL 3.0 spec that transform feedback can be performed on a whole varying array (without supplying a subscript). However, it seems clear from context that this was the intent. Section 2.15 (TransformFeedback) says this:

[Mesa-dev] [Bug 44405] Spring RTS crashes using r600g (5670, Redwood), kernel rejects relocations

2012-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44405 --- Comment #3 from Marcin Baczyński marb...@gmail.com 2012-01-04 11:43:21 PST --- Glad you know what's wrong in there. Is there anything I can do to help fixing this bug? Like some traces or debug dumps? -- Configure bugmail:

[Mesa-dev] [Bug 44438] Configure fails on missing tests/Makefile.in

2012-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44438 --- Comment #1 from Ian Romanick i...@freedesktop.org 2012-01-04 11:44:52 PST --- There has been some discussion about this on the mesa-dev mailing list (see link below). The current thinking is that the Gentoo build is not running automake

[Mesa-dev] [Bug 44438] Configure fails on missing tests/Makefile.in

2012-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44438 Ian Romanick i...@freedesktop.org changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |i...@freedesktop.org

Re: [Mesa-dev] [PATCH 3/5] glsl: rename VERSION to VERSION_TOK for automake

2012-01-04 Thread Ian Romanick
On 12/23/2011 04:21 PM, Matt Turner wrote: Signed-off-by: Matt Turnermatts...@gmail.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/glsl_lexer.ll |2 +- src/glsl/glsl_parser.yy |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/5] configure.ac: remove deprecated --with-driver=

2012-01-04 Thread Ian Romanick
On 12/23/2011 04:21 PM, Matt Turner wrote: See 9e7a4147. Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- configure.ac | 77 -- 1 files changed, 0 insertions(+), 77 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [Mesa-dev] [PATCH 2/5] configure.ac: bump AC_PREREQ to 2.60

2012-01-04 Thread Ian Romanick
On 12/23/2011 05:38 PM, Gaetan Nadon wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11-12-23 08:09 PM, Matt Turner wrote: On Fri, Dec 23, 2011 at 8:06 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 12/23/2011 04:21 PM, Matt Turner wrote: --- configure.ac | 2 +- 1 files

Re: [Mesa-dev] R600g LLVM shader backend

2012-01-04 Thread Tom Stellard
Hi Jose, On Thu, 2011-12-15 at 10:41 -0800, Jose Fonseca wrote: - Original Message - On Mon, 2011-12-12 at 07:05 -0800, Jose Fonseca wrote: - Original Message - Hi, I have just pushed a branch containing an LLVM shader backend for r600g to my personal

[Mesa-dev] [PATCH] mesa: fix _mesa_get_fallback_texture() to handle all texture targets

2012-01-04 Thread Brian Paul
Previously, this function only handled 2D textures. The fallback texture is used when we try to sample from an incomplete texture object. GLSL says sampling an incomplete texture should return (0,0,0,1). --- src/mesa/main/mtypes.h |2 +- src/mesa/main/shared.c |8 ++-

[Mesa-dev] [PATCH] mesa: only map src/dest regions in _mesa_copy_buffer_subdata()

2012-01-04 Thread Brian Paul
We were wastefully mapping the whole source/dest buffers before. --- src/mesa/main/bufferobj.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 66957e4..c4a7b8d 100644 --- a/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH] mesa: Fix transform feedback of unsubscripted arrays.

2012-01-04 Thread Paul Berry
On 4 January 2012 11:38, Ian Romanick i...@freedesktop.org wrote: On 01/03/2012 10:35 PM, Paul Berry wrote: It is not explicitly stated in the GL 3.0 spec that transform feedback can be performed on a whole varying array (without supplying a subscript). However, it seems clear from context

[Mesa-dev] [PATCH 1/2] mesa: Fix computation of transform feedback num_components.

2012-01-04 Thread Paul Berry
The function tfeedback_decl::num_components() was not correctly accounting for transform feedback of whole arrays and gl_ClipDistance. The bug was hard to notice in tests, because it only affected the checks for MAX_TRANSFORM_FEEDBACK_SEPARATE_COMPONENTS and

[Mesa-dev] [PATCH 2/2] mesa: Fix transform feedback of unsubscripted gl_ClipDistance array.

2012-01-04 Thread Paul Berry
On drivers that set gl_shader_compiler_options::LowerClipDistance (for example i965), we need to handle transform feedback of gl_ClipDistance specially, to account for the fact that the hardware represents it as an array of vec4's rather than an array of floats. The previous way this was

[Mesa-dev] [PATCH] mesa: Fix bogus transform feedback error message when subscripting non-array.

2012-01-04 Thread Paul Berry
Previous to this patch, if the client requested transform feedback using a subscript, but the variable was not an array (e.g. gl_FrontColor[0]), we would produce a bogus error message like Transform feedback varying gl_FrontColor[0] found, but it's an array ([] expected). Changed the error

Re: [Mesa-dev] [PATCH] mesa: Fix bogus transform feedback error message when subscripting non-array.

2012-01-04 Thread Kenneth Graunke
On 01/04/2012 03:23 PM, Paul Berry wrote: Previous to this patch, if the client requested transform feedback using a subscript, but the variable was not an array (e.g. gl_FrontColor[0]), we would produce a bogus error message like Transform feedback varying gl_FrontColor[0] found, but it's an

Re: [Mesa-dev] [PATCH] mesa: Fix bogus transform feedback error message when subscripting non-array.

2012-01-04 Thread Eric Anholt
On Wed, 4 Jan 2012 15:23:06 -0800, Paul Berry stereotype...@gmail.com wrote: Previous to this patch, if the client requested transform feedback using a subscript, but the variable was not an array (e.g. gl_FrontColor[0]), we would produce a bogus error message like Transform feedback varying

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Eric Anholt
On Wed, 04 Jan 2012 03:28:12 -0800, Kenneth Graunke kenn...@whitecape.org wrote: On 01/03/2012 09:43 PM, Marek Olšák wrote: This ProgramStringNotify call causes excessive shader recompilations in the game Cogs (from some Humble Bundle). Approximately 25% of in-game CPU time is spent on

[Mesa-dev] [PATCH] mesa: Add forgotten GL_RG_INTEGER format in unpack_color_span_float.

2012-01-04 Thread Kenneth Graunke
Fixes piglit test spec/EXT_texture_integer/texture_integer_glsl130 on Sandybridge. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/pack.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index

Re: [Mesa-dev] [PATCH 0/2 v4] Add support for clip distances in Gallium

2012-01-04 Thread Bryan Cain
On 01/02/2012 02:58 PM, Bryan Cain wrote: This is the fourth revision of my changes to add support for gl_ClipDistance with Gallium. The first three revisions were sent in closer succession about two weeks ago. This revision is identical to v3 except for the inclusion of the changes

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Marek Olšák
On Thu, Jan 5, 2012 at 12:45 AM, Eric Anholt e...@anholt.net wrote: On Wed, 04 Jan 2012 03:28:12 -0800, Kenneth Graunke kenn...@whitecape.org wrote: On 01/03/2012 09:43 PM, Marek Olšák wrote: This ProgramStringNotify call causes excessive shader recompilations in the game Cogs (from some

[Mesa-dev] [PATCH] mesa: Add missing GL_RG_INTEGER cases

2012-01-04 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Adds two missing '|| srcFormat == GL_RG_INTEGER' in assertions and a bunch of missing pixel converions cases. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/pack.c | 39 +++ 1 files

Re: [Mesa-dev] [PATCH] mesa: Fix bogus transform feedback error message when subscripting non-array.

2012-01-04 Thread Ian Romanick
On 01/04/2012 03:23 PM, Paul Berry wrote: Previous to this patch, if the client requested transform feedback using a subscript, but the variable was not an array (e.g. gl_FrontColor[0]), we would produce a bogus error message like Transform feedback varying gl_FrontColor[0] found, but it's an

Re: [Mesa-dev] [PATCH] mesa: Add missing GL_RG_INTEGER cases

2012-01-04 Thread Kenneth Graunke
On 01/04/2012 04:38 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Adds two missing '|| srcFormat == GL_RG_INTEGER' in assertions and a bunch of missing pixel converions cases. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

2012-01-04 Thread Laurent Carlier
From: Ian Romanick ian.d.roman...@intel.com Detect whether a new enough version of XCB is installed at configure time. If it is not, don't enable the extension and don't build the unit tests. v2: Move the AM_CONDIATION outside the case-statement so that it is invoked even for non-GLX

[Mesa-dev] [PATCH] [RFC] r600g clip distance support

2012-01-04 Thread Vadim Girlin
The patch requires the Marek's gallium-clip-state branch [1] and the patches from Bryan Cain for gallium/tgsi clip distance support [2]. Also it seems we need to increase MaxClipPlanes to 8 somewhere. Tested on evergreen: fixes about 30 tests related to clip distance. [1]

[Mesa-dev] [PATCH] r600g: implement clip distance

2012-01-04 Thread Vadim Girlin
--- src/gallium/drivers/r600/evergreen_state.c | 22 ++--- src/gallium/drivers/r600/r600_pipe.h |3 ++ src/gallium/drivers/r600/r600_shader.c | 42 ++--- src/gallium/drivers/r600/r600_shader.h |5 +++

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Ian Romanick
On 01/03/2012 09:43 PM, Marek Olšák wrote: On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanicki...@freedesktop.org wrote: diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index db2f200..50a724b 100644 --- a/src/mesa/main/uniform_query.cpp +++

Re: [Mesa-dev] [PATCH] mesa: only map src/dest regions in _mesa_copy_buffer_subdata()

2012-01-04 Thread Yuanhan Liu
On Wed, Jan 04, 2012 at 02:55:44PM -0700, Brian Paul wrote: We were wastefully mapping the whole source/dest buffers before. --- src/mesa/main/bufferobj.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) Looks good to me. Reviewed-by: Yuanhan Liu

[Mesa-dev] [PATCH 1/7] i965: Add sensible disasm for the JMPI instruction.

2012-01-04 Thread Eric Anholt
We care about the jump distance, not that the first src is always the ip register. --- src/mesa/drivers/dri/i965/brw_disasm.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c index

[Mesa-dev] [PATCH 2/7] swrast: Move the check for fast_copy_pixels() ability to caller.

2012-01-04 Thread Eric Anholt
I'm going to reuse this function from glBlitFramebuffer() handling, which wants to do the same thing. --- src/mesa/swrast/s_copypix.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/swrast/s_copypix.c b/src/mesa/swrast/s_copypix.c index

[Mesa-dev] [PATCH 4/7] swrast: Fix use of uninitialized value in rbmapping changes.

2012-01-04 Thread Eric Anholt
I'm so surprised that gcc didn't catch this that I feel like I must be misreading. srcMap is what we initialize (along with dstMap) from this map value right after this check. --- src/mesa/swrast/s_copypix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 5/7] mesa: Fix packing of stencil bits to MESA_FORMAT_Z32_FLOAT_X24S8.

2012-01-04 Thread Eric Anholt
We were converting our ubyte stencil value to a float. Just write it as a uint, which overwrites the X24 part of X24S8 with 0 but shouldn't matter. --- src/mesa/main/format_pack.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/format_pack.c

[Mesa-dev] [PATCH 3/7] swrast: Use the fast copypixels code to implement fast glBlitFramebuffer().

2012-01-04 Thread Eric Anholt
They were meaning to do the same thing of memcpying rows, so just write the code once. --- src/mesa/swrast/s_blit.c| 167 +-- src/mesa/swrast/s_copypix.c | 13 ++-- src/mesa/swrast/swrast.h|5 ++ 3 files changed, 46 insertions(+), 139

[Mesa-dev] [PATCH 7/7] i965: Turn on ARB_depth_buffer_float by default.

2012-01-04 Thread Eric Anholt
Everything about this that we have tests for works except for the deprecated metaops. The conclusion we came to on IRC sounded like we were OK with turning it on as long as core functionality works. The remaining failures (copypixels, drawpixels) should just be a matter of finishing the

Re: [Mesa-dev] [PATCH 1/7] i965: Add sensible disasm for the JMPI instruction.

2012-01-04 Thread Kenneth Graunke
On 01/04/2012 06:04 PM, Eric Anholt wrote: We care about the jump distance, not that the first src is always the ip register. --- src/mesa/drivers/dri/i965/brw_disasm.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) Patches 1-5 and 7 are Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] mesa: only map src/dest regions in _mesa_copy_buffer_subdata()

2012-01-04 Thread Kenneth Graunke
On 01/04/2012 01:55 PM, Brian Paul wrote: We were wastefully mapping the whole source/dest buffers before. --- src/mesa/main/bufferobj.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index

[Mesa-dev] [Bug 44480] New: Build error with LLVM -DLLVM_APPEND_VC_REV=ON

2012-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44480 Bug #: 44480 Summary: Build error with LLVM -DLLVM_APPEND_VC_REV=ON Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: