[Mesa-dev] [Bug 53318] New: [softpipe] sp_state_shader.c:194:softpipe_delete_fs_state: Assertion `var != softpipe-fs_variant' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53318 Bug #: 53318 Summary: [softpipe] sp_state_shader.c:194:softpipe_delete_fs_state: Assertion `var != softpipe-fs_variant' failed. Classification: Unclassified Product:

Re: [Mesa-dev] [PATCH 0/16] Assorted gallium shader, sampler, sampler_view changes

2012-08-10 Thread Bryan Cain
On 08/09/2012 10:11 PM, Brian Paul wrote: The following patches are steps toward some gallium API clean-ups. 1. Eventually, replace pipe_context::bind_fragment/vertex/geometry/compute_sampler_states() with a single bind_sampler_states() entrypoint which takes a PIPE_SHADER_x to identify the

[Mesa-dev] [Bug 53321] New: [softpipe] sp_texture.c:322:softpipe_get_transfer: Assertion `level = resource-last_level' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53321 Bug #: 53321 Summary: [softpipe] sp_texture.c:322:softpipe_get_transfer: Assertion `level = resource-last_level' failed. Classification: Unclassified Product: Mesa Version: git

[Mesa-dev] [Bug 53319] [softpipe] sp_texture.c:322:softpipe_get_transfer: Assertion `level = resource-last_level' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53319 --- Comment #1 from Vinson Lee v...@freedesktop.org 2012-08-10 06:53:10 UTC --- *** Bug 53321 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving

[Mesa-dev] [Bug 53321] [softpipe] sp_texture.c:322:softpipe_get_transfer: Assertion `level = resource-last_level' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53321 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning: narrowing conversion of X from 'int' to 'float' inside { } is ill-formed in C++11 [-Wnarrowing] in

Re: [Mesa-dev] [PATCH 16/16] r600: update sampler, sampler_view code for the future

2012-08-10 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com On Fri, Aug 10, 2012 at 5:11 AM, Brian Paul bri...@vmware.com wrote: For when we have pipe-set_sampler_states(pipe, shader, start, num, samplers), etc. --- src/gallium/drivers/r600/evergreen_state.c |6 +-- src/gallium/drivers/r600/r600_pipe.h

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Kenneth Graunke
On 08/10/2012 07:51 AM, Chad Versace wrote: On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning: narrowing conversion of X from 'int' to 'float' inside { } is

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #8 from Benoit Jacob bja...@mozilla.com 2012-08-10 15:13:28 UTC --- (In reply to comment #7) Is it possible for you to make an apitrace of this issue? I don't have time to install/setup a WebGL browser ATM. For what it's worth,

[Mesa-dev] [PATCH] st/mesa: fix glCopyTexSubImage crash

2012-08-10 Thread Brian Paul
Fixes a WebGL crash. The dest texture image is at level 2 and is of size 1x1 texel. The st texture image is a stand-alone resource, not a pointer into a complete mipmap. So the resource has one level and trying to write to level 2 blows up. Fixes

[Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Brian Paul
Fixes WebGL conformance/uniforms/uniform-default-values.html crash. We need to check for the null view pointer before accessing view-texture. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53317 Note: This is a candidate for the 8.0 branch. --- src/gallium/auxiliary/gallivm/lp_bld_sample.c

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #9 from Brian Paul brian.e.p...@gmail.com 2012-08-10 15:28:11 UTC --- Firefox on my main machine is a bit old but I have a new enough Firefox in one of my Linux VMs so I'm doing some WebGL testing/fixing with that. -- Configure

Re: [Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Jose Fonseca
Is a view with a NULL texture really possible? Otherwise Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - Fixes WebGL conformance/uniforms/uniform-default-values.html crash. We need to check for the null view pointer before accessing view-texture. Fixes

Re: [Mesa-dev] [PATCH] st/mesa: fix glCopyTexSubImage crash

2012-08-10 Thread Jose Fonseca
Sounds good to me. Jose - Original Message - Fixes a WebGL crash. The dest texture image is at level 2 and is of size 1x1 texel. The st texture image is a stand-alone resource, not a pointer into a complete mipmap. So the resource has one level and trying to write to level 2 blows

Re: [Mesa-dev] [PATCH] gallivm: fix crash in lp_sampler_static_state()

2012-08-10 Thread Brian Paul
On 08/10/2012 09:38 AM, Jose Fonseca wrote: Is a view with a NULL texture really possible? Probably not, but I'd rather be extra safe. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 53319] [softpipe] sp_texture.c:322:softpipe_get_transfer: Assertion `level = resource-last_level' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53319 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 53314] [llvmpipe] src/gallium/drivers/llvmpipe/lp_texture.c:920:llvmpipe_get_texture_tile_layout: Assertion `x lpr-tiles_per_row[level]' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53314 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 53317] [llvmpipe] SIGSEGV src/gallium/auxiliary/gallivm/lp_bld_sample.c:99

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53317 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] st/mesa: fix renderbuffer validation bug

2012-08-10 Thread Brian Paul
After we attach a new renderbuffer in this function we need to make sure Mesa's update_framebuffer() gets called. Fixes crash in WebGL conformance/textures/texture-attachment-formats.html, but the test still fails for other reasons. Fixes ttps://bugs.freedesktop.org/show_bug.cgi?id=53316 Note:

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #10 from Jason Wood sand...@hotmail.com 2012-08-10 16:01:15 UTC --- Created attachment 65392 -- https://bugs.freedesktop.org/attachment.cgi?id=65392 apitrace I'm not familiar with how to use apitrace, so I can only hope that this

Re: [Mesa-dev] [PATCH] mesa: Fix some -Wnarrowing warnings

2012-08-10 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: Fixes the following warnings: ff_fragment_shader.cpp: In function 'ir_rvalue* emit_texenv(texenv_fragment_program*, GLuint)': ff_fragment_shader.cpp:897:3: warning: narrowing conversion of '(1 ((int)rgb_shift))' from 'int' to 'float'

Re: [Mesa-dev] [PATCH 13/14] i965: Advertise GLSL 1.40 and TexBOs in core contexts

2012-08-10 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 08/08/2012 03:14 PM, Kenneth Graunke wrote: On 08/08/2012 10:38 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/intel/intel_extensions.c | 10

Re: [Mesa-dev] [PATCH 3/3] intel: Fix rendering to a multisample front buffer

2012-08-10 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: We need to downsample before flushing BUFFER_FAKE_FRONT_LEFT to BUFFER_FRONT_LEFT in intel_flush_front. Tested with some frontbuffer apps? The series looks good to me. pgpDP2GpTnnZd.pgp Description: PGP signature

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #11 from Brian Paul brian.e.p...@gmail.com 2012-08-10 16:38:51 UTC --- When I run the test here using the svga driver or llvmpipe I get: conformance/textures/texture-mips.html (26 of 29 passed) failed: getError expected:

[Mesa-dev] [PATCH] mesa: raise GL_INVALID_OPERATION in glGenerateMipmap for missing base image

2012-08-10 Thread Brian Paul
This seems to be expected by the WebGL texture-mips test. The error makes sense, but I haven't found (yet) any OpenGL documentation specifying this error condition. See https://bugs.freedesktop.org/show_bug.cgi?id=44912 Note: This is a candidate for the 8.0 branch. --- src/mesa/main/fbobject.c

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #12 from Brian Paul brian.e.p...@gmail.com 2012-08-10 16:40:20 UTC --- (In reply to comment #10) Created attachment 65392 [details] apitrace I'm not familiar with how to use apitrace, so I can only hope that this is useful to

Re: [Mesa-dev] [PATCH] st/mesa: fix renderbuffer validation bug

2012-08-10 Thread Jose Fonseca
- Original Message - After we attach a new renderbuffer in this function we need to make sure Mesa's update_framebuffer() gets called. Fixes crash in WebGL conformance/textures/texture-attachment-formats.html, but the test still fails for other reasons. Fixes

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #13 from Benoit Jacob bja...@mozilla.com 2012-08-10 16:45:22 UTC --- (In reply to comment #10) Created attachment 65392 [details] apitrace I'm not familiar with how to use apitrace, so I can only hope that this is useful to

Re: [Mesa-dev] [PATCH] mesa: raise GL_INVALID_OPERATION in glGenerateMipmap for missing base image

2012-08-10 Thread Jose Fonseca
Seems alright to me. Jose - Original Message - This seems to be expected by the WebGL texture-mips test. The error makes sense, but I haven't found (yet) any OpenGL documentation specifying this error condition. See https://bugs.freedesktop.org/show_bug.cgi?id=44912 Note:

Re: [Mesa-dev] [PATCH] mesa: Fix some -Wnarrowing warnings

2012-08-10 Thread Chad Versace
diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index f743ce1..aefd412 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b/src/mesa/main/ff_fragment_shader.cpp @@ -890,10 +890,10 @@ emit_texenv(struct texenv_fragment_program *p, GLuint unit)

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
Oh cool! :D I had no idea it did that. Reviewed-by: Kenneth Graunke kenn...@whitecape.org Thanks. It's now pushed, and our builds less complainy :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 3/3] intel: Fix rendering to a multisample front buffer

2012-08-10 Thread Chad Versace
On 08/10/2012 09:33 AM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: We need to downsample before flushing BUFFER_FAKE_FRONT_LEFT to BUFFER_FRONT_LEFT in intel_flush_front. Tested with some frontbuffer apps? Um... I would if I knew of one. Any that you recommend?

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #14 from Pavel Ondračka pavel.ondra...@email.cz 2012-08-10 17:15:37 UTC --- Created attachment 65393 -- https://bugs.freedesktop.org/attachment.cgi?id=65393 new trace (In reply to comment #11) After fixing that, I get two

Re: [Mesa-dev] [PATCH 3/3] intel: Fix rendering to a multisample front buffer

2012-08-10 Thread Brian Paul
On 08/10/2012 11:04 AM, Chad Versace wrote: On 08/10/2012 09:33 AM, Eric Anholt wrote: Chad Versacechad.vers...@linux.intel.com writes: We need to downsample before flushing BUFFER_FAKE_FRONT_LEFT to BUFFER_FRONT_LEFT in intel_flush_front. Tested with some frontbuffer apps? Um... I would

[Mesa-dev] [PATCH 1/2] intel: Move finish_batch() call before MI_BATCH_BUFFER_END and padding.

2012-08-10 Thread Kenneth Graunke
On Gen4+, brw_finish_batch() calls brw_emit_query_end(), which emits some extra PIPE_CONTROLs to capture the current occlusion query data. Unfortunately, it was being called *after* _intel_batchbuffer_flush added the MI_BATCH_BUFFER_END, meaning those PIPE_CONTROLs didn't get inside the batch.

[Mesa-dev] [PATCH 2/2] intel: Reserve enough space to finish occlusion queries on Gen6.

2012-08-10 Thread Kenneth Graunke
After realizing that brw_finish_batch emitted some final PIPE_CONTROLs to record occlusion queries, Chris noted that we probably hadn't reserved enough space to actually emit them. Reserving a full 60 bytes seems a bit harsh, since we only need that much if occlusion queries are actually active.

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 Kenneth Graunke kenn...@whitecape.org changed: What|Removed |Added CC|eug...@dodonov.net | -- Configure

[Mesa-dev] [Bug 53316] [llvmpipe] src/gallium/drivers/llvmpipe/lp_texture.c:601:llvmpipe_get_transfer: Assertion `resource' failed.

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53316 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 Jason Wood sand...@hotmail.com changed: What|Removed |Added Attachment #65392|0 |1 is obsolete|

[Mesa-dev] [PATCH] softpipe: fix softpipe_delete_fs_state() failed assertion

2012-08-10 Thread Brian Paul
The var!=softpipe-fs_variant assertion was failing because we weren't nulling the softpipe-fs_variant pointer when binding a new shader. Since softpipe-fs_variant depends on the current fs, it's of no use when a new FS is bound. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53318 Note: This

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Kenneth Graunke wrote: On 08/10/2012 07:51 AM, Chad Versace wrote: On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning: narrowing conversion of X from 'int' to

Re: [Mesa-dev] [PATCH] softpipe: fix softpipe_delete_fs_state() failed assertion

2012-08-10 Thread Jose Fonseca
Looks good to me. Jose - Original Message - The var!=softpipe-fs_variant assertion was failing because we weren't nulling the softpipe-fs_variant pointer when binding a new shader. Since softpipe-fs_variant depends on the current fs, it's of no use when a new FS is bound. Fixes

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
On 08/10/2012 11:40 AM, Andy Furniss wrote: Kenneth Graunke wrote: On 08/10/2012 07:51 AM, Chad Versace wrote: On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning:

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Chad Versace wrote: Andy, I just reverted the patch. Ok, thanks This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that was on an old LFS AGP

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #16 from Benoit Jacob bja...@mozilla.com 2012-08-10 21:52:09 UTC --- Both Pavel's and Jason's apitraces are correctly recorded, show the GL calls corresponding to the WebGL test. -- Configure bugmail:

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that was on an old LFS AGP box I don't really use apart from booting now and again to see if

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Andy Furniss wrote: Chad Versace wrote: Andy, I just reverted the patch. Ok, thanks This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Chad Versace wrote: This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that was on an old LFS AGP box I don't really use apart from booting now and

Re: [Mesa-dev] [PATCH 2/2] intel: Reserve enough space to finish occlusion queries on Gen6.

2012-08-10 Thread Chris Wilson
On Fri, 10 Aug 2012 10:26:04 -0700, Kenneth Graunke kenn...@whitecape.org wrote: After realizing that brw_finish_batch emitted some final PIPE_CONTROLs to record occlusion queries, Chris noted that we probably hadn't reserved enough space to actually emit them. Reserving a full 60 bytes

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chí-Thanh Christopher Nguyễn
Chad Versace schrieb: This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? Before 2007 I had not even been introduced to Linux, so I'm not in a position to answer

[Mesa-dev] [Bug 53361] New: Commit of Mesa broke Wayland's weston on some graphics cards

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53361 Bug #: 53361 Summary: Commit of Mesa broke Wayland's weston on some graphics cards Classification: Unclassified Product: Mesa Version: unspecified Platform: Other

[Mesa-dev] [Bug 53361] Commit of Mesa broke Wayland's weston on some graphics cards

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53361 Darxus dar...@chaosreigns.com changed: What|Removed |Added CC||dar...@chaosreigns.com

Re: [Mesa-dev] [PATCH 04/14] mesa: Don't advertise extensions that are part of GL 1.4 in a core context

2012-08-10 Thread Ian Romanick
On 08/09/2012 07:52 PM, Marek Olšák wrote: On Fri, Aug 10, 2012 at 3:42 AM, Ian Romanick i...@freedesktop.org wrote: On 08/08/2012 10:53 AM, Brian Paul wrote: On 08/08/2012 11:38 AM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Signed-off-by: Ian

[Mesa-dev] [Bug 53361] Commit of Mesa broke Wayland's weston on some graphics cards

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53361 --- Comment #1 from Darxus dar...@chaosreigns.com 2012-08-11 02:12:50 UTC --- The weston code that's failing is: #ifdef HAVE_CAIRO_EGL d-argb_device = cairo_egl_device_create(d-dpy, d-argb_ctx); if (cairo_device_status(d-argb_device) !=

[Mesa-dev] [Bug 53361] Commit of Mesa broke Wayland's weston on some graphics cards

2012-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53361 Matt Turner matts...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 04/14] mesa: Don't advertise extensions that are part of GL 1.4 in a core context

2012-08-10 Thread Marek Olšák
On Sat, Aug 11, 2012 at 4:11 AM, Ian Romanick i...@freedesktop.org wrote: On 08/09/2012 07:52 PM, Marek Olšák wrote: On Fri, Aug 10, 2012 at 3:42 AM, Ian Romanick i...@freedesktop.org wrote: On 08/08/2012 10:53 AM, Brian Paul wrote: On 08/08/2012 11:38 AM, Ian Romanick wrote: From: Ian