[Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-28 Thread Paul Berry
From: Bryan Cain Before, it accounted for the size of the vertices but not the other fields in the vertex_header struct, which caused memory corruption. --- src/gallium/auxiliary/draw/draw_gs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_

[Mesa-dev] [PATCH 05/34] main: Allow for the possibility of GL 3.2 without ARB_geometry_shader4.

2013-07-28 Thread Paul Berry
Previously, we assumed that the only way Mesa would expose geometry shader support was via the ARB_geometry_shader4 extension. But this extension has some extra complications over GL 3.2 (interactions with compatibility-only features, and link-time initialization of the constant gl_VerticesIn). S

[Mesa-dev] [PATCH 07/34] mesa: account for geometry shader texture fetches in update_texture_state

2013-07-28 Thread Paul Berry
From: Bryan Cain --- src/mesa/main/texstate.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 741985c..0f5d776 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa/main/texstate.c @@ -528,6 +528,7 @

[Mesa-dev] [PATCH 04/34] main: Fix geometry shader error messages (missing right paren)

2013-07-28 Thread Paul Berry
--- src/mesa/main/shaderapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 4cc0357..9c8af87 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -1629,7 +1629,7 @@ _mesa_ProgramParameteri(

[Mesa-dev] [PATCH 03/34] glsl: Enable various extensions for geometry shaders.

2013-07-28 Thread Paul Berry
Allow the following extensions in geometry shaders: - ARB_shader_texture_lod - ARB_shading_language_packing - ARB_texture_cube_map_array - ARB_texture_multisample - ARB_texture_rectangle - ARB_uniform_buffer_object - EXT_texture_array Note: In principle there's no reason geometry shaders couldn't

[Mesa-dev] [PATCH 02/34] glsl: Add EXT_texture_array support for geometry shaders.

2013-07-28 Thread Paul Berry
--- src/glsl/builtins/profiles/EXT_texture_array.geom | 12 1 file changed, 12 insertions(+) create mode 100644 src/glsl/builtins/profiles/EXT_texture_array.geom diff --git a/src/glsl/builtins/profiles/EXT_texture_array.geom b/src/glsl/builtins/profiles/EXT_texture_array.geom new f

[Mesa-dev] [PATCH 01/34] glsl/linker: Make update_array_sizes apply to just uniforms.

2013-07-28 Thread Paul Berry
Commit 586b4b5 (glsl: Also update implicit sizes of varyings at link time) extended update_array_sizes() to apply to both uniforms and shader ins/outs. However, doing creates problems for geometry shaders, because update_array_sizes() assumes that variables with matching names in different parts o

[Mesa-dev] [PATCH 22/34] main: Fix delete_shader_cb() for geometry shaders

2013-07-28 Thread Paul Berry
--- src/mesa/main/shared.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shared.c b/src/mesa/main/shared.c index 5ef8809..2f73cf3 100644 --- a/src/mesa/main/shared.c +++ b/src/mesa/main/shared.c @@ -218,7 +218,8 @@ delete_shader_cb(GLuint id, void *data, void

[Mesa-dev] [PATCH 00/34] Preliminary front-end support for geometry shaders.

2013-07-28 Thread Paul Berry
This patch series implements preliminary front-end support for geometry shaders in Mesa. It is based on work done by myself, Bryan Cain, Eric Anholt, and Fabian Bieler over the last several months. For the patches that aren't mine, I've preserved the original authorship information, and added note

[Mesa-dev] Error building Mesa 32 bit version on Arch Linux

2013-07-28 Thread Sandeep
Hi, When I try to build 32 bit Mesa on Arch Linux, I get the following error: /usr/bin/mkdir -p ../../src/glsl/glcpp /usr/bin/mkdir -p ../../src/glsl/glcpp YACC glcpp/glcpp-parse.c LEX glsl_lexer.cpp YACC glsl_parser.cpp LEX glcpp/glcpp-lex.c make all-recursive make[3]:

Re: [Mesa-dev] Trying MSAAx2 (r300g) on RS690/AMD Radeon X1200 128MB

2013-07-28 Thread Björn Beutel
Hi Marek, for me, MSAAx2, MSAAx4 and MSAAx6 work perfectly on RS690 using r300g (git) when I set "RADEON_DEBUG=nocmask". I've tested the driver on glxgears, SuperTuxKart, Torcs, FooBillard, and some other games. Without "RADEON_DEBUG=nocmask", I see corruptions, as in the attached picture

Re: [Mesa-dev] Trying MSAAx2 (r300g) on RS690/AMD Radeon X1200 128MB

2013-07-28 Thread Bryan Quigley
It works perfectly with nocmask set. I'm up for doing other tests to help get this up and running by default... Thanks again! Bryan On Mon, Jul 22, 2013 at 7:10 AM, Marek Olšák wrote: > Set this environment variable: > > RADEON_DEBUG=nocmask > > and please try again. You can also press 'a' in g

Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
On 07/28/2013 03:32 PM, Chris Forbes wrote: + if (att->Zoffset > texImage->Depth) Shouldn't this be >=, same as in your later array patch? Yes. Good catch. Off-by-one error for the lose. :( -- Chris ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Ian Romanick
On 07/28/2013 03:24 PM, Jordan Justen wrote: On Sun, Jul 28, 2013 at 12:56 PM, Ian Romanick wrote: From: Ian Romanick This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/f

Re: [Mesa-dev] Mesa Library questions

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 06:18 PM, ZhiLi wrote: Hello everyone, I am an university student working on school project related to OpenGL. Now I am using mesa library (version 9.0.3) as an implementation of OpenGL. I have a few questions about Mesa library. glBegin()/glEnd() pair is used for immediate mode r

Re: [Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 04:36 PM, Matt Turner wrote: Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0. --- src/mesa/main/fbobject.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index a29f1ab..bf7e85c 100644 --- a/s

Re: [Mesa-dev] [PATCH 1/4] mesa: Remove stray debug printfs in attachment completeness code

2013-07-28 Thread Kenneth Graunke
On 07/28/2013 12:56 PM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 29c3c50..a55b56c 10064

Re: [Mesa-dev] [PATCH 1/2] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 10:55 PM, Ian Romanick wrote: From: Ian Romanick Allow user-generated names for glBindRenderbufferEXT on desktop GL. Disallow its use altogether for core profiles. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 32 +

Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Chris Forbes
+ if (att->Zoffset > texImage->Depth) Shouldn't this be >=, same as in your later array patch? -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Jordan Justen
On Sun, Jul 28, 2013 at 12:56 PM, Ian Romanick wrote: > From: Ian Romanick > > This fixes the segfault in the '0x0 texture' subtest of piglit's > fbo-incomplete test. > > Signed-off-by: Ian Romanick > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/main/fbobject.c | 22 ++

[Mesa-dev] [PATCH 5/4] mesa: Generate a renderbuffer wrapper even if the texture has no image

2013-07-28 Thread Ian Romanick
From: Ian Romanick This prevents a segfault in check_begin_texture_render when an FBO is rebound while in this state. This fixes the piglit test fbo-incomplete-invalid-texture. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- I accidentally forgot to send this one with the

Re: [Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

2013-07-28 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Fri, Jul 26, 2013 at 4:36 PM, Matt Turner wrote: > Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0. > --- > src/mesa/main/fbobject.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/

[Mesa-dev] [PATCH 4/4] mesa: Validate the layer selection of an array texture too

2013-07-28 Thread Ian Romanick
From: Ian Romanick Previously only the slice of a 3D texture was validated in the FBO completeness check. This fixes the failure in the 'invalid layer of an array texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/m

[Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
From: Ian Romanick This fixes the segfault in the 'invalid slice of 3D texture' and 'invalid layer of an array texture' subtests of piglit's fbo-incomplete test. The 'invalid layer of an array texture' subtest still fails. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Ian Romanick
From: Ian Romanick This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 1/4] mesa: Remove stray debug printfs in attachment completeness code

2013-07-28 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 29c3c50..a55b56c 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/

Re: [Mesa-dev] [PATCH 1/2] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-28 Thread Jordan Justen
On Fri, Jul 26, 2013 at 10:55 PM, Ian Romanick wrote: > From: Ian Romanick > > Allow user-generated names for glBindRenderbufferEXT on desktop GL. > Disallow its use altogether for core profiles. > > Signed-off-by: Ian Romanick > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/main/fbobj

Re: [Mesa-dev] [PATCH 0/5] glsl: Clean up linker error checking.

2013-07-28 Thread Jordan Justen
Reviewed-by: Jordan Justen On Sat, Jul 27, 2013 at 3:59 PM, Paul Berry wrote: > I recently discovered a bug in my geometry shader branch wherein we > were responding to certain kinds of link errors by calling > linker_error(), but the program was still linking successfully. The > root cause tur

Re: [Mesa-dev] Mesa Library questions

2013-07-28 Thread Pierre Moreau
Hello Li Zhi, I have done a quick search, and it seems that glBegin is mapped to vbo_exec_Begin. I'm not using the same version of Mesa as you, but here is how it works for me. In vbo_exec_api.c, function vbo_exec_vtxfmt_init, you get vfmt->Begin = vbo_exec_Begin; And after, in vtxfmt.c,