Re: [Mesa-dev] [PATCH] Mark drmServerInfo.debug_print with printf attribute

2013-12-11 Thread Keith Packard
Alan Coopersmith writes: > You should drop that line - those comments are used for us to figure out which > xproto version to list in the pkg-config requirements when using newer _X_* > macros out of Xfuncproto.h, so doesn't make sense here. > > Also be warned that using a macro name starting wi

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 --- Comment #5 from Tapani Pälli --- IMO not a problem, I've been running my own gles2 engine + some of other gles2 benchmarks and none of them have any functional failures with current Mesa. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] Mark drmServerInfo.debug_print with printf attribute

2013-12-11 Thread Alan Coopersmith
On 12/11/13 01:17 PM, Keith Packard wrote: I stole the conditional for _X_ATTRIBUTE_PRINTF from xproto and changed the name to _DRM_ATTRIBUTE_PRINTF to avoid future conflicts. Signed-off-by: Keith Packard --- xf86drm.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 72619] [llvmpipe] piglit copyteximage 2D regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72619 --- Comment #1 from Roland Scheidegger --- Hmm works for me, with llvm 3.1 Though looking at the intrinsics code I believe the pointer should be i8 type, not i32. Hence should probably allocate i32 var then cast the pointer to i8* type for stmxcs

Re: [Mesa-dev] [PATCH 4/5] glx: Add missing null check in DRI2WireToEvent

2013-12-11 Thread Brian Paul
On 12/11/2013 02:06 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..7e8fdea 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c @@ -102,6 +102,8 @@ DRI2WireTo

Re: [Mesa-dev] [PATCH 5/5] glx: Add missing null check in dri2CreateDrawable

2013-12-11 Thread Brian Paul
On 12/11/2013 02:06 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index bfeebed..e553004 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -39

Re: [Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

2013-12-11 Thread Brian Paul
On 12/11/2013 02:05 AM, Juha-Pekka Heikkila wrote: Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila I'd like to reconsider these changes from scratch. The basic issue is just null-checking of the malloc calls in glPush[Client]Attrib().

[Mesa-dev] [Bug 72624] New: [llvmpipe] piglit arb_color_buffer_float-render GL_RGBA16F regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72624 Priority: medium Bug ID: 72624 Keywords: regression CC: jfons...@vmware.com, srol...@vmware.com, za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Sum

[Mesa-dev] [Bug 72623] New: [llvmpipe] piglit arb_color_buffer_float-drawpixels GL_RGBA16F regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72623 Priority: medium Bug ID: 72623 Keywords: regression CC: jfons...@vmware.com, srol...@vmware.com, za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Sum

[Mesa-dev] [Bug 72622] New: [llvmpipe] piglit getteximage-formats regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72622 Priority: medium Bug ID: 72622 Keywords: regression CC: jfons...@vmware.com, srol...@vmware.com, za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Sum

[Mesa-dev] [Bug 72620] New: [llvmpipe] piglit copyteximage 3D regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72620 Priority: medium Bug ID: 72620 Keywords: regression CC: jfons...@vmware.com, srol...@vmware.com, za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Sum

[Mesa-dev] [Bug 72619] New: [llvmpipe] piglit copyteximage 2D regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72619 Priority: medium Bug ID: 72619 Keywords: regression CC: jfons...@vmware.com, srol...@vmware.com, za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Sum

Re: [Mesa-dev] [PATCH V2 01/10] mesa: Add infrastructure for GL_ARB_clear_buffer_object

2013-12-11 Thread Brian Paul
On 12/11/2013 02:55 PM, Pi Tabred wrote: - add xml file for extension - add reference in gl_API.xml - add pointer to device driver function table - add new functions to list of available functions Or "- update dispatch_sanity.cpp" --- src/mapi/glapi/gen/ARB_clear_buffer_object.xml

Re: [Mesa-dev] [PATCH V2 05/10] mesa: Add bufferobj_range_mapped function

2013-12-11 Thread Brian Paul
On 12/11/2013 02:55 PM, Pi Tabred wrote: Add function to test if the buffer is already mapped and if so, if the mapped range overlaps the given range. Modify the _mesa_InvalidateBufferSubData function to use the new function. Enable buffer_object_subdata_range_good() to use bufferobj_range_mappe

Re: [Mesa-dev] [PATCH V2 07/10] mesa: Implement functions for clear_buffer_object extensions

2013-12-11 Thread Brian Paul
On 12/11/2013 02:55 PM, Pi Tabred wrote: - _mesa_buffer_clear_subdata: default callback for dd function table - _mesa_ClearBufferData: API function - _mesa_ClearBufferSubData: API function - buffer_object_format_good: helper function, check if the internalformat, format and type param

Re: [Mesa-dev] [PATCH] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-11 Thread Brian Paul
On 12/11/2013 12:03 PM, Keith Packard wrote: These are duplicates from gl.h; I'm not sure which file they belong in, but you don't get to have them in both places. Signed-off-by: Keith Packard --- include/GL/glext.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/GL/glext.h b/in

Re: [Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

2013-12-11 Thread Andreas Hartmetz
Here: git://anongit.kde.org/scratch/ahartmetz/mesa.git On Wednesday 11 December 2013 20:23:58 Marek Olšák wrote: > This looks good to me. Can you send me a git link pointing to all your > patches? > > Marek > > On Wed, Dec 11, 2013 at 6:50 AM, Andreas Hartmetz wrote: > > --- > > > > src/gall

Re: [Mesa-dev] [PATCH 23/23] mesa: Handle binding of uniforms to image units with glUniform*().

2013-12-11 Thread Paul Berry
On 11 December 2013 13:59, Paul Berry wrote: > On 26 November 2013 00:08, Francisco Jerez wrote: > >> --- >> src/mesa/main/uniform_query.cpp | 36 >> 1 file changed, 36 insertions(+) >> >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/unifo

Re: [Mesa-dev] [PATCH 23/23] mesa: Handle binding of uniforms to image units with glUniform*().

2013-12-11 Thread Paul Berry
On 26 November 2013 00:08, Francisco Jerez wrote: > --- > src/mesa/main/uniform_query.cpp | 36 > 1 file changed, 36 insertions(+) > > diff --git a/src/mesa/main/uniform_query.cpp > b/src/mesa/main/uniform_query.cpp > index 88ad476..fec45be 100644 > --- a/src

[Mesa-dev] [PATCH V2 04/10] mesa: get_texbuffer_format(): differentiate between core and compat context

2013-12-11 Thread Pi Tabred
alpha, lumincance and intensity formats are illegal in a core context. Add a check to return MESA_FORMAT_NONE if one of those is requested within a core context. --- src/mesa/main/teximage.c | 167 --- 1 file changed, 87 insertions(+), 80 deletions(-) d

Re: [Mesa-dev] [PATCH 20/23] glsl/linker: Count and check image resources.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > --- > src/glsl/link_uniforms.cpp | 13 +++- > src/glsl/linker.cpp| 50 > ++ > 2 files changed, 62 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/li

[Mesa-dev] [PATCH V2 03/10] mesa: Modify format validation to check for extension not context version

2013-12-11 Thread Pi Tabred
--- src/mesa/main/teximage.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 21dcef5..cbe572c 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -4053,15 +4053,10 @@ _mesa_validate_texbuffer

[Mesa-dev] [PATCH V2 08/10] Add ARB_clear_buffer_object to list of supported extensions

2013-12-11 Thread Pi Tabred
--- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 0828c60..6162802 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -82,6 +82,7 @@ static const struct extension extension_table

[Mesa-dev] [PATCH V2 10/10] mesa: Cleanup mesa/main/bufferobj.h (column wrapping and space between lines)

2013-12-11 Thread Pi Tabred
--- src/mesa/main/bufferobj.h | 59 --- 1 file changed, 45 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/bufferobj.h b/src/mesa/main/bufferobj.h index b38519f..71988b0 100644 --- a/src/mesa/main/bufferobj.h +++ b/src/mesa/main/bufferobj.h @@

[Mesa-dev] [PATCH V2 09/10] Modify release notes to include ARB_clear_buffer_object extension

2013-12-11 Thread Pi Tabred
--- docs/relnotes/10.1.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.1.html b/docs/relnotes/10.1.html index dfb0969..778ae6a 100644 --- a/docs/relnotes/10.1.html +++ b/docs/relnotes/10.1.html @@ -45,6 +45,7 @@ Note: some of the new features are only available with cert

[Mesa-dev] [PATCH V2 01/10] mesa: Add infrastructure for GL_ARB_clear_buffer_object

2013-12-11 Thread Pi Tabred
- add xml file for extension - add reference in gl_API.xml - add pointer to device driver function table - add new functions to list of available functions --- src/mapi/glapi/gen/ARB_clear_buffer_object.xml | 50 ++ src/mapi/glapi/gen/gl_API.xml | 6 ++

[Mesa-dev] [PATCH V2 06/10] mesa: Modify get_buffer() to allow for a variable error code

2013-12-11 Thread Pi Tabred
--- src/mesa/main/bufferobj.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 98fd413..0e5b705 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -12

[Mesa-dev] [PATCH V2 05/10] mesa: Add bufferobj_range_mapped function

2013-12-11 Thread Pi Tabred
Add function to test if the buffer is already mapped and if so, if the mapped range overlaps the given range. Modify the _mesa_InvalidateBufferSubData function to use the new function. Enable buffer_object_subdata_range_good() to use bufferobj_range_mapped --- src/mesa/main/bufferobj.c | 87 +

[Mesa-dev] [PATCH V2 07/10] mesa: Implement functions for clear_buffer_object extensions

2013-12-11 Thread Pi Tabred
- _mesa_buffer_clear_subdata: default callback for dd function table - _mesa_ClearBufferData: API function - _mesa_ClearBufferSubData: API function - buffer_object_format_good: helper function, check if the internalformat, format and type parameter are legal - buffer_object_convert_clear: h

[Mesa-dev] [PATCH V2 02/10] mesa: Make validate_texbuffer_format function available externally

2013-12-11 Thread Pi Tabred
- change storage class from static to extern - rename validate_texbuffer_format to _mesa_validate_texbuffer_format --- src/mesa/main/teximage.c | 7 --- src/mesa/main/teximage.h | 4 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/

[Mesa-dev] [PATCH V2 00/10] Newbie Project : Implement ARB_clear_buffer_object

2013-12-11 Thread Pi Tabred
Hello, second version of the patches to implement "ARB_clear_buffer_object" (as suggested by Ian Romanick). I tried to include all hints and hope I have not forgotten any. Best Regards, Pi Tabred Pi Tabred (10): mesa: Add infrastructure for GL_ARB_clear_buffer_object mesa: Make validate_tex

Re: [Mesa-dev] [PATCH 19/23] glsl: Add image built-in function generator.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > Because of the combinatorial explosion of different image built-ins > with different image dimensionalities and base data types, enumerating > all the 242 possibilities would be annoying and a waste of .text > space. Instead use a special path

Re: [Mesa-dev] [PATCH 18/23] glsl: Add built-in constants for ARB_shader_image_load_store.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > --- > src/glsl/builtin_variables.cpp | 19 +++ > src/glsl/glsl_parser_extras.cpp | 8 > src/glsl/glsl_parser_extras.h | 9 + > 3 files changed, 36 insertions(+) > > diff --git a/src/glsl/builtin_variables.c

Re: [Mesa-dev] [PATCH 15/23] glsl/ast: Generalize some sampler variable restrictions to all opaque types.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > No opaque types may be statically initialized in the shader, all > opaque variables must be declared uniform or be part of an "in" > function parameter declaration, no opaque types may be used as the > return type of a function. > --- > src/gls

Re: [Mesa-dev] [PATCH 09/23] glsl/parser: Handle image memory qualifiers.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > --- > src/glsl/glsl_parser.yy | 83 > + > 1 file changed, 83 insertions(+) > > diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy > index e436b16..e207510 100644 > --- a/src/glsl/glsl_

Re: [Mesa-dev] [PATCH 08/23] glsl/parser: Handle the early_fragment_tests input layout qualifier.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > > + > + if (qualifier.flags.q.early_fragment_tests) { > + state->early_fragment_tests = true; > + qualifier.flags.q.early_fragment_tests = 0; > + } > "early_fragment_tests" should only be allowed in fragment shaders.

Re: [Mesa-dev] [PATCH 06/23] glsl/ast: Keep track of type qualifiers defined by ARB_shader_image_load_store.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > --- > src/glsl/ast.h| 32 +++- > src/glsl/ast_type.cpp | 5 + > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/ast.h b/src/glsl/ast.h > index 5c214b6..b750bb7 100644 > --- a/s

Re: [Mesa-dev] [PATCH 05/23] glsl: Add gl_uniform_storage fields to keep track of image uniform indices.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > --- > src/glsl/ir_uniform.h | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/glsl/ir_uniform.h b/src/glsl/ir_uniform.h > index 13faab7..0704061 100644 > --- a/src/glsl/ir_uniform.h > +++ b/src/glsl/ir_uniform.h

Re: [Mesa-dev] [PATCH 04/23] glsl: Add image memory and layout qualifiers to ir_variable.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > > +* ARB_shader_image_load_store qualifiers. > +*/ > + struct { > + bool read_only; > + bool write_only; > It's hard to come up with a good naming convention for read_only and write_only--should they have underscores (like t

Re: [Mesa-dev] [PATCH 2/8] i965: Add SFID #defines for media stuff.

2013-12-11 Thread Kenneth Graunke
On 12/11/2013 01:15 PM, Chris Forbes wrote: > My patches for making the pixel interpolator actually work already > introduce the SFID with a longer name -- is there stuff in > intel_gpu_tools that expects GEN7_SFID_PI? Yes, but that's not a problem...I already have piles of patches to intel-gpu-to

Re: [Mesa-dev] [PATCH 03/23] glsl: Add helper methods to glsl_type for dealing with images.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > Add predicates to query if a GLSL type is or contains an image. > Rename sampler_coordinate_components() to coordinate_components() and > fix it to support calculating the number of coordinate dimensions of > image types as well as sampler types

[Mesa-dev] [PATCH] Mark drmServerInfo.debug_print with printf attribute

2013-12-11 Thread Keith Packard
I stole the conditional for _X_ATTRIBUTE_PRINTF from xproto and changed the name to _DRM_ATTRIBUTE_PRINTF to avoid future conflicts. Signed-off-by: Keith Packard --- xf86drm.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xf86drm.h b/xf86drm.h index 1e763a3..0bf205f

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 --- Comment #4 from Kenneth Graunke --- ES3 is supposed to be backwards compatible with ES2, so silently promoting people from ES2 -> ES3 should be allowed. It's like requesting a GL 2.1 context and getting promoted to a GL 3.0 or 4.3/compatibil

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

2013-12-11 Thread Paul Berry
On 26 November 2013 00:02, Francisco Jerez wrote: > > +enum glsl_image_dim { > + GLSL_IMAGE_DIM_1D, > + GLSL_IMAGE_DIM_2D, > + GLSL_IMAGE_DIM_3D, > + GLSL_IMAGE_DIM_RECT, > + GLSL_IMAGE_DIM_CUBE, > + GLSL_IMAGE_DIM_BUFFER, > + GLSL_IMAGE_DIM_MS > +}; > + > glsl_image_dim seems redu

Re: [Mesa-dev] [PATCH 2/8] i965: Add SFID #defines for media stuff.

2013-12-11 Thread Chris Forbes
My patches for making the pixel interpolator actually work already introduce the SFID with a longer name -- is there stuff in intel_gpu_tools that expects GEN7_SFID_PI? On Wed, Dec 11, 2013 at 8:25 PM, Kenneth Graunke wrote: > While we probably won't ever use these, having them makes it easy to >

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Paul Berry
On 11 December 2013 12:37, Francisco Jerez wrote: > Paul Berry writes: > >[...] > > I'm glad you're dragging this out, Brian. IMHO we have to think > carefully > > about these sorts of issues to keep the quality of Mesa high. > > > > Now that I've spent a day ruminating about this, I've changed

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Francisco Jerez
Paul Berry writes: >[...] > I'm glad you're dragging this out, Brian. IMHO we have to think carefully > about these sorts of issues to keep the quality of Mesa high. > > Now that I've spent a day ruminating about this, I've changed my mind > somewhat. The question at hand is what Mesa should do

Re: [Mesa-dev] [PATCH 4/8] i965: Implement a disassembler for Broadwell's new instruction encoding

2013-12-11 Thread Chris Forbes
Commit messages need updating to match having ported this stuff to C. On Wed, Dec 11, 2013 at 8:25 PM, Kenneth Graunke wrote: > Heavily based on Keith Packard's existing brw_disasm.c code. I've tried > to go through most of the pieces (like SFIDs) and update the lists to > include features added

[Mesa-dev] [Bug 72607] [llvmpipe] piglit glean fragProg1 Z-write test regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72607 José Fonseca changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeonsi: Write htile state to hardware.

2013-12-11 Thread Marek Olšák
This looks good to me. Can you send me a git link pointing to all your patches? Marek On Wed, Dec 11, 2013 at 6:50 AM, Andreas Hartmetz wrote: > --- > src/gallium/drivers/radeonsi/si_state.c | 67 > +--- > src/gallium/drivers/radeonsi/si_state.h | 4 +- > src

[Mesa-dev] [PATCH] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-11 Thread Keith Packard
These are duplicates from gl.h; I'm not sure which file they belong in, but you don't get to have them in both places. Signed-off-by: Keith Packard --- include/GL/glext.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/GL/glext.h b/include/GL/glext.h index fea9e1f..4c0a373 100644 --

[Mesa-dev] [Bug 72607] [llvmpipe] piglit glean fragProg1 Z-write test regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72607 Matthew McClure changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this ma

[Mesa-dev] [Bug 72607] [llvmpipe] piglit glean fragProg1 Z-write test regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72607 --- Comment #1 from Matthew McClure --- A patch is in testing to implement the correct plumbing for ARB_depth_clamp. The fragment depth write was not clamping against the near/far depth range as specified here: How should the setting of the r

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Paul Berry
On 11 December 2013 08:56, Brian Paul wrote: > On 12/10/2013 03:27 PM, Francisco Jerez wrote: > >> Brian Paul writes: >> >> On 12/10/2013 11:06 AM, Francisco Jerez wrote: >>> Paul Berry writes: On 10 December 2013 08:42, Francisco Jerez > wrote: > > Brian Paul wr

[Mesa-dev] [Bug 72607] New: [llvmpipe] piglit glean fragProg1 Z-write test regression

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72607 Priority: medium Bug ID: 72607 Keywords: regression CC: jfons...@vmware.com, mcclu...@vmware.com, srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Brian Paul
On 12/11/2013 11:14 AM, Francisco Jerez wrote: And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. v2: Fix constness of texobj argument, use assert and return reasonable default rather than calling unreachable() in default swit

[Mesa-dev] [PATCH v2] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Francisco Jerez
And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. v2: Fix constness of texobj argument, use assert and return reasonable default rather than calling unreachable() in default switch case. --- src/mesa/main/teximage.c | 87 ++

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Francisco Jerez
Brian Paul writes: > On 12/10/2013 03:27 PM, Francisco Jerez wrote: >> Brian Paul writes: >>[...] >>> I'm more convinced now that we should simply have an assert there rather >>> than unreachable(). >>> >>> Finally, in release builds we generally don't want to crash in these >>> situations. So

[Mesa-dev] PATCHES: R600: Implement work-around for CF stack HW bug

2013-12-11 Thread Tom Stellard
Hi, The attached patches implement a work-around for the CF stack HW bug that is present on some Evergreen and NI GPUs. Please Review. -Tom >From 7653598e8f3b111643348caa0aad5ff0f8859fe6 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 6 Dec 2013 16:19:40 -0800 Subject: [PATCH 1/6] R600:

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Brian Paul
On 12/10/2013 03:27 PM, Francisco Jerez wrote: Brian Paul writes: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry writes: On 10 December 2013 08:42, Francisco Jerez wrote: Brian Paul writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachab

Re: [Mesa-dev] [PATCH 4/5] mesa: Implement functions for clear_buffer_object extensions

2013-12-11 Thread Pi Tabred
On 11.12.2013 16:51, Brian Paul wrote: > On 12/11/2013 05:21 AM, Pi Tabred wrote: >> >> >> On 10.12.2013 17:44, Brian Paul wrote: >>> On 12/10/2013 06:13 AM, Pi Tabred wrote: ... + } + } + + if (!_mesa_is_color_format(format)) { + _mesa_error(ctx, GL_IN

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 --- Comment #3 from org.freedesk...@io7m.com --- Additional: EGL_RENDERABLE_TYPE shall have bit EGL_OPENGL_ES3_BIT_KHR set. It appears that this does happen on Mesa/Intel, but not on Mesa/AMD. -- You are receiving this mail because: You are th

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 --- Comment #2 from org.freedesk...@io7m.com --- Specifically EGL_OPENGL_ES3_BIT_KHR. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

2013-12-11 Thread Brian Paul
On 12/11/2013 04:53 AM, Pi Tabred wrote: On 10.12.2013 18:00, Marek Olšák wrote: On Tue, Dec 10, 2013 at 2:13 PM, Pi Tabred wrote: - add xml file for extension - add reference in gl_API.xml - add pointer to device driver function table - add new functions to list of available functio

Re: [Mesa-dev] [PATCH 4/5] mesa: Implement functions for clear_buffer_object extensions

2013-12-11 Thread Brian Paul
On 12/11/2013 05:21 AM, Pi Tabred wrote: On 10.12.2013 17:44, Brian Paul wrote: On 12/10/2013 06:13 AM, Pi Tabred wrote: ... + } + } + + if (!_mesa_is_color_format(format)) { + _mesa_error(ctx, GL_INVALID_ENUM, + "glClearBufferData(no color format)"); + } Ar

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 --- Comment #1 from org.freedesk...@io7m.com --- To clarify, the actual bug appears to be that the ES3 type bit is not set in the EGL config (so the actual ES3 context doesn't correctly identify itself as such). -- You are receiving this mail be

[Mesa-dev] [Bug 72600] New: ES3 context returned when ES2 is requested

2013-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 Priority: medium Bug ID: 72600 Assignee: mesa-dev@lists.freedesktop.org Summary: ES3 context returned when ES2 is requested Severity: normal Classification: Unclassified OS:

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Daniel Vetter
On Tue, Dec 10, 2013 at 06:31:55PM -0800, Matt Turner wrote: > On Tue, Dec 10, 2013 at 5:55 PM, Francisco Jerez > wrote: > > It just seems annoying and unnecessary to me to have to repeat the same > > pattern before each use of unreachable(). If by definition the > > unreachable macro wants to b

Re: [Mesa-dev] [PATCH 6/9] glsl: implement mid3 built-in function

2013-12-11 Thread Roland Scheidegger
Wouldn't something like max(min(x, max(y,z)), min(y, z)) work as well, saving one instruction? Roland Am 11.12.2013 08:52, schrieb Mario Rugiero: > Why not computing the max3(min(x,y),min(x,z),min(y,z))? > > For the six possible cases: > x < y < z --> max(x, x, y) -> y ==> works > x < z < y -->

Re: [Mesa-dev] [PATCH 4/5] mesa: Implement functions for clear_buffer_object extensions

2013-12-11 Thread Pi Tabred
On 10.12.2013 17:44, Brian Paul wrote: > On 12/10/2013 06:13 AM, Pi Tabred wrote: >> ... >> + } >> + } >> + >> + if (!_mesa_is_color_format(format)) { >> + _mesa_error(ctx, GL_INVALID_ENUM, >> + "glClearBufferData(no color format)"); >> + } > > Are you sure abou

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

2013-12-11 Thread Pi Tabred
On 10.12.2013 18:00, Marek Olšák wrote: > On Tue, Dec 10, 2013 at 2:13 PM, Pi Tabred wrote: >> - add xml file for extension >> - add reference in gl_API.xml >> - add pointer to device driver function table >> - add new functions to list of available functions >> --- >> src/mapi/glapi/gen/AR

Re: [Mesa-dev] Gallium3d Documentation

2013-12-11 Thread Erik Faye-Lund
On Tue, Dec 10, 2013 at 1:41 AM, Christopher Corsi wrote: > Currently it can do rasterize with T&L, > texturing, bit-blits, and handle a subset of functionality needed for OpenGL > (scissor, blend modes, etc.). Shader support is planned. AFAIK, Gallium3D requires support for vertex and fragment s

[Mesa-dev] [PATCH 5/5] glx: Add missing null check in dri2CreateDrawable

2013-12-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index bfeebed..e553004 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -397,6 +397,12 @@ dri2CreateDrawable(struct glx_screen *ba

[Mesa-dev] [PATCH 4/5] glx: Add missing null check in DRI2WireToEvent

2013-12-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..7e8fdea 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c @@ -102,6 +102,8 @@ DRI2WireToEvent(Display *dpy, XEvent *event, xEvent *wire)

[Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

2013-12-11 Thread Juha-Pekka Heikkila
Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 8a2a268..3ecf533 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 3/5] mesa: Verify memory allocations success in _mesa_PushAttrib

2013-12-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 227 +++-- 1 file changed, 144 insertions(+), 83 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 87797d1..e41b981 100644 --- a/src/mesa/main/attrib.c +++ b/

[Mesa-dev] [PATCH 0/5] Klocwork related patches

2013-12-11 Thread Juha-Pekka Heikkila
I made _mesa_PushAttrib a bit nicer with helper function as Topi suggested, it made the entire _mesa_PushAttrib look more clean. _mesa_PushClientAttrib I did not go touching anymore, helper for _mesa_PushAttrib could not be used here and save_attrib_data would need a duplicate function if it was t

[Mesa-dev] [PATCH 2/5] mesa: Verify memory allocations success in _mesa_PushClientAttrib

2013-12-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..87797d1 100644 --- a/src/mesa/main/attrib.c +++ b/s