Re: [Mesa-dev] [PATCH] glsl: Add locking to builtin_builder singleton

2014-02-11 Thread Kenneth Graunke
On 02/07/2014 03:29 AM, Daniel Kurtz wrote: Consider a multithreaded program with two contexts A and B, and the following scenario: 1. Context A calls initialize(), which allocates mem_ctx and starts building built-ins. 2. Context B calls initialize(), which sees mem_ctx != NULL and

Re: [Mesa-dev] Convert vdpau and dri targets to the pipe-loader

2014-02-11 Thread Christian König
Am 11.02.2014 05:26, schrieb Emil Velikov: Hello list, The recent patches from Rob gave me a nice kick to give another stab at integrating the pipe-loader into the vdpau/dri targets. What: - With these patches one library will be created for hardware and one for software driven backends -

[Mesa-dev] [PATCH] gallium/vl: remove remaining softpipe video functions

2014-02-11 Thread Christian König
From: Christian König christian.koe...@amd.com Unused and unmaintained for quite a while. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/vl/vl_winsys.h | 4 +- src/gallium/auxiliary/vl/vl_winsys_xsp.c | 170 --

[Mesa-dev] [Bug 74803] Cogs shadows are broken

2014-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74803 --- Comment #9 from funkydude funkydud...@hotmail.co.uk --- I launched Cogs via Steam and used the following launch option, hopefully that's correct. R600_DEBUG=nohyperz %command% That actually fixed the shadows, they all look normal. -- You

[Mesa-dev] [Bug 74803] [r600g] HyperZ broken on RV630 (Cogs shadows are broken)

2014-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74803 Marek Olšák mar...@gmail.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH 1/3] glx: Add extra null check in __glXClientInfo

2014-02-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..4d8d0c2 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1392,13

[Mesa-dev] [PATCH 3/3] glx: add missing null check in SendMakeCurrentRequest

2014-02-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0..41048f4 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c @@

[Mesa-dev] [PATCH 2/3] glx: add extra null check in getFBConfigs

2014-02-11 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..837c5b0 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -686,7 +686,8 @@ static

[Mesa-dev] [PATCH 0/3] Three simple Klocwork patches to glx

2014-02-11 Thread Juha-Pekka Heikkila
Three simple patches for glx to do some null checking. Juha-Pekka Heikkila (3): glx: Add extra null check in __glXClientInfo glx: add extra null check in getFBConfigs glx: add missing null check in SendMakeCurrentRequest src/glx/glxcmds.c | 13 - src/glx/glxext.c |

Re: [Mesa-dev] [PATCH 3/3] glx: add missing null check in SendMakeCurrentRequest

2014-02-11 Thread Petri Latvala
On 02/11/2014 04:07 PM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0..41048f4 100644 ---

Re: [Mesa-dev] [PATCH 3/3] glx: add missing null check in SendMakeCurrentRequest

2014-02-11 Thread Juha-Pekka Heikkilä
Ah, you're correct. I'll fix that. /Juha-Pekka On Tue, Feb 11, 2014 at 4:18 PM, Petri Latvala petri.latv...@intel.com wrote: On 02/11/2014 04:07 PM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file

[Mesa-dev] [PATCH] XXXsq: create standalone libxatracker library

2014-02-11 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- This is what I had in mind + a last second extra - drops the wrappers - clean up all the linker mayham - include $(top_srcdir)/install-lib-links.mk to handle symlinks for library -Emil src/gallium/state_trackers/xa/Makefile.am | 3

[Mesa-dev] [PATCH 1/6] configure: cleanup switch statement

2014-02-11 Thread Emil Velikov
Move all the cases within one switch statement and handle i9{1,6}5 and r{adeon,200} independently. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 47 --- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] configure: drop explicit DRI_DIRS assignment on some platforms/arches

2014-02-11 Thread Emil Velikov
Both x86_64|amd64 and *bsd, already set the full range of available classic dri drivers. Drop the explicit assignment, and fall back to the generic default. Keep explicit list from plafroms/arches that do not handle the default list. Update help strings, to explicitly mention classic for

[Mesa-dev] [PATCH 4/6] configure: cleanup classic dri drivers handling

2014-02-11 Thread Emil Velikov
* Make sure that only drivers that are handled by configure.ac are included in DRI_DIRS. * Change with_dri_drivers default value to auto, and set enable autodetection, when enable_opengl is on. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 127

[Mesa-dev] [PATCH 3/6] configure: compact ppc/sparc DRI_DIRS handling

2014-02-11 Thread Emil Velikov
Both arches have the same list of dri_dirs. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 6d3e780..3f34555 100644 --- a/configure.ac +++ b/configure.ac @@

[Mesa-dev] [PATCH 5/6] configure: use test -z whenever possible

2014-02-11 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 136d0d1..64e9feb 100644 --- a/configure.ac +++ b/configure.ac @@ -1190,7 +1190,7 @@ dnl dnl EGL Gallium

[Mesa-dev] [PATCH] gallium makefiles: use -export-symbols-regex for building dri drivers

2014-02-11 Thread Maarten Lankhorst
Hide most symbols, except radeon_drm_winsys_create. As a side effect, it ought to fix bug 73200 on radeon. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc index 1e4a34f..b70b940 100644 ---

[Mesa-dev] [PATCH 6/6] configure: use test -n whenever possible

2014-02-11 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 64e9feb..35c3a05 100644 --- a/configure.ac +++ b/configure.ac @@ -1311,7 +1311,7 @@

[Mesa-dev] [PATCHv2 4/6] configure: cleanup classic dri drivers handling

2014-02-11 Thread Emil Velikov
* Make sure that only drivers that are handled by configure.ac are included in DRI_DIRS. * Change with_dri_drivers default value to auto, and set enable autodetection, when enable_opengl is on. v2: Move test to the correct location. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [Mesa-dev] [PATCH] gallium makefiles: use -export-symbols-regex for building dri drivers

2014-02-11 Thread Christian König
Am 11.02.2014 15:55, schrieb Maarten Lankhorst: Hide most symbols, except radeon_drm_winsys_create. As a side effect, it ought to fix bug 73200 on radeon. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com I think Emil Velikov wanted to remove -export-symbols-regex, but I'm

Re: [Mesa-dev] [PATCH] gallium makefiles: use -export-symbols-regex for building dri drivers

2014-02-11 Thread Emil Velikov
On 11/02/14 15:17, Christian König wrote: Am 11.02.2014 15:55, schrieb Maarten Lankhorst: Hide most symbols, except radeon_drm_winsys_create. As a side effect, it ought to fix bug 73200 on radeon. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com I think Emil Velikov wanted

Re: [Mesa-dev] [PATCHv2 4/6] configure: cleanup classic dri drivers handling

2014-02-11 Thread Ilia Mirkin
On Tue, Feb 11, 2014 at 10:14 AM, Emil Velikov emil.l.veli...@gmail.com wrote: * Make sure that only drivers that are handled by configure.ac are included in DRI_DIRS. * Change with_dri_drivers default value to auto, and set enable autodetection, when enable_opengl is on. v2: Move test to

Re: [Mesa-dev] [PATCH] gallium makefiles: use -export-symbols-regex for building dri drivers

2014-02-11 Thread Christian König
Am 11.02.2014 16:24, schrieb Emil Velikov: On 11/02/14 15:17, Christian König wrote: Am 11.02.2014 15:55, schrieb Maarten Lankhorst: Hide most symbols, except radeon_drm_winsys_create. As a side effect, it ought to fix bug 73200 on radeon. Signed-off-by: Maarten Lankhorst

Re: [Mesa-dev] [PATCHv2 4/6] configure: cleanup classic dri drivers handling

2014-02-11 Thread Emil Velikov
On 11/02/14 15:29, Ilia Mirkin wrote: On Tue, Feb 11, 2014 at 10:14 AM, Emil Velikov emil.l.veli...@gmail.com wrote: * Make sure that only drivers that are handled by configure.ac are included in DRI_DIRS. * Change with_dri_drivers default value to auto, and set enable autodetection, when

[Mesa-dev] [PATCH v2] gallium makefiles: use a linker script for building dri drivers

2014-02-11 Thread Maarten Lankhorst
Only export __driDriverExtensions by default, and radeon_drm_winsys_create on radeons. Remove -Bsymbolic which should no longer be needed. As a side effect, it ought to fix a manifestation of bug 73200 on radeon. Signed-off-by: Maarten Lankhorstmaarten.lankho...@canonical.com --- diff --git

Re: [Mesa-dev] [PATCH 2/3] gallium: add texture gather support to gallium (v3)

2014-02-11 Thread Roland Scheidegger
Am 11.02.2014 02:43, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This adds support to gallium for a TG4 instruction, and two CAPs. The first CAP is required for GL_ARB_texture_gather. The second CAP is required to expose GL_ARB_gpu_shader5. However so far we haven't found

Re: [Mesa-dev] [PATCH v2] gallium makefiles: use a linker script for building dri drivers

2014-02-11 Thread Emil Velikov
On 11/02/14 16:28, Maarten Lankhorst wrote: Only export __driDriverExtensions by default, and radeon_drm_winsys_create on radeons. Remove -Bsymbolic which should no longer be needed. As a side effect, it ought to fix a manifestation of bug 73200 on radeon. As long as out of tree builds

Re: [Mesa-dev] [Nouveau] [PATCH] nv30, nvc0: only claim a single viewport

2014-02-11 Thread Emil Velikov
On 11/02/14 05:42, Ilia Mirkin wrote: It should be possible to make this be 16 on nvc0. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Reviewed-by: Emil Velikov emil.l.veli...@gmail.com I have some other patches in the queue and I'll push this shortly -Emil --- Not touching nv50 since

[Mesa-dev] [PATCH] mesa: Preserve the NewArrays state when copying a VAO

2014-02-11 Thread Fredrik Höglund
Cc: 10.1 10.0 mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72895 --- src/mesa/main/attrib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 0045280..5a626f2 100644 --- a/src/mesa/main/attrib.c

[Mesa-dev] [PATCH 1/4] r600/video: disable tilling for now v2

2014-02-11 Thread Christian König
From: Christian König christian.koe...@amd.com v2: cleanup, add some comments Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/drivers/r600/r600_uvd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c

[Mesa-dev] [PATCH 3/4] radeon/vce: initial VCE support v7

2014-02-11 Thread Christian König
From: Christian König christian.koe...@amd.com v2 (chk): revert feedback buffer hack v3 (slava): fixed bitstream size calculation v4 (chk): always create buffers in the right domain v5 (chk): flush async v6 (chk): rework fw interface add version check v7 (leo): implement cropping support

[Mesa-dev] [PATCH 2/4] radeon/winsys: add VCE support v4

2014-02-11 Thread Christian König
From: Christian König christian.koe...@amd.com v2: add fw version query v3: add README.VCE v4: avoid error msg when kernel doesn't support it Signed-off-by: Christian König christian.koe...@amd.com --- docs/README.VCE | 43 +++

[Mesa-dev] [PATCH 4/4] st/omx: initial OpenMAX H264 encoder v6

2014-02-11 Thread Christian König
From: Christian König christian.koe...@amd.com v2 (chk): fix eos handling v3 (leo): implement scaling configuration support v4 (leo): fix bitrate bug v5 (chk): add workaround for bug in Bellagio v6 (chk): fix div by 0 if framerate isn't known, user separate pipe object for scale and

[Mesa-dev] Initial VCE support v2

2014-02-11 Thread Christian König
Hello list, this is the v2 of the initial VCE support. It's based on the OpenMAX state tracker. Beside this list those patches can be found here as well: http://cgit.freedesktop.org/~deathsimple/mesa/log/?h=vce-release Additionally to those patches you also need kernel support and matching

Re: [Mesa-dev] [PATCH 2/2] glx/dri2: Add support for adaptive vsync

2014-02-11 Thread Lauri Kasanen
On Thu, 2 Jan 2014 11:20:13 +0200 Lauri Kasanen c...@gmx.com wrote: On Sun, 15 Dec 2013 12:38:28 +0200 Lauri Kasanen c...@gmx.com wrote: There is a GLX extension for this behavior, glx_swap_control_tear, which mesa doesn't support ATM. But as usual, even after it becomes supported,

Re: [Mesa-dev] [PATCH] meta_blitframebuffer integer format corrections

2014-02-11 Thread Eric Anholt
Kevin Rogovin kevin.rogo...@intel.com writes: Corrects the format for the temp texture used in for the case where source framebuffer is an integer texture when blitframebuffer_texture() cannot be used. Note: Does NOT correct the underling blits, rather only corrects the format of the

Re: [Mesa-dev] [PATCH 4/4] st/omx: initial OpenMAX H264 encoder v6

2014-02-11 Thread Emil Velikov
On 11/02/14 17:27, Christian König wrote: From: Christian König christian.koe...@amd.com v2 (chk): fix eos handling v3 (leo): implement scaling configuration support v4 (leo): fix bitrate bug v5 (chk): add workaround for bug in Bellagio v6 (chk): fix div by 0 if framerate isn't known,

Re: [Mesa-dev] [PATCH] mesa: Preserve the NewArrays state when copying a VAO

2014-02-11 Thread Brian Paul
On 02/11/2014 10:26 AM, Fredrik Höglund wrote: Cc: 10.1 10.0 mesa-sta...@lists.freedesktop.org Bugzilla:

Re: [Mesa-dev] [PATCH 4/4] st/omx: initial OpenMAX H264 encoder v6

2014-02-11 Thread Christian König
Am 11.02.2014 19:56, schrieb Emil Velikov: On 11/02/14 17:27, Christian König wrote: From: Christian König christian.koe...@amd.com v2 (chk): fix eos handling v3 (leo): implement scaling configuration support v4 (leo): fix bitrate bug v5 (chk): add workaround for bug in Bellagio v6 (chk): fix

Re: [Mesa-dev] [PATCH 4/4] st/omx: initial OpenMAX H264 encoder v6

2014-02-11 Thread Emil Velikov
On 11/02/14 19:30, Christian König wrote: Am 11.02.2014 19:56, schrieb Emil Velikov: On 11/02/14 17:27, Christian König wrote: From: Christian König christian.koe...@amd.com v2 (chk): fix eos handling v3 (leo): implement scaling configuration support v4 (leo): fix bitrate bug v5 (chk): add

Re: [Mesa-dev] [PATCH] R600/SI: Split global vector loads with more than 4 elements

2014-02-11 Thread Tom Stellard
On Mon, Feb 10, 2014 at 02:35:03PM -0800, Matt Arsenault wrote: Why would you want to do this for the small types? You should be able to load those in fewer loads and then promote them. We only custom lower v*i32 loads, so this code won't be executed on smaller types. -Tom On 02/10/2014

Re: [Mesa-dev] [PATCH 04/35] meta: Release resources used by decompress_texture_image

2014-02-11 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com decompress_texture_image creates an FBO, an RBO, a VBO, a VAO, and a sampler object, but none of them are ever released. Later patches will add program objects, exacerbating the problem. Leaking piles of

[Mesa-dev] [PATCH 4/10] r600g: remove r600_surface::htile_enabled

2014-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com v2: use one of the htile registers instead --- src/gallium/drivers/r600/evergreen_state.c| 6 ++ src/gallium/drivers/r600/r600_state.c | 6 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 2 -- 3 files changed, 4 insertions(+), 10

Re: [Mesa-dev] [PATCH 2/3] gallium: add texture gather support to gallium (v3)

2014-02-11 Thread Dave Airlie
dst.z = texture_depth(unit, lod) +.. opcode:: TG4 - Texture Gather (as per ARB_texture_gather) + Gathers the four texels to be used in a bi-linear + filtering operation and packs them into a single register. + Only works with 2D, 2D array,

Re: [Mesa-dev] [PATCH 00/22] Exported symbols cleanup and tests

2014-02-11 Thread Emil Velikov
On 08/02/14 16:03, Emil Velikov wrote: Hello list, Continuing with another not so interesting area of mesa - cleaning up the exported symbols and adding make check tests. Note: Most of these patches are rather dull and may cause boredom or sleepiness :-) Before proceeding make sure that

[Mesa-dev] [PATCHv3 4/6] configure: cleanup classic dri drivers handling

2014-02-11 Thread Emil Velikov
* Make sure that only drivers that are handled by configure.ac are included in DRI_DIRS. * Change with_dri_drivers default value to auto, and set enable autodetection, when enable_opengl is on. v2: Move test to the correct location. v3: Squash DRI_DIRS handling before the switch statement.

Re: [Mesa-dev] [PATCH 2/3] gallium: add texture gather support to gallium (v3)

2014-02-11 Thread Roland Scheidegger
Am 11.02.2014 22:58, schrieb Dave Airlie: dst.z = texture_depth(unit, lod) +.. opcode:: TG4 - Texture Gather (as per ARB_texture_gather) + Gathers the four texels to be used in a bi-linear + filtering operation and packs them into a single register. +

[Mesa-dev] [PATCHv3 0/4] enable XA for freedreno

2014-02-11 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org Original patchset: http://lists.freedesktop.org/archives/mesa-dev/2014-February/053632.html v1: original v2: moves xa target into targets/xa, and fixes various issues spotted by Emil v3: few more comments from Emil (drop code in targets/xa, get rid

[Mesa-dev] [PATCHv3 2/4] st/xa: use pipe-loader to get screen

2014-02-11 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org This lets multiple gallium drivers use XA. Signed-off-by: Rob Clark robcl...@freedesktop.org --- configure.ac | 9 +-- src/gallium/auxiliary/pipe-loader/Makefile.am | 1 -

[Mesa-dev] [PATCHv3 1/4] pipe-loader: split out client version

2014-02-11 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org Build two versions of pipe-loader, with only the client version linking in x11 client side dependencies. This will allow the XA state tracker to use pipe-loader. Signed-off-by: Rob Clark robcl...@freedesktop.org --- configure.ac

[Mesa-dev] [PATCHv3 4/4] pipe-loader: add pipe loader for freedreno/msm

2014-02-11 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/targets/pipe-loader/Makefile.am | 17 + src/gallium/targets/pipe-loader/pipe_msm.c | 21 + 2 files changed, 38 insertions(+) create mode 100644

[Mesa-dev] [PATCHv3 3/4] st/xa: missing handle type

2014-02-11 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org DRM_API_HANDLE_TYPE_SHARED is zero, so doesn't actually fix anything. But we shouldn't rely on SHARED handle type being zero. Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/state_trackers/xa/xa_tracker.c | 1 + 1 file changed, 1

[Mesa-dev] Mesa installation - Facing problems..

2014-02-11 Thread Sathishkumar Sivagurunathan
Hi, I am trying to install MESA libraries. I am facing a few issues with the installation. Can someone help me in this.. 1)I am running the following command. ./autogen.sh --prefix=/usr --enable-gles2 --enable-gles1 --disable-gallium-egl --with-dri-drivers=i965,swrast

Re: [Mesa-dev] Mesa installation - Facing problems..

2014-02-11 Thread Matt Turner
On Tue, Feb 11, 2014 at 2:41 AM, Sathishkumar Sivagurunathan sathishkumar.sivagurunat...@igate.com wrote: brw_context.h:1842:24: error: 'drm_intel_bo' has no member named 'offset64' Sounds like the libdrm you're building against is too old.

[Mesa-dev] [PATCH 4/7] meta: Rename the sampler stuff to blit shader.

2014-02-11 Thread Eric Anholt
While these structs are generated per GLSL sampler type, they're structs of data-about-shaders (notably, the ID of a shader program), not data-about-samplers. --- src/mesa/drivers/common/meta.c | 81 +- 1 file changed, 40 insertions(+), 41 deletions(-)

[Mesa-dev] [PATCH 5/7] mesa: Make TexImage error cases about internalFormat more informative.

2014-02-11 Thread Eric Anholt
I tripped over one of these when debugging meta, and it's a lot nicer to just see the internalFormat being complained about. --- src/mesa/main/teximage.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c

[Mesa-dev] meta cleanups

2014-02-11 Thread Eric Anholt
Here are a few easy cleanups of meta (plus the one little mesa core change I had in the previous series) before I get to the meat of the meta MSAA blit work. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/7] meta: Fold the glUseProgram() into the blit program generator.

2014-02-11 Thread Eric Anholt
Everyone was just immediately calling it and doing nothing else with the shader program id. --- src/mesa/drivers/common/meta.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index

[Mesa-dev] [PATCH 6/7] meta: Drop the src == dst restriction on meta glBlitFramebuffer().

2014-02-11 Thread Eric Anholt
From the GL_ARB_fbo spec: If the source and destination buffers are identical, and the source and destination rectangles overlap, the result of the blit operation is undefined. As far as I know, that's the only thing that would have been of concern for this. ---

[Mesa-dev] [PATCH 3/7] meta: Drop a now-trivial helper function.

2014-02-11 Thread Eric Anholt
--- src/mesa/drivers/common/meta.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index f0cd5a0..268f418 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/meta.c @@

[Mesa-dev] [PATCH 7/7] meta: Fold the texture setup into setup_copypix_texture().

2014-02-11 Thread Eric Anholt
There was this funny argument passed to setup for did alloc decide we need to allocate new texture storage?, which goes away if we don't have the caller do alloc as a separate step. --- src/mesa/drivers/common/meta.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-)

[Mesa-dev] [PATCH 1/7] meta: Simplify the blit shader setup steps.

2014-02-11 Thread Eric Anholt
The only thing that wants to track the glsl_sampler structure is the shader string generator. --- src/mesa/drivers/common/meta.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c

Re: [Mesa-dev] meta: single-copy glBlitFramebuffer from renderbuffers, depth.

2014-02-11 Thread Kenneth Graunke
On 02/05/2014 05:20 PM, Eric Anholt wrote: We're looking at the option of using meta to implement glBlitFramebuffer() on gen8, to avoid writing another set of blorp code. I think it's looking pretty promising. Here's a first patch series that gets us to the point of fixing

Re: [Mesa-dev] meta cleanups

2014-02-11 Thread Kenneth Graunke
On 02/11/2014 05:11 PM, Eric Anholt wrote: Here are a few easy cleanups of meta (plus the one little mesa core change I had in the previous series) before I get to the meat of the meta MSAA blit work. Ah I see, this is the start of the respin...great. These 7 are: Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 01/10] radeonsi: move PA_SU_POLY_OFFSET_DB_FMT_CNTL to framebuffer state

2014-02-11 Thread Michel Dänzer
The series is Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 5/7] mesa: Make TexImage error cases about internalFormat more informative.

2014-02-11 Thread Ian Romanick
On 02/11/2014 05:11 PM, Eric Anholt wrote: I tripped over one of these when debugging meta, and it's a lot nicer to just see the internalFormat being complained about. --- src/mesa/main/teximage.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] meta cleanups

2014-02-11 Thread Ian Romanick
On 02/11/2014 05:11 PM, Eric Anholt wrote: Here are a few easy cleanups of meta (plus the one little mesa core change I had in the previous series) before I get to the meat of the meta MSAA blit work. The series, even the one I complained about, is Reviewed-by: Ian Romanick

Re: [Mesa-dev] [PATCH 6/7] meta: Drop the src == dst restriction on meta glBlitFramebuffer().

2014-02-11 Thread Ian Romanick
On 02/11/2014 05:11 PM, Eric Anholt wrote: From the GL_ARB_fbo spec: If the source and destination buffers are identical, and the source and destination rectangles overlap, the result of the blit operation is undefined. As far as I know, that's the only thing that would have

Re: [Mesa-dev] [PATCH 04/25] egl/wl: Call dri2_swap_interval() statically

2014-02-11 Thread Ian Romanick
On 02/09/2014 01:37 PM, Chad Versace wrote: Don't call it through the driver dispatch table. Just call it statically. This prepares for the EGL platform extensions. Since this also modifies platform_x11.c, the commit message should reflect that. Signed-off-by: Chad Versace

Re: [Mesa-dev] [PATCH 02/25] egl/dri2: Move dri2_egl_display virtual funcs to vtbl

2014-02-11 Thread Ian Romanick
On 02/09/2014 01:37 PM, Chad Versace wrote: dri2_egl_display has only one virtual function, 'authenticate'. Define dri2_egl_display::vtbl and move 'authenticate' there. This prepares for the EGL platform extensions, which will add many more virtual functions to dri2_egl_display.

Re: [Mesa-dev] [PATCH 05/25] egl/dri2: Dispatch eglSwapInterval by display, not driver

2014-02-11 Thread Ian Romanick
On 02/09/2014 01:37 PM, Chad Versace wrote: Add dri2_egl_display_vtbl::swap_interval, set it for each platform, and let egl_dri2 dispatch eglSwapInterval to that. This prepares for the EGL platform extensions. Same formatting comment as on patch 2. Signed-off-by: Chad Versace

Re: [Mesa-dev] [PATCH 00/25] egl: Enable Linux platform extensions

2014-02-11 Thread Ian Romanick
With the minor formatting and commit message nits fixed, patches 1 through 15 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com Admittedly, I just skimmed the last few. :) I'll try to get through the rest tomorrow. On 02/09/2014 01:37 PM, Chad Versace wrote: This series enable

Re: [Mesa-dev] [PATCH v2] gallium makefiles: use a linker script for building dri drivers

2014-02-11 Thread Michel Dänzer
On Die, 2014-02-11 at 17:28 +0100, Maarten Lankhorst wrote: Only export __driDriverExtensions by default, and radeon_drm_winsys_create on radeons. Remove -Bsymbolic which should no longer be needed. Is there any particular reason for removing -Bsymbolic though? Whenever it was accidentally

[Mesa-dev] glxinfo and indirect contexts on nvidia driver

2014-02-11 Thread Dave Airlie
Hey, so currently glxinfo with our libGL vs indirect nvidia GL fails to work, The main reason is we get fbconfigs, our libGL picks the best fbconfig as a 32-bit per channel RGBA, but then glXGetVisualFromFBConfig fails on that since I assume it wants 8-bit per channel ones. Now I can fix this

Re: [Mesa-dev] [PATCH v2] gallium makefiles: use a linker script for building dri drivers

2014-02-11 Thread Michel Dänzer
On Mit, 2014-02-12 at 11:50 +0900, Michel Dänzer wrote: On Die, 2014-02-11 at 17:28 +0100, Maarten Lankhorst wrote: Only export __driDriverExtensions by default, and radeon_drm_winsys_create on radeons. Remove -Bsymbolic which should no longer be needed. Is there any particular reason

Re: [Mesa-dev] [PATCH] R600/SI: Add a pattern for i32 anyext

2014-02-11 Thread Michel Dänzer
On Mon, 2014-02-10 at 13:32 -0800, Tom Stellard wrote: From: Tom Stellard thomas.stell...@amd.com Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X

Re: [Mesa-dev] glxinfo and indirect contexts on nvidia driver

2014-02-11 Thread James Jones
Hi Dave, Adding { GLX_DRAWABLEL_TYPE, GLX_WINDOW_BIT } to the attrib list should work, and would technically be more correct since glxinfo is creating a window drawable. 32-bit float FBConfigs won't be able to render to X drawables (at least on our driver), so they don't have associated

[Mesa-dev] [PATCH] targets/vdpau: Always use c++ to link

2014-02-11 Thread Kusanagi Kouichi
If built without llvm, the following error occurs with mplayer: Failed to open VDPAU backend .../libvdpau_r600.so: undefined symbol: _ZTVN10__cxxabiv117__class_type_infoE [vo/vdpau] Error when calling vdp_device_create_x11: 1 Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp ---

Re: [Mesa-dev] [PATCH v2] gallium makefiles: use a linker script for building dri drivers

2014-02-11 Thread Christian König
Am 12.02.2014 03:50, schrieb Michel Dänzer: On Die, 2014-02-11 at 17:28 +0100, Maarten Lankhorst wrote: Only export __driDriverExtensions by default, and radeon_drm_winsys_create on radeons. Remove -Bsymbolic which should no longer be needed. Is there any particular reason for removing

Re: [Mesa-dev] [PATCH 5/7] mesa: Make TexImage error cases about internalFormat more informative.

2014-02-11 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 02/11/2014 05:11 PM, Eric Anholt wrote: I tripped over one of these when debugging meta, and it's a lot nicer to just see the internalFormat being complained about. --- src/mesa/main/teximage.c | 19 --- 1 file changed, 12