When deciding if a clear color is suitable for fast clear,
take into account if a color channel is active in the
buffer format.
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/
https://bugs.freedesktop.org/show_bug.cgi?id=76579
--- Comment #2 from Chris Forbes ---
Patch as promised:
http://lists.freedesktop.org/archives/piglit/2014-March/010089.html
--
You are receiving this mail because:
You are the assignee for the bug.
_
Looks good to me.
z
- Original Message -
> From: Roland Scheidegger
>
> This can get called in some circumstances if both src type and dst type
> have same width (seen with float32->unorm32). While this particular case
> was bogus anyway let's just fix that as it can work trivially (due
https://bugs.freedesktop.org/show_bug.cgi?id=76579
--- Comment #1 from Chris Forbes ---
I believe the glean test is wrong.
The completeness conditions are listed in this order in EXT_framebuffer_object,
ARB_framebuffer_object, and the core spec.
I'm not sure there's much point to keeping glean'
https://bugs.freedesktop.org/show_bug.cgi?id=76579
Priority: medium
Bug ID: 76579
Keywords: regression
CC: bri...@vmware.com, chr...@ijw.co.nz
Assignee: mesa-dev@lists.freedesktop.org
Summary: [swrast] piglit glean fbo regression
From: Roland Scheidegger
This can get called in some circumstances if both src type and dst type
have same width (seen with float32->unorm32). While this particular case
was bogus anyway let's just fix that as it can work trivially (due to the
way it was called it actually worked anyway apart fro
https://bugs.freedesktop.org/show_bug.cgi?id=76577
Dâniel Fraga changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=76577
Dâniel Fraga changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=76489
Dâniel Fraga changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 03/24/2014 04:59 PM, Ian Romanick wrote:
> On 03/22/2014 03:58 PM, Alexander von Gluck IV wrote:
>> * Add HAVE_PTHREAD, we do have pthread support wrappers now for
>> non-native Haiku threaded applications.
>> * Viewport changed behavior recently breaking the build.
>> We fix this by looking
Sent out a V2 of this patch which fixes a bug I noticed recently.
On Thu, Mar 13, 2014 at 3:39 PM, Anuj Phogat wrote:
>
>
>
> On Tue, Mar 11, 2014 at 10:37 AM, Ian Romanick wrote:
>>
>> On 03/10/2014 04:15 PM, Anuj Phogat wrote:
>> >
>> >
>> >
>> > On Mon, Mar 10, 2014 at 3:27 PM, Ian Romanick >
Currently overlapping locations of input variables are not allowed for all
the shader types in OpenGL and OpenGL ES.
>From OpenGL ES 3.0 spec, page 56:
"Binding more than one attribute name to the same location is referred
to as aliasing, and is not permitted in OpenGL ES Shading Language
---
src/gallium/drivers/svga/svga_context.c | 33 ++
src/gallium/drivers/svga/svga_context.h |5
src/gallium/drivers/svga/svga_state_need_swtnl.c | 13 +++--
3 files changed, 49 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/s
Just to be extra safe.
---
src/gallium/drivers/svga/svga_pipe_query.c |1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/svga/svga_pipe_query.c
b/src/gallium/drivers/svga/svga_pipe_query.c
index cdf463c..0283aa9 100644
--- a/src/gallium/drivers/svga/svga_pipe_query.c
+++ b
To help debug failures.
---
src/gallium/drivers/svga/svga_pipe_query.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_pipe_query.c
b/src/gallium/drivers/svga/svga_pipe_query.c
index 61085c4..cdf463c 100644
--- a/src/gallium/drivers/svg
Don't pass null query object pointers into gallium functions.
This avoids segfaulting in the VMware driver (and others?) if the
pipe_context::create_query() call fails and returns NULL.
Cc: "10.0" "10.1"
---
src/mesa/state_tracker/st_cb_queryobj.c | 18 --
1 file changed, 16 in
The kernel I'm working with is rather simple:
const sampler_t s_nearest = CLK_FILTER_NEAREST | CLK_NORMALIZED_COORDS_FALSE |
CLK_ADDRESS_NONE;
__kernel void
image_test (__read_only image2d_t im, __global float4 *out)
{
out[ 0] = read_imagef (im, s_nearest, (int2) (0, 0));
}
Using the Catalys
On 03/22/2014 03:58 PM, Alexander von Gluck IV wrote:
> * Add HAVE_PTHREAD, we do have pthread support wrappers now for
> non-native Haiku threaded applications.
> * Viewport changed behavior recently breaking the build.
> We fix this by looking at the gl_context ViewportArray
> (Thanks Brian
On 03/24/2014 08:07 AM, Brian Paul wrote:
> On 03/24/2014 02:52 AM, Kenneth Graunke wrote:
>> WebGL Aquarium in Chrome 24 actually hits this.
>>
>> v2: Move to core Mesa (wisely suggested by Ian); only consider
>> components which actually exist.
>>
>> v3: Use _mesa_format_has_color_component
On 03/20/2014 11:53 AM, Kenneth Graunke wrote:
> Core profile requires a non-default VAO to be bound. Currently, calls
> to glVertexAttribPointer raise INVALID_OPERATION unless a VAO is bound,
> and we never actually get any vertex data set. Trying to draw without
> any vertex data can only cause
Kenneth Graunke writes:
> When considering color write masks, we often want to know whether an
> RGBA component actually contains any meaningful data. This function
> provides an easy way to answer that question, and handles luminance,
> intensity, and alpha formats correctly.
>
> Signed-off-by:
On Mon, Mar 24, 2014 at 02:35:04PM +, Dorrington, Albert wrote:
> I have been experimenting with adding image support to the clover
> implementation, and have been trying to understand the differences between
> the existing buffer support and what would be required to support images.
>
> Fro
https://bugs.freedesktop.org/show_bug.cgi?id=76489
--- Comment #7 from Dâniel Fraga ---
Created attachment 96313
--> https://bugs.freedesktop.org/attachment.cgi?id=96313&action=edit
Preprocessed source (indirect_init.c)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=76489
--- Comment #6 from Dâniel Fraga ---
(In reply to comment #5)
> gcc -E will help you out. Note that I'm not passionate at looking through
> and comparing the mile long preprocessed sources so I'd leave that pleasure
> to you :)
No problem! ;) I
The series looks great to me.
- Original Message -
> From: José Fonseca
>
> Eliminate lp_vertex_shader, as it added nothing over draw_vertex_shader.
>
> Simplify lp_geometry_shader, as most of the incoming state is unneeded.
> (We could also just use draw_geometry_shader if we were will
Am 24.03.2014 16:31, schrieb jfons...@vmware.com:
> From: José Fonseca
>
> Eliminate lp_vertex_shader, as it added nothing over draw_vertex_shader.
>
> Simplify lp_geometry_shader, as most of the incoming state is unneeded.
> (We could also just use draw_geometry_shader if we were willing to pee
On Thu, Mar 20, 2014 at 12:28 PM, Eric Anholt wrote:
> Matt Turner writes:
>
>> With an awful O(n^2) algorithm that searches previous instructions for
>> dead writes.
>>
>> total instructions in shared programs: 805582 -> 788074 (-2.17%)
>> instructions in affected programs: 144561 -> 127053
Am 23.03.2014 12:36, schrieb Christian König:
> Am 22.03.2014 23:33, schrieb Brian Paul:
>> On Sat, Mar 22, 2014 at 2:49 PM, Christian König
>> mailto:deathsim...@vodafone.de>> wrote:
>>
>> Hi guys,
>>
>> recently some XBMC users complained about crashes with the
>> relatively new NV_vd
Kenneth Graunke writes:
> On 03/21/2014 06:27 PM, Eric Anholt wrote:
>> This gets us equivalent code paths on BDW and pre-BDW, except for stencil
>> (where we don't have MSAA stencil resolve code yet)
>>
>> v2: Move the new meta code to brw_meta_updownsample.c, name it
>> brw_meta_updownsamp
I have been experimenting with adding image support to the clover
implementation, and have been trying to understand the differences between the
existing buffer support and what would be required to support images.
>From what I'm gathering, buffers are laid out in VRAM in a linear format,
>whil
Am 22.03.2014 18:15, schrieb Brian Paul:
> On 03/21/2014 04:01 PM, Anuj Phogat wrote:
>> Cc:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/main/format_unpack.c | 79
>> ++-
>> src/mesa/main/format_unpack.h | 5 +++
>> 2 files changed, 83 insertions(
Am 24.03.2014 17:13, schrieb Brian Paul:
On 03/24/2014 10:04 AM, Christian König wrote:
Am 24.03.2014 16:36, schrieb Brian Paul:
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
With shared glx contexts it is possible that a texture is create and
used
in one context and t
From: Christian König
With shared glx contexts it is possible that a texture is create and used
in one context and then used in another one resulting in incorrect
sampler view usage.
v2: avoid template copy
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
src/mesa/state_tracker/st_atom_tex
From: Christian König
The original problem is fixed by now.
This reverts commit 670be71bd801fea876f7512865ed5f54340da9be.
v2: update patch text and remove stable CC
Signed-off-by: Christian König
---
src/mesa/state_tracker/st_atom_texture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
From: Christian König
Release the references to the sampler views before
destroying the pipe context.
v2: remove TODO and unrelated change
v3: move to st_texture.[ch], rename callback, add comment
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
src/mesa/state_tracker/st_context.c | 16 +++
Am 24.03.2014 16:36, schrieb Brian Paul:
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
The original problem is fixed by now and unconditionally
destroying the sampler view, which is possible still
referenced elsewhere, is a really bad idea also.
This reverts commit 670b
On 03/24/2014 10:04 AM, Christian König wrote:
Am 24.03.2014 16:36, schrieb Brian Paul:
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
With shared glx contexts it is possible that a texture is create and
used
in one context and then used in another one resulting in incor
Am 24.03.2014 16:36, schrieb Brian Paul:
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
With shared glx contexts it is possible that a texture is create and
used
in one context and then used in another one resulting in incorrect
sampler view usage.
v2: avoid template c
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
With shared glx contexts it is possible that a texture is create and used
in one context and then used in another one resulting in incorrect
sampler view usage.
v2: avoid template copy
Signed-off-by: Christian König
Cc: "10
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
Release the references to the sampler views before
destroying the pipe context.
v2: remove TODO and unrelated change
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
src/mesa/state_tracker/st_atom.h | 2 ++
s
On 03/24/2014 09:31 AM, jfons...@vmware.com wrote:
From: José Fonseca
As done in draw_pipe_aaline and draw_pipe_aapoint modules.
---
src/gallium/auxiliary/draw/draw_pipe_pstipple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/draw/draw_pipe_psti
On 03/24/2014 08:06 AM, Christian König wrote:
From: Christian König
The original problem is fixed by now and unconditionally
destroying the sampler view, which is possible still
referenced elsewhere, is a really bad idea also.
This reverts commit 670be71bd801fea876f7512865ed5f54340da9be.
Sig
- Original Message -
> On 03/24/2014 09:31 AM, jfons...@vmware.com wrote:
> > From: José Fonseca
> >
> > As done in draw_pipe_aaline and draw_pipe_aapoint modules.
> > ---
> > src/gallium/auxiliary/draw/draw_pipe_pstipple.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
On 03/24/2014 09:31 AM, jfons...@vmware.com wrote:
From: José Fonseca
Eliminate lp_vertex_shader, as it added nothing over draw_vertex_shader.
Simplify lp_geometry_shader, as most of the incoming state is unneeded.
(We could also just use draw_geometry_shader if we were willing to peek
inside
https://bugs.freedesktop.org/show_bug.cgi?id=69874
Fabio Pedretti changed:
What|Removed |Added
CC||fabio@libero.it
--
You are receivi
From: José Fonseca
As done in draw_pipe_aaline and draw_pipe_aapoint modules.
---
src/gallium/auxiliary/draw/draw_pipe_pstipple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/draw/draw_pipe_pstipple.c
b/src/gallium/auxiliary/draw/draw_pipe_pstipple
From: José Fonseca
Eliminate lp_vertex_shader, as it added nothing over draw_vertex_shader.
Simplify lp_geometry_shader, as most of the incoming state is unneeded.
(We could also just use draw_geometry_shader if we were willing to peek
inside the structure.)
---
src/gallium/drivers/llvmpipe/lp_
On 03/24/2014 02:52 AM, Kenneth Graunke wrote:
WebGL Aquarium in Chrome 24 actually hits this.
v2: Move to core Mesa (wisely suggested by Ian); only consider
components which actually exist.
v3: Use _mesa_format_has_color_component to determine whether components
actually exist, fixin
On 03/24/2014 02:52 AM, Kenneth Graunke wrote:
When considering color write masks, we often want to know whether an
RGBA component actually contains any meaningful data. This function
provides an easy way to answer that question, and handles luminance,
intensity, and alpha formats correctly.
Si
https://bugs.freedesktop.org/show_bug.cgi?id=76530
Brian Paul changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
On 03/23/2014 03:41 AM, Chris Forbes wrote:
The ARB_framebuffer_object spec lists this case before the
FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER and
FRAMEBUFFER_INCOMPLETE_READ_BUFFER cases.
Fixes two broken cases in piglit's fbo-incomplete test, if
ARB_ES2_compatibility is not advertised. (If it is, t
On 03/23/2014 03:07 AM, Chris Forbes wrote:
GL_INTENSITY has never been valid as a pixel format -- to get the memcpy
pack/unpack paths, the app needs to specify GL_RED as the pixel format
(or GL_RED_INTEGER for the integer formats).
Signed-off-by: Chris Forbes
---
src/mesa/main/formats.c | 20
On 03/22/2014 04:58 PM, Alexander von Gluck IV wrote:
* Add HAVE_PTHREAD, we do have pthread support wrappers now for
non-native Haiku threaded applications.
* Viewport changed behavior recently breaking the build.
We fix this by looking at the gl_context ViewportArray
(Thanks Brian for
I think I would need some hints here, I don't know how to test my
changes now properly.
On Sat, Mar 22, 2014 at 8:26 AM, Matt Turner wrote:
> On Fri, Mar 21, 2014 at 11:17 PM, Matt Turner wrote:
>> On Fri, Mar 21, 2014 at 7:33 AM, Juha-Pekka Heikkila
>> wrote:
>>> Our hardware has an "accumulat
On 03/22/2014 01:53 PM, Kai Wasserbäch wrote:
Dear Mesa devs,
I'm not sure whether this is a bug in Mesa, LLVM or in eglibc. The crash happens
in _int_malloc, but since that is certainly one of the more often used
functions, I'm not yet convinced, the fault lies indeed with eglibc.
Therefore I'm
From: Christian König
Release the references to the sampler views before
destroying the pipe context.
v2: remove TODO and unrelated change
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
src/mesa/state_tracker/st_atom.h | 2 ++
src/mesa/state_tracker/st_atom_texture.c | 8 ++
From: Christian König
With shared glx contexts it is possible that a texture is create and used
in one context and then used in another one resulting in incorrect
sampler view usage.
v2: avoid template copy
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
src/mesa/state_tracker/st_atom_tex
From: Christian König
The original problem is fixed by now and unconditionally
destroying the sampler view, which is possible still
referenced elsewhere, is a really bad idea also.
This reverts commit 670be71bd801fea876f7512865ed5f54340da9be.
Signed-off-by: Christian König
Cc: "10.0 10.1"
---
On 03/17/2014 11:05 AM, Jammy Zhou wrote:
Hi Ander,
Some comments inline.
And I have some further thinking about current GBM support, which is
tied to specific implementation closely, although the GBM APIs are quite
independent from mesa. I have some idea below to make GBM a generic
solution. I
On 03/21/2014 05:45 PM, Eric Anholt wrote:
> Sometimes it would be nice to benchmark some app with MSAA versus not, but
> it doesn't offer the controls you want. Just provide a handy knob to
> force the issue.
> ---
> src/mesa/drivers/dri/i965/intel_screen.c | 15 +++
> src/mesa/drive
On 03/21/2014 06:27 PM, Eric Anholt wrote:
> This gets us equivalent code paths on BDW and pre-BDW, except for stencil
> (where we don't have MSAA stencil resolve code yet)
>
> v2: Move the new meta code to brw_meta_updownsample.c, name it
> brw_meta_updownsample(), add a comment about
> i
When considering color write masks, we often want to know whether an
RGBA component actually contains any meaningful data. This function
provides an easy way to answer that question, and handles luminance,
intensity, and alpha formats correctly.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/
WebGL Aquarium in Chrome 24 actually hits this.
v2: Move to core Mesa (wisely suggested by Ian); only consider
components which actually exist.
v3: Use _mesa_format_has_color_component to determine whether components
actually exist, fixing alpha format handling.
Signed-off-by: Kenneth Gr
The SIMD16 replicated FB write message only works if we don't need the
color calculator to mask our framebuffer writes. Previously, we bailed
on it if color_mask wasn't . However, this was
needlessly strict for formats with fewer than four components - only the
components that actually exist matt
64 matches
Mail list logo
