Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Tuesday, December 02, 2014 09:35:05 AM Jason Ekstrand wrote: > On Mon, Dec 1, 2014 at 11:03 PM, Samuel Iglesias Gonsálvez < > > sigles...@igalia.com> wrote: > > On 01/12/14 20:00, Jason Ekstrand wrote: > > > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga > > > > > > wrote: > > >> From: Ja

Re: [Mesa-dev] [PATCH] gallivm: Fix build with LLVM 3.6

2014-12-03 Thread Jose Fonseca
On 03/12/14 04:50, Tom Stellard wrote: As of r223183 EngineBuilder::setMCJITMemoryManager() takes a unique_ptr. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gall

Re: [Mesa-dev] [PATCH v2 08/23] mesa: Fix _mesa_swizzle_and_convert integer conversions to clamp properly

2014-12-03 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/14 09:35, Samuel Iglesias Gonsálvez wrote: > On Tuesday, December 02, 2014 07:54:19 AM Samuel Iglesias Gonsálvez > wrote: >> On Monday, December 01, 2014 10:16:35 AM Jason Ekstrand wrote: >>> This looks much better. Two comments though. Fir

Re: [Mesa-dev] [PATCH v2 00/23] auto-generate pack/unpack functions

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Monday, December 01, 2014 11:22:59 AM Jason Ekstrand wrote: > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga > > wrote: > > This is the first of two series that aim to address: > > https://bugs.freedesktop.org/show_bug.cgi?id=84566 > > > > A branch with this series is available here: > >

[Mesa-dev] [Bug 86690] glmark2-es2-wayland shortly freezes on some frames with egl_dri2 backend (Nouveau/GK20A)

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86690 Alexandre Courbot changed: What|Removed |Added Status|NEW |ASSIGNED Component|EGL/Wayl

Re: [Mesa-dev] [PATCH 06/10] glsl: invariant qualifier is not valid for shader inputs in GLSL ES 3.00

2014-12-03 Thread Samuel Iglesias Gonsálvez
On 02/12/14 21:56, Ian Romanick wrote: > On 12/02/2014 12:54 PM, Ian Romanick wrote: >> On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: >>> From: Samuel Iglesias Gonsalvez >>> >>> GLSL ES 3.00 spec, chapter 4.6.1 "The Invariant Qualifier", >>> >>> Only variables output from a shader can be

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-03 Thread Christian König
Am 02.12.2014 um 21:14 schrieb Jan Vesely: Mostly signed/unsigned comparison Signed-off-by: Jan Vesely Reviewed-by: Christian König Feel free to commit this patch or if you don't have commit access leave me a note and I can commit it. Regards, Christian. --- src/gallium/state_tracker

Re: [Mesa-dev] [PATCH v2 00/23] auto-generate pack/unpack functions

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 10:33:33 AM Samuel Iglesias Gonsálvez wrote: > On Monday, December 01, 2014 11:22:59 AM Jason Ekstrand wrote: > > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga > > > > wrote: > > > This is the first of two series that aim to address: > > > https://bugs.freedes

Re: [Mesa-dev] [PATCH v2 09/29] mesa: Add _mesa_swap2_copy and _mesa_swap4_copy

2014-12-03 Thread Iago Toral
On Mon, 2014-12-01 at 09:18 -0700, Brian Paul wrote: > On 12/01/2014 04:05 AM, Iago Toral Quiroga wrote: > > We have _mesa_swap{2,4} but these do in-place byte-swapping only. The new > > functions receive an extra parameter so we can swap bytes on a source > > input array and store the results in a

Re: [Mesa-dev] [PATCH 07/10] glsl: don't allow invariant qualifiers for interface blocks in GLSL ES

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Tuesday, December 02, 2014 12:57:24 PM Ian Romanick wrote: > On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: > > From: Samuel Iglesias Gonsalvez > > > > From GLSL ES 3.0, chapter 4.3.7 "Interface Blocks", page 38: > > > > "GLSL ES 3.0 does not support interface blocks for shader inputs or >

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #30 from Juha-Pekka Heikkilä --- Created attachment 110402 --> https://bugs.freedesktop.org/attachment.cgi?id=110402&action=edit requested logs Here are the logs. Sorry for the delay, my build system was confused for a while and ne

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Emil Velikov
Hi Iago, On 01/12/14 11:04, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > We were auto-generating it before. The problem was that the autogeneration > tool we were using was called "copy, paste, and edit". Let's use a more > sensible solution. > > Signed-off-by: Jason Ekstrand > > v2

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Emil Velikov
On 03/12/14 11:30, Emil Velikov wrote: > Hi Iago, > > On 01/12/14 11:04, Iago Toral Quiroga wrote: >> From: Jason Ekstrand >> >> We were auto-generating it before. The problem was that the autogeneration >> tool we were using was called "copy, paste, and edit". Let's use a more >> sensible solu

Re: [Mesa-dev] [PATCH v2 5/7] st/mesa: For vertex shaders, don't emit saturate when SM 3.0 is unsupported

2014-12-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Dec 1, 2014 at 2:47 PM, Abdiel Janulgue wrote: > There is a bug in the current lowering pass implementation where we lower > saturate > to clamp only for vertex shaders on drivers supporting SM 3.0. The correct > behavior > is to actually lower to clamp

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 11:34:10 AM Emil Velikov wrote: > On 03/12/14 11:30, Emil Velikov wrote: > > Hi Iago, > > > > On 01/12/14 11:04, Iago Toral Quiroga wrote: > >> From: Jason Ekstrand > >> > >> We were auto-generating it before. The problem was that the > >> autogeneration > >> too

Re: [Mesa-dev] [PATCH v2 15/23] configure: require python mako module

2014-12-03 Thread Emil Velikov
Hi Iago, Shouldn't this patch come before 13 ? Currently we impose the new dependency and a couple of commits later we check/document it. On 01/12/14 11:04, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > It is now a hard dependency because of the autogeneration of > format pack

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 11:30:12 AM Emil Velikov wrote: > Hi Iago, > > On 01/12/14 11:04, Iago Toral Quiroga wrote: > > From: Jason Ekstrand > > > > We were auto-generating it before. The problem was that the > > autogeneration > > tool we were using was called "copy, paste, and edit".

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 11:34:10 AM Emil Velikov wrote: > On 03/12/14 11:30, Emil Velikov wrote: > > Hi Iago, > > > > On 01/12/14 11:04, Iago Toral Quiroga wrote: > >> From: Jason Ekstrand > >> > >> We were auto-generating it before. The problem was that the > >> autogeneration > >> too

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 03:29:46 PM Samuel Iglesias Gonsálvez wrote: > On Wednesday, December 03, 2014 11:34:10 AM Emil Velikov wrote: > > On 03/12/14 11:30, Emil Velikov wrote: > > > Hi Iago, > > > > > > On 01/12/14 11:04, Iago Toral Quiroga wrote: > > >> From: Jason Ekstrand > > >> > >

Re: [Mesa-dev] [PATCH v2 08/23] mesa: Fix _mesa_swizzle_and_convert integer conversions to clamp properly

2014-12-03 Thread Jason Ekstrand
On Dec 3, 2014 12:41 AM, "Samuel Iglesias Gonsálvez" wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > On 02/12/14 09:35, Samuel Iglesias Gonsálvez wrote: > > On Tuesday, December 02, 2014 07:54:19 AM Samuel Iglesias Gonsálvez > > wrote: > >> On Monday, December 01, 2014 10:16:35 AM

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-03 Thread Jan Vesely
On Wed, 2014-12-03 at 11:15 +0100, Christian König wrote: > Am 02.12.2014 um 21:14 schrieb Jan Vesely: > > Mostly signed/unsigned comparison > > > > Signed-off-by: Jan Vesely > > Reviewed-by: Christian König > > Feel free to commit this patch or if you don't have commit access leave > me a not

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-03 Thread Christian König
Am 03.12.2014 um 16:31 schrieb Jan Vesely: On Wed, 2014-12-03 at 11:15 +0100, Christian König wrote: Am 02.12.2014 um 21:14 schrieb Jan Vesely: Mostly signed/unsigned comparison Signed-off-by: Jan Vesely Reviewed-by: Christian König Feel free to commit this patch or if you don't have commi

Re: [Mesa-dev] [Patch v3] Mesa: Add support for GL_OES_texture_*float* extensions.

2014-12-03 Thread kalyan kondapally
>>I think this is a bad idea. Right now OpenGL ES 3.0 support depends on >>ARB_texture_float (see compute_version_es2 in src/mesa/main/version.c). Hmm Missed this :( >>My suggestion: just enable the full set of extensions in the i965 >>driver. K, will revert back to original version. >>If we

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 03:44:19 PM Samuel Iglesias Gonsálvez wrote: > On Wednesday, December 03, 2014 03:29:46 PM Samuel Iglesias Gonsálvez wrote: > > On Wednesday, December 03, 2014 11:34:10 AM Emil Velikov wrote: > > > On 03/12/14 11:30, Emil Velikov wrote: > > > > Hi Iago, > > > > > >

[Mesa-dev] [PATCH 13/13] mesa/main: Verify context creation on progress

2014-12-03 Thread Juha-Pekka Heikkila
Stop context creation if something failed. If something errored during context creation we'd segfault. Now will clean up and return error. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/shared.c | 66 +++--- 1 file changed, 62 insertions(+), 4 de

[Mesa-dev] [PATCH 1/2] mesa: Add a source parameter to _mesa_gl_debug.

2014-12-03 Thread Matt Turner
--- src/mesa/drivers/dri/i915/intel_context.h | 2 ++ src/mesa/drivers/dri/i915/intel_fbo.c | 1 + src/mesa/drivers/dri/i965/intel_debug.h | 2 ++ src/mesa/drivers/dri/i965/intel_fbo.c | 1 + src/mesa/main/errors.c| 3 ++- src/mesa/main/errors.h| 4

[Mesa-dev] [PATCH 2/2] i965: Give compile stats through KHR_debug.

2014-12-03 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 10 ++ src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 10 ++ 2 files changed, 20 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index bbed4cc..4a

[Mesa-dev] [Bug 86980] [swrast] piglit fp-rfl regression

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86980 Bug ID: 86980 Summary: [swrast] piglit fp-rfl regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: bisecte

[Mesa-dev] [Bug 86980] [swrast] piglit fp-rfl regression

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86980 --- Comment #1 from Roland Scheidegger --- Looks like while indeed mesa doesn't support NV_fragment_program, it does however support NV_fragment_program_option, which layers these opcodes on top of ARB_fp. Seems like either both of these commits

[Mesa-dev] [Bug 86980] [swrast] piglit fp-rfl regression

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86980 --- Comment #2 from Ian Romanick --- (In reply to Roland Scheidegger from comment #1) > Looks like while indeed mesa doesn't support NV_fragment_program, it does > however support NV_fragment_program_option, which layers these opcodes on > top of

Re: [Mesa-dev] [PATCH v2 00/23] auto-generate pack/unpack functions

2014-12-03 Thread Jason Ekstrand
On Dec 3, 2014 2:45 AM, "Samuel Iglesias Gonsálvez" wrote: > > On Wednesday, December 03, 2014 10:33:33 AM Samuel Iglesias Gonsálvez wrote: > > On Monday, December 01, 2014 11:22:59 AM Jason Ekstrand wrote: > > > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga > > > > > > wrote: > > > > This i

Re: [Mesa-dev] [PATCH] llvmpipe: decrease MAX_SCENES from 2 to 1

2014-12-03 Thread Jose Fonseca
On 03/12/14 02:59, srol...@vmware.com wrote: From: Roland Scheidegger Multiple scenes per context are meant to be used so a new scene can be built while another one is processed in rasterization. However, quite surprisingly, this does not actually work (and according to git log, possibly never

Re: [Mesa-dev] [PATCH v2 01/23] mesa/format_utils: Fix a bug in unorm_to_float helper function

2014-12-03 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick Should it also be tagged for 10.4? On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > This patch fixes the return of a wrong value when x is lower than > -MAX_INT(src_bits) as the result would not be between [-1.0 1.0]. > > v2

Re: [Mesa-dev] [PATCH v2 02/23] mesa: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM

2014-12-03 Thread Ian Romanick
One question below... On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > Aparently, the packing/unpacking functions for these formats have differed > from the format description in formats.h. Instead of fixing this, people > simply left a comment saying it was broken.

Re: [Mesa-dev] [PATCH v2 03/23] mesa/colormac: Remove an unused macro

2014-12-03 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > The PACK_565_REV macro is no longer used. It was also extremely confusing > because it's actually a byteswapped 565 not reversed 565. > > Signed-off-by: Jason Ekstrand > ---

Re: [Mesa-dev] [PATCH v2 04/23] mesa: Fix A1R5G5B5 packing/unpacking

2014-12-03 Thread Ian Romanick
On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > As with B5G6R5, these have been left broken with comments saying they are. > > Signed-off-by: Jason Ekstrand > --- > src/mesa/main/format_pack.c | 8 +--- > src/mesa/main/format_unpack.c| 11 ---

Re: [Mesa-dev] [PATCH v2 05/23] mesa: Fix get_texbuffer_format().

2014-12-03 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick Should it also be tagged for 10.4? On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > We were returning incorrect mesa formats for GL_LUMINANCE_ALPHA16I_EXT > and GL_LUMINANCE_ALPHA32I_EXT. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH v2 01/23] mesa/format_utils: Fix a bug in unorm_to_float helper function

2014-12-03 Thread Jason Ekstrand
On Wed, Dec 3, 2014 at 2:15 PM, Ian Romanick wrote: > This patch is > > Reviewed-by: Ian Romanick > > Should it also be tagged for 10.4? > Yes, it should. > > On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > > From: Jason Ekstrand > > > > This patch fixes the return of a wrong value when

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-03 Thread Ian Romanick
On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > _BaseFormat is a GLenum (unsigned int) so testing if its value is > greater than 0 to detect the cases where _mesa_base_tex_format > returns -1 doesn't work. > > Fixing the assertion breaks the arb_texture_view-lifetime-format > piglit test on no

Re: [Mesa-dev] [PATCH v2 07/23] mesa/format_utils: Prefix and expose the conversion helper functions

2014-12-03 Thread Ian Romanick
On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > Signed-off-by: Jason Ekstrand > > v2 by Samuel Iglesias : > - Fix compilation errors > > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Ian Romanick > --- > src/mesa/main/format_utils.c | 215 > ++

Re: [Mesa-dev] [PATCH v2 02/23] mesa: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM

2014-12-03 Thread Jason Ekstrand
On Wed, Dec 3, 2014 at 2:20 PM, Ian Romanick wrote: > One question below... > > On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > > From: Jason Ekstrand > > > > Aparently, the packing/unpacking functions for these formats have > differed > > from the format description in formats.h. Instead o

Re: [Mesa-dev] [PATCH v2 09/23] swrast: Remove unused variable.

2014-12-03 Thread Ian Romanick
Reviewed-by: Ian Romanick On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > --- > src/mesa/swrast/s_drawpix.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/mesa/swrast/s_drawpix.c b/src/mesa/swrast/s_drawpix.c > index f7926e4..227faa2 100644 > --- a/src/mesa/swrast/s_drawpix.

[Mesa-dev] r600/sb loop issue

2014-12-03 Thread Dave Airlie
Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of weeks now triggered by a change in how GLSL generates switch statements. I understand you probably aren't too interested in r600g but I believe I'm hitting a design level problem and I would like some advice. So it ap

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Emil Velikov
On 03/12/14 16:14, Samuel Iglesias Gonsálvez wrote: > On Wednesday, December 03, 2014 03:44:19 PM Samuel Iglesias Gonsálvez wrote: >> On Wednesday, December 03, 2014 03:29:46 PM Samuel Iglesias Gonsálvez wrote: >>> On Wednesday, December 03, 2014 11:34:10 AM Emil Velikov wrote: On 03/12/14 11:

Re: [Mesa-dev] [PATCH v2 10/23] mesa: Add a concept of an array format

2014-12-03 Thread Ian Romanick
On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > From: Jason Ekstrand > > An array format is a 32-bit integer format identifier that can represent > any format that can be represented as an array of standard GL datatypes. > While the MESA_FORMAT enums provide several of these, they don't accou

Re: [Mesa-dev] [PATCH v2 6/7] i915: Don't emit saturate for vertex shaders

2014-12-03 Thread Ian Romanick
On 12/01/2014 11:27 AM, Matt Turner wrote: > On Mon, Dec 1, 2014 at 10:50 AM, Matt Turner wrote: >> I think i915's vertex shaders can use saturate. I don't think this is needed. >> >> The code you were modifying (in Gallium) in the original patch doesn't >> affect this driver. > > Actually, i915

Re: [Mesa-dev] [PATCH v2 10/23] mesa: Add a concept of an array format

2014-12-03 Thread Jason Ekstrand
On Wed, Dec 3, 2014 at 2:52 PM, Ian Romanick wrote: > On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > > From: Jason Ekstrand > > > > An array format is a 32-bit integer format identifier that can represent > > any format that can be represented as an array of standard GL datatypes. > > While

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-03 Thread Jason Ekstrand
On Wed, Dec 3, 2014 at 8:14 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > On Wednesday, December 03, 2014 03:44:19 PM Samuel Iglesias Gonsálvez > wrote: > > On Wednesday, December 03, 2014 03:29:46 PM Samuel Iglesias Gonsálvez > wrote: > > > On Wednesday, December 03, 2014 11:34:1

Re: [Mesa-dev] [PATCH v2 1/7] ir_to_mesa: Only lower saturate to clamp when EmitNoSat is set

2014-12-03 Thread Ian Romanick
On 12/01/2014 05:47 AM, Abdiel Janulgue wrote: > Fixes an infinite loop in swrast where the lowering pass unpacks saturate > into clamp Which swrast are we talking about here? Classic swrast? softpipe? llvmpipe? prog_execute.c can handle saturates in vertex shaders, so classic swrast shouldn't

Re: [Mesa-dev] [PATCH v2 2/7] glsl: Don't optimize min/max into saturate when EmitNoSat is set

2014-12-03 Thread Ian Romanick
On 12/01/2014 05:47 AM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index 430f5cb..89fc0de 100644 > --- a/src/glsl/o

Re: [Mesa-dev] [PATCH v2 4/7] dri/radeon: Don't emit saturate for vertex shaders

2014-12-03 Thread Ian Romanick
On 12/01/2014 05:47 AM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/r200/r200_context.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/r200/r200_context.c > b/src/mesa/drivers/dri/r200/r200_context.c > index 931f437..8533

Re: [Mesa-dev] [PATCH] i965: Add var->location != -1 assertions.

2014-12-03 Thread Ian Romanick
Now that my patches that fix the problem have landed, Reviewed-by: Ian Romanick On 12/01/2014 01:44 PM, Kenneth Graunke wrote: > We shouldn't receive variables with invalid locations set - adding these > assertions should help catch problems before they cause crashes later. > > Inspired by simi

[Mesa-dev] [PATCH] i965/skl: Fix GS thread count location

2014-12-03 Thread Ben Widawsky
SKL moves the GS threadcount to dw8 from dw7, and no longer does the divide by 2 thing. Only compile test. Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/gen8_gs_state.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff

Re: [Mesa-dev] [PATCH v2 1/7] ir_to_mesa: Only lower saturate to clamp when EmitNoSat is set

2014-12-03 Thread Emil Velikov
Hi Abdiel, On 01/12/14 13:47, Abdiel Janulgue wrote: > Fixes an infinite loop in swrast where the lowering pass unpacks saturate > into clamp > but the opt_algebraic pass tries to do the opposite. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83463 > Signed-off-by: Abdiel Janulgue >

Re: [Mesa-dev] [PATCH] i965/skl: Fix GS thread count location

2014-12-03 Thread Kenneth Graunke
On Wednesday, December 03, 2014 03:53:29 PM Ben Widawsky wrote: > SKL moves the GS threadcount to dw8 from dw7, and no longer does the divide > by 2 > thing. > > Only compile test. > > Cc: Kristian Høgsberg > Signed-off-by: Ben Widawsky Reviewed-by: Kenneth Graunke signature.asc Description

Re: [Mesa-dev] [PATCH v2 1/7] ir_to_mesa: Only lower saturate to clamp when EmitNoSat is set

2014-12-03 Thread Kenneth Graunke
On Thursday, December 04, 2014 12:04:10 AM Emil Velikov wrote: > Hi Abdiel, > On 01/12/14 13:47, Abdiel Janulgue wrote: > > Fixes an infinite loop in swrast where the lowering pass unpacks saturate > > into clamp > > but the opt_algebraic pass tries to do the opposite. > > > > Bugzilla: https://b

[Mesa-dev] [PATCH] egl/dri2: Log a warning if no platforms are enabled.

2014-12-03 Thread Matt Turner
--- The number of times I've wondered why piglit/gbm wasn't working... src/egl/drivers/dri2/egl_dri2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index d795a2f..2a6811c 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/sr

[Mesa-dev] [PATCH] i965: Make INTEL_DEBUG=state ignore state flags with a count of 1.

2014-12-03 Thread Kenneth Graunke
There are too many state flags to fit in one terminal screen, even with a very tall terminal. Everything is flagged once, so a value of 1 means that it hasn't ever happened again, and thus isn't terribly interesting. Skipping those makes it easier to see the interesting values. Signed-off-by: Ke

Re: [Mesa-dev] [PATCH] i965: Make INTEL_DEBUG=state ignore state flags with a count of 1.

2014-12-03 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 86980] [swrast] piglit fp-rfl regression

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86980 --- Comment #3 from Kenneth Graunke --- I started working on killing NV_fragment_program_option in 2012 - the nukefpopt branch of ~kwg/mesa. IIRC, at the time, VMware cared a lot about SPECviewperf, and I thought that used it. I might be wrong

[Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Kenneth Graunke
BRW_NEW_VERTICES is flagged every time we draw a primitive. Having the brw_vs_prog atom depend on BRW_NEW_VERTICES meant that we had to compute the VS program key and do a program cache lookup for every single primitive. This is painfully expensive. The workaround bit computation is almost entir

Re: [Mesa-dev] [PATCH] i965: Move PSCDEPTH calculations from draw time to compile time.

2014-12-03 Thread Kenneth Graunke
On Tuesday, December 02, 2014 10:34:49 AM Matt Turner wrote: > On Tue, Dec 2, 2014 at 3:50 AM, Kenneth Graunke wrote: > > The "Pixel Shader Computed Depth Mode" value is entirely based on the > > shader program, so we can easily do it at compile time. This avoids the > > if+switch on every 3DSTAT

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
What's the perf impact on a platform which actually needs this? I think there would be some further substantial gains to be had by giving this its own dirty bit -- piles of other atoms listen to BRW_NEW_VERTEX_PROGRAM, but don't care about the workaround bits. On Thu, Dec 4, 2014 at 2:42 PM, Kenn

[Mesa-dev] New stable-branch 10.3 candidate pushed

2014-12-03 Thread Emil Velikov
Hello list, A candidate for the stable 10.3.5 release has been pushed. The current patch queue is as follows: - 11 queued - 10 nominated (outstanding) - and 0 rejected patches In a nut shell this gives us a few fixes for nouveau and freedreno, and a couple of misc ones. Take a look at sectio

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
Half-ignore the first part of that... I thinko'd and assumed Baytrail worked the same as Haswell here, but obviously doesn't. I am interested in how it affects earlier gens, though. On Thu, Dec 4, 2014 at 3:13 PM, Chris Forbes wrote: > What's the perf impact on a platform which actually needs thi

[Mesa-dev] [Bug 84186] X 1.16.1 RC 1 segfaults and reports "XXX fail to create fbo" with Radeon HD 7970.

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84186 --- Comment #7 from p...@cmu.edu --- Created attachment 110440 --> https://bugs.freedesktop.org/attachment.cgi?id=110440&action=edit Another Xorg log with the failure -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 84186] X 1.16.1 RC 1 segfaults and reports "XXX fail to create fbo" with Radeon HD 7970.

2014-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84186 --- Comment #8 from p...@cmu.edu --- Hi there, I just experienced this bug myself on a Radeon 7750, and I've just uploaded my Xorg.0.log. The strange thing was that it surfaced after a reboot. I traced my apt logs, and I hadn't installed/upgrad

[Mesa-dev] [PATCH] Dri2 egl filter away dobule buffer configs for pbuffers and pixmaps

2014-12-03 Thread Jørgen Lind
Make sure that a double buffered only config is returned when eglChooseConfig attrib_list contains surfacetype of EGL_PBUFFER_BIT or EGL_PIXMAP_BIT --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Kenneth Graunke
On Thursday, December 04, 2014 03:13:59 PM Chris Forbes wrote: > What's the perf impact on a platform which actually needs this? > > I think there would be some further substantial gains to be had by > giving this its own dirty bit -- piles of other atoms listen to > BRW_NEW_VERTEX_PROGRAM, but do

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
Either way, Reviewed-by: Chris Forbes On Thu, Dec 4, 2014 at 7:36 PM, Kenneth Graunke wrote: > On Thursday, December 04, 2014 03:13:59 PM Chris Forbes wrote: >> What's the perf impact on a platform which actually needs this? >> >> I think there would be some further substantial gains to be had

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-03 Thread Iago Toral
On Wed, 2014-12-03 at 14:29 -0800, Ian Romanick wrote: > On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: > > _BaseFormat is a GLenum (unsigned int) so testing if its value is > > greater than 0 to detect the cases where _mesa_base_tex_format > > returns -1 doesn't work. > > > > Fixing the assert

Re: [Mesa-dev] [PATCH] egl/dri2: Log a warning if no platforms are enabled.

2014-12-03 Thread Anuj Phogat
On Thu, Dec 4, 2014 at 6:17 AM, Matt Turner wrote: > > --- > The number of times I've wondered why piglit/gbm wasn't working... > > src/egl/drivers/dri2/egl_dri2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c > index d7

Re: [Mesa-dev] [PATCH] egl/dri2: Log a warning if no platforms are enabled.

2014-12-03 Thread Ben Widawsky
On Wed, Dec 03, 2014 at 04:47:18PM -0800, Matt Turner wrote: > --- > The number of times I've wondered why piglit/gbm wasn't working... > > src/egl/drivers/dri2/egl_dri2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c >

Re: [Mesa-dev] [PATCH] egl/dri2: Log a warning if no platforms are enabled.

2014-12-03 Thread Ben Widawsky
On Wed, Dec 03, 2014 at 11:27:55PM -0800, Ben Widawsky wrote: > On Wed, Dec 03, 2014 at 04:47:18PM -0800, Matt Turner wrote: > > --- > > The number of times I've wondered why piglit/gbm wasn't working... > > > > src/egl/drivers/dri2/egl_dri2.c | 1 + > > 1 file changed, 1 insertion(+) > > > > di

Re: [Mesa-dev] [PATCH v2 15/23] configure: require python mako module

2014-12-03 Thread Samuel Iglesias Gonsálvez
On Wednesday, December 03, 2014 11:58:34 AM Emil Velikov wrote: > Hi Iago, > > Shouldn't this patch come before 13 ? Currently we impose the new > dependency and a couple of commits later we check/document it. > Oh right. We will do that change for the next version of the series. > On 01/12/14