Re: [Mesa-dev] [PATCHv4 0/4] Separate device from driver vendor

2015-03-20 Thread Giuseppe Bilotta
Ping, is there anything else that needs to be done for this patchset? On Wed, Mar 11, 2015 at 3:27 PM, Giuseppe Bilotta giuseppe.bilo...@gmail.com wrote: OpenCL (as opposed to OpenGL) has separate vendor strings for the implementation/driver/platform and the device. CL_PLATFORM_VENDOR is akin

[Mesa-dev] [PATCH 11/14] mesa: repack gl_texture_attrib.

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This removes a hole, and puts the large allocation at the end, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 08/14] mesa: reorder gl_program, gl_shader, gl_shader_program

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com gl_program : 1344-1336 gl_shader: 488-472 gl_shader_program: 352-344. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] mesa vs pahole

2015-03-20 Thread Dave Airlie
I started running pahole on stuff today and mesa had a bunch of low hanging fruit all over the types, the main thing all of this does is reduce the mesa context size considerably. before: /* size: 150024, cachelines: 2345, members: 114 */ after: /* size: 146912, cachelines: 2296, members: 114 */

[Mesa-dev] [PATCH 09/14] mesa: reorder gl_image_unit

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com reduces 40-32 but reduces use in context from 7680-6144. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 10/14] mesa: reduce gl_colorbuffer_attrib and gl_fog_attrib

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com These 392-388 and 72-68. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 42075aa..4e1b468 100644 ---

[Mesa-dev] [PATCH 07/14] mesa: reorder gl_transform_feedback_object

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Reduces size from 184 to 176 bytes. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH 06/14] mesa: reorder prog_instruction

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com reduces size from 64 to 56 bytes. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/program/prog_instruction.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/prog_instruction.h

[Mesa-dev] [PATCH 03/14] mesa: reorder gl_texture_unit

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com drops size from 520 - 512 bytes, which then makes gl_texture_attrib go from 99984 to 98440. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 05/14] mesa: reorder gl_array_attrib

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com drops 80 bytes to 72. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 627c144..72db275 100644 ---

[Mesa-dev] [PATCH 13/14] mesa: reorder gl_framebuffer

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this reduces it from 1088 - 1080 bytes Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH 02/14] mesa: reorder gl_point_attrib

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this drops the size from 52 bytes to 48 bytes. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index a428a59..d9f0086

[Mesa-dev] [PATCH 01/14] mesa: reorder gl_multisample_attrib

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com drops size from 28 bytes to 20. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index c43c6ac..a428a59 100644

[Mesa-dev] [PATCH 14/14] mesa: reorder gl_light_attrib

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com reduces from 2664-2656. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index e77c4f0..1b45494 100644 ---

Re: [Mesa-dev] [PATCH] i965/fs: bail on move-to-flag in sel peephole

2015-03-20 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 89687] Mesa implementation error: GLX Error: maximum number of visuals exceeded

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89687 Tapani Pälli lem...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-20 Thread Julien Cristau
On Thu, Mar 12, 2015 at 16:15:56 +0900, Michel Dänzer wrote: On 11.03.2015 05:07, Vivek Dasmohapatra wrote: Hi - As you probably already know, there can only be one version of libstdc++.so in your runtime link chain - This is usually not a problem, but when things are linked against the

Re: [Mesa-dev] [PATCH] i965/fs: Use correct null destination register in cmod tests

2015-03-20 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 12/14] mesa: fix hole in vertex_array_object

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this just removes 4 bytes from this object. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 587507b..68a5d5c

[Mesa-dev] [PATCH 04/14] mesa: reorder gl_client_array

2015-03-20 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com drops from 56 to 48 bytes, drops gl_vertex_array_object from 4584 to 4320 bytes Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [Bug 89689] [Regression] Weston on DRM backend won't start with new version of mesa

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89689 Bug ID: 89689 Summary: [Regression] Weston on DRM backend won't start with new version of mesa Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] mesa vs pahole

2015-03-20 Thread Eero Tamminen
Hi, On 03/20/2015 09:29 AM, Dave Airlie wrote: I started running pahole on stuff today and mesa had a bunch of low hanging fruit all over the types, the main thing all of this does is reduce the mesa context size considerably. before: /* size: 150024, cachelines: 2345, members: 114 */ after:

[Mesa-dev] [Bug 89689] [Regression] Weston on DRM backend won't start with new version of mesa

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89689 Pekka Paalanen ppaala...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 15/23] glsl: Distribute binary operations over ir_triop_csel

2015-03-20 Thread Ian Romanick
On 03/20/2015 03:09 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com If the both result operands of the ir_triop_csel are constants and the other operand of the binary operation is constant,

Re: [Mesa-dev] [PATCH 06/14] mesa: reorder prog_instruction

2015-03-20 Thread Ian Romanick
On 03/20/2015 12:30 AM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com reduces size from 64 to 56 bytes. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/program/prog_instruction.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] Mesa 10.4.7

2015-03-20 Thread Emil Velikov
Mesa 10.4.7 has been released. Mesa 10.4.7 is a bug fix release fixing bugs since the 10.4.6 release, (see below for a list of changes). The tag in the git repository for Mesa 10.4.7 is 'mesa-10.4.7'. Mesa 10.4.7 is available for download at ftp://freedesktop.org/pub/mesa/10.4.7/ SHA-256

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Chris Forbes
I think that having both the existing `struct brw_vs_compile` and a function with the same name is going to cause confusion. (same with the other non-fs stages) On Sat, Mar 21, 2015 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 06:02 PM, Ian Romanick wrote: On 03/20/2015

Re: [Mesa-dev] [PATCH 00/23] Handle Booleans and things better

2015-03-20 Thread Jason Ekstrand
On Fri, Mar 20, 2015 at 4:26 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 03:10 PM, Jason Ekstrand wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: This is a series that I've been working on for quite some time. Some of these patches data from as

Re: [Mesa-dev] [PATCH 17/23] glsl: Distribute ir_unop_neg over ir_binop_mul of a constant

2015-03-20 Thread Matt Turner
On Fri, Mar 20, 2015 at 4:14 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 02:51 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com An expression like -(x * 8) becomes (x * -8). Much of

[Mesa-dev] [PATCH v3 2/9] i965/state: Rename brw_clear_dirty_bits to brw_render_state_finished

2015-03-20 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_state.h| 2 +- src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v3 1/9] i965/state: Rename brw_upload_state to brw_upload_render_state

2015-03-20 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Kristian Høgsberg k...@bitplanet.net --- src/mesa/drivers/dri/i965/brw_draw.c | 7 --- src/mesa/drivers/dri/i965/brw_state.h| 2 +- src/mesa/drivers/dri/i965/brw_state_upload.c | 12 ++-- 3 files

[Mesa-dev] [PATCH v3 8/9] i965/state: Don't use brw-state.dirty.mesa

2015-03-20 Thread Jordan Justen
Now, we only use brw-NewGLState. I used this bash sed command in the i965 directory: for file in *.[ch] *.[ch]pp; do sed -i -e 's/brw-state\.dirty\.mesa/brw-NewGLState/g' $file done Followed by manual changes to brw_state_upload.c. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com

[Mesa-dev] [PATCH v3 6/9] i965/state: Add compute pipeline with empty atom lists

2015-03-20 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Kristian Høgsberg k...@bitplanet.net --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_state.h| 2 ++ src/mesa/drivers/dri/i965/brw_state_upload.c | 34 +++-

[Mesa-dev] [PATCH v3 9/9] i965/state: Remove brw-state.dirty

2015-03-20 Thread Jordan Justen
We now use brw-NewGLState and brw-ctx.NewDriverState instead. Suggested-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_state_upload.c | 6 -- 2 files

[Mesa-dev] [PATCH v3 4/9] i965/state: Create separate dirty state bits for each pipeline

2015-03-20 Thread Jordan Justen
When clearing the state for a pipeline, we will save changed state for the other pipelines. v3: * Adjust brw_upload_pipeline_state * Don't pull pipeline state bits into common state bits * Don't clear pipeline state bits * Adjust 'clear' phase * brw_clear_dirty_bits is now

[Mesa-dev] [PATCH v3 0/9] Support multiple state pipelines for i965

2015-03-20 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-pipelines-v3 v2: * Rename brw-atoms[] to render_atoms * Add brw-compute_atoms[] * Replace brw_pipeline_first_atom with brw_get_pipeline_atoms v3: * Avoid changing pipelines' state bits in upload path * brw_clear_dirty_bits =

[Mesa-dev] [PATCH v3 7/9] i965/state: Don't use brw-state.dirty.brw

2015-03-20 Thread Jordan Justen
Now, we only use ctx-NewDriverState. I used this bash sed command in the i965 directory: for file in *.[ch] *.[ch]pp; do sed -i -e 's/state\.dirty\.brw/ctx.NewDriverState/g' $file done Followed by manual changes to brw_state_upload.c. Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH v3 5/9] i965/state: Only upload render programs for render state uploads

2015-03-20 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_state_upload.c | 45 +++- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c

[Mesa-dev] [PATCH v3 3/9] i965/state: Support multiple pipelines in brw-num_atoms

2015-03-20 Thread Jordan Justen
brw-num_atoms is converted to an array, but currently just an array of length 1. Adds brw_copy_pipeline_atoms which copies the atoms for a pipeline, and sets brw-num_atoms[p] for pipeline p. v2: * Rename brw-atoms[] to render_atoms * Rename brw_add_pipeline_atoms to brw_copy_pipeline_atoms *

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Ian Romanick
On 03/20/2015 06:15 PM, Chris Forbes wrote: I think that having both the existing `struct brw_vs_compile` and a function with the same name is going to cause confusion. (same with the other non-fs stages) That's a good point... and I agree. We should be able to come up with reasonable names

Re: [Mesa-dev] [PATCH v3 5/7] i965: Add a NIR analysis pass for determining when a boolean resolve is needed

2015-03-20 Thread Jason Ekstrand
On Fri, Mar 20, 2015 at 3:41 PM, Matt Turner matts...@gmail.com wrote: On Fri, Mar 20, 2015 at 2:23 PM, Jason Ekstrand ja...@jlekstrand.net wrote: v2: Fix the spelling of analyze and re-arrange code for better readability as per Connor's comments. v3: Make the naming of things more

Re: [Mesa-dev] [PATCH 00/23] Handle Booleans and things better

2015-03-20 Thread Ian Romanick
On 03/20/2015 03:13 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: This is a series that I've been working on for quite some time. Some of these patches data from as long ago as July 2014. It's finally time to just send it out. I have felt

Re: [Mesa-dev] [PATCH 17/23] glsl: Distribute ir_unop_neg over ir_binop_mul of a constant

2015-03-20 Thread Ian Romanick
On 03/20/2015 04:33 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 4:14 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 02:51 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com An expression

Re: [Mesa-dev] [PATCH 17/23] glsl: Distribute ir_unop_neg over ir_binop_mul of a constant

2015-03-20 Thread Ian Romanick
On 03/20/2015 02:51 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com An expression like -(x * 8) becomes (x * -8). Much of the hurt caused by this change appears to be from CSE not being able to see

[Mesa-dev] [Bug 89699] Regression in 10.5.1 causes flickering/artifacting in a particular video game

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89699 --- Comment #1 from andre35...@yahoo.com --- Created attachment 114498 -- https://bugs.freedesktop.org/attachment.cgi?id=114498action=edit Xorg Log Xorg Log after running the game -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 89699] Regression in 10.5.1 causes flickering/artifacting in a particular video game

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89699 Bug ID: 89699 Summary: Regression in 10.5.1 causes flickering/artifacting in a particular video game Product: Mesa Version: 10.5 Hardware: Other OS: Linux

[Mesa-dev] [Bug 89699] Regression in 10.5.1 causes flickering/artifacting in a particular video game

2015-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89699 --- Comment #2 from andre35...@yahoo.com --- Created attachment 114499 -- https://bugs.freedesktop.org/attachment.cgi?id=114499action=edit dmesg output dmesg output after running the game, experiencing the artifacts/flickering/issues listed in

Re: [Mesa-dev] [PATCH 00/23] Handle Booleans and things better

2015-03-20 Thread Jason Ekstrand
On Fri, Mar 20, 2015 at 4:59 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 04:26 PM, Ian Romanick wrote: On 03/20/2015 03:10 PM, Jason Ekstrand wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: There are a couple commits that hurt a fair number of

[Mesa-dev] [RFC: PATCH 4/4] i965: Refactor all upload_stage_prog functions up into brw_upload_programs

2015-03-20 Thread Carl Worth
This completes the refactoring being prepared for in the previous commits. The function bodies of all brw_upadload_stage_prog functions are pulled up into brw_upload_programs where there are unified with loops and switch statements. The purpose of this refactoring is to allow for new code to be

[Mesa-dev] [PATCH 1/4] i965: Split out brw_stage_populate_key into their own functions

2015-03-20 Thread Carl Worth
This commit splits portions of the existing brw_upload_vs_prog and brw_upload_gs_prog function into new brw_vs_populate_key and brw_gs_populate_key functions. This follows the same style as is already present for all other stages, (see brw_wm_populate_key, etc.). This commit is intended to have

[Mesa-dev] [PATCH 2/4] i965: Split out per-stage dirty-bit checking into separate functions

2015-03-20 Thread Carl Worth
The dirty-bit checking from each brw_upload_stage_prog function is split out into its a new brw_stage_state_dirty function. This commit is intended to have no functional change. It exists in preparation for some upcoming code movement in preparation for the shader cache. ---

[Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Carl Worth
The rename here is in preparation for these functions to be exported to other files. This commit is intended to have no functional change. It exists in preparation for some upcoming code movement in preparation for the shader cache. --- src/mesa/drivers/dri/i965/brw_ff_gs.c | 7 ---

Re: [Mesa-dev] [PATCH 00/23] Handle Booleans and things better

2015-03-20 Thread Ian Romanick
On 03/20/2015 03:10 PM, Jason Ekstrand wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: This is a series that I've been working on for quite some time. Some of these patches data from as long ago as July 2014. It's finally time to just send it out. I have

Re: [Mesa-dev] [PATCH 17/23] glsl: Distribute ir_unop_neg over ir_binop_mul of a constant

2015-03-20 Thread Jason Ekstrand
On Fri, Mar 20, 2015 at 4:14 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 02:51 PM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com An expression like -(x * 8) becomes (x * -8). Much of

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Ian Romanick
On 03/20/2015 06:02 PM, Ian Romanick wrote: On 03/20/2015 05:49 PM, Carl Worth wrote: The rename here is in preparation for these functions to be exported to other files. I think I'd wait on this until you're also going to make them non-static. Otherwise it's just extra churn. Which

[Mesa-dev] [PATCH 3/3] radeonsi/compute: Default to the same PIPE_SHADER_CAP values as other shader types

2015-03-20 Thread Tom Stellard
--- src/gallium/drivers/radeonsi/si_pipe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index f1a5388..545c156 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++

[Mesa-dev] [PATCH 1/3] clover: Add a space at the end of CL_DEVICE_OPENCL_C_VERSION

2015-03-20 Thread Tom Stellard
This is required by the spec. --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 5d1f4ab..04f293d 100644 ---

Re: [Mesa-dev] [PATCH 00/23] Handle Booleans and things better

2015-03-20 Thread Ian Romanick
On 03/20/2015 04:26 PM, Ian Romanick wrote: On 03/20/2015 03:10 PM, Jason Ekstrand wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: There are a couple commits that hurt a fair number of shaders with NIR. It doesn't seem like this should be the case, and it seems

[Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set

2015-03-20 Thread Tom Stellard
The storage size for local kernel args can be queried before the arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param of clGetKernelWorkGroupInfo(). The spec says that if local kernel arguments have not been specified, then we should assume their size is 0. ---

Re: [Mesa-dev] [PATCH 2/4] i965: Split out per-stage dirty-bit checking into separate functions

2015-03-20 Thread Ian Romanick
With the tabs converted to spaces, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 03/20/2015 05:49 PM, Carl Worth wrote: The dirty-bit checking from each brw_upload_stage_prog function is split out into its a new brw_stage_state_dirty function. This commit is intended

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Ian Romanick
On 03/20/2015 05:49 PM, Carl Worth wrote: The rename here is in preparation for these functions to be exported to other files. I think I'd wait on this until you're also going to make them non-static. Otherwise it's just extra churn. And tabs. :) One other comment below. This commit is

Re: [Mesa-dev] [PATCH 1/4] i965: Split out brw_stage_populate_key into their own functions

2015-03-20 Thread Ian Romanick
On 03/20/2015 05:49 PM, Carl Worth wrote: This commit splits portions of the existing brw_upload_vs_prog and brw_upload_gs_prog function into new brw_vs_populate_key and brw_gs_populate_key functions. This follows the same style as is already present for all other stages, (see

[Mesa-dev] [PATCH 2/3] clover: Add all the mandatory 1.1 extensions to the extension string

2015-03-20 Thread Tom Stellard
--- src/gallium/state_trackers/clover/api/device.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 04f293d..43e7475 100644 ---

Re: [Mesa-dev] [PATCH 09/23] glsl: Distribute multiply over b2f

2015-03-20 Thread Ian Romanick
On 03/20/2015 01:58 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Convert cases like (x * bool(b)) to 'mix(0, x, b)'. Note: This may hurt the code generated for GPUs that represent Boolean values using floating point. shader-db doesn't play well with i915, so I

[Mesa-dev] [PATCH] r600g/sb: Enable SB for geometry shaders

2015-03-20 Thread Glenn Kennard
Add SV_GEOMETRY_EMIT special variable type to track the implicit dependencies between CUT/EMIT_VERTEX/MEM_RING instructions so GCM/scheduler doesn't reorder them. Mark emit instructions as unkillable so DCE doesn't eat them. Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com --- The hangs with

[Mesa-dev] [PATCH 06/15] scons: Ensure git_sha1.h's directory exists.

2015-03-20 Thread Jose Fonseca
--- src/mesa/SConscript | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index cc5d242..72d9811 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@ -130,7 +130,9 @@ def write_git_sha1_h_file(filename): (commit,

[Mesa-dev] [PATCH 07/15] scons: Tell MSVC STL library to not use exceptions.

2015-03-20 Thread Jose Fonseca
MSVC defaults to no exceptions unless /EH option is passed (which we don't), while MSVC's STL defaults to use exceptions unless _HAS_EXCEPTIONS=0 is defined, which we didn't. This fixes warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc ---

[Mesa-dev] [PATCH 01/15] glsl: Avoid GLboolean vs bool arithmetic MSVC warnings.

2015-03-20 Thread Jose Fonseca
Note that GLboolean is an alias for unsigned char, which lacks the implicit true/false semantics that C++/C99 bool have. Reviewed-by: Brian Paul bri...@vmware.com v2: Change gl_shader::IsES and gl_shader_program::IsES to be bool as recommended by Ian Romanick. --- src/glsl/linker.cpp| 5

[Mesa-dev] [PATCH 04/15] include: Ensure float.h is included for DBL_MAX.

2015-03-20 Thread Jose Fonseca
I didn't actually hit the issue in practice, but just happen to notice while looking at the code. --- include/c99_math.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/c99_math.h b/include/c99_math.h index bd35d1b..5b01d53 100644 --- a/include/c99_math.h +++ b/include/c99_math.h @@

[Mesa-dev] [PATCH 09/15] scons: Prefer winflexbison, and use --wincompat when available.

2015-03-20 Thread Jose Fonseca
This avoids MSVC the warning warning C4013: 'isatty' undefined; assuming extern returning int with certain versions of flex. --- scons/gallium.py | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/scons/gallium.py b/scons/gallium.py

[Mesa-dev] [PATCH 05/15] configure: Bail out with MinGW targets.

2015-03-20 Thread Jose Fonseca
We only support native Windows builds with SCons. Tested with: ./configure --host=i686-w64-mingw32 --- configure.ac | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 8c90b41..daed769 100644 --- a/configure.ac +++

[Mesa-dev] [PATCH 02/15] glsl: Disable MSVC switch warning on a per-file basis.

2015-03-20 Thread Jose Fonseca
This addresses ...\glsl_parser.cpp(...) : warning C4065: switch statement contains 'default' but no 'case' labels This is on code generated by bison, which we have little control. It seems useful to have this warning otherwise enabled. --- src/glsl/glsl_parser.yy | 4 1 file changed, 4

[Mesa-dev] [PATCH 14/15] scons: Silence conversion from 'size_t' to 'type', possible loss of data on MSVC.

2015-03-20 Thread Jose Fonseca
Most cases seem harmless, though that might not always be the case. Maybe one day we can get gcc to complain about these and fix them throughout the code, but until then let's silence them. --- scons/gallium.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scons/gallium.py

[Mesa-dev] [PATCH 12/15] scons: Silence MSVC C4351 warning.

2015-03-20 Thread Jose Fonseca
It warns about change in MSVC behavior -- array initialisation used to be non-standard, but is standard now, assuming I understand correctly http://en.cppreference.com/w/cpp/language/zero_initialization . --- scons/gallium.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scons/gallium.py

[Mesa-dev] [PATCH 08/15] scons: Define YY_USE_CONST on MSVC.

2015-03-20 Thread Jose Fonseca
This prevents the MSVC from warning C4090: 'function' : different 'const' qualifiers when compiling flex generated lexers. --- scons/gallium.py | 8 1 file changed, 8 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 2b11526..9924f1e 100755 --- a/scons/gallium.py

[Mesa-dev] [PATCH 03/15] st/vdpau: Avoid constness cast warnings.

2015-03-20 Thread Jose Fonseca
Fixes MSVC warning C4090: '=' : different 'const' qualifiers --- src/mesa/state_tracker/st_vdpau.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_vdpau.c b/src/mesa/state_tracker/st_vdpau.c index 6ccaf3e..63af119 100644 ---

[Mesa-dev] [PATCH 10/15] scons: Cleanup flex/bison settings specification.

2015-03-20 Thread Jose Fonseca
--- src/glsl/SConscript | 20 src/mesa/SConscript | 2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/glsl/SConscript b/src/glsl/SConscript index 26de455..284b375 100644 --- a/src/glsl/SConscript +++ b/src/glsl/SConscript @@ -24,22 +24,26 @@

[Mesa-dev] [PATCH 13/15] scons: Ensure inttypes.h is always pre-included on MSVC.

2015-03-20 Thread Jose Fonseca
It's a bit hackish couldn't find another solution. See code comment for details. The warning is useful, so universally disabling doesn't sound a good idea. Fixes warning C4005: 'xxx' : macro redefinition --- scons/gallium.py | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH 15/15] gallivm: Silence unused variable warnings on release builds.

2015-03-20 Thread Jose Fonseca
--- src/gallium/auxiliary/gallivm/lp_bld_arit.c| 2 ++ src/gallium/auxiliary/gallivm/lp_bld_bitarit.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index 0d4eaea..3ee1646 100644 ---

Re: [Mesa-dev] [PATCH 09/15] scons: Prefer winflexbison, and use --wincompat when available.

2015-03-20 Thread Brian Paul
On 03/20/2015 07:59 AM, Jose Fonseca wrote: This avoids MSVC the warning warning C4013: 'isatty' undefined; assuming extern returning int with certain versions of flex. --- scons/gallium.py | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-)

Re: [Mesa-dev] [PATCH 14/15] scons: Silence conversion from 'size_t' to 'type', possible loss of data on MSVC.

2015-03-20 Thread Brian Paul
On 03/20/2015 07:59 AM, Jose Fonseca wrote: Most cases seem harmless, though that might not always be the case. Maybe one day we can get gcc to complain about these and fix them throughout the code, but until then let's silence them. --- scons/gallium.py | 1 + 1 file changed, 1 insertion(+)

[Mesa-dev] [PATCH 14/15] i965/vec4: Some more trivial swizzle clean-up.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_ir_vec4.h | 6 +- src/mesa/drivers/dri/i965/brw_reg.h | 6 ++ src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 ++-- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 6 +++---

[Mesa-dev] [PATCH 15/15] i965/vec4: Remove unused method definition.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index fe2bca0..50b9921 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.h +++ b/src/mesa/drivers/dri/i965/brw_vec4.h @@ -257,7

Re: [Mesa-dev] [PATCH 01/14] mesa: reorder gl_multisample_attrib

2015-03-20 Thread Alex Deucher
On Fri, Mar 20, 2015 at 3:29 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com drops size from 28 bytes to 20. Signed-off-by: Dave Airlie airl...@redhat.com For the series: Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- src/mesa/main/mtypes.h | 6

Re: [Mesa-dev] [PATCH 17/17] docs: Update progress on ARB_direct_state_access.

2015-03-20 Thread Martin Peres
On 19/03/15 22:39, Laura Ekstrand wrote: Program pipelines should just say DONE. Query objects should say DONE (will require changes when ...). Well spotted! Need to buy myself a new pair of eyes... When patches 16 and 17 get reviewed, I will push the whole series.

Re: [Mesa-dev] [PATCH 13/16] main: Added entry point for glCreateSamplers

2015-03-20 Thread Martin Peres
On 19/03/15 23:50, Fredrik Höglund wrote: On Monday 16 February 2015, Martin Peres wrote: Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/samplerobj.c | 26 --

[Mesa-dev] [PATCH 11/15] scons: Match some of LLVM warning options.

2015-03-20 Thread Jose Fonseca
--- scons/llvm.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scons/llvm.py b/scons/llvm.py index d145de8..be7df9f 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -132,6 +132,11 @@ def generate(env): # Some of the LLVM C headers use the inline keyword without

[Mesa-dev] [PATCH 5/5] i965/vec4: Trivial copy propagate clean-up.

2015-03-20 Thread Francisco Jerez
Fix typo and punctuation in a comment, break long line and add space before curly bracket. --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp

Re: [Mesa-dev] mesa vs pahole

2015-03-20 Thread Brian Paul
On 03/20/2015 01:29 AM, Dave Airlie wrote: I started running pahole on stuff today and mesa had a bunch of low hanging fruit all over the types, the main thing all of this does is reduce the mesa context size considerably. before: /* size: 150024, cachelines: 2345, members: 114 */ after: /*

[Mesa-dev] [PATCH 2/5] i965/vec4: Don't lose copy propagation saturate bits for not written components.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index 8537fdd..653700e 100644 ---

Re: [Mesa-dev] [PATCH 3/4] gallium: implement get_device_vendor() for existing drivers

2015-03-20 Thread Tom Stellard
On Wed, Mar 11, 2015 at 03:27:18PM +0100, Giuseppe Bilotta wrote: The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com

[Mesa-dev] [PATCH 4/5] i965/vec4: Add argument index and type checks to SEL saturate propagation.

2015-03-20 Thread Francisco Jerez
SEL saturate propagation already implicitly relies on these assumptions. --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp

[Mesa-dev] [PATCH 1/5] Revert i965/vec4: Don't lose the saturate modifier in copy propagation.

2015-03-20 Thread Francisco Jerez
This reverts commit 0dfec59a2785cf7a87ee5128889ecebe810b611b. The change prevented propagation of copies with the saturate flag set, making the whole saturate mask tracking completely useless. A proper fix follows. --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +- 1 file

[Mesa-dev] [PATCH 02/11] i965: Define method to check whether a backend_reg is inside a given range.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 + src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + src/mesa/drivers/dri/i965/brw_shader.h | 1 + 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 07/11] i965/vec4: Don't lose the force_writemask_all flag during CSE.

2015-03-20 Thread Francisco Jerez
And set it in the MOV instructions that copy the temporary to the original destination if the generator instruction had it set. --- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp

[Mesa-dev] [PATCH 01/11] i965/vec4: Remove dependency of vec4_live_variables on the visitor.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp | 11 ++- src/mesa/drivers/dri/i965/brw_vec4_live_variables.h | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp

[Mesa-dev] [PATCH 06/11] i965/vec4: Fix handling of multiple register reads and writes in opt_cse().

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp index 76c3132..596300b 100644 ---

[Mesa-dev] [PATCH 08/11] i965/vec4: Define helper functions to convert a register to a variable index.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 1 + .../dri/i965/brw_vec4_dead_code_eliminate.cpp | 11 ++- .../drivers/dri/i965/brw_vec4_live_variables.cpp | 34 +- .../drivers/dri/i965/brw_vec4_live_variables.h | 16 ++ 4 files changed, 34

[Mesa-dev] [PATCH 05/11] i965/vec4: Fix handling of multiple register reads and writes during copy propagation.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index c4120b4..97dfe2a 100644 ---

[Mesa-dev] [PATCH 10/11] i965/vec4: Calculate live intervals with subregister granularity.

2015-03-20 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_vec4.h | 4 +- .../drivers/dri/i965/brw_vec4_live_variables.cpp | 74 -- .../drivers/dri/i965/brw_vec4_live_variables.h | 11 ++-- 3 files changed, 51 insertions(+), 38 deletions(-) diff --git

  1   2   >