Re: [Mesa-dev] [PATCH 13/18] i965: Pass slice details as parameters for surface setup

2015-04-29 Thread Kenneth Graunke
On Wednesday, April 29, 2015 08:58:18 AM Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 02:45:27PM -0700, Kenneth Graunke wrote: > > On Wednesday, April 22, 2015 11:47:33 PM Topi Pohjolainen wrote: > > > Also changed a couple of direct shifts into SET_FIELD(). > > > > > > Signed-off-by: Topi P

[Mesa-dev] [PATCH 5/9] mesa: add helper convenience functions for computing box intersected against scissors of gl_framebuffer

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Add helper convenience function that intersects the scissor values against a passed bounding box. In addition, to avoid replicated code, make the function _mesa_scissor_bounding_box() use this new function. --- src/mesa/main/framebuffer.c | 63 +++

[Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 172fd3c..cf3b5a2 100644 --- a/docs/GL3.txt +++ b/do

[Mesa-dev] [PATCH 1/9] mesa:Define extension GL_ARB_framebuffer_no_attachments

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer --- src/mesa/main/extensions.c | 1 + src/mesa/main/fbobject.c| 1 + src/mesa/main/framebuffer.c | 1 + src/mesa/main/mtypes.h | 52 +

[Mesa-dev] [PATCH 6/9] i965: Use _mesa_geometry_ functions appropriately

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection of the attachments of the

[Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then the gl_framebuffer has no attachments. --- src/mesa/main/framebuffer.h | 29 +++

[Mesa-dev] [PATCH 3/9] mesa: Complete implementation for GL_ARB_framebuffer_no_attachments in Mesa core

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in GL_ARB_framebuffer_no_attachments --- src/mesa/main/fbobject.c | 154 +++

[Mesa-dev] [PATCH 8/9] i965: enable ARB_framebuffer_no_attachments extension for Gen7 and later

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/sr

[Mesa-dev] [PATCH 2/9] mesa:Define constants and functions for GL_ARB_framebuffer_no_attachment extension

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin Define the enumeration constants, function entry points and glGet for the GL_ARB_framebuffer_no_attachments --- .../glapi/gen/ARB_framebuffer_no_attachments.xml | 33 +++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.x

[Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin If the fragment shader has atomic buffer access, the shader must execute even if the current draw buffer has no attachments. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++ src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 2 files changed, 11 insertions(+) diff

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Jose Fonseca
On 28/04/15 23:16, Brian Paul wrote: If the user requested a GL_RGB texture but the driver actually allocated an RGBA texture, the alpha values in the texture may not be defined. If we later bind the texture as a color target and try to blend into it with GL_DST_ALPHA or GL_ONE_MINUS_DST_ALPHA w

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Marek Olšák
I can't say I like this. Ever since Radeon - Northern Islands, our hardware can do this DST_ALPHA->ONE adjustment automatically, so the new state dependency on _NEW_BUFFERS is unnecessary for us here. Marek On Wed, Apr 29, 2015 at 2:19 AM, Brian Paul wrote: > If the user requested a GL_RGB textu

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Petri Latvala
On 04/29/2015 11:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.t

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Jose Fonseca
I think there are two different things here: one is the driver internally fakes BGRX with BGRA, and obviously it's the pipe driver that needs to fix up alpha channel blending to simulate it's one. The other is the state tracker is faking BGRX with BGRA, and in that case, it's the state tracker

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Marek Olšák
On Wed, Apr 29, 2015 at 12:44 PM, Jose Fonseca wrote: > I think there are two different things here: one is the driver internally > fakes BGRX with BGRA, and obviously it's the pipe driver that needs to fix > up alpha channel blending to simulate it's one. > > The other is the state tracker is fak

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
> At the bottom is another block with GLES 3.1 requirements, which also > contains GL_ARB_f_n_a. At first, I said "Oh futz, I did not mark that one". Then I did some thinking. Before expressing my thoughts I want to emphasize that I really do not know what is the best answer, or potentially ev

Re: [Mesa-dev] [PATCH v2] clover: compile all sources with c++11

2015-04-29 Thread Tom Stellard
I've pushed this patch, thanks! -Tom On Tue, Apr 21, 2015 at 03:49:09PM +0200, EdB wrote: > Later we can remove the compat code > > According to Francisco Jerez, it happen that some time llvm requiring exotic > compilation flags and it would be preferable not to to contaminate the rest of > the

Re: [Mesa-dev] [PATCH 0/4] clover: this serie remove util/compat.*

2015-04-29 Thread Tom Stellard
I've pushed patches 1-3, thanks! -Tom On Fri, Apr 24, 2015 at 12:59:53PM +0200, EdB wrote: > Since clover should compile use -std=c++11, > compat classes are no longer neccessary > > EdB (4): > clover: remove compat class that matche std one > clover: remove compat::string > clover: make m

[Mesa-dev] [Bug 90130] gl_PrimitiveId seems to reset at 340

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90130 --- Comment #19 from Ken Martin --- Tested and it looks good, gl_PrimitiveId is incrementing properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Brian Paul
On 04/29/2015 05:52 AM, Marek Olšák wrote: On Wed, Apr 29, 2015 at 12:44 PM, Jose Fonseca wrote: I think there are two different things here: one is the driver internally fakes BGRX with BGRA, and obviously it's the pipe driver that needs to fix up alpha channel blending to simulate it's one.

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: > On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: > > Currently batch emission logic is bolted into using the current > > gl-state and currently bound user shader programs as input. This > > series refactors the api t

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Ilia Mirkin
On Wed, Apr 29, 2015 at 4:56 AM, wrote: > From: Kevin Rogovin > > Mark GL_ARB_framebuffer_no_attachments as done for i965. > > --- > docs/GL3.txt | 2 +- > docs/relnotes/10.6.0.html | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.tx

Re: [Mesa-dev] [PATCH 4/4] clover: remove util/compat

2015-04-29 Thread Tom Stellard
I've pushed this patch, thanks! -Tom On Wed, Apr 29, 2015 at 08:22:02AM +0200, EdB wrote: > > --- > src/gallium/state_trackers/clover/Makefile.sources | 1 - > src/gallium/state_trackers/clover/api/program.cpp | 14 +- > .../state_trackers/clover/core/compiler.hpp| 4 +- > src/gal

Re: [Mesa-dev] [PATCH 1/2] st/mesa: adjust blending modes if we don't have destination alpha

2015-04-29 Thread Jose Fonseca
On 29/04/15 15:56, Brian Paul wrote: On 04/29/2015 05:52 AM, Marek Olšák wrote: On Wed, Apr 29, 2015 at 12:44 PM, Jose Fonseca wrote: I think there are two different things here: one is the driver internally fakes BGRX with BGRA, and obviously it's the pipe driver that needs to fix up alpha ch

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: >> > Currently batch emission logic is bolted into using the current >> > gl-state and currently bound user shader programs as input.

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Pohjolainen, Topi
On Wed, Apr 29, 2015 at 06:54:34PM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: > >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: > >> > Currently batch emission logic is bolted into using th

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Wed, Apr 29, 2015 at 06:54:34PM +0300, Francisco Jerez wrote: >> "Pohjolainen, Topi" writes: >> >> > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: >> >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: >> >> > Currently batch e

Re: [Mesa-dev] [PATCH 03/18] winsys/amdgpu: add a new winsys for the new kernel driver

2015-04-29 Thread Emil Velikov
On 28/04/15 14:28, Marek Olšák wrote: > Hi Emil, > > I think I have fixed everything that you suggested. You can review the > branch here: > > http://cgit.freedesktop.org/~mareko/mesa/log/?h=amdgpu > Looks great. You've even added the new symbol (which I forgot to mention) so that vdpau-gl inter

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90213 --- Comment #1 from Mark Janes --- This test asserted from the time it was written. The test failure does not necessarily indicate a regression. The test was introduced in piglit 2e7be059b1dc71eef0c09964ea393678618d898b, and references the "for

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

2015-04-29 Thread Pohjolainen, Topi
On Thu, Apr 23, 2015 at 09:58:22PM +0300, Pohjolainen, Topi wrote: > On Thu, Apr 23, 2015 at 11:53:49AM -0700, Matt Turner wrote: > > On Wed, Apr 22, 2015 at 1:47 PM, Topi Pohjolainen > > wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/brw_state.h | 12

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #18 from Mark Janes --- The fix for this bug triggered a piglit failure: spec.!opengl 3_2.get-active-attrib-returns-all-inputs /tmp/build_root/m32/lib/piglit/bin/gl-get-active-attrib-returns-all-inputs -auto -fbo piglit_vertex was n

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #19 from Tapani Pälli --- (In reply to Mark Janes from comment #18) > The fix for this bug triggered a piglit failure: > > spec.!opengl 3_2.get-active-attrib-returns-all-inputs > > /tmp/build_root/m32/lib/piglit/bin/gl-get-active-at

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

2015-04-29 Thread Kenneth Graunke
On Wednesday, April 29, 2015 07:47:26 PM Pohjolainen, Topi wrote: > On Thu, Apr 23, 2015 at 09:58:22PM +0300, Pohjolainen, Topi wrote: > > On Thu, Apr 23, 2015 at 11:53:49AM -0700, Matt Turner wrote: > > > On Wed, Apr 22, 2015 at 1:47 PM, Topi Pohjolainen > > > wrote: > > > > Signed-off-by: Topi P

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 Mark Janes changed: What|Removed |Added CC||lem...@gmail.com -- You are receiving this

[Mesa-dev] [PATCH 0/6] Gallium support for create_context_robustness extensions

2015-04-29 Thread Marek Olšák
Hi, These patches add Gallium support for: - GLX_ARB_create_context_robustness - EGL_EXT_create_context_robustness - glGetGraphicsResetStatusARB() Only r600 and radeonsi support is done, which depends on the kernel patch I sent just a moment ago. Please review. Marek __

[Mesa-dev] [PATCH 2/6] gallium: add PIPE_CAP_DEVICE_RESET_STATUS_QUERY

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 5/6] st/mesa: translate st_api robustness flags to gl_context flags

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_manager.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 840f76a..0376954 100644 --- a/src/mesa/state_tracker/st_manager.c +++ b/src/mesa/state_tracker/st_man

[Mesa-dev] [PATCH 3/6] st/mesa: implement GetGraphicsResetStatus

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_flush.c | 35 ++- src/mesa/state_tracker/st_cb_flush.h | 3 ++- src/mesa/state_tracker/st_context.c | 7 --- src/mesa/state_tracker/st_context.h | 3 ++- 4 files changed, 42 insertions(+), 6 deletions(-)

[Mesa-dev] [PATCH 6/6] r600g, radeonsi: implement get_device_reset_status

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 3 +++ src/gallium/drivers/radeon/r600_pipe_common.c | 20 src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_pipe.c| 3 +++ src/gallium/winsys/

[Mesa-dev] [PATCH 4/6] st/dri: add support for create_context_robustness GLX and EGL extensions

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri2.c| 22 +- src/gallium/state_trackers/dri/dri_context.c | 27 +++ src/gallium/state_trackers/dri/dri_screen.h | 1 + 4 files changed

[Mesa-dev] [PATCH 1/6] gallium: add an interface for querying a device reset status

2015-04-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/pipe/p_context.h | 4 src/gallium/include/pipe/p_defines.h | 13 + 2 files changed, 17 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index a4cae8e..314561f 100644 --- a/src/gall

Re: [Mesa-dev] [PATCH 0/6] Gallium support for create_context_robustness extensions

2015-04-29 Thread Kenneth Graunke
On Wednesday, April 29, 2015 07:43:21 PM Marek Olšák wrote: > Hi, > > These patches add Gallium support for: > - GLX_ARB_create_context_robustness > - EGL_EXT_create_context_robustness > - glGetGraphicsResetStatusARB() > > Only r600 and radeonsi support is done, which depends on the kernel patch

Re: [Mesa-dev] [PATCH 01/18] i965: Refactor rb surface setup to allow caller to store offsets

2015-04-29 Thread Anuj Phogat
On Wed, Apr 22, 2015 at 1:47 PM, Topi Pohjolainen wrote: > Notice that in gen7_wm_surface_state.c there is also indentation > change in the surrounding code removing tabs. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.h | 8 +++ > src/mesa/drive

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
> When you rebase this, I'd appreciate it if you could insert it into > the list in alphabetical order. (You based this on a commit where a > bunch of the later additions were already not inserted alphabetically, > but I've recently fixed that up.) Sure, no worries. Given that I am just changing t

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Ilia Mirkin
On Wed, Apr 29, 2015 at 2:35 PM, Rogovin, Kevin wrote: >> When you rebase this, I'd appreciate it if you could insert it into >> the list in alphabetical order. (You based this on a commit where a >> bunch of the later additions were already not inserted alphabetically, >> but I've recently fixed

[Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

2015-04-29 Thread Ian Romanick
From: Ian Romanick Along with a couple secondary goals, the dispatch sanity test had two major, primary goals. 1. Ensure that all functions part of an API version are set in the dispatch table. 2. Ensure that functions that cannot be part of an API version are not set in the dispatch tabl

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Matt Turner
On Wed, Apr 29, 2015 at 6:36 AM, Rogovin, Kevin wrote: >> At the bottom is another block with GLES 3.1 requirements, which also >> contains GL_ARB_f_n_a. > > > > At first, I said “Oh futz, I did not mark that one”. Then I did some > thinking. Before expressing > > my thoughts I want to emphasize t

Re: [Mesa-dev] [PATCH 01/18] i965: Refactor rb surface setup to allow caller to store offsets

2015-04-29 Thread Matt Turner
On Wed, Apr 29, 2015 at 11:05 AM, Anuj Phogat wrote: > With Matt's comments fixed: > Reviewed-by: Anuj Phogat So you know, Ken and I have both reviewed this series now. Unless you just want to review it, I don't think you need to. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 01/18] i965: Refactor rb surface setup to allow caller to store offsets

2015-04-29 Thread Anuj Phogat
On Wed, Apr 29, 2015 at 12:17 PM, Matt Turner wrote: > On Wed, Apr 29, 2015 at 11:05 AM, Anuj Phogat wrote: >> With Matt's comments fixed: >> Reviewed-by: Anuj Phogat > > So you know, Ken and I have both reviewed this series now. Unless you > just want to review it, I don't think you need to. To

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

2015-04-29 Thread Chris Forbes
It might be better to just prefetch no samplers in this case? -- a shader that has this many active samplers "probably" doesn't actually use them all in a single invocation. On Thu, Apr 30, 2015 at 5:23 AM, Kenneth Graunke wrote: > On Wednesday, April 29, 2015 07:47:26 PM Pohjolainen, Topi wrote:

Re: [Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

2015-04-29 Thread Ian Romanick
On 04/29/2015 12:07 PM, Ian Romanick wrote: > From: Ian Romanick > > Along with a couple secondary goals, the dispatch sanity test had two > major, primary goals. > > 1. Ensure that all functions part of an API version are set in the >dispatch table. > > 2. Ensure that functions that cannot

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
Hi, > I'd just go read the ES 3.1 spec and see if there are any differences in this > area. I checked the spec, and it appears to me to have the same behavior as GL_ARB_framebuffer_no_attachments. > Also, please fix your mail client to stop its weird line wrapping (and the > other half of the

Re: [Mesa-dev] [PATCH 3/9] mesa: Complete implementation for GL_ARB_framebuffer_no_attachments in Mesa core

2015-04-29 Thread Rogovin, Kevin
I just want to make a begging on the review for this patch: I am a touch paranoid about how the thing will act under the GL ES situation; I believe it should follow the spec, but if whoever reviews does the extra leg work of checking that I got this right, I'd really appreciate it. _

Re: [Mesa-dev] [PATCH 6/9] i965: Use _mesa_geometry_ functions appropriately

2015-04-29 Thread Rogovin, Kevin
Hi, One comment on the code, or rather a request to the reviewer of the code. The icky part of checking this patch is correct is checking that the remaining instances of gl_framebuffer::Width, Height, MaxNumLayers and Visaul.samples are "correct". I believe I "got 'em all", of those that shoul

[Mesa-dev] [PATCH] i965/ps: Use SET_FIELD() for sampler count

2015-04-29 Thread Topi Pohjolainen
The value is actually clamped to 0-16 as sample state pointer can be used to support more than 16 samplers. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/gen7_wm_state.c | 5 +++-- src/mesa/drivers/dri/i965/gen8_ps_state.c | 5 +++-

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

2015-04-29 Thread Kenneth Graunke
On Thursday, April 30, 2015 08:09:46 AM Chris Forbes wrote: > It might be better to just prefetch no samplers in this case? -- a > shader that has this many active samplers "probably" doesn't actually > use them all in a single invocation. I'm fine with that too - I think the gains from prefetchin

Re: [Mesa-dev] [PATCH] i965/ps: Use SET_FIELD() for sampler count

2015-04-29 Thread Kenneth Graunke
On Thursday, April 30, 2015 12:14:34 AM Topi Pohjolainen wrote: > The value is actually clamped to 0-16 as sample state pointer > can be used to support more than 16 samplers. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_defines.h | 1 + > src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

2015-04-29 Thread Brian Paul
On 04/29/2015 02:53 PM, Ian Romanick wrote: On 04/29/2015 12:07 PM, Ian Romanick wrote: From: Ian Romanick Along with a couple secondary goals, the dispatch sanity test had two major, primary goals. 1. Ensure that all functions part of an API version are set in the dispatch table. 2. Ens

Re: [Mesa-dev] [PATCH] i965/ps: Use SET_FIELD() for sampler count

2015-04-29 Thread Anuj Phogat
On Wed, Apr 29, 2015 at 2:14 PM, Topi Pohjolainen wrote: > The value is actually clamped to 0-16 as sample state pointer > can be used to support more than 16 samplers. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_defines.h | 1 + > src/mesa/drivers/dri/i965/gen7_w

[Mesa-dev] [PATCH 12/20] glsl/es3.1: Allow interger mix built-ins in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 5ce8112..435d926 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/gl

[Mesa-dev] [PATCH 20/20] mesa: Allow MESA_GL_VERSION_OVERRIDE with ES contexts

2015-04-29 Thread Ian Romanick
From: Ian Romanick The bulk of the change is to prevent overriding the context to API_OPENGL_CORE based on the requested version. If the context is API_OPENGL_ES2, don't change it. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/dri_util.c | 4 src/mesa/main/context.c

[Mesa-dev] [PATCH 02/20] mesa: Use bool instead of GLboolean

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/version.c | 56 - 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 5b8ac0a..7bf3f49 100644 --- a/src/mesa/main/

[Mesa-dev] [PATCH 07/20] docs/GL3: Update GLES 3.1 dependencies

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- docs/GL3.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/GL3.txt b/docs/GL3.txt index 617ff34..d188ffa 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -225,11 +225,17 @@ GLES3.1, GLSL ES 3.1 GL_ARB_shading_language_packing

[Mesa-dev] [PATCH 01/20] glsl: Silence unused parameter warnings

2015-04-29 Thread Ian Romanick
From: Ian Romanick I opted to comment out "last_field" because it was not obvious what the meaning of the dangling bool would be. For the other parameters, the meaning was more intuitive without the name. link_uniform_blocks.cpp:70:65: warning: unused parameter 'name' [-Wunused-parameter]

[Mesa-dev] [PATCH 09/20] glsl/es3.1: Allow 3.10 ES shaders in a GLES 3.1 context

2015-04-29 Thread Ian Romanick
From: Ian Romanick Currently no 3.10 ES features (beyond 3.00 ES) are enabled. That will come later. Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 9 +++-- src/glsl/glsl_parser_extras.h | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/glsl/g

[Mesa-dev] [PATCH 10/20] glsl/es3.1: Allow explicit uniform locations in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.h | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h index 960f957..552d589 100644 --- a/src/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH 05/20] mesa: Use bool in _mesa_is_ helpers instead of GLboolean

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 1cd89a8..d11027d 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/main/context.h @@ -

[Mesa-dev] [PATCH 18/20] gles/es3.1: Enable dispatch of almost all new GLES 3.1 functions

2015-04-29 Thread Ian Romanick
From: Ian Romanick A couple functions are missing because there are no implementations of them yet. These are: glFramebufferParameteri (from GL_ARB_framebuffer_no_attachments) glGetFramebufferParameteriv (from GL_ARB_framebuffer_no_attachments) glMemoryBarrierByRegion v2: Reb

[Mesa-dev] [PATCH 17/20] glapi/es3.1: Add support for GLES versions > 3.0

2015-04-29 Thread Ian Romanick
From: Ian Romanick Make the checks in the Python script and the generated code more generic to support arbitrary GLES versions >= 2.0. The updated dispatch_sanity.cpp test discovered this problem. Without this, the next patch would erroneously enable GLES 3.1 functions in GLES 2.0 and GLES 3.0.

[Mesa-dev] [PATCH 04/20] mesa: Trivial coding standards cleanups

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/version.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 85d5ab1..88dba24 100644 --- a/src/mesa/main/version.c +++ b/src/mesa

[Mesa-dev] [PATCH 13/20] glsl/es3.1: Allow atomic counters in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_variables.cpp | 35 +++ src/glsl/glsl_parser_extras.cpp | 10 ++ src/glsl/glsl_parser_extras.h | 12 +++- 3 files changed, 52 insertions(+), 5 deletions(-) diff --git a/src/gl

[Mesa-dev] [PATCH 00/20] Begin enabling OpenGL ES 3.1

2015-04-29 Thread Ian Romanick
There's still a fair amount functionality left to be implemented before GLES 3.1 can actually be enabled. Compute shaders and SSBOs are the biggest things left to finish. This series just allows people to start testing the things that are implemented. To get a GLES 3.1 context, set the environme

[Mesa-dev] [PATCH 08/20] mesa/es3.1: Add _mesa_is_gles31 helper

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index d11027d..6f3c941 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/main/context.h

[Mesa-dev] [PATCH 14/20] glsl/es3.1: Allow enhnaced packing functions in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 435d926..72fb5e0 100644 --- a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 90 -- 1 file changed, 61 insertions(+), 29 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 72fb5e0..b202b39 100644 --- a/

[Mesa-dev] [PATCH 11/20] glsl/es3.1: Allow separate shader objects in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h index 552d589..61d4c93 100644 --- a/src/glsl/glsl_parser_extras.h +++ b/src/glsl

[Mesa-dev] [PATCH 06/20] glsl: Add glsl_parser_state::has_atomic_counters helper

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 2 +- src/glsl/builtin_types.cpp | 2 +- src/glsl/builtin_variables.cpp | 2 +- src/glsl/glsl_parser.yy| 4 ++-- src/glsl/glsl_parser_extras.h | 5 + 5 files changed, 10 insertions(+), 5 deletio

[Mesa-dev] [PATCH 03/20] SQUASH! whitespace fixes after previous commit

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/version.c | 261 1 file changed, 130 insertions(+), 131 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 7bf3f49..85d5ab1 100644 --- a/src/mesa/mai

[Mesa-dev] [PATCH 16/20] glsl/es3.1: Allow misc ARB_gpu_shader5 built-ins in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index b202b39..1df6956 100644 --- a/src/glsl/builtin_fun

[Mesa-dev] [PATCH 19/20] mesa/es3.1: Enable ES 3.1 API and shading language version

2015-04-29 Thread Ian Romanick
From: Ian Romanick This is a bit of a hack for now. Several of the extensions required for OpenGL ES 3.1 have no support, at all, in Mesa. However, with this patch and a patch to allow MESA_GL_VERSION_OVERRIDE to work with ES contexts, people can begin testing the ES "version" of the functional

Re: [Mesa-dev] [PATCH 20/20] mesa: Allow MESA_GL_VERSION_OVERRIDE with ES contexts

2015-04-29 Thread Rob Clark
On Wed, Apr 29, 2015 at 7:26 PM, Ian Romanick wrote: > From: Ian Romanick > > The bulk of the change is to prevent overriding the context to > API_OPENGL_CORE based on the requested version. If the context is > API_OPENGL_ES2, don't change it. > > Signed-off-by: Ian Romanick \o/-by: Rob Clark

Re: [Mesa-dev] [PATCH 01/20] glsl: Silence unused parameter warnings

2015-04-29 Thread Anuj Phogat
On Wed, Apr 29, 2015 at 4:25 PM, Ian Romanick wrote: > From: Ian Romanick > > I opted to comment out "last_field" because it was not obvious what the > meaning of the dangling bool would be. For the other parameters, the > meaning was more intuitive without the name. > > link_uniform_blocks.cpp:

Re: [Mesa-dev] [PATCH 6/7] i965/cs: Implement brw_emit_gpgpu_walker

2015-04-29 Thread Jordan Justen
On 2015-04-27 19:02:38, Kenneth Graunke wrote: > On Friday, April 24, 2015 04:33:43 PM Jordan Justen wrote: > > Tested on Ivybridge, Haswell and Broadwell. > > > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_compute.c | 39 > > - > > sr

Re: [Mesa-dev] [PATCH 12/20] glsl/es3.1: Allow interger mix built-ins in GLSL ES 3.10

2015-04-29 Thread Anuj Phogat
In patch heading: s/interger/integer On Wed, Apr 29, 2015 at 4:26 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/builtin_functions.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/builtin_functions.cpp b/src/

Re: [Mesa-dev] [PATCH 12/20] glsl/es3.1: Allow interger mix built-ins in GLSL ES 3.10

2015-04-29 Thread Anuj Phogat
On Wed, Apr 29, 2015 at 5:38 PM, Anuj Phogat wrote: > In patch heading: s/interger/integer > > On Wed, Apr 29, 2015 at 4:26 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/glsl/builtin_functions.cpp | 3 ++- >> 1 file changed, 2 insertions(+), 1 de

Re: [Mesa-dev] [PATCH 05/20] mesa: Use bool in _mesa_is_ helpers instead of GLboolean

2015-04-29 Thread Dylan Baker
For what it's worth, patches 1-5 are: Reviewed-by: Dylan Baker On Wed, Apr 29, 2015 at 04:25:56PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/main/context.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/s

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 Sgt. Garcia changed: What|Removed |Added CC||darwinsker...@gmail.com -- You are receiv

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #30 from Sgt. Garcia --- same here, it seems. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://list

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #31 from Sgt. Garcia --- Created attachment 115461 --> https://bugs.freedesktop.org/attachment.cgi?id=115461&action=edit dmesg |ag drm -- You are receiving this mail because: You are the assignee for the bug. _

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #32 from Sgt. Garcia --- Created attachment 115462 --> https://bugs.freedesktop.org/attachment.cgi?id=115462&action=edit /sys/class/drm/card0/error -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #33 from Sgt. Garcia --- Created attachment 115463 --> https://bugs.freedesktop.org/attachment.cgi?id=115463&action=edit glxinfo -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #34 from Sgt. Garcia --- glxgrear: Running synchronized to the vertical refresh. The framerate should be approximately the same as the monitor refresh rate. intel_do_flush_locked failed: Input/output error compton: intel_do_flush_lo

Re: [Mesa-dev] [PATCH 14/20] glsl/es3.1: Allow enhnaced packing functions in GLSL ES 3.10

2015-04-29 Thread Matt Turner
On Wed, Apr 29, 2015 at 4:26 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Reviewed-by: Matt Turner (I'm just reviewing this because I've familiar with the crazy availability matrix of these functions. Not planning to review the rest of the series) _

Re: [Mesa-dev] [PATCH 16/20] glsl/es3.1: Allow misc ARB_gpu_shader5 built-ins in GLSL ES 3.10

2015-04-29 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #35 from Sgt. Garcia --- Created attachment 115464 --> https://bugs.freedesktop.org/attachment.cgi?id=115464&action=edit intel_reg_dumper -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [PATCH 5/8] glsl: track which program inputs are doubles

2015-04-29 Thread Dave Airlie
From: Dave Airlie instead of doing the attempts at dual slot handling here, let the backend do it. Signed-off-by: Dave Airlie --- src/glsl/ir_set_program_inouts.cpp | 14 ++ src/mesa/main/mtypes.h | 1 + 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 2/8] mapi: add GL_ARB_vertex_attrib_64bit support

2015-04-29 Thread Dave Airlie
From: Dave Airlie This just adds the glapi bits. Signed-off-by: Dave Airlie --- src/mapi/glapi/gen/ARB_vertex_attrib_64bit.xml | 70 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 +- src/mesa/main/api_loopb

[Mesa-dev] [PATCH 3/8] mesa: add ARB_vertex_attrib_64bit to extensions. (v2)

2015-04-29 Thread Dave Airlie
From: Dave Airlie Just add the boilerplate bits. v2: add to version.c Signed-off-by: Dave Airlie --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/version.c| 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 1/8] st/glsl_to_tgsi: fix ir_assignment hack doing bad things for doubles

2015-04-29 Thread Dave Airlie
From: Dave Airlie This hack for fixing gl_FragDepth apparantly caused a GLSL shader outputting a single double to try and output a dvec4, but we hadn't assigned outputs for the secondary bit. This avoids going into the hack code for scalar doubles. Signed-off-by: Dave Airlie --- src/mesa/stat

[Mesa-dev] ARB_vertex_attrib_64bit support (2nd posting I think)

2015-04-29 Thread Dave Airlie
The biggest change in this series is the attribute slot counting code in patch 6, and some cleanups in patch 8. I think this isn't going to improve itself much more out of tree, Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists

  1   2   >