[Mesa-dev] [PATCH 2/2] glsl/opt_array_splitting: Fix indentation

2015-09-14 Thread Iago Toral Quiroga
--- src/glsl/opt_array_splitting.cpp | 54 +++- 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/src/glsl/opt_array_splitting.cpp b/src/glsl/opt_array_splitting.cpp index 1fdd013..b7ea405 100644 --- a/src/glsl/opt_array_splitting.cpp +++

[Mesa-dev] [PATCH 1/2] glsl/opt_array_splitting: Fix crash when doing array indexing into other arrays

2015-09-14 Thread Iago Toral Quiroga
When we find indirect indexing into an array, the current implementation of the array spliiting optimization pass does not look further into the expression tree. However, if the variable expression involves variable indexing into other arrays, we can miss that these other arrays also have variable

Re: [Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

2015-09-14 Thread Hans de Goede
Hi, On 11-09-15 18:48, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 10:46 AM, Hans de Goede wrote: Hi, I've been working on trying to fix this one: https://bugs.freedesktop.org/show_bug.cgi?id=90871 And today I've more or less root caused this, it seems that some code is

[Mesa-dev] [PATCH 5/5] gallium: Remove pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
This state has been de-fact ignored all along. --- src/gallium/auxiliary/hud/hud_context.c| 1 - src/gallium/auxiliary/util/u_dump_state.c | 1 - src/gallium/docs/source/cso/rasterizer.rst | 4 src/gallium/drivers/trace/tr_dump_state.c | 1 - src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 3/5] nouveau: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
--- src/gallium/drivers/nouveau/nv50/nv50_state.c | 3 --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 1 - 2 files changed, 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_state.c b/src/gallium/drivers/nouveau/nv50/nv50_state.c index 410e631..76c3508 100644 ---

[Mesa-dev] [PATCH 2/5] ilo: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
--- src/gallium/drivers/ilo/ilo_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ilo/ilo_state.c b/src/gallium/drivers/ilo/ilo_state.c index d89765a..d50d5c4 100644 --- a/src/gallium/drivers/ilo/ilo_state.c +++ b/src/gallium/drivers/ilo/ilo_state.c

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-09-14 Thread Abdiel Janulgue
On 09/12/2015 01:42 AM, Ben Widawsky wrote: > On Fri, Sep 11, 2015 at 11:33:14AM +0300, Abdiel Janulgue wrote: >> Some updated figures first: >> >> Ue4 Reflections Subway demo >> x fs gather constants disabled >> + fs gather constants enabled >> >> HSW: >> N Min Max

[Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
Altough SVGA3D_RS_LASTPIXEL renderstate exists, most backends ignore it. --- src/gallium/drivers/svga/svga_context.h | 1 - src/gallium/drivers/svga/svga_pipe_rasterizer.c | 1 - src/gallium/drivers/svga/svga_state_rss.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 4/5] st/nine: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
This state is ignored by most gallium drivers. I also don't know of any D3D9 application that relies on D3DRS_LASTPIXEL. And even WHCK itself doesn't seem to test it. --- src/gallium/state_trackers/nine/nine_pipe.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Brian Paul
On 09/14/2015 05:09 AM, Jose Fonseca wrote: Altough SVGA3D_RS_LASTPIXEL renderstate exists, most backends ignore it. --- src/gallium/drivers/svga/svga_context.h | 1 - src/gallium/drivers/svga/svga_pipe_rasterizer.c | 1 - src/gallium/drivers/svga/svga_state_rss.c | 2 +- 3

Re: [Mesa-dev] [PATCH v3] i915: fixing driver crashes if too few vertices are submitted

2015-09-14 Thread Predut, Marius
Eirik, Apologize for typo. -Original Message- From: Predut, Marius Sent: Monday, September 14, 2015 12:32 PM To: Predut, Marius; Eirik Byrkjeflot Anonsen; Ilia Mirkin; Ian Romanick Cc: mesa-dev@lists.freedesktop.org; Romanick, Ian D Subject: RE: [Mesa-dev] [PATCH v3] i915: fixing driver

Re: [Mesa-dev] [PATCH v2 0/5] gallium: add support for retrieving number of texture samples

2015-09-14 Thread Brian Paul
On 09/11/2015 04:29 PM, Ilia Mirkin wrote: OK, I've added a PIPE_CAP to control it now. I've left the relevant R-b's from v1 in place despite a few changes, I think they're minor enough. Ilia Mirkin (5): tgsi: add a TXQS opcode to retrieve the number of texture samples gallium: add

Re: [Mesa-dev] [PATCH 09/11] nir/lower_vec_to_movs: Get rid of start_idx and swizzle compacting

2015-09-14 Thread Eric Anholt
Jason Ekstrand writes: > Previously, we did this thing with keeping track of a separate start_idx > which was different from the iteration variable. I think this was a relic > of the way that GLSL IR implements writemasks. In NIR, if a given bit in > the writemask is

Re: [Mesa-dev] [PATCH 02/11] nir: Remove the mem_ctx parameter from ssa_def_rewrite_uses

2015-09-14 Thread Eric Anholt
Jason Ekstrand writes: > --- > src/glsl/nir/nir.c| 2 +- > src/glsl/nir/nir.h| 2 +- > src/glsl/nir/nir_control_flow.c | 2 +- > src/glsl/nir/nir_from_ssa.c | 5 ++--- >

Re: [Mesa-dev] [PATCH 01/11] nir: Fix a bunch of ralloc parenting errors

2015-09-14 Thread Eric Anholt
Jason Ekstrand writes: > As of a10d4937, we would really like things associated with an instruction > to be allocated out of that instruction and not out of the shader. In > particular, you should be passing the instruction that will ultimately be > holding the source into

Re: [Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Roland Scheidegger
For the series: Reviewed-by: Roland Scheidegger Am 14.09.2015 um 13:09 schrieb Jose Fonseca: > Altough SVGA3D_RS_LASTPIXEL renderstate exists, most backends ignore it. > --- > src/gallium/drivers/svga/svga_context.h | 1 - >

Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-14 Thread Jason Ekstrand
On Sep 14, 2015 01:22, "Eduardo Lima Mitev" wrote: > > On 09/11/2015 05:58 PM, Jason Ekstrand wrote: > > On Fri, Sep 11, 2015 at 5:45 AM, Eduardo Lima Mitev wrote: > >> Reviewed-by: Eduardo Lima Mitev > > > > One side-note: Could you please

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

2015-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #21 from Eirik Byrkjeflot Anonsen --- (In reply to Krzysztof A. Sobiecki from comment #20) > (In reply to Michel Dänzer from comment #18) > > (In reply to Krzysztof A. Sobiecki from comment #14) > > > So how

Re: [Mesa-dev] [PATCH 02/11] nir: Remove the mem_ctx parameter from ssa_def_rewrite_uses

2015-09-14 Thread Jason Ekstrand
On Sep 14, 2015 07:05, "Eric Anholt" wrote: > > Jason Ekstrand writes: > > > --- > > src/glsl/nir/nir.c| 2 +- > > src/glsl/nir/nir.h| 2 +- > > src/glsl/nir/nir_control_flow.c | 2 +- >

Re: [Mesa-dev] [PATCH 08/11] i965/vec4_nir: Use partial SSA form rather than full non-SSA

2015-09-14 Thread Jason Ekstrand
On Sep 11, 2015 03:25, "Eduardo Lima Mitev" wrote: > > On 09/10/2015 02:50 AM, Jason Ekstrand wrote: > > We made this switch in the FS backend some time ago and it seems to make a > > number of things a bit easier. > > > > The commit log could be a bit less abstract, like

Re: [Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Axel Davy
Looking at the AMD hw state doc, there is a state corresponding to that feature, so it could be implemented there. What is the policy for removing gallium features ? Even though there is no real support for it is, it doesn't seem a feature that can be emulated with other features. Yours,

Re: [Mesa-dev] [PATCH 09/11] nir/lower_vec_to_movs: Get rid of start_idx and swizzle compacting

2015-09-14 Thread Jason Ekstrand
On Fri, Sep 11, 2015 at 8:58 AM, Eric Anholt wrote: > Jason Ekstrand writes: > >> Previously, we did this thing with keeping track of a separate start_idx >> which was different from the iteration variable. I think this was a relic >> of the way that GLSL

Re: [Mesa-dev] [PATCH] docs: only astc ldr required for ES3.2, not hdr

2015-09-14 Thread Ian Romanick
On 09/13/2015 10:09 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > Perhaps I'm missing it, but the ES3.2 spec explicitly says that it only > supports LDR. On page 508, appendix C: > > """ > ASTC textures defined in this appendix are known as the LDR Profile of

[Mesa-dev] [PATCH 3/4] main/get: make KHR_debug enums available everywhere

2015-09-14 Thread Emil Velikov
From: Matthew Waters Although GL_CONTEXT_FLAGS is not explicitly added by KHR_debug, it contains, "It is implementation defined how much debug output is generated if the context was created without the CONTEXT_DEBUG_BIT set. This is a new query bit added to the

[Mesa-dev] [PATCH 4/4] mesa: enable KHR_debug for ES contexts

2015-09-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- docs/relnotes/11.1.0.html | 1 + src/mesa/main/extensions.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 02ffd45..fa99394 100644 ---

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

2015-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #23 from Eirik Byrkjeflot Anonsen --- (In reply to almos from comment #22) > (In reply to Eirik Byrkjeflot Anonsen from comment #21) > > > No matter what they shouldn't be able to get that data. I'm starting to > >

Re: [Mesa-dev] [PATCH 1/6] mesa/glformats: expose certain compressed formats to desktop GL

2015-09-14 Thread Nanley Chery
On Fri, Aug 28, 2015 at 9:17 AM, Ilia Mirkin wrote: > On Fri, Aug 28, 2015 at 10:50 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > According to the extensions table and our glext headers, these > > extensions are

Re: [Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Jose Fonseca
I don't know if there's a strict policy. From my POV, if people actually bother implementing it, then yeah, it would make a lot of sense in keeping it, since as you say it can't be easily emulated. But if the state is just lying there, being ignored by practically everybody, then there's

Re: [Mesa-dev] [PATCH] dri/common: use sysconfdir when looking for drirc

2015-09-14 Thread Emil Velikov
Hi Marcin, On 13 September 2015 at 17:55, Marcin Ślusarz wrote: > Useful when locally installed mesa has more quirks than the system one. > --- > src/mesa/drivers/dri/common/Makefile.am | 1 + > src/mesa/drivers/dri/common/xmlconfig.c | 6 +- Please update the

[Mesa-dev] [PATCH 2/2] egl/dri2: enable EGL_KHR_gl_colorspace for swrast

2015-09-14 Thread Emil Velikov
No driver changes needed for softpipe/llvmpipe - things just work. Signed-off-by: Emil Velikov --- docs/relnotes/11.1.0.html | 1 + src/egl/drivers/dri2/platform_drm.c | 12 ++-- src/egl/drivers/dri2/platform_wayland.c | 9 ++---

[Mesa-dev] [PATCH 1/4] egl: rework handling EGL_CONTEXT_FLAGS

2015-09-14 Thread Emil Velikov
From: Matthew Waters As of version 15 of the EGL_KHR_create_context spec, debug contexts are allowed for ES contexts. We should allow creation instead of erroring. While we're here provide a more comprehensive checking for the other two flags - ROBUST_ACCESS_BIT_KHR and

[Mesa-dev] [PATCH 2/4] glapi: add function pointers for KHR_debug for gles

2015-09-14 Thread Emil Velikov
From: Matthew Waters v2 [Emil Velikov] - Rebase. - Correct version in gles11 dispatch_sanity. - Move the extension enable to a separate patch. Signed-off-by: Matthew Waters Signed-off-by: Emil Velikov ---

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

2015-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #22 from almos --- (In reply to Eirik Byrkjeflot Anonsen from comment #21) > > No matter what they shouldn't be able to get that data. I'm starting to > > think if it's possible to grab that data with OpenGL

[Mesa-dev] [PATCH 1/2] egl/dri2: ease srgb __DRIconfig conditionals

2015-09-14 Thread Emil Velikov
One can simplify the if-else chain, by declaring the driconfigs as a two sized array, whist using srgb as a index to the correct entry. Signed-off-by: Emil Velikov --- This commit is a bit on the bikeshed side so I won't push it people dislike it :) -Emil

Re: [Mesa-dev] [PATCH] dri/common: use sysconfdir when looking for drirc

2015-09-14 Thread Marcin Ślusarz
On Mon, Sep 14, 2015 at 06:33:16PM +0100, Emil Velikov wrote: > Hi Marcin, > > On 13 September 2015 at 17:55, Marcin Ślusarz > wrote: > > Useful when locally installed mesa has more quirks than the system one. > > --- > > src/mesa/drivers/dri/common/Makefile.am | 1 +

[Mesa-dev] XDC 2015: Updated Schedule, Social Event, Video release form

2015-09-14 Thread Tom Stellard
Hi, I just wanted to pass along a few XDC updates: - I have made some changes to the schedule, but it should still be considered tentative. I will let announce once it has been finalized. - There is an informal get together planned for Tuesday night if you are in town early. Please sign up on

[Mesa-dev] [PATCH 2/3] gallium: add support for gl_HelperInvocation semantic

2015-09-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/docs/source/tgsi.rst | 8 src/gallium/include/pipe/p_shader_tokens.h | 3 ++- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++- 4 files changed, 14

[Mesa-dev] [PATCH 3/3] nvc0/ir: add support for TGSI_SEMANTIC_FRAG_HELPER

2015-09-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 +

[Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-09-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 3 +++ src/glsl/shader_enums.h| 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 3 files changed, 5 insertions(+) diff --git a/src/glsl/builtin_variables.cpp

Re: [Mesa-dev] [PATCH] mesa/glformats: restrict luminance alpha formats to API_OPENGL_COMPAT

2015-09-14 Thread Anuj Phogat
On Mon, Sep 14, 2015 at 11:17 AM, Nanley Chery wrote: > From: Nanley Chery > > According the GL 3.1 spec, luminance alpha formats are deprecated. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 4

Re: [Mesa-dev] [PATCH] docs: document INTEL_DEBUG 'optimizer' envvar

2015-09-14 Thread Matt Turner
On Mon, Sep 14, 2015 at 11:16 AM, Alejandro Piñeiro wrote: > --- > > I didn't see any kind (ie: alphabetical) order on that list, so I just added > it to the end. > > docs/envvars.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/envvars.html

Re: [Mesa-dev] [PATCH 0/3] Move libdrm dependencies out of backend compiler

2015-09-14 Thread Jordan Justen
On 2015-09-09 10:44:10, Kristian Høgsberg Kristensen wrote: > In trying to separate the backend compiler from the core driver, I ran > into a couple of inconsistencies with how the compute shader code is > split across files. First patch moves code around to follow our > convention. The last two

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-09-14 Thread Ilia Mirkin
On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/glsl/builtin_variables.cpp | 3 +++ > src/glsl/shader_enums.h| 1 + > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + > 3

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

2015-09-14 Thread Mark Janes
I tested this series, and found a few issues: - `make check` fails the dispatch sanity tests in Mesa - The branch doesn't rebase cleanly on top of master (this isn't wrong, it just surprised me, since you sent out the series so recently) -

Re: [Mesa-dev] [PATCH 08/11] i965/vec4_nir: Use partial SSA form rather than full non-SSA

2015-09-14 Thread Eduardo Lima Mitev
On 09/14/2015 05:10 PM, Jason Ekstrand wrote: > > On Sep 11, 2015 03:25, "Eduardo Lima Mitev" > wrote: >> >> On 09/10/2015 02:50 AM, Jason Ekstrand wrote: >> > We made this switch in the FS backend some time ago and it seems to > make a >> > number of

Re: [Mesa-dev] [PATCH 1/3] i965: Abort tiled_memcpy path for ReadPixels in case of transfer operations

2015-09-14 Thread Anuj Phogat
On Tue, Sep 1, 2015 at 6:58 AM, Emil Velikov wrote: > Hi all > > On 21 August 2015 at 23:04, Anuj Phogat wrote: > > We have a similar check in meta pbo path. > > > > Cc: > > Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH 4/4] i965/fs: Add a very basic validation pass

2015-09-14 Thread Jason Ekstrand
Currently the validation pass only validates that regs_read and regs_written are consistent with the sizes of VGRF's. We can add more as we find it to be useful. Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/Makefile.sources| 1 +

[Mesa-dev] [PATCH 3/4] i965/fs_surface_builder: Only apply predicate to components that exist

2015-09-14 Thread Jason Ekstrand
In certain conditions, we have to do bounds-checking in the shader for image_load_store. The way this works for image loads is that we do the load anyway and then emit a series of slecects, one per component, that gives us 0 or the loaded value depending on whether or not you're in bounds.

[Mesa-dev] [PATCH 1/4] i965/fs: Set output_components for lowered clip distance outputs

2015-09-14 Thread Jason Ekstrand
Cc: Kristian Høgsberg --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index 5cb794b..cea16e0 100644 ---

[Mesa-dev] [PATCH 2/4] i965/fs: Only read output_components many components when writing an output

2015-09-14 Thread Jason Ekstrand
Cc: Kristian Høgsberg --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index cea16e0..8b61c86 100644 ---

[Mesa-dev] [PATCH 06/24] t_dd_dmatmp.h: Remove HAVE_QUAD_STRIPS support

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and neither supports quad strips. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_render.c | 1 - src/mesa/drivers/dri/radeon/radeon_swtcl.c | 1 -

[Mesa-dev] [PATCH 05/24] t_dd_dmatmp.h: Use addition instead of subtraction in loop bounds

2015-09-14 Thread Ian Romanick
From: Ian Romanick This is used everywhere else in this file because it avoids problems when count is zero (due to trimming). Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38109 Cc: Marius Predut

[Mesa-dev] [PATCH 18/24] t_dd_dmatmp.h: Remove HAVE_ELTS support

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and neither supports ELTs. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 588 +- 1 file changed, 4 insertions(+), 584 deletions(-) diff

[Mesa-dev] [PATCH 08/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_QUADS change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 87 --- 1 file changed, 41 insertions(+), 46 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 03/24] t_dd_dmatmp.h: Use '& 3' instead of '% 4' everywhere

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/mesa/tnl_dd/t_dd_dmatmp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 22/24] t_dd_dmatmp.h: Silence comparison between signed and unsigned integer expression warnings

2015-09-14 Thread Ian Romanick
From: Ian Romanick ../../../../../src/mesa/tnl_dd/t_dd_dmatmp.h:83:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] nr = MIN2(currentsz, count - j); ^

[Mesa-dev] [PATCH 07/24] t_dd_dmatmp.h: Remove HAVE_QUADS support

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and neither supports quads. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_render.c | 1 - src/mesa/drivers/dri/radeon/radeon_swtcl.c | 1 - src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 14/24] t_dd_dmatmp.h: Require HAVE_TRI_STRIPS

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and both support triangle strips. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 36 1 file changed, 8 insertions(+), 28 deletions(-) diff

[Mesa-dev] [PATCH 09/24] t_dd_dmatmp.h: Require HAVE_LINES

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and both support lines. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 12/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_LINE_STRIPS change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 260 -- 1 file changed, 123 insertions(+), 137 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 24/24] mesa: Remove unused HAVE_TRI_STRIP_1 defines

2015-09-14 Thread Ian Romanick
From: Ian Romanick Defined to 0 in a few places, but it's not used anywhere. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_render.c | 1 - src/mesa/drivers/dri/r200/r200_swtcl.c | 1 -

[Mesa-dev] [PATCH 10/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_LINES change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 92 +-- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 15/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_TRI_STRIPS change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 198 -- 1 file changed, 95 insertions(+), 103 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 11/24] t_dd_dmatmp.h: Require HAVE_LINE_STRIPS

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and both support line strips. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 33 - 1 file changed, 4 insertions(+), 29 deletions(-) diff --git

[Mesa-dev] [PATCH 19/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_ELTS change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 69 +++ 1 file changed, 31 insertions(+), 38 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 20/24] t_dd_dmatmp.h: General indentation and formatting fixes

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 113 +- 1 file changed, 56 insertions(+), 57 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 00/24] Massive clean up in t_dd_dmatmp.h

2015-09-14 Thread Ian Romanick
I looked at t_dd_dmatmp.h after the previous discussions about fixing the "count" problem. It was a mess. The first 5 patches fix the bug. The remaining 19 patches delete dead code and make the file adhere to Mesa's coding standards. t_dd_triemit.h and t_dd_dmatmp2.h could probably use some

[Mesa-dev] [PATCH 04/24] t_dd_dmatmp.h: Pull out common 'count -= count & 3' code

2015-09-14 Thread Ian Romanick
From: Ian Romanick This was missing in the HAVE_TRIANGLES path, and that could cause incorrect rendering. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38109 Cc: Marius Predut Cc:

[Mesa-dev] [PATCH 01/24] t_dd_dmatmp.h: Make "count" actually be the count

2015-09-14 Thread Ian Romanick
From: Ian Romanick The value passed in count previously was "vertex after the last vertex to be processed." Calling that "count" was misleading and kind of mean. Looking at the code, many functions immediately do "count-start" to get back the true count. That's just

[Mesa-dev] [PATCH 02/24] t_dd_dmatmp.h: Clean up improper code formatting from previous patch

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/mesa/tnl_dd/t_dd_dmatmp.h | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 16/24] t_dd_dmatmp.h: Require HAVE_TRI_FANS

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and both support triangle fans. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 17/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_TRI_FANS change

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 103 +++--- 1 file changed, 47 insertions(+), 56 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h

[Mesa-dev] [PATCH 23/24] t_dd_dmatmp.h: Constify dmasz

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h b/src/mesa/tnl_dd/t_dd_dmatmp.h index

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-09-14 Thread Tapani Pälli
On 09/15/2015 12:43 AM, Ilia Mirkin wrote: On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 3 +++ src/glsl/shader_enums.h| 1 +

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

2015-09-14 Thread Samuel Iglesias Gonsálvez
Hi Mark, On 15/09/15 01:14, Mark Janes wrote: > I tested this series, and found a few issues: > > - `make check` fails the dispatch sanity tests in Mesa > I'm going to take a look at this. > - The branch doesn't rebase cleanly on top of master (this isn't wrong, >it just surprised me,

Re: [Mesa-dev] [PATCH 00/24] Massive clean up in t_dd_dmatmp.h

2015-09-14 Thread Brian Paul
On 09/14/2015 07:01 PM, Ian Romanick wrote: I looked at t_dd_dmatmp.h after the previous discussions about fixing the "count" problem. It was a mess. The first 5 patches fix the bug. The remaining 19 patches delete dead code and make the file adhere to Mesa's coding standards. t_dd_triemit.h

Re: [Mesa-dev] [PATCH 10/24] t_dd_dmatmp.h: Indentation and formatting fixes after HAVE_LINES change

2015-09-14 Thread Brian Paul
On 09/14/2015 07:01 PM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 92 +-- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git

[Mesa-dev] [PATCH 13/24] t_dd_dmatmp.h: Require HAVE_TRIANGLES

2015-09-14 Thread Ian Romanick
From: Ian Romanick Two drivers use this file, and both support triangles. Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 21/24] t_dd_dmatmp.h: Use stdbool.h

2015-09-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/tnl_dd/t_dd_dmatmp.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/tnl_dd/t_dd_dmatmp.h b/src/mesa/tnl_dd/t_dd_dmatmp.h index

Re: [Mesa-dev] [PATCH 1/3] glsl: add gl_HelperInvocation system value

2015-09-14 Thread Ilia Mirkin
On Tue, Sep 15, 2015 at 12:41 AM, Tapani Pälli wrote: > > > On 09/15/2015 12:43 AM, Ilia Mirkin wrote: >> >> On Mon, Sep 14, 2015 at 4:35 PM, Ilia Mirkin wrote: >>> >>> Signed-off-by: Ilia Mirkin >>> --- >>>

[Mesa-dev] [PATCH] nv50, nvc0: unlock tic and update address when invalidating resource

2015-09-14 Thread Ilia Mirkin
When updating texture buffers, we might end up replacing the whole buffer. When the resource is invalidated, we never actually recreate the sampler view, so we have to make sure that it gets reuploaded, and that it gets the proper new address. This fixes arb_direct_state_access-texture-buffer.

[Mesa-dev] [PATCH] freedreno/a3xx: fix blending of L8 format

2015-09-14 Thread Ilia Mirkin
Even though luminance formats don't have alpha, we still want the alpha output to go to the blender. This fixes the luminance blending tests. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a3xx/fd3_format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] docs: cleanups + mark some work as done

2015-09-14 Thread Ilia Mirkin
On Mon, Sep 14, 2015 at 1:52 AM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > docs/GL3.txt | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index e0a8a37..7abfe91

Re: [Mesa-dev] [PATCH 1/5] svga: Ignore pipe_rasterizer_state::line_last_pixel.

2015-09-14 Thread Axel Davy
On 14/09/2015 18:51, Jose Fonseca wrote : I don't know if there's a strict policy. From my POV, if people actually bother implementing it, then yeah, it would make a lot of sense in keeping it, since as you say it can't be easily emulated. But if the state is just lying there, being

Re: [Mesa-dev] [PATCH 3/4] main/get: make KHR_debug enums available everywhere

2015-09-14 Thread Ilia Mirkin
On Mon, Sep 14, 2015 at 1:56 PM, Emil Velikov wrote: > On 14 September 2015 at 18:39, Ilia Mirkin wrote: >> On Mon, Sep 14, 2015 at 1:35 PM, Emil Velikov >> wrote: >>> From: Matthew Waters >>> >>>

[Mesa-dev] [PATCH] mesa/glformats: restrict ETC1_RGB8 support to GLES

2015-09-14 Thread Nanley Chery
From: Nanley Chery According to the extensions table and our glext headers, OES_compressed_ETC1_RGB8_texture is only supported in GLES1 and GLES2. Since we may give users a GLES3 context when a GLES2 context is requested, we also allow this extension for GLES3 as well.

[Mesa-dev] [PATCH] mesa/glformats: restrict luminance alpha formats to API_OPENGL_COMPAT

2015-09-14 Thread Nanley Chery
From: Nanley Chery According the GL 3.1 spec, luminance alpha formats are deprecated. Signed-off-by: Nanley Chery --- src/mesa/main/extensions.c | 4 ++-- src/mesa/main/teximage.c | 6 -- 2 files changed, 6 insertions(+), 4

[Mesa-dev] [PATCH v2] mesa/glformats: refactor compressed format support function

2015-09-14 Thread Nanley Chery
From: Nanley Chery Instead of case statements, use _mesa_get_format_layout() to determine if a GL format is part of a family of compressed formats. v2. restrict LATC formats to API_OPENGL_COMPAT (Ilia). rename the variable mFormat to m_format. Signed-off-by:

Re: [Mesa-dev] [PATCH v2] mesa/glformats: refactor compressed format support function

2015-09-14 Thread Nanley Chery
Sorry about the incorrect threading on these v2's. On Mon, Sep 14, 2015 at 11:17 AM, Nanley Chery wrote: > From: Nanley Chery > > Instead of case statements, use _mesa_get_format_layout() to > determine if a GL format is part of a family of

Re: [Mesa-dev] [PATCH v4 3/3] mesa: Use the effective internal format instead for validation

2015-09-14 Thread Jason Ekstrand
On Fri, Sep 4, 2015 at 7:21 AM, Eduardo Lima Mitev wrote: > When validating format+type+internalFormat for texture pixel operations > on GLES3, the effective internal format should be used if the one > specified is an unsized internal format. Page 127, section "3.8 Texturing" >

[Mesa-dev] [Bug 91984] INTEL_DEBUG=optimizer not described on mesa envvar page

2015-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91984 --- Comment #2 from Alejandro Piñeiro (freenode IRC: apinheiro) --- (In reply to Kenneth Graunke from comment #1) > Feel free to push a patch - it's docs/envvars.html in the Mesa repository. > You might have to ping Brian

Re: [Mesa-dev] [PATCH] i965/fs: Add a very basic validation pass

2015-09-14 Thread Kenneth Graunke
On Thursday, July 30, 2015 03:42:34 PM Jason Ekstrand wrote: > Currently the validation pass only validates that regs_read and > regs_written are consistent with the sizes of VGRF's. We can add more as > we find it to be useful. Bump. Matt sent you a few small comments, but otherwise this was

[Mesa-dev] [Bug 91984] INTEL_DEBUG=optimizer not described on mesa envvar page

2015-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91984 Kenneth Graunke changed: What|Removed |Added Component|Website |Other

Re: [Mesa-dev] [PATCH 3/4] main/get: make KHR_debug enums available everywhere

2015-09-14 Thread Emil Velikov
On 14 September 2015 at 18:39, Ilia Mirkin wrote: > On Mon, Sep 14, 2015 at 1:35 PM, Emil Velikov > wrote: >> From: Matthew Waters >> >> Although GL_CONTEXT_FLAGS is not explicitly added by KHR_debug, >> it contains, >> >>

Re: [Mesa-dev] [PATCH] i965/vec4: fill src_reg type using the constructor type parameter

2015-09-14 Thread Alejandro Piñeiro
Christoph Brill suggested to CC stable on this patch. On 01/09/15 19:53, Matt Turner wrote: > On Tue, Sep 1, 2015 at 8:02 AM, Alejandro Piñeiro > wrote: >> The src_reg constructor that received the glsl_type was using it >> only to build the swizzle, but not to fill

[Mesa-dev] [PATCH] docs: document INTEL_DEBUG 'optimizer' envvar

2015-09-14 Thread Alejandro Piñeiro
--- I didn't see any kind (ie: alphabetical) order on that list, so I just added it to the end. docs/envvars.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/envvars.html b/docs/envvars.html index c0d5a51..168e846 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -153,6

Re: [Mesa-dev] [PATCH 5/6] gallium/util: Add an implementation of ffsl

2015-09-14 Thread Kenneth Graunke
On Saturday, August 15, 2015 11:31:26 AM Jason Ekstrand wrote: > --- > src/gallium/auxiliary/util/u_math.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > index 56bd185..5814421 100644 > ---

Re: [Mesa-dev] [RFC 1/3] nir: Add a generic instruction index

2015-09-14 Thread Jason Ekstrand
On Mon, Sep 14, 2015 at 11:52 AM, Kenneth Graunke wrote: > On Tuesday, September 08, 2015 05:35:12 PM Jason Ekstrand wrote: >> --- >> src/glsl/nir/nir.c | 18 ++ >> src/glsl/nir/nir.h | 4 >> 2 files changed, 22 insertions(+) > > Commit message could

Re: [Mesa-dev] [PATCH v4 3/3] mesa: Use the effective internal format instead for validation

2015-09-14 Thread Jason Ekstrand
Actually, a couple of comments... On Fri, Sep 4, 2015 at 7:21 AM, Eduardo Lima Mitev wrote: > When validating format+type+internalFormat for texture pixel operations > on GLES3, the effective internal format should be used if the one > specified is an unsized internal format.

Re: [Mesa-dev] [PATCH 5/6] gallium/util: Add an implementation of ffsl

2015-09-14 Thread Jason Ekstrand
On Mon, Sep 14, 2015 at 11:41 AM, Kenneth Graunke wrote: > On Saturday, August 15, 2015 11:31:26 AM Jason Ekstrand wrote: >> --- >> src/gallium/auxiliary/util/u_math.h | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git

  1   2   >