[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

[Mesa-dev] glx-tls: Visibility hidden attribute and fix x86/x86_64 tls/tds entry points

2015-09-25 Thread Sedat Dilek
Hi, unfortunately, we still have no cool upstream fix for -fvisibility=hidden compiler flag handling. There is still no visibility-attribute "hidden" available or defined. I see people again fell over this issue [2]. I have one concern... GCC uses "default" visibility-attribute (defined as PUBL

Re: [Mesa-dev] glx-tls: Visibility hidden attribute and fix x86/x86_64 tls/tds entry points

2015-09-25 Thread Sedat Dilek
On Sat, Sep 26, 2015 at 1:59 AM, Sedat Dilek wrote: > Hi, > > unfortunately, we still have no cool upstream fix for > -fvisibility=hidden compiler flag handling. > There is still no visibility-attribute "hidden" available or defined. > > I see people again fell over this issue [2]. > > I have one

[Mesa-dev] [Bug 92125] make check DispatchSanity_test.GL31_CORE regression

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92125 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

[Mesa-dev] ssbo support missing imin/umin dinstinction

2015-09-25 Thread Ilia Mirkin
Hi Samuel, It seems like there's only a single atomic_min intrinsic for ssbo (same for max), but the ssbo spec actually calls for both signed and unsigned semantics: uint atomicMin(inout uint mem, uint data); int atomicMin(inout int mem, int data); Should there be separate intrin

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92124 --- Comment #2 from Roland Scheidegger --- Yes, that function isn't even c99. It is used in a couple more places in mesa, but afaict in no code which is compiled with windows. -- You are receiving this mail because: You are the QA Contact for t

Re: [Mesa-dev] [PATCH V2 4/8] i965: Delete temporary variable 'src_pitch'

2015-09-25 Thread Chad Versace
On Wed 19 Aug 2015, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/intel_blit.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesk

Re: [Mesa-dev] [PATCH 0/9] cs: Add gl_NumWorkGroups

2015-09-25 Thread Kristian Høgsberg
Jordan Justen writes: > git://people.freedesktop.org/~jljusten/mesa cs-num-work-groups-v1 > http://patchwork.freedesktop.org/bundle/jljusten/cs-num-work-groups-v1 > > I recently sent a piglit patch for the ARB_compute_shader > indirect-compute test: "arb_compute_shader: Use gl_NumWorkGroups in >

Re: [Mesa-dev] [PATCH V3 8/8] i965: Rename intel_miptree_get_dimensions_for_image()

2015-09-25 Thread Anuj Phogat
On Fri, Sep 25, 2015 at 4:27 PM, Chad Versace wrote: > On Tue 22 Sep 2015, Anuj Phogat wrote: >> This function isn't specific to miptrees. So, drop the "miptree" >> from function name. >> >> V3: Add a comment explaining how the 1D Array texture height and >> depth is interpreted by Intel hardw

[Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-25 Thread Marek Olšák
From: Marek Olšák The spec doesn't require it. This fixes a crash on Android. Cc: 10.6 11.0 --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 1740ee3..7d8977e 100644 --

[Mesa-dev] [PATCH 1/2] st/dri: don't use _ctx in client_wait_sync

2015-09-25 Thread Marek Olšák
From: Marek Olšák Not needed and it can be NULL. Cc: 10.6 11.0 --- src/gallium/state_trackers/dri/dri2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 91b4431..ab940e4 100644 --- a/

Re: [Mesa-dev] [PATCH 0/3][RFC] Improve GLSL support of GL_ARB_separate_shader_objects

2015-09-25 Thread Ian Romanick
On 09/20/2015 01:15 PM, Gregory Hainaut wrote: > Current GLSL badly optimizes the code making it incompatible with the > GL_ARB_separate_shader_objects extension. > > Typical example of the current behavior: > > VS: > out SHADER > { > vec4 var_zero; // location will always be 0 > vec2 var

Re: [Mesa-dev] [PATCH] i965/gen9: Add a condition for starting pixel in fast copy blit

2015-09-25 Thread Chad Versace
On Mon 10 Aug 2015, Anuj Phogat wrote: > This condition restricts the use of fast copy blit to cases > where starting pixel of src and dst is oword (16 byte) aligned. > > Many piglit tests (if using fast copy blit in Mesa) failed earlier > because I missed adding this condition.Fast copy blit is c

Re: [Mesa-dev] [PATCH V3 8/8] i965: Rename intel_miptree_get_dimensions_for_image()

2015-09-25 Thread Chad Versace
On Tue 22 Sep 2015, Anuj Phogat wrote: > This function isn't specific to miptrees. So, drop the "miptree" > from function name. > > V3: Add a comment explaining how the 1D Array texture height and > depth is interpreted by Intel hardware. > > Cc: Chad Versace > Signed-off-by: Anuj Phogat >

Re: [Mesa-dev] [PATCH V3 2/8] i965: Use intel_get_tile_dims() to get tile masks

2015-09-25 Thread Chad Versace
On Mon 21 Sep 2015, Anuj Phogat wrote: > This will require change in the parameters passed to > intel_miptree_get_tile_masks(). > > V2: Rearrange the order of parameters. (Ben) > Change the name to intel_get_tile_masks(). (Topi) > > V3: Use temporary variables in intel_get_tile_masks() >

Re: [Mesa-dev] [PATCH V3 1/8] i965: Add a helper function intel_get_tile_dims()

2015-09-25 Thread Chad Versace
On Mon 21 Sep 2015, Anuj Phogat wrote: > V2: > - Do the tile width/height computations in the new helper > function and use it later in intel_miptree_get_tile_masks(). > - Change the name to intel_get_tile_dims(). > > V3: Return the tile_h in number of rows in place of bytes. > Document the

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92124 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

[Mesa-dev] [Bug 92125] make check DispatchSanity_test.GL31_CORE regression

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92125 Bug ID: 92125 Summary: make check DispatchSanity_test.GL31_CORE regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keyword

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92124 Bug ID: 92124 Summary: shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linu

[Mesa-dev] [Bug 86265] Error while running gazebo in ROS Hydro

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86265 Ian Romanick changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 0/9] cs: Add gl_NumWorkGroups

2015-09-25 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa cs-num-work-groups-v1 http://patchwork.freedesktop.org/bundle/jljusten/cs-num-work-groups-v1 I recently sent a piglit patch for the ARB_compute_shader indirect-compute test: "arb_compute_shader: Use gl_NumWorkGroups in global ID tests" These patches all

[Mesa-dev] [PATCH 2/9] i965/cs: Re-emit push constants and cs_state on new batches

2015-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen7_cs_state.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_cs_state.c b/src/mesa/drivers/dri/i965/gen7_cs_state.c index d9561cf..c53aa23 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 9/9] i965/cs: Generate code to load gl_NumWorkGroups

2015-09-25 Thread Jordan Justen
This code also sets cs_prog_data->uses_num_work_groups which is later used by state setup to indicate that the gl_NumWorkGroups surface needs to be setup. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 28 1 file changed, 28 insertions(+)

[Mesa-dev] [PATCH 1/9] mesa/cs: Add MESA_VERBOSE=api support in DispatchCompute*

2015-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/compute.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c index a0120cf..8bc3bcd 100644 --- a/src/mesa/main/compute.c +++ b/src/mesa/main/compute.c @@ -34,6 +34,10 @@ _mesa_DispatchCompute(

[Mesa-dev] [PATCH 6/9] i965/cs: Setup surface binding for gl_NumWorkGroups

2015-09-25 Thread Jordan Justen
This will only be setup when the prog_data uses_num_work_groups boolean is set. At this point nothing will set uses_num_work_groups, but soon code will set it when emitting code for the intrinsic that loads gl_NumWorkGroups. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_compute

[Mesa-dev] [PATCH 3/9] i965/cs: Re-emit cs_state when surfaces have changed

2015-09-25 Thread Jordan Justen
Unlike rendering (BINDING_TABLE_POINTERS_*S), compute doesn't have a binding table pointers command. Instead it is part of the MEDIA_INTERFACE_DESCRIPTOR structure loaded by the brw_cs_state atom. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen7_cs_state.c | 3 ++- 1 file changed,

[Mesa-dev] [PATCH 5/9] i965/cs: Add a binding table entry for gl_NumWorkGroups

2015-09-25 Thread Jordan Justen
If glDispatchComputeIndirect is used, then the value for this variable must be read from the indirect BO. To allow the same generated code to support indirect and glDispatchCompute, we will also setup a BO for the number of work groups using the intel_upload_data mechanism. This will only be requi

[Mesa-dev] [PATCH 8/9] nir: Convert SYSTEM_VALUE_NUM_WORK_GROUPS to a nir intrinsic

2015-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/nir/nir.c| 4 src/glsl/nir/nir_intrinsics.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 1206bb4..57fd959 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1487,6 +1487,8 @

[Mesa-dev] [PATCH 4/9] i965/cs: Store compute invocation information in brw context

2015-09-25 Thread Jordan Justen
We will need this in an atom to setup a surface to read the gl_NumWorkGroups values from. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_compute.c | 50 + src/mesa/drivers/dri/i965/brw_context.h | 11 2 files changed, 37 insertions(+), 24

[Mesa-dev] [PATCH 7/9] glsl/cs: Add gl_NumWorkGroups as a system value

2015-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 +- src/glsl/shader_enums.h| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 0722051..a6ad105 100644 --- a/src/glsl/builtin_variable

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Michel Dänzer changed: What|Removed |Added CC||lem...@gmail.com -- You are receiving t

[Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Sedat Dilek
$ make distclean ... Making distclean in . make[2]: Entering directory `/home/wearefam/src/mesa/mesa-git/src' Makefile:545: mesa/main/.deps/imports.Plo: No such file or directory Makefile:546: mesa/program/.deps/dummy_errors.Plo: No such file or directory Makefile:547: mesa/program/.deps/prog_hash_

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Crisan, Alex
Sure Mark, I will work with Kaveh on the next steps. Is it safe to assume these tests will be buggy on any platforms? -Original Message- From: Janes, Mark A Sent: Friday, September 25, 2015 7:41 AM To: Eduardo Lima Mitev; mesa-dev@lists.freedesktop.org Cc: Eduardo Lima Mitev; ja...@jleks

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Sedat Dilek
On Fri, Sep 25, 2015 at 3:32 PM, Emil Velikov wrote: > Hi Sedat, > > On 25 September 2015 at 11:53, Sedat Dilek wrote: >> $ make distclean >> ... >> Making distclean in . >> make[2]: Entering directory `/home/wearefam/src/mesa/mesa-git/src' >> Makefile:545: mesa/main/.deps/imports.Plo: No such fi

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Sedat Dilek
On Fri, Sep 25, 2015 at 4:44 PM, Emil Velikov wrote: > On 25 September 2015 at 14:35, Sedat Dilek wrote: >> On Fri, Sep 25, 2015 at 3:32 PM, Emil Velikov >> wrote: >>> Hi Sedat, >>> >>> On 25 September 2015 at 11:53, Sedat Dilek wrote: $ make distclean ... Making distclean in .

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #1 from Daniel Scharrer --- Created attachment 118451 --> https://bugs.freedesktop.org/attachment.cgi?id=118451&action=edit Expected rendering -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Daniel Scharrer changed: What|Removed |Added Attachment #118450|text/plain |image/jpeg mime type|

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Bug ID: 92122 Summary: [bisected] Regression with Assault Android Cactus Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-09-25 Thread Matt Turner
On Mon, Aug 10, 2015 at 9:16 AM, Matt Turner wrote: > On Fri, Aug 7, 2015 at 10:09 AM, Ian Romanick wrote: >> I know we've talked about this about 100 times, but something in the >> back of my mind tells me that we have a pre-existing race. What happens >> if the p_atomic_dec_zero happens on thr

Re: [Mesa-dev] [PATCH 05/13] mesa: Replace buffer object locks with atomic inc/dec.

2015-09-25 Thread Matt Turner
On Fri, Aug 7, 2015 at 9:41 AM, Ian Romanick wrote: > So... the buffer object isn't locked during a call to glBufferData? > Since that allocates the backing storage for the BO, it doesn't seem > like anything good could happen... Indeed, that's the case. Is there anything for us to do though? I'm

Re: [Mesa-dev] [PATCH 1/5] i965/miptree: More comments for BRW_MAP_DIRECT_BIT

2015-09-25 Thread Chad Versace
On Fri 25 Sep 2015, Anuj Phogat wrote: > On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote: > > Clarify that this bit extends the set of GL_MAP_*_BIT enums. > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/mesa/drive

[Mesa-dev] [PATCH] i965/miptree: Rename intel_miptree_map::mt -> ::linear_mt (v2)

2015-09-25 Thread Chad Versace
Because that's what it is. It's an untiled, *linear* miptree. v2: - Add space after /*. - Use one comment per function argument. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- 2 files changed, 16 inser

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-25 Thread Marek Olšák
Guys, can you please try these patches? They should fix it for gallium drivers (not i965). Marek On Fri, Sep 25, 2015 at 10:35 PM, Marek Olšák wrote: > On Fri, Sep 25, 2015 at 5:43 PM, Chih-Wei Huang > wrote: >> CC to mesa-dev for help. >> >> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >>> 201

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-25 Thread Marek Olšák
On Fri, Sep 25, 2015 at 5:43 PM, Chih-Wei Huang wrote: > CC to mesa-dev for help. > > 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >> 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >>> Actually I'm testing your mesa 11.0 branch >>> to see if it is acceptable. >>> The major issue I found is the >>> Cam

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

2015-09-25 Thread Kyle Brenneman
Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

[Mesa-dev] [PATCH] radeon/vce: fix vui time_scale zero error

2015-09-25 Thread Leo Liu
if app pass 0 as frame_rate_num, it should not be encoded to the VUI. Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Reviewed-by: Christian König Cc: "10.6 11.0" --- src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH 1/5] i965/miptree: More comments for BRW_MAP_DIRECT_BIT

2015-09-25 Thread Anuj Phogat
On Fri, Sep 25, 2015 at 12:44 PM, Anuj Phogat wrote: > On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote: >> Clarify that this bit extends the set of GL_MAP_*_BIT enums. >> --- >> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/m

Re: [Mesa-dev] [PATCH 1/5] i965/miptree: More comments for BRW_MAP_DIRECT_BIT

2015-09-25 Thread Anuj Phogat
On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote: > Clarify that this bit extends the set of GL_MAP_*_BIT enums. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > b/src/mesa/drivers

Re: [Mesa-dev] [PATCH 3/5] i965/miptree: Rename intel_miptree_map::mt -> ::linear_mt

2015-09-25 Thread Matt Turner
On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote: > Because that's what it is. It's an untiled, *linear* miptree. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 27 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- > 2 files changed, 15 insertion

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v2)

2015-09-25 Thread Kyle Brenneman
On 09/25/2015 11:58 AM, Ilia Mirkin wrote: On Fri, Sep 25, 2015 at 1:47 PM, Kyle Brenneman wrote: Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard

[Mesa-dev] [PATCH 3/5] i965/miptree: Rename intel_miptree_map::mt -> ::linear_mt

2015-09-25 Thread Chad Versace
Because that's what it is. It's an untiled, *linear* miptree. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 27 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_

[Mesa-dev] [PATCH 5/5] i965/miptree: Add PRM references for most struct members

2015-09-25 Thread Chad Versace
Add comments that link the driver's miptree structures to the hardware structures documented in the PRM. This provides sorely needed orientation to developers new to the miptree code. And for miptree veterans, this clarifies some of the more obscure miptree data. For each driver struct field that

[Mesa-dev] [PATCH 0/5] i965/miptree: Improved comments and minor cleanups

2015-09-25 Thread Chad Versace
Conversations with Ken encouraged me to begin cleaning up and documenting the miptree code. This patch series will likely be the first of many. Chad Versace (5): i965/miptree: More comments for BRW_MAP_DIRECT_BIT i965/miptree: Fix comments for map mode i965/miptree: Rename intel_miptree_map:

[Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

2015-09-25 Thread Chad Versace
The values of intel_mipmap_tree::align_w and ::align_h correspond to the hardware enums HALIGN_* and VALIGN_*. See the confusion? align_h != HALIGN align_h == VALIGN Reduce the confusion by renaming the variables to match the hardware enum names: git ls-files | xargs sed -i -e 's/

[Mesa-dev] [PATCH 1/5] i965/miptree: More comments for BRW_MAP_DIRECT_BIT

2015-09-25 Thread Chad Versace
Clarify that this bit extends the set of GL_MAP_*_BIT enums. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index c28162a..a65dae9 100644 --- a/sr

[Mesa-dev] [PATCH 2/5] i965/miptree: Fix comments for map mode

2015-09-25 Thread Chad Versace
The comment for intel_miptree_map::mode claimed that it was a bitmask of GL_MAP_{READ,WRITE,INVALIDATE}_BIT. In reality, the bitmask may include any of {GL,BRW}_MAP_*_BIT. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Jason Ekstrand
On Fri, Sep 25, 2015 at 9:06 AM, Crisan, Alex wrote: > Sure Mark, I will work with Kaveh on the next steps. Is it safe to assume > these tests will be buggy on any platforms? Yes. The test is testing for GL API errors and its behavior should be completely independent of platform. --Jason > ---

Re: [Mesa-dev] [PATCH 1/2] i965/gs: Allow src0 immediates in GS_OPCODE_SET_WRITE_OFFSET.

2015-09-25 Thread Matt Turner
On Fri, Sep 25, 2015 at 11:10 AM, Kenneth Graunke wrote: > On Friday, September 25, 2015 11:03:46 AM Matt Turner wrote: >> On Fri, Sep 25, 2015 at 10:47 AM, Kenneth Graunke >> wrote: >> > GS_OPCODE_SET_WRITE_OFFSET is a MUL with a constant src[1] and special >> > strides. We can easily make the

Re: [Mesa-dev] [PATCH 2/2] i965/gs: Optimize away the EOT write on Gen8+ with static vertex count.

2015-09-25 Thread Kenneth Graunke
On Friday, September 25, 2015 11:06:32 AM Matt Turner wrote: > On Fri, Sep 25, 2015 at 10:47 AM, Kenneth Graunke > wrote: > > With static vertex counts, the final EOT write doesn't actually write > > any data - it's just there to end the thread. Typically, the last > > thing before ending the th

Re: [Mesa-dev] [PATCH 1/2] i965/gs: Allow src0 immediates in GS_OPCODE_SET_WRITE_OFFSET.

2015-09-25 Thread Kenneth Graunke
On Friday, September 25, 2015 11:03:46 AM Matt Turner wrote: > On Fri, Sep 25, 2015 at 10:47 AM, Kenneth Graunke > wrote: > > GS_OPCODE_SET_WRITE_OFFSET is a MUL with a constant src[1] and special > > strides. We can easily make the generator handle constant src[0] > > arguments by instead gener

Re: [Mesa-dev] [PATCH 2/2] i965/gs: Optimize away the EOT write on Gen8+ with static vertex count.

2015-09-25 Thread Matt Turner
On Fri, Sep 25, 2015 at 10:47 AM, Kenneth Graunke wrote: > With static vertex counts, the final EOT write doesn't actually write > any data - it's just there to end the thread. Typically, the last > thing before ending the thread will be an EmitVertex() call, resulting > in a URB write. We can j

Re: [Mesa-dev] [PATCH 1/2] i965/gs: Allow src0 immediates in GS_OPCODE_SET_WRITE_OFFSET.

2015-09-25 Thread Matt Turner
On Fri, Sep 25, 2015 at 10:47 AM, Kenneth Graunke wrote: > GS_OPCODE_SET_WRITE_OFFSET is a MUL with a constant src[1] and special > strides. We can easily make the generator handle constant src[0] > arguments by instead generating a MOV with the product of both operands. > > This isn't necessaril

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v2)

2015-09-25 Thread Ilia Mirkin
On Fri, Sep 25, 2015 at 1:47 PM, Kyle Brenneman wrote: > Add a macro GL_LIB_NAME to hold the filename that configure comes up with > based on the --with-gl-lib-name and --enable-mangling options. > > In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding > "libGL.so.1". > > v2: Add an

[Mesa-dev] [PATCH 2/2] i965/gs: Optimize away the EOT write on Gen8+ with static vertex count.

2015-09-25 Thread Kenneth Graunke
With static vertex counts, the final EOT write doesn't actually write any data - it's just there to end the thread. Typically, the last thing before ending the thread will be an EmitVertex() call, resulting in a URB write. We can just set EOT on that. Note that this isn't always possible - there

[Mesa-dev] [PATCH 1/2] i965/gs: Allow src0 immediates in GS_OPCODE_SET_WRITE_OFFSET.

2015-09-25 Thread Kenneth Graunke
GS_OPCODE_SET_WRITE_OFFSET is a MUL with a constant src[1] and special strides. We can easily make the generator handle constant src[0] arguments by instead generating a MOV with the product of both operands. This isn't necessarily a win in and of itself - instead of a MUL, we generate a MOV, whi

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v2)

2015-09-25 Thread Kyle Brenneman
Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

Re: [Mesa-dev] [PATCH] radeon/vce: fix vui time_scale zero error

2015-09-25 Thread Alex Deucher
On Wed, Sep 23, 2015 at 3:57 PM, Leo Liu wrote: > if app pass 0 as frame_rate_num, it should not be encoded to the VUI. > > Signed-off-by: Leo Liu > Reviewed-by: Alex Deucher > Reviewed-by: Christian König > Cc: "10.6" 11.0 should be cc'ed as well. Alex > --- > src/gallium/drivers/radeon/r

[Mesa-dev] memoryBarrier + SSBO

2015-09-25 Thread Ilia Mirkin
Hi Ian (and other spec experts), The ARB_ssbo spec mentions the following: OpenGL 4.0 (either core or compatibility profile) is required. ... Additionally, the shading language provides the memoryBarrier() function to control the relative order of memory accesses within individual s

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver.

2015-09-25 Thread Ilia Mirkin
This will break non-autoconf builds... how about #ifndef GL_LIB_NAME #define GL_LIB_NAME "libGL.so.1"? On Fri, Sep 25, 2015 at 12:43 PM, Kyle Brenneman wrote: > Add a macro GL_LIB_NAME to hold the filename that configure comes up with > based on the --with-gl-lib-name and --enable-mangling option

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Ilia Mirkin
This happens when you rename a file between .c and .cpp -- the destination object stays the same, and so the deps don't get regenerated. Or something. I fix this by hand-editing the Plo file to flip from .c to .cpp or vice-versa. On Fri, Sep 25, 2015 at 12:46 PM, Emil Velikov wrote: > On 25 Septe

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Emil Velikov
On 25 September 2015 at 16:14, Sedat Dilek wrote: > On Fri, Sep 25, 2015 at 4:44 PM, Emil Velikov > wrote: >> On 25 September 2015 at 14:35, Sedat Dilek wrote: >>> On Fri, Sep 25, 2015 at 3:32 PM, Emil Velikov >>> wrote: Hi Sedat, On 25 September 2015 at 11:53, Sedat Dilek wro

Re: [Mesa-dev] [PATCH 4/6] main/tests: Enable glShaderStorageBlockBinding() check in dispatch_sanity test

2015-09-25 Thread Matt Turner
Reviewed-by: Matt Turner Please commit this one as soon as possible. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver.

2015-09-25 Thread Kyle Brenneman
Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". --- src/glx/Makefile.am | 1 + src/glx/dri_common.c | 2 +- 2 files changed, 2

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-25 Thread Emil Velikov
On 25 September 2015 at 17:24, Rob Clark wrote: > On Fri, Sep 25, 2015 at 11:43 AM, Chih-Wei Huang > wrote: >> CC to mesa-dev for help. >> >> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >>> 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : Actually I'm testing your mesa 11.0 branch to see if

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-25 Thread Rob Clark
On Fri, Sep 25, 2015 at 11:43 AM, Chih-Wei Huang wrote: > CC to mesa-dev for help. > > 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >> 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >>> Actually I'm testing your mesa 11.0 branch >>> to see if it is acceptable. >>> The major issue I found is the >>> Ca

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-25 Thread Chih-Wei Huang
CC to mesa-dev for help. 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >> Actually I'm testing your mesa 11.0 branch >> to see if it is acceptable. >> The major issue I found is the >> Camera and Youtube crashing in mesa. > > OK, I can almost confirm thi

Re: [Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

2015-09-25 Thread Ilia Mirkin
On Fri, Sep 25, 2015 at 10:34 AM, Hans de Goede wrote: > Hi, > > On 11-09-15 18:48, Ilia Mirkin wrote: >> >> On Fri, Sep 11, 2015 at 10:46 AM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> I've been working on trying to fix this one: >>> >>> https://bugs.freedesktop.org/show_bug.cgi?id=90871 >>> >>

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Emil Velikov
On 25 September 2015 at 14:35, Sedat Dilek wrote: > On Fri, Sep 25, 2015 at 3:32 PM, Emil Velikov > wrote: >> Hi Sedat, >> >> On 25 September 2015 at 11:53, Sedat Dilek wrote: >>> $ make distclean >>> ... >>> Making distclean in . >>> make[2]: Entering directory `/home/wearefam/src/mesa/mesa-gi

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Mark Janes
This patch series fixes a few dEQP tests on braswell. The rest of the platform are unaffected, according to my tests. deqp-gles2.functional.negative_api.texture.teximage2d_invalid_type deqp-gles2.functional.negative_api.texture.teximage2d_invalid_internalformat deqp-gles3.functional.negative_api.

Re: [Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

2015-09-25 Thread Hans de Goede
Hi, On 11-09-15 18:48, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 10:46 AM, Hans de Goede wrote: Hi, I've been working on trying to fix this one: https://bugs.freedesktop.org/show_bug.cgi?id=90871 And today I've more or less root caused this, it seems that some code is making glTexImage2D c

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-25 Thread Jose Fonseca
On 24/09/15 19:01, Marek Olšák wrote: On Wed, Sep 2, 2015 at 12:55 AM, Jose Fonseca wrote: I'm all for TGIS simplification, but I just checked, and we rely on TGSI predicates for some of our internal state trackers. So I'll need more time to evaluate how much effort it would be to not rely on

Re: [Mesa-dev] [PATCH 1/2] gallivm: Allow drivers and state trackers to initialize gallivm LLVM targets

2015-09-25 Thread Tom Stellard
On Thu, Sep 24, 2015 at 10:48:32PM +0100, Emil Velikov wrote: > Hi Tom, > > On 24 September 2015 at 17:31, Tom Stellard wrote: > > Drivers and state trackers that use LLVM for generating code, must > > register the targets they use with LLVM's global TargetRegistry. > > The TargetRegistry is not

Re: [Mesa-dev] [PATCH 2/2] radeon/llvm: Initialize gallivm targets when initializing the AMDGPU target

2015-09-25 Thread Tom Stellard
On Fri, Sep 25, 2015 at 02:19:53PM +0200, Marek Olšák wrote: > On Thu, Sep 24, 2015 at 6:32 PM, Tom Stellard wrote: > > This fixes a race condition in the glx-multithreaded-shader-compile > > test. > > > > CC: "10.6 11.0" > > --- > > src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ > > 1 f

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

2015-09-25 Thread Emil Velikov
Hi Sedat, On 25 September 2015 at 11:53, Sedat Dilek wrote: > $ make distclean > ... > Making distclean in . > make[2]: Entering directory `/home/wearefam/src/mesa/mesa-git/src' > Makefile:545: mesa/main/.deps/imports.Plo: No such file or directory > Makefile:546: mesa/program/.deps/dummy_errors.

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

2015-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #27 from Albert Freeman --- (In reply to Krzysztof A. Sobiecki from comment #26) > Trace from wayland/Xwayland: > https://drive.google.com/file/d/0B3J0Mg89izcbR1BHWXEwREJhY00/view?usp=sharing > > It shows only dark screen in menu. T

Re: [Mesa-dev] [PATCH 2/2] radeon/llvm: Initialize gallivm targets when initializing the AMDGPU target

2015-09-25 Thread Marek Olšák
On Thu, Sep 24, 2015 at 6:32 PM, Tom Stellard wrote: > This fixes a race condition in the glx-multithreaded-shader-compile > test. > > CC: "10.6 11.0" > --- > src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/radeon/rade

[Mesa-dev] [PATCH 5/6] glsl: apply shader storage block member rules when adding program resources

2015-09-25 Thread Samuel Iglesias Gonsalvez
From ARB_program_interface_query: "For an active shader storage block member declared as an array, an entry will be generated only for the first array element, regardless of its type. For arrays of aggregate types, the enumeration rules are applied recursively for the single enumerated array el

[Mesa-dev] [PATCH 6/6] docs: mention ARB_shader_storage_buffer_object on 11.1.0 release notes

2015-09-25 Thread Samuel Iglesias Gonsalvez
Signed-off-by: Samuel Iglesias Gonsalvez --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index e28fab6..c755c98 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -45,6 +45,7 @@ Note: so

[Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

2015-09-25 Thread Samuel Iglesias Gonsalvez
NumUniformBlocks also counts shader storage blocks. NumUniformBlocks variable will be renamed in a later patch to avoid misunderstandings. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shaderapi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 2/6] mesa: rename gl_shader_program's NumUniformBlocks to NumUniformShaderStorageBlocks

2015-09-25 Thread Samuel Iglesias Gonsalvez
Because it counts shader storage blocks too. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/link_uniform_initializers.cpp | 2 +- src/glsl/link_uniforms.cpp | 4 ++-- src/glsl/linker.cpp| 10 +- src/glsl/standalone_scaffold

[Mesa-dev] [PATCH 3/6] glsl: return the number of uniform blocks in error message

2015-09-25 Thread Samuel Iglesias Gonsalvez
Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index d6a62bf..be04f5b 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2836,7 +2836,7 @@ check_resources(st

[Mesa-dev] [PATCH 4/6] main/tests: Enable glShaderStorageBlockBinding() check in dispatch_sanity test

2015-09-25 Thread Samuel Iglesias Gonsalvez
Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/tests/dispatch_sanity.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index 0ddda59..b19c6d7 100644 --- a/src/mesa/main/tests/dispa

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

2015-09-25 Thread Samuel Iglesias Gonsálvez
On 25/09/15 09:19, Ilia Mirkin wrote: > On Fri, Sep 25, 2015 at 3:17 AM, Samuel Iglesias Gonsálvez > wrote: >> On 21/09/15 12:39, Iago Toral wrote: >>> Hi Kristian, >>> >>> On Fri, 2015-09-18 at 16:56 -0700, Kristian Høgsberg wrote: On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiro

Re: [Mesa-dev] [PATCH] glsl: fix packed varyings interface type and add default case

2015-09-25 Thread Ilia Mirkin
On Fri, Sep 25, 2015 at 3:28 AM, Tapani Pälli wrote: > fixes Piglit test: >arb_program_interface_query/linker/query-varyings.shader_test > > Signed-off-by: Tapani Pälli Reviewed-by: Ilia Mirkin > --- > src/glsl/linker.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gl

[Mesa-dev] [PATCH] glsl: fix packed varyings interface type and add default case

2015-09-25 Thread Tapani Pälli
fixes Piglit test: arb_program_interface_query/linker/query-varyings.shader_test Signed-off-by: Tapani Pälli --- src/glsl/linker.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 53e276c..ab54e11 100644 --- a/src/glsl/linker.cpp +++ b/

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

2015-09-25 Thread Ilia Mirkin
On Fri, Sep 25, 2015 at 3:17 AM, Samuel Iglesias Gonsálvez wrote: > On 21/09/15 12:39, Iago Toral wrote: >> Hi Kristian, >> >> On Fri, 2015-09-18 at 16:56 -0700, Kristian Høgsberg wrote: >>> On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: Hi, this is the latest v

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

2015-09-25 Thread Samuel Iglesias Gonsálvez
On 21/09/15 12:39, Iago Toral wrote: > Hi Kristian, > > On Fri, 2015-09-18 at 16:56 -0700, Kristian Høgsberg wrote: >> On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: >>> Hi, >>> >>> this is the latest version of the ARB_shader_storage_buffer_object >>> implementation. A good p