Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Iago Toral
On Wed, 2015-10-14 at 16:18 +0300, Francisco Jerez wrote: > "Lofstedt, Marta" writes: > > > I have found a couple of more places in linker.cpp where we loop up to > > MESA_SHADER_FRAGMENT. > > Should these now also be up to MESA_SHADER_COMPUTE instead? > > > Some might be oversights like this, b

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-14 Thread Iago Toral
On Wed, 2015-10-14 at 11:08 -0700, Jordan Justen wrote: > On 2015-10-13 22:49:08, Iago Toral wrote: > > On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote: > > > On 2015-10-13 05:17:37, Francisco Jerez wrote: > > > > Iago Toral Quiroga writes: > > > > > > > > > This fixes the following test:

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-14 Thread Belal, Awais
Thanks a lot Brian. BR, Awais From: Brian Paul [bri...@vmware.com] Sent: Wednesday, October 14, 2015 7:19 PM To: Belal, Awais; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang I

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

2015-10-14 Thread Samuel Iglesias Gonsálvez
On 15/10/15 05:43, Timothy Arceri wrote: > On Fri, 2015-10-09 at 13:33 +0200, Samuel Iglesias Gonsálvez wrote: >> >> On 09/10/15 13:25, Timothy Arceri wrote: >>> On Thu, 2015-10-08 at 11:08 +0200, Samuel Iglesias Gonsálvez wrote: On 07/10/15 00:47, Timothy Arceri wrote: > From Section 4.

Re: [Mesa-dev] [PATCH v2 12/17] i965/vs: Rework vs_emit to take a nir_shader and a brw_compiler

2015-10-14 Thread Pohjolainen, Topi
On Wed, Oct 14, 2015 at 11:53:37AM -0700, Jason Ekstrand wrote: > On Wed, Oct 14, 2015 at 1:41 AM, Pohjolainen, Topi > wrote: > > On Wed, Oct 14, 2015 at 11:25:40AM +0300, Pohjolainen, Topi wrote: > >> On Sat, Oct 10, 2015 at 08:09:01AM -0700, Jason Ekstrand wrote: > >> > This commit removes all d

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

2015-10-14 Thread Timothy Arceri
On Fri, 2015-10-09 at 13:33 +0200, Samuel Iglesias Gonsálvez wrote: > > On 09/10/15 13:25, Timothy Arceri wrote: > > On Thu, 2015-10-08 at 11:08 +0200, Samuel Iglesias Gonsálvez wrote: > > > On 07/10/15 00:47, Timothy Arceri wrote: > > > > From Section 4.1.9 of the GLSL ES 3.10 spec: > > > > > >

[Mesa-dev] [PATCH] glsl: initialise record count to 1

2015-10-14 Thread Timothy Arceri
This was only being done in one of the two process methods. Fixes issue with samplers using the array size of a previous record. Cc: Marek Olšák Cc: Jason Ekstrand --- src/glsl/link_uniforms.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_unif

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #17 from Eduardo Lima Mitev --- I just sent for review a piglit test that checks that the combination of internalFormat=GL_BGRA_EXT, format=GL_BGRA_EXT and type=GL_UNSIGNED_BYTE is valid on TexImageXD and TexSubImageXD, as specified b

[Mesa-dev] [PATCH] mesa: Improve handling of GL_BGRA format in es3 format_and_type checks

2015-10-14 Thread Eduardo Lima Mitev
We recently added support for GL_BGRA internal format when validating combination of format+type+internal_format in Tex(Sub)ImageXD calls (to fix https://bugs.freedesktop.org/show_bug.cgi?id=92265). However, the current implementation handles it as a special case when obtaining the effective inter

Re: [Mesa-dev] [PATCH 02/10] mesa: short-cut new_state == _NEW_LINE in _mesa_update_state_locked()

2015-10-14 Thread Eric Anholt
Brian Paul writes: > We can skip to the end of _mesa_update_state_locked() if only the > _NEW_LINE flag is set since none of the derived state depends on it > (just like _NEW_CURRENT_ATTRIB). Note that we still call the > ctx->Driver.UpdateState() function, of course. > --- > src/mesa/main/stat

Re: [Mesa-dev] [PATCH 07/10] mesa: fix incorrect error string in _mesa_BlendEquationiARB()

2015-10-14 Thread Eric Anholt
Brian Paul writes: > --- > src/mesa/main/blend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c > index d225f3d..f14949f 100644 > --- a/src/mesa/main/blend.c > +++ b/src/mesa/main/blend.c > @@ -407,7 +407,7 @@ _mesa_BlendEqu

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-14 Thread Michel Thierry
On 10/14/2015 8:19 AM, Daniel Vetter wrote: On Tue, Oct 13, 2015 at 02:51:36PM -0700, Kristian Høgsberg wrote: On Tue, Oct 13, 2015 at 7:55 AM, Michel Thierry wrote: On 10/13/2015 3:13 PM, Emil Velikov wrote: On 13 October 2015 at 13:16, Michel Thierry wrote: On 10/6/2015 2:12 PM, Michel

[Mesa-dev] [PATCH shader-db v2 1/2] docs: Improve dependencies documentation

2015-10-14 Thread Rhys Kidd
v2: Reflect feedback from Kenneth Graunke and Matt Turner Signed-off-by: Rhys Kidd --- README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/README b/README index e301d0e..2f83987 100644 --- a/README +++ b/README @@ -49,6 +49,12 @@ ST_DEBUG=precompile R600_DEBUG=ps,vs,gs,precomp

[Mesa-dev] [PATCH shader-db v2 2/2] docs: Add symbolic link generation step

2015-10-14 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- README | 5 + 1 file changed, 5 insertions(+) diff --git a/README b/README index 2f83987..cfbc362 100644 --- a/README +++ b/README @@ -55,6 +55,11 @@ Install necessary dependencies on Debian or Ubuntu: sudo apt-get install build-essentials libepoxy-dev libgbm-de

Re: [Mesa-dev] [PATCH shader-db 3/3] docs: Add symbolic link generation step

2015-10-14 Thread Rhys Kidd
On 13 October 2015 at 08:54, Matt Turner wrote: > On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > > Signed-off-by: Rhys Kidd > > --- > > README | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/README b/README > > index 6ed3244..03be4e7 100644 > > --- a/README > > +++ b/

Re: [Mesa-dev] [PATCH 00/10] Support Skylake MCS buffers (fast clears)

2015-10-14 Thread Ben Widawsky
On Tue, Oct 13, 2015 at 08:50:17PM -0700, Ben Widawsky wrote: > This patch series adds support for fast color clears on SKL as it exists on > previous generations of hardware minus the new hardware restriction on surface > formats. Additionally, it adds support for utilizing clear values with up to

[Mesa-dev] [PATCH 08/10] mesa: optimize _UsesDualSrc blend flag setting

2015-10-14 Thread Brian Paul
For glBlendFunc and glBlendFuncSeparate(), the _UsesDualSrc flag will be the same for all buffers, so no need to compute it N times. --- src/mesa/main/blend.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index f14949f..6e27

[Mesa-dev] [PATCH 10/10] mesa: wrap a ridiculously long line in es1_conversion.c

2015-10-14 Thread Brian Paul
--- src/mesa/main/es1_conversion.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/es1_conversion.c b/src/mesa/main/es1_conversion.c index b254a6e..1dfe827 100644 --- a/src/mesa/main/es1_conversion.c +++ b/src/mesa/main/es1_conversion.c @@ -1,

[Mesa-dev] [PATCH 03/10] mesa: optimize no-change check in _mesa_BlendFuncSeparate()

2015-10-14 Thread Brian Paul
Streamline the checking for no state change in _mesa_BlendFuncSeparate() (and _mesa_BlendFunc()). If _BlendFuncPerBuffer is false, we only need to check the 0th buffer state. Move argument validation after the no-op check. I'm looking at an app that issues about 1000 redundant glBlendFunc() call

[Mesa-dev] [PATCH 09/10] mesa: add num_buffers() helper in blend.c

2015-10-14 Thread Brian Paul
--- src/mesa/main/blend.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 6e27cf9..ccbac75 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -190,6 +190,19 @@ update_uses

[Mesa-dev] [PATCH 05/10] mesa: optimize no-change check in _mesa_BlendEquationSeparate()

2015-10-14 Thread Brian Paul
--- src/mesa/main/blend.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 01b6919..14742d0 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -432,7 +432,7 @@ void GLA

[Mesa-dev] [PATCH 07/10] mesa: fix incorrect error string in _mesa_BlendEquationiARB()

2015-10-14 Thread Brian Paul
--- src/mesa/main/blend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index d225f3d..f14949f 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -407,7 +407,7 @@ _mesa_BlendEquationiARB(GLuint buf, GLenum mode)

[Mesa-dev] [PATCH 06/10] mesa: move validate_blend_factors() call after no-change check

2015-10-14 Thread Brian Paul
A redundant call to glBlendFuncSeparateiARB() is more likely than getting invalid values, so do the no-op check first. --- src/mesa/main/blend.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 14742d0..d225f3d 100

[Mesa-dev] [PATCH 01/10] mesa: remove FLUSH_VERTICES() in _mesa_MatrixMode()

2015-10-14 Thread Brian Paul
Changing the matrix mode alone has no effect on rendering and does not need to trigger a flush or state validation. --- src/mesa/main/matrix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/matrix.c b/src/mesa/main/matrix.c index 2b8016a..5ff5ac5 100644 --- a/src/mesa/main/matrix

[Mesa-dev] [PATCH 02/10] mesa: short-cut new_state == _NEW_LINE in _mesa_update_state_locked()

2015-10-14 Thread Brian Paul
We can skip to the end of _mesa_update_state_locked() if only the _NEW_LINE flag is set since none of the derived state depends on it (just like _NEW_CURRENT_ATTRIB). Note that we still call the ctx->Driver.UpdateState() function, of course. --- src/mesa/main/state.c | 3 ++- 1 file changed, 2 in

[Mesa-dev] [PATCH 04/10] mesa: optimize no-change check in _mesa_BlendEquation()

2015-10-14 Thread Brian Paul
Same story as preceeding change to _mesa_BlendFuncSeparate(). --- src/mesa/main/blend.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 98d2858..01b6919 100644 --- a/src/mesa/main/blend.c

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-14 Thread Christian Gmeiner
2015-10-14 14:51 GMT+02:00 Erik Faye-Lund : > On Sun, Oct 11, 2015 at 5:09 PM, Christian Gmeiner > wrote: >> @@ -2181,6 +2188,13 @@ if test -n "$with_gallium_drivers"; then >> done >> fi >> >> +dnl We need to validate some needed dependencies for renderonly drivers. >> + >> +if test "x$HAVE_

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-14 Thread Christian Gmeiner
2015-10-14 5:58 GMT+02:00 Michel Dänzer : > On 13.10.2015 12:44, Alexandre Courbot wrote: >> On Mon, Oct 12, 2015 at 12:09 AM, Christian Gmeiner >> wrote: >>> >>> diff --git a/src/gallium/winsys/tegra/drm/tegra_drm_winsys.c >>> b/src/gallium/winsys/tegra/drm/tegra_drm_winsys.c >>> new file mode 1

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-14 Thread Christian Gmeiner
Hi 2015-10-13 5:44 GMT+02:00 Alexandre Courbot : > On Mon, Oct 12, 2015 at 12:09 AM, Christian Gmeiner > wrote: >> This commit adds tegra support, which uses the renderonly driver >> library. >> >> Signed-off-by: Christian Gmeiner >> --- >> configure.ac | 1

[Mesa-dev] [PATCH v2] i965/vec4: Add unit tests for cmod propagation pass

2015-10-14 Thread Alejandro Piñeiro
This include the same tests coming from test_fs_cmod_propagation, (non vector glsl types included) plus some new with vec4 types, inspired on the regressions found while the optimization was a work in progress. Additionally, the check of number of instructions after the optimization was changed fr

[Mesa-dev] [PATCH] i965/vec4: dead_code_eliminate: update writemask on null_regs based on flag_live

2015-10-14 Thread Alejandro Piñeiro
--- This patch implements the idea proposed by Francisco Jerez. With this change, even adding the new condition pointed by Matt Turner on the "2/5 i965/vec4: adding vec4_cmod_propagation optimization", the shader-db numbers remain the same. So this patch would go before the optimization (so in thi

[Mesa-dev] [PATCH] main: Match DispatchCompute* API validation from main specification

2015-10-14 Thread Jordan Justen
There is a discrepancy between the ARB_compute_shader specification, and the OpenGL 4.3 and OpenGLES 3.1 specifications. With regards to the indirect dispatch parameter, unsupported value errors should return INVALID_VALUE according to the main specifications, whereas the extension specification in

[Mesa-dev] [PATCH] configure: show which gallium drivers/sts are built

2015-10-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- configure.ac | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 217281f..7112e43 100644 --- a/configure.ac +++ b/configure.ac @@ -1576,6 +1576,8 @@ fi AM_CONDITIONAL(HAVE_EGL, test "x$enable_egl" = xye

Re: [Mesa-dev] [PATCH] st/fbo: use pipe_surface_release instead of pipe_surface_reference

2015-10-14 Thread Roland Scheidegger
Am 14.10.2015 um 18:03 schrieb Krzysztof A. Sobiecki: > From: Krzysztof Sobiecki > > pipe_surface_reference have problems with deleted contexts, > so use of pipe_surface_release might be more appropriate. > > Fixes Wasteland 2 Director's Cut crash on start. > --- > src/mesa/state_tracker/st_cb_

[Mesa-dev] [PATCH] st/omx/dec/h264: fix field picture type 0 poc disorder

2015-10-14 Thread Leo Liu
Signed-off-by: Leo Liu Cc: "10.6 11.0" --- src/gallium/state_trackers/omx/vid_dec_h264.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c b/src/gallium/state_trackers/omx/vid_dec_h264.c index 18d8803..f66ed89 100644 -

Re: [Mesa-dev] [PATCH v2 12/17] i965/vs: Rework vs_emit to take a nir_shader and a brw_compiler

2015-10-14 Thread Jason Ekstrand
On Wed, Oct 14, 2015 at 1:41 AM, Pohjolainen, Topi wrote: > On Wed, Oct 14, 2015 at 11:25:40AM +0300, Pohjolainen, Topi wrote: >> On Sat, Oct 10, 2015 at 08:09:01AM -0700, Jason Ekstrand wrote: >> > This commit removes all dependence on GL state by getting rid of the >> > brw_context parameter and

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-14 Thread Francisco Jerez
Jordan Justen writes: > On 2015-10-13 22:49:08, Iago Toral wrote: >> On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote: >> > On 2015-10-13 05:17:37, Francisco Jerez wrote: >> > > Iago Toral Quiroga writes: >> > > >> > > > This fixes the following test: >> > > > >> > > > [require] >> > > >

[Mesa-dev] [PATCH 2/2] i965/fs: Consider type mismatches in saturate propagation.

2015-10-14 Thread Matt Turner
NIR considers bcsel to produce and consume unsigned types, leading to SEL instructions operating on unsigned types when the data is really floating-point. Previous to this patch, saturate propagation would happily transform (+f0) sel g20:UD, g30:UD, g40:UD mov.sat g50:F, g20:F

[Mesa-dev] [PATCH 1/2] i965: Extract can_change_source_types() functions.

2015-10-14 Thread Matt Turner
Make them members of fs_inst/vec4_instruction for use elsewhere. Also fix the fs version to check that dst.type == src[1].type and for !saturate. --- src/mesa/drivers/dri/i965/brw_fs.cpp| 12 src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 15 ++-

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-14 Thread Jordan Justen
On 2015-10-13 22:49:08, Iago Toral wrote: > On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote: > > On 2015-10-13 05:17:37, Francisco Jerez wrote: > > > Iago Toral Quiroga writes: > > > > > > > This fixes the following test: > > > > > > > > [require] > > > > GL >= 3.3 > > > > GLSL >= 3.30 > >

Re: [Mesa-dev] [PATCH] i965/fs: Restore compute shader support in brw_nir_lower_inputs

2015-10-14 Thread Kenneth Graunke
On Tuesday, October 13, 2015 09:02:48 PM Jordan Justen wrote: > On 2015-10-13 20:04:36, Kenneth Graunke wrote: > > On Tuesday, October 13, 2015 01:44:55 PM Jordan Justen wrote: > > > The commit shown below caused compute shaders to hit the unreachable > > > in the default of the switch block. Resto

Re: [Mesa-dev] [PATCH] st/fbo: use pipe_surface_release instead of pipe_surface_reference

2015-10-14 Thread Krzysztof A. Sobiecki
Brian Paul writes: > Reviewed-by: Brian Paul > > Do you need me to commit this for you? > > -Brian > Yes, it would be nice. Thanks. -- X was an interactive protocol: alpha blending a full-screen image looked like slugs racing down the monitor. http://www.keithp.com/~keithp/talks/usenix2000/ren

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-14 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 01:10:23PM +0200, Neil Roberts wrote: > It would be nice if you could give some indication of where this list of > formats came from. > > Unless we expect the list to change with future generations, maybe it > would be better to make it a static const table? It's a shame to

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-14 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 08:04:48PM +0300, Pohjolainen, Topi wrote: > On Wed, Oct 14, 2015 at 09:54:43AM -0700, Ben Widawsky wrote: > > On Wed, Oct 14, 2015 at 02:43:24PM +0300, Pohjolainen, Topi wrote: > > > On Wed, Oct 14, 2015 at 11:39:03AM +0200, Neil Roberts wrote: > > > > Ben Widawsky writes:

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-14 Thread Pohjolainen, Topi
On Wed, Oct 14, 2015 at 09:54:43AM -0700, Ben Widawsky wrote: > On Wed, Oct 14, 2015 at 02:43:24PM +0300, Pohjolainen, Topi wrote: > > On Wed, Oct 14, 2015 at 11:39:03AM +0200, Neil Roberts wrote: > > > Ben Widawsky writes: > > > > > > > The impetus for this patch comes from a seemingly benign st

Re: [Mesa-dev] [PATCH] mesa: remove unused texUnit local in _mesa_BindTextureUnit()

2015-10-14 Thread Anuj Phogat
On Tue, Oct 13, 2015 at 7:10 PM, Brian Paul wrote: > The texture unit is error-checked before this and the texUnit var > is unused, so remove it. > --- > src/mesa/main/texobj.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index b

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-14 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 02:43:24PM +0300, Pohjolainen, Topi wrote: > On Wed, Oct 14, 2015 at 11:39:03AM +0200, Neil Roberts wrote: > > Ben Widawsky writes: > > > > > The impetus for this patch comes from a seemingly benign statement within > > > the > > > spec (quoted within the patch). For me,

Re: [Mesa-dev] [PATCH] st/fbo: use pipe_surface_release instead of pipe_surface_reference

2015-10-14 Thread Brian Paul
On 10/14/2015 10:03 AM, Krzysztof A. Sobiecki wrote: From: Krzysztof Sobiecki pipe_surface_reference have problems with deleted contexts, so use of pipe_surface_release might be more appropriate. Fixes Wasteland 2 Director's Cut crash on start. --- src/mesa/state_tracker/st_cb_fbo.c | 2 +-

[Mesa-dev] [PATCH] st/fbo: use pipe_surface_release instead of pipe_surface_reference

2015-10-14 Thread Krzysztof A. Sobiecki
From: Krzysztof Sobiecki pipe_surface_reference have problems with deleted contexts, so use of pipe_surface_release might be more appropriate. Fixes Wasteland 2 Director's Cut crash on start. --- src/mesa/state_tracker/st_cb_fbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

2015-10-14 Thread Eduardo Lima Mitev
On 10/08/2015 12:58 AM, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the checks w

Re: [Mesa-dev] [PATCH 09/10] i965/meta: Remove fast_clear_color variable

2015-10-14 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 11:52:03AM +0200, Neil Roberts wrote: > This patch doesn't look right. See this sentence in “Render Target Fast > Clear”: > > “The pixel shader kernel requires no attributes, and delivers a value of > 0x in all channels of the render target write message” > > Pres

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-14 Thread Brian Paul
I just pushed it. Thanks. -Brian On 10/14/2015 02:07 AM, Belal, Awais wrote: Hi Brian, Do you want me to update this or is it good to go as is? BR, Awais From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Belal, Awais Sent: Monday,

Re: [Mesa-dev] [PATCH v2] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Francisco Jerez
Marta Lofstedt writes: > From: Marta Lofstedt > > The split of Uniform blocks and shader storage block only loops > up to MESA_SHADER_FRAGMENT and igonres compute shaders. > This cause segfault when running the OpenGL ES 3.1 CTS tests > with GL_ARB_compute_shader enabled. > > V2: Changed to use

[Mesa-dev] [PATCH v2] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Marta Lofstedt
From: Marta Lofstedt The split of Uniform blocks and shader storage block only loops up to MESA_SHADER_FRAGMENT and igonres compute shaders. This cause segfault when running the OpenGL ES 3.1 CTS tests with GL_ARB_compute_shader enabled. V2: Changed to use MESA_SHADER_STAGES instead of MESA_SHAD

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Lofstedt, Marta
> -Original Message- > From: Francisco Jerez [mailto:curroje...@riseup.net] > Sent: Wednesday, October 14, 2015 3:18 PM > To: Lofstedt, Marta; Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO > also for compute shader

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Francisco Jerez
"Lofstedt, Marta" writes: > I have found a couple of more places in linker.cpp where we loop up to > MESA_SHADER_FRAGMENT. > Should these now also be up to MESA_SHADER_COMPUTE instead? > Some might be oversights like this, but I guess in some cases a loop up to MESA_SHADER_FRAGMENT might be the

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Lofstedt, Marta
I have found a couple of more places in linker.cpp where we loop up to MESA_SHADER_FRAGMENT. Should these now also be up to MESA_SHADER_COMPUTE instead? /Marta > -Original Message- > From: Marta Lofstedt [mailto:marta.lofst...@linux.intel.com] > Sent: Wednesday, October 14, 2015 2:56 PM

Re: [Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Francisco Jerez
Hi Marta, Marta Lofstedt writes: > From: Marta Lofstedt > > The split of Uniform blocks and shader storage block only loops > up to MESA_SHADER_FRAGMENT and igonres compute shaders. > This cause segfault when running the OpenGL ES 3.1 CTS tests > with GL_ARB_compute_shader enabled. > > Signed-o

[Mesa-dev] [PATCH] glsl: Enable split of lower UBOs and SSBO also for compute shaders

2015-10-14 Thread Marta Lofstedt
From: Marta Lofstedt The split of Uniform blocks and shader storage block only loops up to MESA_SHADER_FRAGMENT and igonres compute shaders. This cause segfault when running the OpenGL ES 3.1 CTS tests with GL_ARB_compute_shader enabled. Signed-off-by: Marta Lofstedt --- src/glsl/linker.cpp |

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-14 Thread Erik Faye-Lund
On Sun, Oct 11, 2015 at 5:09 PM, Christian Gmeiner wrote: > @@ -2181,6 +2188,13 @@ if test -n "$with_gallium_drivers"; then > done > fi > > +dnl We need to validate some needed dependencies for renderonly drivers. > + > +if test "x$HAVE_GALLIUM_NOUVEAU" != xyes -a "x$HAVE_GALLIUM_TEGRA" == x

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-14 Thread Alejandro Piñeiro
On 14/10/15 10:15, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> On 13/10/15 23:36, Matt Turner wrote: >>> On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro >>> wrote: On 13/10/15 03:10, Matt Turner wrote: > Looks like this is causing an intermittent failure on HSW in our >>>

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #16 from Eduardo Lima Mitev --- (In reply to Mark Janes from comment #14) > No piglit, dEQP, or CTS tests indicated this regression. However, a major > consumer of Mesa was debilitated due to this bug. > > This bug cannot be marked

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-14 Thread Pohjolainen, Topi
On Wed, Oct 14, 2015 at 11:39:03AM +0200, Neil Roberts wrote: > Ben Widawsky writes: > > > The impetus for this patch comes from a seemingly benign statement within > > the > > spec (quoted within the patch). For me, this patch was at some point > > critical > > for getting stable piglit result

Re: [Mesa-dev] [PATCH 00/10] Support Skylake MCS buffers (fast clears)

2015-10-14 Thread Neil Roberts
Looks good, it'll be great to get this landed. Patches 1-3 and 6-8 are: Reviewed-by: Neil Roberts I've sent comments separately for 4, 5 and 9. Hopefully I can try to help with patch 10 once my SKL machine arrives. Regards, - Neil Ben Widawsky writes: > This patch series adds support for fas

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-14 Thread Neil Roberts
It would be nice if you could give some indication of where this list of formats came from. Unless we expect the list to change with future generations, maybe it would be better to make it a static const table? It's a shame to grow the context size unnecessarily. Regards, - Neil Ben Widawsky wr

Re: [Mesa-dev] [PATCH 09/10] i965/meta: Remove fast_clear_color variable

2015-10-14 Thread Neil Roberts
This patch doesn't look right. See this sentence in “Render Target Fast Clear”: “The pixel shader kernel requires no attributes, and delivers a value of 0x in all channels of the render target write message” Presumably the fast_clear_color is trying to implement this restriction. Regard

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-14 Thread Neil Roberts
Ben Widawsky writes: > The impetus for this patch comes from a seemingly benign statement within the > spec (quoted within the patch). For me, this patch was at some point critical > for getting stable piglit results (though this did not seem to be the case on > a > branch Chad was working on).

Re: [Mesa-dev] [PATCH v2 18/17 (was 10/17)] i965/vs: Move use_legacy_snorm_formula into the shader key

2015-10-14 Thread Pohjolainen, Topi
On Sat, Oct 10, 2015 at 08:05:59AM -0700, Jason Ekstrand wrote: > This is really an input into the shader compiler so it kind of makes sense > in the key. Also, given where it's placed into the key, it doesn't > actually make it any bigger. > > v2 (Jason Ekstrand): >- Rebase on top of the com

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-14 Thread Timothy Arceri
On Tue, 2015-10-13 at 12:20 +0200, Marek Olšák wrote: > On Tue, Oct 13, 2015 at 10:13 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > > > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > > On

Re: [Mesa-dev] [PATCH v2 12/17] i965/vs: Rework vs_emit to take a nir_shader and a brw_compiler

2015-10-14 Thread Pohjolainen, Topi
On Wed, Oct 14, 2015 at 11:25:40AM +0300, Pohjolainen, Topi wrote: > On Sat, Oct 10, 2015 at 08:09:01AM -0700, Jason Ekstrand wrote: > > This commit removes all dependence on GL state by getting rid of the > > brw_context parameter and the GL data structures. > > > > v2 (Jason Ekstrand): > >-

Re: [Mesa-dev] [PATCH v2 12/17] i965/vs: Rework vs_emit to take a nir_shader and a brw_compiler

2015-10-14 Thread Pohjolainen, Topi
On Sat, Oct 10, 2015 at 08:09:01AM -0700, Jason Ekstrand wrote: > This commit removes all dependence on GL state by getting rid of the > brw_context parameter and the GL data structures. > > v2 (Jason Ekstrand): >- Patch use_legacy_snorm_formula through as a function argument rather > tha

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-14 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 13/10/15 23:36, Matt Turner wrote: >> On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro >> wrote: >>> On 13/10/15 03:10, Matt Turner wrote: Looks like this is causing an intermittent failure on HSW in our Jenkins system (but I'm not able to reproduce lo

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-14 Thread Belal, Awais
Hi Brian, Do you want me to update this or is it good to go as is? BR, Awais From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Belal, Awais Sent: Monday, October 12, 2015 6:33 PM To: Brian Paul; mesa-dev@lists.freedesktop.org Subject:

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-14 Thread Alejandro Piñeiro
On 13/10/15 23:36, Matt Turner wrote: > On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro > wrote: >> On 13/10/15 03:10, Matt Turner wrote: >>> Looks like this is causing an intermittent failure on HSW in our >>> Jenkins system (but I'm not able to reproduce locally) and a >>> consistent failure

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-14 Thread Daniel Vetter
On Tue, Oct 13, 2015 at 02:51:36PM -0700, Kristian Høgsberg wrote: > On Tue, Oct 13, 2015 at 7:55 AM, Michel Thierry > wrote: > > On 10/13/2015 3:13 PM, Emil Velikov wrote: > >> > >> On 13 October 2015 at 13:16, Michel Thierry > >> wrote: > >>> > >>> On 10/6/2015 2:12 PM, Michel Thierry wrote: >