Re: [Mesa-dev] [PATCH] i965: Make convert_attr_sources_to_hw_regs handle stride == 0.

On Thu, Nov 12, 2015 at 12:18 PM, Kenneth Graunke wrote: > This makes expressions like component(fs_reg(ATTR, n), 7) get a proper > <0,1,0> region instead of the invalid <0,8,0>. > > Nobody uses this today, but I plan to. This seems like the right thing to do, but I'd

Re: [Mesa-dev] [PATCH 1/7] [v2] i965/skl: Add fast color clear infrastructure

On Wed 11 Nov 2015, Ben Widawsky wrote: > Patch was originally called: > i965/skl: Enable fast color clears on SKL > > Skylake introduces some differences in the way that fast clears are programmed > and in the restrictions for using fast clears. Since some of these are > non-obvious, and fast

[Mesa-dev] [PATCH] i965/skl: Disable fast clear for formats without alpha

--- Here is one proposal to fix the issue. I noticed that only formats without alpha were failing. This sucks for RGBX formats (which technically aren't fast clearable based on the surface format). The hunk for moving the format should happen regardless of this patch. Neil has another patch

Re: [Mesa-dev] [PATCH v2] glsl: fix 'shared' layout qualifier related regressions

Thanks. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/6] nir: Add a ssa_def_rewrite_uses_after helper

--- src/glsl/nir/nir.c | 49 + src/glsl/nir/nir.h | 2 ++ 2 files changed, 51 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 32d8598..9b11b26 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1315,6 +1315,55 @@

[Mesa-dev] [PATCH 0/6] i965: Do textures swizzle work-arounds in NIR.

The subject says it all. This little series adds texture swizzle support to nir_lower_tex and makes the i965 driver use that instead of its own code. This approach has a few advantages: 1) It lets us share the swizzling code between both backends and with anyone else who wants it. 2) It

[Mesa-dev] [PATCH 2/6] nir: Use instr/if_rewrite in nir_ssa_def_rewrite_uses

nir_ssa_def_rewrite_uses is one of the older helpers in NIR and predated both of those. Now it can be substantially simplified. --- src/glsl/nir/nir.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index

[Mesa-dev] [PATCH 6/6] i965: Use NIR for lowering texture swizzle

Now that nir_lower_tex can do texture swizzle lowering, we can use that instead of repeating more-or-less the same code in both backends. This both allows us to share code and means that things like the tg4 work-arounds are somewhat simpler because they don't have to take the swizzle into

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

Hi Emil, On 11/10/2015 04:35 PM, Emil Velikov wrote: Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: On 10/27/2015 02:01 PM, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil Velikov wrote: On 27

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add gl_HelperInvocation system value

Reviewed-by: Matt Turner I'll take a stab at hooking this up in the i965 backend. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/6] nir/validate: Validated dests after sources

Previously, if someone accidentally made an instruction that refers to its own SSA destination, the validator wouldn't catch it. The reason for this is that it validated the destination too early and, by the time it got to the source, the destination SSA value was already added to the set of seen

[Mesa-dev] [PATCH 4/6] nir: Add a tex_instr_is_query helper

--- src/glsl/nir/nir.h | 25 + 1 file changed, 25 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 47fc62e..53dea7f 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1038,6 +1038,31 @@ nir_tex_instr_dest_size(nir_tex_instr *instr) }

[Mesa-dev] [PATCH 5/6] nir/lower_tex: Add support for lowering texture swizzle

--- src/glsl/nir/nir.h | 13 + src/glsl/nir/nir_lower_tex.c | 67 2 files changed, 80 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 53dea7f..a07380e 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

On 11/12/2015 08:51 PM, Samuel Pitoiset wrote: Hi Emil, On 11/10/2015 04:35 PM, Emil Velikov wrote: Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: On 10/27/2015 02:01 PM, samuel.pitoiset wrote:

[Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

This commit accidentally used a '==' when '=' was intended. commit 96b22fb080894ba1840af2372f28a46cc0f40c76 Author: Kristian Høgsberg Kristensen Date: Wed Nov 4 14:58:54 2015 -0800 glsl: Use array deref for access to vector components Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

On 2015-11-11 20:57:55, Matt Turner wrote: > On Wed, Nov 11, 2015 at 8:47 PM, Ilia Mirkin wrote: > > On Nov 11, 2015 9:10 PM, "Matt Turner" wrote: > >> > >> On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen > >> wrote: >

Re: [Mesa-dev] [PATCH v2 2/3] gallium: add support for gl_HelperInvocation semantic

On Thu, 12 Nov 2015 18:32:25 +0100, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/docs/source/tgsi.rst | 8 src/gallium/include/pipe/p_shader_tokens.h | 3 ++-

[Mesa-dev] [PATCH 2/2] i965: Clean up context constant initialization code.

This was getting pretty out of hand, and with compute partially in place and tessellation on the way, it was only going to get worse. This patch makes a "stage exists?" predicate and a "number of stages" count and uses them to clean up a lot of calculations. We can just loop over shader stages

[Mesa-dev] [PATCH 1/2] i965: Convert scalar_* flags to a scalar_stage array.

I was going to add scalar_tcs and scalar_tes flags, and then thought better of it and decided to convert this to an array. Simpler. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.h | 3 +-- src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH] nir: Add helpers for getting input/output intrinsic sources.

With the many variants of IO intrinsics, particular sources are often in different locations. It's convenient to say "give me the indirect offset" or "give me the vertex index" and have it just work, without having to think about exactly which kind of intrinsic you have. Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH 1/4] nir/lower_io: Use load_per_vertex_input intrinsics for TCS and TES.

On Tue, Nov 10, 2015 at 1:21 AM, Kenneth Graunke wrote: > Tessellation control shader inputs are an array indexed by the vertex > number, like geometry shader inputs. There aren't per-patch TCS inputs. > > Tessellation evaluation shaders have both per-vertex and per-patch

[Mesa-dev] [PATCH 8/8] glsl: don't validate binding when its not needed

From: Timothy Arceri Checking that the flag has been set is all the validation thats needed here. Also not calling the binding validation function will make things much simpler when adding compile time constant support as we won't need to resolve the binding value.

[Mesa-dev] [PATCH 2/8] glsl: move block validation outside function that validates members

From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f4c53b4..60f415d 100644 --- a/src/glsl/ast_to_hir.cpp +++

[Mesa-dev] [PATCH 1/8] glsl: move ast layout qualifier handling code into its own function

From: Timothy Arceri We now also only apply these rules to variables rather than also trying to apply them to function params. --- src/glsl/ast_to_hir.cpp | 404 +--- 1 file changed, 207 insertions(+), 197 deletions(-)

[Mesa-dev] [PATCH 4/8] glsl: only do type and qualifier validation once per declaration

From: Timothy Arceri For struct and block members previously we were doing it for every variable declaration. So for example struct S { atomic_uint x, y, z; }; Would previously generate three error messages when one is sufficient. --- src/glsl/ast_to_hir.cpp |

[Mesa-dev] [PATCH 3/8] glsl: rename function that processes struct and iface members

From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 60f415d..3cd7a88 100644 ---

[Mesa-dev] [PATCH 6/8] glsl: cleanup and fix validate matrix function for arrays

From: Timothy Arceri Previously if the member was an array of matrices then a warning message would be incorrectly given. Also the struct case could never be met so it has been removed. --- src/glsl/ast_to_hir.cpp | 11 +-- 1 file changed, 1 insertion(+),

[Mesa-dev] ast clean-up and fixes

This is a bunch of clean ups and some small fixes I noticed while getting ready to add arb_enhanced_layouts support. No regressions after runnning on Intels CI system. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 7/8] glsl: remove temp variable to make code easier to read

From: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 3cc60a9..75da399 100644 --- a/src/glsl/ast_to_hir.cpp +++

[Mesa-dev] [PATCH 5/8] glsl: use better location in struct and block error messages

From: Timothy Arceri Previously we only gave the location for some members and never gave the variable location. In those cases we were just giving the location of the struct/block. --- src/glsl/ast_to_hir.cpp | 10 +++--- 1 file changed, 3 insertions(+), 7

Re: [Mesa-dev] [PATCH] i965/fs: Replace nested ternary with if ladder.

On Thursday, November 12, 2015 05:46:58 PM Matt Turner wrote: > Since the types of the expression were > >bool ? src_reg : (bool ? brw_reg : brw_reg) > > the result of the second (nested) ternary would be implicitly > converted to a src_reg by the src_reg(struct brw_reg) constructor. I.e., >

[Mesa-dev] [PATCH] r600g: Support TGSI_SEMANTIC_HELPER_INVOCATION

Signed-off-by: Glenn Kennard --- Maybe there is a better way to check if a thread is a helper invocation? src/gallium/drivers/r600/r600_shader.c | 83 +- 1 file changed, 72 insertions(+), 11 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

Am 12.11.2015 um 23:59 schrieb Brian Paul: > --- > src/mesa/main/extensions.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h > index e4671be..1615e1c 100644 > --- a/src/mesa/main/extensions.h > +++

Re: [Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

On Thu, Nov 12, 2015 at 3:17 PM, Brian Paul wrote: > On 11/12/2015 04:03 PM, Nanley Chery wrote: > >> From: Nanley Chery >> >> Hopefully fixes the MSVC build error reported by Roland. >> >> Signed-off-by: Nanley Chery >>

Re: [Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

On 11/13/2015 01:15 AM, Ilia Mirkin wrote: On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: +static bool +nv50_compute_validate_program(struct nv50_context *nv50) +{ + struct nv50_program *prog = nv50->compprog; + + if (prog->mem) + return true; + +

Re: [Mesa-dev] [PATCH 2/2] i965: Clean up context constant initialization code.

On Thursday, November 12, 2015 03:38:52 PM Kenneth Graunke wrote: [snip] > - ctx->Const.MaxDualSourceDrawBuffers = 1; > - ctx->Const.MaxDrawBuffers = BRW_MAX_DRAW_BUFFERS; > - ctx->Const.Program[MESA_SHADER_FRAGMENT].MaxTextureImageUnits = > max_samplers; > -

[Mesa-dev] [PATCH] i965: Make convert_attr_sources_to_hw_regs handle stride == 0.

This makes expressions like component(fs_reg(ATTR, n), 7) get a proper <0,1,0> region instead of the invalid <0,8,0>. Nobody uses this today, but I plan to. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 +++- 1 file changed, 11

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] r200: fix bgrx8/xrgb8 blits

I'll try to swap the RV200 for the R200 next week. I'm not sure when Emil is planning the next stable release... I'll try to test before that... unless someone beats me to it. ;) On 11/12/2015 11:00 AM, srol...@vmware.com wrote: > From: Roland Scheidegger > > Since

Re: [Mesa-dev] [PATCH 08/11] nir/lower_tex: Report progress

On Wednesday, November 11, 2015 05:26:28 PM Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 2 +- > src/glsl/nir/nir_lower_tex.c | 19 +++ > 2 files changed, 16 insertions(+), 5 deletions(-) (a bit of drive by reviewing, since we talked about patch 10 on IRC)

Re: [Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

On 12 November 2015 at 22:59, Brian Paul wrote: > --- > src/mesa/main/extensions.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h > index e4671be..1615e1c 100644 > ---

Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

On Thu, 2015-11-12 at 13:59 +0100, Iago Toral wrote: > On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > > From: Timothy Arceri > > > > We already give the location of the qualifier so there is > > no need to list all the identifiers in the error message. >

[Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for the % operator.

GLSL 4.00 and GL_ARB_gpu_shader5 introduced a new int -> uint implicit conversion rule and updated the rules for modulus to use them. (In earlier languages, none of the implicit conversion rules did anything relevant, so there was no point in applying them.) This allows expressions such as:

Re: [Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: > +static bool > +nv50_compute_validate_program(struct nv50_context *nv50) > +{ > + struct nv50_program *prog = nv50->compprog; > + > + if (prog->mem) > + return true; > + > + if (!prog->translated) { >

Re: [Mesa-dev] [PATCH] nir: Add helpers for getting input/output intrinsic sources.

I didn't double-check all your indices, but I like it. Reviewed-by: Jason Ekstrand The other four can also have my R-B conditional on the little rework I suggested. --Jason On Thu, Nov 12, 2015 at 4:03 PM, Kenneth Graunke wrote: > With the many

[Mesa-dev] [PATCH] i965/fs: Replace nested ternary with if ladder.

Since the types of the expression were bool ? src_reg : (bool ? brw_reg : brw_reg) the result of the second (nested) ternary would be implicitly converted to a src_reg by the src_reg(struct brw_reg) constructor. I.e., bool ? src_reg : src_reg(bool ? brw_reg : brw_reg) In the next patch,

[Mesa-dev] [PATCH] mesa: fix MSVC build break in extensions.h

--- src/mesa/main/extensions.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h index e4671be..1615e1c 100644 --- a/src/mesa/main/extensions.h +++ b/src/mesa/main/extensions.h @@ -75,7 +75,9 @@ struct mesa_extension {

[Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

From: Nanley Chery Hopefully fixes the MSVC build error reported by Roland. Signed-off-by: Nanley Chery --- I'm not sure why the array size being unknown is an issue. Please let me know if this fixes the build issue.

Re: [Mesa-dev] [PATCH] mesa/extensions: Define the size of the extension array

On 11/12/2015 04:03 PM, Nanley Chery wrote: From: Nanley Chery Hopefully fixes the MSVC build error reported by Roland. Signed-off-by: Nanley Chery --- I'm not sure why the array size being unknown is an issue. Please let me know if this

Re: [Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for the % operator.

On 11/12/2015 02:25 PM, Kenneth Graunke wrote: > GLSL 4.00 and GL_ARB_gpu_shader5 introduced a new int -> uint implicit > conversion rule and updated the rules for modulus to use them. (In > earlier languages, none of the implicit conversion rules did anything > relevant, so there was no point in

[Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

This adds the ability to launch simple compute kernels like the one I will use to read out MP performance counters in the upcoming patch. This compute support is based on the work of Francisco Jerez (aka curro) that he did as part of his EVoC project in 2011/2012 to get OpenCL working on Tesla.

[Mesa-dev] [PATCH 4/5] nv50: expose two groups of compute-related MP perf counters

This turns on GL_AMD_performance_monitor which needs at least one group of GPU counters to be enabled. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 55 ++ src/gallium/drivers/nouveau/nv50/nv50_query.h

[Mesa-dev] [PATCH 2/5] nv50: add compute-related MP perf counters on G84+

These compute-related MP performance counters have been reverse engineered using CUPTI which is part of NVIDIA CUDA. As for nvc0, we use a compute kernel to read out those performance counters, and the command stream to configure them. Note that Tesla only exposes 4 MP performance counters, while

[Mesa-dev] [PATCH 3/5] nv50: add support for performance metrics on G84+

Currently only one metric is exposed but more will be added later. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 19

[Mesa-dev] [PATCH 5/5] docs: mark GL_AMD_performance_monitor for nv50

Signed-off-by: Samuel Pitoiset --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 82ee3c4..14dc5e4 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -63,6

[Mesa-dev] [PATCH 0/5] nv50: compute support & some perf counters

Hi there, The first patch of this series implements a basic compute support which allows to launch simple kernels on NV50 (Tesla). The other patches add some compute-related MP performance counters that will enable GL_AMD_performance_monitor on Tesla at the end of the series. This has been fully

Re: [Mesa-dev] [PATCH 2/4] nir/lower_io: Introduce nir_store_per_vertex_output intrinsics.

On Tue, Nov 10, 2015 at 1:21 AM, Kenneth Graunke wrote: > Similar to nir_load_per_vertex_input, but for outputs. This is not > useful in geometry shaders, but will be useful in tessellation shaders. > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matrices with atomic counter buffers

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Monday, November 2, 2015 12:36 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] glsl: set

Re: [Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

Reviewed-by: Iago Toral Quiroga On Thu, 2015-11-12 at 00:44 -0800, Jordan Justen wrote: > This commit accidentally used a '==' when '=' was intended. > > commit 96b22fb080894ba1840af2372f28a46cc0f40c76 > Author: Kristian Høgsberg Kristensen > Date: Wed

Re: [Mesa-dev] [PATCH 7/7] [v2] i965/gen9: Support fast clears for 32b float

Ben Widawsky writes: > Two formats are explicitly disabled because they fail piglit tests, > LUMINANCE16F and INTENSITY16F. There is some question about the > validity of sampling from these surfaces for all gens, however, there > seem to be no other failures, so I'd

Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > From: Timothy Arceri > > We already give the location of the qualifier so there is > no need to list all the identifiers in the error message. However, there can be multiple layout qualifiers in the same

Re: [Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

On 12 November 2015 at 00:09, Matt Turner wrote: > On Wed, Nov 11, 2015 at 4:08 PM, Kenneth Graunke > wrote: >> Actually, your earlier statement: >> "if file == BAD_FILE, no other fields mean anything." >> suggests that we should change fs_reg() to

Re: [Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

On 11 November 2015 at 20:45, Rob Clark wrote: > On Mon, Nov 9, 2015 at 8:39 AM, Rob Clark wrote: >> On Mon, Nov 9, 2015 at 8:30 AM, Emil Velikov >> wrote: >>> On 30 October 2015 at 17:57, Emil Velikov

[Mesa-dev] [PATCH] glsl: move ast layout qualifier handling code into its own function

From: Timothy Arceri We now also only apply these rules to variables rather than also trying to apply them to function params. --- src/glsl/ast_to_hir.cpp | 404 +--- 1 file changed, 207 insertions(+), 197 deletions(-)

Re: [Mesa-dev] [PATCH] nir/vars_to_ssa: Delete dead output set code

Reviewed-by: Connor Abbott On Fri, Nov 13, 2015 at 12:53 AM, Jason Ekstrand wrote: > This was a remnant of an early attempt to handle output reads in > vars_to_ssa. That attempt was abandon a long time ago but these few lines > were aparently left in

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

On Thu, Nov 12, 2015 at 9:36 PM, Jason Ekstrand wrote: > bump! Where are we at on this? Go ahead and push it with my r-b. I still think glsl_type::is_vector_or_scalar() should return true for subroutine types, but that might require some more fixing and testing. > > On

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

On 12/11/15 18:45, Emil Velikov wrote: > Hi Sam, > > On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez > wrote: >> On 12/11/15 15:28, Timothy Arceri wrote: >>> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" >>> wrote:

[Mesa-dev] [PATCH] nir/vars_to_ssa: Delete dead output set code

This was a remnant of an early attempt to handle output reads in vars_to_ssa. That attempt was abandon a long time ago but these few lines were aparently left in the pass and managed to evade review. --- src/glsl/nir/nir_lower_vars_to_ssa.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nir/vars_to_ssa: Rework copy set handling in lower_copies_to_load_store

Reviewed-by: Connor Abbott On Thu, Nov 12, 2015 at 10:02 PM, Jason Ekstrand wrote: > Previously, we walked through a given deref_node's copies and, after > lowering the copy away, removed it from both the source and destination > copy sets. This

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

On Thu, Nov 12, 2015 at 9:57 PM, Connor Abbott wrote: > On Thu, Nov 12, 2015 at 9:36 PM, Jason Ekstrand wrote: >> bump! Where are we at on this? > > Go ahead and push it with my r-b. I still think > glsl_type::is_vector_or_scalar() should return true

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" wrote: >'shared' was added in ARB_uniform_buffer_object and also used >in ARB_shader_storage_buffer_object. Hi Samuel, Shared for UBO and SSBOs is not a key word its just an identifier for a layout

Re: [Mesa-dev] [PATCH] egl/wayland: Ignore rects from SwapBuffersWithDamage

On Sat, 7 Nov 2015 18:34:20 + Daniel Stone wrote: > eglSwapBuffersWithDamage accepts damage-region rectangles to hint the > compositor that it only needs to redraw certain areas, which was passed > through the wl_surface_damage request, as designed. > > Wayland also

[Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

Commit 8b28b35 added 'shared' as a keyword for compute shaders but it broke the existing 'shared' layout qualifier support for uniform and shader storage blocks. This patch fixes 578 dEQP-GLES31.functional.ssbo.* tests. Signed-off-by: Samuel Iglesias Gonsálvez ---

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Samuel Iglesias Gonsálvez > Sent: Thursday, November 12, 2015 2:23 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev]

[Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

'shared' was added in ARB_uniform_buffer_object and also used in ARB_shader_storage_buffer_object. A later patch will fix the shader layout qualifier regressions in dEQP. Signed-off-by: Samuel Iglesias Gonsálvez --- src/glsl/glsl_lexer.ll | 9 - 1 file changed, 8

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Samuel Iglesias Gonsálvez > Sent: Thursday, November 12, 2015 2:23 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev]

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

On 13 November 2015 12:22:40 am AEDT, "Samuel Iglesias Gonsálvez" wrote: >Commit 8b28b35 added 'shared' as a keyword for compute shaders >but it broke the existing 'shared' layout qualifier support for >uniform and shader storage blocks. > >This patch fixes 578

[Mesa-dev] [PATCH] nir/vars_to_ssa: Rework copy set handling in lower_copies_to_load_store

Previously, we walked through a given deref_node's copies and, after lowering the copy away, removed it from both the source and destination copy sets. This commit changes this to only remove it from the other node's copy set (not the one we're lowering). At the end of the loop, we just throw

Re: [Mesa-dev] [PATCH v2 1/3] i965: Introduce a MOV_INDIRECT opcode.

On Wed, Nov 11, 2015 at 12:02 PM, Kenneth Graunke wrote: > The geometry and tessellation control shader stages both read from > multiple URB entries (one per vertex). The thread payload contains > several URB handles which reference these separate memory segments. > > In

Re: [Mesa-dev] [PATCH v2 1/3] i965: Introduce a MOV_INDIRECT opcode.

On Thursday, November 12, 2015 07:27:31 PM Jason Ekstrand wrote: > On Wed, Nov 11, 2015 at 12:02 PM, Kenneth Graunke > wrote: > > The geometry and tessellation control shader stages both read from > > multiple URB entries (one per vertex). The thread payload contains > >

Re: [Mesa-dev] [PATCH v2 1/3] i965: Introduce a MOV_INDIRECT opcode.

On Thu, Nov 12, 2015 at 8:52 PM, Kenneth Graunke wrote: > On Thursday, November 12, 2015 07:27:31 PM Jason Ekstrand wrote: >> On Wed, Nov 11, 2015 at 12:02 PM, Kenneth Graunke >> wrote: >> > The geometry and tessellation control shader stages both

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

bump! Where are we at on this? On Tue, Nov 10, 2015 at 6:16 PM, Dave Airlie wrote: >>> >>> Well, it's not just a NIR thing -- GLSL IR also effectively treats >>> subroutines as integers. Actually, I wonder why the >>> glsl_type::is_vector_or_scalar() doesn't return true for

Re: [Mesa-dev] [PATCH] nir/vars_to_ssa: Rework copy set handling in lower_copies_to_load_store

On Thu, 2015-11-12 at 19:02 -0800, Jason Ekstrand wrote: > Previously, we walked through a given deref_node's copies and, after > lowering the copy away, removed it from both the source and destination > copy sets. This commit changes this to only remove it from the other > node's copy set (not

Re: [Mesa-dev] [PATCH 00/11] i965/nir: Do texture rectangle lowering in NIR

Patches 1-4 are, Reviewed-by: Iago Toral Quiroga Patch 5 seems to be missing. Iago On Wed, 2015-11-11 at 17:23 -0800, Jason Ekstrand wrote: > On older hardware (Iron Lake and below), we can't support texture rectangle > natively. Sandy Bridge through Haswell can support it

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

On 12/11/15 15:28, Timothy Arceri wrote: > > > On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" > wrote: >> 'shared' was added in ARB_uniform_buffer_object and also used >> in ARB_shader_storage_buffer_object. > > Hi Samuel, > > Shared for UBO and

Re: [Mesa-dev] [PATCH 7/7] [v2] i965/gen9: Support fast clears for 32b float

On Thu, Nov 12, 2015 at 11:39:25AM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > Two formats are explicitly disabled because they fail piglit tests, > > LUMINANCE16F and INTENSITY16F. There is some question about the > > validity of sampling from these

Re: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matrices with atomic counter buffers

On Mon, Nov 2, 2015 at 6:36 AM, Tapani Pälli wrote: > Patch sets matrix_stride as 0 for non matrix uniforms that are in a > atomic counter buffer. Matrix stride calculation for actual matrix > uniforms is done during link_assign_uniform_locations. > > From

Re: [Mesa-dev] [PATCH 00/11] i965/nir: Do texture rectangle lowering in NIR

On Thu, 2015-11-12 at 16:23 +0100, Iago Toral wrote: > Patches 1-4 are, > Reviewed-by: Iago Toral Quiroga > > Patch 5 seems to be missing. Oh never mind, I've just seen your reply to the thread pointing to the repository. Iago > Iago > > On Wed, 2015-11-11 at 17:23 -0800,

Re: [Mesa-dev] [PATCH 2/2] glsl: fix 'shared' layout qualifier related regressions

On 12/11/15 15:38, Timothy Arceri wrote: > > > On 13 November 2015 12:22:40 am AEDT, "Samuel Iglesias Gonsálvez" > wrote: >> Commit 8b28b35 added 'shared' as a keyword for compute shaders >> but it broke the existing 'shared' layout qualifier support for >> uniform and

[Mesa-dev] [PATCH v2] glsl: fix 'shared' layout qualifier related regressions

Commit 8b28b35 added 'shared' as a keyword for compute shaders but it broke the existing 'shared' layout qualifier support for uniform and shader storage blocks. This patch fixes 578 dEQP-GLES31.functional.ssbo.* tests. v2: - Move SHARED to interface_block_layout_qualifier (Timothy) - Don't

[Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

It looks like the sampler hardware doesn't take into account the surface format when sampling a cleared color after a fast clear has been done. So for example if you clear a GL_RED surface to 1,1,1,1 then the sampling instructions will return 1,1,1,1 instead of 1,0,0,1. This patch makes it

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

Hi Sam, On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez wrote: > On 12/11/15 15:28, Timothy Arceri wrote: >> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" >> wrote: >>> 'shared' was added in ARB_uniform_buffer_object and

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

On Tue, Nov 10, 2015 at 12:01 PM, Ian Romanick wrote: > On 11/09/2015 04:29 PM, Ilia Mirkin wrote: >> On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: >>> On 11/04/2015 03:26 PM, Ryan Houdek wrote: I'm hoping to potentially convince about

Re: [Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

In response to using FRAG_RESULT_DATA0 for both of the builtins that the extension provides for ES2. When looking at what _mesa_BindFragDataLocationIndexed does, it binds the output variable to DATA0+colorNumber that you passed in to it, and also sets that variable to being whatever index you

Re: [Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

On Thu, Nov 12, 2015 at 1:02 PM, Ryan Houdek wrote: > In response to using FRAG_RESULT_DATA0 for both of the builtins that the > extension provides for ES2. > When looking at what _mesa_BindFragDataLocationIndexed does, it binds the > output variable to DATA0+colorNumber

Re: [Mesa-dev] [PATCH] glsl: Correctly handle vector extract on function parameter

On Thu, Nov 12, 2015 at 12:44 AM, Jordan Justen wrote: > This commit accidentally used a '==' when '=' was intended. > > commit 96b22fb080894ba1840af2372f28a46cc0f40c76 > Author: Kristian Høgsberg Kristensen > Date: Wed Nov 4 14:58:54 2015 -0800 >

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

On Thu, Nov 12, 2015 at 9:54 AM, Ilia Mirkin wrote: > I wonder if we'll be able to support ES 3.1 on Intel Sandy Bridge, > NVIDIA Tesla family (G80-GT218), or ATI R600/R700 GPU's, all of which > support ES 3.0 today. OTOH, they're unlikely targets for ES software. Not on

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #57 from pavi...@yahoo.fr --- There will be a workaround in chromium and the Tooltips will work but something still need to be fixed in nouveau if I understand corrcectly ? -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #58 from Ilia Mirkin --- (In reply to paviluf from comment #57) > There will be a workaround in chromium and the Tooltips will work but > something still need to be fixed in nouveau if I understand corrcectly ?

Re: [Mesa-dev] [PATCH v2 10/18] mesa: In helpers, only check driver capability for meta

On Wed, Nov 11, 2015 at 3:00 PM, Chad Versace wrote: > On Fri 30 Oct 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > Make API context and version checks done by the helper functions pass > > unconditionally while meta is in progress.

[Mesa-dev] [PATCH v2 3/3] nvc0/ir: add support for TGSI_SEMANTIC_HELPER_INVOCATION

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 1 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 +

  1   2   >