Re: [Mesa-dev] [PATCH] perf: fix snprintf() problem on Windows for glsl-compile-time.c

On Wednesday, February 24, 2016 4:45:42 PM PST Brian Paul wrote: > Use the typical _snprintf work-around. > --- > src/perf/glsl-compile-time.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/perf/glsl-compile-time.c b/src/perf/glsl-compile-time.c > index 917073c..a8e774f 100644

Re: [Mesa-dev] [PATCH] gallium/radeon: return correct values for BE in r600_translate_colorswap

On Wed, Feb 24, 2016 at 5:56 PM, Emil Velikov wrote: > Hi Oded, > > On 24 February 2016 at 12:46, Oded Gabbay wrote: >> Because I changed the swizzle check, I also need to adapt the return >> values for each check. >> >> It's basically almost the

Re: [Mesa-dev] [PATCH 16/21] nir/cf: Make extracting or re-inserting nothing a no-op

Reviewed-by: Connor Abbott On Sat, Feb 13, 2016 at 9:14 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_control_flow.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/compiler/nir/nir_control_flow.c >

Re: [Mesa-dev] [PATCH 15/21] nir: Add a function for comparing cursors

On Sat, Feb 13, 2016 at 9:14 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir.c | 63 > ++ > src/compiler/nir/nir.h | 2 ++ > 2 files changed, 65 insertions(+) > > diff --git a/src/compiler/nir/nir.c

Re: [Mesa-dev] [PATCH 14/21] nir/cf: Handle relinking top-level blocks

Reviewed-by: Connor Abbott On Sat, Feb 13, 2016 at 9:14 PM, Jason Ekstrand wrote: > This can happen if a function ends in a return instruction and you remove > the return. > --- > src/compiler/nir/nir_control_flow.c | 7 +-- > 1 file changed, 5

Re: [Mesa-dev] [PATCH] nir: Add a pass for lower indirect variable dereferences

On Sat, Feb 13, 2016 at 8:48 PM, Jason Ekstrand wrote: > This new pass lowers load/store_var intrinsics that act on indirect derefs > to if-ladder of direct load/store_var intrinsics. The if-ladders perform a > simple binary search on the indirect. > --- >

Re: [Mesa-dev] [PATCH 10/21] nir/dominance: Handle unreachable blocks

I believe this is correct, and won't cause any issues with phi node placement, etc. before dead_cf comes and gets rid any code in the unreachable block(s). Reviewed-by: Connor Abbott BTW, I'd ask that you hold off on pushing this until I at least get a chance to look at the

[Mesa-dev] [Bug 91840] Expose GL_KHR_debug to ES contexts

https://bugs.freedesktop.org/show_bug.cgi?id=91840 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 37397] Expose more ES extensions that are identical to existing desktop GL functionality

https://bugs.freedesktop.org/show_bug.cgi?id=37397 Bug 37397 depends on bug 91840, which changed state. Bug 91840 Summary: Expose GL_KHR_debug to ES contexts https://bugs.freedesktop.org/show_bug.cgi?id=91840 What|Removed |Added

[Mesa-dev] [PATCH v3 4/6] gallium/target-helpers: add OpenSWR driver

--- src/gallium/auxiliary/target-helpers/inline_sw_helper.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/target-helpers/inline_sw_helper.h b/src/gallium/auxiliary/target-helpers/inline_sw_helper.h index a9ab16f..5bb77a5 100644 ---

[Mesa-dev] [PATCH v3 5/6] mesa/build: add OpenSWR to build

--- configure.ac | 38 ++ m4/ax_cxx_compile_stdcxx.m4 | 558 ++ src/gallium/Makefile.am | 6 + src/gallium/drivers/swr/.clang-format | 64 +++ src/gallium/drivers/swr/Makefile.am

[Mesa-dev] [PATCH v3 0/6] OpenSWR driver addition

Updating parts 3 through 6 (1 and 2 are still current) based on review comments. Since we're only targeting linux at the moment, I've removed the scons build and libgl-gdi changes to simplify the review process. In the future when we get windows working as well we'll get the scons build system

[Mesa-dev] [PATCH v3 3/6] gallium/auxilary: more __cplusplus exports

--- src/gallium/auxiliary/gallivm/lp_bld_flow.h | 7 +++ src/gallium/auxiliary/gallivm/lp_bld_init.h | 7 +++ src/gallium/auxiliary/gallivm/lp_bld_sample.h | 6 ++ src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 8 src/gallium/auxiliary/util/u_dl.h | 6 ++

[Mesa-dev] [PATCH v3 6/6] gallium/docs - add OpenSWR documentation

--- src/gallium/docs/source/drivers/openswr.rst| 21 +++ src/gallium/docs/source/drivers/openswr/faq.rst| 141 + src/gallium/docs/source/drivers/openswr/knobs.rst | 114 + .../docs/source/drivers/openswr/profiling.rst | 67 ++

Re: [Mesa-dev] [PATCH 00/21] nir: Functions!

On 2016-02-13 22:01:46, Jordan Justen wrote: > On 2016-02-13 18:14:17, Jason Ekstrand wrote: > > > > Jason Ekstrand (21): > > nir/glsl: Remove dead function parameter handling code > > nir: Add a new "param" variable mode for parameters and return > > variables > > nir: Add a helper for

Re: [Mesa-dev] [PATCH 7/8] gallium/radeon: fix C++11 invalid suffix on literal error

I generally prefer the shortlog saying what the change does as opposed to what effect that has. For patches 7 & 8, that would be something like gallium/radeon: Add space between string literal and identifier r600: Make enum alu_op_flags unsigned respectively, with the previous shortlogs

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use re-Z

On 24.02.2016 19:28, Marek Olšák wrote: > On Wed, Feb 24, 2016 at 4:02 AM, Michel Dänzer wrote: >> On 24.02.2016 01:45, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This can increase perf for shaders that kill pixels (kill, alpha-test, >>>

Re: [Mesa-dev] [PATCH 1/6] winsys/radeon: drop support for DRM 2.12.0

On 25 February 2016 at 01:27, Dave Airlie wrote: > On 25 February 2016 at 11:15, Emil Velikov wrote: >> Hi Marek, >> >> On 24 February 2016 at 23:09, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> in order to

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

On 24 February 2016 at 18:56, Rob Herring wrote: > AOSP master branch has switched to clang from gcc and has major build > system changes moving away from GNU make. Out of curiosity: what are they moving to ? I can see "blueprint" (ninja?), kati (gnu make clone) and soong(?). Is

Re: [Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

On 02/24/2016 04:35 PM, Miklós Máté wrote: This fixes post-processing in SW:KotOR. Can you elaborate on exactly what's happening and why this change fixes things? v2: fix const-ness Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atom_sampler.c | 6 +-

Re: [Mesa-dev] [PATCH 6/8] freedreno: drop unnecessary -Wno-packed-bitfield-compat

On Wed, Feb 24, 2016 at 8:21 PM, Emil Velikov wrote: > On 24 February 2016 at 19:11, Rob Clark wrote: >> hmm, we did need this at one point in time for the packed structs used >> for shader instruction assembly.. maybe newer gcc doesn't warn about

Re: [Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

On 02/24/2016 04:35 PM, Miklós Máté wrote: Now it follows the GLX 1.4 specification. Can you elaborate on that a bit? This fixes post-processing in SW:KotOR. Signed-off-by: Miklós Máté --- src/mesa/main/context.c | 42 -- 1 file

Re: [Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

On 02/24/2016 04:35 PM, Miklós Máté wrote: the state tracker will use it Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 7 ++-

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

I think this patch could be broken up a bit... On 02/24/2016 04:35 PM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes

Re: [Mesa-dev] [PATCH 1/8] Android: remove dependence on .SECONDEXPANSION

Hi Rob, On 24 February 2016 at 18:56, Rob Herring wrote: > With the Android build system changes to ninja/kati, the use of > .SECONDEXPANSION is no longer supported. Fix this by avoiding rule specific > variables and using $(transform-generated-source). > > Cc: Emil Velikov

Re: [Mesa-dev] [PATCH 1/6] winsys/radeon: drop support for DRM 2.12.0

On 25 February 2016 at 11:15, Emil Velikov wrote: > Hi Marek, > > On 24 February 2016 at 23:09, Marek Olšák wrote: >> From: Marek Olšák >> >> in order to make some winsys interface changes easier > > Please add to the commit

Re: [Mesa-dev] [PATCH 6/8] freedreno: drop unnecessary -Wno-packed-bitfield-compat

On 24 February 2016 at 19:11, Rob Clark wrote: > hmm, we did need this at one point in time for the packed structs used > for shader instruction assembly.. maybe newer gcc doesn't warn about > this (since it mostly seems related to a bug in older gcc versions)? > I guess

Re: [Mesa-dev] [PATCH 1/6] winsys/radeon: drop support for DRM 2.12.0

Hi Marek, On 24 February 2016 at 23:09, Marek Olšák wrote: > From: Marek Olšák > > in order to make some winsys interface changes easier Please add to the commit message the linux kernel version - 3.2.0 . Out of curiosity I looked at current kernel

[Mesa-dev] [PATCH] nv50/ir: Check for valid insn instead of defs size

On Tesla cards, the first register $r0 contains the thread id; later generations use a specialised register for it. In order to prevent the register from being given to anyone, and thus lose the thread id information, an lvalue is created to represent $r0 and is passed as an argument to the `main`

[Mesa-dev] [PATCH] perf: fix snprintf() problem on Windows for glsl-compile-time.c

Use the typical _snprintf work-around. --- src/perf/glsl-compile-time.c | 4 1 file changed, 4 insertions(+) diff --git a/src/perf/glsl-compile-time.c b/src/perf/glsl-compile-time.c index 917073c..a8e774f 100644 --- a/src/perf/glsl-compile-time.c +++ b/src/perf/glsl-compile-time.c @@ -20,6

[Mesa-dev] [PATCH 6/7] glx: fix the refcounting of dri drawables

This fixes premature deallocation on unbind, and introduces support for deleting GLX drawables while they are current to a context. Note that in practice this also introduces a resource leak, because nobody uses the GLX 1.3 glXDestroyWindow and glXDestroyPixmap calls. This fixes disappearing

[Mesa-dev] [PATCH 3/7] st/mesa: enable GL_ATI_fragment_shader

Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 24c6444..6d0c200 100644 --- a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v3)

Hi, this series is the third version of my patch set, which aims to improve the looks of Star Wars: Knights of the Old Republic (via Wine). The main feature is the implementation of GL_ATI_fragment_shader for all Gallium divers (though I could only test it with radeonsi, llvmpipe, and

[Mesa-dev] [PATCH 4/7] main: rework the compatibility check of visuals in glXMakeCurrent

Now it follows the GLX 1.4 specification. This fixes post-processing in SW:KotOR. Signed-off-by: Miklós Máté --- src/mesa/main/context.c | 42 -- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/context.c

[Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

This fixes post-processing in SW:KotOR. v2: fix const-ness Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atom_sampler.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c

[Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes Signed-off-by: Miklós Máté --- src/mesa/Makefile.sources | 1 +

[Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

the state tracker will use it Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 7 ++- src/mesa/main/mtypes.h| 1 +

[Mesa-dev] [PATCH 7/7] mesa: optimize out the realloc from glCopyTexImagexD()

v2: comment about the purpose of the code v3: also compare texFormat, add a perf debug message, formatting fixes Signed-off-by: Miklós Máté --- src/mesa/main/teximage.c | 35 +++ 1 file changed, 35 insertions(+) diff --git

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 > --- >  src/compiler/glsl/ast_to_hir.cpp | 7 +++ >  1 file changed, 7 insertions(+) > > diff --git a/src/compiler/glsl/ast_to_hir.cpp >

Re: [Mesa-dev] [PATCH 1/2] gallium: add usage flags to resource_get_handle

On 25/02/2016 00:10, Marek Olšák wrote: From: Marek Olšák This will help differentiate between window-system framebuffers and other buffers. PIPE_HANDLE_USAGE_EXPLICIT_FLUSH should yield higher performance (e.g. allows delayed clears), but PIPE_HANDLE_USAGE_COHERENT is

Re: [Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

On Wed, Feb 24, 2016 at 3:35 PM, Samuel Pitoiset wrote: > +/* TIC/TSC entries (6 user clip planes, base instance id) */ > +#define NVC0_CB_AUX_TXC_INFO0x000 > +#define NVC0_CB_AUX_TXC_SIZE(8 * 4) This makes no sense. UCP's and base instances have

[Mesa-dev] [Bug 94273] OpenCL segfault during testing of clBLAS

https://bugs.freedesktop.org/show_bug.cgi?id=94273 --- Comment #3 from joshua.r.marshall.1...@gmail.com --- https://gist.github.com/anadon/c1ea234ade1e9d076970 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH 1/2] gallium: add usage flags to resource_get_handle

From: Marek Olšák This will help differentiate between window-system framebuffers and other buffers. PIPE_HANDLE_USAGE_EXPLICIT_FLUSH should yield higher performance (e.g. allows delayed clears), but PIPE_HANDLE_USAGE_COHERENT is more flexible. Sadly, it looks like st/dri

[Mesa-dev] [PATCH 2/2] gallium: add usage flags to resource_from_handle

From: Marek Olšák These are the same flags as for resource_get_handle. --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 3 ++- src/gallium/drivers/ddebug/dd_screen.c | 5 +++-- src/gallium/drivers/freedreno/freedreno_resource.c | 3 ++-

[Mesa-dev] [PATCH 5/6] gallium/radeon: remove rcs parameter from radeon_winsys::buffer_set_tiling

From: Marek Olšák This was needed for DRM < 2.12.0 where the kernel was rewriting tiling flags in IBs. --- src/gallium/drivers/r300/r300_texture.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 2 +- src/gallium/drivers/radeon/radeon_winsys.h| 2 --

[Mesa-dev] [PATCH 3/6] r600g: remove support for DRM < 2.12.0

From: Marek Olšák --- src/gallium/drivers/r600/evergreen_compute.c | 21 - src/gallium/drivers/r600/evergreen_state.c | 44 +--- src/gallium/drivers/r600/r600_hw_context.c | 4 +-- src/gallium/drivers/r600/r600_pipe.c | 3 +-

[Mesa-dev] [PATCH 1/6] winsys/radeon: drop support for DRM 2.12.0

From: Marek Olšák in order to make some winsys interface changes easier --- src/gallium/drivers/radeon/radeon_winsys.h| 16 + src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 42 +-- 2 files changed, 18 insertions(+), 40 deletions(-)

[Mesa-dev] [PATCH 4/6] gallium/radeon: add radeon_bo_tiling_info for passing flags from/to winsys

From: Marek Olšák --- src/gallium/drivers/r300/r300_texture.c | 22 - src/gallium/drivers/radeon/r600_texture.c | 52 ++-- src/gallium/drivers/radeon/radeon_winsys.h| 43 +++-- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c |

[Mesa-dev] [PATCH 6/6] gallium/radeon: rename winsys buffer_get/set_tiling to buffer_get/set_metadata

From: Marek Olšák and rename the structure. Later it will be extended to support amdgpu metadata. --- src/gallium/drivers/r300/r300_texture.c | 8 ++--- src/gallium/drivers/radeon/r600_texture.c | 48 -

[Mesa-dev] [PATCH 2/6] r300g: remove support for DRM < 2.12.0

From: Marek Olšák --- src/gallium/drivers/r300/r300_context.c | 9 +++ src/gallium/drivers/r300/r300_emit.c| 3 +-- src/gallium/drivers/r300/r300_flush.c | 6 ++--- src/gallium/drivers/r300/r300_screen.c | 19 +-

[Mesa-dev] [Bug 94273] OpenCL segfault during testing of clBLAS

https://bugs.freedesktop.org/show_bug.cgi?id=94273 --- Comment #2 from joshua.r.marshall.1...@gmail.com --- Improved stacktrace with debug information: https://gist.github.com/anadon/4bc558761e1192e26d0d -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [RFC 1/3] glsl: add an assignment_recipient parameter on ast_expression

On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: > The idea is pass through the ast-to-hir conversion if the current > expression is the recipient of the assignment or not. Default > value is false (so default value is being rhs). > > Bugzilla:

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On 08:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > > > On 02/24/2016 08:30 PM, Pierre Moreau wrote: > >Hi Samuel, > > > >On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > >>Reduce the amount of duplicated code by re-using > >>nvc0_program_validate(). While we are at it, change the prototype >

[Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

Instead make use of constants to improve readability. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 13 +- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 25 +++

Re: [Mesa-dev] [PATCH 1/3] nvc0: move nvc0_validate_global_residents() to nvc0_compute.c

On 02/24/2016 08:37 PM, Pierre Moreau wrote: Hello Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: While we are at it, rename it to nvc0_compute_validate_globals() and update its prototype. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

On 02/24/2016 08:30 PM, Pierre Moreau wrote: Hi Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is now useless. Why

Re: [Mesa-dev] [PATCH 2/3] nvc0: make sure to validate compute global buffers on Fermi

Acked-by: Pierre Moreau On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > No reason to not validate those global buffers and this might avoid > fails if someone try to use the global memory from compute programs. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 1/3] nvc0: move nvc0_validate_global_residents() to nvc0_compute.c

Hello Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > While we are at it, rename it to nvc0_compute_validate_globals() and > update its prototype. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 15

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

Hi Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > Reduce the amount of duplicated code by re-using > nvc0_program_validate(). While we are at it, change the prototype > to return void and remove nvc0_compute.h which is now useless. Why don't you want to know whether the validation

Re: [Mesa-dev] [PATCH 6/8] freedreno: drop unnecessary -Wno-packed-bitfield-compat

hmm, we did need this at one point in time for the packed structs used for shader instruction assembly.. maybe newer gcc doesn't warn about this (since it mostly seems related to a bug in older gcc versions)? I guess since (afaiu) android provides it's own compiler per android release, I suppose

[Mesa-dev] [RFC 2/3] glsl: set non-default cases for assignment_recipient

It is true for the lhs of all the ast nodes related with assignmnent, plus the array on ast_array_index. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 --- src/compiler/glsl/ast_to_hir.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 --- src/compiler/glsl/ast_to_hir.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index ee5485c..296c845 100644 --- a/src/compiler/glsl/ast_to_hir.cpp +++

[Mesa-dev] [RFC 1/3] glsl: add an assignment_recipient parameter on ast_expression

The idea is pass through the ast-to-hir conversion if the current expression is the recipient of the assignment or not. Default value is false (so default value is being rhs). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 --- src/compiler/glsl/ast.h| 11 ++-

[Mesa-dev] [RFC 0/3] glsl: add "use of uninitialized variable" warning

This series implement enhancement suggested on this bug: https://bugs.freedesktop.org/show_bug.cgi?id=94129 Although the bug mentions that detecting uninitialized (undefined) usage of variables on NIR is easy, this series implements the feature on ast-to-hir. NIR is (imho) too high level to deal

[Mesa-dev] [PATCH 3/8] Android: add -Wno-date-time flag for clang

clang complains about date/time macros: src/mesa/main/context.c:403:25: error: expansion of date or time macro is not reproducible [-Werror,-Wdate-time] Disable this warning. Cc: Emil Velikov Signed-off-by: Rob Herring --- Android.common.mk | 1 +

[Mesa-dev] [PATCH 8/8] gallium/radeon: fix c++11-narrowing errors

In builds with clang, there are several errors related to the enum alu_op_flags like this: src/gallium/drivers/r600/sb/sb_expr.cpp:887:8: error: case value evaluates to -1610612736, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing] These are due to the MSB being set in the

[Mesa-dev] [PATCH 5/8] Android: clean-up and fix DRI module path handling

MESA_DRI_MODULE_PATH is only getting set for classic DRI drivers and may or may not be set correctly for gallium_dri.so depending on the makefile include ordering. For Android 6 and earlier it is fine, but with build system changes in AOSP master, it is not. Move the path variables to a single

Re: [Mesa-dev] [PATCH] i965: Don't emit an empty then-branch

Ian Romanick writes: > From: Ian Romanick > > Invert the condition and just emit the non-empty else-branch. > > total instructions in shared programs: 8448571 -> 8448373 (-0.00%) > instructions in affected programs: 20880 -> 20682 (-0.95%) >

[Mesa-dev] [PATCH 4/8] Android: remove headers from LOCAL_SRC_FILES

The Android build system now spits out warnings for header files listed in LOCAL_SRC_FILES, so strip them out. Cc: Emil Velikov Signed-off-by: Rob Herring --- Android.common.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Android.common.mk

[Mesa-dev] [PATCH 6/8] freedreno: drop unnecessary -Wno-packed-bitfield-compat

Enabling this warning doesn't generate any warnings with gcc, but is an unknown option for clang, so drop it. Cc: Rob Clark Signed-off-by: Rob Herring --- src/gallium/drivers/freedreno/Android.mk | 3 --- 1 file changed, 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/8] Android: glsl: fix dependence on YACC_HEADER_SUFFIX from build system

The makefile was implicitly picking up YACC_HEADER_SUFFIX from the Android build system, but this variable is now gone. Add it locally to fix the build with AOSP master. Cc: Emil Velikov Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH 7/8] gallium/radeon: fix C++11 invalid suffix on literal error

Fix compiles with clang that have this C++11 error: src/gallium/drivers/radeon/r600_pipe_common.h:662:34: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] Cc: Marek Olšák Signed-off-by: Rob Herring

[Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

AOSP master branch has switched to clang from gcc and has major build system changes moving away from GNU make. These changes have broken the mesa build and this series fixes it. There shouldn't be any interdependencies among the individual patches. Rob Rob Herring (8): Android: remove

[Mesa-dev] [PATCH 1/8] Android: remove dependence on .SECONDEXPANSION

With the Android build system changes to ninja/kati, the use of .SECONDEXPANSION is no longer supported. Fix this by avoiding rule specific variables and using $(transform-generated-source). Cc: Emil Velikov Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH v3] Android: fix x86 gallium builds

Builds with gallium enabled fail on x86 with linker error: external/mesa3d/src/mesa/vbo/vbo_exec_array.c:127: error: undefined reference to '_mesa_uint_array_min_max' The problem is sse_minmax.c is not included in the libmesa_st_mesa library. Since the SSE4.1 files are needed for both

[Mesa-dev] [PATCH] i965: Don't emit an empty then-branch

From: Ian Romanick Invert the condition and just emit the non-empty else-branch. total instructions in shared programs: 8448571 -> 8448373 (-0.00%) instructions in affected programs: 20880 -> 20682 (-0.95%) helped: 114 HURT: 0 Jason suggested that there were several

[Mesa-dev] [PATCH 2/3] nvc0: make sure to validate compute global buffers on Fermi

No reason to not validate those global buffers and this might avoid fails if someone try to use the global memory from compute programs. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Mesa-dev] [PATCH 1/3] nvc0: move nvc0_validate_global_residents() to nvc0_compute.c

While we are at it, rename it to nvc0_compute_validate_globals() and update its prototype. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 15 +++ src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 3 +--

[Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is now useless. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 1

[Mesa-dev] [Bug 94280] Regression related to mesa/readpix

https://bugs.freedesktop.org/show_bug.cgi?id=94280 --- Comment #2 from Ken Martin --- Created attachment 121950 --> https://bugs.freedesktop.org/attachment.cgi?id=121950=edit apitrace apitrace file for the test that is exposing the problem. The test renders four

[Mesa-dev] [Bug 94280] Regression related to mesa/readpix

https://bugs.freedesktop.org/show_bug.cgi?id=94280 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 94280] Regression related to mesa/readpix

https://bugs.freedesktop.org/show_bug.cgi?id=94280 Bug ID: 94280 Summary: Regression related to mesa/readpix Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] Is that possible implement OpenGL/DirectX on top of Vulkan

On Wed, Feb 24, 2016 at 9:21 AM, Mohamed Mediouni wrote: > I consider Vulkan to be as low-level as Gallium. > > > Le 23/02/2016 17:43, Nicolas Capens a écrit : > > ANGLE is considering implementing OpenGL ES 3.x on top of Vulkan. Gallium is about as low-level as

[Mesa-dev] [Bug 94254] [llvmpipe] [softpipe] piglit read-front regression

https://bugs.freedesktop.org/show_bug.cgi?id=94254 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 94257] [softpipe] piglit glx-copy-sub-buffer regression

https://bugs.freedesktop.org/show_bug.cgi?id=94257 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 94253] [llvmpipe] piglit gl-1.0-swapbuffers-behavior regression

https://bugs.freedesktop.org/show_bug.cgi?id=94253 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] gallium/radeon: return correct values for BE in r600_translate_colorswap

Hi Oded, On 24 February 2016 at 12:46, Oded Gabbay wrote: > Because I changed the swizzle check, I also need to adapt the return > values for each check. > > It's basically almost the same as before, we just cross between STD and > STD_REV, and cross between ALT and

Re: [Mesa-dev] [PATCH] virtio_gpu: Add virtio 1.0 PCI ID to driver map

Hi On Mon, Feb 22, 2016 at 8:06 PM, Emil Velikov wrote: > Hi Marc, > > On 12 February 2016 at 21:11, Marc-André Lureau > wrote: >> From: Marc-André Lureau >> >> Add the virtio-gpu PCI ID for virtio 1.0

Re: [Mesa-dev] [PATCH 3/3] glsl: replace remaining tabs in link_varyings.cpp

Series is: Reviewed-by: Thomas Helland 2016-02-24 9:45 GMT+01:00 Timothy Arceri : > --- > src/compiler/glsl/link_varyings.cpp | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use re-Z

On 2016-02-23 17:45, Marek Olšák wrote: From: Marek Olšák This can increase perf for shaders that kill pixels (kill, alpha-test, alpha-to-coverage). --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state.c | 6 +++---

Re: [Mesa-dev] [PATCH] gallium: remove duplicate define from enum pipe_format

Am 24.02.2016 um 10:51 schrieb Oded Gabbay: > Signed-off-by: Oded Gabbay > --- > src/gallium/include/pipe/p_format.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/include/pipe/p_format.h > b/src/gallium/include/pipe/p_format.h > index

Re: [Mesa-dev] Is that possible implement OpenGL/DirectX on top of Vulkan

I consider Vulkan to be as low-level as Gallium. Le 23/02/2016 17:43, Nicolas Capens a écrit : ANGLE is considering implementing OpenGL ES 3.x on top of Vulkan. On Sat, Feb 20, 2016 at 2:07 AM, 罗勇刚(Yonggang Luo)

Re: [Mesa-dev] [PATCH] gallium: remove duplicate define from enum pipe_format

Reviewed-by: Thomas Helland 2016-02-24 10:51 GMT+01:00 Oded Gabbay : > Signed-off-by: Oded Gabbay > --- > src/gallium/include/pipe/p_format.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] gallium/radeon: return correct values for BE in r600_translate_colorswap

Reviewed-by: Marek Olšák Marek On Wed, Feb 24, 2016 at 1:46 PM, Oded Gabbay wrote: > Because I changed the swizzle check, I also need to adapt the return > values for each check. > > It's basically almost the same as before, we just cross between STD

[Mesa-dev] [PATCH 1/3] glsl: replace remaining tabs in ir_builder.cpp

--- src/compiler/glsl/ir_builder.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/ir_builder.cpp b/src/compiler/glsl/ir_builder.cpp index c9cf124..d68647f 100644 --- a/src/compiler/glsl/ir_builder.cpp +++ b/src/compiler/glsl/ir_builder.cpp @@

[Mesa-dev] [PATCH 3/3] glsl: replace remaining tabs in link_varyings.cpp

--- src/compiler/glsl/link_varyings.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 0d73216..8133772 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use re-Z

On 2016-02-24 12:47, Marek Olšák wrote: On Wed, Feb 24, 2016 at 12:22 PM, Grigori Goronzy wrote: S_00B32C_SCRATCH_EN(shader->config.scratch_bytes_per_wave > 0)); + + /* Prefer RE_Z if the shader is complex enough. */ + if (info->num_memory_instructions >= 2 || +

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use re-Z

On Wed, Feb 24, 2016 at 12:22 PM, Grigori Goronzy wrote: > On 2016-02-23 17:45, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This can increase perf for shaders that kill pixels (kill, alpha-test, >> alpha-to-coverage). >> --- >>

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use re-Z

On Wed, Feb 24, 2016 at 4:02 AM, Michel Dänzer wrote: > On 24.02.2016 01:45, Marek Olšák wrote: >> From: Marek Olšák >> >> This can increase perf for shaders that kill pixels (kill, alpha-test, >> alpha-to-coverage). >> --- >>

Re: [Mesa-dev] [PATCH] mesa: use sizeof on the correct type

On 23 February 2016 at 00:05, Brian Paul wrote: > On 02/22/2016 03:58 PM, Thomas Hindoe Paaboel Andersen wrote: >> >> Before the luminance stride was based on the size of GL_FLOAT >> which is just the type constant (0x1406). Change it to use the >> size of GLfloat. >

  1   2   >