Re: [Mesa-dev] [PATCH] anv/device: Enable sample shading on gen7+

On Aug 8, 2016 4:24 PM, "Anuj Phogat" wrote: > > Passes all 30 min_sample_shading tests in vulkan cts. > > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On 09/08/16 05:59 AM, ⚛ wrote: > On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick wrote: >> On 08/08/2016 09:38 AM, ⚛ wrote: >>> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: I'm pretty sure this breaks ABI. Did you try using an unpatched libGL

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #10 from Roland Scheidegger --- (In reply to Jules Blok from comment #9) > (In reply to Roland Scheidegger from comment #8) > > So I think you're doing something unusual. With my earlier quick look, it > > seemed

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

https://bugs.freedesktop.org/show_bug.cgi?id=97214 Alexandr Zelinsky changed: What|Removed |Added Keywords|regression | -- You are

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

https://bugs.freedesktop.org/show_bug.cgi?id=97214 Alexandr Zelinsky changed: What|Removed |Added Keywords||bisected,

[Mesa-dev] [Bug 97136] [softpipe] piglit egl-create-context-verify-gl-flavor regression

https://bugs.freedesktop.org/show_bug.cgi?id=97136 Alexandr Zelinsky changed: What|Removed |Added CC|

Re: [Mesa-dev] Call i965 GLSL IR backend optimisation from the common linker

Ping ... most of these are tidy ups and can be reviewed individually. Also patch 13 has landed. On Wed, 2016-07-27 at 15:20 +1000, Timothy Arceri wrote: > The ultimate goal is to be able to convert to NIR and make use of its > optimisations before assigning varying and uniform locations. This >

Re: [Mesa-dev] [PATCH] nir: Add an IO scalarizing pass using the intrinsic's first_component.

On Mon, 2016-08-08 at 09:18 -0700, Eric Anholt wrote: > Timothy Arceri writes: > > > > > On Sat, 2016-08-06 at 10:15 +1000, Timothy Arceri wrote: > > > > > > On Fri, 2016-08-05 at 16:27 -0700, Eric Anholt wrote: > > > > > > > > vc4 wants to have per-scalar IO

Re: [Mesa-dev] [PATCH 2/2] anv/clear: Clear E5B9G9R9 images as R32_UINT

On Mon, Aug 8, 2016 at 11:40 AM, Nanley Chery wrote: > On Wed, Aug 03, 2016 at 01:06:10PM -0700, Jason Ekstrand wrote: > > We can't actually clear these images normally because we can't render to > > them. Instead, we have to manually unpack the rgb9e5 color value on the

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

Does this fix any tests? If so, we should say so in the commit message. With that updated, Reviewed-by: Jason Ekstrand On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 2/3] anv/pipeline: Add sample locations for gen7-7.5

I wish we could come up with some clever way to not have to repeat the multisample positions all over the place. Unfortunately, I don't have any particularly fastastic ideas on how. We can figure that out later. Patches 1 and 2 are Reviewed-by: Jason Ekstrand On Mon, Aug

Re: [Mesa-dev] [PATCH 1/3] gallium: add render_condition_enable param to clear_render_target/depth_stencil

Am 09.08.2016 um 00:59 schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_clear.h| 5 +++-- > src/gallium/auxiliary/vl/vl_bicubic_filter.c| 2 +- > src/gallium/auxiliary/vl/vl_compositor.c| 2 +- >

[Mesa-dev] [PATCH] anv/device: Enable sample shading on gen7+

Passes all 30 min_sample_shading tests in vulkan cts. Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index c2c5153..b0b48ea

Re: [Mesa-dev] [PATCH] st/mesa: define ST_NEW_ flags as uint64_t values, not enums

Reviewed-by: Marek Olšák Marek On Tue, Aug 9, 2016 at 12:41 AM, Brian Paul wrote: > MSVC doesn't support 64-bit enum values, at least not with C code. > The compiler was warning: > > c:\users\brian\projects\mesa\src\mesa\state_tracker\st_atom_list.h(43)

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

On 08/08/2016 08:37 AM, Mathias Fröhlich wrote: Brian, On Monday, 8 August 2016 08:27:40 CEST Brian Paul wrote: > On 08/06/2016 12:42 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > We need this for 'inline'. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 43/95] i965/disasm: print NibCtrl for instructions with execsize 4

Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c > b/src/mesa/drivers/dri/i965/brw_disasm.c > index c8bdeab..d5e9916 100644 > ---

[Mesa-dev] [PATCH 1/3] gallium: add render_condition_enable param to clear_render_target/depth_stencil

From: Marek Olšák --- src/gallium/auxiliary/util/u_clear.h| 5 +++-- src/gallium/auxiliary/vl/vl_bicubic_filter.c| 2 +- src/gallium/auxiliary/vl/vl_compositor.c| 2 +- src/gallium/docs/source/context.rst | 7 ---

[Mesa-dev] [PATCH 3/3] gallium/radeon: implement ARB_clear_texture (v3)

From: Marek Olšák Some ideas copied from Jakob Sinclair's implementation, but the color clearing is completely different. v2: remove leftover code, disable conditional rendering disable render condition cleanly --- docs/GL3.txt | 2 +-

[Mesa-dev] [PATCH 2/3] gallium/radeon: handle render_condition_enable for clear_rt/ds

From: Marek Olšák --- src/gallium/drivers/r300/r300_blit.c | 6 -- src/gallium/drivers/r600/r600_blit.c | 6 -- src/gallium/drivers/radeonsi/si_blit.c | 6 -- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH] st/mesa: define ST_NEW_ flags as uint64_t values, not enums

MSVC doesn't support 64-bit enum values, at least not with C code. The compiler was warning: c:\users\brian\projects\mesa\src\mesa\state_tracker\st_atom_list.h(43) : warning C4309: 'initializing' : truncation of constant value

Re: [Mesa-dev] Mesa (master): st/mesa: completely rewrite state atoms

Marek, I just found a problem with this patch series with MSVC. The new enum type which defines the ST_NEW_ values uses bitshifts of more than 32 bits. It looks like this overflows the 32-bit size of the enum datatype: c:\users\brian\projects\mesa\src\mesa\state_tracker\st_atom_list.h(43)

Re: [Mesa-dev] [PATCH 42/95] i965/vec4: dump NibCtrl for instructions with execsize 4

Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index 829b7d3..88bf895 100644 > ---

Re: [Mesa-dev] [PATCH 41/95] i965/vec4: make the generator set correct NibCtrl for SIMD4 DF instructions

Iago Toral Quiroga writes: > From the HSW PRM, Command Reference, QtrCtrl: > >"NibCtrl is only allowed for SIMD4 instructions with a DF (Double Float) > source or destination type." > > v2 (Samuel): Assert that the type is DF. > > Signed-off-by: Samuel Iglesias

Re: [Mesa-dev] [PATCH] mesa: simplify ff fs generator a bit

On 08/08/2016 04:15 PM, Brian Paul wrote: On 08/06/2016 03:34 PM, Miklós Máté wrote: Literally. Signed-off-by: Miklós Máté --- src/mesa/main/ff_fragment_shader.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH] ddebug: dump driver states and shaders for apitrace calls

From: Marek Olšák I think this was an oversight when the PIPE_DUMP flags were added. --- src/gallium/drivers/ddebug/dd_draw.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c

Re: [Mesa-dev] [PATCH 8/8] radeonsi: enable multi-draw related pipe caps

If release notes are updated as well, the series is: Reviewed-by: Marek Olšák Marek On Mon, Aug 8, 2016 at 5:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This enables GL_shader_draw_parameters and

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 Sander Eikelenboom changed: What|Removed |Added Hardware|Other |x86-64

[Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen7_pipeline.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 5395e79..17d7ccc 100644 ---

[Mesa-dev] [PATCH 2/3] anv/pipeline: Add sample locations for gen7-7.5

V1: Add multisample positions (Nanley) V2: Fix 8x sample positions (Anuj) Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_pipeline_util.h | 47 +++ 1 file changed, 47 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_util.h

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 --- Comment #4 from Sander Eikelenboom --- Created attachment 125619 --> https://bugs.freedesktop.org/attachment.cgi?id=125619=edit mesa-vanilla-opencv-vanilla.txt -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 --- Comment #5 from Sander Eikelenboom --- Created attachment 125620 --> https://bugs.freedesktop.org/attachment.cgi?id=125620=edit opencv-patch.diff -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [PATCH 1/3] anv/pipeline: Move emit_ms_state() to genX_pipeline_util.h

This will help sharing multisample state setting code. Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen8_pipeline.c | 40 --- src/intel/vulkan/genX_pipeline_util.h | 40 +++ 2 files changed, 40

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 --- Comment #3 from Sander Eikelenboom --- Created attachment 125618 --> https://bugs.freedesktop.org/attachment.cgi?id=125618=edit mesa-vanilla-opencv-patched.txt -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 --- Comment #2 from Sander Eikelenboom --- Created attachment 125617 --> https://bugs.freedesktop.org/attachment.cgi?id=125617=edit mesa-patched-opencv-vanilla.txt -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 --- Comment #1 from Sander Eikelenboom --- Created attachment 125616 --> https://bugs.freedesktop.org/attachment.cgi?id=125616=edit mesa-patch.diff -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

https://bugs.freedesktop.org/show_bug.cgi?id=97250 Bug ID: 97250 Summary: Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR Product: Mesa Version: git Hardware: Other OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

On Mon, Aug 8, 2016 at 12:30 PM, Lionel Landwerlin wrote: > Fixes the following failures : > > dEQP-VK.api.copy_and_blit.resolve_image.whole_4_bit > dEQP-VK.api.copy_and_blit.resolve_image.whole_8_bit > dEQP-VK.api.copy_and_blit.resolve_image.partial_4_bit >

Re: [Mesa-dev] [PATCH 38/95] i965/vec4: allow the vec4 IR to indicate the execution size of instructions

Iago Toral Quiroga writes: > In the vec4 backend the generator sets the execution size for all > instructions to 8, however, we will have to split certain DF instructions > to have an execution size of 4, so we need to indicate this explicitly in the > IR for the generator to

[Mesa-dev] [Bug 97140] dd_draw.c:949:11: error: implicit declaration of function 'fmemopen' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

https://bugs.freedesktop.org/show_bug.cgi?id=97140 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

On 08/08/2016 01:58 PM, Rob Herring wrote: On Mon, Aug 8, 2016 at 1:39 PM, Chad Versace wrote: On 08/02/2016 04:07 AM, Tomasz Figa wrote: This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #9 from Jules Blok --- (In reply to Roland Scheidegger from comment #8) > So I think you're doing something unusual. With my earlier quick look, it > seemed like maybe you're relying on getting the clamped

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick wrote: > On 08/08/2016 09:38 AM, ⚛ wrote: >> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: >>> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL >>> with a patched *_dri.so (and

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

On Mon, Aug 8, 2016 at 1:39 PM, Chad Versace wrote: > On 08/02/2016 04:07 AM, Tomasz Figa wrote: >> >> This patch adds support for YV12 pixel format to the Android platform >> backend. Only creating EGL images is supported, it is not added to the >> list of available visuals.

Re: [Mesa-dev] [PATCH v2] egl/dri2: Add reference count for dri2_egl_display

Hello https://patchwork.freedesktop.org/series/10079/ has been merged to master but it is still marked as "new" at patchwork. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #8 from Roland Scheidegger --- (In reply to Jules Blok from comment #7) > It seems you misunderstood me, it doesn't work with either reversed depth or > normal depth on Mesa. So reverse depth has nothing to do

[Mesa-dev] [PATCH] vl/rbsp: add a check for emulation prevention three byte

This is the case when the "00 00 03" is very close to the beginning of nal unit header Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h

Re: [Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

On Mon, Aug 8, 2016 at 12:30 PM, Lionel Landwerlin wrote: > Fixes the following failures : > > dEQP-VK.api.copy_and_blit.resolve_image.whole_4_bit > dEQP-VK.api.copy_and_blit.resolve_image.whole_8_bit > dEQP-VK.api.copy_and_blit.resolve_image.partial_4_bit >

[Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

Fixes the following failures : dEQP-VK.api.copy_and_blit.resolve_image.whole_4_bit dEQP-VK.api.copy_and_blit.resolve_image.whole_8_bit dEQP-VK.api.copy_and_blit.resolve_image.partial_4_bit dEQP-VK.api.copy_and_blit.resolve_image.partial_8_bit

[Mesa-dev] [PATCH 0/2] Program multisampling modes on gen7/75

Some of the new CTS tests are failing basic image resolve operations on gen7/75. Turns out we're missing some bits there. Cheers, Lionel Landwerlin (2): anv: genX_pipeline: rename info to rs_info anv: gen7/75: Set multisample modes src/intel/vulkan/gen7_pipeline.c | 10 --

[Mesa-dev] [PATCH 1/2] anv: genX_pipeline: rename info to rs_info

Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline_util.h

Re: [Mesa-dev] [PATCH v2 0/7] egl/android: Improve the Android EGL backend

On 08/02/2016 04:07 AM, Tomasz Figa wrote: Nicolas Boichat (1): egl/android: Fix support for pbuffers Tomasz Figa (6): egl/android: Remove unused variables in droid_get_buffers_with_format() egl/android: Respect buffer mask in droid_image_get_buffers egl/android: Refactor image

Re: [Mesa-dev] Switching to the GL 4.4 sRGB rules for glBlitFramebuffer().

Patches 1 through 5 and 7 through 9 are Reviewed-by: Ian Romanick I sent one trivial comment on patch 9. On 08/04/2016 04:14 PM, Kenneth Graunke wrote: > Hello, > > This combined patch series updates both Piglit and Mesa to implement > the modern GL 4.4+ rules for

Re: [Mesa-dev] [PATCH - Mesa 09/10] meta: Make Meta's BlitFramebuffer() follow the GL 4.4 sRGB rules.

On 08/04/2016 04:14 PM, Kenneth Graunke wrote: > Just avoid whacking GL_FRAMEBUFFER_SRGB altogether, so we respect > the application's setting. This appears to work. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/common/meta_blit.c | 80 >

Re: [Mesa-dev] [PATCH 2/2] anv/clear: Clear E5B9G9R9 images as R32_UINT

On Wed, Aug 03, 2016 at 01:06:10PM -0700, Jason Ekstrand wrote: > We can't actually clear these images normally because we can't render to > them. Instead, we have to manually unpack the rgb9e5 color value on the > CPU and clear it as R32_UINT. We still have a bit of work to do to clear >

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

On 08/02/2016 04:07 AM, Tomasz Figa wrote: This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added to the list of available visuals. v2: Use const array defined just for YV12 instead of trying to be overly

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

"Juan A. Suarez Romero" writes: > On Mon, 2016-08-08 at 16:12 +0200, Juan A. Suarez Romero wrote: >> Hmm... what about the case of exec_size == 4 and writing just a >> float?  >> >> I understand in this case we only should mark one word, so the loop >> should  not be

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On Mon, Aug 8, 2016 at 9:52 AM, Jan Vesely wrote: > On Mon, 2016-08-08 at 08:54 -0700, Ian Romanick wrote: >> On 08/05/2016 07:05 PM, ⚛ wrote: >> > >> > On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely >> > wrote: >> > > >> > > On Sat, 2016-08-06 at

Re: [Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v3)

On Fri, Aug 5, 2016 at 11:37 PM, Jason Ekstrand wrote: > I am going to try and give this a proper look on Monday. Given how > sketchy the multisampling support is on gen7 at the moment, I am a but > concerned that it doesn't fix more tests. What's left to fix for MSAA? >

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #7 from Jules Blok --- Created attachment 125603 --> https://bugs.freedesktop.org/attachment.cgi?id=125603=edit FIFO log for Dolphin Emulator (In reply to Roland Scheidegger from comment #6) > The replays

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On 08/08/2016 09:52 AM, Jan Vesely wrote: > On Mon, 2016-08-08 at 08:54 -0700, Ian Romanick wrote: >> On 08/05/2016 07:05 PM, ⚛ wrote: >>> >>> On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely >>> wrote: On Sat, 2016-08-06 at 02:42 +0200, Jan Ziak wrote: > >

Re: [Mesa-dev] [PATCH 6/7] isl: Add a helper for getting a depth format from an isl_format

Patches 6 and 7 are Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On 08/08/2016 10:20 AM, Rob Clark wrote: > how strict are we on that actually? I think whenever we add new gl > entry points (ie. implementing new extension, etc) we kinda sorta > break ABI, don't we? I thought mixing/matching libGL vs *_dri.so was > at least not recommended.. No... we go to

Re: [Mesa-dev] [PATCH 5/7] anv/pipeline: Unify 3DSTATE_RASTER and 3DSTATE_SF setup between gen7 and gen8

On Saturday, August 6, 2016 10:31:20 AM PDT Jason Ekstrand wrote: > --- > src/intel/vulkan/gen7_pipeline.c | 43 + > src/intel/vulkan/gen8_pipeline.c | 48 > src/intel/vulkan/genX_pipeline_util.h | 60 >

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On 08/08/2016 09:38 AM, ⚛ wrote: > On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: >> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL >> with a patched *_dri.so (and vice-versa)? > > Can you be more specific? Eh... build Mesa. Save the libGL and

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

how strict are we on that actually? I think whenever we add new gl entry points (ie. implementing new extension, etc) we kinda sorta break ABI, don't we? I thought mixing/matching libGL vs *_dri.so was at least not recommended.. BR, -R On Mon, Aug 8, 2016 at 12:22 PM, Ian Romanick

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On Mon, 2016-08-08 at 08:54 -0700, Ian Romanick wrote: > On 08/05/2016 07:05 PM, ⚛ wrote: > > > > On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely > > wrote: > > > > > > On Sat, 2016-08-06 at 02:42 +0200, Jan Ziak wrote: > > > > > > > > Mesa source code prior to this patch

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: > I'm pretty sure this breaks ABI. Did you try using an unpatched libGL > with a patched *_dri.so (and vice-versa)? Can you be more specific? Where is the ABI documented? ___

Re: [Mesa-dev] [PATCH] nir: Add an IO scalarizing pass using the intrinsic's first_component.

On Aug 8, 2016 9:18 AM, "Eric Anholt" wrote: > > Timothy Arceri writes: > > > On Sat, 2016-08-06 at 10:15 +1000, Timothy Arceri wrote: > >> On Fri, 2016-08-05 at 16:27 -0700, Eric Anholt wrote: > >> > vc4 wants to have per-scalar IO load/stores so

Re: [Mesa-dev] [PATCH 12/18] mesa: Skip ES 3.0/3.1 transform feedback primitive counting error.

On 08/01/2016 10:29 AM, Kenneth Graunke wrote: > This error condition is not implementable when using tessellation or > geometry shaders. The text was also removed from the ES 3.2 spec. > I believe the intended behavior is to remove the error condition > when either OES_geometry_shader or

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

I'm pretty sure this breaks ABI. Did you try using an unpatched libGL with a patched *_dri.so (and vice-versa)? On 08/01/2016 06:21 AM, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > src/egl/drivers/dri2/egl_dri2.h | 19

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

On Mon, 2016-08-08 at 16:12 +0200, Juan A. Suarez Romero wrote: > Hmm... what about the case of exec_size == 4 and writing just a > float?  > > I understand in this case we only should mark one word, so the loop > should  not be 2*inst->regs_written. > > Note that in the original patch that was

Re: [Mesa-dev] [PATCH] nir: Add an IO scalarizing pass using the intrinsic's first_component.

Timothy Arceri writes: > On Sat, 2016-08-06 at 10:15 +1000, Timothy Arceri wrote: >> On Fri, 2016-08-05 at 16:27 -0700, Eric Anholt wrote: >> > vc4 wants to have per-scalar IO load/stores so that dead code >> > elimination >> > can happen on a more granular basis, >

Re: [Mesa-dev] [PATCH 0/8] radeonsi: implement missing indirect draw features

For patch 1-7: Reviewed-by: Bas Nieuwenhuizen For patch 8, you probably also want to add the extensions to the release notes. With that added, it looks good to me too. - Bas On Mon, Aug 8, 2016 at 5:55 PM, Nicolai Hähnle wrote: > Hi, > > this

[Mesa-dev] [PATCH] nvc0: advertise 8 bits subpixel precision for viewport bounds

Based on subpixel precision returned by the blob. Signed-off-by: Józef Kucia --- I've checked that the blob returns 8 for the following GPUs: GeForce GTX 460 (GF104), GeForce GTX 760 (GK104), GeForce GTX 970 (GM204). Generally, I expect that 8 bits precision should be

Re: [Mesa-dev] [PATCH 01/18] mapi: Add PatchParameteriOES and PatchParameteriEXT.

It looks like only part of this series has landed? Patches 1 through 7 and 9 through 12 are Reviewed-by: Ian Romanick On 08/01/2016 10:29 AM, Kenneth Graunke wrote: > The OES_tessellation_shader and EXT_tessellation_shader specifications > have suffixed names. These

Re: [Mesa-dev] [PATCH 09/18] glsl: Handle patch qualifier on interface blocks.

This is also a problem for desktop, yeah? Cc stable? On 08/01/2016 10:29 AM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/glsl/ast_to_hir.cpp | 4 > src/compiler/glsl/glsl_parser.yy | 11 +++ >

Re: [Mesa-dev] [PATCH 07/18] glsl: Implicitly enable OES_shader_io_blocks if geom/tess are enabled.

On 08/01/2016 10:29 AM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/glsl/glsl_parser_extras.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/compiler/glsl/glsl_parser_extras.h >

Re: [Mesa-dev] [PATCH 02/18] mesa: Add {OES, EXT}_tessellation_shader to the extensions table.

On 08/01/2016 07:52 PM, Kenneth Graunke wrote: > On Monday, August 1, 2016 7:06:14 PM PDT Ilia Mirkin wrote: >> I'm looking at these on my phone, so perhaps I missed it - do you ever end >> up turning them on, or is that left to later series? > > No...not yet. This series gets almost all of

[Mesa-dev] [PATCH 5/8] radeonsi: add DRAWID parameter to vertex shaders

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 8 +++- src/gallium/drivers/radeonsi/si_shader.h | 4 +++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 1/8] radeonsi/sid: add additional bits for the DRAW_(INDEX)_INDIRECT_MULTI packets

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/sid.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/sid.h b/src/gallium/drivers/radeonsi/sid.h index 0d2ac37..9c74a6a 100644 --- a/src/gallium/drivers/radeonsi/sid.h +++

[Mesa-dev] [PATCH 8/8] radeonsi: enable multi-draw related pipe caps

From: Nicolai Hähnle This enables GL_shader_draw_parameters and GL_ARB_indirect_parameters as well as a properly accelerated implementation of GL_ARB_multi_draw_indirect. Enabling the feature requires a sufficiently uptodate firmware -- those have already been released

[Mesa-dev] [PATCH 6/8] radeonsi: program the DRAWID SGPR

From: Nicolai Hähnle Note that for indirect draws, the new MULTI firmware packets are required. There's also no need to reset last_{start_instance,sh_base_reg}, since resetting last_base_vertex is sufficient. --- src/gallium/drivers/radeonsi/si_pipe.h | 3 +--

[Mesa-dev] [PATCH 4/8] radeonsi: wire up TGSI_SEMANTIC_BASEINSTANCE

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 64c367e..2c00f56 100644 ---

[Mesa-dev] [PATCH 3/8] radeonsi: remove an incorrect assertion

From: Nicolai Hähnle Byte indices don't need any alignment, so remove this assertion (it got moved into a path where a piglit test hit it during the refactoring of commit 64ff23a58c). --- src/gallium/drivers/radeonsi/si_state_draw.c | 2 -- 1 file changed, 2

[Mesa-dev] [PATCH 0/8] radeonsi: implement missing indirect draw features

Hi, this series adds some bug fixes and small extensions related to indirect draws that we can now use. As with the recent changes, it only applies with sufficiently new firmware, which means that it only works with amdgpu (due to a lack of firmware version query in the radeon kernel module).

[Mesa-dev] [PATCH 2/8] radeonsi: flush TC L2 cache for indirect draw data

From: Nicolai Hähnle This fixes a bug when indirect draw data is generated by transform feedback. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_descriptors.c | 8 src/gallium/drivers/radeonsi/si_state_draw.c | 5 + 2 files

[Mesa-dev] [PATCH 7/8] radeonsi: program additional multi draw parameters

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 30 +++- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On 08/05/2016 07:05 PM, ⚛ wrote: > On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely wrote: >> On Sat, 2016-08-06 at 02:42 +0200, Jan Ziak wrote: >>> Mesa source code prior to this patch uses both RTLD_NOW and >>> RTLD_LAZY. >>> This patch removes all RTLD_NOW in favor of

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #6 from Roland Scheidegger --- (In reply to Jules Blok from comment #5) > (In reply to Roland Scheidegger from comment #4) > > Oh I could see why it might not work with llvmpipe if you do reverse depth > > range.

Re: [Mesa-dev] [PATCH 1/6] gallium/radeon: change the vendor string to Advanced Micro Devices, Inc.

On Sat, Aug 6, 2016 at 2:04 PM, Marek Olšák wrote: > From: Marek Olšák If we want to display the marking names for each asic, we could add the marketing name api from libdrm_amdgpu that the closed driver uses. It would also reduce the delta between open

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

Brian, On Monday, 8 August 2016 08:27:40 CEST Brian Paul wrote: > On 08/06/2016 12:42 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > We need this for 'inline'. > > > > Signed-off-by: Mathias Fröhlich > > --- > >

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Hi Christian, I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I was not able to reproduce the problems Andy was facing. On Mon, Aug 8, 2016 at 6:24 PM, Christian König wrote: > Hi Nayan, > > ok let's take a

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Hi Nayan, ok let's take a step back and put the lanczos filtering aside for a moment. I have another task for you which is more urgent right now. The order we do things in vlVdpVideoMixerRender() was never 100% correct, so we have at least three problems here which needs fixing: 1) The

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

On 08/06/2016 12:42 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich We need this for 'inline'. Signed-off-by: Mathias Fröhlich --- src/gallium/auxiliary/util/u_bitcast.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] mesa: simplify ff fs generator a bit

On 08/06/2016 03:34 PM, Miklós Máté wrote: Literally. Signed-off-by: Miklós Máté --- src/mesa/main/ff_fragment_shader.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

On Fri, 2016-07-29 at 12:59 -0700, Francisco Jerez wrote: > |   for (unsigned i = 0; i < 2 * inst->regs_written; i++) > { > |  for (int c = 0; c < 4; c++) > | result_live[c] |= BITSET_TEST( > |    live, var_from_reg(alloc,

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #5 from Jules Blok --- (In reply to Roland Scheidegger from comment #4) > Oh I could see why it might not work with llvmpipe if you do reverse depth > range. We already had this problem before we reversed the

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #4 from Roland Scheidegger --- (In reply to Jules Blok from comment #3) > Created attachment 125589 [details] > apitrace file version 2 > > That's a rounding error, 16777215 / 16777216 is being rounded to 1 in

Re: [Mesa-dev] [PATCH - Mesa 06/10] Revert "st/mesa: use sRGB formats for MSAA resolving if destination is sRGB"

Reviewed-by: Nicolai Hähnle On 05.08.2016 01:14, Kenneth Graunke wrote: This reverts commit 4e549ddb500cf677b6fa16d9ebdfa67cc23da097, dropping the hack from Gallium that I just deleted from i965. See the previous commit for rationale. ---

Re: [Mesa-dev] [PATCH - Mesa 10/10] st/mesa: Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules.

I'm glad your sanity is still hanging on :) I particularly like the "Yes & No" in the comparison table. Anyway, this patch and the piglit patches are Reviewed-by: Nicolai Hähnle On 05.08.2016 01:14, Kenneth Graunke wrote: OpenGL 4.4 specifies that BlitFramebuffer

  1   2   >