[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #43 from Michel Dänzer --- (In reply to Suzuki, Shinji from comment #41) > "screen->fence_reference(screen, &fence, NULL); > is thread-safe if calls are serialized otherwise not thread safe". Not quite. screen->fence_reference(scre

Re: [Mesa-dev] [PATCH 09/24] radeon/vce: use nblk_y instead of npix_y

Am 25.10.2016 um 00:33 schrieb Marek Olšák: From: Marek Olšák npix_y will be removed. level[0].npix_y will be removed too. nblk_y should be the same as npix_y if the block height == 1. However, nblk_y is aligned to the tile size, so it can be greater than npix_y. Mhm, what if block_height is

Re: [Mesa-dev] [PATCH] radeon/vce Handle H.264 level 5.2

Am 25.10.2016 um 00:39 schrieb Andy Furniss: For gstreamer Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss --- src/gallium/drivers/radeon/radeon_vce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_v

Re: [Mesa-dev] [PATCH] st/omx/enc Raise default encode level

Am 25.10.2016 um 00:46 schrieb Andy Furniss: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss Reviewed-by: Christian König . --- src/gallium/state_trackers/omx/vid_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/s

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 Bug ID: 98428 Summary: Undefined non-weak-symbol in dri-drivers Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 NicolasChauvet changed: What|Removed |Added CC||drink...@chromium.org --- Comment #1 fr

Re: [Mesa-dev] [PATCH] nir: stop adjusting driver location for varying packing

On Tuesday, October 25, 2016 11:14:48 AM PDT Timothy Arceri wrote: > As of 59864e8e020 we just use the location assigned by the front-end and > no longer need this for i965. > > Since there were some issues in the logic with assigning arrays the same > driver location if they didn't start at the s

[Mesa-dev] [Bug 98339] dEQP-EGL: Got EGL_BAD_MATCH: eglCreateSyncKHR()

https://bugs.freedesktop.org/show_bug.cgi?id=98339 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail

[Mesa-dev] [PATCH] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfaceFormatsKHR

x11_surface_get_formats() is currently assering that the number of elements in pSurfaceFormats must be greater or equal than the number of formats available. This is buggy because later that number of elements is copied from the internal formats' array, so if pSurfaceFormatCount is greater, it will

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #44 from Suzuki, Shinji --- > screen->fence_reference(screen, &fence, NULL); > > is always thread-safe with a local variable fence, That case is thread-safe not because the variable is local but because concurrent execution is not pos

Re: [Mesa-dev] [PATCH] drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression

Gentle reminder :) Thanks! On 10/18/2016 09:55 AM, Eduardo Lima Mitev wrote: > An assert is currently raised, preventing decompression of a texture image > into > a GL_TEXTURE_3D target. I have not found any spec wording that would explain > this, or implementation detail that would prevent it.

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #45 from Suzuki, Shinji --- > feeling that solution via serialization of unref-ops blurs the nature of the > problem that is inherent in the sock code. This concern can perhaps be obviated by inserting an explicit check. if (scre

[Mesa-dev] [Bug 98344] dEQP EGL: Depth buffer rendering wrong [SKL]

https://bugs.freedesktop.org/show_bug.cgi?id=98344 Tapani Pälli changed: What|Removed |Added Summary|dEQP EGL: Depth buffer |dEQP EGL: Depth buffer

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #46 from Michel Dänzer --- (In reply to Suzuki, Shinji from comment #44) > >=> r600_fence_reference and st_client_wait_sync continue working > > with the fence object memory, which was already freed by thread > > 1. > > I see tha

Re: [Mesa-dev] [PATCH 01/25] intel/isl: Add some basic info about RENDER_SURFACE_STATE to isl_device

On Sat, Oct 22, 2016 at 10:50:32AM -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/intel/blorp/blorp_genX_exec.h| 33 -- > src/intel/isl/isl.c | 19 > src/intel/isl/isl.h | 11 +

Re: [Mesa-dev] [PATCH] nv50/ir: start LocalCSE with getFirst to merge PHI instructions

On 10/08/2016 06:58 PM, Samuel Pitoiset wrote: This breaks a bunch of things, like: spec/glsl-4.30/execution/built-in-functions/cs-all-bvec2-using-if: fail spec/glsl-4.30/execution/built-in-functions/cs-all-bvec3-using-if: fail spec/glsl-4.30/execution/built-in-functions/cs-all-bvec4-using-if:

[Mesa-dev] [Bug 98344] dEQP EGL: Depth buffer rendering wrong [SKL]

https://bugs.freedesktop.org/show_bug.cgi?id=98344 Tapani Pälli changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfaceFormatsKHR

On 10/25/2016 11:25 AM, Dave Airlie wrote: > Reviewed-by : Dave Airlie mailto:airl...@redhat.com>> > Thanks Dave. I will merge the patch later in the afternoon. Eduardo > On 25 Oct. 2016 18:39, "Eduardo Lima Mitev" > wrote: >> >> x11_surface_get_formats() is currently

Re: [Mesa-dev] [PATCH 09/24] radeon/vce: use nblk_y instead of npix_y

On Tue, Oct 25, 2016 at 9:32 AM, Christian König wrote: > Am 25.10.2016 um 00:33 schrieb Marek Olšák: >> >> From: Marek Olšák >> >> npix_y will be removed. level[0].npix_y will be removed too. nblk_y should >> be the same as npix_y if the block height == 1. However, nblk_y is aligned >> to the ti

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

On Tue, Oct 25, 2016 at 4:54 AM, Enrico Weigelt, metux IT consult wrote: > folks, > > are you looking for ways to make simple things complicated ? > > date-based versioning (eg. -MM) only makes sense, when you > have an appropriate release schedule. > > I'd really prefer semantic versioning -

Re: [Mesa-dev] [PATCH 09/24] radeon/vce: use nblk_y instead of npix_y

Am 25.10.2016 um 12:18 schrieb Marek Olšák: On Tue, Oct 25, 2016 at 9:32 AM, Christian König wrote: Am 25.10.2016 um 00:33 schrieb Marek Olšák: From: Marek Olšák npix_y will be removed. level[0].npix_y will be removed too. nblk_y should be the same as npix_y if the block height == 1. However

[Mesa-dev] [PATCH v2] radeon/vce Handle H.264 level 5.2

For gstreamer Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 v2: explicitly add case 52 Signed-off-by: Andy Furniss --- src/gallium/drivers/radeon/radeon_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium

Re: [Mesa-dev] [PATCH] nv50/ir: start LocalCSE with getFirst to merge PHI instructions

2016-10-25 11:18 GMT+02:00 Samuel Pitoiset : > > > On 10/08/2016 06:58 PM, Samuel Pitoiset wrote: >> >> This breaks a bunch of things, like: >> >> spec/glsl-4.30/execution/built-in-functions/cs-all-bvec2-using-if: fail >> spec/glsl-4.30/execution/built-in-functions/cs-all-bvec3-using-if: fail >> sp

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #47 from Marek Olšák --- What was wrong with the initial mutex idea? I think the solution in comment 22 is sufficient to close this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assigne

[Mesa-dev] [Bug 98343] dEQP-EGL: GL_INVALID_ENUM at teglCreateContextExtTests

https://bugs.freedesktop.org/show_bug.cgi?id=98343 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Tapani Pälli

[Mesa-dev] [PATCH 1/2] st/mesa: unduplicate st_check_sync code

From: Marek Olšák It's the same as st_client_wait_sync. Discovered by Michel. This is needed to make the following fix simpler. Cc: 12.0 13.0 --- src/mesa/state_tracker/st_cb_syncobj.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/mesa/stat

[Mesa-dev] [PATCH 2/2] st/mesa: allow multiple concurrent waiters in ClientWaitSync

From: Marek Olšák so->fence can be unreferenced by one thread while another thread is somewhere in ClientWaitSync and expecting so->fence to be non-NULL. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98172 Cc: 12.0 13.0 --- src/mesa/state_tracker/st_cb_syncobj.c | 26

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #48 from Marek Olšák --- I've sent my patches that fix this to mesa-dev. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ me

[Mesa-dev] [PATCH] nvc0: use correct bufctx when invalidating CP textures

Signed-off-by: Samuel Pitoiset Cc: "12.0 13.0" --- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c index cbc270d..e57391e 100644 --- a/src/ga

Re: [Mesa-dev] [PATCH 00/24] RadeonSI: Massive radeon_surf winsys interface cleanup and more

I think there is a subtle but important SI fix in patch 20 that didn't occur to me: [PATCH 20/24] gallium/radeon: don't force the same tiling parameters for FMASK .. which makes FMASK parameters completely independent of the color surface. It fixes an incorrect value in the FMASK_BANK_HEIGHT regis

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 Emil Velikov changed: What|Removed |Added CC||a...@nwnk.net, |

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #3 from Emil Velikov --- On a more comprehensive note: One of the goals behind GLVND is to reuse mesa's GLAPI and allow us to drop our "copy". The latter seems to have diminished and my attempts to get it back on board have been shot

[Mesa-dev] [PATCH 0/5] more dEQP EGL fixes

These patch fix issues in: dEQP-EGL.functional.reusable_sync.* dEQP-EGL.functional.create_context_ext.robust_gles* Tapani Pälli (5): egl: fix error handling in _eglCreateSync mesa: add missing CONTEXT_ROBUST_ACCESS enum i956: set RobustAccess true when is supported st/mesa: set Robu

[Mesa-dev] [PATCH 5/5] mesa: expose GL_EXT_robustness

Fixes 8 failing dEQP tests: dEQP-EGL.functional.create_context_ext.robust_gles* (now 42 tests pass in dEQP-EGL*robust*, 0 fail and rest are skipped) Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98343 --- src/mesa/main/extensions_table.h | 1 + 1 file cha

[Mesa-dev] [PATCH 2/5] mesa: add missing CONTEXT_ROBUST_ACCESS enum

commit 85008db1d51f923113832394d7f8d6b1868be882 missed this enum for GL_KHR_robustness implementation Signed-off-by: Tapani Pälli --- src/mapi/glapi/gen/KHR_robustness.xml | 3 +++ src/mesa/main/context.c | 3 +++ src/mesa/main/get.c | 1 + src/mesa/main/get_hash_

[Mesa-dev] [PATCH 3/5] i956: set RobustAccess true when is supported

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index d6204fd..6c1a45a 100644 --- a/src/mesa/drivers/dri/i965/brw_conte

[Mesa-dev] [PATCH 1/5] egl: fix error handling in _eglCreateSync

EGL specification requires context to be current only when sync type matches EGL_SYNC_FENCE_KHR. Fixes 25 failing dEQP tests: dEQP-EGL.functional.reusable_sync.* Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98339 --- src/egl/main/eglapi.c | 11 +-

[Mesa-dev] [PATCH 0/3] Aubinator fixes

Hi, Here are a bunch of fixes, fallouts from a previous series I sent (dealing with standard input). Cheers, Lionel Landwerlin (3): intel: aubinator: don't print out blocks twice intel: aubinator: fix assumptions on amount of required data intel: aubinator: fix printing missing gen option

[Mesa-dev] [PATCH 3/3] intel: aubinator: fix printing missing gen option

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 67f1f0d..4fee53c 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -

[Mesa-dev] [PATCH 1/3] intel: aubinator: don't print out blocks twice

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 31c1f89..11709c8 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -974,7 +974,6 @@ aub_f

[Mesa-dev] [PATCH 2/3] intel: aubinator: fix assumptions on amount of required data

We require 12 bytes of headers but in some cases we just need 4. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 11709c8..67f1f0d 100644 --- a

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

On 25 October 2016 at 01:17, Vedran Miletić wrote: > On 10/25/2016 01:41 AM, Vinson Lee wrote: >> >> Fix SCons build. drmDevicePtr is not available until libdrm 2.4.65. >> >> Compiling src/loader/loader.c ... >> src/loader/loader.c:111:40: error: unknown type name ‘drmDevicePtr’ >> static char

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

On 10/25/2016 04:15 AM, Michel Dänzer wrote: > On 25/10/16 11:01 AM, Michel Dänzer wrote: >> On 25/10/16 09:17 AM, Vedran Miletić wrote: >>> On 10/25/2016 01:41 AM, Vinson Lee wrote: Fix SCons build. drmDevicePtr is not available until libdrm 2.4.65. Compiling src/loader/loader.c .

Re: [Mesa-dev] [PATCH 0/5] more dEQP EGL fixes

On Tuesday, 2016-10-25 14:49:06 +0300, Tapani Pälli wrote: > These patch fix issues in: >dEQP-EGL.functional.reusable_sync.* >dEQP-EGL.functional.create_context_ext.robust_gles* The series is Reviewed-by: Eric Engestrom > > Tapani Pälli (5): > egl: fix error handling in _eglCreateSyn

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #49 from Suzuki, Shinji --- (In reply to Marek Olšák from comment #47) > What was wrong with the initial mutex idea? I think the solution in comment > 22 is sufficient to close this bug. I did not like added storage overhead of contai

[Mesa-dev] [Bug 97524] Samplers referring to the same texture unit with different types should raise GL_INVALID_OPERATION

https://bugs.freedesktop.org/show_bug.cgi?id=97524 --- Comment #12 from Matias N. Goldberg --- I believe the error should happen in either glLinkProgram or glUseProgram, and then every time glDraw* is called. If I recall correctly AMD's Windows driver raised the error every time glDrawArrays was

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

https://bugs.freedesktop.org/show_bug.cgi?id=98279 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivin

Re: [Mesa-dev] [PATCH] gallium/radeon: make sure HTILE address is aligned properly

Reviewed-by: Nicolai Hähnle On 24.10.2016 21:39, Marek Olšák wrote: From: Marek Olšák This should fix random GPU hangs on Hawaii and Fiji. It's already been fixed in 13.0 and later. Cc: 11.2 12.0 --- src/gallium/drivers/radeon/r600_texture.c | 17 ++--- 1 file changed, 10 inser

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: critical fixes

On 25.10.2016 00:23, Marek Olšák wrote: Patch 1: SI fix for MSAA for Mesa 13.0. I don't know the impact of that bug. Patch 2: Possible GPU hang fix for Hawaii and Fiji when using separate CMASK. Patch 3: Addrlib integration fix that hopefully resolves our SDMA issues. Patch 4: Let's enable SDMA a

Re: [Mesa-dev] [PATCH 1/2] st/mesa: unduplicate st_check_sync code

On 25.10.2016 13:18, Marek Olšák wrote: From: Marek Olšák It's the same as st_client_wait_sync. Discovered by Michel. This is needed to make the following fix simpler. The series is: Reviewed-by: Nicolai Hähnle Cc: 12.0 13.0 --- src/mesa/state_tracker/st_cb_syncobj.c | 26 ++---

Re: [Mesa-dev] [PATCH v2 6/6] i965/miptree: Remove the width/height < 32768 restrictions

Hi, On 25.10.2016 06:40, Jason Ekstrand wrote: These restrictions existed because intel_miptree_blit couldn't handle surfaces bigger than 32k. How that we're chopping blits up into chunks, it can handle any size we throw at it so we can get rid of this restriction. This improves the terrain tes

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #38 from Vedran Miletić --- (In reply to Micael Bergeron from comment #37) > The number of shaders is quite astonishing. > > Could using the r600 shader compiler LLVM (--enable-r600-llvm-compiler) fix > this? > I don't see this opt

Re: [Mesa-dev] [PATCH 03/24] gallium/radeon: use r600_gfx_write_event_eop everywhere

On 25.10.2016 00:33, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 +++- src/gallium/drivers/radeon/r600_query.c | 17 - src/gallium/drivers/radeonsi/si_state_draw.c | 12 +++- 3 files changed, 10 insertions(+), 23 de

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

On 10/25/2016 02:01 AM, Nayan Deshmukh wrote: Hi Leo, On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: There are a couple of other issues from a brief test: 1. Compile warnings for presentation.c. I will fix this in v2 with the changes that christian suggested, it might be because o

Re: [Mesa-dev] [PATCH 3/9] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

On Mon, 2016-10-24 at 14:09 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > >   > > > > > > +   | layout_qualifier BUFFER ';' > > ; > >   > >  layout_in_defaults: > > layout_qualifier layout_in_defaults > > { > > -  $$ = NULL; > > +  $

Re: [Mesa-dev] [PATCH 00/24] RadeonSI: Massive radeon_surf winsys interface cleanup and more

One small remark on #3 that I'll leave up to you what to do with it. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 25.10.2016 00:33, Marek Olšák wrote: Hi, Most of this series cleans up the radeon_surf-based winsys interface, and texture, fmask, and metadata (cmask, htile) al

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

On Tue, Oct 25, 2016 at 11:08:12AM -0400, Leo Liu wrote: > > > On 10/25/2016 02:01 AM, Nayan Deshmukh wrote: > > Hi Leo, > > > > On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: > > > There are a couple of other issues from a brief test: > > > > > > 1. Compile warnings for presentation.

[Mesa-dev] [PATCH] configure.ac: simplify EGL requirements for drivers dependent on EGL

From: Marek Olšák --- configure.ac | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 30817d8..588d11d 100644 --- a/configure.ac +++ b/configure.ac @@ -2289,36 +2289,35 @@ dnl Gallium helper functions dnl gallium_

Re: [Mesa-dev] [PATCH 6/9] glsl: push layout-qualifier-name values from variable declarations to global

On Mon, 2016-10-24 at 13:44 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > > After the previous modifications in the merging of the > > layout-qualifier-name values, we no longer push the final value in a > > declaration to the global values. > > > > This r

Re: [Mesa-dev] [PATCH 9/9] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

On Mon, 2016-10-24 at 14:09 +1100, Timothy Arceri wrote: > I'm not sure we can do this see my last commets to patch 3. As commented previously, I've created new tests for input, output, uniform and global default declarations using non-value layout- qualifier-ids and multiple layout-qualifiers in

[Mesa-dev] [PATCH] glsl: inspect interfaces in contains_foo()

When checking if a type contains doubles, integers, samples, etc. we check if the current type is a record or array, but not if it is an interface. This commit also inspects if the type is an interface. It fixes spec/arb_enhanced_layouts/compiler/transform-feedback-layout-qualifiers/xfb_offset/i

[Mesa-dev] [PATCH] glsl: inspect interfaces in contains_foo()

When checking if a type contains doubles, integers, samples, etc. we check if the current type is a record or array, but not if it is an interface. This commit also inspects if the type is an interface. It fixes spec/arb_enhanced_layouts/compiler/transform-feedback-layout-qualifiers/xfb_offset/i

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

On Wed, Oct 19, 2016 at 03:34:12PM -0700, Ian Romanick wrote: > On 10/19/2016 12:58 PM, Matt Turner wrote: > > On Wed, Oct 19, 2016 at 12:06 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > >> This patch removes locks around reference counts in favor of atomic inc/dec > >> operations on the refcoun

Re: [Mesa-dev] [PATCH] i965: Skip register write checks if cmd_parser_version >= 2.

On Wed, Oct 19, 2016 at 02:26:15PM -0700, Kenneth Graunke wrote: > On Wednesday, October 19, 2016 8:35:11 PM PDT Chris Wilson wrote: > > On Wed, Oct 19, 2016 at 12:25:51PM -0700, Kenneth Graunke wrote: > > > If the kernel advertises a new enough command parser version, then we > > > can just assume

Re: [Mesa-dev] [PATCH] nvc0: use correct bufctx when invalidating CP textures

Good one. Reviewed-by: Ilia Mirkin On Tue, Oct 25, 2016 at 7:24 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > Cc: "12.0 13.0" > --- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouve

Re: [Mesa-dev] [PATCH] i965: Skip register write checks if cmd_parser_version >= 2.

On Tue, Oct 25, 2016 at 05:57:14PM +0200, Daniel Vetter wrote: > On Wed, Oct 19, 2016 at 02:26:15PM -0700, Kenneth Graunke wrote: > > On Wednesday, October 19, 2016 8:35:11 PM PDT Chris Wilson wrote: > > > On Wed, Oct 19, 2016 at 12:25:51PM -0700, Kenneth Graunke wrote: > > > > If the kernel advert

[Mesa-dev] [Bug 97524] Samplers referring to the same texture unit with different types should raise GL_INVALID_OPERATION

https://bugs.freedesktop.org/show_bug.cgi?id=97524 --- Comment #13 from Roland Scheidegger --- (In reply to Matias N. Goldberg from comment #12) > I believe the error should happen in either glLinkProgram or glUseProgram, > and then every time glDraw* is called. This is impossible, since the valu

Re: [Mesa-dev] [PATCH] i965: Skip register write checks if cmd_parser_version >= 2.

Kenneth Graunke writes: > If the kernel advertises a new enough command parser version, then we > can just assume that register writes will work and not bother executing > commands on the GPU to test it. > > This should speed up context creation. > > From the command parser version history (i915_

Re: [Mesa-dev] [PATCH] configure.ac: simplify EGL requirements for drivers dependent on EGL

Reviewed-by: Emil Velikov I owe you a beer or a few, thanks again ! Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: mark the fence as submitted and signalled in vkAcquireNextImageKHR

This stops the debug layers from complaining when fences are used to throttle image acquisition. --- src/amd/vulkan/radv_device.c | 6 -- src/amd/vulkan/radv_private.h | 7 +++ src/amd/vulkan/radv_wsi.c | 14 +++--- 3 files changed, 18 insertions(+), 9 deletions(-) diff --g

[Mesa-dev] [Bug 97524] Samplers referring to the same texture unit with different types should raise GL_INVALID_OPERATION

https://bugs.freedesktop.org/show_bug.cgi?id=97524 --- Comment #14 from Matias N. Goldberg --- Dang it! You're right. I forgot GL allows (requires?) changing sampler values after the shader is compiled. As for glValidateProgram, our actual software (not this sample) would often warn about sampl

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if it's available or not. Keep in mind that we pos

[Mesa-dev] [PATCH 2/2] radv: Replace "abi_versions" with correct "api_version".

git history shows "abi_versions" was used from the outset. Cc: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98415 --- src/amd/vulkan/dev_icd.json.in | 2 +- src/amd/vulkan/radeon_icd.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/dev_icd.json

[Mesa-dev] [PATCH 1/2] anv: Replace "abi_versions" with correct "api_version".

git history shows "abi_versions" was used from the outset. Cc: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98415 --- src/intel/vulkan/dev_icd.json.in | 2 +- src/intel/vulkan/intel_icd.json.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/de

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #4 from ajax at nwnk dot net --- (In reply to Emil Velikov from comment #3) > On a more comprehensive note: > > One of the goals behind GLVND is to reuse mesa's GLAPI and allow us to drop > our "copy". The latter seems to have dimini

Re: [Mesa-dev] [PATCH 2/2] radv: Replace "abi_versions" with correct "api_version".

On Tue, Oct 25, 2016 at 11:49 AM, Matt Turner wrote: > git history shows "abi_versions" was used from the outset. > > Cc: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98415 > --- > src/amd/vulkan/dev_icd.json.in | 2 +- > src/amd/vulkan/radeon_icd.json | 2 +- > 2 files changed, 2 in

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

On 10/25/2016 02:42 PM, Andy Furniss wrote: Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if i

[Mesa-dev] [PATCH 0/7] nvc0: various perf improvements for Elemental

Hi, This little series tries to improve performance with the Elemental demo (Unreal) and I actually have +6% FPS on both Fermi/Kepler. It's not THAT much, but few weeks ago I also improved that demo by +15%. But this time I looked mostly into the draw path and the invalidation between compute and

[Mesa-dev] [PATCH 3/7] nvc0: simplify draw parameters upload for vertex shaders

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c b/src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c index 138e24d..11fd7eb 100644 --- a/src/gall

[Mesa-dev] [PATCH 1/7] nvc0: reduce the number of PUSH_SPACE in draw path

This might help CPU-bounds applications but should not have any real effects for GPU-bounds ones. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c

[Mesa-dev] [PATCH 6/7] nvc0: only invalidate currently bound tic/tsc

This is especially useful when switching from compute to 3D. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 11 +++ src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 14 ++ src/gallium/drivers/nouveau/nvc0/nve4_compute.c | 11 +++

[Mesa-dev] [PATCH 2/7] nvc0: only update primitive restart for indexed draws

Unnecessary to update it at every draw calls, especially for non-indexed draws. This is similar to what nv50 already does. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/n

[Mesa-dev] [PATCH 7/7] nvc0: add support for PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

Loosely based on radeonsi, thanks Nicolai! Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_miptree.c | 13 src/gallium/drivers/nouveau/nv50/nv50_resource.h | 3 ++- src/gallium/drivers/nouveau/nvc0/nvc0_miptree.c | 6 -- src/gallium/drivers/nouveau/n

[Mesa-dev] [PATCH 5/7] nvc0: clean nve4_compute_validate_textures()

It's not particularily useful to store commands which are going to be send few lines after. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nve4_compute.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/n

[Mesa-dev] [PATCH 4/7] nvc0: be smarter when invalidating shader caches

MEM_BARRIER seems to be similar to FLUSH, thus bit 0 is for flushing code while bit 12 is for constant buffers. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 2 +- 2 files changed, 2 insertions(+), 2 d

Re: [Mesa-dev] [PATCH 1/7] nvc0: reduce the number of PUSH_SPACE in draw path

What if instance_count = 1M? (It can happen.) On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > This might help CPU-bounds applications but should not have > any real effects for GPU-bounds ones. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 8

Re: [Mesa-dev] [PATCH 01/26] i965/meta: Split conversion of color and setting it

On Wed, Oct 19, 2016 at 02:29:17PM -0700, Ben Widawsky wrote: > On 16-10-11 22:26:33, Topi Pohjolainen wrote: > > And fix a mangled comment while at it. > > > > Signed-off-by: Topi Pohjolainen > > CC: Ben Widawsky > > CC: Jason Ekstrand > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 7

Re: [Mesa-dev] [PATCH 4/7] nvc0: be smarter when invalidating shader caches

And bit 4 is for ... ? I've only ever seen the blob use the value 0x1011. You're right that it's a bitfield, but there's all kinds of crazy caches =/ On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > MEM_BARRIER seems to be similar to FLUSH, thus bit 0 is for > flushing code while bit 12

Re: [Mesa-dev] [PATCH 5/7] nvc0: clean nve4_compute_validate_textures()

It's useful because it lets you avoid having to send a bunch of begins. NAK. On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > It's not particularily useful to store commands which are > going to be send few lines after. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nou

Re: [Mesa-dev] [PATCH 6/7] nvc0: only invalidate currently bound tic/tsc

On Tue, Oct 25, 2016 at 3:41 PM, Samuel Pitoiset wrote: > This is especially useful when switching from compute to 3D. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 11 +++ > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 14 ++---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Leo Liu wrote: On 10/25/2016 02:42 PM, Andy Furniss wrote: Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function witho

[Mesa-dev] [PATCH 1/2] glsl: Pass ctx to program interface query helper functions.

The next commit will use this in add_shader_variable - this just separates out some of the mechanical changes for easier review. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke --- src/compiler/glsl/linker.cpp | 33 - 1 file changed, 20 insert

[Mesa-dev] [PATCH 2/2] glsl: Size TCS->TES unsized arrays to gl_MaxPatchVertices for queries.

SSO validation and other program interface queries want to see that unsized (non-patch) TCS output/TES input arrays are implicitly sized to gl_MaxPatchVertices. By the time we create the program resource lists, we've sized the arrays to their actual size. (We try to create TCS output arrays to ma

[Mesa-dev] [PATCH] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 58 ++--- 1 file changed, 32 insertions(+), 26 deletio

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Regards, Nayan. _

Re: [Mesa-dev] [PATCH v2 4/6] i965/blit: Break blits into chunks in set_alpha_to_one

On Mon, Oct 24, 2016 at 08:40:44PM -0700, Jason Ekstrand wrote: > v2: Properly handle linear blit alignment restrictions > > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/intel_blit.c | 88 > -- > 1 file changed, 73 insertions(+), 15 deletions(-

[Mesa-dev] [Bug 98448] Can't init or use the opengl or 3D

https://bugs.freedesktop.org/show_bug.cgi?id=98448 Bug ID: 98448 Summary: Can't init or use the opengl or 3D Product: Mesa Version: git Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity: blocker

[Mesa-dev] [Bug 98448] Can't init or use the opengl or 3D

https://bugs.freedesktop.org/show_bug.cgi?id=98448 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Nayan Deshmukh wrote: Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Patch

[Mesa-dev] [PATCH] i965: Fix GPU hang related to multiple render targets and alpha testing

In a situation when there are multiple render targets with alpha testing enabled, if fragment shader doesn't write to draw buffer zero, it causes the GPU hang on SKL. No GPU hang is seen on HSW. Simulator gives a warning for all gen6+ h/w: "Illegal render target write message length 0xa expected 0x

  1   2   >