Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer wrote: > On 28/10/16 03:08 AM, Marek Olšák wrote: > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov > wrote: > >> On 17 October 2016 at 10:37, Marek Olšák wrote: > >>> Reverting the whole commit is too much. You can just remove the PIPE > BIND > >>

[Mesa-dev] [PATCH 3/5] nir/vc4: pass shader_info to nir_shader_create() in nir_shader_clone()

2016-10-27 Thread Timothy Arceri
This requires us to free shader_info manually when there is no memory context, st_program is the only thing that doesn't pass a context. As far as I could tell freedreno is leaking nir_shader so this doesn't free anything there. --- src/compiler/nir/nir_clone.c | 3 ++- src/gallium/drive

[Mesa-dev] [PATCH 5/5] nir/mesa: always pass shader_info to nir_shader_create() from nir_builder_init_simple_shader()

2016-10-27 Thread Timothy Arceri
Both radv and freedreno seem to leak nir_shader where created with nir_builder_init_simple_shader() there is no attempt to fix that in this patch. --- src/compiler/nir/nir_builder.h | 4 +++- src/mesa/program/prog_to_nir.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 4/5] i965: use memory context when creating passthrough tcs

2016-10-27 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_tcs.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c index 58d080d..7beccd7 100644 --- a/src/mesa/drivers/dri/i965/brw_tcs.c +++ b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 2/5] nir: fix nir_shader_clone()

2016-10-27 Thread Timothy Arceri
This was broken in e1af20f18a8 when the info field in nir_shader was turned into a pointer. --- src/compiler/nir/nir_clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_clone.c b/src/compiler/nir/nir_clone.c index f23fabc..4f7bdd9 100644 --- a/src/compi

[Mesa-dev] [PATCH 1/5] radv/anv/spirv: create shader_info in the driver and pass it to spirv_to_nir()

2016-10-27 Thread Timothy Arceri
This will allow us to later detach shader_info from nir_shader. --- src/amd/vulkan/radv_pipeline.c| 21 +++- src/compiler/spirv/nir_spirv.h| 3 ++- src/compiler/spirv/spirv2nir.c| 7 ++- src/compiler/spirv/spirv_to_nir.c | 4 ++-- src/intel/vulkan/anv_pipeline.c

[Mesa-dev] Separate shader_info and nir_shader Part 1

2016-10-27 Thread Timothy Arceri
This series should fix the current use-after-free-caused segfaults in the tgsi_to_nir() path (compile tested only). Part 2 will remove the pointer to shader_info in nir_shader. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freed

Re: [Mesa-dev] [PATCH] intel/blorp: remove stale comment

2016-10-27 Thread Jason Ekstrand
Heh... very stale. Reviewed-by: Jason Ekstrand On Thu, Oct 27, 2016 at 10:27 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > --- > src/intel/blorp/blorp_blit.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c > i

[Mesa-dev] [PATCH] intel/blorp: remove stale comment

2016-10-27 Thread Timothy Arceri
--- src/intel/blorp/blorp_blit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 9357a72..4fefa4e 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -1237,9 +1237,6 @@ brw_blorp_get_blit_kernel(str

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Tapani Pälli
On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it is at least *a* solution to a problem with android wallpaper vs mesa that I've been debugging. Ba

[Mesa-dev] [PATCH] glsl: Improve accuracy of alpha scaling in advanced blend lowering.

2016-10-27 Thread Kenneth Graunke
When blending with GL_COLORBURN_KHR and these colors: dst = <0.372549027, 0.372549027, 0.372549027, 0.372549027> src = <0.09375, 0.046875, 0.0, 0.375> the normalized dst value became 0.9994 (due to precision problems in the floating point divide of rgb by alpha). This caused the color

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Michel Dänzer
On 27/10/16 10:01 PM, Christian König wrote: > Am 27.10.2016 um 13:14 schrieb Emil Velikov: >> On 27 October 2016 at 12:06, Andres Gomez wrote: >>> On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails t

Re: [Mesa-dev] [PATCH] nir: fix nir_shader_clone()

2016-10-27 Thread Timothy Arceri
On Fri, 2016-10-28 at 12:53 +1100, Timothy Arceri wrote: > This was broken in e1af20f18a8 when the info field in nir_shader was > turned into a pointer. > > Cc: Eric Anholt > --- > >  I was part was through refactoring everything when I noticed this. > Does this >  fix your problem? Nevermind.

Re: [Mesa-dev] [PATCH 48.1/59 v2] nir: Shift count for shift opcodes is always 32-bits

2016-10-27 Thread Connor Abbott
On Thu, Oct 27, 2016 at 10:06 PM, Ian Romanick wrote: > From: Ian Romanick > > Previously both sources were unsized. This caused problems when the > thing being shifted was 64-bit but the shift count was 32-bit. The > expectation in NIR is that all unsized sources (and destination) will > ultim

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Ian Romanick
On 10/27/2016 05:40 AM, Nicolai Hähnle wrote: > On 26.10.2016 02:59, Ian Romanick wrote: >> From: Ian Romanick >> >> This is only in libstandalone currently because it will only be used in >> the stand-alone compiler. >> >> v2: Change the signature of the generated function. The ir_factory is >>

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Ian Romanick
On 10/27/2016 04:16 AM, Iago Toral wrote: > I spent some time looking at this and trying and I did not find > anything that did not look reasonable to me in general. I have a > question below, but in any case this is: > > Reviewed-by: Iago Toral Quiroga > > BTW, now I also see why you need patch

Re: [Mesa-dev] [PATCH 11/59] glsl: Add basic ARB_gpu_shader_int64 types

2016-10-27 Thread Ian Romanick
On 10/27/2016 05:52 AM, Nicolai Hähnle wrote: > On 26.10.2016 02:59, Ian Romanick wrote: >> From: Dave Airlie >> >> This adds the builtins and the lexer support. >> >> To avoid too many warnings, it adds basic support to the type in a few >> other places in mesa, mostly in the trivial places. >> >

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: > On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > > > > On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > > > > > > Agreed but as far as I can tell we shouldn't even need > > > gl_linked_shader > > > after glL

[Mesa-dev] [PATCH 48.1/59 v2] nir: Shift count for shift opcodes is always 32-bits

2016-10-27 Thread Ian Romanick
From: Ian Romanick Previously both sources were unsized. This caused problems when the thing being shifted was 64-bit but the shift count was 32-bit. The expectation in NIR is that all unsized sources (and destination) will ultimately have the same size. The changes in nir_opt_algebraic.py are

[Mesa-dev] [PATCH] nir: fix nir_shader_clone()

2016-10-27 Thread Timothy Arceri
This was broken in e1af20f18a8 when the info field in nir_shader was turned into a pointer. Cc: Eric Anholt --- I was part was through refactoring everything when I noticed this. Does this fix your problem? src/compiler/nir/nir_clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Kenneth Graunke
On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > > Agreed but as far as I can tell we shouldn't even need > > gl_linked_shader > > after glLinkProgram. > > > > We should probably just free it after linking. Everything w

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Michel Dänzer
On 28/10/16 03:08 AM, Marek Olšák wrote: > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov > wrote: >> On 17 October 2016 at 10:37, Marek Olšák wrote: >>> Reverting the whole commit is too much. You can just remove the PIPE BIND >>> SHARED usage if you need to. >>> >> I'd imagine that one wants to

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Michel Dänzer
On 27/10/16 07:52 PM, Andy Furniss wrote: > Andy Furniss wrote: >> Michel Dänzer wrote: >>> On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Flux

Re: [Mesa-dev] [PATCH v2] glsl: compute lvalues of [in]out parameters before inlined function body

2016-10-27 Thread Ian Romanick
On 10/20/2016 02:00 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is required when an out argument involves an array index that is either > a global variable modified by the function or another out argument in the > same function call. > > Fixes the shaders/out-parameter-indexing/vs-

[Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2016-10-27 Thread Robert Bragg
typo fixed (thanks) --- >8 --- Prior to Skylake the Gen HW timestamps were driven by a 12.5MHz clock with the convenient property of being able to scale by an integer (80) to nanosecond units. For Skylake the frequency is 12MHz or a scale factor of 83.33 This updates gen_device_info to trac

Re: [Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2016-10-27 Thread Matt Turner
On Thu, Oct 27, 2016 at 4:56 PM, Robert Bragg wrote: > Prior to Skylake the Gen HW timestamps were driven by a 12.5MHz clock > with the convenient property of being able to scale by an integer (80) > to nanosecond units. > > For Skylake the frequency is 12MHz or a scale factor of 83.33 > > Thi

[Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2016-10-27 Thread Robert Bragg
Prior to Skylake the Gen HW timestamps were driven by a 12.5MHz clock with the convenient property of being able to scale by an integer (80) to nanosecond units. For Skylake the frequency is 12MHz or a scale factor of 83.33 This updates gen_device_info to track a floating point timebase_scale

Re: [Mesa-dev] [PATCH] radv: add support for anisotropic filtering on VI+

2016-10-27 Thread Fredrik Höglund
On Thursday 27 October 2016, Fredrik Höglund wrote: > On Thursday 27 October 2016, Roland Scheidegger wrote: > > On 10/26/2016 06:02 PM, Fredrik Höglund wrote: > > > Ported from radeonsi. > > > --- > > > src/amd/vulkan/radv_device.c | 30 +++--- > > > 1 file changed, 27 ins

Re: [Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

2016-10-27 Thread Jason Ekstrand
On Thu, Oct 27, 2016 at 2:47 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Thu, 2016-10-27 at 13:57 -0700, Jason Ekstrand wrote: > > On Thu, Oct 27, 2016 at 1:30 PM, Eric Anholt wrote: > > > Fixes use-after-free-caused segfaults in the tgsi_to_nir() path. > > > --- > > > > > > I

Re: [Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 13:57 -0700, Jason Ekstrand wrote: > On Thu, Oct 27, 2016 at 1:30 PM, Eric Anholt wrote: > > Fixes use-after-free-caused segfaults in the tgsi_to_nir() path. > > --- > > > > I don't like the boolean I added here, any better plans, though?  I > > haven't fully piglited this,

Re: [Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

2016-10-27 Thread Jason Ekstrand
On Thu, Oct 27, 2016 at 1:30 PM, Eric Anholt wrote: > Fixes use-after-free-caused segfaults in the tgsi_to_nir() path. > --- > > I don't like the boolean I added here, any better plans, though? I > haven't fully piglited this, but it's enough to get gears to not crash > on master (it at least to

[Mesa-dev] [PATCH 1/2] nir: Avoid making an unused info struct in cloning shaders.

2016-10-27 Thread Eric Anholt
We were implictly making one in create, which would get overwritten by ns->info = s->info below and hang around until nir_sweep() time. --- src/compiler/nir/nir_clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_clone.c b/src/compiler/nir/nir_clone.c i

[Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

2016-10-27 Thread Eric Anholt
Fixes use-after-free-caused segfaults in the tgsi_to_nir() path. --- I don't like the boolean I added here, any better plans, though? I haven't fully piglited this, but it's enough to get gears to not crash on master (it at least touches the GLSL to NIR and TGSI to NIR paths.) src/compiler/nir/

Re: [Mesa-dev] [PATCH v2 4/6] i965/blit: Break blits into chunks in set_alpha_to_one

2016-10-27 Thread Anuj Phogat
On Mon, Oct 24, 2016 at 8:40 PM, Jason Ekstrand wrote: > v2: Properly handle linear blit alignment restrictions > > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/intel_blit.c | 88 > -- > 1 file changed, 73 insertions(+), 15 deletions(-) > > dif

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-27 Thread Marek Olšák
On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli wrote: > On 10/21/2016 04:57 PM, Eero Tamminen wrote: >> >> Hi, >> >> On 21.10.2016 14:07, Tapani Pälli wrote: >>> >>> I did run some valgrind comparisons with gfxbench4, your branch against >>> Mesa master. I did not spot anything obvious related to r

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:07 PM, Leo Liu wrote: > > > On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: > > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >>> On

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Marek Olšák
On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov wrote: > On 17 October 2016 at 10:37, Marek Olšák wrote: >> Reverting the whole commit is too much. You can just remove the PIPE BIND >> SHARED usage if you need to. >> > I'd imagine that one wants to check if radeon(s) behave OK with the > flag dropp

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Robert Foss
I gave this patch a spin on a Qemu+Virgl+AOSP setup, and it seems to work rather well. Thanks Rob! Tested-by: Robert Foss ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu > wrote: On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55 AM, Nayan Deshmukh

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:50 PM, Nayan Deshmukh wrote: > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote:

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > > > On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: > >> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >> >>> >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: >>> Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_w

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: > > > On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: > > Suggested-by: Leo Liu > > Signed-off-by: Nayan Deshmukh > > --- > > src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ > > src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 > >

[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-27 Thread Gurchetan Singh
In Android, the pthreads libs are in bionic. When building Mesa for Android with the autotools workflow, we shouldn't set -lpthread or -pthread. --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4761c59..3f21cd5 100644 --

[Mesa-dev] [PATCH 2/2] egl: Use pkg-config for Android NDK build

2016-10-27 Thread Gurchetan Singh
It's possible to build Mesa for Android using the traditional autotools workflow. To enable this, let's add the required pkg-config checks and link against them. --- configure.ac| 3 +++ src/egl/Makefile.am | 1 + 2 files changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac

Re: [Mesa-dev] [PATCH 5/5] swr: [rasterizer] added EventHandlerFile contructor

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > --- > .../rasterizer/scripts/templates/ar_eventhandlerfile_h.template| 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git > a/src/gallium/drivers/swr/rasterizer/scripts/template

Re: [Mesa-dev] [PATCH 4/5] swr: [rasterizer core] Frontend dependency work

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Add frontend dependency concept in the DRAW_CONTEXT, which > allows serialization of frontend work if necessary. > --- > src/gallium/drivers/swr/rasterizer/core/api.cpp | 3 +++ > src/gallium/drivers/s

Re: [Mesa-dev] [PATCH 3/5] swr: [rasterizer core] Refactor/cleanup backends

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Used for common code reuse and simplification > --- > .../drivers/swr/rasterizer/core/backend.cpp| 561 - > src/gallium/drivers/swr/rasterizer/core/backend.h | 150 +- > 2 fi

Re: [Mesa-dev] [PATCH 2/5] swr: [rasterizer core] Remove deprecated simd intrinsics

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Used in abandoned all-or-nothing approach to converting to AVX512 > --- > .../drivers/swr/rasterizer/common/simdintrin.h | 633 - > .../drivers/swr/rasterizer/core/format_types.h

Re: [Mesa-dev] [PATCH 1/5] swr: [rasterizer archrast] Add thread tags to event files.

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > This allows the post-processor to easily detect the API thread and to > process frame information. The frame information is needed to > optimized how data is processed from worker threads. > --- > src/gall

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #4 from Kai --- The problem was not so much me not seeing that message, the problem was more that I didn't connect "no DRI3 support" equals "this game won't start and segfault. Combine that with the warning "WARNING: radv is not a con

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #3 from Emil Velikov --- Hi Kai, feel free to send a patch which makes the "vulkan: No DRI3 support" message less likely to miss ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee fo

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Emil Velikov
On 17 October 2016 at 10:37, Marek Olšák wrote: > Reverting the whole commit is too much. You can just remove the PIPE BIND > SHARED usage if you need to. > I'd imagine that one wants to check if radeon(s) behave OK with the flag dropped ? Thus it might be better for someone with radeon HW to give

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 98263, which changed state. Bug 98263 Summary: [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode." https://bugs.freedesktop.org/show_bug.cgi?id=98263 What|Removed

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 Kai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 96309] Request for new account

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 +++ 2 files changed, 83 insertions(+), 10 deletions(-) diff

[Mesa-dev] [Bug 96309] Request for new account

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 --- Comment #5 from Rob Clark --- +1 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.o

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Nicolai Hähnle
On 27.10.2016 15:43, Alex Deucher wrote: On Thu, Oct 27, 2016 at 9:40 AM, Nicolai Hähnle wrote: On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Alex Deucher
On Thu, Oct 27, 2016 at 9:40 AM, Nicolai Hähnle wrote: > On 26.10.2016 01:16, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/src/gallium/drivers/radeonsi/si_state.c >> b/src/galli

Re: [Mesa-dev] [PATCH] radeonsi: fix behavior of GLSL findLSB(0)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák 12.0 and older need the same fix but elsewhere. Cc: 13.0 --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shad

Re: [Mesa-dev] [PATCH] gallium/radeon: fix behavior of GLSL findLSB(0)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:17, Marek Olšák wrote: From: Marek Olšák This is for 12.0 and older. A different commit fixes 13.0 and newer. Cc: 11.2 12.0 Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 19 ++- 1 file changed, 14 insertions(+), 5

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 42689da..0633b64 100644 --- a/src/gallium/d

Re: [Mesa-dev] [PATCH] glsl: inspect interfaces in contains_foo()

2016-10-27 Thread Nicolai Hähnle
On 25.10.2016 17:53, Juan A. Suarez Romero wrote: When checking if a type contains doubles, integers, samples, etc. we check if the current type is a record or array, but not if it is an interface. This commit also inspects if the type is an interface. It fixes spec/arb_enhanced_layouts/compil

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Emil Velikov
On 27 October 2016 at 12:41, Andres Gomez wrote: > On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: >> On 27 October 2016 at 12:06, Andres Gomez wrote: >> > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: >> > > Hi, >> > > >> > > recently, we have noticed that we are not receiving so

Re: [Mesa-dev] [PATCH 31/59] st/glsl_to_tgsi: add support for 64-bit integers. (v2)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie v2: add conversion opcodes. v3 (idr): Rebase on replacemtn of TGSI_OPCODE_I2U64 with TGSI_OPCODE_I2I64. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 217 ++--- 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems

Re: [Mesa-dev] [PATCH 13/59] glsl/ast/ir: Add 64-bit integer constant support

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This adds support for 64-bit integer constants to the parser, ast and ir. v2: fix a few issues found in testing. v3: Add missing ir_constant copy contructor support. Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick [v2] --- sr

Re: [Mesa-dev] [PATCH 12/59] mesa: Add support for 64-bit integer uniforms. (v2)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This hooks up the API to the internals for 64-bit integer uniforms. v2: update to use non-strict aliased alternatives Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/mesa/main/uniform_query.cpp | 82 ++

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Christian König
Am 27.10.2016 um 13:14 schrieb Emil Velikov: On 27 October 2016 at 12:06, Andres Gomez wrote: On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails that we have sent to the ML. The mails are archived, though, but we d

Re: [Mesa-dev] [PATCH 11/59] glsl: Add basic ARB_gpu_shader_int64 types

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This adds the builtins and the lexer support. To avoid too many warnings, it adds basic support to the type in a few other places in mesa, mostly in the trivial places. It also adds a query to be used later for if a type is an integer

Re: [Mesa-dev] [PATCH 0/3] Flex 2.6.2 build fixes

2016-10-27 Thread Mike Lothian
Thanks On Thu, 27 Oct 2016 at 12:51 Emil Velikov wrote: > Hi all, > > As pointed out by Mike, building Mesa with latest version of flex is > not possible. > > Upon closer look it seems that the following functions are not expanded > properly (the #define yyfoo ${prefix}foo is missing). > > yylex

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Ian Romanick This is only in libstandalone currently because it will only be used in the stand-alone compiler. v2: Change the signature of the generated function. The ir_factory is created in the generator, and an availability predicate is taken

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Felix Schwarz
Am 27.10.2016 um 13:14 schrieb Emil Velikov: > Skimming through the above they have arrived in timely manner over here. > It might be worth checking if it's not something on your end - ISP > and/or local infra. Seems like a fdo issue to me: ,---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: > Andy Furniss wrote: > > Michel Dänzer wrote: > > > On 26/10/16 08:07 PM, Andy Furniss wrote: > > > > > > > > The bad = Starting with DRI3 (which is default) I still get trashed > > > > rendering full screen. Windowed including re-sizi

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Thu, 2016-10-27 at 14:47 +0300, Martin Peres wrote: > These are know issues and are being investigated by the freedes Thanks Martin! -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listin

[Mesa-dev] [PATCH 0/3] Flex 2.6.2 build fixes

2016-10-27 Thread Emil Velikov
Hi all, As pointed out by Mike, building Mesa with latest version of flex is not possible. Upon closer look it seems that the following functions are not expanded properly (the #define yyfoo ${prefix}foo is missing). yylex_init_extra yylex_destroy yy_scan_* Not 100% sure if this is flex bug o

[Mesa-dev] [PATCH 2/3] mesa/program: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Cc: "12.0 13.0" Signed-off-by: Emil Velikov --- src/mesa/program/program_lexer.l | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/program_lexer.l b/src/mesa/program/program_lexer.l index dee66cb..019663

[Mesa-dev] [PATCH 3/3] glsl/glcpp: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Cc: "12.0 13.0" Signed-off-by: Emil Velikov --- src/compiler/glsl/glcpp/glcpp-lex.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/glcpp-lex.l b/src/compiler/glsl/glcpp/glcpp-lex.l index d09441a..41

[Mesa-dev] [PATCH 1/3] glsl: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Flex version 2.6.2 does not expand (define) the yy version of some function, thus we fail to compile. Strictly speaking this might be a flex bug, although expanding the few instances is perfectly trivial and works with 2.6.2 and earlier versions of flex. Cc: "12.0 13.0" Cc:

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Martin Peres
On 27/10/16 14:41, Andres Gomez wrote: On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: On 27 October 2016 at 12:06, Andres Gomez wrote: On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails that we have sent

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: > On 27 October 2016 at 12:06, Andres Gomez wrote: > > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > > > Hi, > > > > > > recently, we have noticed that we are not receiving some of the mails > > > that we have sent to the ML. > > >

Re: [Mesa-dev] [PATCH v2 2/2] glsl: update default precision qualifier when it is set in the shader

2016-10-27 Thread Samuel Iglesias Gonsálvez
On 27/10/16 12:45, Eero Tamminen wrote: > Hi, > > Glmark2 is fairly common test. Shouldn't this regression bugfix be CC > to stable? > They can be added to next stable release but they need another commit more that removes unused namespace support from the symbol table. Emil, they should be pi

Re: [Mesa-dev] [PATCH 07/59] glsl/standalone: Add the ability to generate ir_builder code

2016-10-27 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2016-10-25 at 17:59 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- >  src/compiler/glsl/main.cpp   |  1 + >  src/compiler/glsl/standalone.cpp | 12 >  src/compiler/glsl/standalone.h   |  1 + >  3 fil

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Iago Toral
I spent some time looking at this and trying and I did not find anything that did not look reasonable to me in general. I have a question below, but in any case this is: Reviewed-by: Iago Toral Quiroga BTW, now I also see why you need patch 5, you want to use the ir_builder for things like add()

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Emil Velikov
On 27 October 2016 at 12:06, Andres Gomez wrote: > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: >> Hi, >> >> recently, we have noticed that we are not receiving some of the mails >> that we have sent to the ML. >> >> The mails are archived, though, but we don't get the copy from the ML.

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > Hi, > > recently, we have noticed that we are not receiving some of the mails > that we have sent to the ML. > > The mails are archived, though, but we don't get the copy from the ML.  > > We were checking if this was a problem in our side

Re: [Mesa-dev] [PATCH] intel/blorp: Fix a couple asserts around image copy rectangles

2016-10-27 Thread Eero Tamminen
Hi, Tested. Unreal Engine assert isn't anymore triggered. When this patch goes in, you can mark the bug as verified. - Eero On 26.10.2016 08:53, Jason Ekstrand wrote: With dealing with rectangles in compressed images, you can have a width or height that isn't a multiple of the cor

Re: [Mesa-dev] [PATCH] radv: split the device local memory heap into two

2016-10-27 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/27/2016 11:49 AM, Fredrik Höglund wrote: > Advertise two device local memory heaps; one that is host visible > and one that is not. > > This makes it possible for clients to tell how much host visible > vs. non-host visible memory is available. > --- > src/

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has his

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Rob Clark
On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: > On 10/27/2016 12:16 AM, Rob Clark wrote: >> >> So, not quite sure if this is the *correct* solution, but it is at least >> *a* solution to a problem with android wallpaper vs mesa that I've been >> debugging. Basically, what happens is: > > >

Re: [Mesa-dev] [PATCH v2 2/2] glsl: update default precision qualifier when it is set in the shader

2016-10-27 Thread Eero Tamminen
Hi, Glmark2 is fairly common test. Shouldn't this regression bugfix be CC to stable? (Regression happened with https://bugs.freedesktop.org/show_bug.cgi?id=97532) - Eero On 26.10.2016 12:23, Samuel Iglesias Gonsálvez wrote: Default precision qualifier for a data type could be se

[Mesa-dev] [Bug 97804] Later precision statement isn't overriding earlier one

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97804 Eero Tamminen changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Eero Tammin

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > On Wed, 2016-10-26 at 20:19 -0400, Ilia Mirkin wrote: > > > > On Wed, Oct 26, 2016 at 8:08 PM, Timothy Arceri > > wrote: > > > > > > > > > On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: > > > > > > > > > > > > On Wed, 2016-1

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has historically shown some

[Mesa-dev] [PATCH 2/2] radeonsi: fix BFE/BFI lowering for GLSL semantics

2016-10-27 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes spec/arb_gpu_shader5/execution/built-in-functions/*-bitfield{Extract,Insert} Cc: 13.0 --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 37 +-- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 1/2] tgsi: align the definition of BFI & [UI]BFE with GLSL

2016-10-27 Thread Nicolai Hähnle
From: Nicolai Hähnle As previously written, these opcodes use the SM5 semantics which is incompatible with GLSL when bits == 0, offset == 32. At some point we may want to add BFI_SM5 etc. opcodes, but all users currently either want (and expect!) the GLSL semantics or don't care. Bitfield inser

[Mesa-dev] [PATCH 5/5] i965: get num_abos from shader_info rather than gl_linked_shader

2016-10-27 Thread Timothy Arceri
This is a step towards freeing gl_linked_shader after linking. --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 5 +++-- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_tcs_surface_state.c

[Mesa-dev] [PATCH 4/5] mesa/glsl: copy num_abos to gl_program

2016-10-27 Thread Timothy Arceri
We should be able to free gl_linked_shader after linking in order to do so we need to switch to getting values from gl_program instead. --- src/compiler/glsl/glsl_to_nir.cpp | 1 - src/mesa/main/shaderapi.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/gl

[Mesa-dev] [PATCH 3/5] i965: get num_images from shader_info rather than gl_linked_shader

2016-10-27 Thread Timothy Arceri
This is a step towards freeing gl_linked_shader after linking. --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_cs.c| 5 +++-- src/mesa/drivers/dri/i965/brw_gs.c

  1   2   >