Re: [Mesa-dev] 答复: Re: screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

On Tue, Dec 5, 2017 at 8:18 PM, Lvzhihong (ReJohn) wrote: > Hi Michel, > > We solve the glxgears segmentation fault problem by add the compile > flags: -fsigned-char. > In arm platform, char variant default to "unsigned-char", that makes > problem of

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 12/01/2017 01:52 PM, Miguel Angel Vico wrote: On Fri, 1 Dec 2017 13:38:41 -0500 Rob Clark wrote: On Fri, Dec 1, 2017 at 12:09 PM, Nicolai Hähnle wrote: On 01.12.2017 16:06, Rob Clark wrote: On Thu, Nov 30, 2017 at 5:43 PM, Nicolai Hähnle

Re: [Mesa-dev] [PATCH v3 24/25] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

On 12/05/2017 06:10 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > Thanks, Timothy. Any chance to review the remaining patches in the series? It would be nice to land this batch soon to focus on the actual linker stuff. cheers, Eduardo > On 04/12/17 20:21,

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 12/01/2017 10:34 AM, Nicolai Hähnle wrote: On 01.12.2017 18:09, Nicolai Hähnle wrote: [snip] As for the actual transition API, I accept that some metadata may be required, and the metadata probably needs to depend on the memory layout, which is often vendor-specific. But even linear

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 11/30/2017 12:06 PM, Lyude Paul wrote: On Thu, 2017-11-30 at 13:20 -0500, Rob Clark wrote: On Thu, Nov 30, 2017 at 12:59 AM, James Jones wrote: On 11/29/2017 04:09 PM, Miguel Angel Vico wrote: On Wed, 29 Nov 2017 16:28:15 -0500 Rob Clark wrote:

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 11/30/2017 10:48 AM, Rob Clark wrote: On Thu, Nov 30, 2017 at 1:28 AM, James Jones wrote: On 11/29/2017 01:10 PM, Rob Clark wrote: On Wed, Nov 29, 2017 at 12:33 PM, Jason Ekstrand wrote: On Sat, Nov 25, 2017 at 1:20 PM, Rob Clark

[Mesa-dev] 答复: Re: screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

Hi Michel, We solve the glxgears segmentation fault problem by add the compile flags: -fsigned-char. In arm platform, char variant default to "unsigned-char", that makes problem of glxgears segmentation fault. But after we recompile mesa with -fsigned-char. The

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 2017-12-05 18:30:30, Mark Janes wrote: > Timothy Arceri writes: > > > On 06/12/17 12:04, Mark Janes wrote: > >> Jordan Justen writes: > >> > >>> On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Timothy Arceri writes: > On 06/12/17 12:04, Mark Janes wrote: >> Jordan Justen writes: >> >>> On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote:

Re: [Mesa-dev] screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

Hi Michel, I debug deep into the source code, found out that: In si_shader.c file about 7039 line: if (key->ps_prolog.color_interp_vgpr_index[i] != -1) { unsigned interp_vgpr = key->ps_prolog.num_input_sgprs +

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 06/12/17 12:04, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen writes: >> >> >> >> > On 2017-11-08 17:26:47,

Re: [Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

On Thu, Nov 30, 2017 at 9:15 PM, Jason Ekstrand wrote: > After talking with Kristian a bit on IRC, I think there is a bit more > explanation needed. I would be happy to add something like this to the > commit message or as a comment upon request. > > There is an interesting

Re: [Mesa-dev] [PATCH 04/29] anv/blorp: Rework HiZ ops to look like MCS and CCS

On Mon, Nov 27, 2017 at 07:05:54PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 38 > ++ > src/intel/vulkan/anv_private.h | 9 + > src/intel/vulkan/genX_cmd_buffer.c | 11 ++- > 3 files changed, 33

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

On 05/12/17 18:31, Chema Casanova wrote: > El 05/12/17 a las 06:16, Jason Ekstrand escribió: >> A couple of notes: >> >>  1) I *think* I gave you enough reviews to land the UBO/SSBO part and >> the optimizations in 26-28.  If reviews are still missing anywhere, >> please let me know.  If not,

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp

Re: [Mesa-dev] [PATCH 03/29] anv/blorp: Support ISL_AUX_USAGE_HIZ in surf_for_anv_image

On Mon, Nov 27, 2017 at 07:05:53PM -0800, Jason Ekstrand wrote: > If the function gets passed ANV_AUX_USAGE_DEFAULT, it still has the old > behavior of setting ISL_AUX_USAGE_NONE for depth/stencil which is what > we want for blits/copies. > --- > src/intel/vulkan/anv_blorp.c | 22

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

I can confirm this fixes the Dead Island crash, which makes this the first time I've been able to play the game since purchasing it :D The patches doesn't apply cleanly to master so I used the following fixup https://github.com/FireBurn/mesa/tree/gallium-program-binary If you're happy with that

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

Looks good to me. On Tue, Dec 5, 2017 at 3:47 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > From: Jason Ekstrand > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading 16-bit components with

[Mesa-dev] [PATCH] intel/compiler/gen10: Disable push constants.

We still have gpu hangs on Cannonlake when using push constants, so disable them for now until we have a proper fix for these hangs. Signed-off-by: Rafael Antognolli --- src/intel/compiler/brw_fs.cpp | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/1] radv: use a faster version for nir_op_pack_half_2x16

On 6 December 2017 at 03:02, Samuel Pitoiset wrote: > This patch is ported from RadeonSI and it has two effects. > > It fixes a rendering issue which affects F1 2017 and Dawn > of War 3 (Vega only) because LLVM was ending up by generating > the new v_mad_mix_{hi,lo}

[Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

From: Jason Ekstrand load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit surface format defined. So when reading 16-bit components with the sampler we need to unshuffle two 16-bit components from each 32-bit component. Using the sampler avoids the use of

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

On 05/12/17 22:25, Chema Casanova wrote: > On 05/12/17 19:53, Jason Ekstrand wrote: >> On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova > > wrote: >> >> El 30/11/17 a las 23:58, Jason Ekstrand escribió: >> > On Wed, Nov 29, 2017 at 6:50

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen writes: > > > On 2017-12-05 09:13:11, Mark Janes wrote: > >> Jordan Justen writes: > >> > >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: > >> >> Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

On Monday, December 4, 2017 12:12:49 PM PST Antia Puentes wrote: > The new order is: > * VE 1: > * VE 2: > > Previously it was: > * VE 1: > * VE 2: > > The gl_BaseVertex is in a new location now,

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 06/12/17 09:49, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Mark may

Re: [Mesa-dev] [PATCH v4 28/44] i965/fs: Use untyped_surface_read for 16-bit load_ssbo (v2)

On 05/12/17 23:47, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 1:36 PM, Jose Maria Casanova Crespo > > wrote: > > SSBO loads were using byte_scattered read messages as they allow > reading 16-bit size components. byte_scattered

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> Reviewed-by: Timothy Arceri >> >> >> >> Mark may want to

Re: [Mesa-dev] [PATCH v4 28/44] i965/fs: Use untyped_surface_read for 16-bit load_ssbo (v2)

On Tue, Dec 5, 2017 at 1:36 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > SSBO loads were using byte_scattered read messages as they allow > reading 16-bit size components. byte_scattered messages can only > operate one component at a time so we needed to emit as many messages

Re: [Mesa-dev] [PATCH 2/2] mesa: add const qualifier on _mesa_is_renderable_texture_format()

Series: Reviewed-by: Timothy Arceri On 06/12/17 06:08, Brian Paul wrote: --- src/mesa/main/teximage.c | 3 ++- src/mesa/main/teximage.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index

[Mesa-dev] [PATCH v4 28/44] i965/fs: Use untyped_surface_read for 16-bit load_ssbo (v2)

SSBO loads were using byte_scattered read messages as they allow reading 16-bit size components. byte_scattered messages can only operate one component at a time so we needed to emit as many messages as components. But for vec2 and vec4 of 16-bit, being multiple of 32-bit we can use the

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

On 05/12/17 19:53, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova > wrote: > > El 30/11/17 a las 23:58, Jason Ekstrand escribió: > > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > >

[Mesa-dev] [PATCH 3/3] glx: Implement GLX_EXT_no_config_context (v4)

This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. v3: Fix glvnd path and dri2_convert_glx_attribs() v4: Screeching signedness correctness, and disable a now inappropriate test. Khronos:

[Mesa-dev] [PATCH 0/3] GLX_EXT_no_config_context v4

With one exception (noted in 2/3) this is now regression-free in piglit, and passes make check. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] glx: Lift sending the MakeCurrent request to top-level code (v2)

Somewhat terrifyingly, we never sent this for direct contexts, which means the server never knew the context/drawable bindings. To handle this sanely, pull the request code up out of the indirect backend, and rewrite the context switch path to call it as appropriate. This attempts to preserve the

[Mesa-dev] [PATCH 1/3] glx: Move vertex array protocol state into the indirect backend (v2)

Only relevant for indirect contexts, so let's get that code out of the common path. v2: Add the necessary context setup before calling GetString Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 12 src/glx/indirect_glx.c | 26 ++ 2

Re: [Mesa-dev] [PATCH 2/2] anv: fix a case statement in GetMemoryFdPropertiesKHR

Oops. Both are Reviewed-by: Jason Ekstrand On Tue, Dec 5, 2017 at 12:51 PM, Fredrik Höglund wrote: > The handle type in the case statement is supposed to be VK_EXTERNAL_- > MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT. > > Signed-off-by: Fredrik Höglund

[Mesa-dev] [PATCH 2/2] anv: fix a case statement in GetMemoryFdPropertiesKHR

The handle type in the case statement is supposed to be VK_EXTERNAL_- MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT. Signed-off-by: Fredrik Höglund --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 1/2] radv: fix a case statement in GetMemoryFdPropertiesKHR

The handle type in the case statement is supposed to be VK_EXTERNAL_- MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 2017-12-05 09:13:11, Mark Janes wrote: > Jordan Justen writes: > > > On 2017-11-08 17:26:47, Timothy Arceri wrote: > >> Reviewed-by: Timothy Arceri > >> > >> Mark may want to consider adding some of the once a day type CI runs for > >>

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Tue, Dec 5, 2017 at 11:01 AM, Robert Foss wrote: > On Tue, 2017-12-05 at 18:22 +0900, Tomasz Figa wrote: >> On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring wrote: >> > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa >> > wrote: >> > >

Re: [Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

On Thu, 2017-11-30 at 16:10 +, Emil Velikov wrote: > On 14 November 2017 at 20:13, Adam Jackson wrote: > > > @@ -562,6 +562,10 @@ dri2_convert_glx_attribs(unsigned num_attribs, > > const uint32_t *attribs, > > return false; > > } > > break; >

Re: [Mesa-dev] [PATCH 2/2] radv: enable lowering of nir_op_bitfield_extract

Same comment as the previous patch. On Tue, Dec 5, 2017 at 12:50 PM, Samuel Pitoiset wrote: > This instruction should also be lowered correctly. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_shader.c | 1 + > 1 file

Re: [Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

lower_bitfield_insert lowers nir_op_bitfield_insert to DX10-style nir_op_bfi and nir_op_bfm, both of which aren't handled by ac_nir_to_llvm, so unless I'm missing something this will just break them even harder. We probably should use this lowering after adding support for bfi and bfm, since AMD

[Mesa-dev] [PATCH 2/2] mesa: add const qualifier on _mesa_is_renderable_texture_format()

--- src/mesa/main/teximage.c | 3 ++- src/mesa/main/teximage.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 572e380..e5f8bb0 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5712,7 +5712,8

[Mesa-dev] [PATCH 1/2] mesa: add const qualifier on _mesa_base_fbo_format()

--- src/mesa/main/fbobject.c | 2 +- src/mesa/main/fbobject.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 30287ab..d23916d 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -1804,7 +1804,7

[Mesa-dev] [PATCH 6/6] radeonsi: make const and stream uploaders allocate read-only memory

From: Marek Olšák and anything that clones these uploaders, like u_threaded_context. --- src/gallium/drivers/radeon/r600_pipe_common.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

[Mesa-dev] [PATCH 1/6] radeonsi: allow DMABUF exports for local buffers

From: Marek Olšák Cc: 17.3 --- src/gallium/drivers/radeon/r600_texture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index

[Mesa-dev] [PATCH 4/6] radeonsi/gfx9: make shader binaries use read-only memory

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 3 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.h | 1 +

[Mesa-dev] [PATCH 3/6] winsys/amdgpu: make IBs use read-only memory

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 089a358..63cd632 100644 ---

[Mesa-dev] [PATCH 5/6] radeonsi: use a separate allocator for fine fences

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 7 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_fence.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/6] radeonsi: print the buffer list for CHECK_VM

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 22609b7..385ce39 100644 --- a/src/gallium/drivers/radeonsi/si_debug.c

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova wrote: > El 30/11/17 a las 23:58, Jason Ekstrand escribió: > > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > > wrote: > > > > load_ubo is using 32-bit

Re: [Mesa-dev] [PATCH 3/3] st/mesa: remove unneeded #include in st_format.h

For the series: Reviewed-by: Marek Olšák Marek On Tue, Dec 5, 2017 at 5:59 PM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_format.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_format.h >

Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

On Tue, Dec 5, 2017 at 10:34 AM, Rogovin, Kevin wrote: > Hi, > > >This isn't true. 100% of the intel_mipmap_tree -> blorp_surf > translations are handled by that function. > > It's a perfectly reasonable place to handle these things. It could > also be handled in

Re: [Mesa-dev] [PATCH 4/4] mesa: s/%u/%d/ in _mesa_error() call in check_layer()

For the series: Reviewed-by: Marek Olšák Marek On Tue, Dec 5, 2017 at 6:00 PM, Brian Paul wrote: > The layer parameter is signed. Fixes the error message seen when > running the arb_texture_multisample-errors test which checks a > negative layer value.

Re: [Mesa-dev] [PATCH v2] st/mesa: swizzle argument when there's a vector size mismatch

Reviewed-by: Marek Olšák Marek On Tue, Dec 5, 2017 at 5:26 AM, Ilia Mirkin wrote: > GLSL IR operation arguments can sometimes have an implicit swizzle as a > result of a vector arg and a scalar arg, where the scalar argument is > implicitly expanded

Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

Hi, >This isn't true.  100% of the intel_mipmap_tree -> blorp_surf translations are >handled by that function.  > It's a perfectly reasonable place to handle these things.  It could also be > handled in genX(blorp_exec) if that makes someone more comfortable. This is where I placed the ASTC

Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

> Are you saying that this bug extends over hardware context? Different HW contexts imply different execbuffer2 ioctl's. The kernel inserts a full blown flush of everything after (or before, I cannot remember) each execbuffer2 call. This way there is context isolation in HW buggineness.

Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

On Tue, Dec 5, 2017 at 10:17 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Dec 05, 2017 at 10:26:33AM +, Rogovin, Kevin wrote: > > Hi, > > > > > > >> Here are my comments of the patch posted: > > >> > > >> 1. it is essentially replication and moving around of the code

Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

On Tue, Dec 05, 2017 at 10:26:33AM +, Rogovin, Kevin wrote: > Hi, > > > >> Here are my comments of the patch posted: > >> > >> 1. it is essentially replication and moving around of the code of the > >> patch series posted earlier but missing various > >> important bits: preventing

[Mesa-dev] [Bug 104035] When will the egl introp for vaapi be implemented

https://bugs.freedesktop.org/show_bug.cgi?id=104035 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net

Re: [Mesa-dev] [PATCH] mesa/st: move cloning of NIR shader for compute

Reviewed-by: Marek Olšák Marek On Tue, Dec 5, 2017 at 4:05 PM, Rob Clark wrote: > Since in the NIR case, driver takes ownership of the NIR shader, we need > to clone what is passed to the driver. Normally this is done as part of > creating the shader

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 --- Comment #5 from Samuel Pitoiset --- Patch is on the list. https://patchwork.freedesktop.org/series/34930/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

Otherwise it's replaced by "vec1 32 ssa_108 = load_const (0x /* 0.00 */)", which looks clearly wrong. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104119 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 + 1 file changed, 1

[Mesa-dev] [PATCH 2/2] radv: enable lowering of nir_op_bitfield_extract

This instruction should also be lowered correctly. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 0b19d23fa2..044bcd0641 100644 ---

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 9:43 AM, Kristian Høgsberg wrote: > On Tue, Dec 5, 2017 at 8:49 AM, Jason Ekstrand wrote: >> On Tue, Dec 5, 2017 at 8:23 AM, Kristian Høgsberg >> wrote: >>> >>> On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 8:49 AM, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 8:23 AM, Kristian Høgsberg > wrote: >> >> On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand >> wrote: >> > On Tue, Dec 5, 2017 at 1:22 AM, Daniel Stone

[Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

Signed-off-by: Dylan Baker --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 3e8ea7d17e0..bf6bd551f08 100644 --- a/meson.build +++ b/meson.build @@ -1107,9 +1107,9 @@ if with_platform_x11

[Mesa-dev] [Bug 103126] glthread doesn't offload anything in Witcher 2

https://bugs.freedesktop.org/show_bug.cgi?id=103126 --- Comment #2 from Alexander Tsoy --- I had the same problem with other eON ports: Spec Ops: The Line and Overlord at least. It's turned out that it's due to disabled assembly in my 32-bit mesa build (--disable-asm). Not

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 --- Comment #4 from Samuel Pitoiset --- Possible fix: diff --git i/src/amd/vulkan/radv_shader.c w/src/amd/vulkan/radv_shader.c index 4a3fdfa80e..0b19d23fa2 100644 --- i/src/amd/vulkan/radv_shader.c +++

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

Quoting Emil Velikov (2017-12-05 07:36:25) > On 4 December 2017 at 23:57, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-23 11:04:34) > >> On 20 November 2017 at 23:12, Dylan Baker wrote: > >> > This doesn't actually accomplish what it's meant to

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

El 05/12/17 a las 06:16, Jason Ekstrand escribió: > A couple of notes: > >  1) I *think* I gave you enough reviews to land the UBO/SSBO part and > the optimizations in 26-28.  If reviews are still missing anywhere, > please let me know.  If not, let's try and get that part landed. The series is

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 --- Comment #3 from Samuel Pitoiset --- Something is wrong in the NIR. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> Reviewed-by: Timothy Arceri >> >> Mark may want to consider adding some of the once a day type CI runs for >> this. For example running the test suite for two consecutive

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

El 30/11/17 a las 23:58, Jason Ekstrand escribió: > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > wrote: > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading

[Mesa-dev] [PATCH 1/1] radv: use a faster version for nir_op_pack_half_2x16

This patch is ported from RadeonSI and it has two effects. It fixes a rendering issue which affects F1 2017 and Dawn of War 3 (Vega only) because LLVM was ending up by generating the new v_mad_mix_{hi,lo} instructions which appear to be buggy in some way. Not sure if Mesa is generating something

[Mesa-dev] [PATCH 0/1] radv: bugfix for F1 2017 and DOW3 on Vega

Hi folks, It took me a while to figure out the issue which is addressed by the following patch, but I think it should be the right one (see the patch description for more explanations). Keep in mind that DOW3 is still affected by one other issue (Vega only). Hopefully, I will be able to write a

Re: [Mesa-dev] [PATCH 3/3] st/mesa: remove unneeded #include in st_format.h

Series is Reviewed-by: Ilia Mirkin On Tue, Dec 5, 2017 at 11:59 AM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_format.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_format.h >

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Tue, 2017-12-05 at 18:22 +0900, Tomasz Figa wrote: > On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring wrote: > > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa > > wrote: > > > On Fri, Dec 1, 2017 at 11:20 PM, Rob Herring > > > wrote: > > > > On

[Mesa-dev] [PATCH 4/4] mesa: s/%u/%d/ in _mesa_error() call in check_layer()

The layer parameter is signed. Fixes the error message seen when running the arb_texture_multisample-errors test which checks a negative layer value. --- src/mesa/main/fbobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 1/4] mesa: add const qualifier in test_attachment_completeness()

--- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8116563..f7702f1 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -793,7 +793,7 @@ test_attachment_completeness(const

[Mesa-dev] [PATCH 2/4] mesa: trivial whitespace fixes in transformfeedback.c

--- src/mesa/main/transformfeedback.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index a5ea2a5..e4cc1db 100644 --- a/src/mesa/main/transformfeedback.c +++

[Mesa-dev] [PATCH 3/4] mesa: simplify/improve some _mesa_error() calls in teximage.c

--- src/mesa/main/teximage.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 41de966..572e380 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5778,14 +5778,10 @@

[Mesa-dev] [PATCH 2/3] st/mesa: rename a few vars to 'bindings'

To be consistent. --- src/mesa/state_tracker/st_format.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index da8b5e2..3f7e55e 100644 --- a/src/mesa/state_tracker/st_format.c +++

[Mesa-dev] [PATCH 3/3] st/mesa: remove unneeded #include in st_format.h

--- src/mesa/state_tracker/st_format.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_format.h b/src/mesa/state_tracker/st_format.h index 3dd9c10..466b5d0 100644 --- a/src/mesa/state_tracker/st_format.h +++ b/src/mesa/state_tracker/st_format.h @@ -33,7 +33,6 @@

[Mesa-dev] [PATCH 1/3] st/mesa: whitespace fixes in st_format.c

--- src/mesa/state_tracker/st_format.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 1ae677d..da8b5e2 100644 --- a/src/mesa/state_tracker/st_format.c +++

[Mesa-dev] [PATCH] swr/scons: Fix another intermittent build failure

gen_BackendPixelRate*.cpp depends on gen_ar_eventhandler.hpp. Fix missing dependency. --- src/gallium/drivers/swr/SConscript | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr/SConscript index 9204ecb..eca4830 100644 ---

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 8:23 AM, Kristian Høgsberg wrote: > On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand > wrote: > > On Tue, Dec 5, 2017 at 1:22 AM, Daniel Stone > wrote: > >> > >> Hi, > >> > >> On 18 November 2017 at 00:10,

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 1:22 AM, Daniel Stone wrote: >> >> Hi, >> >> On 18 November 2017 at 00:10, Jason Ekstrand wrote: >> > This fixes a bug where we were taking the tiling

[Mesa-dev] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

This extension is not defined for indirect contexts. Marking it as "client only", as the old code did here, would make the extension available in indirect contexts, even though the server would certainly not have it in its extension list. Cc: Signed-off-by:

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 1:22 AM, Daniel Stone wrote: > Hi, > > On 18 November 2017 at 00:10, Jason Ekstrand wrote: > > This fixes a bug where we were taking the tiling from the BO regardless > > of what the modifier said. When we got images in from

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 --- Comment #2 from James Legg --- Created attachment 135982 --> https://bugs.freedesktop.org/attachment.cgi?id=135982=edit Output from RADV_DEBUG=shaders -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 --- Comment #1 from James Legg --- Created attachment 135981 --> https://bugs.freedesktop.org/attachment.cgi?id=135981=edit SPIR-V disassembly of test shader -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

https://bugs.freedesktop.org/show_bug.cgi?id=104119 Bug ID: 104119 Summary: radv: OpBitFieldInsert produces 0 with a loop counter for Insert Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] nvir/nvc0: fix CVT lowering for dType == sType

On Tue, Dec 5, 2017 at 9:34 AM, Ilia Mirkin wrote: > An in any case, CVT with stype == dtype is illegal - whatever > generates that should be fixed. Without source modifiers, that is :) "cvt f32 dst neg src" is just fine of course.

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

On 4 December 2017 at 23:57, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-23 11:04:34) >> On 20 November 2017 at 23:12, Dylan Baker wrote: >> > This doesn't actually accomplish what it's meant to do, as extern C >> > doesn't undefine __cplusplus,

[Mesa-dev] [PATCH] mesa/st: move cloning of NIR shader for compute

Since in the NIR case, driver takes ownership of the NIR shader, we need to clone what is passed to the driver. Normally this is done as part of creating the shader variant (where is clone is anyways needed). But compute shaders have no variants, so we were cloning earlier. The problem is that

Re: [Mesa-dev] [PATCH] Android: enable noreturn and returns_nonnull attributes

On Tue, Dec 5, 2017 at 5:56 AM, Emil Velikov wrote: > On 5 December 2017 at 02:21, Rob Herring wrote: >> Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke >> Android builds which have -Werror enabled with the following errors: >>

  1   2   >