Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

Reviewed-by: Iago Toral Quiroga On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: > Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if > parser error was emitted previously. This way process_array_size > won't see bogus IR generated like with commit 9c676a64273. > > Signed-off

[Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if parser error was emitted previously. This way process_array_size won't see bogus IR generated like with commit 9c676a64273. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98699 --- src/compiler/g

Re: [Mesa-dev] [PATCH] [rfc] r600: set vpm bit for loop start clause

On 5 August 2018 at 19:47, Gert Wollny wrote: > Am Freitag, den 03.08.2018, 06:02 +0200 schrieb Roland Scheidegger: >> Am 03.08.2018 um 05:10 schrieb Dave Airlie: >> > From: Dave Airlie >> > >> > This fixes some hangs with the arb_shader_image_load_store- >> > atomicity tests >> > on evergreen/ca

[Mesa-dev] [PATCH] r600/eg: rework atomic counter emission with flushes

From: Dave Airlie With the current code, we didn't do the space checks prior to atomic counter setup emission, but we also didn't add atomic counters to the space check so we could get a flush later as well. These flushes would be bad, and lead to problems with parallel tests. We have to ensure

[Mesa-dev] [PATCH v3 38/48] meson: don't build gallium trivial tests on windows

They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 --- a

[Mesa-dev] [PATCH v3 34/48] util/tests: Use define instead of VLA

To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++- src/util/tests/hash_tabl

[Mesa-dev] [PATCH v3 43/48] meson: maintain names of shared API libraries

Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) --- meson.build | 16 +--- meson_options.txt | 5 +++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff --

[Mesa-dev] [PATCH v3 37/48] meson: Set visibility and compat args for graw

--- src/gallium/targets/graw-gdi/meson.build | 1 + src/gallium/targets/graw-null/meson.build | 2 ++ src/gallium/targets/graw-xlib/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/targets/graw-gdi/meson.build b/src/gallium/targets/graw-gdi/meson.build index e04b454a

[Mesa-dev] [PATCH v3 35/48] meson: Don't build glsl cache_test for windows

v2: - Use new with_shader_cache variable instead of host_machine.system() == 'windows' --- src/compiler/glsl/tests/meson.build | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.buil

[Mesa-dev] [PATCH v3 24/48] util/xmlconfig: include strndup.h for windows

--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index ba657294c1c..e204e52b71d 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -36,6 +36,7 @@ #include #include #include +#include "strndup.h" #include "x

[Mesa-dev] [PATCH v3 46/48] appveyor: Add support for meson as well as scons

--- appveyor.yml | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 86440f0d76a..26f50ce2596 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -42,20 +42,29 @@ os: Visual Studio 2015 environment: WINFLEXBISO

[Mesa-dev] [PATCH v3 30/48] meson: disable sse4.1 optimizations with msvc

There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 73a69

[Mesa-dev] [PATCH v3 04/48] meson: add a expat subproject

--- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index 6960db9e9de..c7dd5ddfec6 100644 --- a/meson.build +++ b/meson.build @@ -1064,7 +1064

[Mesa-dev] [PATCH v3 00/48] Meson for windows

Mostly this is the same thing as before, just rebased on master. A couple of the patches from v2 have already landed. I've also fix the bad rebase of Erik's patch to use the python module for finding python, and updated the appveyor instance to work, and use msbuild instead of ninja. Dylan Baker (

[Mesa-dev] [PATCH v3 44/48] meson: Use python module to find python2 on windows

The python installer on Windows installs two `python.exe`, one for python2 and one for python3 and no `python2.exe` nor `python3.exe`. This seems utterly broken to me, but luckily for us meson handles this craziness for us, but only since version 0.46. This is higher than we require for now, but

[Mesa-dev] [PATCH v3 21/48] meson: fix gallium-osmesa to build for windows

v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH v3 36/48] glsl/tests: define ssize_t on windows

--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@ -2

[Mesa-dev] [PATCH v3 39/48] meson: Fix gtest linkage on msvc

We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 --- a/src/gtest/meso

[Mesa-dev] [PATCH v3 31/48] meson: add switches for SWR with MSVC

--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++ b/src/gallium/drivers/swr/mes

[Mesa-dev] [PATCH v3 33/48] meson: Add idep_getopt for tests

There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff -

[Mesa-dev] [PATCH v3 07/48] glsl: fix general_ir_test with mingw

Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/tests/general_ir_test.cpp b/s

[Mesa-dev] [PATCH v3 27/48] meson: Add support for using win_flex and win_bison on windows

--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 39b542730a9..b7d277b7bc0 100644 --- a/meson.build +++ b/meson.build @@ -1329,8 +1329,31 @@ endif # pthread stubs. Lets not and say we didn't -prog_b

[Mesa-dev] [PATCH v3 48/48] use msbuild instead of ninja

I think that most windows users probably find using msbuild more interesting than ninja, even if ninja is faster. I've left the ninja build in case someone wants to look at it. --- appveyor.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/appveyor.yml b/appveyor.yml

[Mesa-dev] [PATCH v3 25/48] meson: fix pipe-loader compilation for windows

v2: - Add missing D to pound define - Simply define the variable rather than set it to 1 (mirrors android.mk not scons) --- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/meson.b

[Mesa-dev] [PATCH v3 45/48] meson: Add linker arguments for windows

--- meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/meson.build b/meson.build index bbfd7c3c73f..594d3f804fc 100644 --- a/meson.build +++ b/meson.build @@ -887,6 +887,27 @@ else endforeach endif +# set linker arguments +if host_machine.system() == 'wind

[Mesa-dev] [PATCH v3 42/48] tests/vma: fix build with MSVC

--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++ b/src/util/tests/vma/vma_ra

[Mesa-dev] [PATCH v3 19/48] meson: build libgl-gdi target

--- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 44 +++ 2 files changed, 45 insertions(+) create mode 100644 src/gallium/targets/libgl-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index a4f28d

[Mesa-dev] [PATCH v3 32/48] meson: don't define GLX_USE_TLS for windows

Because the macros for exporting dll symbols and using TLS are mutually exclusive. --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index aaa7d9990ab..100d12f475d 100644 --- a/meson.build +++ b/meson.build @@ -329,7 +329,10 @@ if wit

[Mesa-dev] [PATCH v3 41/48] meson: don't build or run mesa-sha1 test on windows

It crashes hard (pop-up window and all). --- src/util/meson.build | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/util/meson.build b/src/util/meson.build index 6386d945a22..5e6766fc8ad 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -1

[Mesa-dev] [PATCH v3 26/48] meson: don't look for rt on windows

--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c8a66942cff..39b542730a9 100644 --- a/meson.build +++ b/meson.build @@ -1101,7 +1101,9 @@ elif with_dri_i965 and get_option('shader-cache') endif # Determine whether or not th

[Mesa-dev] [PATCH v3 09/48] meson: build getopt when using msvc

completely untested --- src/getopt/meson.build | 29 + src/meson.build| 5 + 2 files changed, 34 insertions(+) create mode 100644 src/getopt/meson.build diff --git a/src/getopt/meson.build b/src/getopt/meson.build new file mode 100644 index 000..5

[Mesa-dev] [PATCH v3 18/48] meson: build wgl state tracker

--- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 50 ++ 2 files changed, 53 insertions(+) create mode 100644 src/gallium/state_trackers/wgl/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index 775

[Mesa-dev] [PATCH v3 28/48] meson: make nm binary optional

This makes nm not required, but used if found. In general I imagine that this means that on windows nm wont be found, and on other platforms it will. v2: - fix gbm and egl symbols check tests to only be run if nm is found - reword commit message to reflect the code change --- meson.build

[Mesa-dev] [PATCH v3 15/48] meson: Add windows defines to glapi

These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13 - src/mapi/shar

[Mesa-dev] [PATCH v3 47/48] appveyor: use chocolatey (cinst) to install winflexbison

v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 26f50ce2596..bbd7e1cddb0 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,13 +34,11 @@ branches: clone_depth: 100 cache: -- win_flex_

[Mesa-dev] [PATCH v3 16/48] meson: Add necessary defines for mesa_gallium on windows

--- src/mesa/meson.build | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index 29633691ee7..fa086466443 100644 --- a/src/mesa/meson.build +++ b/src/mesa/meson.build @@ -728,11 +728,19 @@ libmesa_classic = static_library(

[Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

By including the proper headers for getpid and for mkdir. Signed-off-by: Dylan Baker Reviewed-by: Marek Olšák --- src/gallium/auxiliary/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/auxiliary/meson.build b/src/gallium/auxiliary/meson.build index 98542d7ef3e.

[Mesa-dev] [PATCH v3 10/48] meson: Add a platform for windows

This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 788021c05e9..37c07eaa581 100644 --- a/meson.build +++ b/me

[Mesa-dev] [PATCH v3 22/48] meson: Don't check for posix_memalign on windows

There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 4dc76732d4a..dfeeab8c11a

[Mesa-dev] [PATCH v3 40/48] meson: disable graw tests on mingw

I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 --- a/src/gallium/tests/me

[Mesa-dev] [PATCH v3 12/48] meson: don't allow glvnd on windows

--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 75f7f1c672d..25de31bfabd 100644 --- a/meson.build +++ b/meson.build @@ -356,7 +356,9 @@ endif with_glvnd = get_option('glvnd') if with_glvnd - if with_glx == 'xlib' or with_g

[Mesa-dev] [PATCH v3 17/48] meson: build gallium gdi winsys

--- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index 561af9d33

[Mesa-dev] [PATCH v3 11/48] meson: don't build glx or dri by default on windows

--- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 37c07eaa581..75f7f1c672d 100644 --- a/meson.build +++ b/meson.build @@ -264,8 +264,12 @@ if with_glx == 'auto' elif with_platform_haiku with_glx = 'disabled' elif

[Mesa-dev] [PATCH v3 23/48] meson: Add support for wrapping llvm

For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for example

[Mesa-dev] [PATCH v3 03/48] meson: add a zlib subproject

To help windows build --- meson.build | 2 +- subprojects/zlib.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/zlib.wrap diff --git a/meson.build b/meson.build index cbaee5ceb22..6960db9e9de 100644 --- a/meson.build +++ b/meson.bui

[Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

--- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index c7dd5ddfec6..788021c05e9 100644 --- a/meson.build +++ b/meson.build @@ -1027,9 +1027,9 @@ endif if cc.has_function('dlopen') dep_dl = null_dep else - dep_dl = cc.find_libra

[Mesa-dev] [PATCH v3 20/48] meson: build graw-gdi target

--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.bui

[Mesa-dev] [PATCH v3 29/48] meson: for incluse of inttypes.h for glcpp with msvc

Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 09d44

[Mesa-dev] [PATCH v3 13/48] meson: add windows compiler checks and libraries

--- meson.build | 129 1 file changed, 79 insertions(+), 50 deletions(-) diff --git a/meson.build b/meson.build index 25de31bfabd..4350e1af810 100644 --- a/meson.build +++ b/meson.build @@ -775,69 +775,96 @@ endif # TODO: this is very incomple

[Mesa-dev] [PATCH v3 06/48] glapi: export glapi_destroy_multithread when building shared-glapi on windows

Which will allow meson to build a shared glapi build with mingw. --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a 100644 --- a/src/mapi/glapi/glapi.h +++ b/src/mapi/glapi/gl

[Mesa-dev] [PATCH v3 02/48] add a git ignore for subprojects

--- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null +++ b/subprojects/.gitignore @@ -0,0 +1,3 @@ +* +!*.wrap +!

[Mesa-dev] [PATCH v3 01/48] meson: always define libglapi

This allows the identifier to be used even if shared-glapi isn't build, which simplifies a bunch of things. --- src/mapi/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/meson.build b/src/mapi/meson.build index 798586bfb0c..0be80047e4d 100644 --- a/src/mapi/meson.build ++

Re: [Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

On 7 August 2018 at 06:11, Erik Faye-Lund wrote: > Ping? > Acked-by: Dave Airlie ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 107502] Newest libdrm is required by amdgpu, but drm_intel error is emitted

https://bugs.freedesktop.org/show_bug.cgi?id=107502 --- Comment #2 from mirh --- Sure, I can see that in the comment. But that would make for a hell of headbanging, was I to decide to just disable X vendor instead of upgrading the whole libdrm. -- You are receiving this mail because: You are t

Re: [Mesa-dev] [PATCH] main/tests: Add AMD_framebuffer_multisample_advanced

On 08/06/2018 10:02 AM, Dylan Baker wrote: > Add dispatch_sanity tests > > Fixes: 3d6900d76efaef1ff6e84b7b8785bbe3d8f5b29b >("glapi: define AMD_framebuffer_multisample_advanced and add its > functions") > Cc: Marek Olšák > Cc: Brian Paul > Signed-off-by: Dylan Baker > --- > > Marek, t

[Mesa-dev] [Bug 107502] Newest libdrm is required by amdgpu, but drm_intel error is emitted

https://bugs.freedesktop.org/show_bug.cgi?id=107502 Dylan Baker changed: What|Removed |Added Priority|medium |lowest Severity|normal

[Mesa-dev] [Bug 107502] Newest libdrm is required by amdgpu, but drm_intel error is emitted

https://bugs.freedesktop.org/show_bug.cgi?id=107502 Bug ID: 107502 Summary: Newest libdrm is required by amdgpu, but drm_intel error is emitted Product: Mesa Version: git Hardware: Other OS: Linux (All)

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #3 from mirh --- This is the newest one https://patchwork.freedesktop.org/series/44315/ curl 'https://patchwork.freedesktop.org/project/mesa/pwclientrc/' | sed '7,8s/^#//g' > ~/.pwclientrc && pwclient list -w "Gert Wollny" -s New v4

[Mesa-dev] [Bug 107488] gl.h:2090: error: redefinition of typedef ‘GLeglImageOES’

https://bugs.freedesktop.org/show_bug.cgi?id=107488 --- Comment #2 from Vinson Lee --- (In reply to Brian Paul from comment #1) > Created attachment 140982 [details] [review] > proposed fix > > Hmmm, I don't see that issue here. What is your ./configure command line? > > In any case, does the

Re: [Mesa-dev] [PATCH] virgl: add ARB_shader_clock support

Reviewed-by: Erik Faye-Lund On 06. aug. 2018 22:23, Dave Airlie wrote: From: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.

[Mesa-dev] [PATCH] virgl: add ARB_shader_clock support

From: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index 02cedcd0dc0..978839ad4fd 100644

Re: [Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

Ping? On 27. juli 2018 09:18, Erik Faye-Lund wrote: Here's a few patches to get the delta between our copy of virgl_hw.h and the copy in the virglrenderer repository as small as possible. The goal is to make it easier to track this file in the future by simply copying the new version of the fi

[Mesa-dev] [PATCH 3/4] nv50/ir: add scalar field to TexInstructions

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 ++ src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp | 5 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.h b/src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 2/4] nv50/ra: add condenseDef overloads for partial condenses

Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 29 ++- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp index b660fec75c9..0059ec

[Mesa-dev] [PATCH 1/4] nv50/ir: print color masks of tex instructions

Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_print.cpp | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp index ee3506fbaee..5

[Mesa-dev] [PATCH 4/4] gm107/ir: use scalar tex instructions where possible

TEXS, TLD4 and TLD4S are variants of tex instructions which are more scalar, which gives RA more freedom and is less likely to insert silly MOVs to satisfy quad registers. shader-db changes: total instructions in shared programs : 5814250 -> 5748182 (-1.14%) total gprs used in shared programs:

[Mesa-dev] [PATCH 0/4] gm107/ir: add support for TEXS, TLDS and TLD4S

No regressions inside the CTS or piglit. More details in the 4th patch. Karol Herbst (4): nv50/ir: print color masks of tex instructions nv50/ra: add condenseDef overloads for partial condenses nv50/ir: add scalar field to TexInstructions gm107/ir: use scalar tex instructions where possibl

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #2 from Guenther Sohler --- Hi Gert Wollny, I see exactly same bug in a software called "curv" . So I tried to use exact those 2 patches you provided here. I did * git clone MESA repository * git fetch --all * git am TGSI-split-me

[Mesa-dev] [PATCH] glsl_to_tgsi: plumb image writable through to driver

The virgl driver cares about the writable-flag on image definitions, because it re-emits GLSL from the TGSI. However, so far it was hardcoded to true in glsl_to_tgsi, which cause problems when virglrenderer is running on top of GLES 3.1, where not all formats are supported for writable images. Sig

Re: [Mesa-dev] [PATCH 13/14] intel: tools: add aubinator viewer

This is a really nice tool, and I'm looking forward to see the other features you teased us with, as well as helping to improve it. With that said, I don't know much about the imgui API and can't really do much to help reviewing it yet. But I would like to have it landed anyway. Patches 13 and 14

Re: [Mesa-dev] [PATCH 12/14] build: new tool option for intel ui tools

Ugh, I just replied with the whole message without cutting it out, so in case it doesn't reach the ML, this is what I wanted to say: On Mon, Aug 06, 2018 at 11:19:20AM -0700, Rafael Antognolli wrote: > I would change the commit summary line to make it clear we are importing > imgui code, instead o

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

On Fri 03 Aug 2018, Tapani Pälli wrote: > One tiny nit below but for patches 3,4 and 5: > > Reviewed-by: Tapani Pälli > > Special thanks for the documentation. I want to go through rest of changes > within Android but I'm currently experiencing some horrible issues with the > image building. I'm

Re: [Mesa-dev] [PATCH 11/14] intel: tools: aubmem: map gtt data to aub file

On Thu, Aug 02, 2018 at 10:39:23AM +0100, Lionel Landwerlin wrote: > This will allow the aubinator viewer tool to modify the aub data that > was loaded at a particular gtt address. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aub_mem.c | 29 + > src/in

[Mesa-dev] [Bug 107483] DispatchSanity_test.GL31_CORE regression

https://bugs.freedesktop.org/show_bug.cgi?id=107483 Ian Romanick changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [Mesa-dev] [PATCH 2/8] glapi: define AMD_framebuffer_multisample_advanced and add its functions

On 08/06/2018 03:49 AM, Juan A. Suarez Romero wrote: > On Wed, 2018-08-01 at 19:25 -0400, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mapi/glapi/gen/gl_API.xml | 27 +++ >> src/mesa/main/fbobject.c | 22 ++ >> src/mesa/main/fbobject.h

Re: [Mesa-dev] [PATCH v3 02/13] nvc0/ir: return 0 in imageLoad on incomplete textures

On Mon, Aug 6, 2018 at 6:26 PM, Dylan Baker wrote: > Quoting Karol Herbst (2018-07-15 11:15:42) >> We already guarded all OP_SULDP against out of bound accesses, but those >> ended up just reusing whatever value was stored in the dest registers. >> >> fixes CTS test shader_image_load_store.incompl

[Mesa-dev] [PATCH] main/tests: Add AMD_framebuffer_multisample_advanced

Add dispatch_sanity tests Fixes: 3d6900d76efaef1ff6e84b7b8785bbe3d8f5b29b ("glapi: define AMD_framebuffer_multisample_advanced and add its functions") Cc: Marek Olšák Cc: Brian Paul Signed-off-by: Dylan Baker --- Marek, the XML in mesa and the Khronos XML agree that this works for GLES

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

Quoting Emil Velikov (2018-06-28 07:35:44) > From: Emil Velikov > > Helps when the native wayland-scanner is located outside of PATH. > Inspired by the xserver code ;-) > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > meson.build | 3 ++- > 1 file changed, 2 ins

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > repository. > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > CC: Marek Olšák Cc: Emil Velikov Cc: Dylan Baker > > --- > .travis.yml | 4 >

Re: [Mesa-dev] [PATCH v3 02/13] nvc0/ir: return 0 in imageLoad on incomplete textures

Quoting Karol Herbst (2018-07-15 11:15:42) > We already guarded all OP_SULDP against out of bound accesses, but those > ended up just reusing whatever value was stored in the dest registers. > > fixes CTS test shader_image_load_store.incomplete_textures > > v2: fix for loads not ending up with pr

Re: [Mesa-dev] [PATCH v2] meson, install_megadrivers: Also remove stale symlinks

Am Montag, den 06.08.2018, 16:59 +0100 schrieb Eric Engestrom: > On Monday, 2018-08-06 09:41:48 +0200, Gert Wollny wrote: > > os.path.exists doesn't return True for stale symlinks, but they are > > in > > the way later, when a link/file with the same name is to be > > created. > > For instance it i

Re: [Mesa-dev] [PATCH v2] meson, install_megadrivers: Also remove stale symlinks

Quoting Eric Engestrom (2018-08-06 08:59:00) > On Monday, 2018-08-06 09:41:48 +0200, Gert Wollny wrote: > > os.path.exists doesn't return True for stale symlinks, but they are in > > the way later, when a link/file with the same name is to be created. > > For instance it is conceivable that the poi

Re: [Mesa-dev] [PATCH v2] meson, install_megadrivers: Also remove stale symlinks

On Monday, 2018-08-06 09:41:48 +0200, Gert Wollny wrote: > os.path.exists doesn't return True for stale symlinks, but they are in > the way later, when a link/file with the same name is to be created. > For instance it is conceivable that the pointed to file is replaced by > a file with a new name,

[Mesa-dev] [Bug 107488] gl.h:2090: error: redefinition of typedef ‘GLeglImageOES’

https://bugs.freedesktop.org/show_bug.cgi?id=107488 --- Comment #1 from Brian Paul --- Created attachment 140982 --> https://bugs.freedesktop.org/attachment.cgi?id=140982&action=edit proposed fix Hmmm, I don't see that issue here. What is your ./configure command line? In any case, does the

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On Mon, 2018-08-06 at 16:02 +0100, Daniel Stone wrote: > Hi Juan, > > On Tue, 5 Jun 2018 at 18:23, Juan A. Suarez Romero > wrote: > > On Tue, 2018-06-05 at 12:41 +0100, Daniel Stone wrote: > > > > - In Wayland/Mesa, the surface is not resized at the time the native > > > > window is > > > > res

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

Hi Juan, On Tue, 5 Jun 2018 at 18:23, Juan A. Suarez Romero wrote: > On Tue, 2018-06-05 at 12:41 +0100, Daniel Stone wrote: > > > - In Wayland/Mesa, the surface is not resized at the time the native > > > window is > > > resized; this is done in *eglSwapBuffers*, following 3.10.1.1. > > > > Disa

Re: [Mesa-dev] [PATCH] [rfc] r600: set vpm bit for loop start clause

Am 05.08.2018 um 11:47 schrieb Gert Wollny: > Am Freitag, den 03.08.2018, 06:02 +0200 schrieb Roland Scheidegger: >> Am 03.08.2018 um 05:10 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This fixes some hangs with the arb_shader_image_load_store- >>> atomicity tests >>> on evergreen/cayman GPU

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #12 from Ilia Mirkin --- I believe that's the loader (in src/loader) - nothing radv specific. It's annoying for GL purposes too, with DRI_PRIME=1 picking the *last* GPU instead of the second. It used to work this way, but then the l

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #11 from sher...@amiran.us --- I have the same problem using DXVK, and there is a similar bug report on vkmark: https://github.com/vkmark/vkmark/issues/10 It seems that there is something in the RADV driver that causes GPUs to enumer

Re: [Mesa-dev] [PATCH] i965: do not emit empty sampler state

Hey Erik, I don't think this is right, because by not filling out_offset, you're leaving it at 0 which makes the entry in the binding table point to a dynamic state base address. I would emit the null surface instead. - Lionel On 06/08/18 14:27, Erik Faye-Lund wrote: If called with an empty

[Mesa-dev] [PATCH] i965: do not emit empty sampler state

If called with an empty size, brw_emit_buffer_surface_state asserts. And since doing a zero-size upload is really just a lot of work for no gain, let's just avoid the call in the first place. Signed-off-by: Erik Faye-Lund --- This fixes an assert that triggers for me when running dEQP-GLES31.func

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

On 06/08/18 13:41, Sergii Romantsov wrote: Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson

[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

https://bugs.freedesktop.org/show_bug.cgi?id=99730 --- Comment #8 from vadym --- (In reply to Eero Tamminen from comment #7) > (In reply to vadym from comment #6) > > I didn't noticed any visual issues (but suppose it should be fixed anyway). > > Last Night Redux is run with the same binary name

[Mesa-dev] [PATCH v2] drirc: Allow extension midshader for Metro Redux

This fixes both Metro 2033 Redux and Metro Last Light Redux Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730 Signed-off-by: Eero Tamminen Signed-off-by: Vadym Shovkoplias --- src/util/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/util/drirc b/src/util/drirc index

[Mesa-dev] [PATCH] drirc: Allow extension midshader for Metro Redux

This fixes both Metro 2033 Redux and Metro Last Light Redux Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730 Signed-off-by: Eero Tamminen Signed-off-by: Vadym Shovkoplias --- src/util/drirc | 5 + 1 file changed, 5 insertions(+) diff --git a/src/util/drirc b/src/util/drirc inde

[Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson). -v4: changes related to PAGE_SIZE moved to

[Mesa-dev] [PATCH v4 2/2] intel/ppgtt: 4096 replaced by PAGE_SIZE

Usage of number 4096 replaced by PAGE_SIZE. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 8274c2e..

Re: [Mesa-dev] [PATCH 2/8] glapi: define AMD_framebuffer_multisample_advanced and add its functions

On Wed, 2018-08-01 at 19:25 -0400, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mapi/glapi/gen/gl_API.xml | 27 +++ > src/mesa/main/fbobject.c | 22 ++ > src/mesa/main/fbobject.h | 10 ++ > 3 files changed, 59 insertions(+) >

[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

https://bugs.freedesktop.org/show_bug.cgi?id=99730 --- Comment #7 from Eero Tamminen --- (In reply to vadym from comment #6) > I didn't noticed any visual issues (but suppose it should be fixed anyway). > Last Night Redux is run with the same binary name (metro) as in case of > Metro 2033 redux.

  1   2   >