Re: [Mesa-dev] [PATCH mesa 0/6] Let's get rid of 99% of warnings :)

2018-09-21 Thread Daniel Stone
On Fri, 21 Sep 2018 at 19:48, Jason Ekstrand wrote: > You should try building with clang. 😜 > If only there was some way we could do both, in some kind of automated fashion! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedes

Re: [Mesa-dev] Lets talk about autotools

2018-09-20 Thread Daniel Stone
Hi Emil, On Thu, 20 Sep 2018 at 15:36, Emil Velikov wrote: > Mildly related: when using meson, make that you have patchelf or similar tool. > It nukes the RPATH, removing the need to relink the binaries [as it > happens on make install]. > > Perhaps meson should error out when that's missing? Th

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Daniel Stone
Hi, On Mon, 17 Sep 2018 at 22:31, Marek Olšák wrote: > Is there any documentation for configure options? Or do I have to do > "grep get_option meson.build" to get the list at least? Most of these questions can be answered by running: meson configure $builddir More documentation is available a

[Mesa-dev] [PATCH] st/dri: Don't expose sRGB formats to clients

2018-08-31 Thread Daniel Stone
faces, preventing us from tripping over an assert. Signed-off-by: Daniel Stone Reported-by: Michel Dänzer Fixes: 8c1b9882b2e0 ("egl/dri2: Guard against invalid fourcc formats") Cc: Jason Ekstrand --- src/gallium/state_trackers/dri/dri2.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

Re: [Mesa-dev] [PATCH v2] egl/wayland: do not leak wl_buffer when it is locked

2018-08-31 Thread Daniel Stone
nlock only or free wl_buffer too (Daniel) > > This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. Thanks Juan! Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-31 Thread Daniel Stone
ts[i].fourcc == __DRI_IMAGE_FOURCC_SARGB > > > || > > > + intel_image_formats[i].fourcc == __DRI_IMAGE_FOURCC_SABGR) > > > + return false; > > > > > > > This should be a continue. Fixed locally. > > With that, the series is > Reviewed-by: Eric Engestrom ... and also: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as well

Re: [Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-21 Thread Daniel Stone
ver treated as signed. Might be worth a note in the commit about signedness. Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

2018-08-13 Thread Daniel Stone
d any new ones. So, series is: Acked-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; >

Re: [Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

2018-08-08 Thread Daniel Stone
e), and create the > image. You can eke out a little bit of a speed improvement by using the go-faster runes from before 'apt-get update' here: https://gitlab.freedesktop.org/wayland/weston/blob/master/.gitlab-ci.yml#L6 Anyway, this all looks great, and I'm really excited to

Re: [Mesa-dev] [PATCH v4 2/2] wayland/egl: update surface size on window resize

2018-08-08 Thread Daniel Stone
tely, > and if user calls eglQuerySurface() it will return the new resized > values. I'm pretty confident that these two patches do the right thing; series is: Reviewed-by: Daniel Stone Thanks a lot for your patience & persistence! Cheers, Daniel _

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
(causing all buffers to be released) by the time they destroy their EGLSurface, but that's of course never going to happen. So, assuming there's no unexpected consequences I haven't seen, this is: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-08-06 Thread Daniel Stone
Hi Juan, On Tue, 5 Jun 2018 at 18:23, Juan A. Suarez Romero wrote: > On Tue, 2018-06-05 at 12:41 +0100, Daniel Stone wrote: > > > - In Wayland/Mesa, the surface is not resized at the time the native > > > window is > > > resized; this is done in *eglSw

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Daniel Stone
der_buffer() to return NULL and breaks > rendering when using GLX_DOUBLEBUFFER on pixmaps. > > Query the root window of the pixmap on first init, and use the root > window instead of the pixmap drawable for get_supported_modifiers() > and pixmap_from_buffers(). Looks good to me, thanks

Re: [Mesa-dev] [PATCH rfc 0/3] Be able to disable EGL/GLX_EXT_buffer_age

2018-07-05 Thread Daniel Stone
r usage. Due to currently > only out of tree lima driver need it, and not sure if this is > the right way to disable it, so I send this RFC before lima be > able to upstream. Series is: Acked-by: Daniel Stone Cheers, Daniel ___ mesa-d

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-19 Thread Daniel Stone
Hi Dylan, On Tue, 19 Jun 2018 at 16:42, Dylan Baker wrote: > Historical artifact. When I created the proposed branch we didn't have a > policy > of putting it on master instead of a personal repo, and we were discussing a > transition to gitlab. I also seem to remember that the gitlab doesn't all

Re: [Mesa-dev] GitLab migration update

2018-06-07 Thread Daniel Stone
Hi, On 2 June 2018 at 16:45, Jason Ekstrand wrote: > When the migration happens, there will be a very brief (less than 30 > minutes?) period during which no one will be able to push to either repo. > I'll fire off an e-mail as well as messages in #dri-devel and #intel-3d > shortly before we actua

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-07 Thread Daniel Stone
Hi Emil, On 5 June 2018 at 18:21, Emil Velikov wrote: > On 5 June 2018 at 18:02, Daniel Stone wrote: >>>> drm-gralloc.git > Empty - please nuke, alongside bugzilla & other infra. Done. >>>> drm.git > Out of curiosity - this and others (say igt) projects

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
We definitely do, but I assume it's not been tested recently ... (Sorry about mangled formatting) On Wed, 6 Jun 2018, 8:42 pm Jason Ekstrand, wrote: > On June 6, 2018 12:37:58 Daniel Stone wrote: > >> Right, it's a feature we use, because we do all import them as separat

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Right, it's a feature we use, because we do all import them as separate EGLImages ... and we won't if it's not advertised. On Wed, 6 Jun 2018, 7:05 pm Jason Ekstrand, wrote: > On Wed, Jun 6, 2018 at 11:03 AM, Jason Ekstrand > wrote: > >> On Wed, Jun 6, 2018 at 11

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Sorry, but as written this will regress ability to import NV12 images as separately-addressed planes with shader conversion to RGB; Kodi, Mutter and Weston all use this. On Wed, 6 Jun 2018, 6:48 pm Jason Ekstrand, wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
On 5 June 2018 at 17:55, Eric Engestrom wrote: > On Tuesday, 2018-06-05 17:52:17 +0100, Daniel Stone wrote: >> > I assume that's now mesa, libdrm, piglit, shader-db, crucible, kmscube, >> > mesa-demos; what about igt? Anything else? >> >> We current

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
Hi Eric, On 5 June 2018 at 17:49, Eric Engestrom wrote: > On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: >> Given the discussion below, I think we'll make piglit a sub-project of >> mesa. Those who need commit access to piglit but not mesa can be added >> directly to the piglit pro

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-05 Thread Daniel Stone
Hi Juan, On 5 June 2018 at 09:51, Juan A. Suarez Romero wrote: > On Mon, 2018-06-04 at 13:22 +0100, Daniel Stone wrote: >> The first query will correctly return (w1,h1). The second query will >> incorrectly also return (w1,h1), even though the surface will never >> have

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
On 4 June 2018 at 19:29, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-04 11:20:45) >> Is git-lfs mainly about supporting large individual files, or large >> collections of relatively small files? The tarballs aren't massive, >> there are just tons of them. If it

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
Hi Dylan, On 4 June 2018 at 19:18, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-03 13:19:51) >> One thing I've just remembered is that https://www.mesa3d.org/archive/ >> serves all the tarballs for Mesa releases. Given how Pages is >> structured, we don't ha

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Daniel Stone
Hi Juan, On 4 June 2018 at 12:43, Juan A. Suarez Romero wrote: > On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: >> I think you're right, and this needs more rework to be consistent. >> >> wl_egl_window_get_attached_size() always returns the size of the last &g

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Daniel Stone
Hi Laura, On 25 May 2018 at 01:27, Laura Ekstrand wrote: > When reviewing these patches, please note: > 1. This patch series does *not* touch content. Please do not bikeshed >the content of webpages here. That will be addressed in later >commits. > 2. Ple

Re: [Mesa-dev] GitLab migration update

2018-06-03 Thread Daniel Stone
Hi, On 2 June 2018 at 16:45, Jason Ekstrand wrote: > My current plan (if Daniel is amenable) is to due the migration late next > week. I'm tentatively thinking Thursday morning pacific but that may change > depending on Daniel's schedule. That works for me. > When the migration happens, there

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 15:35, Brendan King wrote: > IMG has a similar patch to the one you describe, but without the changes to > the resize_callback, so just this bit: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > _EGLDisplay *disp, >goto cleanup_surf; > }

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 11:23, Eric Engestrom wrote: > On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: >> https://docs.gitlab.com/ee/user/project/pages/introduction.html >> > Be aware that Pages are by default branch/tag agnostic and their >> > deploymen

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > My question then: is mandatory to call eglSwapBuffers() to ensure > wl_egl_window_get_attached_size() returns the right window size? Because I > found nothing related about this. If it is mandatory, then calling > eglSwapBuffers() in the

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Daniel Stone
On 1 June 2018 at 11:10, Eric Engestrom wrote: > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: >> If you could deal with Daniel's feedback and v3 just this patch sooner >> rather than later, that would be good. I'd like to merge it before we >> switch to gitlab so we can start usi

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-05-31 Thread Daniel Stone
Hi Eric, On 31 May 2018 at 17:13, Eric Engestrom wrote: > On Thursday, 2018-05-31 16:57:17 +0100, Daniel Stone wrote: >> Not initialising attached_{width,height} should not cause any problems >> with these checks. By definition there cannot have been any buffers >> allocate

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-05-31 Thread Daniel Stone
(dri2_surf->wl_win->attached_width != dri2_surf->wl_win->width || > + dri2_surf->wl_win->attached_height != dri2_surf->wl_win->height) { Not initialising attached_{width,height} should not cause any problems with these checks. By definition there cannot have been any buf

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-05-31 Thread Daniel Stone
Hi Laura, On 30 May 2018 at 23:53, Laura Ekstrand wrote: > @@ -0,0 +1,9 @@ > +pages: > + stage: deploy > + script: > + - mkdir .public > + - cp -r docs/* .public > + - mv .public public You should be able to just write into the 'public' folder directly. It seems like creating a new di

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Daniel Stone
Hey, On 30 May 2018 at 21:40, Ilia Mirkin wrote: > Given that not everyone will be a master by default, it would be good > to also set out criteria for adding and removing masters. I'm not > proposing anything heavy -- perhaps by a majority vote of the existing > masters to either add or remove s

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

2018-05-29 Thread Daniel Stone
On 29 May 2018 at 15:17, Eric Engestrom wrote: > On Tuesday, 2018-05-29 09:50:46 -0400, Adam Jackson wrote: >> GL_LIB expands to GLX_mesa, but applications should not link against >> that. -lGL is never wrong, just hardcode it. > > Agreed, and Archlinux has had this patch since basically forever:

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hey, On 27 May 2018 at 16:35, Rob Clark wrote: > On Sun, May 27, 2018 at 10:47 AM, Jason Ekstrand wrote: >> Given the number of people who have said they still like the mailing list, >> that's probably a discussion for another email thread. > > It would be kinda clever if gitlab could automagica

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hi, On 26 May 2018 at 07:42, Marek Olšák wrote: > On Thu, May 24, 2018 at 6:46 AM, Daniel Stone wrote: >> cgit and anongit will not be orphaned: they remain as push mirrors so >> are updated simultaneously with GItLab pushes, as will the GitHub >> mirrors. Realisticall

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hi Mark, On 26 May 2018 at 00:47, Mark Janes wrote: > Daniel Stone writes: >> We had a go at using Jenkins for some of this: Intel's been really >> quite successful at doing it internally, but our community efforts >> have been a miserable failure. After a few years I

Re: [Mesa-dev] [PATCH 01/16] Added ci yaml file for Gitlab.

2018-05-25 Thread Daniel Stone
Hi Eric, On 25 May 2018 at 12:15, Eric Engestrom wrote: > If I'm misunderstanding gitlab-ci and this is running one the same > filesystem as the website, then you'll need to `rm -r public` before the > move, otherwise `mv .public public` will not do what you want :) It's always run in a fresh co

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi, On 24 May 2018 at 02:23, Jason Ekstrand wrote: > On Wed, May 23, 2018 at 5:49 PM, Jordan Justen > wrote: >> Another project I'm involved with had a contingency that swore >> github's "issues" were completely inadequate compared to bugzilla, >> which is to say that I don't think there is cons

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi, On 24 May 2018 at 11:46, Daniel Stone wrote: > It _is_ possible to bend Jenkins to your will - Mark's excellent and > super-helpful work with Intel's CI is testament to that - and in some > environments it's fine, but after a few years of trying, I just don't &g

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi all, I'm going to attempt to interleave a bunch of replies here. On 23 May 2018 at 20:34, Jason Ekstrand wrote: > The freedesktop.org admins are trying to move as many projects and services > as possible over to gitlab and somehow I got hoodwinked into spear-heading > it for mesa. There are a

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-08 Thread Daniel Stone
.2" > CC: 18.1 > CC: Abel Garcia Dorta > CC: Daniel Stone Acked-by: Daniel Stone Reviewed-by: Jason Ekstrand Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Daniel Stone
Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: > On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen > wrote: >> @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct >> x11_swapchain *chain, >> uint32_t bpp = 32; >> >> if (chain->base.use_prime_blit) { >> - result = wsi_

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Daniel Stone
On 5 May 2018 at 10:15, Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' > what(): VkResult -101004 returned > Aborted (core dumped) VK_ERROR_OUT_OF_DATE_KHR i

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Daniel Stone
On 27 April 2018 at 16:56, Michel Dänzer wrote: > And only free no longer needed back buffers there as well. > > We want to stick to the same back buffer throughout a frame, otherwise > we can run into various issues. Thanks for dealing with this Michel! Acked-by:

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Daniel Stone
Hi Johan, On 24 April 2018 at 09:44, Johan Helsing wrote: > If the call to dri_destroy_buffer is delayed until the next eglMakeCurrent, > that would also solve the problem (I'm not sure how that would affect other > things, though). It _must_ be: If the EGL surface surface is not current to an

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Daniel Stone
Hi Sergii, On 6 April 2018 at 09:12, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. Thanks a lot for writing this. I take it the cor

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2018-04-06 Thread Daniel Stone
Hi all, On 5 April 2018 at 23:55, Laura Ekstrand wrote: > So I spoke with Daniel Stone today about the infrastructure. He estimates > it will be ready to deploy the website in 2-3 weeks, at the most. So I'd > say the infrastructure will be there when we are ready. > > In

Re: [Mesa-dev] [PATCH] anv: Add WSI support for the I915_FORMAT_MOD_Y_TILED_CCS

2018-04-05 Thread Daniel Stone
ier which supports fast-clears. I've been running this for a while and haven't seen any issues with it so far, so: Reviewed-by: Daniel Stone Tested-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.free

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: fix leaks

2018-04-03 Thread Daniel Stone
Hi James, On 30 March 2018 at 16:45, James Legg wrote: > Fixes: bfa22266cd vulkan/wsi/wayland: Add support for zwp_dmabuf > CC: Daniel Stone > CC: Jason Ekstrand Wow, the cleanup hunk must have been lost in a rebase somewhere. :( At least, I think I remember writing it. Thanks a lo

Re: [Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
On 2 April 2018 at 18:52, Eric Anholt wrote: > Daniel Stone writes: >> When allocating a buffer for DRI2, set the modifier to INVALID to inform >> the backend that we have no supplied modifiers and it should do its own >> thing. The missed initialisation force

Re: [Mesa-dev] [PATCH V2 kmscube] cube-tex: make use of modifiers

2018-04-02 Thread Daniel Stone
>modifiers_supported && modifier != DRM_FORMAT_MOD_INVALID)'. With that fixed, and I suppose with the same weak-symbol handling as the others, this is: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] RFC: Externd IMG_context_priority with NV_context_priority_realtime

2018-04-02 Thread Daniel Stone
On 30 March 2018 at 19:20, Kenneth Graunke wrote: > On Friday, March 30, 2018 7:40:13 AM PDT Chris Wilson wrote: >> For i915, we are proposing to use a quality-of-service parameter in >> addition to that of just a priority that usurps everyone. Due to our HW, >> preemption may not be immediate and

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-04-02 Thread Daniel Stone
Hi Andreas, On 31 March 2018 at 15:18, Andreas Müller wrote: > Thanks for prompt an VERY helpful support. I did: > > * Check my configure and found: --disable-dri3! > * Tested your patch (with --disable-dri3) and as expected it fixes the issue > * Found what causes --disable-dri3 - it came in by

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.8 release candidate

2018-04-02 Thread Daniel Stone
Hi Juan, On 29 March 2018 at 11:25, Juan A. Suarez Romero wrote: > The plan is to have 17.3.8 this Monday (2nd April), around or shortly after > 11:00 > GMT. Does this mean we could expect 17.3.9 in a couple of weeks, or is this the last release for the 17.3.x branch? Cheers, Daniel __

[Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
: Modifier 0x0 vs. tiling (0x701) mismatch Signed-off-by: Daniel Stone Reported-by: Andreas Müller Fixes: 3f8513172ff6 ("gallium/winsys/drm: introduce modifier field to winsys_handle") --- src/gallium/state_trackers/dri/dri2.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [Mesa-dev] [PATCH] x11: Only report supported DRI3/Present versions

2018-03-30 Thread Daniel Stone
On 23 March 2018 at 13:03, Emil Velikov wrote: > On 22 March 2018 at 15:27, Daniel Stone wrote: >> The version passed to QueryVersion requests is the version that the >> client supports. We were just passing in whatever version of XCB was >> present on the system, which may

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-03-30 Thread Daniel Stone
Hi Andreas, On 30 March 2018 at 15:18, Andreas Müller wrote: > What happened: I build all images cross with Openembedded/Yocto. To > prepare next release there I updated my builds and that moved mesa > 17.1.7 -> 17.3.7. Since then all applications using GL/GLES (e.g > glmark2-es - tried others -

Re: [Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

2018-03-27 Thread Daniel Stone
11 compositor uses EGL. I have no reason to doubt your testing, so this patch is: Acked-by: Daniel Stone But it does rather fill me with trepidation, given that X11 Pixmaps are supposed to be a dumb 'bag of bits', doing nothing else than providing the same number and size of channels

Re: [Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

2018-03-27 Thread Daniel Stone
Hi Ilia, On 14 March 2018 at 19:02, Ilia Mirkin wrote: > On Tue, Mar 13, 2018 at 5:30 AM, Daniel Stone wrote: >> On 12 March 2018 at 20:45, Mario Kleiner wrote: >>> This way the wayland server can signal support for these formats >>> to wayland EGL clients. This i

Re: [Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

2018-03-22 Thread Daniel Stone
Hi Juan, On 22 March 2018 at 16:49, Juan A. Suarez Romero wrote: > Instead we will re-generate them again on building. Thanks for sending the v2 - that looks good to me. There was some kind of problem with having the sources in BUILT_SOURCES though, which Emil might be able to remember. Is it ne

Re: [Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

2018-03-22 Thread Daniel Stone
On 22 March 2018 at 15:20, Derek Foreman wrote: > commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface > queues, but the display_sync for swrast_commit_backbuffer remained on > the old queue. This is likely to break when dispatching the correct > queue at the top of function (wh

[Mesa-dev] [PATCH] x11: Only report supported DRI3/Present versions

2018-03-22 Thread Daniel Stone
which we support, and only pass those. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_x11_dri3.c | 19 +++ src/glx/dri3_glx.c | 21 +++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/src/egl/drivers/dri2

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Daniel Stone
On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> On 21 March 2018 at 13:36, Daniel Stone wrote: >> > I thought we had resolved earlier to _not_ ship files generated by >> > wayland-scanner in dist af

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-21 Thread Daniel Stone
Hi Juan, On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > The first two patches in the series is a new fix for issue > https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version > breaks when running the above command, due "make dist/distcheck" tries to > generate the th

Re: [Mesa-dev] [PATCH] dri3: Fix typo in version check

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 16:24, Dylan Baker wrote: > Quoting Daniel Stone (2018-03-20 09:17:21) >> The have-new-DRI3 codepaths would never actually properly trigger, since >> there was a typo in configure.ac which broke the version check. This >> went unnoticed but for an error

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 16:16, Dylan Baker wrote: > Quoting Daniel Stone (2018-03-20 01:54:25) >> VMware has no (published) support for Arm-architecture guests. Pushed now with review and the new suggested title - thanks both for review! Cheer

[Mesa-dev] [PATCH] dri3: Fix typo in version check

2018-03-20 Thread Daniel Stone
The have-new-DRI3 codepaths would never actually properly trigger, since there was a typo in configure.ac which broke the version check. This went unnoticed but for an error in config.log if you looked closely enough. Signed-off-by: Daniel Stone Reported-by: Lukas F. Hartmann Fixes

[Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Daniel Stone
VMware has no (published) support for Arm-architecture guests. Signed-off-by: Daniel Stone Cc: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 88e90fe8119..24cad58c61e 100644 --- a/meson.build +++ b/meson.build

[Mesa-dev] [PATCH 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-03-20 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by:

[Mesa-dev] [PATCH] dri3: Don't fail on version mismatch

2018-03-19 Thread Daniel Stone
d-off-by: Daniel Stone Fixes: 7aeef2d4efdc ("dri3: allow building against older xcb (v3)") Cc: Dave Airlie --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/platform_x11_dri3.c | 10 ++ src/glx/dri3_glx.c | 8 +

Re: [Mesa-dev] Patchwork has 'Server Error (500)'

2018-03-18 Thread Daniel Stone
Hi Dieter, On 18 March 2018 at 00:48, Dieter Nützel wrote: > @ least, here fromm Germany. > > https://patchwork.freedesktop.org/ > Server Error (500) This is fixed now, and I think that particular problem shouldn't happen again. Cheers, Daniel ___ mes

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

2018-03-16 Thread Daniel Stone
Hi, On 16 March 2018 at 15:23, Matt Turner wrote: > On Fri, Mar 16, 2018 at 8:07 AM, Emil Velikov > wrote: >> On 16 March 2018 at 02:39, Matt Turner wrote: >>> All of your messages are going to spam on gmail: >>> >> Setting up a filter for 'list:"mesa-dev.lists.freedesktop.org"' will help >>

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Daniel Stone
Hi Juan, On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > Trivial merge conflicts > --- > > [...] > > commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 > Author: Daniel Stone > > egl/wayland: Fix ARGB/XRGB transposition in config map

Re: [Mesa-dev] [PATCH 1/2] autotools+dri3: allow building against older xcb (v4)

2018-03-14 Thread Daniel Stone
Hi, On 14 March 2018 at 13:04, Rob Clark wrote: > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distro that aren't brand new. I don't have that much of an opinion on whether the dependency should b

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: correct DRI3 version in comment

2018-03-13 Thread Daniel Stone
Hi Emil, On 13 March 2018 at 11:40, Emil Velikov wrote: > During development the version was bumped, yet the comment did not get > an update. > > Cc: Daniel Stone > Fixes: c80c08e2260 ("vulkan/wsi/x11: Add support for DRI3 v1.2") > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

2018-03-13 Thread Daniel Stone
Hi Mario, On 12 March 2018 at 20:45, Mario Kleiner wrote: > This way the wayland server can signal support for these formats > to wayland EGL clients. This is currently used by nouveau for 10 > bpc support. > > Tested with glmark2-wayland and glmark2-es2-wayland under weston > to now expose 10 bp

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Daniel Stone
Hi Juan, On 12 March 2018 at 12:10, Juan A. Suarez Romero wrote: > On Mon, 2018-03-12 at 11:49 +0000, Daniel Stone wrote: >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > We are improving this by moving to use Gitlab CI (still wip), which allows >> >

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Daniel Stone
Hi Juan, On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> - CI Automation immediately builds/tests the proposed stable branch >>whenever it changes. Release managers verify the results. >> > > This is k

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Daniel Stone
On 10 March 2018 at 14:53, Christian Gmeiner wrote: > Fixes following dependency problem: > Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Oh, oops! Thanks for the catch Christian. Reviewed-by: Daniel Stone Fixes: c80c08e22603 ("vu

[Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

2018-03-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

[Mesa-dev] [PATCH 2/2] gbm: Add support for 10bpp BGR formats

2018-03-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index df20db40218..b3d6ceb15a3 100644 --- a/src/gbm

Re: [Mesa-dev] nouveau 30bpp / deep color status

2018-03-08 Thread Daniel Stone
Hi, On 8 March 2018 at 17:08, Ilia Mirkin wrote: > On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner > wrote: >> Under EGL there is matching of channel masks, so only X11+GLX is >> problematic. Not sure if anything special would need to be done for >> XWayland, haven't looked at that at all so far.

Re: [Mesa-dev] [PATCH mesa] gbm: give a name to rgba fields

2018-03-05 Thread Daniel Stone
On 5 March 2018 at 14:40, Eric Engestrom wrote: > Note: `gbm_dri_visuals_table` doesn't need any modification, as the > channel order doesn't change, so `rgba_mask = { r, g, b, a }` still > works. Yeah, this is a very definite and obvious improvement. Thanks Eric! Review

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Daniel Stone
Hi, On 2 March 2018 at 12:06, Thierry Reding wrote: > On Thu, Mar 01, 2018 at 09:37:28AM -0500, Ilia Mirkin wrote: >> > +static void >> > +nvc0_query_dmabuf_modifiers(struct pipe_screen *screen, >> > +enum pipe_format format, int max, >> >> Maybe change this to "unsign

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-02-28 Thread Daniel Stone
Hi, On 28 February 2018 at 09:33, Eric Engestrom wrote: > On Tuesday, 2018-02-27 18:01:11 +0000, Daniel Stone wrote: >> On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as >> 'aarch64'), only build swrast for DRI drivers. > > The commit

[Mesa-dev] [PATCH v2 2/2] meson: Don't build svga on ARM/AArch64

2018-02-27 Thread Daniel Stone
VMware has no (published) support for Arm-architecture guests. Signed-off-by: Daniel Stone Cc: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c349e9e5f85..92200a3d64a 100644 --- a/meson.build +++ b/meson.build

[Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by:

Re: [Mesa-dev] [PATCH] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
Hi Dylan, On Tue, 2018-02-27 at 09:13 -0800, Dylan Baker wrote: > Quoting Daniel Stone (2018-02-27 02:08:29) > > --- a/meson.build > > +++ b/meson.build > > @@ -100,6 +100,8 @@ if _drivers == 'auto' > > # TODO: PPC, Sparc > > if ['

[Mesa-dev] [PATCH] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by:

Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-25 Thread Daniel Stone
Hi, On 24 February 2018 at 00:43, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 4:31 PM, Keith Packard wrote: >> + image->chain = chain; >> + image->state = wsi_image_idle; >> + image->fb_id = 0; >> + >> + /* XXX extract depth and bpp from image somehow */ > > You have the format in cr

Re: [Mesa-dev] [PATCH] gbm: Fix the alpha masks in the GBM format table.

2018-02-23 Thread Daniel Stone
Reviewed-by: Daniel Stone You can probably tell I only tested XRGB. Sorry!___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Daniel Stone
Hi Marc, On 23 February 2018 at 15:42, Marc Dietrich wrote: > Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone: >> On 20 February 2018 at 18:36, Dylan Baker wrote: >> > Currently meson will generate a pkg-config that links to EGL_mesa (or >> > GLX_me

Re: [Mesa-dev] [ANNOUNCE] mesa-demos 8.4.0

2018-02-23 Thread Daniel Stone
Hi Marc, On 23 February 2018 at 12:58, Marc Dietrich wrote: > my system has problems with linking xdemos: > ... > CCLD glsync > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: > glsync.o: undefined reference to symbol 'glXQueryExtensionsString' > /usr/lib64/libGL.

Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files with glvnd

2018-02-23 Thread Daniel Stone
Hi Dylan, On 20 February 2018 at 18:36, Dylan Baker wrote: > Currently meson will generate a pkg-config that links to EGL_mesa (or > GLX_mesa), but this isn't correct, it should always link to EGL or GL. > Probably the "right" solution is to have glvnd itself provide the pkg > config files for GL

<    1   2   3   4   5   6   7   8   >