Thanks, r-b and pushed!
On 27.03.2018 22:40, Stefan Schake wrote:
Fixes: 76dfed8ae2d5 ("nir: mako all the intrinsics")
Signed-off-by: Stefan Schake
Acked-by: Rob Clark
---
src/compiler/Android.nir.gen.mk | 9 +
1 file changed, 9
Thanks, I'll modify the commit message a bit and push this in.
On 03/26/2018 05:13 PM, Lin Johnson wrote:
Ext_color_buffer_half_float is using type GL_HALF_FLOAT
and data_type GL_FLOAT. This fix Android CTS test
android.view.cts.PixelCopyTest
v2: remove commtens of Ext_color_buffer_half_float.
On 03/23/2018 03:20 PM, Tomasz Figa wrote:
On Fri, Mar 23, 2018 at 10:15 PM, Stefan Schake wrote:
On Fri, Mar 23, 2018 at 1:02 PM, Tomasz Figa wrote:
On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss wrote:
Hey Chih-Wei,
On
Yes, this fixes the app where I saw this issue, thanks!
Tested-by: Tapani Pälli <tapani.pa...@intel.com>
On 03/23/2018 10:54 PM, Ian Romanick wrote:
From: Ian Romanick <ian.d.roman...@intel.com>
A recent commit (see below) triggered some cases where conditional
modifier propagat
On 23.03.2018 12:18, Alejandro Piñeiro wrote:
On 23/03/18 09:58, Tapani Pälli wrote:
On 03/23/2018 07:54 AM, Lin, Johnson wrote:
So the solution will be query if EXT_color_buffer_half_float is
supported?
I think I found a proof that we don't actually need anything. Spec
No good to have random data in serialized nir;
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 23.03.2018 12:48, Lionel Landwerlin wrote:
I don't think it actually fixes anything, but that's nice not to have valgrind
warnings.
It manifests itself when running the piglit test : g
ping Jason ..
On 22.03.2018 13:30, vadym.shovkoplias wrote:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105440
Fixes: 2458ea95c56 "nir/lower_vec_to_movs: Coalesce movs on-the-fly when
possible"
Signed-off-by: Andriy Khulap
Signed-off-by: Vadym
On 03/21/2018 08:55 PM, Eric Engestrom wrote:
On March 21, 2018 6:47:48 PM UTC, Dylan Baker wrote:
Quoting Emil Velikov (2018-03-21 10:53:08)
On 21 March 2018 at 17:09, Eric Engestrom
wrote:
Cc: Maxin B. John
Cc:
TCH] mesa: readpixels add support for GL_HALF_FLOAT
On 03/22/2018 07:53 AM, Tapani Pälli wrote:
On 03/22/2018 04:43 AM, Lin, Johnson wrote:
Hi, Thanks for the comments.
I just noticed it does not check the extension support for
EXT_color_buffer_float neither?
That is probably because it is enabled as 'du
On 03/22/2018 07:53 AM, Tapani Pälli wrote:
On 03/22/2018 04:43 AM, Lin, Johnson wrote:
Hi, Thanks for the comments.
I just noticed it does not check the extension support for
EXT_color_buffer_float neither?
That is probably because it is enabled as 'dummy_true' (see
extensions_table.h
On 03/22/2018 01:01 PM, Emil Velikov wrote:
Hi guys,
On 22 March 2018 at 08:23, Tomasz Figa wrote:
Hi Chih-Wei,
On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote:
2018-02-21 3:03 GMT+08:00 Rob Herring :
Perhaps worth
intel.com>; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT
On 21.03.2018 12:45, Tapani Pälli wrote:
On 21.03.2018 08:52, Alejandro Piñeiro wrote:
On 21/03/18 06:57, Lin Johnson wrote:
Ext_color_buffer_half_float is using type G
On 21.03.2018 12:45, Tapani Pälli wrote:
On 21.03.2018 08:52, Alejandro Piñeiro wrote:
On 21/03/18 06:57, Lin Johnson wrote:
Ext_color_buffer_half_float is using type GL_HALF_FLOAT
and data_type GL_FLOAT. This fix Android CTS test
android.view.cts.PixelCopyTest
On 21.03.2018 08:52, Alejandro Piñeiro wrote:
On 21/03/18 06:57, Lin Johnson wrote:
Ext_color_buffer_half_float is using type GL_HALF_FLOAT
and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest
#TestWindowProducerCopyToRGBA16F
Signed-off-by: Lin Johnson
When sending this I did not realize there are also other patches in list
... hopefully this makes sense. Anyway, this fixes issues for me and
build is fine on Android.
On 21.03.2018 09:15, Tapani Pälli wrote:
From: Lionel Landwerlin <lionel.g.landwer...@intel.com>
This is the equi
From: Lionel Landwerlin <lionel.g.landwer...@intel.com>
This is the equivalent of commit 5770e1d89e0eb49eb3c9547e8657d636b6e7e5d7 for
android.
v2: fix xml files path and file given to --header
Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
Signed-off-by:
On 20.03.2018 23:11, Lionel Landwerlin wrote:
This is the equivalent of commit 5770e1d89e0eb49eb3c9547e8657d636b6e7e5d7 for
android.
Signed-off-by: Lionel Landwerlin
Fixes: 2d2b15fbcab ("i965: fix autotools/android build")
---
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 20.03.2018 16:59, Lionel Landwerlin wrote:
Autotools/android builds generate the header & code files in 2 steps,
but the code generation requires the name of the header file to
include it.
This change generates both files in o
==by 0x86032C4: _mesa_add_sized_state_reference
(prog_parameter.c:384)
==15115==by 0x8603324: _mesa_add_state_reference (prog_parameter.c:409)
Fixes: edded12376 "mesa: rework ParameterList to allow packing"
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
Exposing the visual makes following dEQP tests pass on Android:
dEQP-EGL.functional.wide_color.window__colorspace_srgb
dEQP-EGL.functional.wide_color.pbuffer__colorspace_srgb
Visual is exposed only when DRI_LOADER_CAP_RGBA_ORDERING is set.
Signed-off-by: Tapani Pälli <tapani
Add format definition and required plumbing to create images.
Note that there is no match to drm_fourcc definition, just like
with existing _DRI_IMAGE_FOURCC_SARGB.
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
include/GL/internal/dri_interface.h| 2 ++
src/
On 03/16/2018 02:10 PM, Juan A. Suarez Romero wrote:
On Fri, 2018-03-16 at 13:25 +0200, Tapani Pälli wrote:
On 03/16/2018 01:13 PM, Tapani Pälli wrote:
On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote:
On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote:
On 03/15/2018 02:04 PM
On 03/15/2018 11:07 AM, Tapani Pälli wrote:
Patches 1-3:
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
Make that the whole series!
I tested also briefly with app that uses glProgramBinary to implement
cache and verified result of GL_LINK_STATUS query with glGetProgramiv
On 03/16/2018 01:13 PM, Tapani Pälli wrote:
On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote:
On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote:
On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote:
According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return
On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote:
On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote:
On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote:
According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return
an INVALID_OPERATION if the internalformat of the texture
: call gen9_set_astc5x5_wa_mode directly in brw_predraw_resolve_inputs
(Tapani)
Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com>
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
I've gone through this patch and wanted to express my thoughts as v2
rather than review. I've also di
On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote:
According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return
an INVALID_OPERATION if the internalformat of the texture is RGB9_E5.
This fixes
Patches 1-3:
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
(also verified with xfb using app)
On 03/14/2018 09:26 AM, Jordan Justen wrote:
git://people.freedesktop.org/~jljusten/mesa shader-cache-xform-fb+prog-bin-v1
Patches 1 - 3 remove the restriction preventing the disk shader
On 03/07/2018 04:29 PM, Emil Velikov wrote:
On 7 March 2018 at 06:02, Tapani Pälli <tapani.pa...@intel.com> wrote:
On 03/07/2018 12:36 AM, Marek Olšák wrote:
On Mon, Mar 5, 2018 at 7:33 AM, Tapani Pälli <tapani.pa...@intel.com>
wrote:
Hi;
On 03/02/2018 03:25 PM, Andres
On 03/07/2018 12:36 AM, Marek Olšák wrote:
On Mon, Mar 5, 2018 at 7:33 AM, Tapani Pälli <tapani.pa...@intel.com> wrote:
Hi;
On 03/02/2018 03:25 PM, Andres Gomez wrote:
This way we won't fail when validating just because we may have a non
overriden core version that is lowe
Thanks, will push this;
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 03/07/2018 01:15 AM, Mauro Rossi wrote:
Fixes the following building errors:
external/mesa/src/intel/vulkan/anv_device.c:300: error: undefined reference to
'gen_get_pci_device_id_override'
external/mesa/src
On 06.03.2018 14:07, Emil Velikov wrote:
On 6 March 2018 at 07:32, Tapani Pälli <tapani.pa...@intel.com> wrote:
Hi;
On 01.03.2018 03:12, Kenneth Graunke wrote:
On Thursday, February 15, 2018 1:12:54 AM PST Tapani Pälli wrote:
From: Simon Hausmann <simon.hausm...@qt.io>
Whe
Hi;
On 01.03.2018 03:12, Kenneth Graunke wrote:
On Thursday, February 15, 2018 1:12:54 AM PST Tapani Pälli wrote:
From: Simon Hausmann <simon.hausm...@qt.io>
When looking up known glsl_type instances in the various hash tables, we
end up leaking the key instances used for the
LGTM
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 06.03.2018 03:00, Clayton Craft wrote:
This adds a missing library to the i965/Android.mk file, and updates
intel/Android.mk to include the new library. Without this, mesa does not
build on Android.
Fixes: 272bef0601a "i
On Android surface/swapchain extensions are implemented by the loader. Patch
modifies both anv and radv extension scripts disabling currently exposed
ones. See also earlier commit 9f763c1f9b.
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/amd/vulkan/radv_extensions.p
asked
is > 3.2 then we always do core context, even when overriding to compat
profile?
Assuming it's OK to have both __DRI_API_OPENGL and __DRI_API_OPENGL_CORE
in api_mask;
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
For example, running glcts from VK-GL-CTS with i965, this wil
On 03/05/2018 01:46 PM, Emil Velikov wrote:
Hi Tapani,
On 5 March 2018 at 08:57, Tapani Pälli <tapani.pa...@intel.com> wrote:
Just like commit 2ffe395 does for radv.
Fixes following dEQP test on i965:
dEQP-VK.api.info.android.no_unknown_extensions
v2: make it !ANDROID
Just like commit 2ffe395 does for radv.
Fixes following dEQP test on i965:
dEQP-VK.api.info.android.no_unknown_extensions
v2: make it !ANDROID since this extension is not about
surfaces/swapchain
CC: 18.0 <mesa-sta...@lists.freedesktop.org>
Signed-off-by: Tapani Pälli <
Just like commit 2ffe395 does for radv.
Fixes following dEQP test on i965:
dEQP-VK.api.info.android.no_unknown_extensions
CC: 18.0 <mesa-sta...@lists.freedesktop.org>
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/intel/vulkan/anv_extensions.py | 2 +-
1 fil
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 03/02/2018 01:28 PM, Andres Gomez wrote:
Found by inspection.
Cc: Ian Romanick <ian.d.roman...@intel.com>
Cc: Emil Velikov <emil.veli...@collabora.com>
Cc: Eric Engestrom <eric.engest...@imgtec.com>
Signed-o
Hi;
Some feedback below ..
On 02/28/2018 02:21 PM, Hugues Evrard wrote:
Hi Brian, all,
Thanks for the follow-up, and congrats to the team for the prompt bug
fix! We've just tweeted about it:
https://twitter.com/GraphicsFuzz/status/968815766681333760
We'll be pleased to report further Mesa
anv_gem_set_context_param is to be used directly instead!
Fixes: 6d8ab53303 "anv: implement VK_EXT_global_priority extension"
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/intel/vulkan/anv_device.c | 5 +++--
src/intel/vulkan/anv_gem.c | 9 -
On 27.02.2018 15:07, Samuel Iglesias Gonsálvez wrote:
On 27/02/18 13:37, Tapani Pälli wrote:
On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote:
According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders"
section, the precision qualifier should match for uniform
On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote:
According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders"
section, the precision qualifier should match for uniform variables.
This also applies to previous GLSL ES 3.x specs.
This 'if' checks the condition for uniform
v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris)
use unreachable with unknown priority (Samuel)
v3: add stubs in gem_stubs.c (Emil)
use priority defines from gen_defines.h
v4: cleanup, add anv_gem_set_context_param (Jason)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
Re
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 02/27/2018 08:44 AM, Harish Krupo wrote:
Signed-off-by: Harish Krupo <harish.krupo@intel.com>
---
src/intel/Android.vulkan.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/Android.vulkan.mk
On 02/27/2018 05:00 AM, Harish Krupo wrote:
Hi Tapani,
Tapani Pälli <tapani.pa...@intel.com> writes:
On 02/20/2018 10:10 AM, Harish Krupo wrote:
Signed-off-by: Harish Krupo <harish.krupo@intel.com>
---
src/intel/Android.vulkan.mk | 3 ++-
1 file changed, 2 inse
On 02/26/2018 07:55 PM, Emil Velikov wrote:
On 15 February 2018 at 09:12, Tapani Pälli <tapani.pa...@intel.com> wrote:
From: Simon Hausmann <simon.hausm...@qt.io>
When looking up known glsl_type instances in the various hash tables, we
end up leaking the key instances used fo
On 02/20/2018 10:10 AM, Harish Krupo wrote:
Signed-off-by: Harish Krupo
---
src/intel/Android.vulkan.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk
index 6fe736d397..444278613d
ping ..
On 02/15/2018 11:12 AM, Tapani Pälli wrote:
From: Simon Hausmann <simon.hausm...@qt.io>
When looking up known glsl_type instances in the various hash tables, we
end up leaking the key instances used for the lookup, as the glsl_type
constructor allocates memory on the global m
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 15.02.2018 13:01, Eric Engestrom wrote:
Doesn't really change anything to the test though ¯\_(ツ)_/¯
CID: 1429511
Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create
test"
Signed-off-by: Eric Engest
memory, which fixes the leak and also allows
getting rid of the global mem_ctx and its mutex.
v2: remove lambda usage (Tapani)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104884
Signed-off-by: Simon Hausmann <simon.hausm...@qt.io>
Signed-off-by: Tapani Pälli <tapani.pa...@inte
Same fix was sent by Jason earlier :) See:
https://lists.freedesktop.org/archives/mesa-dev/2018-February/185446.html
On 14.02.2018 15:37, Andriy Khulap wrote:
Fixes: db5f4221696a
(i965: fix tessellation regressions with gl_state_index16)
Bugzilla:
On 14.02.2018 09:54, Tapani Pälli wrote:
On 14.02.2018 09:38, Rogovin, Kevin wrote:
Hi,
The 3rd patch, "i965: use ASTC5x5 workaround in
intel_miptree_texture_aux_usage has issues:
1. Definitely: brw_draw lacks the call to
gen9_astc5x5_perform_wa() which generates the needed
workaround
On 02/12/2018 09:44 AM, Tapani Pälli wrote:
Hi;
On 02/08/2018 09:50 AM, Rogovin, Kevin wrote:
Hi,
I gave it a whirl of setting the .mocs field set to 0 passed to
isl_surf_fill_state() ALWAYS. Sadly CarChase GLES continued to hang
(where as the GL did not because it does not use
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 14.02.2018 00:57, Jason Ekstrand wrote:
This fixes the build in clang
---
src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_nir_unifor
On 02/12/2018 09:44 AM, Tapani Pälli wrote:
Hi;
On 02/08/2018 09:50 AM, Rogovin, Kevin wrote:
Hi,
I gave it a whirl of setting the .mocs field set to 0 passed to
isl_surf_fill_state() ALWAYS. Sadly CarChase GLES continued to hang
(where as the GL did not because it does not use ASTC
Hi;
On 02/08/2018 09:50 AM, Rogovin, Kevin wrote:
Hi,
I gave it a whirl of setting the .mocs field set to 0 passed to
isl_surf_fill_state() ALWAYS. Sadly CarChase GLES continued to hang
(where as the GL did not because it does not use ASTC). This makes sense
since MOCS (atleast last time I
On 02/09/2018 06:03 AM, Timothy Arceri wrote:
On 09/02/18 14:45, Timothy Arceri wrote:
On 08/02/18 16:36, Tapani Pälli wrote:
Hi;
On 02/08/2018 06:00 AM, Timothy Arceri wrote:
Hi Tapani,
This patch causes deadlock when running piglit on my radeonsi with
my ryzen (16 threads all running
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/util/disk_cache.c | 162 +++---
1 file changed, 76 insertions(+), 86 deletions(-)
diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
index ea6808aaf8..34a9145a72 100644
--- a/src/u
Thanks Mauro!
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 02/08/2018 02:21 AM, Mauro Rossi wrote:
How about introducing ANV_LIBRARIES (near to ANV_INCLUDES) and setting
libdrm and libnativewindow there, then for each libanv just have the
$(ANV_LIBRARIES)?
IMO this woul
some
more debug information?
Tim
On 31/01/18 18:17, Tapani Pälli wrote:
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without a path using callback
functionality introduced by next patch.
v2: unmap mmap and destroy queue only if index_mmap
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 06.02.2018 19:06, Lionel Landwerlin wrote:
This helps figuring out potential problems when metrics don't show up
on frameretrace for example.
Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
---
src/mesa/driv
Both patches are
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 07.02.2018 01:56, Lionel Landwerlin wrote:
ioctl() might be interrupted, use drmIoctl() instead as it'll retry
automatically.
Fixes: 27ee83eaf7e "i965: perf: add support for userspace configurations"
Cc:
On 05.02.2018 17:26, Emil Velikov wrote:
On 5 February 2018 at 07:02, Tapani Pälli <tapani.pa...@intel.com> wrote:
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
v3: remove useless checking, add _eglSetFuncName (Emi
Hi;
On 02/04/2018 11:57 PM, Mauro Rossi wrote:
Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow")
Fixes the following building errors:
In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer.c:30:
In file included from
ut-c' or
anv_extensions.h did not exist. Those were introduced later by commit
dd088d4bec which this commit is fixing.
With that changed;
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
Cc: "18.0" <mesa-sta...@lists.freedesktop.org>
---
src/intel/Android.vulkan.mk |
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 02/03/2018 11:58 PM, Jordan Justen wrote:
Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com>
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com>
---
docs/relnotes/18.1.0.html | 1 +
src/mes
put/get that should fail with invalid path set
(Emil)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> (v1)
---
src/compiler/glsl/tests/cache_test.c | 28 ++--
1 file changed, 22 insertions(+),
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
v3: remove useless checking, add _eglSetFuncName (Emil Velikov)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> (v
From: Ilia Mirkin <imir...@alum.mit.edu>
Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu>
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
---
This one was originally sent as:
https://patchwork.freedesktop.org/patch/45339/
I've done trivial rebase for the patch, went t
This fixes the issue;
Tested-by: Tapani Pälli <tapani.pa...@intel.com>
On 02/01/2018 03:41 AM, Jason Ekstrand wrote:
This fixes some rendering corruption in a couple of Android apps that
use window-system MSAA.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104741
Cc: me
On 31.01.2018 15:51, Tapani Pälli wrote:
On 31.01.2018 15:41, Emil Velikov wrote:
On 31 January 2018 at 07:17, Tapani Pälli <tapani.pa...@intel.com> wrote:
- /* Before doing anything else, ensure that with
- * MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create
return
On 31.01.2018 15:41, Emil Velikov wrote:
On 31 January 2018 at 07:17, Tapani Pälli <tapani.pa...@intel.com> wrote:
- /* Before doing anything else, ensure that with
-* MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns NULL.
-*/
- setenv("MESA_GLSL_CA
On 31.01.2018 15:18, Emil Velikov wrote:
On 31 January 2018 at 07:17, Tapani Pälli <tapani.pa...@intel.com> wrote:
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without a path using callback
functionality introduced by next patch.
v2:
On 31.01.2018 15:07, Tapani Pälli wrote:
On 31.01.2018 13:58, Emil Velikov wrote:
On 31 January 2018 at 07:17, Tapani Pälli <tapani.pa...@intel.com> wrote:
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
Signed-off-b
On 31.01.2018 13:58, Emil Velikov wrote:
On 31 January 2018 at 07:17, Tapani Pälli <tapani.pa...@intel.com> wrote:
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
On 31.01.2018 11:18, Jordan Justen wrote:
On 2018-01-30 23:17:05, Tapani Pälli wrote:
v2: add disk_cache_has_key, disk_cache_put_key support
using blob cache (Nicolai, Jordan)
v3: rename set_cb as put_cb to match existing naming (Timothy)
Signed-off-by: Tapani Pälli <tapani
On 31.01.2018 11:27, Jordan Justen wrote:
On 2018-01-30 23:17:06, Tapani Pälli wrote:
v2: adjust to change that moved cache from ctx to screen
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/mesa/drivers/dri/i965/intel_screen.c | 21 +
1 file chang
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
(I verified the 1st one and I trust you on the 2nd one.)
BTW I witnessed pahole crashing when processing visit() methods of
ir_print_visitor class, did you experience that? My pahole version is
1.9, it dies in /lib64/libdwarves.so.1
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 30.01.2018 17:11, Juan A. Suarez Romero wrote:
According with OpenGL GLSL 3.20 spec, section 4.3.9:
"It is a link-time error if any particular shader interface
contains:
- two different blocks, each having no in
Patch moves functions higher so that we can utilize them from
test_disk_cache_create which is modified by next patch.
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/compiler/glsl/tests/cache_test.c | 70 ++--
1 file changed, 35 insertions(
v2: add disk_cache_has_key, disk_cache_put_key support
using blob cache (Nicolai, Jordan)
v3: rename set_cb as put_cb to match existing naming (Timothy)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/util/disk_cache.c | 49
v2: adjust to change that moved cache from ctx to screen
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/mesa/drivers/dri/i965/intel_screen.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drive
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without a path using callback
functionality introduced by next patch.
v2: unmap mmap and destroy queue only if index_mmap exists
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
sr
v2: move from __DRIcontext to __DRIscreen (Emil Velikov)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
include/GL/internal/dri_interface.h | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/include/GL/internal/dri_interface.h
b/incl
-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/compiler/glsl/tests/cache_test.c | 51 ++--
1 file changed, 20 insertions(+), 31 deletions(-)
diff --git a/src/compiler/glsl/tests/cache_test.c
b/src/compiler/glsl/tests/cache_test.c
index dd11fd5944..4a2f43a4c3
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/egl/drivers/dri2/egl_dri2.c | 25 +
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/main
Android-IA testing was done with:
https://github.com/tpalli/external-mesa/tree/boy_and_his_blob
Thanks;
Tapani Pälli (7):
dri: add interface for EGL_ANDROID_blob_cache extension
egl: add support for EGL_ANDROID_blob_cache
glsl/tests: move utility functions in cache_test
glsl/tests
On 01/29/2018 01:36 PM, Elie Tournier wrote:
On Mon, Jan 29, 2018 at 01:24:42PM +0200, Tapani Pälli wrote:
On 01/29/2018 12:05 PM, Elie Tournier wrote:
On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote:
Hi;
On 01/25/2018 05:18 PM, Elie Tournier wrote
Now every context refers to same disk_cache instance in screen.
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
Suggested-by: Emil Velikov <emil.veli...@collabora.com>
---
src/mesa/drivers/dri/i965/brw_context.c| 4 +---
src/mesa/drivers/dri/i965/brw_disk_cache.c | 6 +++-
On 01/29/2018 12:05 PM, Elie Tournier wrote:
On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote:
Hi;
On 01/25/2018 05:18 PM, Elie Tournier wrote:
texture_format_error_check_gles() displays error like "glTexImage%dD".
This patch just replace the %d by the correct dimensio
Reviewing own code ...
This change does not work well with existing unit tests for disk cache.
I'll have to do some changes to those tests.
On 01/22/2018 03:00 PM, Tapani Pälli wrote:
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without
On 01/27/2018 01:29 AM, Jordan Justen wrote:
On 2018-01-26 00:48:42, Tapani Pälli wrote:
==2780== 1,024 bytes in 1 blocks are possibly lost in loss record 180 of 205
==2780==at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
==2780==by 0x13F6467E: util_queue_init (u_queue.c
Hi;
On 01/25/2018 05:18 PM, Elie Tournier wrote:
texture_format_error_check_gles() displays error like "glTexImage%dD".
This patch just replace the %d by the correct dimension.
Signed-off-by: Elie Tournier
---
src/mesa/main/teximage.c | 13 ++---
1 file
(disk_cache.c:947)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/compiler/nir/nir_serialize.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/nir/nir_serialize.c b/src/compiler/nir/nir_serialize.c
index 54a00c81d6..9fe46a675f 100644
--- a/src/compiler/nir/nir_seria
==by 0x13F05406: brw_disk_cache_init (brw_disk_cache.c:428)
==2780==by 0x13F01E78: brwCreateContext (brw_context.c:1068)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dr
==by 0x1411A5C9: brw_disk_cache_upload_program
(brw_disk_cache.c:271)
==25481==by 0x1412FCA4: brw_upload_wm_prog (brw_wm.c:597)
Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
---
src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drive
I've verified this gets the correct address. Very nice work figuring
this out Stephan!
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 01/24/2018 04:13 PM, Stephan Gerhold wrote:
build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD
segment has a virtual a
On 24.01.2018 18:02, Juan A. Suarez Romero wrote:
On Mon, 2018-01-22 at 08:41 +0200, Tapani Pälli wrote:
On 01/19/2018 12:44 PM, Juan A. Suarez Romero wrote:
Anyone could take a look at this patch?
Can you pinpoint where the mentioned tests are located, which suite?
Yes. It's
401 - 500 of 2124 matches
Mail list logo