Re: [Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 08/03/2017 07:52 PM, Jason Ekstrand wrote: The make_shareable function deletes the aux buffer and then whacks aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear. Since we only look at supports_fast_clear to decide w

[Mesa-dev] [PATCH] android: anv_extensions.c is generated to libmesa_vulkan_common

Fixes build error with anv_extensions.c not found for libmesa_anv_entrypoints. Fixes: d62063c "anv: Autogenerate extension query and lookup" Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/intel/Android.vulkan.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Mesa-dev] [PATCH] i965: do not attempt fast clear with ISL_AUX_USAGE_NONE

Aux usage is ISL_AUX_USAGE_NONE when miptree is set shareable within (intel_miptree_make_shareable). Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925 --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 1 file changed, 4 inse

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

On 08/03/2017 09:33 AM, Tapani Pälli wrote: On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli <tapani.pa...@intel.com> wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on A

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli <tapani.pa...@intel.com> wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. Can you p

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. On 08/02/2017 11:35 PM, Jason Ekstrand wrote: Originally, I had moved it to the caller to make some things easier when adding the CCS

Re: [Mesa-dev] [PATCH mesa 1/3] egl: deduplicate swap interval clamping logic

lgtm Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 08/01/2017 03:55 PM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/platform_wayland.c | 14 +-

Re: [Mesa-dev] [PATCH] intel/isl: Stop padding surfaces

Did some testing with this and run GL applications, Vulkan applications, video playback + some selected dEQP and did not observe any regression. Tested-by: Tapani Pälli <tapani.pa...@intel.com> On 07/31/2017 09:27 PM, Jason Ekstrand wrote: The docs contain a bunch of commentary about th

Re: [Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

On 08/01/2017 02:04 PM, Eric Engestrom wrote: On Tuesday, 2017-08-01 10:51:54 +0300, Tapani Pälli wrote: It is required by libmesa_dri_common and i965_dri modules which both already use MESA_DRI_C_INCLUDES. Fixes following build errors: In file included from vendor/intel/external/android_ia

[Mesa-dev] [PATCH] android: export intermediates from libmesa_util

/intel/external/android_ia/mesa/src/mesa/drivers/dri/i965/intel_screen.c:44: vendor/intel/external/android_ia/mesa/src/util/xmlpool.h:103:10: fatal error: 'xmlpool/options.h' file not found Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/mesa/drivers/dri/common/Android.mk | 2 +

Re: [Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

On 08/01/2017 12:20 PM, Chih-Wei Huang wrote: 2017-08-01 15:51 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: It is required by libmesa_dri_common and i965_dri modules which both already use MESA_DRI_C_INCLUDES. Fixes following build errors: In file included from vendor/intel/ex

[Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

:10: fatal error: 'xmlpool/options.h' file not found --- In file included from vendor/intel/external/android_ia/mesa/src/mesa/drivers/dri/i965/intel_screen.c:44: vendor/intel/external/android_ia/mesa/src/util/xmlpool.h:103:10: fatal error: 'xmlpool/options.h' file not found Signed-off-by: Tapani

Re: [Mesa-dev] [PATCH 1/2] android: link libmesa_intel_common with zlib and expat

On 08/01/2017 12:17 AM, Rob Herring wrote: On Mon, Jul 31, 2017 at 3:45 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: On 31 July 2017 at 09:32, Tapani Pälli <tapani.pa...@intel.com> wrote: Makes it possible to build Mesa on Android with -DDEBUG with the next patch that reve

[Mesa-dev] [PATCH 2/2] intel: move gen_decoder.* back to COMMON_FILES

this change reverts commit 4f695731, we want to be able to build with -DDEBUG and gen_decoder on Android. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/intel/Makefile.common.am | 2 +- src/intel/Makefile.sources | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 1/2] android: link libmesa_intel_common with zlib and expat

Makes it possible to build Mesa on Android with -DDEBUG with the next patch that reverts 4f695731. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/intel/Android.common.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/Android.common.mk b/src

Re: [Mesa-dev] i965: Transition the rest of surfaces (i.e., color) to isl

On 07/29/2017 08:21 AM, Jason Ekstrand wrote: On Fri, Jul 28, 2017 at 10:14 PM, Tomasz Figa > wrote: On Sat, Jul 29, 2017 at 2:06 PM, Jason Ekstrand > wrote: > On Fri, Jul 28, 2017

Re: [Mesa-dev] [PATCH] util: fix warning/error on 32bit build

On 07/25/2017 09:08 AM, Michel Dänzer wrote: On 25/07/17 03:02 PM, Michel Dänzer wrote: On 25/07/17 02:42 PM, Tapani Pälli wrote: Add uintptr_t cast to fix 'cast to pointer from integer of different size' warning on 32bit build (build error on Android M). Signed-off-by: Tapani Pälli

[Mesa-dev] [PATCH] util: fix warning/error on 32bit build

Add uintptr_t cast to fix 'cast to pointer from integer of different size' warning on 32bit build (build error on Android M). Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/util/hash_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sr

Re: [Mesa-dev] [PATCH] egl: guard wayland header dep. tracking behind HAVE_PLATFORM_WAYLAND

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 07/24/2017 03:27 PM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Otherwise we'll attemt to generate the header even we don't need to. In that case the dependencies may not be met, leading to build

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

I sent attempt to fix this here: https://patchwork.freedesktop.org/patch/168609/ On 07/24/2017 03:25 PM, Luke A. Guest wrote: master currently fails when enabling egl because drivers/dri2/linux-dmabuf-unstable-v1-protocol.c doesn't exist, should it? Luke. On 19/07/17 23:44, Andres Gomez

[Mesa-dev] [PATCH 2/2] egl: guard wayland specific bits with HAVE_PLATFORM_WAYLAND

Fixes: 166852e "configure.ac: rework wayland-protocols handling" Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- This fixes following build error for me: make[4]: *** No rule to make target '/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml', needed by 'drivers/d

[Mesa-dev] [PATCH 1/2] egl: fix whitespace issues from eglimage code

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/egl/main/eglimage.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c index 72a556e..46bf0c5 100644 --- a/src/egl/main/eglimage.c +++ b/s

Re: [Mesa-dev] [PATCH] Android: fix spirv_info.c generation

Nice, I think it was done like this in some other occurence too; Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 07/20/2017 01:30 PM, Chih-Wei Huang wrote: It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's changing. The typical way to handle it is to use private va

Re: [Mesa-dev] [PATCH] Revert "i965: Call intel_prepare_render() from intel_update_state()"

Works for Android-IA: Tested-by: Tapani Pälli <tapani.pa...@intel.com> On 07/20/2017 09:00 AM, Kenneth Graunke wrote: This reverts commit b7153c3e9f9d2d430b0338313587a00e531e4800. The point of that commit was to ensure intel_prepare_render() occurred before color resolves on the c

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

On 07/19/2017 05:01 PM, Rob Herring wrote: On Wed, Jul 19, 2017 at 8:56 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: On 19 July 2017 at 14:14, Tapani Pälli <tapani.pa...@intel.com> wrote: On 07/19/2017 03:29 PM, Emil Velikov wrote: On 19 July 2017 at 08:12, Tapani Päll

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

On 07/19/2017 03:29 PM, Emil Velikov wrote: On 19 July 2017 at 08:12, Tapani Pälli <tapani.pa...@intel.com> wrote: Depending on build order, LOCAL_PATH maybe set or not (and can't be trusted to have assumed path), change modifies all occurences of LOCAL_PATH as locally defined COMPILE

[Mesa-dev] [PATCH 1/2] android: fix libmesa_nir build

current build did not find required include 'spirv_info.h' Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/compiler/Android.nir.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/Android.nir.mk b/src/compiler/Android.nir.mk index f021b80..75a247a 100644 ---

[Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

Depending on build order, LOCAL_PATH maybe set or not (and can't be trusted to have assumed path), change modifies all occurences of LOCAL_PATH as locally defined COMPILER_PATH instead. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/compiler/Android.nir.gen.m

Re: [Mesa-dev] [PATCH] i965: don't call dup() twice when calling eglDupNativeFenceFDANDROID.

Oops sorry, forget about this one. This does not work ok :/ Need to take a closer look why. On 06/16/2017 10:21 AM, Tapani Pälli wrote: From: Randy Xu <randy...@intel.com> This was causing crashes in Vulkan and GLES stress testing. Currently, both libEGL and the DRI module call du

[Mesa-dev] [PATCH] i965: don't call dup() twice when calling eglDupNativeFenceFDANDROID.

From: Randy Xu This was causing crashes in Vulkan and GLES stress testing. Currently, both libEGL and the DRI module call dup when the function is called. Remove the former since it's ultimately a driver decision how to manage the file descriptor. v2: remove dup from the

Re: [Mesa-dev] [PATCH v1 0/7] Android etnaviv and imx support

) are Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 06/15/2017 11:47 PM, Robert Foss wrote: This series enables etnaviv and imx for the android platform. This is done through updating the Android build scripts. Additionally 4 small fixes are included in the series. Rob Herring (4): g

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

On 06/16/2017 09:28 AM, Tapani Pälli wrote: On 06/15/2017 11:47 PM, Robert Foss wrote: From: Rob Herring <r...@kernel.org> Add etnaviv to Android makefiles. Signed-off-by: Rob Herring <r...@kernel.org> --- Android.mk| 5 +-- src/galliu

Re: [Mesa-dev] [PATCH v1 7/7] android: build imx-drm winsys

On 06/15/2017 11:47 PM, Robert Foss wrote: From: Tomeu Vizoso Signed-off-by: Tomeu Vizoso --- Android.mk| 5 +++-- src/gallium/Android.mk| 1 + src/gallium/winsys/imx/drm/Android.mk |

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

On 06/15/2017 11:47 PM, Robert Foss wrote: From: Rob Herring Add etnaviv to Android makefiles. Signed-off-by: Rob Herring --- Android.mk| 5 +-- src/gallium/Android.mk| 1 +

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

On 06/15/2017 07:57 PM, Rob Clark wrote: On Thu, Jun 15, 2017 at 12:04 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: On 06/15/2017 06:52 PM, Rob Clark wrote: On Thu, Jun 15, 2017 at 9:59 AM, Eric Engestrom <eric.engest...@imgtec.com> wrote: On Thursday, 2017-06-15 13:27:06 +0

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

On 06/15/2017 06:52 PM, Rob Clark wrote: On Thu, Jun 15, 2017 at 9:59 AM, Eric Engestrom wrote: On Thursday, 2017-06-15 13:27:06 +, Marathe, Yogesh wrote: Hello, I'm tyring to run flatland native app on android. It apparantly fails because of a fence issue.

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

On 06/14/2017 01:12 AM, Eric Anholt wrote: Tapani Pälli <tapani.pa...@intel.com> writes: On 06/12/2017 09:52 AM, Tapani Pälli wrote: On 05/18/2017 09:39 PM, Eric Anholt wrote: Eric Anholt <e...@anholt.net> writes: This series came out of fixing dEQP failures on vc4's GLES2 c

Re: [Mesa-dev] [PATCH mesa 0/2] egl: wire up swap_with_damage() and enable it on Android

On 06/12/2017 04:30 PM, Eric Engestrom wrote: On Monday, 2017-06-12 09:39:15 +0300, Tapani Pälli wrote: Hi Eric; EGL_KHR_swap_buffers_with_damage is implemented by Android's EGL wrapper library so these tests are passing already, no implementation required in Mesa side. Right, I keep

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

On 06/12/2017 09:52 AM, Tapani Pälli wrote: On 05/18/2017 09:39 PM, Eric Anholt wrote: Eric Anholt <e...@anholt.net> writes: This series came out of fixing dEQP failures on vc4's GLES2 context. Mesa was allowing RGB565 textures, which is only valid with GL_OES_required_internal

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

On 05/18/2017 09:39 PM, Eric Anholt wrote: Eric Anholt writes: This series came out of fixing dEQP failures on vc4's GLES2 context. Mesa was allowing RGB565 textures, which is only valid with GL_OES_required_internalformat. Rather than disable RGB565, I decided the

Re: [Mesa-dev] [PATCH mesa 0/2] egl: wire up swap_with_damage() and enable it on Android

Hi Eric; EGL_KHR_swap_buffers_with_damage is implemented by Android's EGL wrapper library so these tests are passing already, no implementation required in Mesa side. Thanks; On 06/12/2017 01:09 AM, Eric Engestrom wrote: This is completely untested, as I don't have access to an Android

Re: [Mesa-dev] [PATCH] i965: Call intel_prepare_render() from intel_update_state()

This fixes also the crashes seen on Android; Tested-by: Tapani Pälli <tapani.pa...@intel.com> On 06/10/2017 12:11 AM, Kenneth Graunke wrote: The resolve code looks at the current color draw buffers. These are not valid until intel_prepare_render() is called. You can end up with one

Re: [Mesa-dev] [RFC 3/3] egl: remove EGL_NOK_swap_region

On 06/05/2017 03:21 PM, Emil Velikov wrote: On 5 June 2017 at 09:32, Tapani Pälli <tapani.pa...@intel.com> wrote: On 06/05/2017 02:52 AM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Analogous to previous commit - only one platform (of 6?

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On 06/08/2017 09:27 PM, Chad Versace wrote: On Thu 08 Jun 2017, Tomasz Figa wrote: On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: On 06/08/2017 09:36 AM, Tapani Pälli wrote: On 06/08/2017 06:05 AM, Tomasz Figa wrote: On Wed, Jun 7, 2017 at 5:36 AM

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

With the suggestions from Emil and Eric, this is: Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 06/07/2017 07:11 PM, Harish Krupo wrote: This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_upd

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

On 06/08/2017 04:53 PM, Emil Velikov wrote: Hi all, On 8 June 2017 at 13:06, Harish Krupo <harish.krupo@intel.com> wrote: Hi Tapani, On 06/08/2017 04:32 PM, Tapani Pälli wrote: Harish, please find small addition below. I noticed we still have one crasher in tests when this ext

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

On 06/08/2017 06:01 PM, Emil Velikov wrote: On 8 June 2017 at 11:10, Tapani Pälli <tapani.pa...@intel.com> wrote: Specification states that in case of error, value should not be written, patch changes buffer age queries to return -1 in case of error so that we can skip changing the

Re: [Mesa-dev] [PATCH 22/30] i965: Move images to the new resolve functions

FYI I bisected that starting from this commit (or maybe somewhere within this series) there are segfaults with systemui (using libhwui) in Android, it looks like below. Seems rather hard case to debug as it does not seem to always happen (!) but will try to figure out what is going wrong.

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

Harish, please find small addition below. I noticed we still have one crasher in tests when this extension is enabled, it's related to buffer age so I've sent a fix separately here: https://lists.freedesktop.org/archives/mesa-dev/2017-June/158391.html On 06/07/2017 07:11 PM, Harish Krupo

[Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

. Fixes: dEQP-EGL.functional.negative_partial_update.not_postable_surface Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/egl/drivers/dri2/platform_android.c | 4 ++-- src/egl/drivers/dri2/platform_drm.c | 2 +- src/egl/main/eglsurface.c | 6 +- 3 files chan

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

til: Unused source files: util/vk_util.h). Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util") Cc: Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> Cc: Alex Smith <asm...@feralinteractive.com <mai

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On 06/08/2017 09:36 AM, Tapani Pälli wrote: On 06/08/2017 06:05 AM, Tomasz Figa wrote: On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace <chadvers...@chromium.org> wrote: More patches to break your formats... again ;) The Android framework requires support for EGLC

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On 06/08/2017 06:05 AM, Tomasz Figa wrote: On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace wrote: More patches to break your formats... again ;) The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

argh, how did that get there ... Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 06/08/2017 05:00 AM, Rob Herring wrote: Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util") broke the Android build with the following error: build/core/binar

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On 06/06/2017 02:58 AM, Kenneth Graunke wrote: On Monday, June 5, 2017 2:03:45 AM PDT Tapani Pälli wrote: FWIW this change fixes also regression on Android wallpaper since that commit. I'm planning on dropping this patch, as it seems that commit 708664159e18487b6676fd5b4c33f52003f81d9e

Re: [Mesa-dev] [PATCH 1/3] util/vulkan: Move Vulkan utilities to src/vulkan/util

On 06/06/2017 02:13 PM, Alex Smith wrote: Aha, sorry, I missed that. Do you want me to fold your patch into this one and send a v2? That would be ideal as working build makes bisecting a lot less painful, thanks! Alex On 6 June 2017 at 12:11, Tapani Pälli <tapani.pa...@intel.

Re: [Mesa-dev] [PATCH 1/3] util/vulkan: Move Vulkan utilities to src/vulkan/util

Looks nice to me, I've sent required changes to Android build system for this change as addition. On 06/06/2017 12:42 PM, Alex Smith wrote: We have Vulkan utilities in both src/util and src/vulkan/util. The latter seems a more appropriate place for Vulkan-specific things, so move them there.

[Mesa-dev] [PATCH] android: build system changes for Vulkan utilities move

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- Android build system changes required for: https://lists.freedesktop.org/archives/mesa-dev/2017-June/158027.html Android.common.mk | 1 + src/intel/Android.vulkan.mk | 1 + src/vulkan/Android.mk | 2 ++ 3 files c

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

FWIW this change fixes also regression on Android wallpaper since that commit. On 06/04/2017 10:26 PM, Kenneth Graunke wrote: Since commit e9f5004d5ea38a21019e0affcd63d353b98d499a, KDE's Plasma Shell started crashing when intel_disable_rb_aux_buffer tried to dereference irb->mt, and there was

Re: [Mesa-dev] [RFC 3/3] egl: remove EGL_NOK_swap_region

On 06/05/2017 02:52 AM, Emil Velikov wrote: From: Emil Velikov Analogous to previous commit - only one platform (of 6?) implements this, and there's no implementations seen in the wild that use this. Hmm the extension isn't even available anywhere :-\ There is

Re: [Mesa-dev] [RFC 1/3] egl/dri2: enable EGL_NOK_texture_from_pixmap everywhere

Android does not support pixmaps, so this should be set to false there. I think otherwise this should be fine. On 06/05/2017 02:52 AM, Emil Velikov wrote: From: Emil Velikov There's nothing platform specific in the extension - all the required core parts are

Re: [Mesa-dev] [PATCH] Android: use bionic pthread_barrier_* if possible

that seems the case Acked-by: Tapani Pälli <tapani.pa...@intel.com> On 06/04/2017 07:53 AM, Chih-Wei Huang wrote: The pthread_barrier_* functions were introduced to bionic since Nougat. Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.common.mk

Re: [Mesa-dev] [PATCH 10/24] i965/cnl: Wire up android Mesa build files for gen10

looks correct and builds fine for Android-IA; Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/13/2017 02:38 AM, Anuj Phogat wrote: Note: This patch is untested. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/Android.genxml.mk | 5 +

Re: [Mesa-dev] [PATCH] egl/android: support for EGL_KHR_partial_update

Hi Harish; One thing left for the basic plumbing, sorry I did not mention this earlier. Please add a "_eglReturnFalse" fallback for eglSetDamageRegionKHR (see _eglInitDriverFallbacks). Also see one small but significant change below in 'ClampRects' .. On 06/01/2017 07:42 AM, Harish Krupo

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/30/2017 03:23 PM, Rob Herring wrote: sysmacros.h was getting implicitly included in types.h until recently in AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. Signed-off-by: Rob Herring <r...@k

Re: [Mesa-dev] [PATCH 2/9] i965/dri: Combine declaration and assignment in intelCreateBuffer

On 05/29/2017 09:55 AM, Martin Peres wrote: On 27/05/17 01:15, Chad Versace wrote: Trivial cleanup. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

Re: [Mesa-dev] [PATCH 0/9] i965: A few tiny trivial cleanups

LGTM Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/27/2017 01:15 AM, Chad Versace wrote: I was hacking on the i965/DRI glue, and on brw_surface_formats.c, and I found several little cleanups to make the code nicer. All these patches are super small. Chad Versace (9): i9

Re: [Mesa-dev] [PATCH 0/2] egl/android: A few trivial cleanups

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/27/2017 01:09 AM, Chad Versace wrote: Chad Versace (2): egl/android: Align channel masks in HAL_PIXEL_FORMAT table egl/android: Drop unused 'format' param in get_back_bo() src/egl/drivers/dri2/platform_android.

[Mesa-dev] [PATCH] android: add -Wl, --build-id=sha1 to LDFLAGS for libvulkan_intel

Just like is done on desktop and what is expected by the build-id code. Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- Jason, I commented before that this did not work but it seems I had other changes when testing that screwed up things, sorry for that, this works just fine!

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 05/19/2017 04:19 AM, Xu, Randy wrote: -Original Message- From: Rob Herring [mailto:r...@kernel.org] Sent: Friday, May 19, 2017 6:01 AM To: Emil Velikov Cc: Chih-Wei Huang ; ML mesa-dev ; Xu, Randy Subject: Re:

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: Partially revert 23c86c74, fix eglMakeCurrent

On 05/18/2017 12:16 AM, Tomasz Figa wrote: Hi, On Tue, May 16, 2017 at 11:35 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: On 05/16/2017 08:10 PM, Chad Versace wrote: On Tue 16 May 2017, Tapani Pälli wrote: On 05/16/2017 02:04 AM, Chad Versace wrote: Fixes regressions in A

[Mesa-dev] [PATCH] egl/android: fix segfault within swap_buffers

.so (eglSwapBuffers+55) #05 pc 000754dc /system/lib/libandroid_runtime.so Note, this is v1 as v2 caused dEQP regressions. Fixes: 2acc69d ("EGL/Android: Add EGL_EXT_buffer_age extension") Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/egl/drivers/dri2/platform_android.c | 4 +++-

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 05/18/2017 07:10 AM, Chih-Wei Huang wrote: 2017-05-18 12:01 GMT+08:00 Xu, Randy : -Original Message- From: Palli, Tapani It's just applied. Isn't it? Yesterday without this patch the color format is mismatch apparently. Yeah we do need this. TBH I don't quite

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 05/18/2017 06:41 AM, Chih-Wei Huang wrote: 2017-05-18 11:26 GMT+08:00 Xu, Randy : -Original Message- From: Chih-Wei Huang [mailto:cwhu...@android-x86.org] Sent: Thursday, May 18, 2017 11:04 AM To: Xu, Randy Cc: Emil Velikov

Re: [Mesa-dev] [PATCH] mesa: Allow MESA_FORMAT_LAYOUT_S3TC in non-desktop mesa

On 05/17/2017 12:05 PM, Tapani Pälli wrote: On 05/17/2017 11:49 AM, Gao, Chun wrote: Thanks for your comments. Are we working on GL_EXT_sRGB, or is there any plan for that? There has been work done to enable it: https://patchwork.freedesktop.org/patch/148975/ I believe Harish has been

Re: [Mesa-dev] [PATCH] mesa: Allow MESA_FORMAT_LAYOUT_S3TC in non-desktop mesa

On 05/17/2017 11:49 AM, Gao, Chun wrote: Thanks for your comments. Are we working on GL_EXT_sRGB, or is there any plan for that? There has been work done to enable it: https://patchwork.freedesktop.org/patch/148975/ I believe Harish has been fixing some of the faults, work is still

Re: [Mesa-dev] [PATCH] mesa: Allow MESA_FORMAT_LAYOUT_S3TC in non-desktop mesa

On 05/17/2017 11:09 AM, Gao, Chun wrote: I know EXT_texture_sRGB is desktop OpenGL extension. On Android-IA and ChromeOS ARC++, the game https://play.google.com/store/apps/details?id=com.eline.neveralonemobile could not display some texture correctly. I found the following formats which the

Re: [Mesa-dev] [PATCH] mesa: Allow MESA_FORMAT_LAYOUT_S3TC in non-desktop mesa

IMO this is not correct. Are you having problems with some application? For Android games Mesa should already return true for the previous check (ANGLE_texture_compression_dxt) and things should work OK. The check you are touching is desktop specific because EXT_texture_sRGB is available only

Re: [Mesa-dev] [PATCH] Android: correct libz dependency

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/17/2017 08:10 AM, Chih-Wei Huang wrote: Commit 6facb0c0 ("android: fix libz dynamic library dependencies") unconditionally adds libz as a dependency to all shared libraries. That is unnecessary. Commit 85a9b1b5

Re: [Mesa-dev] [PATCH] egl: Partially revert 23c86c74, fix eglMakeCurrent

On 05/16/2017 08:10 PM, Chad Versace wrote: On Tue 16 May 2017, Tapani Pälli wrote: On 05/16/2017 02:04 AM, Chad Versace wrote: Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices due to incorrect error handling in eglMakeCurrent. See below on how to confirm

Re: [Mesa-dev] [PATCH] egl: Partially revert 23c86c74, fix eglMakeCurrent

On 05/16/2017 02:04 AM, Chad Versace wrote: Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices due to incorrect error handling in eglMakeCurrent. See below on how to confirm the regression is fixed. This partially reverts commit

Re: [Mesa-dev] [PATCH 1/3] egl/android: use the image_driver alongside the image_loader

upport (which we really should integrate, need to visit why those got rejected and what would be solution there). Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> dri2_dpy->loader_extensions = droid_image_loader_extensions; + if (!dri2_load_driver_dri3(dpy)) { + err = &q

Re: [Mesa-dev] [PATCH 1/2] intel: gen-decoder: fix xml parser leak

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/12/2017 02:37 PM, Lionel Landwerlin wrote: In the unlikely case the parsing of genxml files fails, we were leaking an xml parser object. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/

Re: [Mesa-dev] [PATCH v2 2/2] i965: perf: fix pointer to integer cast

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 05/12/2017 06:49 PM, Lionel Landwerlin wrote: v2: Just use cast to uintptr_t (Chris) Reported-by: Mauro Rossi <issor.or...@gmail.com> Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/mes

Re: [Mesa-dev] [PATCH 10/13] egl/x11: make use of the dri2_display_destroy() helper

this patch causes a crash with egl-create-surface Piglit test On 05/11/2017 09:57 PM, Emil Velikov wrote: From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 78

Re: [Mesa-dev] [PATCH 06/13] egl/android: make use of dri2_display_destroy() helper

On 05/11/2017 09:57 PM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Cc: Tomasz Figa <tf...@chromium.org> Cc: Tapani Pälli <tapani.pa...@intel.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/drivers/dri2

[Mesa-dev] [PATCH v2] egl: fix android logger compilation

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- src/egl/main/egllog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/egl/main/egllog.c b/src/egl/main/egllog.c index 6de2a50..64ff474 100644 --- a/src/egl/main/egllog.c +++ b/src/egl/main/egllog.c

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

On 05/12/2017 09:19 AM, Chih-Wei Huang wrote: 2017-05-12 14:15 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: 2017-05-12 13:37 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: this patch is a partial revert of 1ce585

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 05/11/2017 04:00 PM, Lionel Landwerlin wrote: On 11/05/17 13:58, Lionel Landwerlin wrote: On 11/05/17 12:27, Tapani Pälli wrote: On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi <issor.or...@gmail.com> wrote: Fixes the following building error hap

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: 2017-05-12 13:37 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: this patch is a partial revert of 1ce5853 that break compilation since LOG_ERROR etc are not defined and also macro expansion won't work as planned (expands to 'ANDROID_eg

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

Yep, this fixes the issue, also other DXT tests what I have are passing fine. Acked-by: Tapani Pälli <tapani.pa...@intel.com> On 05/12/2017 02:46 AM, Nanley Chery wrote: The DXT1_RGB* format does not provide the correct behavior for OpenGL in the case where color_0 <= color_1. BC1_

[Mesa-dev] [PATCH] egl: fix android logger compilation

this patch is a partial revert of 1ce5853 that break compilation since LOG_ERROR etc are not defined and also macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]') Fixes: 1ce5853 ("egl: simplify the Android logger") Signed-off-by: Tapani Pälli <tapani.pa

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi wrote: Fixes the following building error happening on marshmallow-x86 with Ubuntu 16.04 LTS stock build essentials package and by the book Android build system.

Re: [Mesa-dev] [PATCH 4/9] mesa: fix misleading indentation

On 04/12/2017 01:04 AM, Thomas Hindoe Paaboel Andersen wrote: --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 187475f..9efb2e0 100644 --- a/src/mesa/main/shaderapi.c +++

Re: [Mesa-dev] Trivial code cleanups

Patches 3 & 7 Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 04/12/2017 01:03 AM, Thomas Hindoe Paaboel Andersen wrote: A mix of fixes for static analysis warnings, recent indentation mistakes, and unnecessary null checks b

Re: [Mesa-dev] [PATCH 5/9] i965: remove unused context

On 04/12/2017 01:04 AM, Thomas Hindoe Paaboel Andersen wrote: --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 -- src/mesa/drivers/dri/i965/intel_pixel_draw.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

On 05/05/2017 10:14 AM, Randy Xu wrote: Follow up "i965: Solve Android native fence fd double close" The _EGLSync.SyncFd is not neccesary to keep after pass to dri driver. Test: Run Vulkan and GLES stress test and no crash. Yep I've verified as well that no crashes happen. Lots of tearing

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

On 05/09/2017 12:29 PM, Tapani Pälli wrote: On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: Hi, first sorry, for missing the subject in my mail to the mailing list, then thanks for the hint with the "ext_image_dma_buf_import-sample_yuv". Unfortunately things don't beco

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

u. And I use "texture" instead of "texture2D" because I'm on OpenGL 3.3, but that does not seem to cause any differences. On 09.05.2017 06:37, Tapani Pälli wrote: Hi; Take a look at Piglit test "ext_image_dma_buf_import-sample_yuv", (https://cgit.freedesktop.org

Re: [Mesa-dev] (no subject)

Hi; Take a look at Piglit test "ext_image_dma_buf_import-sample_yuv", (https://cgit.freedesktop.org/piglit). Test creates EGLImage from dma buf, binds to a texture and then samples this in a shader with samplerExternalOES type from GL_OES_EGL_image_external extension. On 05/09/2017 01:57

<    4   5   6   7   8   9   10   11   12   13   >