/31/18 12:57 AM, Timothy Arceri wrote:
> >> On 30/10/18 10:14 pm, Tapani Pälli wrote:
> >>> Hi;
> >>>
> >>> On 10/30/18 1:28 AM, Timothy Arceri wrote:
> >>>> On 29/10/18 10:05 pm, Vadim Shovkoplias wrote:
> >>>>> Hi
Hi Jason,
Looks like there is an issue with the float comparison. It works perfectly
fine for me if it is compared with some precision:
if( (fabsf(*dstX1 - *dstX0) < 1e-8F) || (fabsf(*dstY1 - *dstY0) < 1e-8F) ) {
return true;
пн, 1 окт. 2018 г. в 19:24, Eric Engestrom :
> On Monday, 201
Hi Timothy,
Thanks for the review. Piglit patch is updated with the additional out var:
https://patchwork.freedesktop.org/patch/258899/
Original reporter confirmed that issue is finally fixed with the current
patch and closed it.
Can I ask to push the patch please ?
Regards,
Vadym
сб, 27 окт. 2
Hi Ian,
Thanks for the explanation. I've just sent a patch for review with the
compile time check https://patchwork.freedesktop.org/patch/255542/
Regards,
Vadym
пт, 5 окт. 2018 г. в 16:55, Ian Romanick :
> On 10/03/2018 11:52 PM, Iago Toral wrote:
> > On Wed, 2018-10-03 at 16:2
Sure, my fault.
чт, 4 окт. 2018 г. в 10:27, Tapani Pälli :
> Reviewed-by: Tapani Pälli
>
> In the future, please remember update patch version when making changes
> and posting patch again, easiest way is to give '-v2' to
> git-format-patch and then update commit message with information what
>
Thanks, I'll appreciate if you will push the patch once test will be
finished.
чт, 4 окт. 2018 г. в 9:52, Iago Toral :
> On Wed, 2018-10-03 at 16:24 +0300, Vadim Shovkoplias wrote:
>
> Hi Iago,
>
> I also think that compiler is the best place for the fix. But from my
> und
Hi Iago,
I also think that compiler is the best place for the fix. But from my
understanding compiler fix will be limited to distinct shader objects (not
the shader stage).
In GLSL spec mentioned: "A program will fail to compile or link if any *shader
or stage* contains two or more functions with
Hi Jason,
I'm still getting crash with this patch when run conformance test in the
firefox.
Assert is triggered during following call:
glBlitFramebuffer(srcX0 = -1, srcY0 = -1, srcX1 = 2147483646, srcY1 =
2147483646, dstX0 = 0, dstY0 = 0, dstX1 = 8, dstY1 = 8, mask =
GL_COLOR_BUFFER_BIT, filter =
Hi Timothy,
Thanks for the review! Space was removed. Can you please push this patch
since I haven't got write permissions ?
Regards,
Vadym
вт, 28 авг. 2018 г. в 10:32, Vadym Shovkoplias :
> From: "vadym.shovkoplias"
>
> During intra stage linking some out variables can be dropped because
> it
m are really against this patch. So unless
> someone else raise any concern, I'll ack and push the patch later today.
>
> Thanks for fixing this.
>
> Rafael
>
> On Thu, Jul 26, 2018 at 04:04:29PM +0300, Vadym Shovkoplias wrote:
> > ping
> >
> > On Tue, Jul
Vadim Shovkoplias :
> Hi Kenneth,
>
> Can you please look at this patch ?
>
> 2018-06-07 15:30 GMT+03:00 Den :
>
>> Hello. Found out that this patch also fixes 2 new issues:
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158
>>
>> Bug
Hi Kenneth,
Can you please look at this patch ?
2018-06-07 15:30 GMT+03:00 Den :
> Hello. Found out that this patch also fixes 2 new issues:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106667
>
> Tested-by: Denis
>
No worries :)
2018-01-24 11:36 GMT+02:00 Pohjolainen, Topi :
> On Tue, Jan 16, 2018 at 03:58:03PM +0200, Vadim Shovkoplias wrote:
> > Tested-by: Vadym Shovkoplias
>
> Just realized that I pushed without your Tested-by, I'm sorry about that!
>
> >
> > 2018-01-
Tested-by: Vadym Shovkoplias
2018-01-16 15:31 GMT+02:00 Topi Pohjolainen :
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546
> CC: xinghua@intel.com
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/brw_draw.c | 6 --
> 1 file changed, 4 insertions(+), 2
Tested-by: Vadym Shovkoplias
This patch also fixes similar issue with SHENZHEN I/O game (
https://bugs.freedesktop.org/show_bug.cgi?id=104392)
Tested on HP Zbook.
2018-01-11 11:53 GMT+02:00 Thomas Hellstrom :
> Upon reception of an event that lowered the number of active back buffers,
> the cod
Hi Eric,
I used smatch (http://smatch.sourceforge.net/). It is mainly used for Linux
kernel.
2017-12-04 18:52 GMT+02:00 Eric Engestrom :
> On Monday, 2017-12-04 12:48:55 +0200, Vadim Shovkoplias wrote:
> > Hi Eric,
>
> Hey, sorry, I forgot to hit "send" on th
Hi Eric,
Mostly by a static analysis tool. It found at least 7 issues with useless
free() calls and other problems that probably should be fixed.
Suggest please should I create one cumulative commit for this or it should
be a separate commits ?
2017-12-01 17:41 GMT+02:00 Eric Engestrom :
> On Fr
From: Vadym Shovkoplias
At this point dc_job->cache_item_metadata.keys always equals
NULL, so call to free() is useless
Fixes: b86ecea3446 ("util/disk_cache: write cache item metadata to disk")
Signed-off-by: Vadym Shovkoplias
---
src/util/disk_cache.c | 1 -
1 file changed, 1 deletion(-)
di
From: Vadym Shovkoplias
In this condition dri2_dpy->driver_name string always equals
NULL, so call to free() is useless
Signed-off-by: Vadym Shovkoplias
---
src/egl/drivers/dri2/platform_x11.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/dr
From: Vadym Shovkoplias
deviceName string is declared, assigned and freed but actually
never used in dri3_create_screen() function.
Fixes: 2d94601582e ("Add DRI3+Present loader")
Signed-off-by: Vadym Shovkoplias
---
src/glx/dri3_glx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
From: Vadym Shovkoplias
Fix incomplete check of input params in blorp_surf_convert_to_uncompressed()
which can lead to NULL pointer dereferencing.
---
src/intel/blorp/blorp_blit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/bl
From: Vadym Shovkoplias
Fix incomplete check of input params in blorp_surf_convert_to_uncompressed()
which can lead to NULL pointer dereferencing.
---
src/intel/blorp/blorp_blit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blo
22 matches
Mail list logo
