Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-11-06 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-10-19 at 06:55 -0700, Jason Ekstrand wrote: > On October 18, 2017 11:44:12 PM Samuel Iglesias Gonsálvez > wrote: > > > On Wednesday, October 18, 2017 8:11:01 AM CEST Jason Ekstrand > > wrote: > > > On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez > >

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-19 Thread Jason Ekstrand
On October 18, 2017 11:44:12 PM Samuel Iglesias Gonsálvez wrote: On Wednesday, October 18, 2017 8:11:01 AM CEST Jason Ekstrand wrote: On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez wrote: > v2: > - Use helper to add a new source to the

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-19 Thread Samuel Iglesias Gonsálvez
On Wednesday, October 18, 2017 8:11:01 AM CEST Jason Ekstrand wrote: > On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez > > wrote: > > v2: > > - Use helper to add a new source to the texture instruction. > > > > Signed-off-by: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Jason Ekstrand
On October 18, 2017 12:54:48 AM Samuel Iglesias Gonsálvez wrote: v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Lionel Landwerlin
Thanks again! Reviewed-by: Lionel Landwerlin On 18/10/17 08:54, Samuel Iglesias Gonsálvez wrote: v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez ---

[Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Samuel Iglesias Gonsálvez
v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir_lower_tex.c