Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-23 Thread Jason Ekstrand
On Tue, Oct 23, 2018 at 12:04 PM Christian Gmeiner < christian.gmei...@gmail.com> wrote: > Am Di., 23. Okt. 2018 um 18:31 Uhr schrieb Ian Romanick < > i...@freedesktop.org>: > > > > On 10/23/2018 08:33 AM, Connor Abbott wrote: > > > On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand > wrote: > > >>

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-23 Thread Christian Gmeiner
Am Di., 23. Okt. 2018 um 18:31 Uhr schrieb Ian Romanick : > > On 10/23/2018 08:33 AM, Connor Abbott wrote: > > On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand > > wrote: > >> > >> This should be useful for drivers that don't support real integers. > >> > >> Cc: Alyssa Rosenzweig > >> --- > >>

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-23 Thread Ian Romanick
On 10/23/2018 08:33 AM, Connor Abbott wrote: > On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote: >> >> This should be useful for drivers that don't support real integers. >> >> Cc: Alyssa Rosenzweig >> --- >> src/compiler/Makefile.sources | 1 + >>

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-23 Thread Connor Abbott
On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote: > > This should be useful for drivers that don't support real integers. > > Cc: Alyssa Rosenzweig > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/meson.build | 1 + >

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Christian Gmeiner
Am Di., 23. Okt. 2018 um 01:43 Uhr schrieb Jason Ekstrand : > > On Mon, Oct 22, 2018 at 6:20 PM Alyssa Rosenzweig > wrote: >> >> For what it's worth, Midgard has real integers (including int32 >> support), using hardware-level D3D10 boolean conventions. I'm trying to >> wrap my head around how

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Alyssa Rosenzweig
I think so? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Jason Ekstrand
On October 22, 2018 20:13:25 Alyssa Rosenzweig wrote: If you want to set me straight, that's probably the better patch to argue it out. :) No, I thought about it; you're right. I understand my hardware (and NIR) much better now than what I wrote the earlier patch; you have now shown me the

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Alyssa Rosenzweig
> If you want to set me straight, that's probably the better patch to > argue it out. :) No, I thought about it; you're right. I understand my hardware (and NIR) much better now than what I wrote the earlier patch; you have now shown me the error of my ways :) Nothing special should be needed

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Ian Romanick
On 10/22/2018 05:09 PM, Alyssa Rosenzweig wrote: >> Right. Sorry. I forgot who's working on what chip these days. Maybe Ilia >> can CC the right person. > > No worries at all! It may well have been me (I had touched the b2f code; > our hardware lacks a dedicated instruction and needs `iand

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Alyssa Rosenzweig
> Right. Sorry. I forgot who's working on what chip these days. Maybe Ilia > can CC the right person. No worries at all! It may well have been me (I had touched the b2f code; our hardware lacks a dedicated instruction and needs `iand 1.0` to do the conversion). I'm not sure which hardware

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Jason Ekstrand
On Mon, Oct 22, 2018 at 6:13 PM Ilia Mirkin wrote: > On Mon, Oct 22, 2018 at 6:16 PM Jason Ekstrand > wrote: > > > > This should be useful for drivers that don't support real integers. > > > > Cc: Alyssa Rosenzweig > > --- > > src/compiler/Makefile.sources | 1 + > >

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Jason Ekstrand
On Mon, Oct 22, 2018 at 6:20 PM Alyssa Rosenzweig wrote: > For what it's worth, Midgard has real integers (including int32 > support), using hardware-level D3D10 boolean conventions. I'm trying to > wrap my head around how this interacts with 5d85a0a. > Right. Sorry. I forgot who's working on

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Alyssa Rosenzweig
For what it's worth, Midgard has real integers (including int32 support), using hardware-level D3D10 boolean conventions. I'm trying to wrap my head around how this interacts with 5d85a0a. I'm tempted to think the standard lower_bool_to_int32 pass would work, with an emulated b2f instruction in

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Ilia Mirkin
On Mon, Oct 22, 2018 at 6:16 PM Jason Ekstrand wrote: > > This should be useful for drivers that don't support real integers. > > Cc: Alyssa Rosenzweig > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/meson.build | 1 + >

[Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Jason Ekstrand
This should be useful for drivers that don't support real integers. Cc: Alyssa Rosenzweig --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/nir_lower_bool_to_float.c | 181 + 3 files changed, 183