[Mesa-dev] [PATCH 06/30] mesa/main: clean up integer texture check

This makes the logic a little bit easier to follow, and reduce a bit of repetition. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 27 +++ 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 13/30] mesa/main: do not allow ARB_texture_rgb10_a2ui enums before gles3

ARB_texture_rgb10_a2ui isn't supported on OpenGL ES, we shouldn't expose it there even if the driver supports it. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 12 ++-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 07/30] mesa/main: use _mesa_has_FOO_bar for compressed format checks

_mesa_has_FOO_bar() knows about the APIs these extensions should be supported under, so let's use that to simplify these checks a bit. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 04/30] mesa/main: clean up OES_texture_float_linear check

for OpenGL ES 3.x right now. But if this was to change in the future, this makes the function behave a lot more predictable. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main

[Mesa-dev] [PATCH 01/30] mesa/main: make _mesa_has_tessellation return bool

All other _mesa_has_foo functions return bool rather than GLboolean, so let's follow that style here as well. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index

[Mesa-dev] [PATCH 08/30] mesa/main: do not allow s3tc enums on gles1

_mesa_has_EXT_texture_compression_s3tc() instead of checking the driver cap directly, otherwise we end up enabling this on OpenGL ES 1.x, as the API isn't checked. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 02/30] mesa/main: rename format-check function

the name. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 12 ++-- src/mesa/main/glformats.h | 6 +++--- src/mesa/main/teximage.c | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index

[Mesa-dev] [PATCH 00/30] do not allow invalid texture-format enums

ely oes_packed_depth_stencil-depth-stencil-texture_gles1. I don't think this is worth back-porting to old releases, as this only prevents broken code from incorrectly working, not the other way around. Erik Faye-Lund (30): mesa/main: make _mesa_has_tessellation return bool mesa/main: rename format-check funct

[Mesa-dev] [PATCH 03/30] mesa/main: clean up S3_s3tc check

S3_s3tc is the extension that enables this functionality on desktop, so let's check for that one. The _mesa_has_S3_s3tc() helper already verifies the API according to the extension-table. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 8 +++- 1 file changed, 3 insertions

[Mesa-dev] [PATCH 17/30] mesa/main: do not allow rg-textures enums before gles3

EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow these enums there, before OpenGL ES 3.0 which also introduce support for these enums. Since this check is repeated a lot, let's make a helper for this. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src

[Mesa-dev] [PATCH 11/30] mesa/main: do not allow depth-texture enums on gles1

res on OpenGL and OpenGL ES 2.0+. There's no extension enabling depth-textures for OpenGL ES 1.x, so we shouldn't allow those enums there. This fixes oes_packed_depth_stencil-depth-stencil-texture_gles1 on i965 Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 3 ++- 1 file changed

[Mesa-dev] [PATCH 12/30] mesa/main: do not allow stencil-texture enums on gles1

pth textures on OpenGL and OpenGL ES 2.0+. There's no extension enabling stencil-textures for OpenGL ES 1.x, so we shouldn't allow those enums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/m

[Mesa-dev] [PATCH 14/30] mesa/main: do not allow integer-texture enums before gles3

Integer textures shouldn't be implicitly exposed on OpenGL ES 1.x and 2.x, but because the code checked against a driver-capability rather than using an extension-check helper, we ended up accidentally allowing these enums on older versions when the driver supports it. Signed-off-by: Erik Faye

[Mesa-dev] [PATCH 28/30] mesa/st: do not probe for the same texture-formats twice

This should be equalent of what we did before. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_extensions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 16889074f66

[Mesa-dev] [PATCH 19/30] mesa/main: do not allow MESA_ycbcr_texture enums on gles

This extension requies OpenGL, and shouldn't be available on OpenGL ES. So let's not allow the enums from it either. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main

[Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 14 ++ src/mesa/main/glformats.c | 39 +-- 2 files changed, 43 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 071bd5b0818..bec9310db82

[Mesa-dev] [PATCH 24/30] mesa/main: do not allow EXT_texture_sRGB_R8 enums before gles3

ten the check. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 6c9d8b88d79..d79bcedffd9 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformat

[Mesa-dev] [PATCH 23/30] mesa/main: do not allow sRGB texture enums before gles3

eck. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 0a42d3dd9a0..6c9d8b88d79 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformats.c @@ -245

[Mesa-dev] [PATCH 22/30] mesa/main: do not allow snorm-texture enums before gles3

ten the check. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 453465fb1c8..0a42d3dd9a0 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformats.c @@ -241

[Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

There's nothing in the ARB_texture_float specification that limits filterability for floating-point textures, so we need to ensure that this is required to enable this extension. Luckily, we have just the right bits ready. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH 26/30] mesa/main: require EXT_texture_type_2_10_10_10_REV for gles3

OpenGL ES 3.0 require this functionality, so we should also test for it to avoid incorrectly exposing a too high GLES version. On desktop, this has been required since all the way back in OpenGL 1.2 anyway. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 29/30] mesa/main: do not require float-texture filtering for es3

The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as filterable, but not float textures. So we shouldn't depend on ARB_float_texture, which requires full filtering support for both. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 18/30] mesa/main: do not allow EXT_texture_shared_exponent enums before gles3

ted, let's introduce a helper. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index af81717d9bd..7db3b94e0b6 100644 --- a/src/m

[Mesa-dev] [PATCH 27/30] mesa/main: require EXT_texture_sRGB for gles3

sRGB textures is a requirement for OpenGL ES 3.0, so let's make sure we don't incorrectly enable a too high version. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index b3c68bb865c

[Mesa-dev] [PATCH 20/30] mesa/main: do not allow type_2_10_10_10_REV enums before gles3

ned-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 7 +++ src/mesa/main/glformats.c | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 7db3b94e0b6..071bd5b0818 100644 --- a/src/mesa/main/context.h +++ b/

[Mesa-dev] [PATCH 21/30] mesa/main: do not allow floating-point texture enums on gles1

ose enums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 2ac3110187f..453465fb1c8 100644 --- a/src/mesa/main/glformats.c +++ b/

[Mesa-dev] [PATCH 09/30] mesa/main: do not allow etc2 enums on gles1

off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 964235bb72f..2e2ef9a05bb 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformats.c @@ -1385,7 +138

[Mesa-dev] [PATCH 16/30] mesa/main: do not allow EXT_packed_float enums before gles3

EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow these enums there, before OpenGL ES 3.0 which also introduce support for these enums. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 6 +++--- 2 files changed, 9 insertions

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

on... > On Mon, Nov 19, 2018 at 7:16 AM Erik Faye-Lund > wrote: > > There's nothing in the ARB_texture_float specification that limits > > filterability for floating-point textures, so we need to ensure > > that > > this is required to enable this extension. Lucki

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

On Tue, 2018-11-27 at 07:11 +0100, Mathias Fröhlich wrote: > Hi Erik, > > > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote: > > > > I know this is *very* late notice, but this commit broke Super > > > > Tux > > > > Kart

Re: [Mesa-dev] Lets talk about autotools

On Tue, 2018-11-27 at 11:13 +0200, Timo Aaltonen wrote: > On 17.11.2018 6.04, Dylan Baker wrote: > > Quoting Dylan Baker (2018-09-17 09:44:07) > > > I feel like for !windows meson is in good enough shape at this > > > point that we > > > can start having the discussion about deleting the autotools

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

On Wed, 2018-11-28 at 15:20 +, Emil Velikov wrote: > On Wed, 28 Nov 2018 at 14:29, Eric Engestrom < > eric.engest...@intel.com> wrote: > > On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote: > > > On 2018-11-28 00:47:25, Erik Faye-Lund wrote: > > >

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

On Wed, 2018-11-28 at 01:18 -0800, Jordan Justen wrote: > On 2018-11-28 00:47:25, Erik Faye-Lund wrote: > > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote: > > > This adds the "Developer's Certificate of Origin 1.1" from the > > > Linux > > >

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

On Mon, 2018-11-19 at 11:37 -0500, Ilia Mirkin wrote: > On Mon, Nov 19, 2018 at 11:30 AM Erik Faye-Lund > wrote: > > On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote: > > > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund > > > wrote: > > > > On M

Re: [Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote: > Hi Eric, > > While checking this patch I noticed an extra semicolon in this > function: > +static inline bool > +_mesa_has_half_float_textures(const struct gl_context *ctx) > +{ > + return _mesa_has_ARB_texture_float(ctx) || > +

[Mesa-dev] [PATCH] mesa/main: fixup requirements for GL_PRIMITIVES_GENERATED

/main: fix validation of transform-feedback queries" Signed-off-by: Erik Faye-Lund --- Sorry about this! As I mentioned on the ticket, I don't have old enough intel HW to trigger this, but I think this should do the trick. src/mesa/main/queryobj.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [Mesa-dev] [PATCH 1/3] virgl: quadruple command buffer size

llny > For the series: Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > If glGetTexImage or glGetnTexImage is called with a level that > > doesn't > > exist, we get an error message on this form: > > > > M

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

On Mon, 2018-11-26 at 13:16 +0100, Juan A. Suarez Romero wrote: > On Mon, 2018-11-26 at 13:13 +0100, Erik Faye-Lund wrote: > > On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > > > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > > > If g

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

On Mon, 2018-05-07 at 08:14 +0200, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Finally make use of the binding information in the VAO when > setting up arrays for draw. > > v2: Emit less relocations also for interleaved userspace arrays. > > Signed-off-by: Mathias Fröhlich

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

*... On Mon, 2018-11-26 at 15:42 -0500, Marek Olšák wrote: > I have this issue on radeonsi as well, but the bad commit is: > > commit f1998e15ffccf260552bf559abe1a733a8ce990e > Author: Erik Faye-Lund > Date: Wed Nov 21 20:09:46 2018 +0100 > > mesa/main: remove ARB suffi

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

On Mon, 2018-11-26 at 21:33 +0100, Mathias Fröhlich wrote: > Hi, > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote: > > I know this is *very* late notice, but this commit broke Super Tux > > Kart > > on VirGL. Both the player-models as as well as

Re: [Mesa-dev] [PATCH] mesa/main: fixup requirements for GL_PRIMITIVES_GENERATED

Thanks. Pushed :) On Mon, 2018-11-26 at 12:58 -0800, Mark Janes wrote: > Tested-by: Mark Janes > > Erik Faye-Lund writes: > > > This enum is also allowed by EXT_tessellation_shader, which is > > supported > > on older i965 HW (as opposed to OES_geometry_shader)

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

(sorry, forgot to answer one of the questions) On Mon, 2018-11-26 at 21:33 +0100, Mathias Fröhlich wrote: > Hi, > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote: > > I know this is *very* late notice, but this commit broke Super Tux > > Kart > > on Vi

Re: [Mesa-dev] [PATCH] nir: fix copy-paste error in nir_lower_constant_initializers

Reviewed-by: Erik Faye-Lund On Thu, 2019-01-10 at 11:23 +, Rhys Perry wrote: > Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1 > ('nir: Rework nir_lower_constant_initializers() to handle > functions') > --- > src/compiler/nir/nir_lower_constant_initializers.c | 4 ++-- &g

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

7f68d81e1 "glsl: apply align layout qualifier rules to block offsets" With that added: Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

On Fri, 2019-01-04 at 09:40 -0600, Jason Ekstrand wrote: > On Fri, Jan 4, 2019 at 4:07 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote: > > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund < >

Re: [Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

On Wed, 2018-10-17 at 14:58 +0300, Danylo Piliaiev wrote: > This series implement VK_KHR_draw_indirect_count and > VK_EXT_conditional_rendering extensions. > They are implemented together because they are highly interweaved. > > There are already tests in VK_CTS for VK_KHR_draw_indirect_count and

Re: [Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

no idea when will be merged. I don't think this will > prevent merging my patches but still I would be more confident if CI > have ALL tests. > > And yes, I also was quite slow with my patches. > > On 1/8/19 11:13 AM, Erik Faye-Lund wrote: > > On Wed, 2018-10-17 at 14:

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote: > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote: > > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin >

[Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

If we update the program-state etc, we risk compiling needless shaders, which can cost quite a bit of performance. Signed-off-by: Erik Faye-Lund --- This was motivated by seeing an unexpected shader-compile with nonsensical state on start-up in glxgears. src/mesa/main/clear.c | 34

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

, 2018 at 12:05 PM Erik Faye-Lund wrote: If we update the program-state etc, we risk compiling needless shaders, which can cost quite a bit of performance. Signed-off-by: Erik Faye-Lund --- This was motivated by seeing an unexpected shader-compile with nonsensical state on start-up

Re: [Mesa-dev] [PATCH] virgl: Set bind when creating temp resource.

On Mon, 2019-04-01 at 12:43 -0700, Lepton Wu wrote: > > > On Tue, Mar 19, 2019 at 4:29 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > On Mon, 2019-03-18 at 14:44 -0700, Lepton Wu wrote: > > > virgl render complains about "Ill

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > This fixes the following LLVM error when using RADV_DEBUG=checkir: > Intrinsic name not mangled correctly for type arguments! Should be: > llvm.amdgcn.buffer.atomic.add.i32 > i32 (i32, <4 x i32>, i32, i32, i1)*

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

On Mon, 2019-04-08 at 12:39 +0200, Samuel Pitoiset wrote: > On 4/8/19 12:32 PM, Erik Faye-Lund wrote: > > On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > > > This fixes the following LLVM error when using > > > RADV_DEBUG=checkir: > > > Intrinsic

Re: [Mesa-dev] [PATCH] docs: mention "Allow commits from members who can merge..."

Yeah, good move! Reivewed-by: Erik Faye-Lund On Mon, 2019-02-25 at 11:57 +, Emil Velikov wrote: > From: Emil Velikov > > Mention the tick-box otherwise only the MR author can rebase the > series. > > Cc: Jordan Justen > Cc: Dylan Baker > Cc: Erik Faye-Lu

[Mesa-dev] virglrenderer on gles, format conversion

When we try to do a vrend transfer from a renderable texture, we end up using glReadPixels to read the data. However, OpenGL ES has restrictions on what formats are allowed to be used for glReadPixels. In partcular, only GL_UNSIGNED_BYTE + GL_RGBA are guaranteed to be supported (for OpenGL ES 2.0;

Re: [Mesa-dev] [virglrenderer-devel] virglrenderer on gles, format conversion

On Wed, 2019-03-06 at 13:39 +1000, Dave Airlie wrote: > On Wed, 6 Mar 2019 at 01:01, Erik Faye-Lund > wrote: > > When we try to do a vrend transfer from a renderable texture, we > > end up > > using glReadPixels to read the data. However, OpenGL ES has > > restrictio

Re: [Mesa-dev] [PATCH] virgl: Set bind when creating temp resource.

On Mon, 2019-03-18 at 14:44 -0700, Lepton Wu wrote: > virgl render complains about "Illegal resource" when running > dEQP-EGL.functional.color_clears.single_context.gles2.rgb888_window, > the reason is that a zero bind value was given for temp resource. > > Signed-off-by: Lepton Wu > --- >

Re: [Mesa-dev] [PATCH 2/3] st/mesa: enable GL_EXT_float_blend when possible

Reviewed-by: Erik Faye-Lund And just for the record, I think this is the right "compromise" between checking all possible formats and facilitating fallbacks. On Tue, 2019-02-12 at 22:40 -0500, Ilia Mirkin wrote: > If the driver supports PIPE_BIND_BLENABLE on RGBA32F, flip >

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

On Wed, 2019-02-13 at 11:53 -0800, Ian Romanick wrote: > On 2/13/19 9:59 AM, Juan A. Suarez Romero wrote: > > On Wed, 2019-02-13 at 09:16 -0800, Ian Romanick wrote: > > > On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: > > > > On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: > > > > > On

Re: [Mesa-dev] Thoughts on fp64 for GLES?

On Thu, 2019-02-14 at 08:53 +1000, Dave Airlie wrote: > On Thu, 14 Feb 2019 at 06:04, Stéphane Marchesin > wrote: > > On Wed, Feb 13, 2019 at 11:09 AM Elie Tournier < > > tournier.e...@gmail.com> wrote: > > > > > > > > > On Wednesday, 13 February 2019, Stéphane Marchesin < > > >

Re: [Mesa-dev] Thoughts on fp64 for GLES?

On Thu, 2019-02-14 at 16:25 +0100, Gert Wollny wrote: > > > > On Wed, Feb 13, 2019 at 11:09 AM Elie Tournier < > > > > tournier.e...@gmail.com> wrote: > [...] > > > > > A solution would be to inline the > > > > > function in GLSL but I'm scared than the following shader > > > > > will > > > > >

Re: [Mesa-dev] [PATCH] nir: Optimize double-precision lower_round_even()

On Tue, 2019-01-29 at 14:41 +, Roland Scheidegger wrote: > Am 29.01.19 um 10:10 schrieb Erik Faye-Lund: > > On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote: > > > Use the trick of adding and then subtracting 2**52 (52 is the > > > number > > > of &

Re: [Mesa-dev] [PATCH] nir: Optimize double-precision lower_round_even()

On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote: > Use the trick of adding and then subtracting 2**52 (52 is the number > of > explicit mantissa bits a double-precision floating-point value has) > to > implement round-to-even. > > Cuts the number of instructions on SKL of the piglit test >

Re: [Mesa-dev] [PATCH] mesa: GLES2 fix for OES float/half-float textures.

On Mon, 2019-01-28 at 09:22 -0800, Eric Anholt wrote: > Erik Faye-Lund writes: > > > On Fri, 2019-01-25 at 13:41 -0800, Eric Anholt wrote: > > > Nick Kreeger writes: > > > > > > > The OES_texture* extensions for float and half-float are val

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

On Wed, 2019-01-23 at 14:47 +, Eric Engestrom wrote: > On Thursday, 2019-01-17 15:55:44 +0100, Erik Faye-Lund wrote: > > It could have been made obvious for instance by showing the commit- > > graph next to the commit-list, decorating it with the branch head > > in

Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement

On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote: > ping > Probably worth including Keith, who added this line... But yeah, I tend to think that this makes sense. The autotools-build doesn't seem to tie this to a specific version, and seems to have been used without problems for almost a

Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement

systems, one of them used to > be my main system. Not being able to use meson on those systems > without this patch is a big deal for me. This sounds like you have indeed tested on xcb-randr < 1.12, so I suppose the answer to the question is "yes"? If so, I think it's all go

Re: [Mesa-dev] [PATCH 2/2] panfrost: Include glue for out-of-tree legacy code

On Tue, 2019-02-05 at 06:26 +, Alyssa Rosenzweig wrote: > In addition to the DRM interface in active development, for legacy > kernels Panfrost has a small, optional, out-of-tree glue repository. > For > various reasons, this legacy code should not be included in Mesa > proper, > but this

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

On Mon, 2019-01-28 at 17:20 -0500, Rob Clark wrote: > On Mon, Jan 28, 2019 at 2:29 PM Ilia Mirkin > wrote: > > 2. I've seen a bunch of things land where I would have had comments > > beforehand. Once the patch is in, I don't really have an easy way > > to > > provide feedback. In the past if such

Re: [Mesa-dev] [PATCH] mesa: GLES2 fix for OES float/half-float textures.

On Fri, 2019-01-25 at 13:41 -0800, Eric Anholt wrote: > Nick Kreeger writes: > > > The OES_texture* extensions for float and half-float are valid when > > GLES2 is present w/ the matching > > OES_texture_float/OES_texture_half_float extensions. This fix > > ensures > > that these formats are

Re: [Mesa-dev] [PATCH v2] virgl: Set bind when creating temp resource.

Nice move to put the logic in its own function! Reviewed-by: Erik Faye-Lund On Mon, 2019-04-08 at 09:39 -0700, Lepton Wu wrote: > virgl render complains about "Illegal resource" when running > dEQP-EGL.functional.color_clears.single_context.gles2.rgb888_window, > the reason

Re: [Mesa-dev] Move adriconf to mesa repositories

Yeah, moving this to the mesa group in gitlab would be great for visibility. On Sat, 2019-04-13 at 12:22 +, Jean Hertel wrote: > Any other mesa developer interested in seeing this move forward? > > Kind Regards, > Jean Hertel > > ___ > mesa-dev

Re: [Mesa-dev] [PATCH] list: add some iterator debug

On Mon, 2019-05-27 at 13:37 +0200, Erik Faye-Lund wrote: > On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote: > > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund > > wrote: > > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > > > > This ends up embedded

Re: [Mesa-dev] [PATCH] list: add some iterator debug

On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote: > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund > wrote: > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > > > This ends up embedded in a for loop expression, ie. the C part in > > > an > > > fo

Re: [Mesa-dev] [PATCH] list: add some iterator debug

On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > This ends up embedded in a for loop expression, ie. the C part in an > for (A;B;C) > > iirc, that means it needs to be a C expr rather than statement.. or > something roughly like that, I'm too lazy to dig out my C grammar > Can't you just

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

On Wed, 2019-06-12 at 14:03 -0400, Adam Jackson wrote: > On Wed, 2019-06-12 at 10:29 +0200, Erik Faye-Lund wrote: > > On Wed, 2019-06-12 at 10:25 +0200, Erik Faye-Lund wrote: > > > On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > > > > On Tue, 2019-06-11

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

On Wed, 2019-06-12 at 10:25 +0200, Erik Faye-Lund wrote: > On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > > On Tue, 2019-06-11 at 11:13 +0200, Erik Faye-Lund wrote: > > > > > So here's the question: How does people feel about hosting this

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > On Tue, 2019-06-11 at 11:13 +0200, Erik Faye-Lund wrote: > > > So here's the question: How does people feel about hosting this > > under > > https://gitlab.freedesktop.org/mesa/ogl-sample/? If people are OK > &

[Mesa-dev] mirroring ogl-sample source code in gitlab?

While looking into dead-links on our website, I noticed that the OpenGL Sample Implementation that SGI open sourced lacks a proper public mirror. So I'm looking to fix this. The tarballs are currently available from here:

[Mesa-dev] Proposal for the future of www.mesa3d.org

A while back, Laura and Jean was working on a Sphinx-conversion of the mesa-documentation. Sadly this work stranded due to it also trying to move to using GitLab Pages for hosting www.mesa3d.org, and because the documentation and the websit eis the same thing, this lead to problems with hosting

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

- processing. We can cross that bridge when we get there. Perhaps by then the world looks a bit differently? On Tue, 2019-05-21 at 15:51 +0200, Erik Faye-Lund wrote: > Right. I guess with an old enough bison version, this can happen. > I'll see if I can come up with something better. > &g

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

On Wed, 2019-05-22 at 15:21 +0200, Hans Åberg wrote: > > On 22 May 2019, at 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> wrote: > > > > The problem is that Bison doesn't seem to have any mechanism for > > doing > > statements lik

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

On Wed, 2019-05-22 at 20:41 +0200, Akim Demaille wrote: > > Le 22 mai 2019 à 18:06, Akim Demaille a écrit > > : > > > > Hi Erik, > > > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > > erik.faye-l...@collabora.com> a écrit : > >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: > Hi Erik, > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> a écrit : > > > > I ended up reverting the change [from-%error-verbose to %define > > parse.error

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

, GitLab Mirror wrote: > Module: Mesa > Branch: master > Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a > URL:    https://nam04.safelinks.protection.outlook.com/?url="" > > Author: Erik Faye-Lund > Date:   Mon May 20 13:29:05 2019 +0200 > > glsl

Re: [Mesa-dev] boolean usage in gallium

On Sat, 2019-06-29 at 00:08 -0400, Ilia Mirkin wrote: > Ken pointed out on IRC today that there was still a lot of "boolean" > (vs bool/_Bool) usage in gallium. In fact, many interfaces are > specified with boolean. > > I had it in my mind that I had at some point removed most boolean > usage,

Re: [Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

On Wed, 2019-06-26 at 10:34 -0700, Alyssa Rosenzweig wrote: > Ah-ha, now we're into parts of the stack I can claim to understand! > >:) > > Reviewed-by: Alyssa Rosenzweig > > On Tue, Jun 25, 2019 at 06:37:48PM +0200, Boris Brezillon wrote: > > From: Daniel Stone > > > > Add a

Re: [Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

On Wed, 2019-07-03 at 12:33 +0200, Boris Brezillon wrote: > On Wed, 03 Jul 2019 11:54:29 +0200 > Erik Faye-Lund wrote: > > > On Wed, 2019-06-26 at 10:34 -0700, Alyssa Rosenzweig wrote: > > > Ah-ha, now we're into parts of the stack I can c

Re: [Mesa-dev] [PATCH] panfrost: Rewrite u-interleaving code

On Tue, 2019-06-25 at 12:36 -0700, Vasily Khoruzhick wrote: > On Tue, Jun 25, 2019 at 11:54 AM Alyssa Rosenzweig > wrote: > > Hi Alyssa, > > > Rather than using a magic lookup table with no explanations, let's > > add > > liberal comments to the code to explain what this tiling scheme is > >

Re: [Mesa-dev] [PATCH v4 0/5] EGL_KHR_partial_update support

On Tue, 2019-06-25 at 18:37 +0200, Boris Brezillon wrote: > This is an attempt at resurrecting Daniel's MR [1] which was already > resurrecting Harish's EGL_KHR_partial_update series [2]. This version > implements Marek's suggestion to pass the set_damage_region() > directly > to the gallium

[Mesa-dev] [PATCH 0/5] gallium: kill PIPE_CAP_SM3

to enable PIPE_CAP_VERTEX_SHADER_SATURATE without enabling the rest. But for now, I leave that up to follow-up patches. I'm intentionally sending just the cover-letter here. You can see the merge request on gitlab here: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1266 Erik Faye-Lund (5): mesa/st: dro

Re: [Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

On Thu, 2019-07-04 at 10:02 +0200, Tomeu Vizoso wrote: > In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. > > Signed-off-by: Tomeu Vizoso > Cc: Boris Brezillon > Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT > ioctls") Nit: this isn't really about off-screen vs

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > > Signed-off-by: Alyssa Rosenzweig > --- > .../drivers/panfrost/ci/expected-failures.txt | 6 -- > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/compiler.h | 6

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > Maybe you could share which test this fixes, so someone can fix it? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] panfrost: Track BO lifetime with jobs and reference counts

On Tue, 2019-04-16 at 01:49 +, Alyssa Rosenzweig wrote: > This (fairly large) patch continues work surrounding the panfrost_job > abstraction to improve job lifetime management. In particular, we add > infrastructure to track which BOs are used by a particular job > (currently limited to the

Re: [Mesa-dev] [PATCH] virgl: Set meta data for textures from handle.

; > + virgl_resource_layout(>u.b, >metadata); > > res->hw_res = vs->vws->resource_create_from_handle(vs->vws, > whandle); > if (!res->hw_res) { Whoops! Good catch, sorry for the mess! Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: Mention if swrast is being forced

On Mon, 2019-11-11 at 10:44 +0200, Martin Peres wrote: > On 31/10/2019 09:35, Chris Wilson wrote: > > The system can be disabling HW acceleration unbeknowst to the user, > > leading to a long debug session trying to work out which component > > is > > failing. A quick mention that it is the

Re: [Mesa-dev] [PATCH] spirv: s/{}/{0}/ initializer to fix MSVC build

There's already this one: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2695 On Mon, 2019-11-11 at 16:46 -0700, Brian Paul wrote: > Trivial. > --- > src/compiler/spirv/vtn_variables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

<    2   3   4   5   6   7   8   >