I've looked into the issue, and found a workaround by looking at what
st_renderbuffer_alloc_storage (which is called to create the depth
buffer with ST_SURFACE_DEPTH != BUFFER_DEPTH) does.
Adding:
if(ctx) ctx-NewState |= _NEW_BUFFERS;
at the end of st_set_framebuffer_surface seems to solve the
Luca Barbieri wrote:
I've looked into the issue, and found a workaround by looking at what
st_renderbuffer_alloc_storage (which is called to create the depth
buffer with ST_SURFACE_DEPTH != BUFFER_DEPTH) does.
Adding:
if(ctx) ctx-NewState |= _NEW_BUFFERS;
at the end of
Brian Paul wrote:
Luca Barbieri wrote:
I've looked into the issue, and found a workaround by looking at what
st_renderbuffer_alloc_storage (which is called to create the depth
buffer with ST_SURFACE_DEPTH != BUFFER_DEPTH) does.
Adding:
if(ctx) ctx-NewState |= _NEW_BUFFERS;
at the end of
Solves the Warsow issue and seems to work.
Thanks!
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel
Luca Barbieri wrote:
Solves the Warsow issue and seems to work.
OK, I think you can commit the patch to 7.8 then.
-Brian
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed
On Thu, 2010-03-11 at 11:28 -0700, Brian Paul wrote:
Luca Barbieri wrote:
Solves the Warsow issue and seems to work.
OK, I think you can commit the patch to 7.8 then.
Can this also be backported to mesa_7_7_branch?
--
Earthling Michel Dänzer |
Michel Dänzer wrote:
On Thu, 2010-03-11 at 11:28 -0700, Brian Paul wrote:
Luca Barbieri wrote:
Solves the Warsow issue and seems to work.
OK, I think you can commit the patch to 7.8 then.
Can this also be backported to mesa_7_7_branch?
Sure, if you can test it. We might want to wait a
Shouldn't
_mesa_add_renderbuffer(stfb-Base, BUFFER_FRONT_LEFT, rb);
be
_mesa_add_renderbuffer(stfb-Base, surfIndex, rb);
instead, since you seem to make the on-demand creation mechanism
generic and no longer limited to the front buffer?
Luca Barbieri wrote:
Shouldn't
_mesa_add_renderbuffer(stfb-Base, BUFFER_FRONT_LEFT, rb);
be
_mesa_add_renderbuffer(stfb-Base, surfIndex, rb);
instead, since you seem to make the on-demand creation mechanism
generic and no longer limited to the front buffer?
Yes. Fixed now.
-Brian
On Thu, Mar 11, 2010 at 4:41 PM, Luca Barbieri l...@luca-barbieri.comwrote:
I've looked into the issue, and found a workaround by looking at what
st_renderbuffer_alloc_storage (which is called to create the depth
buffer with ST_SURFACE_DEPTH != BUFFER_DEPTH) does.
Adding:
if(ctx)
In mesa_7_7_branch, 52d83efdbc4735d721e6fc9b44f29bdd432d4d73 reverts
commit 9d17ad2891b58de9e33e943ff918a678c6a3c2bd.
How about cherry-picking that commit into master, until a fix for the
bugs the revert commit introduces are found?
The reverted commit currently breaks the Warsow main menu for
I second that. The commit breaks 6 glean tests (api2, clipFlat, fragProg1,
occluQry, pointAtten, texCombine4) with r300g.
-Marek
On Wed, Mar 10, 2010 at 10:50 PM, Luca Barbieri l...@luca-barbieri.comwrote:
In mesa_7_7_branch, 52d83efdbc4735d721e6fc9b44f29bdd432d4d73 reverts
commit
Mesa/master is correct as is. Changing ST_SURFACE_DEPTH to be !=
BUFFER_DEPTH is just hiding another problem elsewhere.
If ST_SURFACE_DEPTH==8 then calling st_set_framebuffer_surface(fb,
ST_SURFACE_DEPTH, surf) is effectively setting the fb's COLOR0
attachment to be a Z/stencil buffer (and
13 matches
Mail list logo
