Re: [PATCH] fix POSIX 'command -pv'

2016-03-12 Thread Thorsten Glaser
Martijn Dekker dixit: >> I don’t think so, what do you make of true=ENOENT > >The existence of 'true' as an external command somewhere in the default >system $PATH (whatever that is) is mandated by POSIX, as it is for all Sure, but half the targets of mksh don’t do POSIX or even predate it. And t

Re: [PATCH] fix POSIX 'command -pv'

2016-03-10 Thread Martijn Dekker
Op 05-03-16 om 18:23 schreef Thorsten Glaser: > Martijn Dekker dixit: > >> Ah yes, I didn't think of the hardcoded /usr/bin/true path, oops. >> >> That's nothing that can't be fixed with a simple regex. > >> Finally, an external command was still missing from the test and it >> seems like a good

Re: [PATCH] fix POSIX 'command -pv'

2016-03-05 Thread Thorsten Glaser
Martijn Dekker dixit: >Ah yes, I didn't think of the hardcoded /usr/bin/true path, oops. > >That's nothing that can't be fixed with a simple regex. >Finally, an external command was still missing from the test and it >seems like a good idea to add one. I don’t think so, what do you make of true=

Re: [PATCH] fix POSIX 'command -pv'

2016-03-05 Thread Martijn Dekker
Thorsten Glaser schreef op 05-03-16 om 16:27: > I think I’ll mark your second test as MirBSD-only after moving true > from /usr/bin to /bin where we have it, this way the logic gets full > coverage but we only run the portable test elsewhere. Ah yes, I didn't think of the hardcoded /usr/bin/true p

Re: [PATCH] fix POSIX 'command -pv'

2016-03-05 Thread Thorsten Glaser
Martijn Dekker dixit: >Thorsten Glaser schreef op 26-02-16 om 21:57: >> In the end, I decided I don’t like the code and rewrote it entirely, >> separating options processing, simplifying, etc. but thanks anyway! > >Yes, that code looks much cleaner. No more opaque mixing of two >different command'

Re: [PATCH] fix POSIX 'command -pv'

2016-03-04 Thread Martijn Dekker
Thorsten Glaser schreef op 26-02-16 om 21:57: > In the end, I decided I don’t like the code and rewrote it entirely, > separating options processing, simplifying, etc. but thanks anyway! Yes, that code looks much cleaner. No more opaque mixing of two different command's option logic. I also misse

Re: [PATCH] fix POSIX 'command -pv'

2016-02-26 Thread Thorsten Glaser
Martijn Dekker dixit: >I found another minor POSIX bug in mksh 'command': the options -p and -v >don't combine correctly. Thanks. Sorry it took me some time to have a look at this, but I like to… put off dealing with standards… ☺ In the end, I decided I don’t like the code and rewrote it entirel

[PATCH] fix POSIX 'command -pv'

2016-02-14 Thread Martijn Dekker
I found another minor POSIX bug in mksh 'command': the options -p and -v don't combine correctly. The -p flag means that 'command' will search the system default PATH instead of the current PATH, but does not change that builtins take precedence over external commands. Hence 'command -p test' will