Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Fixed Block comments

2022-07-22 Thread Dan Carpenter
= zoran_enum_output, > - .vidioc_g_output= zoran_g_output, > - .vidioc_s_output= zoran_s_output,*/ > + * .vidioc_g_output= zoran_g_output, > + * .vidioc_s_output= zoran_s_outp

Re: [Mjpeg-users] [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros

2022-05-06 Thread Dan Carpenter
ubmitted v3. > > What did you use to see these issues? When I ran the checkpatch script > and compiled, I did not see any of this. > I have written a blog entry about checking kernel code with Smatch: https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/ regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH 3/4] staging: media: zoran: replace all pr_err() with zrdev_err()

2022-04-26 Thread Dan Carpenter
://download.01.org/0day-ci/archive/20220426/202204260911.ppsncmg4-...@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/staging/media/zoran

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Dan Carpenter
at how it's used. pr_debug() might be an option, but I don't know if we will accept that, we prefer dev_dbg(). regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Dan Carpenter
specified level of debugging */ > +#define dprintk(debug, num, format, args...) \ > +do { \ > + if (debug > num) \ > + printk(format, ##args); \ > +} while (0) > + I don't like the new format. It needs to have a KERN_DEBUG at the start. Passing the param_

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

2021-11-02 Thread Dan Carpenter
On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote: > Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit : > > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrote: > > > +config VIDEO_ZORAN_DEBUG > > > + bool "Enable zoran debugfs

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

2021-10-14 Thread Dan Carpenter
->map_mode = ZORAN_MAP_MODE_RAW; > > +#ifdef CONFIG_VIDEO_ZORAN_DEBUG > + zr->dbgfs_dir = debugfs_create_dir(ZR_DEVNAME(zr), NULL); > + debugfs_create_file("debug", 0444, > + zr->dbgfs_dir, zr, > +

Re: [Mjpeg-users] [PATCH v2 06/10] staging: media: zoran: fusion all modules

2021-10-14 Thread Dan Carpenter
video_codec); if (result < 0) { pci_err(pdev, "failed to load codec %s: %d\n", codec_name, result); zr->card.video_codec = 0; } regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH v2 06/10] staging: media: zoran: fusion all modules

2021-10-14 Thread Dan Carpenter
ails, the probe function still does zoran_setup_videocodec() on the failed codec. These would be better in a .h file. #ifdef CONFIG_VIDEO_ZORAN_ZR36060 int zr36060_init_module(void); #else int zr36060_init_module(void) { return -EINVAL; } #endif regards, dan carpenter _

Re: [Mjpeg-users] [PATCH -next] media: zoran: use resource_size

2021-01-07 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 09:19:58PM +0100, LABBE Corentin wrote: > Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit : > > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > > > Use resource_size rather than a verbose computation on > > &g

Re: [Mjpeg-users] [PATCH -next] media: zoran: use resource_size

2021-01-06 Thread Dan Carpenter
se of the + 1 on part of the "end - start + 1"... It's sometimes hard to know if we should add the + 1 which resource_size() does or not. (That check is ancient and not up to modern standards). regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH] staging: media: zoran: fix trailing whitespaces

2019-04-08 Thread Dan Carpenter
nsecutive blank lines so really we should just delete the lines entirely... But this driver is scheduled for deletion in May. Let's not bother with cleaning it up. regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

[Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define

2014-06-10 Thread Dan Carpenter
The ZR050_MO_COMP define is cut and pasted twice so we can delete the second instance. Signed-off-by: Dan Carpenter diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h index 9f52f0c..ea083ad 100644 --- a/drivers/media/pci/zoran/zr36050.h +++ b/drivers/media/pci

[Mjpeg-users] [patch] [media] zoran: bit-wise vs logical and

2010-12-11 Thread Dan Carpenter
zr->frame_num is a counter and && was intended here instead of &. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/zoran/zoran_device.c b/drivers/media/video/zoran/zoran_device.c index b02007e..e8a2784 100644 --- a/drivers/media/video/zoran/zoran_device.c +++ b/driv

[Mjpeg-users] potential null deref in mpeg_open()

2009-07-21 Thread Dan Carpenter
17.c 59 #define dprintk(level, fmt, arg...)\ 60 do { if (v4l_debug >= level) \ 61 printk(KERN_DEBUG "%s: " fmt, dev->name , ## arg);\ 62 } while (0) regards, dan carpenter ---

Re: [Mjpeg-users] Chroma spatial shift?

2009-06-28 Thread Dan Scholnik
y4mshift (use -h for documentation). You don't need to upsample to 444, but it will give you finer control over the chroma shifts. Since the luma alone can be moved by individual pixels (using -y and -Y) you still have fine control over the differential shift with subsampled formats. Da

Re: [Mjpeg-users] y4mstabilizer segmentation fault

2009-06-04 Thread Dan Scholnik
stabilizer that seemed related to how big the correction shift was (how far the image wandered in the frame). I think only very large shifts caused problems (my video was handheld while running.) I lost interest before I could track the bug down, but I always assumed that it was inadve

Re: [Mjpeg-users] DV analyzer tool / optimizing video rendering?

2006-11-29 Thread Dan Maas
ause desktop software like Quicktime Player DOES play the MOV audio track, ignoring the embedded audio. But if you try to record the file to DV tape, it only transmits the embedded DV stream). Regards, Dan - Take Surveys. Ea

Re: [Mjpeg-users] DV analyzer tool / optimizing video rendering?

2006-11-29 Thread Dan Maas
ia FireWire, like Final Cut Pro, rely on the embedded DV stream to be 100% correct. When playing to a FireWire device, Final Cut does not re-build the DV headers or re-insert the audio - it just plays whatever is embedded in the MOV file. Regards, Dan --

Re: [Mjpeg-users] DV analyzer tool / optimizing video rendering?

2006-11-24 Thread Dan Maas
ng bewteen "field mode" and "progressive mode" DCTs. - ffmpeg's DV-in-MOV encoding is broken. It does not insert the DV audio and header data into the embedded DV stream, as required by Quicktime. Regards, Dan -

Re: [Mjpeg-users] Extracting a storyboard?

2006-08-21 Thread Dan A. Dickey
On Monday 21 August 2006 09:33, Dan A. Dickey wrote: > On Sunday 20 August 2006 01:38, Bernhard Praschinger wrote: > > Hallo > > > > > I'm new to this list and to mjpeg. > > > I was wondering if there is an easy to to feed an mpeg2 > > > video int

Re: [Mjpeg-users] Extracting a storyboard?

2006-08-21 Thread Dan A. Dickey
t be messed up. If I get around to making either of these changes to mpeg2decode, I'll certainly let you all know. If someone else does it first, I'd like to hear about it... Or, if someone has some other suggestion, I'd *really* like to hear that. :) Bernhard - thank you fo

[Mjpeg-users] Extracting a storyboard?

2006-08-18 Thread Dan A. Dickey
100 thousandth frame, does it do this by seeking to that frame instead of reading up to and tossing the first 9 frames? Thanks for any help. -Dan -- Dan A. Dickey [EMAIL PROTECTED] SAVVIS Transforming Information Technology --

[Mjpeg-users] y4mstabilizer bugs

2006-07-11 Thread Dan Scholnik
, but I thought I'd throw it out there in case someone more familiar with the code wanted to take a crack at it. I can provide example video sequences. Dan - Using Tomcat but need to do more? Need to support web serv

[Mjpeg-users] mplex want to split output

2006-04-13 Thread Dan Johansson
/tmp/audio.ac3" And here is a list of /var/tmp/: -rw-r--r-- 1 dan users 252637184 Apr 13 10:27 audio.ac3 -rw-r--r-- 1 dan users 4252723675 Apr 13 10:45 video.m2v -rw-r--r-- 1 dan users 3091064832 Apr 13 10:53 video.mpg As I understand it there should be no need to split the output,

Re: [Mjpeg-users] Horizontal / vertical chromashift correction?

2006-04-12 Thread Dan Scholnik
On Tue, 2006-04-11 at 01:26 +0200, Nicolas wrote: > Do you know of any tool I could use in an mjpeg pipe to correct > horizontal ("color Bleed") and/or vertical ("color Droop") chromashifts? Use y4mshift with the -y/-Y options to shift luma and

Re: [Mjpeg-users] pnmtoy4m / progressive

2005-03-08 Thread Dan Scholnik
he preferred scaler (y4mscaler) already has very flexible antialiasing built in. Indeed, if y4mscaler were to allow the filter bandwidth to be independent of the scaling ratio then y4mspatialfilter would be rendered obsolete. Dan --- SF em

Re: [Mjpeg-users] yuvkineco - kudos and requests

2005-02-20 Thread Dan Scholnik
me videotapes left to convert, so I'd be interested. But I barely have time to lurk on this list, much less code... Dan --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from

[Mjpeg-users] Re: [Kino-dev] single ppm from firewire

2004-11-10 Thread dan
> Hi > Something that might be of interest for both lists : > > Is there any possibility to grab one single ppm frame with appropriate > file naming (pict_000n.ppm etc ...) form a firewire port ? > see ffmeg. not tried it, but I know it supports ppm, you can specify the filename, it has support fo

Re: [Mjpeg-users] Offtopic: archival safe CD/DVD labelling

2004-09-03 Thread Dan Scholnik
operly center them, was lots of standalone DVD player video glitches and lockups. Cured every time by reburning sans label. Dan Scholnik --- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get

Re: [Mjpeg-users] blockiness/splotches in dim scenes (revisited)

2004-05-26 Thread Dan Scholnik
On Wed, 2004-05-26 at 12:18, Steven M. Schultz wrote: > On Wed, 26 May 2004, Dan Scholnik wrote: > > > Doesn't the ' in Y' indicate that the digital data has been > > gamma-corrected to compensate for the nonlinear CRT response? In that > > I'd

Re: [Mjpeg-users] blockiness/splotches in dim scenes (revisited)

2004-05-26 Thread Dan Scholnik
ing noise usually dominates and dark frame subtraction would only make things worse. At best you could subtract out the mean if "black" has a constant bias. Besides, since dark noise doesn't change quickly over time it wouldn't lead to noisy backgrounds, just nonuniform

Re: [Mjpeg-users] y4mdenoise - some numbers

2004-05-22 Thread Dan Scholnik
On Sat, 2004-05-22 at 01:56, Steven M. Schultz wrote: > On Sat, 22 May 2004, Dan Scholnik wrote: > > > > > You might even try running y4mspatialfilter before and after y4mdenoise > > > > in case the latter introduces any high-frequency artifacts. > > >

Re: [Mjpeg-users] y4mdenoise - some numbers

2004-05-21 Thread Dan Scholnik
On Sat, 2004-05-22 at 00:50, Steven M. Schultz wrote: > On Mon, 10 May 2004, Dan Scholnik wrote: > > > You might even try running y4mspatialfilter before and after y4mdenoise > > in case the latter introduces any high-frequency artifacts. > > Ok - this I have done.

Re: [Mjpeg-users] y4mdenoise - some numbers

2004-05-09 Thread Dan Scholnik
set of values is "-l 1 -t 4","-l 2 -t 6", and "-l 3 -t 8" for light, medium, and heavy filtering. Dan Scholnik --- This SF.Net email is sponsored by Sleepycat Software Learn developer strategies Cisco, Motorola, E

Re: [Mjpeg-users] Novice needs help with bright washout

2004-04-25 Thread Dan Scholnik
er has this feature), try this: yuvcorrect -Y Y_1.0_16_255_0_239 which just shifts the whole image down by 16 luminance values. Dan Scholnik --- This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek For a limited time only, ge

Re: [Mjpeg-users] Samples of our new denoiser!

2004-04-24 Thread Dan Scholnik
ifference when I lean in and concentrate, but the noise in those clips is lower than a lot of my VHS captures and low-light video from consumer digital camcorders. Any noisier examples? I'm trying to find the (visually) best settings for material where the original noise is distractingl

Re: [Mjpeg-users] Interlacing a progressive stream?

2004-03-30 Thread Dan Scholnik
om frame n followed by 1,3,5 from frame n+1. That's how they will be displayed on your TV. Any other choice would introduce a mismatch in either time or space, albeit small. I would be curious if you can tell the difference though. Dan Scholnik ---

[Mjpeg-users] tricking a dvd player to play svcd

2004-02-25 Thread Dan Adams
it. Anyone know of a way i can do this? Thanks. - Dan --- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=

[Mjpeg-users] Re: [Dvdauthor-users] ANNOUNCEMENT: DVD Video Presentation

2003-09-25 Thread Dan Dennedy
Oh yeah, you asked for an updated patch to insert VOBUs into ivtv DVD streams without remuxing... that would be neat to show, eh? On Wed, 2003-09-24 at 10:53, James A. Pattie wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > Just to let you know, I'll be giving a present