[mkgmap-dev] Commit: r3197: code cleanup to reduce number of problems reported by FindBugs and eclipse,

2014-04-18 Thread svn commit
Version mkgmap-r3197 was committed by gerd on Fri, 18 Apr 2014 code cleanup to reduce number of problems reported by FindBugs and eclipse, no change in output expected ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/m

[mkgmap-dev] Commit: r3198: prepare refactoring of access evaluation:

2014-04-18 Thread svn commit
Version mkgmap-r3198 was committed by gerd on Fri, 18 Apr 2014 prepare refactoring of access evaluation: move RoadNetwork from package uk.me.parabola.mkgmap.general to uk.me.parabola.imgfmt.app.net Note that you may have to adapt your logging.properties file! ___

Re: [mkgmap-dev] Commit: r3198: prepare refactoring of access evaluation:

2014-04-18 Thread Gerd Petermann
Hi all, Steve agreed that the class RoadNetwork belongs to routing, so it should be in package uk.me.parabola.imgfmt.app.net. If your logging.properties file contains e.g. uk.me.parabola.mkgmap.general.RoadNetwork.level=INFO I suggest to add a line uk.me.parabola.imgfmt.app.net.RoadNetwork.leve

Re: [mkgmap-dev] Commit: r3187: make-cycleways-v1.patch:

2014-04-18 Thread Minko
Gerd, With the option --make-cycleways enabled, the streetname label gets name = name (cycleway) The cycleway part of this street gets the name = name. Why is this not the other way around? Is it possible to remove (cycleway) from the name label, it seems hardcoded? I have tried to delete name mk

Re: [mkgmap-dev] Commit: r3187: make-cycleways-v1.patch:

2014-04-18 Thread Minko
I wrote > The cycleway part of this street gets the name = name. > Why is this not the other way around? Sorry I was confused, I see now there are two lines on top of each other (in my style I see 3, because I also render the oneway arrows) 0x06 name 0x06 name (cycleway) I only want to remove (

Re: [mkgmap-dev] Commit: r3187: make-cycleways-v1.patch:

2014-04-18 Thread Gerd Petermann
Hi Minko, > With the option --make-cycleways enabled, the streetname label gets name = > name (cycleway) > The cycleway part of this street gets the name = name. > Why is this not the other way around? Sorry, I can't reproduce that. The way with bicycle=no is added first and without (cycleway)

[mkgmap-dev] [PATCH v2] Rework of inc/access

2014-04-18 Thread WanMil
Hi Steph, obviously it was too late yesterday... I forgot to remove two debugging statements. Attached you find a fixed version. WanMil Hi, Error in style: Error: (inc/access:31): Unrecognised command 'bus' Found one style in ../styles/default/ line 31: psv=*{ add taxi='${

Re: [mkgmap-dev] [PATCH v1] Rework of inc/access

2014-04-18 Thread WanMil
Hi Gerd, Hi WanMil, besides the error reported by Stéphane here are my 50 cents after a first compare with the unpatched default style: I am not sure, but I think tags like vehicle=private, motor_vehicle=private etc. should not set mkgmap:emergency=no My interpretation regarding routing is th

Re: [mkgmap-dev] Commit: r3187: make-cycleways-v1.patch:

2014-04-18 Thread Minko
Thanks Gerd, as first line it works now. > I can reproduce that. It works with this as first line in lines (with > bicycle, not mkgmap:bicycle) > > mkgmap:synthesised=yes & bicycle=yes { set > mkgmap:highest-resolution-only = true; delete name } > > Gerd __

Re: [mkgmap-dev] [PATCH v1] Rework of inc/access

2014-04-18 Thread Gerd Petermann
Hi WanMil, did not try it, but my understanding is that it should select the detour because the target is not on the road 1 - 2. Gerd > Date: Fri, 18 Apr 2014 11:20:02 +0200 > From: wmgc...@web.de > To: mkgmap-dev@lists.mkgmap.org.uk > Subject: Re: [mkgmap-dev] [PATCH v1] Rework of inc/access >

Re: [mkgmap-dev] [PATCH v1] Rework of inc/access

2014-04-18 Thread Gerd Petermann
Hi WanMil, okay, if you don't want to add two ways, please make sure that access=private also sets mkgmap:truck=no Gerd > Date: Fri, 18 Apr 2014 11:20:02 +0200 > From: wmgc...@web.de > To: mkgmap-dev@lists.mkgmap.org.uk > Subject: Re: [mkgmap-dev] [PATCH v1] Rework of inc/access > > Hi Gerd, >

[mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread WanMil
Hi Gerd, yep thanks! There was a c&p error for hgv. Attached is the fixed patch v3. WanMil Hi WanMil, okay, if you don't want to add two ways, please make sure that access=private also sets mkgmap:truck=no Gerd > Date: Fri, 18 Apr 2014 11:20:02 +0200 > From: wmgc...@web.de > To: mkgmap-d

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread Minko
Wanmil, how about country specific access rules? For instance only in the NLD's (and a lot more countries) add foot=yes on cycleways? http://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access-Restrictions#The_Netherlands Of course I understand that this only works if the complete boundary

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread WanMil
Hi Minko, we can create a second include file access_country with country specific rules. This file could be included from the access file. Once it is possible to use conditional includes it might be useful to easily enable/disable country specific rules. Do you want to post a first version o

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread Minko
Sure, I can think of a country specific file for the Netherlands. Where do you put such include rule? FYI, related to this question, in the NL OSM forum (and also on the German forum) we are discussing a new access tag that must guide bicycles (or pedestrians) to adjacent ways: http://wiki.openst

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread Minko
Wanmil, here are two examples of country specific rules. Maybe put them in one inc/access_country file so anyone can add their speific country rules to this file? # The Netherlands highway=trunk & mkgmap:country=NLD { add bicycle=no; add foot=no } highway=cycleway & mkgmap:country=NLD {

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread Colin Smale
Another couple of examples of country defaults for NLD: cycleway: add mofa=yes; add moped=no motorway/link: add bicycle=no; add mofa=no; add moped=no; add foot=no; add agricultural=no; add maxspeed=130; Would it be more manageable to have a directory structure containing a small file per c

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread WanMil
Hi Colin, Another couple of examples of country defaults for NLD: cycleway: add mofa=yes; add moped=no mofa and moped are not supported with the default style so it makes no sense to add those rules. motorway/link: add bicycle=no; add mofa=no; add moped=no; add foot=no; add agricultural

[mkgmap-dev] [PATCH v4] Rework of inc/access

2014-04-18 Thread WanMil
Thanks Minko, attached you find a complete patch with all changes and included country specific access rules. WanMil Wanmil, here are two examples of country specific rules. Maybe put them in one inc/access_country file so anyone can add their speific country rules to this file? # The Net

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread Colin Smale
It would make it easier for someone (a moped rider?) who wanted to make a special-purpose map for routing on his moped. The point I would like to make, is that once you have a central place for "country specific rules" (some may say "country defaults" but that may be a dangerous term to use in t

Re: [mkgmap-dev] [PATCH v3] Rework of inc/access

2014-04-18 Thread WanMil
Hi Colin, I understand your argument that handling all other access tags (like mofa and moped) makes it easier for special purpose maps. But that means a drawback for performance: 1. mkgmap loads only those tags from the input files that are referenced from the style files 2. Additional rules

[mkgmap-dev] Commit: r3199: Revert r3198

2014-04-18 Thread svn commit
Version mkgmap-r3199 was committed by steve on Fri, 18 Apr 2014 Revert r3198 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] Commit: r3200: Reapply 3198 as svn move

2014-04-18 Thread svn commit
Version mkgmap-r3200 was committed by steve on Fri, 18 Apr 2014 Reapply 3198 as svn move prepare refactoring of access evaluation: move RoadNetwork from package uk.me.parabola.mkgmap.general to uk.me.parabola.imgfmt.app.net Note that you may have to adapt your logging.properties file! --- Als