Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Vladimir Ivanov
Looks good. Best regards, Vladimir Ivanov On 9/12/14, 7:03 PM, Igor Ignatyev wrote: Vladimir/Alan, Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and removed whitebox from the changes. updated webrev : http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/ Thanks Igo

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Igor Ignatyev
Vladimir/Alan, Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and removed whitebox from the changes. updated webrev : http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/ Thanks Igor On 09/12/2014 05:41 PM, Vladimir Ivanov wrote: Alan, I wasn't aware about such

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Vladimir Ivanov
Alan, I wasn't aware about such capability. Sounds interesting. Since we are short on time integrating tests for JEP210 into 9 and 8u40, I'd suggest to remove dependency on WB API from the tests for now and file a followup bug to restore it once a suitable solution is found. As I understand,

Re: [9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

2014-09-12 Thread Paul Sandoz
Hi, On Sep 12, 2014, at 12:45 PM, Igor Ignatyev wrote: > Paul, > > thanks for your review. I'll take care about this change, since Konstantin is > on vacation. > Thanks. > updated webrev: > http://cr.openjdk.java.net/~iignatyev/kshefov/8057719/webrev.00/ > > please see inline answers. >

Re: [9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

2014-09-12 Thread Igor Ignatyev
Paul, thanks for your review. I'll take care about this change, since Konstantin is on vacation. updated webrev: http://cr.openjdk.java.net/~iignatyev/kshefov/8057719/webrev.00/ please see inline answers. Igor On 09/11/2014 05:12 PM, Paul Sandoz wrote: On Sep 5, 2014, at 7:52 PM, Konsta