Re: [mmh] folder_read with scandir()

[2020-03-21 23:01] markus schnalke > [2020-03-21 17:48] Philipp Takacs > > [2020-03-21 10:28] markus schnalke > > > > > > Some comments: > > > > > > [2020-03-19 12:45] Philipp Takacs > > > > > > > > Also noticed the other flag, not shoure if we need this realy. It's > > > > only used in folder

Re: [mmh] Previous-Sequence

Hi [2020-03-21 09:54] markus schnalke > [2019-12-15 17:55] Philipp Takacs > > > > During that I found the Previous-Sequence again. I don't see a reason > > why we need this feature. The usecases, I see, for the feature are better > > handled with mark or the backlog of your shell. But I don't

Re: [mmh] show sequences racecondition

Hoi. [2020-03-21 16:15] Philipp Takacs > [2020-03-21 09:32] markus schnalke > > [2020-03-19 12:14] Philipp Takacs > > > [2019-12-15 17:55] Philipp Takacs > > > > > > > > I have looked at the problem with open pager for show and change the > > > > sequences during the pager is open. This

Re: [mmh] folder_add and msgstats

Hoi. [2020-03-21 18:43] Philipp Takacs > [2020-03-21 10:05] markus schnalke > > [2020-03-19 12:33] Philipp Takacs > > > I have also removed the > > > clear_msg_flags loop from folder_read and folder_realloc. In most cases > > > we use calloc, so this isn't necesarry. At one place in

Re: [mmh] folder_read with scandir()

Hoi. [2020-03-21 17:48] Philipp Takacs > [2020-03-21 10:28] markus schnalke > > > > Some comments: > > > > [2020-03-19 12:45] Philipp Takacs > > > > > > Also noticed the other flag, not shoure if we need this realy. It's > > > only used in folder and I don't see the point of knowing that there

Re: [mmh] folder_add and msgstats

Hi [2020-03-21 10:05] markus schnalke > [2020-03-19 12:33] Philipp Takacs > > I have also removed the > > clear_msg_flags loop from folder_read and folder_realloc. In most cases > > we use calloc, so this isn't necesarry. At one place in folder_realloc > > realloc is used. There I have add a

Re: [mmh] folder_read with scandir()

[2020-03-21 10:28] markus schnalke > [2020-03-19 12:45] Philipp Takacs > > > > I have also looked at folder_read and found it't a bit ugly ;-) > > A good indicator for starting to rework. :-) > > > I have rewritten it with scandir. This saves about 40 loc and improves > > the reading flow for

Re: [mmh] show sequences racecondition

Hi [2020-03-21 09:32] markus schnalke > [2020-03-19 12:14] Philipp Takacs > > [2019-12-15 17:55] Philipp Takacs > > > > > > I have looked at the problem with open pager for show and change the > > > sequences during the pager is open. This happen often, if you show a > > > message and recieve

Re: [mmh] folder_read with scandir()

Hoi. [2020-03-19 12:45] Philipp Takacs > > I have also looked at folder_read and found it't a bit ugly ;-) A good indicator for starting to rework. :-) > I have rewritten it with scandir. This saves about 40 loc and improves > the reading flow for this funktion. Sounds good! Some comments:

Re: [mmh] folder_add and msgstats

Hoi. [2020-03-19 12:33] Philipp Takacs > > I have also removed the > clear_msg_flags loop from folder_read and folder_realloc. In most cases > we use calloc, so this isn't necesarry. At one place in folder_realloc > realloc is used. There I have add a memset. > > comment? Why were (in the

Re: [mmh] Previous-Sequence

Hoi. [2019-12-15 17:55] Philipp Takacs > > During that I found the Previous-Sequence again. I don't see a reason > why we need this feature. The usecases, I see, for the feature are better > handled with mark or the backlog of your shell. But I don't use this > feature. Just for reference, the

Re: [mmh] show sequences racecondition

Hoi, good to see you being active again, Philipp. I try to put my share in as well, at least comment on your messages. So, let's start here: [2020-03-19 12:14] Philipp Takacs > [2019-12-15 17:55] Philipp Takacs > > > > I have looked at the problem with open pager for show and change the > >