[WikimediaMobile] [offtopic] interesting read on Android app architecture

2016-02-26 Thread Brian Gerstle
And general architecture: http://devblog.songkick.com/2016/02/25/ingredients-for-a-healthy-android-codebase/ Post links to a presentation as well. Their approach is following some best practices I also strongly agree with, and they're using frameworks I would probably look to use (Dagger & RxJava

Re: [WikimediaMobile] [Analytics-internal] Pageview API used in iOS app beta

2016-02-23 Thread Brian Gerstle
uot; we obtain via "action=query" might not be > cached as long. > But these are not fetched from pageview API, are they? > > On Tue, Feb 23, 2016 at 7:05 AM, Brian Gerstle > wrote: > >> Ok, also worth noting is that the pageview response expiration is >> differen

Re: [WikimediaMobile] [Analytics-internal] Pageview API used in iOS app beta

2016-02-23 Thread Brian Gerstle
cache for all > requests to 24 hours, so if you do start respecting the headers keep that > in mind. > > On Mon, Feb 22, 2016 at 6:43 PM, Brian Gerstle > wrote: > >> IF traffic is widespread through the day and app is doing 1 request per >>> day. If traffic concent

Re: [WikimediaMobile] [Analytics-internal] Pageview API used in iOS app beta

2016-02-22 Thread Brian Gerstle
> > IF traffic is widespread through the day and app is doing 1 request per > day. If traffic concentrates in some hours request ratio might be higher > It largely boils down to "it depends" on: - Number of "Top read sections" that are in the user's feed on that device - Which sections t

[WikimediaMobile] Wikipedia iOS app git history rewrite

2015-12-28 Thread Brian Gerstle
Hey all, Just a quick heads up that we've rewritten the Wikipedia iOS app git history to amend some mistakes with author information. If you have a local copy of the repo, please re-checkout the new master. Merging or rebasing are not recommended, as a

Re: [WikimediaMobile] Older iOS test devices available

2015-10-22 Thread Brian Gerstle
Did you already update them to iOS 9? If not, it will be *very* valuable to have iOS 8 devices on hand. On Thu, Oct 22, 2015 at 2:26 PM, Brion Vibber wrote: > Hey all -- I've got a few older ios devices that I no longer test with > much, and am looking to clear them out of my inventory. If nobod

Re: [WikimediaMobile] [reading-wmf] Browse Hypothesis Results

2015-10-13 Thread Brian Gerstle
Great experiment! A couple questions/comments: 1. The % clickthrough per category shows SF Landmarks at 120%. Is that correct, and if so, what does it mean? 2. As a big believer in the power of categories as a driver for engagement, I would love to see more variations of this experime

Re: [WikimediaMobile] Some interesting stuff from Google

2015-10-09 Thread Brian Gerstle
Can we start a proposal to make all mobile websites look like 8-bit video games? That should be pretty performant ;-) Humor aside, just want to +1 this discussion, has been very insightful for me both in terms of making me aware of this proposal by Google and breaking it down pretty thoroughly. T

Re: [WikimediaMobile] Breaking apart MobileFrontend's front and back ends

2015-09-02 Thread Brian Gerstle
A valiant effort, Sam! Would love to hear more about your personal experience tackling a legacy component w/ a TDD approach when all is said and done. On Wed, Sep 2, 2015 at 6:45 AM, Bahodir Mansurov wrote: > Looks interesting! > > On Tue, 2015-09-01 at 14:52 +0100, Sam Smith wrote: > > Hey all

Re: [WikimediaMobile] What people think about Wikidata descriptions in search on mobile web beta, and a question about "arbitrary access" of Wikidata data

2015-08-18 Thread Brian Gerstle
Could there be a way to have our nicely curated description cake and eat it too? For example, interpolating data into the description and/or marking data points which are referenced in the description (so as to mark it as outdated when they change)? I appreciate the potential benefits of generated

Re: [WikimediaMobile] Thank You

2015-08-11 Thread Brian Gerstle
Thanks Philip! Always great to hear from the community, especially such kind words as yours. Let us know what you think we can do to make the apps even better! Cheers, Brian Gerstle (iOS Engineer) On Tue, Aug 11, 2015 at 11:14 AM, Philip Nelson wrote: > I just want to say thank you to

[WikimediaMobile] Wikipedia iOS 4.1.7 released!

2015-08-03 Thread Brian Gerstle
Hey everyone, The iOS team has released an update to the iOS app, which is now version 4.1.7. This update is a relatively minor one, mostly crash fixes and localization updates. As always, we'd love to hear what you think—especially if you think something's broken! Regards, WMF iOS team -- E

[WikimediaMobile] Wikipedia iOS 4.1.7 beta

2015-07-30 Thread Brian Gerstle
Hi everyone! We're gearing up release another minor update the app. You can download it by opening the TestFlight app on your device and downloading the *Wikipedia Beta 4.1.7 (171)*. You'll see "What To Test" notes in TestFlight, but I've also copied them below for convenience. Please reply to

Re: [WikimediaMobile] Parameters for RESTBase endpoints + caching/performance

2015-07-28 Thread Brian Gerstle
e were, say, a cross-platform epic about it next quarter? Just a thought... On Tue, Jul 28, 2015 at 7:25 PM, Gergo Tisza wrote: > On Tue, Jul 28, 2015 at 3:57 PM, Brian Gerstle > wrote: >> >> I guess the "thumb/6/6e" part isn't standard either. >>

Re: [WikimediaMobile] Parameters for RESTBase endpoints + caching/performance

2015-07-28 Thread Brian Gerstle
> > (e.g. for a JPEG the URL could look like > upload.wikimedia.org/wikipedia/commons/thumb/6/6e/Cernfounders.jpg/qlow-1024px-Cernfounders.jpg > ). > Darn, really? Well, there goes my idea of hacking client-side URL generation... I guess the "thumb/6/6e" part isn't standard either. If we could j

Re: [WikimediaMobile] Parameters for RESTBase endpoints + caching/performance

2015-07-28 Thread Brian Gerstle
Some comments inline: TL;DR; proper dynamic image URLs would solve this problem nicely. I'm still curious to see if constructing image URLs on the client side would get the job done until our servers are able to fall back gracefully. The logic would be: - API requests return image filenames in

Re: [WikimediaMobile] Wikipedia iOS app moving to GH

2015-07-28 Thread Brian Gerstle
). Mostly just as "redundant storage," not sure if we'll support any code review here for the time being (mostly due to iOS team unfamiliarity) Hope to see a pull request (or patch) from you soon! Brian On Fri, Jul 24, 2015 at 10:25 AM, Brian Gerstle wrote: > FYI, s

Re: [WikimediaMobile] Wikipedia iOS app moving to GH

2015-07-24 Thread Brian Gerstle
FYI, spent some time this morning "refactoring" the epic <https://phabricator.wikimedia.org/T98970>, scope has been reduced to CI (moving CD into its own epic <https://phabricator.wikimedia.org/T102547>) and clarified/elaborated many other sections. On Thu, Jul 23, 2015 at

Re: [WikimediaMobile] In-app editing / talk pages support

2015-07-23 Thread Brian Gerstle
Well played, sir On Thu, Jul 23, 2015 at 4:30 PM, Corey Floyd wrote: > But can the apps' reading experience make the Kessel Run in less than 12 > Parsecs? > > And, quite frankly, we have to remind ourselves that the apps are still > light years away from having a good editing experience. > >

Re: [WikimediaMobile] Wikipedia iOS app moving to GH

2015-07-23 Thread Brian Gerstle
s-covered fork) and hasn't changed much. On Thu, Jul 23, 2015 at 2:04 PM, Greg Grossmeier wrote: > Brian and the Reading team: > > On Wed, Jul 22, 2015 at 3:40 AM, Brian Gerstle > wrote: > >> By using GitHub with Travis CI, the team believes it will work faster, >

Re: [WikimediaMobile] [Wikitech-l] Wikipedia iOS app moving to GH

2015-07-22 Thread Brian Gerstle
This isn't really about Gerrit vs. GitHub. To be clear, we're mainly doing this for CI (i.e. Travis). That said, we (the iOS team) plan for our workflow to play to GitHub's strengths—which also happen to be our personal preferences. In short, this means "amending patches" becomes "pushing another

Re: [WikimediaMobile] [QA] Qualifiers for selecting test articles for vagrant role

2015-07-22 Thread Brian Gerstle
On Wed, Jul 22, 2015 at 2:51 PM, Dan Duvall wrote: > On Wed, Jul 22, 2015 at 10:43 AM, Brian Gerstle > wrote: >> >> >> Also, one neat thing I saw done at Spotify was a "Test Data Service." >> This service's job was to abstract away concrete test data

Re: [WikimediaMobile] In-app editing / talk pages support

2015-07-22 Thread Brian Gerstle
> > But more importantly, you mentioned yourself that talk pages are really > part of the _editing_ experience. And, quite frankly, we have to remind > ourselves that the apps are still light years away from having a good > editing experience. I think Dan Garry was the last person who I heard say

Re: [WikimediaMobile] [QA] Qualifiers for selecting test articles for vagrant role

2015-07-22 Thread Brian Gerstle
iOS in particular would be _very_ interested in this, but would be more than happy to start testing against pages in beta labs or even local fixtures as a baby-step forward. As far as test data being orthogonal to vagrant, they don't have to be coupled. I've had basic experience "pre-baking" elas

[WikimediaMobile] Fwd: [Wikitech-l] Wikipedia iOS app moving to GH

2015-07-22 Thread Brian Gerstle
sorry, didn't hit reply-all. (these lists aren't a subset of each other, are they?) Also, we're losing IRC notifications, but that should be easy enough to add back via fastlane. -- Forwarded message ------ From: Brian Gerstle Date: Wed, Jul 22, 2015 at 12:59

Re: [WikimediaMobile] reading-web board

2015-07-22 Thread Brian Gerstle
On Wed, Jul 22, 2015 at 12:23 PM, Adam Baso wrote: > Okay, I need more coffee! The subject should have been "reading-admin", > not "reading-web"! > > There is a reading-web board, too :) > > On Wed, Jul 22, 2015 at 9:22 AM, Adam Baso wrote: > >> Hi all - just wanted to let you know about >> http

Re: [WikimediaMobile] In-app editing / talk pages support

2015-07-22 Thread Brian Gerstle
Plus, Flow is backed by structured data, right? We apps engineers can't get enough structured data! On Wed, Jul 22, 2015 at 11:30 AM, Amir E. Aharoni < amir.ahar...@mail.huji.ac.il> wrote: > It's probably a dilettante-ish comment, but for a while already Flow has > been working quite well on mobi

Re: [WikimediaMobile] iOS TWN syncs

2015-07-22 Thread Brian Gerstle
gt; >> Let plan on discussing translation impacts on 5.0 after we get moved to >> Github. That we we have our new CI setup in place before making any Phab >> tasks. >> >> >> >> On Wed, Jul 22, 2015 at 6:20 AM, Brian Gerstle >> wrote: >> >>

[WikimediaMobile] Wikipedia iOS app moving to GH

2015-07-22 Thread Brian Gerstle
Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace

Re: [WikimediaMobile] deep-linking in apps

2015-07-13 Thread Brian Gerstle
Not in iOS, currently. We only handle links that are tapped from w/in our own webview. IIRC we have plans to do something w/ deep linking in Q1. On Mon, Jul 13, 2015 at 11:28 AM, Toby Negrin wrote: > Do we support any deep-linking[1] scheme for our apps? I know that we've > made some steps in i

Re: [WikimediaMobile] W3C mobile checker

2015-07-10 Thread Brian Gerstle
Oh, and the source is on GitHub! https://github.com/w3c/Mobile-Checker/ On Fri, Jul 10, 2015 at 10:27 AM, Brian Gerstle wrote: > Here are the results for en.wikipedia.org: > > http://validator.w3.org/mobile-alpha/?url=en.wikipedia.org&profile=tablet > > -- > EN Wiki

[WikimediaMobile] W3C mobile checker

2015-07-10 Thread Brian Gerstle
Here are the results for en.wikipedia.org: http://validator.w3.org/mobile-alpha/?url=en.wikipedia.org&profile=tablet -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wiki

[WikimediaMobile] [ios] Apple Watch sales in trouble?

2015-07-07 Thread Brian Gerstle
Down 90% since launch, according to this article citing "Slice" consumer research: http://www.marketwatch.com/story/apple-watch-may-not-be-ticking-with-customers-2015-07-07 -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle _

Re: [WikimediaMobile] Mobile-Apps' "Unbreak now" tasks in Phabricator

2015-07-06 Thread Brian Gerstle
I closed the iOS ones, which were already in the "Done" column in Phab 2 sprints ago. Sorry for the confusion, still grappling w/ task state transitions vs. columns. On Mon, Jul 6, 2015 at 6:10 PM, Andre Klapper wrote: > Hi, > > could the Apps Team please update their open tasks with "Unbreak N

Re: [WikimediaMobile] [Web] Monday: QA Day

2015-06-26 Thread Brian Gerstle
We just entertained this notion in a mobile apps retro, very curious to hear how it goes! Happy testing :-) On Fri, Jun 26, 2015 at 10:45 AM, Sam Smith wrote: > The Reading Web team will be taking time every Monday to QA the mobile > site. > > We're currently lining up work around improving our

Re: [WikimediaMobile] Mobile content service Phab project

2015-06-24 Thread Brian Gerstle
I'm happy to act as a sounding board for the design of the service, but I don't think we should consider moving to the content service until 5.0 is out. Until then, try to keep us in mind by building well-factored & reusable components :-). On Wed, Jun 24, 2015 at 2:06 PM, Corey Floyd wrote: >

Re: [WikimediaMobile] iOS 4.1.5 released to the App Store

2015-06-24 Thread Brian Gerstle
On Wed, Jun 24, 2015 at 2:13 PM, Brion Vibber wrote: > Congrats on another great release! > > I also see you're going to be dropping iOS 6 support for future releases > -- that'll allow adding code in Swift, > Indeed! It's starting already :-) > and might mean I can upgrade some of the network

Re: [WikimediaMobile] [ios] iOS Test Cases regression spreadsheet updated for 4.1.5

2015-06-23 Thread Brian Gerstle
; which is an evolving thing, is documented at >>> https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process. >>> Enjoy! >>> >>> -Adam >>> >>> >>> >>> On Sat, Jun 20, 2015 at 6:11 AM, Brian Gerstle >>> wrote: >&

Re: [WikimediaMobile] [ios] iOS Test Cases regression spreadsheet updated for 4.1.5

2015-06-20 Thread Brian Gerstle
ue, Jun 9, 2015 at 9:28 AM, Adam Baso wrote: > >> Moving over to mobile-l. >> >> >> On Monday, June 8, 2015, Brian Gerstle wrote: >> >>> Hey all, >>> >>> I've added some tests to our regression document in preparation for

Re: [WikimediaMobile] WebM/Ogg playback: testing energy usage on iOS

2015-06-19 Thread Brian Gerstle
Any idea if your work would also support dynamic bitrate switching? On Fri, Jun 19, 2015 at 12:57 PM, James Forrester wrote: > On 19 June 2015 at 02:08, Brion Vibber wrote: > >> One of the reasons we've always worried about using the open Ogg and WebM >> formats on iPhones and iPads is that we

[WikimediaMobile] new features in swift 2

2015-06-13 Thread Brian Gerstle
Looks like Swift 2 is going to lean more on exceptions than returning (and out-param'ing) errors: http://www.hackingwithswift.com/new-features-swift-2 -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-

[WikimediaMobile] great list of what's new in iOS

2015-06-09 Thread Brian Gerstle
http://iosdevtips.co/post/12105365/wwdc-ios-9-swift-2-notes Generics in Objective-C! Better handling of unavailable APIs! Cool new animation APIs! Not mentioned, but hope to dive in soon, UI Testing! -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle

Re: [WikimediaMobile] Caching headers in the apps

2015-06-03 Thread Brian Gerstle
d up and polished. > > Brian, from what I heard you say yesterday, the sitematrix and siteinfo > stuff shouldn't be too risky. Interested in tackling the PHP? Need a > pairing partner? > > -Adam > > > On Wednesday, June 3, 2015, Brian Gerstle wrote: > >> Also,

Re: [WikimediaMobile] Caching headers in the apps

2015-06-03 Thread Brian Gerstle
Side note, do we need a lot of these headers? X-Powered-By: HHVM/3.6.1 X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN > X-Varnish: 2583358918, 1834266080 > Via: 1.1 varnish, 1.1 varnish > X-Cache: cp1047 miss (0), cp1060 frontend miss (0) > X-Analytics: https=1 > Set-Cookie: WMF-Las

Re: [WikimediaMobile] Caching headers in the apps

2015-06-03 Thread Brian Gerstle
61>. On Wed, Jun 3, 2015 at 10:09 AM, Brian Gerstle wrote: > Side note, do we need a lot of these headers? > > X-Powered-By: HHVM/3.6.1 > > X-Content-Type-Options: nosniff > > X-Frame-Options: SAMEORIGIN >> X-Varnish: 2583358918, 1834266080 >> Via: 1.1 var

[WikimediaMobile] handling HTML in native apps

2015-06-02 Thread Brian Gerstle
I've been thinking about our client-side strategy, and it just occurred to me that I should check out other open source projects. WordPress seems to be using DTCoreText in their iO

Re: [WikimediaMobile] mobile wikipedia with service worker

2015-05-30 Thread Brian Gerstle
Great video, thanks for sharing! "...the javascript then goes to the Wikipedia API to get the data—*plus a few alterations*." Someone should tell him about Parsoid! Too bad ServiceWorker isn't really supported on mobile

Re: [WikimediaMobile] maps w/ nearby

2015-05-27 Thread Brian Gerstle
te: > Any reason to import a 3rd party library for functionality built in to the > iOS SDK? Seems like work to explore/integrate a dependency where none is > needed. Without this extra work, this is something that can be built in < 1 > day. > > > > On Wed, May 27, 2015 at 10

Re: [WikimediaMobile] maps w/ nearby

2015-05-27 Thread Brian Gerstle
Cool, looks like mapbox has an iOS SDK . Is there somewhere that the progress on funding is being tracked? Put another way, where should I direct PM, design, etc. to get this prioritized? Also, I think it'd be worth it to ship this to a percentage of users

[WikimediaMobile] hacks I particularly liked at Lyon

2015-05-26 Thread Brian Gerstle
Hey everyone, Just wanted to send my notes on the hack demos from this weekend, and potentially start a discussion about shipping some of them! *Apple Watch: *Corey & Jason did an incredible job on this, and I'm essentially sold that a watch companion app could augment our *read later* and *searc

Re: [WikimediaMobile] maps w/ nearby

2015-05-26 Thread Brian Gerstle
Bernd did an OSM-based map feature for Android as well. On Tue, May 26, 2015 at 2:17 PM, Tomasz Finc wrote: > CC'ing Max and Yuvi since they've been working on Maps. > > --tomasz > > On Tue, May 26, 2015 at 11:15 AM, Brian Gerstle > wrote: > > The hackath

[WikimediaMobile] maps w/ nearby

2015-05-26 Thread Brian Gerstle
The hackathon and a recent comment on a great GitHub pull request (which we received almost a year ago) have gotten me thinking about maps. Did we ever find a maps provider? Regards, Brian -- EN Wikipedia user page: https://en.wikipedia.

Re: [WikimediaMobile] Hackathon: mobile apps meeting needs?

2015-05-13 Thread Brian Gerstle
Adam, did you ever reach out to CocoaHeads? I don't see any mobile devs in the list of people looking for buddies . I might try to solicit some people as well. On Thu, May 7, 2015 at 1:09 PM, Adam Baso wrote: > Hi all - Quim asked

Re: [WikimediaMobile] User Testing

2015-05-06 Thread Brian Gerstle
We should also take a "look" at lookback.io. I know the guy who started it, so if there are any issues w/ licensing/privacy I can try reaching out to him. On Wed, May 6, 2015 at 2:03 PM, Corey Floyd wrote: > Good read on how to conduct user testing. We are doing more prototyping > now, so its ni

[WikimediaMobile] Wikipedia iOS Beta 4.1.3.96

2015-05-01 Thread Brian Gerstle
Is now available for testing! Please download it by opening the TestFlight application on your iOS device. You can access the source code revision by checking out the 4.1.3.96 tag from the gerrit repository. Thanks again for your help! Brian -- EN Wikipedia user page: https://en.wikipedia.org

Re: [WikimediaMobile] Skynet is winning the battle on IRC

2015-04-30 Thread Brian Gerstle
o implement this. >> >> I think moving to a new channel seems like an easy solution. Nothing >> gets missed provided people know to join it and nothing needs to be >> implemented. >> >> On Thu, Apr 30, 2015 at 11:36 AM, Bahodir Mansurov >> wrote: >> >

Re: [WikimediaMobile] Skynet is winning the battle on IRC

2015-04-30 Thread Brian Gerstle
Totally agree, having *important messages only* in IRC would be nice. Another idea would be to have notifs go to more specific chat rooms based on the project. On Thu, Apr 30, 2015 at 1:45 PM, Corey Floyd wrote: > I think this is a good idea… the only thing I think should be in the main > channe

Re: [WikimediaMobile] API Phabricator cards, list threads, other

2015-04-29 Thread Brian Gerstle
Great thinking, Jon! I'm sure that didn't even catch everything. I know there are some comments like that in the iOS repo, but aren't as easy to detect. Would be great if each client had a system for flagging & cataloging this kind of tech debt. On Wed, Apr 29, 2015 at 2:03 PM, Jon Robson wrote:

Re: [WikimediaMobile] Moderation tools [was Re: Commons Reloaded]

2015-04-22 Thread Brian Gerstle
Yes, the announcement was encouraging! I'm sure we'll be in touch when these issues surface again after the reorg dust settles :-) On Wed, Apr 22, 2015 at 1:48 PM, Luis Villa wrote: > On Wed, Apr 15, 2015 at 11:16 AM, Jon Robson wrote: > >> > I'm just troubled by some of the language used here

Re: [WikimediaMobile] Commons Reloaded

2015-04-15 Thread Brian Gerstle
non-skippable video? I guess if the comms team and legal > team got involved such a video could be usable in a lot of other use cases > too. > > /Jan Ainali > > > >> > Tänk dig en värld där varje människa har fri tillgång till >> mänsklighetens samlade kunskap.

Re: [WikimediaMobile] Commons Reloaded

2015-04-15 Thread Brian Gerstle
he actual upload to Commons >> happen? >> > >> >> Yeh this is definitely an option but we don't have infrastructure for >> this for images... >> > Med vänliga hälsningar, >> > Jan Ainali >> > >> > Verksamhetschef, Wikimedia Sverige &g

Re: [WikimediaMobile] Commons Reloaded

2015-04-15 Thread Brian Gerstle
> > Because Commons is afraid of the massive influx of selfies that will then > have to be deleted, binding admin time and upsetting the uploader (who is, > likely, not aware of the Commons policies). > As was said before in this thread, some filtering at the source > (smartphone) will have to be

Re: [WikimediaMobile] Commons Reloaded

2015-04-14 Thread Brian Gerstle
>From the README: "Wikimedia Foundation doesn't care anymore, but we do." Maybe we can fold some of the Commons functionality into the main app as we ramp up contribution flows? On Tue, Apr 14, 2015 at 4:45 PM, James Alexander wrote: > Awesome! > > /Downloads/ > > James Alexander > Community

Re: [WikimediaMobile] Wikipedia Android App running with ARC Welder on OSX

2015-04-03 Thread Brian Gerstle
I saw Ars' article about ARC, interesting stuff. Glad it doesn't run on iOS or I'd be out of a job! On Friday, April 3, 2015, Tomasz Finc wrote: > I just took Googles new Chrome/Android (LLVM & Arc) bridge "ARC > Welder" for a spin with the Wikipedia Android App and I've very > impressed with ho

Re: [WikimediaMobile] DHH Testing Key Note at Railsconf 2014

2015-04-02 Thread Brian Gerstle
he "driven" > aspect of it. It doesn't strictly mean red/green/refactor. > - Don't trip on % coverage. > - Tests are just as subjectively written as the rest of your code. > Don't test yourself into a false bubble, a tautological hellscape of > antipatterns

Re: [WikimediaMobile] [Apps] [iOS] XCActionBar

2015-04-02 Thread Brian Gerstle
There's also the XVim plugin which turns the Xcode editor into vim, which can do a lot of these things. On Thu, Apr 2, 2015 at 2:03 PM, Corey Floyd wrote: > So this is just absolutely amazing… > > https://github.com/pdcgomes/XCActionBar > > Install as fast as possible… > > > -- > Corey Floyd > S

Re: [WikimediaMobile] [Apps] [iOS] XCActionBar

2015-04-02 Thread Brian Gerstle
But this has a lot of nice built-in macros too... *installing* On Thu, Apr 2, 2015 at 2:10 PM, Brian Gerstle wrote: > There's also the XVim plugin which turns the Xcode editor into vim, which > can do a lot of these things. > > On Thu, Apr 2, 2015 at 2:03 PM, Corey Floyd wrote

Re: [WikimediaMobile] DHH Testing Key Note at Railsconf 2014

2015-04-01 Thread Brian Gerstle
+1 for the follow-up of the "Is TDD Dead?" On Wed, Apr 1, 2015 at 1:17 PM, Sam Smith wrote: > There's a great set of recorded hangouts between Kent Beck, Martin Fowler, > and DHH titled "Is TDD dead?": > http://martinfowler.com/articles/is-tdd-dead/ > > As with that talk, I'd highly encourage yo

[WikimediaMobile] iOS Engineering Review Meeting

2015-03-27 Thread Brian Gerstle
Hey everyone, The iOS engineers had our regular "review" meeting today, where we discuss team practices and topics in the industry. We've started taking minutes for future reference, and of course to keep in touch with all of you! The main page for the meeting is Wikimedia_Apps/Team/iOS/Enginee

Re: [WikimediaMobile] maps on iOS

2015-03-20 Thread Brian Gerstle
be added lated - I feel it's > a great way to point users to what free content has to offer by now. > > Let me know. > > Best, Ulf > > > On 20/03/15 16:10, Brian Gerstle wrote: > > Ulf, thanks bring me up to speed. I'd love to make this happen, so I've

Re: [WikimediaMobile] Speed

2015-03-20 Thread Brian Gerstle
y sort of achieve the > same, but was curious about simple ways to test on physical devices. > > -Adam > > > On Fri, Mar 20, 2015 at 7:27 AM, Brian Gerstle > wrote: > >> Two-step loading could be one viable approach. However, as with any >> optimizations, I

Re: [WikimediaMobile] maps on iOS

2015-03-20 Thread Brian Gerstle
. We can add a lot of user value with other features, and in this case simply prompt the user with an "Open With..." dialog to view it in an app of their choice. This shouldn't be necessary, as we can render maps in the Wikipedia app without requiring user location. > > Best, Ul

Re: [WikimediaMobile] maps on iOS

2015-03-20 Thread Brian Gerstle
Adding a native map view to display nearby locations on a map sounds like a great feature! Are there any links to mock-ups of what the feature is supposed to look like? I ask because it's not clear why we need custom map tiles or URL protocols instead of simple annotations & annotation views. The

Re: [WikimediaMobile] Speed

2015-03-20 Thread Brian Gerstle
Two-step loading could be one viable approach. However, as with any optimizations, I would prefer to conduct an investigation (or see data from a previous one) about what page loading stages are taking the longest. This can be a combination of loading a few sample articles with the Safari inspecto

Re: [WikimediaMobile] [ios] nullable annotations in Xcode 6.3!!

2015-03-16 Thread Brian Gerstle
gt; 6.3 is out...unless someone can figure out a way to allow such annotations > in the stable 6.2 version. > > On Sat, Mar 14, 2015 at 11:24 PM, Monte Hurd > wrote: > >> Cool! +1 to setting "Xcode 6.3 as the *minimum* *supported* Xcode >> version" >> &

[WikimediaMobile] [ios] nullable annotations in Xcode 6.3!!

2015-03-14 Thread Brian Gerstle
iOS devs can finally claim functionality that our Java counterparts have been taking for granted: "nullable" annotations in ObjC which transfer to Optional Swift types ! I hope we can start using these in our app ASAP. It will help ObjC dev efforts a

Re: [WikimediaMobile] [Apps] Improving Android release cadence

2015-03-12 Thread Brian Gerstle
ssue to enabling features). >>> >>> Still - I think the feature flag solution has promise - but I am way >>> more interested in it if we do it as run time option to get the testing/QA >>> benefits. >>> >>> >>> On Wed, Mar 11, 2015 at 4:

Re: [WikimediaMobile] Node.js service prototype for mobileapps

2015-03-12 Thread Brian Gerstle
> > It's less about it being not appropriate for perf tests and more so > that you can't directly compare bare metal to a virtual instance. Load > testing virts against virts is fine as long as your factor the drift > in shared resourcing. Agree that it's not apples to apples, but can't you still

Re: [WikimediaMobile] [Apps] Improving Android release cadence

2015-03-11 Thread Brian Gerstle
Listened to it this morning, gotta say I think I'm on "Team Flag," if it's done well. IMO we should try one (or both) and see how it goes. Here's my take on each approach: Branches are cheap to implement, but come at the a potentially high cost if you don't continually rebase and try to keep the

Re: [WikimediaMobile] Mobile Scale

2015-03-11 Thread Brian Gerstle
Objc.io is awesome, thanks for sharing Corey! On Wed, Mar 11, 2015 at 3:26 PM, Corey Floyd wrote: > Well specifically iOS… but most of the articles in this issue are about > process and how they collaborate. > > I highly recommend checking out when you have a moment. They are pretty > quick read

Re: [WikimediaMobile] iOS app: Xcode "Simulator already in use" message when trying to run project...

2015-03-10 Thread Brian Gerstle
Ditto, running Xcode 6.1.1. Not sure why this is suddenly a problem, wonder if it has anything to do w/ HockeyApp... On Tue, Mar 10, 2015 at 2:27 PM, Monte Hurd wrote: > I've run into this quite a bit, and it's super annoying as, once this > message is shown, it seems Xcode can't run the projec

Re: [WikimediaMobile] Node.js service prototype for mobileapps

2015-03-02 Thread Brian Gerstle
Thanks Bernd, can't wait to take a closer look at this! On Mon, Mar 2, 2015 at 3:56 PM, Bernd Sitzmann wrote: > Hi, > > As part of the Node.js prototype spike > , > I created a Github repo: >

Re: [WikimediaMobile] Follow up on services meeting

2015-02-24 Thread Brian Gerstle
> > If I'm not mistaken, the thought is that if this relatively simpler > service experiment goes well, then it will make sense to go ahead with > pursuit of the bigger composite service (and probably a suite of services > in due time). > >> Right, so we both agree we should start simplest—I just f

Re: [WikimediaMobile] Follow up on services meeting

2015-02-24 Thread Brian Gerstle
Thanks for the update! Just a couple questions/comments: On Tue, Feb 24, 2015 at 2:17 PM, Adam Baso wrote: > Bernd, Dmitry, and I met with Gabriel and Marko from the services team. > Notes: > > * Bernd to use https://github.com/wikimedia/service-template-node as a > starting point > * Gabriel, M

Re: [WikimediaMobile] Masonry (iOS 3rd party library)

2015-02-19 Thread Brian Gerstle
ng regular layout constraints so it's just the setup >>>>> calls that are different... >>>>> >>>>> -- brion >>>>> >>>>> On Wed, Feb 18, 2015 at 2:59 PM, Monte Hurd >>>>> wrote: >>>>> >>>

Re: [WikimediaMobile] Masonry (iOS 3rd party library)

2015-02-18 Thread Brian Gerstle
+1 On Wed, Feb 18, 2015 at 12:32 PM, Corey Floyd wrote: > We were evaluating Masonry prior to our new 3rd party lib vetting process (See > here for more info: > https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries), > but still wanted to do a write up for everyone. > > Ma

Re: [WikimediaMobile] iOS code style

2015-02-13 Thread Brian Gerstle
Sorry, forgot the link: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/ObjectiveCStyleGuide On Fri, Feb 13, 2015 at 6:17 PM, Brian Gerstle wrote: > After a meeting in which the team reviewed Corey's suggested coding style > guidelines, I've made the following edits: >

[WikimediaMobile] iOS code style

2015-02-13 Thread Brian Gerstle
After a meeting in which the team reviewed Corey's suggested coding style guidelines, I've made the following edits: - Use of dot-notation for instance methods that are cheap & free of side-effects - Added note about auto-trimming trailing whitespace via Xcode settings - More "if" stat

Re: [WikimediaMobile] Blockskit (iOS App 3rd Party Library)

2015-02-13 Thread Brian Gerstle
I love the first-person perspective. Glad to have you BK! On Fri, Feb 13, 2015 at 3:40 PM, Adam Baso wrote: > Great writeup. I don't have any reservations. > > -Adam > > On Fri, Feb 13, 2015 at 12:14 PM, Corey Floyd > wrote: > >> (Testing out our new 3rd party library vetting: >> https://www.me

Re: [WikimediaMobile] [Apps] Scope of the apps content service

2015-02-05 Thread Brian Gerstle
I forgot to fill in my "*" next to "app services." The name is not a great one, and I'm open to suggestions that are more specific or intuitive. On Thu, Feb 5, 2015 at 4:04 PM, Brian Gerstle wrote: > In an effort to avoid yet another mega thread, I went ahead and

Re: [WikimediaMobile] [Apps] Scope of the apps content service

2015-02-05 Thread Brian Gerstle
In an effort to avoid yet another mega thread, I went ahead and created a Wiki page under the apps space which holds the problems & requirements for app services *. There's even a discussion page

Re: [WikimediaMobile] Face detection service?

2015-02-03 Thread Brian Gerstle
stick it in WikiData somehow? >> * or - use a parser function on the image description page that saves the >> coords to page props table >> >> Using a parser function is relatively straightforward to implement, and a >> pretty UI could be made to set the coordinates wi

Re: [WikimediaMobile] Face detection service?

2015-02-03 Thread Brian Gerstle
In general, I just want an API that provides a way to get & set cropping of images in different scenarios. As clever as it sounds to wrap some algo in a service, it won't cover all cropping cases (just faces at first) and will probably need a way for users to fine tune it anyway. TL;DR; +1 but I

Re: [WikimediaMobile] [Apps] Wikipedia Lite app?

2015-01-30 Thread Brian Gerstle
Love the idea, and I agree with everything Monte said. We might also need to drop some 3rd party libs to go super-ultra light, depending on their size. Quick inspection shows the following: - AFNetworking: ~500 KB - hpple: 41 KB We'll need to be careful adding too many other frameworks t