Hey,
On Mon, May 22, 2017 at 7:49 AM, Torsten Hilbrich
wrote:
> This series of patches is based on the "Logging and --help
> updates" series posted by Aleksander Morgado
> .
>
> It start with cleaning up some parts of the logging code. The the
> existing logging support (supporting syslog and fil
Hey,
On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado
wrote:
> The --debug output is a bit annoying right now because it includes the
> function location information by default. This information is most of
> the times not very useful, so just make it optional under a new
> command line argume
> On 22 May 2017 at 09:14 Aleksander Morgado wrote:
>
> Hey,
>
> On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado
> wrote:
>
> > The --debug output is a bit annoying right now because it includes the
> > function location information by default. This information is most of
> > the times n
> On 21 May 2017 at 13:54 Aleksander Morgado wrote:
>
> Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
> Mobile Equipment Event Reporting. We now query the device for the
>
> supported formats and use that info to build commands that will work.
>
I've just tried this set
---
Hey Carlo,
It's never too late :)
I couldn't reproduce the issue with the SIM hot swap changes you were trying,
because none of my Telit modems here were able to support it properly, so I
ended up re-reviewing the logs you sent and I believe I found the issue.
When the SIM is already unlo
On Mon, May 22, 2017 at 12:36 PM, Colin Helliwell
wrote:
>> Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
>> Mobile Equipment Event Reporting. We now query the device for the
>>
>> supported formats and use that info to build commands that will work.
>>
>
> I've just tried t
> On 22 May 2017 at 12:22 Aleksander Morgado wrote:
>
> On Mon, May 22, 2017 at 12:36 PM, Colin Helliwell
>
> wrote:
>
> > > Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
> > > Mobile Equipment Event Reporting. We now query the device for the
> > >
> > > supported form
---
Hey,
(resent to include in CC the mailing list)
This v2 patch includes a correct "underscore_name" for the new enums defined in
the helpers header, needed if we want to use the _build_string_from_mask()
methods.
Cheers,
---
src/mm-modem-helpers.c | 136 ++
Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
Mobile Equipment Event Reporting. We now query the device for the
supported formats and use that info to build commands that will work.
---
Hey Colin,
This patch fixes a check for +CMER mode 1, and includes additional logging to
> On 22 May 2017 at 12:47 Aleksander Morgado wrote:
>
> Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
> Mobile Equipment Event Reporting. We now query the device for the
>
> supported formats and use that info to build commands that will work.
>
> ---
>
> Hey Colin,
>
---
Hey Colin,
Please try now with this v3 patch. I modified the helper method to allow the
comma-separated number sequence you get in your EHS5 for the modes, i.e.:
"(1,2)". The regex wasn't catching that logic, so instead of complicating it
too much, I switched to splitting the response into
Hey,
> Carlo, any chance you can make a quick test with these patches to see
> if they work as expected in the Telit modems? One of the changes I
> see is that the Telit plugin previously did the AT+CMER command only
> in the secondary port, while now we do it in both primary and
> secondary, not
> On 22 May 2017 at 13:43 Aleksander Morgado wrote:
>
> ---
>
> Hey Colin,
>
> Please try now with this v3 patch. I modified the helper method to allow the
> comma-separated number sequence you get in your EHS5 for the modes, i.e.:
> "(1,2)". The regex wasn't catching that logic, so instead
On Mon, May 22, 2017 at 3:38 PM, Carlo Lobrano wrote:
>> Carlo, any chance you can make a quick test with these patches to see
>> if they work as expected in the Telit modems? One of the changes I
>> see is that the Telit plugin previously did the AT+CMER command only
>> in the secondary port, whi
On Mon, May 22, 2017 at 3:50 PM, Colin Helliwell
wrote:
> But do bear in mind that I don't have any conviction about what 'CMER' the
> EHS5 actually supports, because it's AT doc doesn't mention the command at
> all - by rights it shouldn't even respond at all to the '?'.
> I've asked the questi
On Sun, 2017-05-21 at 21:51 +0200, Aleksander Morgado wrote:
> ---
>
> Hey,
>
> This patch implements some basic support for changing allowed modes
> for LTE capable Cinterion devices.
LGTM.
Dan
> Comments?
>
> ---
> plugins/cinterion/mm-broadband-modem-cinterion.c | 162 +++
> -
>
> ...do quite often find the function location useful. But I don't mind
> patching it back in for myself if the consensus is to remove it for
> mainstream.
When I was starting out I also found it very helpful, but I think if there
was a patch or something for others off to the side then it's fin
On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote:
> We also remove the explicit refresh request from the Cinterion
> plugin,
> as this is a generic action applicable to all modems that require
> polling for signal quality and/or access technology.
Should the poll interval get reset to f
On 22 May 2017 at 17:15, Aleksander Morgado
wrote:
> Maybe, yes, although that shouldn't be an issue in most cases.
I see. Anyway, the patch works fine for me, no issues observed.
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedes
On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote:
> If the modem supports ^SIND psinfo reporting, we enable the URC and
> flag the access technology polling unsupported, so that we only update
> access technology via the +CIEV URCs.
>
> E.g.:
>
> (ttyACM1): --> 'AT^SIND="psinfo",1'
On Thu, 2017-05-18 at 10:15 +0200, Aleksander Morgado wrote:
> The whitelist made all platform TTYs managed by the 'atmel_usart'
> kernel driver probed by ModemManager, which isn't something we want,
> as most of these aren't broadband modems.
>
> We leave the logic supporting the ID_MM_PLATFORM_D
On Sun, 2017-05-21 at 15:41 +0200, Aleksander Morgado wrote:
> On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado
> wrote:
> > +/* Our own enable now */
> > +mm_base_modem_at_command_full (
> > MM_BASE_MODEM (self),
> > mm_base_modem_peek_port_secondary (MM_BASE_MODEM (s
LGTM, for syntax & control flow. Like the idea but I'm biased on this one ;)
On Sun, May 21, 2017 at 1:49 PM, Aleksander Morgado <
aleksan...@aleksander.es> wrote:
> Plugins have two ways to update signal quality and access technology
> values: via unsolicited messages or via polling periodically
On Mon, May 22, 2017 at 5:46 PM, Dan Williams wrote:
>> We also remove the explicit refresh request from the Cinterion
>> plugin,
>> as this is a generic action applicable to all modems that require
>> polling for signal quality and/or access technology.
>
> Should the poll interval get reset to f
On Mon, May 22, 2017 at 6:09 PM, Dan Williams wrote:
>> And now that I see this...
>> * Shouldn't we enable +CIEV only for "signal" (that's the only thing
>> we end up parsing in the generic +CIEV parser)?
>> * Shouldn't we move this setting to the generic broadband modem
>> implementation?
>
>
On Mon, May 22, 2017 at 6:06 PM, Dan Williams wrote:
>> The whitelist made all platform TTYs managed by the 'atmel_usart'
>> kernel driver probed by ModemManager, which isn't something we want,
>> as most of these aren't broadband modems.
>>
>> We leave the logic supporting the ID_MM_PLATFORM_DRIV
On Mon, May 22, 2017 at 6:02 PM, Dan Williams wrote:
> On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote:
>> If the modem supports ^SIND psinfo reporting, we enable the URC and
>> flag the access technology polling unsupported, so that we only update
>> access technology via the +CIEV UR
Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable
Mobile Equipment Event Reporting. We now query the device for the
supported formats and use that info to build commands that will work.
---
This v3 adds some additional log messages to specify which CMER settings are
selected.
On Mon, May 22, 2017 at 5:24 PM, Dan Williams wrote:
>> This patch implements some basic support for changing allowed modes
>> for LTE capable Cinterion devices.
>
> LGTM.
Just realized that this patch depends on some other patch I also sent
(the one removing the signal access tech refreshes from
29 matches
Mail list logo
