Re: [Patch mp2] Fix api/module test to pass on static builds

2004-05-07 Thread Geoffrey Young
Actually, I can't think of a good reason why checking for 'module.so' and not 'module.c' would make sense. Hmm, may be someone will want to know that it was loaded as DSO. Yeah, I can't think really why, but that's what .so would be for. really?

[Patch mp2] Fix api/module test to pass on static builds

2004-05-06 Thread Philippe M. Chiasson
Stas Bekman wrote: Here are the results you asked for : t/TEST -clean t/TEST -v t/api/module.t t/apr/netlib.t t/compat/conn_rec.t t/modperl/setupenv.t t/preconnection/note.t Thanks. So it all comes down to two issues. 1) Apache::Module::loaded('mod_perl.so')

Re: [Patch mp2] Fix api/module test to pass on static builds

2004-05-06 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: Here are the results you asked for : t/TEST -clean t/TEST -v t/api/module.t t/apr/netlib.t t/compat/conn_rec.t t/modperl/setupenv.t t/preconnection/note.t Thanks. So it all comes down to two issues. 1) Apache::Module::loaded('mod_perl.so')

Re: [Patch mp2] Fix api/module test to pass on static builds

2004-05-06 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: Here are the results you asked for : t/TEST -clean t/TEST -v t/api/module.t t/apr/netlib.t t/compat/conn_rec.t t/modperl/setupenv.t t/preconnection/note.t Thanks. So it all comes down to two issues. 1)

Re: [Patch mp2] Fix api/module test to pass on static builds

2004-05-06 Thread Stas Bekman
Philippe M. Chiasson wrote: That's correct, and really, it's a borked test then. It did pass for me once strangely, as I managed to have 2 mod_perls in my httpd, a static one and a dso loaded one ( can't reproduce that, lol) Shouldn't loaded() be fixed instead to tell you whether mod_perl is