Philippe M. Chiasson wrote:

That's correct, and really, it's a borked test then. It did pass for me once
strangely, as I managed to have 2 mod_perls in my httpd, a static one and a dso
loaded one ( can't reproduce that, lol)


Shouldn't loaded() be fixed instead to tell you whether mod_perl is linked? Or was the idea for it to work only for DSO modules?


No, you can chose to check for a DSO module with ->loaded('module.so').
But you can also check for a module with ->loaded('module.c') and that will
be true for both static or dso loaded modules.

So most likely you always want to check for .c

If it doesn't I can't see any value in this API, since to check mod_perl you can check $ENV{MOD_PERL} and to check for any other module, you can't really say that the module is not available if its linked statically. No?


Yes, for mod_perl you can check $ENV{MOD_PERL}, but let's say you want to know
if mod_autoindex is installed, you check for ->loaded('mod_autoindex.c') and
this will work.

Actually, I can't think of a good reason why checking for 'module.so' and not
'module.c' would make sense.

Hmm, may be someone will want to know that it was loaded as DSO.

Please commit that patch. Thanks.


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Reply via email to